@optave/codegraph 3.11.2 → 3.12.0

package/src/extractors/kotlin.ts

@@ -102,7 +102,7 @@ function collectKotlinEnumEntries(node: TreeSitterNode): SubDeclaration[] {
   if (!body) return entries;
   for (let i = 0; i < body.childCount; i++) {
     const child = body.child(i);
-    if (!child || child.type !== 'enum_entry') continue;
+    if (child?.type !== 'enum_entry') continue;
     const entryName = findChild(child, 'simple_identifier');
     if (entryName) {
       entries.push({
@@ -122,7 +122,7 @@ function collectKotlinProperties(node: TreeSitterNode): SubDeclaration[] {
   if (!body) return props;
   for (let i = 0; i < body.childCount; i++) {
     const child = body.child(i);
-    if (!child || child.type !== 'property_declaration') continue;
+    if (child?.type !== 'property_declaration') continue;
     const varDecl = findChild(child, 'variable_declaration');
     if (!varDecl) continue;
     const id = findChild(varDecl, 'simple_identifier');
@@ -144,7 +144,7 @@ function collectKotlinMethods(node: TreeSitterNode, className: string, ctx: Extr
   if (!body) return;
   for (let i = 0; i < body.childCount; i++) {
     const child = body.child(i);
-    if (!child || child.type !== 'function_declaration') continue;
+    if (child?.type !== 'function_declaration') continue;
     const methName = findChild(child, 'simple_identifier');
     if (methName) {
       const params = extractKotlinParameters(child);
@@ -168,7 +168,7 @@ function collectKotlinInheritance(
 ): void {
   for (let i = 0; i < node.childCount; i++) {
     const child = node.child(i);
-    if (!child || child.type !== 'delegation_specifier') continue;
+    if (child?.type !== 'delegation_specifier') continue;
 
     // constructor_invocation > user_type > type_identifier (extends)
     const ctorInvocation = findChild(child, 'constructor_invocation');
@@ -294,7 +294,7 @@ function extractKotlinParameters(funcNode: TreeSitterNode): SubDeclaration[] {
   if (!paramList) return params;
   for (let i = 0; i < paramList.childCount; i++) {
     const param = paramList.child(i);
-    if (!param || param.type !== 'parameter') continue;
+    if (param?.type !== 'parameter') continue;
     const nameNode = findChild(param, 'simple_identifier');
     if (nameNode) {
       params.push({ name: nameNode.text, kind: 'parameter', line: param.startPosition.row + 1 });

package/src/extractors/lua.ts

@@ -90,7 +90,7 @@ function extractLuaParams(funcNode: TreeSitterNode): SubDeclaration[] {
 
   for (let i = 0; i < paramList.childCount; i++) {
     const param = paramList.child(i);
-    if (!param || param.type !== 'identifier') continue;
+    if (param?.type !== 'identifier') continue;
     params.push({ name: param.text, kind: 'parameter', line: param.startPosition.row + 1 });
   }
   return params;

package/src/extractors/objc.ts

@@ -468,7 +468,7 @@ function extractPropertyName(propNode: TreeSitterNode): string | null {
   if (!structDecl) return null;
   for (let i = 0; i < structDecl.childCount; i++) {
     const child = structDecl.child(i);
-    if (!child || child.type !== 'struct_declarator') continue;
+    if (child?.type !== 'struct_declarator') continue;
     const id = findIdentifierDeep(child);
     if (id) return id.text;
   }
@@ -494,7 +494,7 @@ function extractMethodParams(methodNode: TreeSitterNode): SubDeclaration[] {
   const params: SubDeclaration[] = [];
   for (let i = 0; i < methodNode.childCount; i++) {
     const child = methodNode.child(i);
-    if (!child || child.type !== 'method_parameter') continue;
+    if (child?.type !== 'method_parameter') continue;
     let nameNode: TreeSitterNode | null = null;
     for (let j = 0; j < child.childCount; j++) {
       const inner = child.child(j);
@@ -516,7 +516,7 @@ function extractCParams(paramListNode: TreeSitterNode | null): SubDeclaration[]
   if (!paramListNode) return params;
   for (let i = 0; i < paramListNode.childCount; i++) {
     const param = paramListNode.child(i);
-    if (!param || param.type !== 'parameter_declaration') continue;
+    if (param?.type !== 'parameter_declaration') continue;
     const nameNode = param.childForFieldName('declarator');
     if (nameNode) {
       const name = unwrapObjCDeclaratorName(nameNode);

package/src/extractors/ocaml.ts

@@ -168,7 +168,7 @@ function handleOCamlTypeDef(node: TreeSitterNode, ctx: ExtractorOutput): void {
   // type_definition contains one or more type_bindings
   for (let i = 0; i < node.childCount; i++) {
     const child = node.child(i);
-    if (!child || child.type !== 'type_binding') continue;
+    if (child?.type !== 'type_binding') continue;
 
     const nameNode =
       child.childForFieldName('name') ||

package/src/extractors/php.ts

@@ -36,7 +36,7 @@ function extractPhpParameters(fnNode: TreeSitterNode): SubDeclaration[] {
 function extractPhpProperties(member: TreeSitterNode, children: SubDeclaration[]): void {
   for (let j = 0; j < member.childCount; j++) {
     const el = member.child(j);
-    if (!el || el.type !== 'property_element') continue;
+    if (el?.type !== 'property_element') continue;
     const varNode = findChild(el, 'variable_name');
     if (varNode) {
       children.push({
@@ -53,7 +53,7 @@ function extractPhpProperties(member: TreeSitterNode, children: SubDeclaration[]
 function extractPhpConstants(member: TreeSitterNode, children: SubDeclaration[]): void {
   for (let j = 0; j < member.childCount; j++) {
     const el = member.child(j);
-    if (!el || el.type !== 'const_element') continue;
+    if (el?.type !== 'const_element') continue;
     const nameNode = el.childForFieldName('name') || findChild(el, 'name');
     if (nameNode) {
       children.push({

package/src/extractors/python.ts

@@ -291,7 +291,7 @@ function extractClassAssignment(
   const assignment = findChild(child, 'assignment');
   if (!assignment) return;
   const left = assignment.childForFieldName('left');
-  if (!left || left.type !== 'identifier' || seen.has(left.text)) return;
+  if (left?.type !== 'identifier' || seen.has(left.text)) return;
   seen.add(left.text);
   props.push({
     name: left.text,
@@ -308,7 +308,7 @@ function extractInitProperties(
   props: SubDeclaration[],
 ): void {
   const fnName = node.childForFieldName('name');
-  if (!fnName || fnName.text !== '__init__') return;
+  if (fnName?.text !== '__init__') return;
   const initBody = node.childForFieldName('body') || findChild(node, 'block');
   if (initBody) walkInitBody(initBody, seen, props);
 }
@@ -342,11 +342,11 @@ function extractPythonClassProperties(classNode: TreeSitterNode): SubDeclaration
 function walkInitBody(bodyNode: TreeSitterNode, seen: Set<string>, props: SubDeclaration[]): void {
   for (let i = 0; i < bodyNode.childCount; i++) {
     const stmt = bodyNode.child(i);
-    if (!stmt || stmt.type !== 'expression_statement') continue;
+    if (stmt?.type !== 'expression_statement') continue;
     const assignment = findChild(stmt, 'assignment');
     if (!assignment) continue;
     const left = assignment.childForFieldName('left');
-    if (!left || left.type !== 'attribute') continue;
+    if (left?.type !== 'attribute') continue;
     const obj = left.childForFieldName('object');
     const attr = left.childForFieldName('attribute');
     if (obj && obj.text === 'self' && attr && attr.type === 'identifier' && !seen.has(attr.text)) {
@@ -370,7 +370,7 @@ function handlePyTypedParam(node: TreeSitterNode, ctx: ExtractorOutput): void {
   const isDefault = node.type === 'typed_default_parameter';
   const nameNode = isDefault ? node.childForFieldName('name') : node.child(0);
   const typeNode = node.childForFieldName('type');
-  if (!nameNode || nameNode.type !== 'identifier' || !typeNode) return;
+  if (nameNode?.type !== 'identifier' || !typeNode) return;
   if (nameNode.text === 'self' || nameNode.text === 'cls') return;
   const typeName = extractPythonTypeName(typeNode);
   if (typeName && ctx.typeMap) setTypeMapEntry(ctx.typeMap, nameNode.text, typeName, 0.9);
@@ -380,7 +380,7 @@ function handlePyTypedParam(node: TreeSitterNode, ctx: ExtractorOutput): void {
 function handlePyAssignmentType(node: TreeSitterNode, ctx: ExtractorOutput): void {
   const left = node.childForFieldName('left');
   const right = node.childForFieldName('right');
-  if (!left || left.type !== 'identifier' || !right || right.type !== 'call') return;
+  if (left?.type !== 'identifier' || !right || right.type !== 'call') return;
 
   const fn = right.childForFieldName('function');
   if (!fn) return;
@@ -391,7 +391,7 @@ function handlePyAssignmentType(node: TreeSitterNode, ctx: ExtractorOutput): voi
     }
   } else if (fn.type === 'attribute') {
     const obj = fn.childForFieldName('object');
-    if (!obj || obj.type !== 'identifier') return;
+    if (obj?.type !== 'identifier') return;
     const objName = obj.text;
     if (objName[0] && objName[0] !== objName[0].toLowerCase() && !BUILTIN_GLOBALS_PY.has(objName)) {
       if (ctx.typeMap) setTypeMapEntry(ctx.typeMap, left.text, objName, 0.7);

package/src/extractors/ruby.ts

@@ -264,7 +264,7 @@ function extractRubyBodyConstants(containerNode: TreeSitterNode): SubDeclaration
   if (!body) return children;
   for (let i = 0; i < body.childCount; i++) {
     const child = body.child(i);
-    if (!child || child.type !== 'assignment') continue;
+    if (child?.type !== 'assignment') continue;
     const left = child.childForFieldName('left');
     if (left && left.type === 'constant') {
       children.push({ name: left.text, kind: 'constant', line: child.startPosition.row + 1 });
@@ -279,7 +279,7 @@ function extractRubyClassChildren(classNode: TreeSitterNode): SubDeclaration[] {
   if (!body) return children;
   for (let i = 0; i < body.childCount; i++) {
     const child = body.child(i);
-    if (!child || child.type !== 'assignment') continue;
+    if (child?.type !== 'assignment') continue;
     const left = child.childForFieldName('left');
     if (!left) continue;
     if (left.type === 'instance_variable') {

package/src/extractors/scala.ts

@@ -263,7 +263,7 @@ function extractScalaParameters(funcNode: TreeSitterNode): SubDeclaration[] {
   if (!paramList) return params;
   for (let i = 0; i < paramList.childCount; i++) {
     const param = paramList.child(i);
-    if (!param || param.type !== 'parameter') continue;
+    if (param?.type !== 'parameter') continue;
     const nameNode = findChild(param, 'identifier');
     if (nameNode) {
       params.push({ name: nameNode.text, kind: 'parameter', line: param.startPosition.row + 1 });

package/src/extractors/solidity.ts

@@ -166,7 +166,7 @@ function extractContractMember(child: TreeSitterNode): SubDeclaration | null {
 function extractInheritance(node: TreeSitterNode, name: string, ctx: ExtractorOutput): void {
   for (let i = 0; i < node.childCount; i++) {
     const inheritance = node.child(i);
-    if (!inheritance || inheritance.type !== 'inheritance_specifier') continue;
+    if (inheritance?.type !== 'inheritance_specifier') continue;
     for (let j = 0; j < inheritance.childCount; j++) {
       const child = inheritance.child(j);
       if (!child) continue;

package/src/extractors/swift.ts

@@ -94,7 +94,7 @@ function collectSwiftEnumEntries(node: TreeSitterNode): SubDeclaration[] {
   if (!body) return entries;
   for (let i = 0; i < body.childCount; i++) {
     const child = body.child(i);
-    if (!child || child.type !== 'enum_entry') continue;
+    if (child?.type !== 'enum_entry') continue;
     const entryName = findChild(child, 'simple_identifier');
     if (entryName) {
       entries.push({
@@ -114,7 +114,7 @@ function collectSwiftProperties(node: TreeSitterNode): SubDeclaration[] {
   if (!body) return props;
   for (let i = 0; i < body.childCount; i++) {
     const child = body.child(i);
-    if (!child || child.type !== 'property_declaration') continue;
+    if (child?.type !== 'property_declaration') continue;
     const pattern = findChild(child, 'pattern');
     if (!pattern) continue;
     const propName = findChild(pattern, 'simple_identifier');
@@ -136,7 +136,7 @@ function collectSwiftMethods(node: TreeSitterNode, className: string, ctx: Extra
   if (!body) return;
   for (let i = 0; i < body.childCount; i++) {
     const child = body.child(i);
-    if (!child || child.type !== 'function_declaration') continue;
+    if (child?.type !== 'function_declaration') continue;
     const methName = findChild(child, 'simple_identifier');
     if (methName) {
       ctx.definitions.push({
@@ -159,7 +159,7 @@ function collectSwiftInheritance(
   let first = true;
   for (let i = 0; i < node.childCount; i++) {
     const child = node.child(i);
-    if (!child || child.type !== 'inheritance_specifier') continue;
+    if (child?.type !== 'inheritance_specifier') continue;
     const userType = findChild(child, 'user_type');
     const typeId = userType ? findChild(userType, 'type_identifier') : null;
     if (!typeId) continue;

package/src/extractors/zig.ts

@@ -86,7 +86,7 @@ function extractZigParams(funcNode: TreeSitterNode): SubDeclaration[] {
 
   for (let i = 0; i < paramList.childCount; i++) {
     const param = paramList.child(i);
-    if (!param || param.type !== 'parameter') continue;
+    if (param?.type !== 'parameter') continue;
     const nameNode = findChild(param, 'identifier');
     if (nameNode) {
       params.push({ name: nameNode.text, kind: 'parameter', line: param.startPosition.row + 1 });
@@ -151,7 +151,7 @@ function zigContainerKind(nodeType: string): 'struct' | 'enum' | undefined {
 function tryHandleZigImportDecl(node: TreeSitterNode, name: string, ctx: ExtractorOutput): boolean {
   for (let i = 0; i < node.childCount; i++) {
     const child = node.child(i);
-    if (!child || child.type !== 'builtin_function') continue;
+    if (child?.type !== 'builtin_function') continue;
     const source = extractZigImportSource(child);
     if (source) {
       ctx.imports.push({ source, names: [name], line: node.startPosition.row + 1 });
@@ -175,7 +175,7 @@ function extractZigContainerFields(container: TreeSitterNode): SubDeclaration[]
   const fields: SubDeclaration[] = [];
   for (let i = 0; i < container.childCount; i++) {
     const child = container.child(i);
-    if (!child || child.type !== 'container_field') continue;
+    if (child?.type !== 'container_field') continue;
     const nameNode = child.childForFieldName('name') || findChild(child, 'identifier');
     if (nameNode) {
       fields.push({ name: nameNode.text, kind: 'property', line: child.startPosition.row + 1 });
@@ -191,7 +191,7 @@ function extractZigContainerMethods(
 ): void {
   for (let i = 0; i < container.childCount; i++) {
     const child = container.child(i);
-    if (!child || child.type !== 'function_declaration') continue;
+    if (child?.type !== 'function_declaration') continue;
     const nameNode = child.childForFieldName('name');
     if (nameNode) {
       ctx.definitions.push({

package/src/infrastructure/config.ts

@@ -24,6 +24,7 @@ export const DEFAULTS = {
     dbPath: '.codegraph/graph.db',
     driftThreshold: 0.2,
     smallFilesThreshold: 5,
+    typescriptResolver: false,
   },
   query: {
     defaultDepth: 3,
@@ -79,6 +80,20 @@ export const DEFAULTS = {
     briefImporterDepth: 5,
     briefHighRiskCallers: 10,
     briefMediumRiskCallers: 3,
+    // TODO(Phase 8.3): wire these into the points-to solver and type-propagation path
+    // once config is threaded through to extractSymbols / buildPointsToMap. Currently
+    // controlled by hardcoded constants in src/extractors/javascript.ts
+    // (MAX_PROPAGATION_DEPTH, PROPAGATION_HOP_PENALTY) and in
+    // src/domain/graph/resolver/points-to.ts (MAX_SOLVER_ITERATIONS).
+    typePropagationDepth: 3,
+    /**
+     * Maximum fixed-point iterations for the Phase 8.3 points-to solver.
+     * @reserved — currently not wired to either the WASM solver
+     * (`MAX_SOLVER_ITERATIONS` in `points-to.ts`) or the native Rust solver
+     * (`MAX_SOLVER_ITERATIONS` in `edge_builder.rs`), both of which use the
+     * same hardcoded value of 50.  See the TODO comment above.
+     */
+    pointsToMaxIterations: 50,
   },
   community: {
     resolution: 1.0,

package/src/infrastructure/native.ts

@@ -6,11 +6,13 @@
  * to the existing WASM pipeline.
  */
 
+import { existsSync } from 'node:fs';
 import { createRequire } from 'node:module';
 import os from 'node:os';
+import { fileURLToPath } from 'node:url';
 import { EngineError, toErrorMessage } from '../shared/errors.js';
 import type { NativeAddon } from '../types.js';
-import { debug } from './logger.js';
+import { debug, warn } from './logger.js';
 
 let _cached: NativeAddon | null | undefined; // undefined = not yet tried, null = failed, NativeAddon = module
 let _loadError: Error | null = null;
@@ -44,31 +46,107 @@ const PLATFORM_PACKAGES: Record<string, string> = {
   'win32-x64': '@optave/codegraph-win32-x64-msvc',
 };
 
+/**
+ * Map of (platform-arch[-libc]) → locally compiled binary filename.
+ * Checked before the npm package so that locally compiled Rust changes
+ * are picked up immediately in development without publishing a new release.
+ */
+const PLATFORM_LOCAL_BINARIES: Record<string, string> = {
+  'linux-x64-gnu': 'codegraph-core.linux-x64-gnu.node',
+  'linux-x64-musl': 'codegraph-core.linux-x64-musl.node',
+  'linux-arm64-gnu': 'codegraph-core.linux-arm64-gnu.node',
+  'linux-arm64-musl': 'codegraph-core.linux-arm64-musl.node',
+  'darwin-arm64': 'codegraph-core.darwin-arm64.node',
+  'darwin-x64': 'codegraph-core.darwin-x64.node',
+  'win32-x64': 'codegraph-core.win32-x64-msvc.node',
+};
+
+/** Compute the platform key used to index PLATFORM_PACKAGES / PLATFORM_LOCAL_BINARIES. */
+function resolvePlatformKey(): string {
+  const platform = os.platform();
+  const arch = os.arch();
+  return platform === 'linux' ? `${platform}-${arch}-${detectLibc()}` : `${platform}-${arch}`;
+}
+
 /**
  * Resolve the platform-specific npm package name for the native addon.
  * Returns null if the current platform is not supported.
  */
 function resolvePlatformPackage(): string | null {
-  const platform = os.platform();
-  const arch = os.arch();
-  const key = platform === 'linux' ? `${platform}-${arch}-${detectLibc()}` : `${platform}-${arch}`;
-  return PLATFORM_PACKAGES[key] || null;
+  return PLATFORM_PACKAGES[resolvePlatformKey()] ?? null;
 }
 
 /**
  * Try to load the native napi addon.
  * Returns the module on success, null on failure.
+ *
+ * Load order:
+ *   1. NAPI_RS_NATIVE_LIBRARY_PATH env var (explicit override)
+ *   2. locally compiled binary in crates/codegraph-core/ (dev mode — preferred
+ *      over the npm package so that Rust changes are picked up immediately
+ *      without publishing a new release)
+ *   3. npm platform package (production path)
  */
 export function loadNative(): NativeAddon | null {
   if (_cached !== undefined) return _cached;
 
+  const platformKey = resolvePlatformKey();
+
+  // 1. Explicit path override — highest priority. Failure is fatal: if the
+  //    operator set this variable, silently loading a different binary would
+  //    be harder to diagnose than an explicit error.
+  const envPath = process.env.NAPI_RS_NATIVE_LIBRARY_PATH;
+  if (envPath) {
+    try {
+      _cached = _require(envPath) as NativeAddon;
+      debug(`loadNative: loaded from NAPI_RS_NATIVE_LIBRARY_PATH: ${envPath}`);
+      return _cached;
+    } catch (err) {
+      _loadError = err as Error;
+      warn(
+        `loadNative: NAPI_RS_NATIVE_LIBRARY_PATH is set but failed to load "${envPath}": ${toErrorMessage(err as Error)}`,
+      );
+      _cached = null;
+      return null;
+    }
+  }
+
+  // 2. Locally compiled dev binary — preferred over npm package so that Rust
+  //    changes are visible without publishing. Only used when the file exists.
+  //    If the file exists but fails to load (e.g. stale ABI), we warn and halt
+  //    rather than silently falling through to the npm package — that would
+  //    defeat the purpose of this priority order.
+  const localFile = PLATFORM_LOCAL_BINARIES[platformKey];
+  if (localFile) {
+    const localPath = fileURLToPath(
+      new URL(`../../crates/codegraph-core/${localFile}`, import.meta.url),
+    );
+    if (existsSync(localPath)) {
+      try {
+        _cached = _require(localPath) as NativeAddon;
+        debug(`loadNative: loaded local dev binary: ${localPath}`);
+        return _cached;
+      } catch (err) {
+        _loadError = err as Error;
+        warn(
+          `loadNative: local dev binary exists but failed to load "${localPath}": ${toErrorMessage(err as Error)}`,
+        );
+        _cached = null;
+        return null;
+      }
+    }
+  }
+
+  // 3. Published npm platform package — production path.
   const pkg = resolvePlatformPackage();
   if (pkg) {
     try {
       _cached = _require(pkg) as NativeAddon;
+      debug(`loadNative: loaded npm package: ${pkg}`);
       return _cached;
     } catch (err) {
       _loadError = err as Error;
+      debug(`loadNative: npm package ${pkg} not available: ${toErrorMessage(err as Error)}`);
     }
   } else {
     _loadError = new Error(`Unsupported platform: ${os.platform()}-${os.arch()}`);
@@ -88,6 +166,10 @@ export function isNativeAvailable(): boolean {
 /**
  * Read the version from the platform-specific npm package.json.
  * Returns null if the package is not installed or has no version.
+ *
+ * Note: always reports the npm package version. When the local dev binary or
+ * NAPI_RS_NATIVE_LIBRARY_PATH is loaded instead, this version may not match
+ * the running binary.
  */
 export function getNativePackageVersion(): string | null {
   const pkg = resolvePlatformPackage();

package/src/presentation/queries-cli/overview.ts

@@ -54,7 +54,13 @@ interface EmbeddingsInfo {
 
 interface QualityInfo {
   score: number;
-  callerCoverage: { ratio: number; covered: number; total: number };
+  callerCoverage: {
+    ratio: number;
+    percentage: number;
+    covered: number;
+    total: number;
+    byTechnique?: Record<string, number>;
+  };
   callConfidence: { ratio: number; highConf: number; total: number };
   falsePositiveWarnings: { name: string; callerCount: number; file: string; line: number }[];
 }
@@ -189,6 +195,14 @@ function printQuality(data: StatsData): void {
     console.log(
       `  Caller coverage:  ${(cc.ratio * 100).toFixed(1)}% (${cc.covered}/${cc.total} functions have >=1 caller)`,
     );
+    if (cc.byTechnique && Object.keys(cc.byTechnique).length > 0) {
+      const entries = Object.entries(cc.byTechnique).sort((a, b) => b[1] - a[1]) as [
+        string,
+        number,
+      ][];
+      const parts = entries.map(([k, v]) => `${k} ${v}`).join('  ');
+      console.log(`    by technique:  ${parts}`);
+    }
     console.log(
       `  Call confidence:  ${(cf.ratio * 100).toFixed(1)}% (${cf.highConf}/${cf.total} call edges are high-confidence)`,
     );