@opra/core 1.0.0-alpha.24 → 1.0.0-alpha.26

package/cjs/http/http-context.js

@@ -69,26 +69,7 @@ class HttpContext extends execution_context_js_1.ExecutionContext {
             /** Retrieve all fields */
             const parts = await reader.getAll();
             /** Filter fields according to configuration */
-            this._body = [];
-            const multipartFields = mediaType?.multipartFields;
-            if (mediaType && multipartFields?.length) {
-                const fieldsFound = new Map();
-                for (const item of parts) {
-                    const field = mediaType.findMultipartField(item.field, item.kind);
-                    if (field) {
-                        fieldsFound.set(field, true);
-                        this._body.push(item);
-                    }
-                }
-                /** Check required fields */
-                for (const field of multipartFields) {
-                    if (field.required && !fieldsFound.get(field)) {
-                        throw new common_1.BadRequestError({
-                            message: `Multipart field (${field.fieldName}) is required`,
-                        });
-                    }
-                }
-            }
+            this._body = [...parts];
             return this._body;
         }
         this._body = await this.request.readBody({ limit: operation.requestBody?.maxContentSize });

package/cjs/http/http-handler.js

@@ -278,123 +278,126 @@ class HttpHandler {
      */
     async sendResponse(context, responseValue) {
         if (context.errors.length)
-            return this.sendErrorResponse(context, context.errors);
+            return this._sendErrorResponse(context);
         const { response } = context;
         const { document } = this.adapter;
-        const responseArgs = this._determineResponseArgs(context, responseValue);
-        const { operationResponse, statusCode } = responseArgs;
-        let { contentType, body } = responseArgs;
-        const operationResultType = document.node.getDataType(common_1.OperationResult);
-        let operationResultEncoder = this[constants_1.kAssetCache].get(operationResultType, 'encode');
-        if (!operationResultEncoder) {
-            operationResultEncoder = operationResultType.generateCodec('encode', { ignoreWriteonlyFields: true });
-            this[constants_1.kAssetCache].set(operationResultType, 'encode', operationResultEncoder);
-        }
-        /** Validate response */
-        if (operationResponse?.type) {
-            if (!(body == null && statusCode === common_1.HttpStatusCode.NO_CONTENT)) {
-                /** Generate encoder */
-                let encode = this[constants_1.kAssetCache].get(operationResponse, 'encode');
-                if (!encode) {
-                    encode = operationResponse.type.generateCodec('encode', {
-                        partial: operationResponse.partial,
-                        projection: '*',
-                        ignoreWriteonlyFields: true,
-                    });
-                    if (operationResponse) {
-                        if (operationResponse.isArray)
-                            encode = valgen_1.vg.isArray(encode);
-                        this[constants_1.kAssetCache].set(operationResponse, 'encode', encode);
+        try {
+            const responseArgs = this._determineResponseArgs(context, responseValue);
+            const { operationResponse, statusCode } = responseArgs;
+            let { contentType, body } = responseArgs;
+            const operationResultType = document.node.getDataType(common_1.OperationResult);
+            let operationResultEncoder = this[constants_1.kAssetCache].get(operationResultType, 'encode');
+            if (!operationResultEncoder) {
+                operationResultEncoder = operationResultType.generateCodec('encode', { ignoreWriteonlyFields: true });
+                this[constants_1.kAssetCache].set(operationResultType, 'encode', operationResultEncoder);
+            }
+            /** Validate response */
+            if (operationResponse?.type) {
+                if (!(body == null && statusCode === common_1.HttpStatusCode.NO_CONTENT)) {
+                    /** Generate encoder */
+                    let encode = this[constants_1.kAssetCache].get(operationResponse, 'encode');
+                    if (!encode) {
+                        encode = operationResponse.type.generateCodec('encode', {
+                            partial: operationResponse.partial,
+                            projection: '*',
+                            ignoreWriteonlyFields: true,
+                            onFail: issue => `Response body validation failed: ` + issue.message,
+                        });
+                        if (operationResponse) {
+                            if (operationResponse.isArray)
+                                encode = valgen_1.vg.isArray(encode);
+                            this[constants_1.kAssetCache].set(operationResponse, 'encode', encode);
+                        }
+                    }
+                    /** Encode body */
+                    if (operationResponse.type.extendsFrom(operationResultType)) {
+                        if (body instanceof common_1.OperationResult)
+                            body = encode(body);
+                        else {
+                            body.payload = encode(body.payload);
+                            body = operationResultEncoder(body);
+                        }
                     }
-                }
-                /** Encode body */
-                if (operationResponse.type.extendsFrom(operationResultType)) {
-                    if (body instanceof common_1.OperationResult)
-                        body = encode(body);
                     else {
-                        body.payload = encode(body.payload);
-                        body = operationResultEncoder(body);
+                        if (body instanceof common_1.OperationResult &&
+                            contentType &&
+                            type_is_1.default.is(contentType, [common_1.MimeTypes.opra_response_json])) {
+                            body.payload = encode(body.payload);
+                            body = operationResultEncoder(body);
+                        }
+                        else {
+                            body = encode(body);
+                        }
                     }
-                }
-                else {
                     if (body instanceof common_1.OperationResult &&
-                        contentType &&
-                        type_is_1.default.is(contentType, [common_1.MimeTypes.opra_response_json])) {
-                        body.payload = encode(body.payload);
-                        body = operationResultEncoder(body);
+                        operationResponse.type &&
+                        operationResponse.type !== document.node.getDataType(common_1.OperationResult)) {
+                        body.type = operationResponse.type.name ? operationResponse.type.name : '#embedded';
                     }
-                    else
-                        body = encode(body);
-                }
-                if (body instanceof common_1.OperationResult &&
-                    operationResponse.type &&
-                    operationResponse.type !== document.node.getDataType(common_1.OperationResult)) {
-                    body.type = operationResponse.type.name ? operationResponse.type.name : '#embedded';
                 }
             }
-        }
-        else if (body != null) {
-            if (body instanceof common_1.OperationResult) {
-                body = operationResultEncoder(body);
-                contentType = common_1.MimeTypes.opra_response_json;
-            }
-            else if (Buffer.isBuffer(body))
-                contentType = common_1.MimeTypes.binary;
-            else if (typeof body === 'object') {
-                contentType = contentType || common_1.MimeTypes.json;
-                if (typeof body.toJSON === 'function')
-                    body = body.toJSON();
+            else if (body != null) {
+                if (body instanceof common_1.OperationResult) {
+                    body = operationResultEncoder(body);
+                    contentType = common_1.MimeTypes.opra_response_json;
+                }
+                else if (Buffer.isBuffer(body))
+                    contentType = common_1.MimeTypes.binary;
+                else if (typeof body === 'object') {
+                    contentType = contentType || common_1.MimeTypes.json;
+                    if (typeof body.toJSON === 'function')
+                        body = body.toJSON();
+                }
+                else {
+                    contentType = contentType || common_1.MimeTypes.text;
+                    body = String(body);
+                }
             }
-            else {
-                contentType = contentType || common_1.MimeTypes.text;
-                body = String(body);
+            /** Set content-type header value if not set */
+            if (contentType && contentType !== responseArgs.contentType)
+                response.setHeader('content-type', contentType);
+            response.status(statusCode);
+            if (body == null) {
+                response.end();
+                return;
             }
+            let x;
+            if (Buffer.isBuffer(body) || (0, common_1.isReadableStream)(body))
+                x = body;
+            else if ((0, common_1.isBlob)(body))
+                x = body.stream();
+            else if (typeof body === 'object')
+                x = JSON.stringify(body);
+            else
+                x = String(body);
+            response.end(x);
         }
-        /** Set content-type header value if not set */
-        if (contentType && contentType !== responseArgs.contentType)
-            response.setHeader('content-type', contentType);
-        response.status(statusCode);
-        if (body == null) {
-            response.end();
-            return;
+        catch (error) {
+            context.errors.push(error);
+            return this._sendErrorResponse(context);
         }
-        let x;
-        if (Buffer.isBuffer(body) || (0, common_1.isReadableStream)(body))
-            x = body;
-        else if ((0, common_1.isBlob)(body))
-            x = body.stream();
-        else if (typeof body === 'object')
-            x = JSON.stringify(body);
-        else
-            x = String(body);
-        response.end(x);
     }
-    async sendErrorResponse(context, errors) {
-        const { response } = context;
+    async _sendErrorResponse(context) {
+        context.errors = this._wrapExceptions(context.errors);
+        try {
+            await this.adapter.emitAsync('error', context.errors, context);
+            context.errors = this._wrapExceptions(context.errors);
+        }
+        catch (e) {
+            context.errors = this._wrapExceptions([e, ...context.errors]);
+        }
+        const { response, errors } = context;
         if (response.headersSent) {
             response.end();
             return;
         }
-        errors = errors || context.errors;
-        const wrappedErrors = errors.map(wrap_exception_1.wrapException);
-        if (!wrappedErrors.length)
-            wrappedErrors.push(new common_1.InternalServerError());
-        // Sort errors from fatal to info
-        wrappedErrors.sort((a, b) => {
-            const i = common_1.IssueSeverity.Keys.indexOf(a.severity) - common_1.IssueSeverity.Keys.indexOf(b.severity);
-            if (i === 0)
-                return b.status - a.status;
-            return i;
-        });
-        context.errors = wrappedErrors;
         let status = response.statusCode || 0;
         if (!status || status < Number(common_1.HttpStatusCode.BAD_REQUEST)) {
-            status = wrappedErrors[0].status;
+            status = errors[0].status;
             if (status < Number(common_1.HttpStatusCode.BAD_REQUEST))
                 status = common_1.HttpStatusCode.INTERNAL_SERVER_ERROR;
         }
         response.statusCode = status;
-        this.adapter.emitAsync('error', wrappedErrors[0], context).catch(() => undefined);
         const { document } = this.adapter;
         const dt = document.node.getComplexType('OperationResult');
         let encode = this[constants_1.kAssetCache].get(dt, 'encode');
@@ -404,7 +407,7 @@ class HttpHandler {
         }
         const { i18n } = this.adapter;
         const bodyObject = new common_1.OperationResult({
-            errors: wrappedErrors.map(x => {
+            errors: errors.map(x => {
                 const o = x.toJSON();
                 if (!(process.env.NODE_ENV === 'dev' || process.env.NODE_ENV === 'development'))
                     delete o.stack;
@@ -420,6 +423,30 @@ class HttpHandler {
         response.send(JSON.stringify(body));
         response.end();
     }
+    async sendDocumentSchema(context) {
+        const { request, response } = context;
+        const { document } = this.adapter;
+        response.setHeader('content-type', common_1.MimeTypes.json);
+        const url = new URL(request.originalUrl || request.url || '/', 'http://tempuri.org');
+        const { searchParams } = url;
+        const documentId = searchParams.get('id');
+        const doc = documentId ? document.findDocument(documentId) : document;
+        if (!doc) {
+            context.errors.push(new common_1.BadRequestError({
+                message: `Document with given id [${documentId}] does not exists`,
+            }));
+            return this.sendResponse(context);
+        }
+        /** Check if response cache exists */
+        let responseBody = this[constants_1.kAssetCache].get(doc, `$schema`);
+        /** Create response if response cache does not exists */
+        if (!responseBody) {
+            const schema = doc.export();
+            responseBody = JSON.stringify(schema);
+            this[constants_1.kAssetCache].set(doc, `$schema`, responseBody);
+        }
+        response.end(responseBody);
+    }
     /**
      *
      * @param context
@@ -477,6 +504,8 @@ class HttpHandler {
                                     : operationResponse.contentType);
                                 if (typeof ct === 'string')
                                     responseArgs.contentType = contentType = ct;
+                                else if (operationResponse.type)
+                                    responseArgs.contentType = common_1.MimeTypes.opra_response_json;
                             }
                         }
                     }
@@ -545,29 +574,18 @@ class HttpHandler {
             responseArgs.body = body;
         return responseArgs;
     }
-    async sendDocumentSchema(context) {
-        const { request, response } = context;
-        const { document } = this.adapter;
-        response.setHeader('content-type', common_1.MimeTypes.json);
-        const url = new URL(request.originalUrl || request.url || '/', 'http://tempuri.org');
-        const { searchParams } = url;
-        const documentId = searchParams.get('id');
-        const doc = documentId ? document.findDocument(documentId) : document;
-        if (!doc) {
-            context.errors.push(new common_1.BadRequestError({
-                message: `Document with given id [${documentId}] does not exists`,
-            }));
-            return this.sendResponse(context);
-        }
-        /** Check if response cache exists */
-        let responseBody = this[constants_1.kAssetCache].get(doc, `$schema`);
-        /** Create response if response cache does not exists */
-        if (!responseBody) {
-            const schema = doc.export();
-            responseBody = JSON.stringify(schema);
-            this[constants_1.kAssetCache].set(doc, `$schema`, responseBody);
-        }
-        response.end(responseBody);
+    _wrapExceptions(exceptions) {
+        const wrappedErrors = exceptions.map(wrap_exception_1.wrapException);
+        if (!wrappedErrors.length)
+            wrappedErrors.push(new common_1.InternalServerError());
+        // Sort errors from fatal to info
+        wrappedErrors.sort((a, b) => {
+            const i = common_1.IssueSeverity.Keys.indexOf(a.severity) - common_1.IssueSeverity.Keys.indexOf(b.severity);
+            if (i === 0)
+                return b.status - a.status;
+            return i;
+        });
+        return wrappedErrors;
     }
 }
 exports.HttpHandler = HttpHandler;

package/cjs/http/impl/multipart-reader.js

@@ -76,15 +76,22 @@ class MultipartReader extends events_1.EventEmitter {
         if (!item && !this._finished) {
             this.resume();
             item = await new Promise((resolve, reject) => {
+                let resolved = false;
                 if (this._stack.length)
                     return resolve(this._stack.shift());
                 if (this._form.ended)
                     return resolve(undefined);
                 this._form.once('close', () => {
+                    if (resolved)
+                        return;
+                    resolved = true;
                     resolve(this._stack.shift());
                 });
                 this.once('item', () => {
                     this.pause();
+                    if (resolved)
+                        return;
+                    resolved = true;
                     resolve(this._stack.shift());
                 });
                 this.once('error', e => reject(e));
@@ -95,8 +102,10 @@ class MultipartReader extends events_1.EventEmitter {
             if (!field)
                 throw new common_1.BadRequestError(`Unknown multipart field (${item.field})`);
             if (item.kind === 'field') {
-                const codec = field.generateCodec('decode');
-                item.value = codec(item.value);
+                const decode = field.generateCodec('decode');
+                item.value = decode(item.value, {
+                    onFail: issue => `Multipart field (${item.field}) validation failed: ` + issue.message,
+                });
             }
             else if (item.kind === 'file') {
                 if (field.contentType) {
@@ -108,7 +117,7 @@ class MultipartReader extends events_1.EventEmitter {
             }
         }
         /** if all items received we check for required items */
-        if (!item && this.mediaType && this.mediaType.multipartFields?.length > 0) {
+        if (this._finished && this.mediaType && this.mediaType.multipartFields?.length > 0) {
             const fieldsLeft = new Set(this.mediaType.multipartFields);
             for (const x of this._items) {
                 const field = this.mediaType.findMultipartField(x.field);
@@ -117,6 +126,8 @@ class MultipartReader extends events_1.EventEmitter {
             }
             let issues;
             for (const field of fieldsLeft) {
+                if (!field.required)
+                    continue;
                 try {
                     (0, valgen_1.isNotNullish)(null, { onFail: () => `Multi part field "${String(field.fieldName)}" is required` });
                 }
@@ -135,7 +146,7 @@ class MultipartReader extends events_1.EventEmitter {
         return item;
     }
     async getAll() {
-        const items = [];
+        const items = [...this._items];
         let item;
         while (!this._cancelled && (item = await this.getNext())) {
             items.push(item);
@@ -173,14 +184,7 @@ class MultipartReader extends events_1.EventEmitter {
         this._items.forEach(item => {
             if (item.kind !== 'file')
                 return;
-            const file = item.storedPath;
-            promises.push(new Promise(resolve => {
-                if (file._writeStream.closed)
-                    return resolve();
-                file._writeStream.once('close', resolve);
-            })
-                .then(() => promises_1.default.unlink(file.filepath))
-                .then(() => 0));
+            promises.push(promises_1.default.unlink(item.storedPath));
         });
         return Promise.allSettled(promises);
     }

package/esm/http/http-context.js

@@ -1,5 +1,5 @@
 import typeIs from '@browsery/type-is';
-import { BadRequestError, InternalServerError, NotAcceptableError, } from '@opra/common';
+import { InternalServerError, NotAcceptableError, } from '@opra/common';
 import { vg } from 'valgen';
 import { kAssetCache } from '../constants.js';
 import { ExecutionContext } from '../execution-context.js';
@@ -65,26 +65,7 @@ export class HttpContext extends ExecutionContext {
             /** Retrieve all fields */
             const parts = await reader.getAll();
             /** Filter fields according to configuration */
-            this._body = [];
-            const multipartFields = mediaType?.multipartFields;
-            if (mediaType && multipartFields?.length) {
-                const fieldsFound = new Map();
-                for (const item of parts) {
-                    const field = mediaType.findMultipartField(item.field, item.kind);
-                    if (field) {
-                        fieldsFound.set(field, true);
-                        this._body.push(item);
-                    }
-                }
-                /** Check required fields */
-                for (const field of multipartFields) {
-                    if (field.required && !fieldsFound.get(field)) {
-                        throw new BadRequestError({
-                            message: `Multipart field (${field.fieldName}) is required`,
-                        });
-                    }
-                }
-            }
+            this._body = [...parts];
             return this._body;
         }
         this._body = await this.request.readBody({ limit: operation.requestBody?.maxContentSize });

package/esm/http/http-handler.js

@@ -274,123 +274,126 @@ export class HttpHandler {
      */
     async sendResponse(context, responseValue) {
         if (context.errors.length)
-            return this.sendErrorResponse(context, context.errors);
+            return this._sendErrorResponse(context);
         const { response } = context;
         const { document } = this.adapter;
-        const responseArgs = this._determineResponseArgs(context, responseValue);
-        const { operationResponse, statusCode } = responseArgs;
-        let { contentType, body } = responseArgs;
-        const operationResultType = document.node.getDataType(OperationResult);
-        let operationResultEncoder = this[kAssetCache].get(operationResultType, 'encode');
-        if (!operationResultEncoder) {
-            operationResultEncoder = operationResultType.generateCodec('encode', { ignoreWriteonlyFields: true });
-            this[kAssetCache].set(operationResultType, 'encode', operationResultEncoder);
-        }
-        /** Validate response */
-        if (operationResponse?.type) {
-            if (!(body == null && statusCode === HttpStatusCode.NO_CONTENT)) {
-                /** Generate encoder */
-                let encode = this[kAssetCache].get(operationResponse, 'encode');
-                if (!encode) {
-                    encode = operationResponse.type.generateCodec('encode', {
-                        partial: operationResponse.partial,
-                        projection: '*',
-                        ignoreWriteonlyFields: true,
-                    });
-                    if (operationResponse) {
-                        if (operationResponse.isArray)
-                            encode = vg.isArray(encode);
-                        this[kAssetCache].set(operationResponse, 'encode', encode);
+        try {
+            const responseArgs = this._determineResponseArgs(context, responseValue);
+            const { operationResponse, statusCode } = responseArgs;
+            let { contentType, body } = responseArgs;
+            const operationResultType = document.node.getDataType(OperationResult);
+            let operationResultEncoder = this[kAssetCache].get(operationResultType, 'encode');
+            if (!operationResultEncoder) {
+                operationResultEncoder = operationResultType.generateCodec('encode', { ignoreWriteonlyFields: true });
+                this[kAssetCache].set(operationResultType, 'encode', operationResultEncoder);
+            }
+            /** Validate response */
+            if (operationResponse?.type) {
+                if (!(body == null && statusCode === HttpStatusCode.NO_CONTENT)) {
+                    /** Generate encoder */
+                    let encode = this[kAssetCache].get(operationResponse, 'encode');
+                    if (!encode) {
+                        encode = operationResponse.type.generateCodec('encode', {
+                            partial: operationResponse.partial,
+                            projection: '*',
+                            ignoreWriteonlyFields: true,
+                            onFail: issue => `Response body validation failed: ` + issue.message,
+                        });
+                        if (operationResponse) {
+                            if (operationResponse.isArray)
+                                encode = vg.isArray(encode);
+                            this[kAssetCache].set(operationResponse, 'encode', encode);
+                        }
+                    }
+                    /** Encode body */
+                    if (operationResponse.type.extendsFrom(operationResultType)) {
+                        if (body instanceof OperationResult)
+                            body = encode(body);
+                        else {
+                            body.payload = encode(body.payload);
+                            body = operationResultEncoder(body);
+                        }
                     }
-                }
-                /** Encode body */
-                if (operationResponse.type.extendsFrom(operationResultType)) {
-                    if (body instanceof OperationResult)
-                        body = encode(body);
                     else {
-                        body.payload = encode(body.payload);
-                        body = operationResultEncoder(body);
+                        if (body instanceof OperationResult &&
+                            contentType &&
+                            typeIs.is(contentType, [MimeTypes.opra_response_json])) {
+                            body.payload = encode(body.payload);
+                            body = operationResultEncoder(body);
+                        }
+                        else {
+                            body = encode(body);
+                        }
                     }
-                }
-                else {
                     if (body instanceof OperationResult &&
-                        contentType &&
-                        typeIs.is(contentType, [MimeTypes.opra_response_json])) {
-                        body.payload = encode(body.payload);
-                        body = operationResultEncoder(body);
+                        operationResponse.type &&
+                        operationResponse.type !== document.node.getDataType(OperationResult)) {
+                        body.type = operationResponse.type.name ? operationResponse.type.name : '#embedded';
                     }
-                    else
-                        body = encode(body);
-                }
-                if (body instanceof OperationResult &&
-                    operationResponse.type &&
-                    operationResponse.type !== document.node.getDataType(OperationResult)) {
-                    body.type = operationResponse.type.name ? operationResponse.type.name : '#embedded';
                 }
             }
-        }
-        else if (body != null) {
-            if (body instanceof OperationResult) {
-                body = operationResultEncoder(body);
-                contentType = MimeTypes.opra_response_json;
-            }
-            else if (Buffer.isBuffer(body))
-                contentType = MimeTypes.binary;
-            else if (typeof body === 'object') {
-                contentType = contentType || MimeTypes.json;
-                if (typeof body.toJSON === 'function')
-                    body = body.toJSON();
+            else if (body != null) {
+                if (body instanceof OperationResult) {
+                    body = operationResultEncoder(body);
+                    contentType = MimeTypes.opra_response_json;
+                }
+                else if (Buffer.isBuffer(body))
+                    contentType = MimeTypes.binary;
+                else if (typeof body === 'object') {
+                    contentType = contentType || MimeTypes.json;
+                    if (typeof body.toJSON === 'function')
+                        body = body.toJSON();
+                }
+                else {
+                    contentType = contentType || MimeTypes.text;
+                    body = String(body);
+                }
             }
-            else {
-                contentType = contentType || MimeTypes.text;
-                body = String(body);
+            /** Set content-type header value if not set */
+            if (contentType && contentType !== responseArgs.contentType)
+                response.setHeader('content-type', contentType);
+            response.status(statusCode);
+            if (body == null) {
+                response.end();
+                return;
             }
+            let x;
+            if (Buffer.isBuffer(body) || isReadableStream(body))
+                x = body;
+            else if (isBlob(body))
+                x = body.stream();
+            else if (typeof body === 'object')
+                x = JSON.stringify(body);
+            else
+                x = String(body);
+            response.end(x);
         }
-        /** Set content-type header value if not set */
-        if (contentType && contentType !== responseArgs.contentType)
-            response.setHeader('content-type', contentType);
-        response.status(statusCode);
-        if (body == null) {
-            response.end();
-            return;
+        catch (error) {
+            context.errors.push(error);
+            return this._sendErrorResponse(context);
         }
-        let x;
-        if (Buffer.isBuffer(body) || isReadableStream(body))
-            x = body;
-        else if (isBlob(body))
-            x = body.stream();
-        else if (typeof body === 'object')
-            x = JSON.stringify(body);
-        else
-            x = String(body);
-        response.end(x);
     }
-    async sendErrorResponse(context, errors) {
-        const { response } = context;
+    async _sendErrorResponse(context) {
+        context.errors = this._wrapExceptions(context.errors);
+        try {
+            await this.adapter.emitAsync('error', context.errors, context);
+            context.errors = this._wrapExceptions(context.errors);
+        }
+        catch (e) {
+            context.errors = this._wrapExceptions([e, ...context.errors]);
+        }
+        const { response, errors } = context;
         if (response.headersSent) {
             response.end();
             return;
         }
-        errors = errors || context.errors;
-        const wrappedErrors = errors.map(wrapException);
-        if (!wrappedErrors.length)
-            wrappedErrors.push(new InternalServerError());
-        // Sort errors from fatal to info
-        wrappedErrors.sort((a, b) => {
-            const i = IssueSeverity.Keys.indexOf(a.severity) - IssueSeverity.Keys.indexOf(b.severity);
-            if (i === 0)
-                return b.status - a.status;
-            return i;
-        });
-        context.errors = wrappedErrors;
         let status = response.statusCode || 0;
         if (!status || status < Number(HttpStatusCode.BAD_REQUEST)) {
-            status = wrappedErrors[0].status;
+            status = errors[0].status;
             if (status < Number(HttpStatusCode.BAD_REQUEST))
                 status = HttpStatusCode.INTERNAL_SERVER_ERROR;
         }
         response.statusCode = status;
-        this.adapter.emitAsync('error', wrappedErrors[0], context).catch(() => undefined);
         const { document } = this.adapter;
         const dt = document.node.getComplexType('OperationResult');
         let encode = this[kAssetCache].get(dt, 'encode');
@@ -400,7 +403,7 @@ export class HttpHandler {
         }
         const { i18n } = this.adapter;
         const bodyObject = new OperationResult({
-            errors: wrappedErrors.map(x => {
+            errors: errors.map(x => {
                 const o = x.toJSON();
                 if (!(process.env.NODE_ENV === 'dev' || process.env.NODE_ENV === 'development'))
                     delete o.stack;
@@ -416,6 +419,30 @@ export class HttpHandler {
         response.send(JSON.stringify(body));
         response.end();
     }
+    async sendDocumentSchema(context) {
+        const { request, response } = context;
+        const { document } = this.adapter;
+        response.setHeader('content-type', MimeTypes.json);
+        const url = new URL(request.originalUrl || request.url || '/', 'http://tempuri.org');
+        const { searchParams } = url;
+        const documentId = searchParams.get('id');
+        const doc = documentId ? document.findDocument(documentId) : document;
+        if (!doc) {
+            context.errors.push(new BadRequestError({
+                message: `Document with given id [${documentId}] does not exists`,
+            }));
+            return this.sendResponse(context);
+        }
+        /** Check if response cache exists */
+        let responseBody = this[kAssetCache].get(doc, `$schema`);
+        /** Create response if response cache does not exists */
+        if (!responseBody) {
+            const schema = doc.export();
+            responseBody = JSON.stringify(schema);
+            this[kAssetCache].set(doc, `$schema`, responseBody);
+        }
+        response.end(responseBody);
+    }
     /**
      *
      * @param context
@@ -473,6 +500,8 @@ export class HttpHandler {
                                     : operationResponse.contentType);
                                 if (typeof ct === 'string')
                                     responseArgs.contentType = contentType = ct;
+                                else if (operationResponse.type)
+                                    responseArgs.contentType = MimeTypes.opra_response_json;
                             }
                         }
                     }
@@ -541,28 +570,17 @@ export class HttpHandler {
             responseArgs.body = body;
         return responseArgs;
     }
-    async sendDocumentSchema(context) {
-        const { request, response } = context;
-        const { document } = this.adapter;
-        response.setHeader('content-type', MimeTypes.json);
-        const url = new URL(request.originalUrl || request.url || '/', 'http://tempuri.org');
-        const { searchParams } = url;
-        const documentId = searchParams.get('id');
-        const doc = documentId ? document.findDocument(documentId) : document;
-        if (!doc) {
-            context.errors.push(new BadRequestError({
-                message: `Document with given id [${documentId}] does not exists`,
-            }));
-            return this.sendResponse(context);
-        }
-        /** Check if response cache exists */
-        let responseBody = this[kAssetCache].get(doc, `$schema`);
-        /** Create response if response cache does not exists */
-        if (!responseBody) {
-            const schema = doc.export();
-            responseBody = JSON.stringify(schema);
-            this[kAssetCache].set(doc, `$schema`, responseBody);
-        }
-        response.end(responseBody);
+    _wrapExceptions(exceptions) {
+        const wrappedErrors = exceptions.map(wrapException);
+        if (!wrappedErrors.length)
+            wrappedErrors.push(new InternalServerError());
+        // Sort errors from fatal to info
+        wrappedErrors.sort((a, b) => {
+            const i = IssueSeverity.Keys.indexOf(a.severity) - IssueSeverity.Keys.indexOf(b.severity);
+            if (i === 0)
+                return b.status - a.status;
+            return i;
+        });
+        return wrappedErrors;
     }
 }

package/esm/http/impl/multipart-reader.js

@@ -72,15 +72,22 @@ export class MultipartReader extends EventEmitter {
         if (!item && !this._finished) {
             this.resume();
             item = await new Promise((resolve, reject) => {
+                let resolved = false;
                 if (this._stack.length)
                     return resolve(this._stack.shift());
                 if (this._form.ended)
                     return resolve(undefined);
                 this._form.once('close', () => {
+                    if (resolved)
+                        return;
+                    resolved = true;
                     resolve(this._stack.shift());
                 });
                 this.once('item', () => {
                     this.pause();
+                    if (resolved)
+                        return;
+                    resolved = true;
                     resolve(this._stack.shift());
                 });
                 this.once('error', e => reject(e));
@@ -91,8 +98,10 @@ export class MultipartReader extends EventEmitter {
             if (!field)
                 throw new BadRequestError(`Unknown multipart field (${item.field})`);
             if (item.kind === 'field') {
-                const codec = field.generateCodec('decode');
-                item.value = codec(item.value);
+                const decode = field.generateCodec('decode');
+                item.value = decode(item.value, {
+                    onFail: issue => `Multipart field (${item.field}) validation failed: ` + issue.message,
+                });
             }
             else if (item.kind === 'file') {
                 if (field.contentType) {
@@ -104,7 +113,7 @@ export class MultipartReader extends EventEmitter {
             }
         }
         /** if all items received we check for required items */
-        if (!item && this.mediaType && this.mediaType.multipartFields?.length > 0) {
+        if (this._finished && this.mediaType && this.mediaType.multipartFields?.length > 0) {
             const fieldsLeft = new Set(this.mediaType.multipartFields);
             for (const x of this._items) {
                 const field = this.mediaType.findMultipartField(x.field);
@@ -113,6 +122,8 @@ export class MultipartReader extends EventEmitter {
             }
             let issues;
             for (const field of fieldsLeft) {
+                if (!field.required)
+                    continue;
                 try {
                     isNotNullish(null, { onFail: () => `Multi part field "${String(field.fieldName)}" is required` });
                 }
@@ -131,7 +142,7 @@ export class MultipartReader extends EventEmitter {
         return item;
     }
     async getAll() {
-        const items = [];
+        const items = [...this._items];
         let item;
         while (!this._cancelled && (item = await this.getNext())) {
             items.push(item);
@@ -169,14 +180,7 @@ export class MultipartReader extends EventEmitter {
         this._items.forEach(item => {
             if (item.kind !== 'file')
                 return;
-            const file = item.storedPath;
-            promises.push(new Promise(resolve => {
-                if (file._writeStream.closed)
-                    return resolve();
-                file._writeStream.once('close', resolve);
-            })
-                .then(() => fsPromise.unlink(file.filepath))
-                .then(() => 0));
+            promises.push(fsPromise.unlink(item.storedPath));
         });
         return Promise.allSettled(promises);
     }

package/i18n/i18n/en/error.json

@@ -0,0 +1,21 @@
+{
+  "BAD_REQUEST": "Bad request",
+  "FAILED_DEPENDENCY": "The request failed due to failure of a previous request",
+  "FORBIDDEN": "You are not authorized to perform this action",
+  "INTERNAL_SERVER_ERROR": "Internal server error",
+  "METHOD_NOT_ALLOWED": "Method not allowed",
+  "NOT_ACCEPTABLE": "Not acceptable",
+  "NOT_FOUND": "Not found",
+  "UNAUTHORIZED": "You have not been authenticated to perform this action",
+  "UNPROCESSABLE_ENTITY": "Unprocessable entity",
+  "REQUEST_VALIDATION": "Request validation failed",
+  "RESPONSE_VALIDATION": "Response validation failed",
+  "RESOURCE_NOT_AVAILABLE": "Resource is not available or you dont have access",
+  "RESOURCE_CONFLICT": "There is already an other {{resource}} resource with same field values ({{fields}})",
+  "OPERATION_FORBIDDEN": "The {{resource}} resource does not accept '{{operation}}' operations",
+  "ACTION_NOT_FOUND": "The {{resource}} resource doesn't have an action named '{{action}}'",
+  "UNKNOWN_FIELD": "Unknown field '{{field}}'",
+  "UNACCEPTED_SORT_FIELD": "Field '{{field}}' is not available for sort operation",
+  "UNACCEPTED_FILTER_FIELD": "Field '{{field}}' is not available for filter operation",
+  "UNACCEPTED_FILTER_OPERATION": "'{{operation}}' for field '{{field}}' is not available for filter operation"
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opra/core",
-  "version": "1.0.0-alpha.24",
+  "version": "1.0.0-alpha.26",
   "description": "Opra schema package",
   "author": "Panates",
   "license": "MIT",
@@ -33,7 +33,7 @@
   "dependencies": {
     "@browsery/http-parser": "^0.5.8",
     "@browsery/type-is": "^1.6.18-r2",
-    "@opra/common": "^1.0.0-alpha.24",
+    "@opra/common": "^1.0.0-alpha.26",
     "accepts": "^1.3.8",
     "base64-stream": "^1.0.0",
     "busboy": "^1.6.0",

package/types/execution-context.d.ts

@@ -1,4 +1,4 @@
-import { ApiDocument, OpraException, OpraSchema } from '@opra/common';
+import { ApiDocument, OpraHttpError, OpraSchema } from '@opra/common';
 import { AsyncEventEmitter } from 'strict-typed-events';
 /**
  * @namespace ExecutionContext
@@ -18,7 +18,7 @@ export declare abstract class ExecutionContext extends AsyncEventEmitter {
     readonly document: ApiDocument;
     readonly protocol: OpraSchema.Protocol;
     readonly platform: string;
-    errors: OpraException[];
+    errors: OpraHttpError[];
     protected constructor(init: ExecutionContext.Initiator);
     addListener(event: 'finish', listener: ExecutionContext.OnFinishListener): this;
     removeListener(event: 'finish', listener: ExecutionContext.OnFinishListener): this;

package/types/http/http-handler.d.ts

@@ -1,4 +1,4 @@
-import { HttpOperationResponse, OpraException } from '@opra/common';
+import { HttpOperationResponse, OpraException, OpraHttpError } from '@opra/common';
 import { kAssetCache } from '../constants';
 import type { HttpAdapter } from './http-adapter';
 import { HttpContext } from './http-context';
@@ -61,7 +61,8 @@ export declare class HttpHandler {
      * @protected
      */
     sendResponse(context: HttpContext, responseValue?: any): Promise<void>;
-    sendErrorResponse(context: HttpContext, errors: any[]): Promise<void>;
+    protected _sendErrorResponse(context: HttpContext): Promise<void>;
+    sendDocumentSchema(context: HttpContext): Promise<void>;
     /**
      *
      * @param context
@@ -69,5 +70,5 @@ export declare class HttpHandler {
      * @protected
      */
     protected _determineResponseArgs(context: HttpContext, body: any): HttpHandler.ResponseArgs;
-    sendDocumentSchema(context: HttpContext): Promise<void>;
+    protected _wrapExceptions(exceptions: any[]): OpraHttpError[];
 }

package/types/http/impl/multipart-reader.d.ts

@@ -10,7 +10,7 @@ export declare namespace MultipartReader {
     interface FieldInfo {
         kind: 'field';
         field: string;
-        value?: string;
+        value?: any;
         mimeType?: string;
         encoding?: string;
     }