@operato/layout 10.29.40 → 10.29.43

package/test/overlay-close-after-write.test.ts

@@ -0,0 +1,31 @@
+import { expect, fixture, waitUntil } from '@open-wc/testing'
+import { html } from 'lit'
+import { addressController, writeAddress } from '@operato/utils/address.js'
+import { closeOverlay, openOverlay, appendViewpart, VIEWPART_POSITION } from '../src/index.js'
+
+/*
+ * Review probe (2026-10-19): a non-modal overlay (the AI dock) stays open while the list query changes; closing it
+ * afterwards must not undo that change.
+ */
+
+describe('closing a non-modal overlay after a later write', () => {
+  it('keeps the write made while it was open', async () => {
+    await fixture(html`<ox-header-bar></ox-header-bar>`)
+    addressController().registerQuery()
+    expect(await writeAddress('?filters=%5B%5D&probe=before')).to.equal(true)
+    appendViewpart({
+      name: 'probe-dock',
+      viewpart: { hovering: 'edge', show: false, backdrop: false, template: html`<div>dock</div>` },
+      position: VIEWPART_POSITION.HEADERBAR
+    })
+    openOverlay('probe-dock', { backdrop: false })
+    await waitUntil(() => (history.state as any)?.overlay?.name === 'probe-dock', 'dock not open')
+    await addressController().whenSettled()
+
+    expect(await writeAddress('?filters=%5B%5D&probe=after')).to.equal(true)
+    closeOverlay('probe-dock')
+    await addressController().whenSettled()
+    await new Promise(resolve => setTimeout(resolve, 100))
+    expect(new URLSearchParams(location.search).get('probe')).to.equal('after')
+  })
+})

package/test/popup-navigation.test.ts

@@ -0,0 +1,67 @@
+import { expect, fixture, waitUntil } from '@open-wc/testing'
+import { sendMouse } from '@web/test-runner-commands'
+import { html } from 'lit'
+import { addressController, writeAddress } from '@operato/utils/address.js'
+import { store } from '@operato/shell'
+import { closeOverlay, openPopup, UPDATE_VIEWPART } from '../src/index.js'
+
+/**
+ * Before 2026-10-17 a button in a popup that navigated went where it said and the popup closed; a hidden
+ * overlay held nothing back. These pin that behaviour.
+ */
+
+const overlays = () => document.querySelector('ox-header-bar')!.shadowRoot!.querySelectorAll('ox-floating-overlay')
+const click = async (element: Element) => {
+  const bounds = element.getBoundingClientRect()
+  await sendMouse({
+    type: 'click',
+    position: [Math.round(bounds.x + bounds.width / 2), Math.round(bounds.y + bounds.height / 2)]
+  })
+}
+const shown = async (element: Element) => {
+  await waitUntil(() => element.isConnected && element.getBoundingClientRect().width > 0, 'popup not shown')
+  await addressController().whenSettled()
+}
+
+describe('requests from inside a popup', () => {
+  beforeEach(async () => {
+    await fixture(html`<ox-header-bar></ox-header-bar>`)
+  })
+
+  afterEach(async () => {
+    for (const overlay of Array.from(overlays()).reverse()) closeOverlay((overlay as any).name)
+    await addressController().whenSettled()
+    await waitUntil(() => overlays().length === 0, 'a popup stayed open after the test')
+  })
+
+  it('a button in a popup that navigates closes the popup and replaces its entry', async () => {
+    expect(await writeAddress('?under=popup')).to.equal(true)
+    const under = location.href
+    const button = document.createElement('button')
+    button.textContent = 'open elsewhere'
+    let request: Promise<boolean> | undefined
+    button.addEventListener('click', () => (request = writeAddress('?destination=1', { source: button, intent: 'navigation' })))
+    openPopup(html`${button}`, { backdrop: true })
+    await shown(button)
+
+    await click(button)
+    expect(await request).to.equal(true)
+    expect(location.search).to.equal('?destination=1')
+    await waitUntil(() => overlays().length === 0, 'popup left open')
+
+    history.back()
+    await waitUntil(() => location.href === under, "back did not arrive")
+    expect(location.href).to.equal(under)
+  })
+
+  it('a popup hidden through the store is closed: it no longer holds requests back', async () => {
+    const content = document.createElement('div')
+    content.textContent = 'printing'
+    const handle = openPopup(html`${content}`, { backdrop: true })
+    await shown(content)
+
+    store.dispatch({ type: UPDATE_VIEWPART, name: handle.name, override: { show: false } })
+    await addressController().whenSettled()
+    expect(await writeAddress('?after=hidden')).to.equal(true)
+  })
+})

package/test/popup-result.test.ts

@@ -5,6 +5,8 @@ import { store } from '@operato/shell'
 import { closePopup } from '@operato/popup'
 import type { OxFloatingOverlay } from '@operato/popup/ox-floating-overlay.js'
 
+import { writeAddress } from '@operato/utils/address.js'
+
 import '../src/index.js'
 import { openPopup } from '../src/index.js'
 
@@ -53,7 +55,8 @@ let markerSequence = 0
 async function open(options = {}) {
   /* Closing must go back exactly one step - to this marker, not past it. */
   const marker = `before-popup-${markerSequence++}`
-  history.pushState({ marker }, '', location.href)
+  /* Through the address layer, as every writer does: an entry written around it has no place it can trust. */
+  await writeAddress(location.href, { state: { marker } })
 
   const handle = openPopup<string>(html`<div class="content">content</div>`, options)
   let onclosedCalls = 0
@@ -77,7 +80,7 @@ describe('openPopup result - layout implementation', () => {
      * instead of leaving the test runner. Such an extra step still fails the test through
      * `history.length`-independent checks below: the next popup would not appear.
      */
-    for (let i = 0; i < 5; i++) history.pushState({}, '', location.href)
+    for (let i = 0; i < 5; i++) await writeAddress(location.href, { state: {} })
     await fixture(html`<ox-header-bar></ox-header-bar>`)
   })
 

package/coverage/lcov-report/base.css

@@ -1,224 +0,0 @@
-body, html {
-  margin:0; padding: 0;
-  height: 100%;
-}
-body {
-    font-family: Helvetica Neue, Helvetica, Arial;
-    font-size: 14px;
-    color:#333;
-}
-.small { font-size: 12px; }
-*, *:after, *:before {
-  -webkit-box-sizing:border-box;
-     -moz-box-sizing:border-box;
-          box-sizing:border-box;
-  }
-h1 { font-size: 20px; margin: 0;}
-h2 { font-size: 14px; }
-pre {
-    font: 12px/1.4 Consolas, "Liberation Mono", Menlo, Courier, monospace;
-    margin: 0;
-    padding: 0;
-    -moz-tab-size: 2;
-    -o-tab-size:  2;
-    tab-size: 2;
-}
-a { color:#0074D9; text-decoration:none; }
-a:hover { text-decoration:underline; }
-.strong { font-weight: bold; }
-.space-top1 { padding: 10px 0 0 0; }
-.pad2y { padding: 20px 0; }
-.pad1y { padding: 10px 0; }
-.pad2x { padding: 0 20px; }
-.pad2 { padding: 20px; }
-.pad1 { padding: 10px; }
-.space-left2 { padding-left:55px; }
-.space-right2 { padding-right:20px; }
-.center { text-align:center; }
-.clearfix { display:block; }
-.clearfix:after {
-  content:'';
-  display:block;
-  height:0;
-  clear:both;
-  visibility:hidden;
-  }
-.fl { float: left; }
-@media only screen and (max-width:640px) {
-  .col3 { width:100%; max-width:100%; }
-  .hide-mobile { display:none!important; }
-}
-
-.quiet {
-  color: #7f7f7f;
-  color: rgba(0,0,0,0.5);
-}
-.quiet a { opacity: 0.7; }
-
-.fraction {
-  font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace;
-  font-size: 10px;
-  color: #555;
-  background: #E8E8E8;
-  padding: 4px 5px;
-  border-radius: 3px;
-  vertical-align: middle;
-}
-
-div.path a:link, div.path a:visited { color: #333; }
-table.coverage {
-  border-collapse: collapse;
-  margin: 10px 0 0 0;
-  padding: 0;
-}
-
-table.coverage td {
-  margin: 0;
-  padding: 0;
-  vertical-align: top;
-}
-table.coverage td.line-count {
-    text-align: right;
-    padding: 0 5px 0 20px;
-}
-table.coverage td.line-coverage {
-    text-align: right;
-    padding-right: 10px;
-    min-width:20px;
-}
-
-table.coverage td span.cline-any {
-    display: inline-block;
-    padding: 0 5px;
-    width: 100%;
-}
-.missing-if-branch {
-    display: inline-block;
-    margin-right: 5px;
-    border-radius: 3px;
-    position: relative;
-    padding: 0 4px;
-    background: #333;
-    color: yellow;
-}
-
-.skip-if-branch {
-    display: none;
-    margin-right: 10px;
-    position: relative;
-    padding: 0 4px;
-    background: #ccc;
-    color: white;
-}
-.missing-if-branch .typ, .skip-if-branch .typ {
-    color: inherit !important;
-}
-.coverage-summary {
-  border-collapse: collapse;
-  width: 100%;
-}
-.coverage-summary tr { border-bottom: 1px solid #bbb; }
-.keyline-all { border: 1px solid #ddd; }
-.coverage-summary td, .coverage-summary th { padding: 10px; }
-.coverage-summary tbody { border: 1px solid #bbb; }
-.coverage-summary td { border-right: 1px solid #bbb; }
-.coverage-summary td:last-child { border-right: none; }
-.coverage-summary th {
-  text-align: left;
-  font-weight: normal;
-  white-space: nowrap;
-}
-.coverage-summary th.file { border-right: none !important; }
-.coverage-summary th.pct { }
-.coverage-summary th.pic,
-.coverage-summary th.abs,
-.coverage-summary td.pct,
-.coverage-summary td.abs { text-align: right; }
-.coverage-summary td.file { white-space: nowrap;  }
-.coverage-summary td.pic { min-width: 120px !important;  }
-.coverage-summary tfoot td { }
-
-.coverage-summary .sorter {
-    height: 10px;
-    width: 7px;
-    display: inline-block;
-    margin-left: 0.5em;
-    background: url(sort-arrow-sprite.png) no-repeat scroll 0 0 transparent;
-}
-.coverage-summary .sorted .sorter {
-    background-position: 0 -20px;
-}
-.coverage-summary .sorted-desc .sorter {
-    background-position: 0 -10px;
-}
-.status-line {  height: 10px; }
-/* yellow */
-.cbranch-no { background: yellow !important; color: #111; }
-/* dark red */
-.red.solid, .status-line.low, .low .cover-fill { background:#C21F39 }
-.low .chart { border:1px solid #C21F39 }
-.highlighted,
-.highlighted .cstat-no, .highlighted .fstat-no, .highlighted .cbranch-no{
-  background: #C21F39 !important;
-}
-/* medium red */
-.cstat-no, .fstat-no, .cbranch-no, .cbranch-no { background:#F6C6CE }
-/* light red */
-.low, .cline-no { background:#FCE1E5 }
-/* light green */
-.high, .cline-yes { background:rgb(230,245,208) }
-/* medium green */
-.cstat-yes { background:rgb(161,215,106) }
-/* dark green */
-.status-line.high, .high .cover-fill { background:rgb(77,146,33) }
-.high .chart { border:1px solid rgb(77,146,33) }
-/* dark yellow (gold) */
-.status-line.medium, .medium .cover-fill { background: #f9cd0b; }
-.medium .chart { border:1px solid #f9cd0b; }
-/* light yellow */
-.medium { background: #fff4c2; }
-
-.cstat-skip { background: #ddd; color: #111; }
-.fstat-skip { background: #ddd; color: #111 !important; }
-.cbranch-skip { background: #ddd !important; color: #111; }
-
-span.cline-neutral { background: #eaeaea; }
-
-.coverage-summary td.empty {
-    opacity: .5;
-    padding-top: 4px;
-    padding-bottom: 4px;
-    line-height: 1;
-    color: #888;
-}
-
-.cover-fill, .cover-empty {
-  display:inline-block;
-  height: 12px;
-}
-.chart {
-  line-height: 0;
-}
-.cover-empty {
-    background: white;
-}
-.cover-full {
-    border-right: none !important;
-}
-pre.prettyprint {
-    border: none !important;
-    padding: 0 !important;
-    margin: 0 !important;
-}
-.com { color: #999 !important; }
-.ignore-none { color: #999; font-weight: normal; }
-
-.wrapper {
-  min-height: 100%;
-  height: auto !important;
-  height: 100%;
-  margin: 0 auto -48px;
-}
-.footer, .push {
-  height: 48px;
-}

package/coverage/lcov-report/block-navigation.js

@@ -1,87 +0,0 @@
-/* eslint-disable */
-var jumpToCode = (function init() {
-    // Classes of code we would like to highlight in the file view
-    var missingCoverageClasses = ['.cbranch-no', '.cstat-no', '.fstat-no'];
-
-    // Elements to highlight in the file listing view
-    var fileListingElements = ['td.pct.low'];
-
-    // We don't want to select elements that are direct descendants of another match
-    var notSelector = ':not(' + missingCoverageClasses.join('):not(') + ') > '; // becomes `:not(a):not(b) > `
-
-    // Selector that finds elements on the page to which we can jump
-    var selector =
-        fileListingElements.join(', ') +
-        ', ' +
-        notSelector +
-        missingCoverageClasses.join(', ' + notSelector); // becomes `:not(a):not(b) > a, :not(a):not(b) > b`
-
-    // The NodeList of matching elements
-    var missingCoverageElements = document.querySelectorAll(selector);
-
-    var currentIndex;
-
-    function toggleClass(index) {
-        missingCoverageElements
-            .item(currentIndex)
-            .classList.remove('highlighted');
-        missingCoverageElements.item(index).classList.add('highlighted');
-    }
-
-    function makeCurrent(index) {
-        toggleClass(index);
-        currentIndex = index;
-        missingCoverageElements.item(index).scrollIntoView({
-            behavior: 'smooth',
-            block: 'center',
-            inline: 'center'
-        });
-    }
-
-    function goToPrevious() {
-        var nextIndex = 0;
-        if (typeof currentIndex !== 'number' || currentIndex === 0) {
-            nextIndex = missingCoverageElements.length - 1;
-        } else if (missingCoverageElements.length > 1) {
-            nextIndex = currentIndex - 1;
-        }
-
-        makeCurrent(nextIndex);
-    }
-
-    function goToNext() {
-        var nextIndex = 0;
-
-        if (
-            typeof currentIndex === 'number' &&
-            currentIndex < missingCoverageElements.length - 1
-        ) {
-            nextIndex = currentIndex + 1;
-        }
-
-        makeCurrent(nextIndex);
-    }
-
-    return function jump(event) {
-        if (
-            document.getElementById('fileSearch') === document.activeElement &&
-            document.activeElement != null
-        ) {
-            // if we're currently focused on the search input, we don't want to navigate
-            return;
-        }
-
-        switch (event.which) {
-            case 78: // n
-            case 74: // j
-                goToNext();
-                break;
-            case 66: // b
-            case 75: // k
-            case 80: // p
-                goToPrevious();
-                break;
-        }
-    };
-})();
-window.addEventListener('keydown', jumpToCode);