@openzeppelin/miden-multisig-client 0.15.2 → 0.16.0

package/src/multisig.test.ts

@@ -22,6 +22,10 @@ vi.mock('@miden-sdk/miden-sdk', () => ({
   AccountId: {
     fromHex: vi.fn((hex: string) => ({ toString: () => hex })),
   },
+  NoteType: {
+    Private: 0,
+    Public: 1,
+  },
   TransactionSummary: {
     deserialize: vi.fn().mockReturnValue({
       toCommitment: () => ({
@@ -87,6 +91,14 @@ vi.mock('./transaction.js', () => ({
     request: {},
     salt: { toHex: () => '0x' + 'd'.repeat(64) },
   }),
+  // Mirrors the real implementations against the mocked NoteType values
+  // (Private = 0, Public = 1).
+  parseP2idNoteType: vi.fn((value?: string) => {
+    if (value === undefined || value === 'public') return 1;
+    if (value === 'private') return 0;
+    throw new Error(`unsupported metadata.noteType '${value}': expected 'public' or 'private'`);
+  }),
+  p2idNoteTypeToMetadata: vi.fn((noteType?: number) => (noteType === 0 ? 'private' : undefined)),
 }));
 
 vi.mock('./utils/signature.js', async () => {
@@ -119,6 +131,8 @@ vi.mock('./inspector.js', () => ({
 const mockFetch = vi.fn();
 vi.stubGlobal('fetch', mockFetch);
 
+const MIDEN_RPC_ENDPOINT = 'https://rpc.devnet.miden.io';
+
 function mockedAccount(commitmentHex: string, nonce = 0): any {
   return {
     commitment: () => ({
@@ -139,6 +153,22 @@ describe('Multisig', () => {
   let mockAccount: any;
   let mockWebClient: any;
 
+  function createTestMultisig(
+    config: ConstructorParameters<typeof Multisig>[1],
+    signer: Signer = mockSigner,
+    accountId?: string
+  ): Multisig {
+    return new Multisig(
+      mockAccount,
+      config,
+      guardian,
+      signer,
+      mockWebClient,
+      accountId,
+      MIDEN_RPC_ENDPOINT
+    );
+  }
+
   beforeEach(() => {
     mockFetch.mockReset();
     vi.mocked(executeForSummary).mockResolvedValue({
@@ -213,7 +243,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       expect(multisig.threshold).toBe(2);
       expect(multisig.signerCommitments).toEqual(config.signerCommitments);
@@ -229,11 +259,31 @@ describe('Multisig', () => {
       };
 
       const accountId = '0x' + 'd'.repeat(30);
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient, accountId);
+      const multisig = createTestMultisig(config, mockSigner, accountId);
 
       expect(multisig.account).toBe(mockAccount);
       expect(multisig.accountId).toBe(accountId);
     });
+
+    it('should reject a missing Miden RPC endpoint immediately', () => {
+      const config = {
+        threshold: 2,
+        signerCommitments: ['0x' + 'a'.repeat(64), '0x' + 'b'.repeat(64)],
+        guardianCommitment: '0x' + 'c'.repeat(64),
+      };
+
+      expect(
+        () => new Multisig(
+          mockAccount,
+          config,
+          guardian,
+          mockSigner,
+          mockWebClient,
+          undefined,
+          undefined as unknown as string
+        )
+      ).toThrow('missing required configuration: midenRpcEndpoint');
+    });
   });
 
   describe('accountId', () => {
@@ -244,7 +294,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       expect(multisig.accountId).toBe('0x' + 'a'.repeat(30));
     });
 
@@ -256,7 +306,7 @@ describe('Multisig', () => {
       };
 
       const accountId = '0x' + 'e'.repeat(30);
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient, accountId);
+      const multisig = createTestMultisig(config, mockSigner, accountId);
       expect(multisig.accountId).toBe(accountId);
     });
   });
@@ -269,7 +319,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       expect(multisig.signerCommitment).toBe(mockSigner.commitment);
     });
   });
@@ -282,7 +332,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       mockFetch.mockResolvedValueOnce({
         ok: true,
@@ -503,7 +553,7 @@ describe('Multisig', () => {
       expect(mockWebClient.newAccount).not.toHaveBeenCalled();
     });
 
-    it('should throw when incoming state nonce is lower than local nonce', async () => {
+    it('keeps local state and refreshes config from it when GUARDIAN nonce is behind local', async () => {
       const config = {
         threshold: 1,
         signerCommitments: ['0x' + 'a'.repeat(64)],
@@ -520,7 +570,8 @@ describe('Multisig', () => {
         'https://rpc.devnet.miden.io'
       );
 
-      mockWebClient.getAccount.mockResolvedValueOnce(mockedAccount('0x' + 'a'.repeat(64), 3));
+      const localAccount = mockedAccount('0x' + 'a'.repeat(64), 3);
+      mockWebClient.getAccount.mockResolvedValueOnce(localAccount);
       mockAccountDeserialize.mockReturnValueOnce(mockedAccount('0x' + 'b'.repeat(64), 2));
       mockFetch.mockResolvedValueOnce({
         ok: true,
@@ -532,11 +583,24 @@ describe('Multisig', () => {
           updated_at: '2024-01-02T00:00:00Z',
         }),
       });
+      mockDetectConfig.mockReturnValueOnce({
+        threshold: 2,
+        numSigners: 2,
+        signerCommitments: ['0x' + '1'.repeat(64), '0x' + '2'.repeat(64)],
+        guardianEnabled: true,
+        guardianCommitment: '0x' + 'd'.repeat(64),
+        vaultBalances: [],
+        procedureThresholds: new Map(),
+      });
 
-      await expect(multisig.syncState()).rejects.toThrow(
-        'incoming nonce 2 is not greater than local nonce 3'
-      );
+      // GUARDIAN behind local (nonce 2 < 3): no throw, local kept, no overwrite,
+      // and the decision needs no on-chain round-trip.
+      await expect(multisig.syncState()).resolves.toBeDefined();
       expect(mockWebClient.newAccount).not.toHaveBeenCalled();
+      expect(mockRpcGetAccountDetails).not.toHaveBeenCalled();
+      // Config refreshed from the authoritative local account (UI unfreezes).
+      expect(multisig.account).toBe(localAccount);
+      expect(multisig.threshold).toBe(2);
     });
 
     it('should throw when incoming state nonce equals local nonce but commitment differs', async () => {
@@ -570,10 +634,49 @@ describe('Multisig', () => {
       });
 
       await expect(multisig.syncState()).rejects.toThrow(
-        'incoming nonce 2 is not greater than local nonce 2'
+        'incoming nonce 2 equals local nonce 2 but commitments differ'
       );
       expect(mockWebClient.newAccount).not.toHaveBeenCalled();
     });
+
+    it('unfreezes Multisig.account after execute when GUARDIAN still lags by one nonce (regression, #343)', async () => {
+      const config = {
+        threshold: 1,
+        signerCommitments: ['0x' + 'a'.repeat(64)],
+        guardianCommitment: '0x' + 'c'.repeat(64),
+      };
+
+      const multisig = new Multisig(
+        mockAccount,
+        config,
+        guardian,
+        mockSigner,
+        mockWebClient,
+        undefined,
+        'https://rpc.devnet.miden.io'
+      );
+
+      // Post-execute: local advanced to nonce 1, GUARDIAN still reports nonce 0
+      // (candidate not canonicalized yet). Before the fix this threw and left
+      // Multisig.account frozen at the pre-execute snapshot.
+      const localAccount = mockedAccount('0x' + 'a'.repeat(64), 1);
+      mockWebClient.getAccount.mockResolvedValueOnce(localAccount);
+      mockAccountDeserialize.mockReturnValueOnce(mockedAccount('0x' + 'b'.repeat(64), 0));
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: async () => ({
+          account_id: multisig.accountId,
+          commitment: '0x' + 'b'.repeat(64),
+          state_json: { data: 'AQID' },
+          created_at: '2024-01-01T00:00:00Z',
+          updated_at: '2024-01-02T00:00:00Z',
+        }),
+      });
+
+      await expect(multisig.syncState()).resolves.toBeDefined();
+      expect(mockWebClient.newAccount).not.toHaveBeenCalled();
+      expect(multisig.account).toBe(localAccount);
+    });
   });
 
   describe('verifyStateCommitment', () => {
@@ -662,7 +765,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       mockFetch.mockResolvedValueOnce({
         ok: true,
@@ -690,7 +793,7 @@ describe('Multisig', () => {
       };
 
       guardian.setSigner(ecdsaSigner);
-      const multisig = new Multisig(mockAccount, config, guardian, ecdsaSigner, mockWebClient);
+      const multisig = createTestMultisig(config, ecdsaSigner);
 
       mockFetch.mockResolvedValueOnce({
         ok: true,
@@ -726,6 +829,7 @@ describe('Multisig', () => {
         mockSigner,
         mockWebClient,
         '0x' + 'e'.repeat(30),
+        MIDEN_RPC_ENDPOINT,
       );
 
       mockFetch.mockResolvedValueOnce({
@@ -746,7 +850,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       mockFetch.mockResolvedValueOnce({
         ok: true,
@@ -768,7 +872,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockProposals = [
         {
@@ -819,7 +923,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockProposals = [
         {
@@ -868,7 +972,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       mockFetch.mockResolvedValueOnce({
         ok: true,
@@ -917,7 +1021,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockProposals = [
         {
@@ -964,7 +1068,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockProposals = [
         {
@@ -1018,7 +1122,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       expect(multisig.listProposals()).toEqual([]);
     });
   });
@@ -1031,7 +1135,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -1075,7 +1179,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -1120,7 +1224,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -1179,7 +1283,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -1216,6 +1320,82 @@ describe('Multisig', () => {
 
       expect(proposal.metadata.description).toBe('Send 100 of asset 0xfaucet... to 0xrecipien...');
     });
+
+    it('threads a private noteType into the request and wire metadata (issue #322)', async () => {
+      const { executeForSummary, buildP2idTransactionRequest } = await import('./transaction.js');
+      const { NoteType } = await import('@miden-sdk/miden-sdk');
+      vi.mocked(executeForSummary).mockResolvedValue({
+        toCommitment: () => ({
+          toHex: () => '0x' + 'c'.repeat(64),
+        }),
+        serialize: () => new Uint8Array([1, 2, 3]),
+      } as any);
+
+      const config = {
+        threshold: 1,
+        signerCommitments: ['0x' + 'a'.repeat(64)],
+        guardianCommitment: '0x' + 'c'.repeat(64),
+      };
+
+      const multisig = createTestMultisig(config);
+
+      const mockDelta = {
+        account_id: '0x' + 'a'.repeat(30),
+        nonce: 1,
+        prev_commitment: '0x' + 'b'.repeat(64),
+        delta_payload: {
+          tx_summary: { data: 'AQID' },
+          signatures: [],
+          metadata: {
+            proposal_type: 'p2id',
+            recipient_id: '0xrecipient',
+            faucet_id: '0xfaucet',
+            amount: '100',
+            note_type: 'private',
+            description: '',
+          },
+        },
+        status: {
+          status: 'pending',
+          timestamp: '2024-01-01T00:00:00Z',
+          proposer_id: '0x' + 'c'.repeat(64),
+          cosigner_sigs: [],
+        },
+      };
+
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: async () => ({
+          delta: mockDelta,
+          commitment: '0x' + 'c'.repeat(64),
+        }),
+      });
+
+      const proposal = await multisig.createP2idProposal('0xrecipient', '0xfaucet', 100n, 1, {
+        noteType: NoteType.Private,
+      });
+
+      // Propose path builds the private note...
+      expect(vi.mocked(buildP2idTransactionRequest)).toHaveBeenCalledWith(
+        expect.any(String),
+        '0xrecipient',
+        '0xfaucet',
+        100n,
+        expect.anything(),
+        { noteType: NoteType.Private },
+      );
+      // ...and the rebuild-from-metadata path parses note_type back to Private.
+      const lastCall = vi.mocked(buildP2idTransactionRequest).mock.calls.at(-1)!;
+      expect(lastCall[5]).toMatchObject({ noteType: NoteType.Private });
+
+      // The pushed wire metadata carries note_type so cosigners rebuild the
+      // same private note at verification/execution.
+      const pushBody = JSON.parse(mockFetch.mock.calls.at(-1)![1].body as string);
+      expect(pushBody.delta_payload.metadata.note_type).toBe('private');
+
+      expect(proposal.metadata.proposalType).toBe('p2id');
+      expect((proposal.metadata as { noteType?: string }).noteType).toBe('private');
+    });
   });
 
   describe('createChangeThresholdProposal', () => {
@@ -1269,7 +1449,7 @@ describe('Multisig', () => {
         }),
       });
 
-      const multisig = new Multisig(mockAccount, config, guardian, ecdsaSigner, mockWebClient);
+      const multisig = createTestMultisig(config, ecdsaSigner);
       await multisig.createChangeThresholdProposal(2, 1);
 
       expect(buildUpdateSignersTransactionRequest).toHaveBeenCalledWith(
@@ -1293,7 +1473,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const newGuardianPubkey = '0x' + '1'.repeat(64);
 
       mockFetch.mockResolvedValueOnce({
@@ -1342,7 +1522,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       mockFetch.mockResolvedValueOnce({
         ok: true,
@@ -1372,7 +1552,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, ecdsaSigner, mockWebClient);
+      const multisig = createTestMultisig(config, ecdsaSigner);
       const newGuardianCommitment = '0x' + '1'.repeat(64);
 
       mockFetch.mockResolvedValueOnce({
@@ -1427,7 +1607,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -1495,7 +1675,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, ecdsaSigner, mockWebClient);
+      const multisig = createTestMultisig(config, ecdsaSigner);
 
       const mockDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -1546,7 +1726,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       // First create a proposal
       const mockDelta = {
@@ -1624,7 +1804,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -1675,7 +1855,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'd'.repeat(64);
 
       mockFetch.mockResolvedValueOnce({
@@ -1722,7 +1902,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       vi.mocked(executeForSummary).mockResolvedValueOnce({
         toCommitment: () => ({
@@ -1758,7 +1938,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       vi.mocked(executeForSummary).mockResolvedValueOnce({
         toCommitment: () => ({
@@ -1809,7 +1989,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockProposals = [
         {
@@ -1862,7 +2042,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const publicKey = '0x' + 'd'.repeat(66);
 
       mockFetch.mockResolvedValueOnce({
@@ -1920,13 +2100,20 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       mockFetch.mockResolvedValueOnce({
         ok: false,
         status: 404,
         statusText: 'Not Found',
-        text: async () => 'Proposal not found',
+        // Feature 009: only a conforming { code, message, meta } envelope is
+        // folded into the error message; raw text bodies are dropped.
+        text: async () =>
+          JSON.stringify({
+            code: 'GUARDIAN_PROPOSAL_NOT_FOUND',
+            message: 'Proposal not found',
+            meta: { retryable: false },
+          }),
       });
 
       await expect(
@@ -1943,7 +2130,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const exported = {
         accountId: multisig.accountId,
@@ -1976,7 +2163,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const publicKey = '0x' + 'd'.repeat(66);
 
       const proposal = await multisig.importProposal(
@@ -2023,7 +2210,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       await expect(
         multisig.importProposal(
@@ -2057,7 +2244,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const exported = {
         accountId: multisig.accountId,
@@ -2102,7 +2289,7 @@ describe('Multisig', () => {
         publicKey: '0x' + '2'.repeat(66),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, ecdsaSigner, mockWebClient);
+      const multisig = createTestMultisig(config, ecdsaSigner);
       const cachedProposalId = '0x' + 'c'.repeat(64);
       const requestedProposalId = '0x' + 'C'.repeat(64);
       const cosignerPubkey = '0x' + '3'.repeat(66);
@@ -2225,7 +2412,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'c'.repeat(64);
       const newGuardianPubkey = '0x' + '1'.repeat(64);
       const finalRequest = { kind: 'final-switch-guardian-request' };
@@ -2280,7 +2467,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       await expect(
         multisig.createTransactionProposalRequest('0x' + 'nonexistent'.repeat(5))
@@ -2294,7 +2481,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockProposals = [
         {
@@ -2345,7 +2532,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'c'.repeat(64);
 
       vi.mocked(executeForSummary).mockResolvedValueOnce({
@@ -2388,7 +2575,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'c'.repeat(64);
 
       (multisig as any).proposals.set(proposalId, {
@@ -2430,7 +2617,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'c'.repeat(64);
 
       (multisig as any).proposals.set(proposalId, {
@@ -2502,7 +2689,7 @@ describe('Multisig', () => {
           guardianCommitment: '0x' + 'c'.repeat(64),
         };
 
-        const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+        const multisig = createTestMultisig(config);
         const proposalId = '0x' + 'c'.repeat(64);
         const finalRequest = { kind: 'fresh-message-word-request' };
 
@@ -2601,7 +2788,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'c'.repeat(64);
 
       (multisig as any).proposals.set(proposalId, {
@@ -2644,7 +2831,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       await expect(
         multisig.executeProposal('0x' + 'nonexistent'.repeat(5))
@@ -2658,7 +2845,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       // Sync with pending proposal (only 1 signature)
       const mockProposals = [
@@ -2711,7 +2898,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const readyDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -2784,7 +2971,7 @@ describe('Multisig', () => {
         publicKey: '0x' + '2'.repeat(66),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, ecdsaSigner, mockWebClient);
+      const multisig = createTestMultisig(config, ecdsaSigner);
       const proposalId = '0x' + 'c'.repeat(64);
       const cosignerPubkey = '0x' + '3'.repeat(66);
       const ackPubkey = '0x' + '4'.repeat(66);
@@ -2900,7 +3087,7 @@ describe('Multisig', () => {
         publicKey: '0x' + '2'.repeat(66),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, ecdsaSigner, mockWebClient);
+      const multisig = createTestMultisig(config, ecdsaSigner);
       const proposalId = '0x' + 'c'.repeat(64);
       const cosignerPubkey = '0x' + '3'.repeat(66);
       const ackPubkey = '0x' + '4'.repeat(66);
@@ -3003,7 +3190,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'c'.repeat(64);
       const newGuardianPubkey = '0x' + '1'.repeat(64);
 
@@ -3086,7 +3273,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'c'.repeat(64);
       const newGuardianPubkey = '0x' + '1'.repeat(64);
 
@@ -3137,7 +3324,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'c'.repeat(64);
 
       (multisig as any).proposals.set(proposalId, {
@@ -3179,7 +3366,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'c'.repeat(64);
 
       (multisig as any).proposals.set(proposalId, {
@@ -3231,7 +3418,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       const proposalId = '0x' + 'c'.repeat(64);
 
       (multisig as any).proposals.set(proposalId, {
@@ -3308,7 +3495,7 @@ describe('Multisig', () => {
         signerCommitments: ['0x' + 'a'.repeat(64)],
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const builtinDelta = {
         ...customDelta('change_threshold', [falconSig('0x' + 'a'.repeat(64))]),
@@ -3336,7 +3523,7 @@ describe('Multisig', () => {
         signerCommitments: ['0x' + 'a'.repeat(64), '0x' + 'b'.repeat(64)],
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       mockFetch.mockResolvedValueOnce({
         ok: true,
@@ -3354,7 +3541,7 @@ describe('Multisig', () => {
         signerCommitments: ['0x' + 'a'.repeat(64)],
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       // Signed commitment comes from TransactionSummary.deserialize -> 'c' * 64.
       // Make the binding request derive a different commitment so the check fails.
@@ -3381,7 +3568,7 @@ describe('Multisig', () => {
         signerCommitments: ['0x' + 'a'.repeat(64)],
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const ready = customDelta('b2agg', [falconSig('0x' + 'a'.repeat(64))]);
 
@@ -3410,7 +3597,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       // Create a proposal with metadata
       const mockDelta = {
@@ -3472,7 +3659,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       // Sync proposals - no local proposals exist
       const mockProposals = [
@@ -3519,7 +3706,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -3567,7 +3754,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -3617,7 +3804,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const mockDelta = {
         account_id: '0x' + 'a'.repeat(30),
@@ -3668,7 +3855,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       // First sync with 1 signature (pending)
       const mockProposalsPending = [
@@ -3760,7 +3947,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'd'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       expect(multisig.threshold).toBe(3);
     });
 
@@ -3772,7 +3959,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'd'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       expect(multisig.signerCommitments).toEqual(signerCommitments);
     });
 
@@ -3784,7 +3971,7 @@ describe('Multisig', () => {
         guardianCommitment,
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       expect(multisig.guardianCommitment).toBe(guardianCommitment);
     });
 
@@ -3795,7 +3982,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'd'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
       expect(multisig.account).toBe(mockAccount);
     });
   });
@@ -3808,7 +3995,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       // Simulates a GUARDIAN response with canonical snake_case metadata
       const rustProposals = [
@@ -3858,7 +4045,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       // P2ID proposal with canonical snake_case fields
       const p2idProposals = [
@@ -3915,7 +4102,7 @@ describe('Multisig', () => {
         guardianCommitment: '0x' + 'c'.repeat(64),
       };
 
-      const multisig = new Multisig(mockAccount, config, guardian, mockSigner, mockWebClient);
+      const multisig = createTestMultisig(config);
 
       const switchGuardianProposals = [
         {