@openzeppelin/miden-multisig-client 0.12.7 → 0.13.0

package/src/utils/signature.test.ts

@@ -8,7 +8,7 @@ import {
 } from './signature.js';
 
 // Mock the Miden SDK
-vi.mock('@demox-labs/miden-sdk', () => ({
+vi.mock('@miden-sdk/miden-sdk', () => ({
   AdviceMap: vi.fn().mockImplementation(() => ({
     insert: vi.fn(),
   })),
@@ -88,7 +88,7 @@ describe('signature utilities', () => {
 
   describe('buildSignatureAdviceEntry', () => {
     it('returns key and values', async () => {
-      const { Word, Signature } = await import('@demox-labs/miden-sdk');
+      const { Word, Signature } = await import('@miden-sdk/miden-sdk');
       const pubkeyCommitment = Word.fromHex('0x' + 'a'.repeat(64));
       const message = Word.fromHex('0x' + 'b'.repeat(64));
       const signature = Signature.deserialize(new Uint8Array([0, 1, 2, 3]));
@@ -100,7 +100,7 @@ describe('signature utilities', () => {
     });
 
     it('hashes pubkey commitment and message to produce key', async () => {
-      const { Word, Signature, Rpo256 } = await import('@demox-labs/miden-sdk');
+      const { Word, Signature, Rpo256 } = await import('@miden-sdk/miden-sdk');
       const pubkeyCommitment = Word.fromHex('0x' + 'a'.repeat(64));
       const message = Word.fromHex('0x' + 'b'.repeat(64));
       const signature = Signature.deserialize(new Uint8Array([0, 1, 2, 3]));
@@ -111,7 +111,7 @@ describe('signature utilities', () => {
     });
 
     it('uses toPreparedSignature to get values', async () => {
-      const { Word, Signature } = await import('@demox-labs/miden-sdk');
+      const { Word, Signature } = await import('@miden-sdk/miden-sdk');
       const pubkeyCommitment = Word.fromHex('0x' + 'a'.repeat(64));
       const message = Word.fromHex('0x' + 'b'.repeat(64));
       const signature = Signature.deserialize(new Uint8Array([0, 1, 2, 3]));
@@ -125,7 +125,7 @@ describe('signature utilities', () => {
 
   describe('mergeSignatureAdviceMaps', () => {
     it('inserts all entries into advice map', async () => {
-      const { AdviceMap, Word, Signature } = await import('@demox-labs/miden-sdk');
+      const { AdviceMap, Word, Signature } = await import('@miden-sdk/miden-sdk');
       const advice = new AdviceMap();
 
       const entries = [
@@ -146,7 +146,7 @@ describe('signature utilities', () => {
     });
 
     it('returns the same advice map', async () => {
-      const { AdviceMap } = await import('@demox-labs/miden-sdk');
+      const { AdviceMap } = await import('@miden-sdk/miden-sdk');
       const advice = new AdviceMap();
 
       const result = mergeSignatureAdviceMaps(advice, []);
@@ -155,7 +155,7 @@ describe('signature utilities', () => {
     });
 
     it('handles empty entries array', async () => {
-      const { AdviceMap } = await import('@demox-labs/miden-sdk');
+      const { AdviceMap } = await import('@miden-sdk/miden-sdk');
       const advice = new AdviceMap();
 
       mergeSignatureAdviceMaps(advice, []);
@@ -166,7 +166,7 @@ describe('signature utilities', () => {
 
   describe('toWord', () => {
     it('creates Word from hex string', async () => {
-      const { Word } = await import('@demox-labs/miden-sdk');
+      const { Word } = await import('@miden-sdk/miden-sdk');
 
       const word = toWord('abc123');
 
@@ -175,7 +175,7 @@ describe('signature utilities', () => {
     });
 
     it('normalizes hex before creating Word', async () => {
-      const { Word } = await import('@demox-labs/miden-sdk');
+      const { Word } = await import('@miden-sdk/miden-sdk');
 
       toWord('abc');
 
@@ -184,7 +184,7 @@ describe('signature utilities', () => {
     });
 
     it('handles 0x prefix', async () => {
-      const { Word } = await import('@demox-labs/miden-sdk');
+      const { Word } = await import('@miden-sdk/miden-sdk');
 
       toWord('0xdef');
 
@@ -192,7 +192,7 @@ describe('signature utilities', () => {
     });
 
     it('handles full 64-char hex', async () => {
-      const { Word } = await import('@demox-labs/miden-sdk');
+      const { Word } = await import('@miden-sdk/miden-sdk');
       const fullHex = 'f'.repeat(64);
 
       toWord(fullHex);

package/src/utils/signature.ts

@@ -1,5 +1,5 @@
-import { AdviceMap, Felt, FeltArray, Rpo256, Signature, Word } from '@demox-labs/miden-sdk';
-import * as midenSdk from '@demox-labs/miden-sdk';
+import { AdviceMap, Felt, FeltArray, Rpo256, Signature, Word } from '@miden-sdk/miden-sdk';
+import * as midenSdk from '@miden-sdk/miden-sdk';
 import { hexToBytes, normalizeHexWord } from './encoding.js';
 import type { SignatureScheme } from '../types.js';
 
@@ -57,9 +57,16 @@ export function buildSignatureAdviceEntry(
 }
 
 export function tryComputeEcdsaCommitmentHex(pubkeyHex: string): string | null {
+  return tryComputeCommitmentHex(pubkeyHex, 'ecdsa');
+}
+
+export function tryComputeCommitmentHex(
+  pubkeyHex: string,
+  scheme: SignatureScheme,
+): string | null {
   const bytes = hexToBytes(pubkeyHex);
   const withPrefix = new Uint8Array(bytes.length + 1);
-  withPrefix[0] = 1;
+  withPrefix[0] = scheme === 'ecdsa' ? 1 : 0;
   withPrefix.set(bytes, 1);
 
   try {

package/src/utils/word.test.ts

@@ -1,9 +1,9 @@
 import { describe, it, expect, vi } from 'vitest';
-import { wordElementToBigInt, wordToHex } from './word.js';
-import { Word } from '@demox-labs/miden-sdk';
+import { wordElementToBigInt, wordToHex, wordToBytes } from './word.js';
+import { Word } from '@miden-sdk/miden-sdk';
 
 // Mock the Miden SDK Word class
-vi.mock('@demox-labs/miden-sdk', () => ({
+vi.mock('@miden-sdk/miden-sdk', () => ({
   Word: {
     fromHex: (hex: string): { toU64s: () => BigUint64Array; toHex: () => string } => {
       // Parse hex string (remove 0x prefix if present)
@@ -61,4 +61,58 @@ describe('word utilities', () => {
       expect(hex).toBe(originalHex);
     });
   });
+
+  describe('wordToBytes', () => {
+    it('should convert a word with known felt values to LE bytes', () => {
+      const word = {
+        toFelts: () => [
+          { asInt: () => 1n },
+          { asInt: () => 2n },
+          { asInt: () => 3n },
+          { asInt: () => 4n },
+        ],
+      };
+      const bytes = wordToBytes(word);
+      expect(bytes.length).toBe(32);
+      expect(bytes[0]).toBe(1);
+      expect(bytes[1]).toBe(0);
+      expect(bytes[8]).toBe(2);
+      expect(bytes[16]).toBe(3);
+      expect(bytes[24]).toBe(4);
+    });
+
+    it('should encode felts in little-endian order', () => {
+      const word = {
+        toFelts: () => [
+          { asInt: () => 0x0102030405060708n },
+          { asInt: () => 0n },
+          { asInt: () => 0n },
+          { asInt: () => 0n },
+        ],
+      };
+      const bytes = wordToBytes(word);
+      expect(bytes[0]).toBe(0x08);
+      expect(bytes[1]).toBe(0x07);
+      expect(bytes[2]).toBe(0x06);
+      expect(bytes[3]).toBe(0x05);
+      expect(bytes[4]).toBe(0x04);
+      expect(bytes[5]).toBe(0x03);
+      expect(bytes[6]).toBe(0x02);
+      expect(bytes[7]).toBe(0x01);
+    });
+
+    it('should handle zero felts', () => {
+      const word = {
+        toFelts: () => [
+          { asInt: () => 0n },
+          { asInt: () => 0n },
+          { asInt: () => 0n },
+          { asInt: () => 0n },
+        ],
+      };
+      const bytes = wordToBytes(word);
+      expect(bytes.length).toBe(32);
+      expect(bytes.every((b) => b === 0)).toBe(true);
+    });
+  });
 });

package/src/utils/word.ts

@@ -1,4 +1,4 @@
-import { Word } from '@demox-labs/miden-sdk';
+import { Word } from '@miden-sdk/miden-sdk';
 
 export function wordToHex(word: Word): string {
   return word.toHex();
@@ -9,3 +9,15 @@ export function wordElementToBigInt(word: Word, index: number): bigint {
   return index >= 0 && index < elements.length ? elements[index] : 0n;
 }
 
+export function wordToBytes(word: { toFelts: () => Array<{ asInt: () => bigint }> }): Uint8Array {
+  const felts = word.toFelts();
+  const buf = new Uint8Array(32);
+  for (let i = 0; i < 4; i++) {
+    const val = felts[i].asInt();
+    for (let b = 0; b < 8; b++) {
+      buf[i * 8 + b] = Number((val >> BigInt(b * 8)) & BigInt(0xff));
+    }
+  }
+  return buf;
+}
+