@openwop/openwop-conformance 1.54.0 → 1.58.0

package/src/scenarios/frontend-plugin-packs.test.ts

@@ -105,6 +105,30 @@ describe('frontend-plugin manifest: schema layer (always-on, server-free)', () =
     const m = { ...validManifest(), uiPlugins: [] };
     expect(validate(m), 'a frontend-plugin pack MUST declare at least one uiPlugins[] entry').toBe(false);
   });
+
+  it('a canvas-preview entry with canvasTypes + host.announce validates (RFC 0130)', () => {
+    const m = validManifest();
+    (m.uiPlugins as Array<Record<string, unknown>>)[0] = {
+      pluginId: 'gantt-preview',
+      surface: 'canvas-preview',
+      canvasTypes: ['canvas.gantt'],
+      entry: 'ui/preview.html',
+      hostApi: ['artifact.read', 'host.announce'],
+    };
+    expect(
+      validate(m),
+      `frontend-plugin-packs.md §The pack (RFC 0130) — a canvas-preview entry MUST validate. Errors: ${JSON.stringify(validate.errors)}`,
+    ).toBe(true);
+  });
+
+  it('a surface outside the closed set is still rejected (RFC 0130 keeps the enum closed)', () => {
+    const m = validManifest();
+    (m.uiPlugins as Array<Record<string, unknown>>)[0].surface = 'omni-panel';
+    expect(
+      validate(m),
+      'frontend-plugin-packs.md §The pack — the surface enum stays closed; an unknown surface MUST NOT validate',
+    ).toBe(false);
+  });
 });
 
 describe('ui-plugin/1 message: schema layer (always-on, server-free)', () => {

package/src/scenarios/workflow-chain-internal-flag.test.ts

@@ -0,0 +1,80 @@
+/**
+ * Workflow-chain gallery visibility — `internal` chains (RFC 0135).
+ *
+ * Server-free corpus legs (always-on): the manifest schema's §WorkflowChain carries
+ * a boolean `internal` property; a chain declaring `internal: true` validates; a
+ * non-boolean `internal` is rejected; the spec documents the MUST-omit-from-default-
+ * gallery rule and the not-an-authorization-boundary rule.
+ *
+ * The gallery-omission behavior itself is host-catalog presentation with no
+ * normative wire listing endpoint, so it is witnessed at the reference host (host
+ * regression test), not over the wire — see RFC 0135 §Conformance.
+ *
+ * @see spec/v1/workflow-chain-packs.md §"Chain visibility (RFC 0135)"
+ * @see schemas/workflow-chain-pack-manifest.schema.json §WorkflowChain
+ * @see RFCS/0135-workflow-chain-internal-visibility.md
+ */
+
+import { describe, it, expect } from 'vitest';
+import { readFileSync } from 'node:fs';
+import { join } from 'node:path';
+import Ajv2020 from 'ajv/dist/2020.js';
+import addFormats from 'ajv-formats';
+import { SCHEMAS_DIR } from '../lib/paths.js';
+
+const cite = (section: string, requirement: string): string => `${section} — ${requirement}`;
+const MANIFEST = join(SCHEMAS_DIR, 'workflow-chain-pack-manifest.schema.json');
+const CHAIN_DOC = join(SCHEMAS_DIR, '..', 'spec', 'v1', 'workflow-chain-packs.md');
+
+function packWith(internal: unknown): Record<string, unknown> {
+  return {
+    name: 'vendor.acme.factory',
+    version: '1.0.0',
+    kind: 'workflow-chain',
+    engines: { openwop: '^1' },
+    chains: [
+      {
+        chainId: 'acme.child-batch',
+        version: '1.0.0',
+        label: 'Child Batch (Factory child)',
+        description: 'Composition-only child fragment; composed by acme.factory.',
+        ...(internal !== undefined ? { internal } : {}),
+        parameters: {},
+        dag: { nodes: [{ id: 'build', typeId: 'core.ai.callPrompt', config: {} }] },
+      },
+    ],
+  };
+}
+
+describe('workflow-chain-internal-flag §A: corpus (RFC 0135, always-on)', () => {
+  it('the manifest §WorkflowChain declares a boolean `internal` property', () => {
+    const schema = JSON.parse(readFileSync(MANIFEST, 'utf8')) as {
+      $defs?: Record<string, { properties?: Record<string, { type?: string }> }>;
+    };
+    const internal = schema.$defs?.WorkflowChain?.properties?.internal;
+    expect(internal, cite('§WorkflowChain', 'internal property present')).toBeTruthy();
+    expect(internal?.type, cite('§WorkflowChain', 'internal is boolean')).toBe('boolean');
+  });
+
+  it('a chain declaring internal: true validates; a non-boolean internal is rejected', () => {
+    const ajv = new Ajv2020({ allErrors: true, strict: false });
+    addFormats(ajv);
+    const validate = ajv.compile(JSON.parse(readFileSync(MANIFEST, 'utf8')) as Record<string, unknown>);
+    expect(validate(packWith(true)), cite('§WorkflowChain', `internal:true validates: ${ajv.errorsText(validate.errors)}`)).toBe(true);
+    expect(validate(packWith(undefined)), cite('§WorkflowChain', 'absent internal stays valid (absent ⇒ false)')).toBe(true);
+    expect(validate(packWith('yes')), cite('§WorkflowChain', 'non-boolean internal rejected')).toBe(false);
+  });
+
+  it('the spec documents the MUST-omit-from-default-gallery + not-an-authz-boundary rules', () => {
+    const doc = readFileSync(CHAIN_DOC, 'utf8');
+    expect(doc.includes('Chain visibility (RFC 0135)'), cite('§Chain visibility', 'section present')).toBe(true);
+    expect(
+      /internal[\s\S]{0,600}MUST omit/i.test(doc),
+      cite('§Chain visibility', 'documents MUST omit from default listing'),
+    ).toBe(true);
+    expect(
+      /NOT an authorization boundary/i.test(doc),
+      cite('§Chain visibility', 'documents internal is not an authz boundary'),
+    ).toBe(true);
+  });
+});