@openviking/dsh-memory-plugin 0.5.13 → 0.5.15

package/README.md

@@ -117,6 +117,15 @@ context under such presets with no error. Pre-step injection also makes each
 injection a session event that replays, is visible to compaction, and never
 reaches `request/header`.
 
+### What triggers recall
+
+Recall runs on a pre-step whose entering batch contains user-authored input.
+The query is built only from those messages: user-role messages with
+`source.kind` absent or `user`. Messages that DSH or other plugins inject
+(`time-context`, `plugin:*` notices, this plugin's own blocks) and tool results
+are excluded, using the same rule capture uses. A batch made only of injected
+context sends no search request.
+
 ### How the tool surface is mounted
 
 `mcp.mjs` mounts `@deepseek-ai/dsh-mcp-client` on `servers/mcp-proxy.mjs`, the
@@ -228,7 +237,7 @@ The older size settings apply to fallback recall, not the primary context reques
 - `tools/pre-execute` denies a DSH filesystem tool (`read`, `glob`, `grep`, `edit`, `write`, `str_replace_editor`) whose path argument is a `viking://` URI, pointing the model at the bridged `mcp__openviking__*` tools instead. A `write` or `edit` under a skill directory (`viking://~/skills/...`, `viking://user/<id>/skills/...`, `viking://agent/skills/...`) points at `mcp__openviking__add_skill` instead, which creates or replaces a whole skill from its `SKILL.md` text. A `grep` whose pattern is `viking://` text still runs.
 - `tools/post-execute` lets a `bash` command that carries a `viking://` URI run unchanged and attaches a notice for the model: use the bridged tools if it meant OpenViking content, or ignore the notice when the URI is intentional data such as an `ov` argument or an HTTP payload.
 
-Each DSH session maps to `dsh-<session-id>` in OpenViking. Workspace-derived actor peers are resolved per session and sent on every session-specific request: the peer is the git identity of the session's workspace — the normalized `origin` URL (`git@github.com:volcengine/OpenViking.git` becomes `github.com-volcengine-openviking`), else the repository root path, that fallback keeping the older rule where every non-letter-or-digit character becomes `-`. With the default peer settings, no peer is sent outside a git repository, and what is remembered there goes to the user-level space `viking://user/<you>/memories`. One repository therefore keeps one peer across subdirectories, worktrees, clones and machines, while a fork's different origin keeps it separate. Memories written under the older path-derived peer stay reachable: the default `recallPeerScope: all` sweeps every peer under the user.
+Each DSH session maps to `dsh-<session-id>` in OpenViking. IDs that contain Windows-invalid path characters are normalized to a readable underscore form plus a stable hash, so two native IDs cannot collapse onto the same OpenViking session; already-portable IDs keep their existing mapping. Existing sessions whose native IDs require normalization start a new OpenViking session after this upgrade. Workspace-derived actor peers are resolved per session and sent on every session-specific request: the peer is the git identity of the session's workspace — the normalized `origin` URL (`git@github.com:volcengine/OpenViking.git` becomes `github.com-volcengine-openviking`), else the repository root path, that fallback keeping the older rule where every non-letter-or-digit character becomes `-`. With the default peer settings, no peer is sent outside a git repository, and what is remembered there goes to the user-level space `viking://user/<you>/memories`. One repository therefore keeps one peer across subdirectories, worktrees, clones and machines, while a fork's different origin keeps it separate. Memories written under the older path-derived peer stay reachable: the default `recallPeerScope: all` sweeps every peer under the user.
 
 Workspace peer settings are loaded from `session.header.cwd` when the session first uses memory. A workspace can set `peer.id` to name its project explicitly, or `peer.source` to choose a preset or template chain. For example, `<root>/.openviking/config.json` can contain:
 

package/capture.mjs

@@ -96,9 +96,18 @@ function captureMessage(event, message, config, toolNames) {
   return payload;
 }
 
+// Recall queries use only what the user typed. Injected context (time-context,
+// job notices, other plugins' blocks, our own recall) and tool results would
+// otherwise trigger recall on their own and pollute the query text.
+function isUserInput(message) {
+  if (!message || message.role !== "user") return false;
+  if (message.source?.kind === "tool") return false;
+  return !isSyntheticUserMessage(message);
+}
+
 export function promptText(messages) {
   return (messages || [])
-    .filter(message => !isOpenVikingPluginMessage(message))
+    .filter(isUserInput)
     .map(message => extractTextFromPayload(message))
     .filter(Boolean)
     .join("\n\n")

package/config.mjs

@@ -1,7 +1,7 @@
 import { buildPluginConfig } from "./shared/plugin-config.mjs";
 import { loadCredentialFiles } from "./shared/credentials.mjs";
 
-export const PLUGIN_VERSION = "0.5.13";
+export const PLUGIN_VERSION = "0.5.15";
 
 /**
  * Namespace for the bridged OpenViking MCP tools. DSH publishes every MCP tool

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openviking/dsh-memory-plugin",
-  "version": "0.5.13",
+  "version": "0.5.15",
   "description": "OpenViking memory and context bundle for DeepSeek Harness",
   "icon": "./icon.svg",
   "type": "module",
@@ -20,6 +20,7 @@
     "mcp.mjs",
     "mcp-env.mjs",
     "runtime.mjs",
+    "session-id.mjs",
     "skills.mjs",
     "uri-guard.mjs",
     "servers/",

package/runtime.mjs

@@ -1,7 +1,6 @@
 import { isCaptureEnabled } from "./shared/capture-utils.mjs";
 import { buildProfileBlock } from "./shared/profile-inject.mjs";
 import { buildRecallBlock, isRecallEnabled } from "./shared/recall-core.mjs";
-import { deriveHarnessSessionId } from "./shared/session-model.mjs";
 import {
   dequeue,
   enqueue,
@@ -16,6 +15,7 @@ import {
   pluginMessage,
   promptText,
 } from "./capture.mjs";
+import { deriveDshSessionId } from "./session-id.mjs";
 
 export class OpenVikingRuntime {
   constructor(client, config, logger = console, resolveSessionPeer = null) {
@@ -45,7 +45,7 @@ export class OpenVikingRuntime {
     });
     state = {
       dshSessionId: String(session.id),
-      ovSessionId: deriveHarnessSessionId("dsh-", String(session.id)),
+      ovSessionId: deriveDshSessionId(session.id),
       config: { ...this.config, peerId: peer.peerId, legacyPeerId: peer.legacyPeerId },
       ready: false,
       profileBlock: "",
@@ -131,7 +131,7 @@ export class OpenVikingRuntime {
     const state = await this.initialize(agent);
     if (!state.ready || !isRecallEnabled(state.config)) return null;
     const query = promptText(messages);
-    if (query.length < state.config.minQueryLength) return null;
+    if (!query || query.length < state.config.minQueryLength) return null;
     const block = await buildRecallBlock(
       (path, init, options) => this.client.fetchJSON(path, init, options),
       state.config,

package/session-id.mjs

@@ -0,0 +1,21 @@
+import { createHash } from "node:crypto";
+import { deriveHarnessSessionId } from "./shared/session-model.mjs";
+
+// Keep identifiers valid as a single path component on Windows. The `dsh-`
+// prefix also prevents reserved device names such as CON and NUL from matching
+// the whole component.
+const WINDOWS_UNSAFE = /[<>:"/\\|?*\u0000-\u001F]/g;
+const WINDOWS_UNSAFE_TRAILING = /[. ]+$/g;
+
+export function deriveDshSessionId(sessionId) {
+  const original = deriveHarnessSessionId("dsh-", String(sessionId));
+  const portable = original
+    .replace(WINDOWS_UNSAFE, "_")
+    .replace(WINDOWS_UNSAFE_TRAILING, match => "_".repeat(match.length));
+  if (portable === original) return original;
+
+  // Replacement alone is lossy (`im:a` and `im?a` both become `im_a`). Keep a
+  // readable stem and add a stable digest whenever normalization was needed.
+  const digest = createHash("sha256").update(original).digest("hex").slice(0, 12);
+  return `${portable}__${digest}`;
+}