@openvcs/git-plugin 0.3.2-nightly.20260603.124 → 0.3.2-nightly.20260613.146

package/bin/git.js

@@ -88,7 +88,7 @@ export class GitCommand {
             const baseLine = isCurrent ? line.slice(0, -1) : line;
             const name = baseLine.trim();
             if (name) {
-                branches.push({ name, current: name === current || (isCurrent && name === current) });
+                branches.push({ name, current: name === current });
             }
         }
         return { current, branches };
@@ -302,7 +302,7 @@ export class GitCommand {
             return false;
         }
         return lines.some((line) => {
-            const candidate = String(line || '');
+            const candidate = String(line);
             return /^binary files /i.test(candidate)
                 || /^git binary patch/i.test(candidate)
                 || /^literal /i.test(candidate);
@@ -359,7 +359,7 @@ export class GitCommand {
             const line = rawLine.trim();
             if (!line)
                 continue;
-            const marker = line[0] || ' ';
+            const marker = line[0];
             const rest = line.slice(1).trim();
             const [commit = '', path = ''] = rest.split(/\s+/);
             if (!path)
@@ -409,7 +409,7 @@ export class GitCommand {
         this.runChecked(['submodule', 'deinit', '-f', '--', path], 'git-submodule-remove-failed');
         this.runChecked(['rm', '-f', '--', path], 'git-submodule-remove-failed');
         const modulesPath = join(this.cwd, '.git', 'modules', path);
-        /* c8 ignore next 4 */
+        /* c8 ignore next 5 */
         try {
             rmSync(modulesPath, { recursive: true, force: true });
         }
@@ -517,6 +517,140 @@ export class GitCommand {
             stdin: patch,
         });
     }
+    /**
+     * Stages structured hunk/line selections (VCS-agnostic).
+     *
+     * For each file, fetches the worktree diff, extracts the selected hunks/lines,
+     * builds a combined sub-patch, and applies it to the index atomically.
+     */
+    stageSelections(selections) {
+        const filePatches = [];
+        for (const sel of selections) {
+            // Fetch only the worktree diff (not --cached) — cached changes are
+            // already staged and must not be re-applied.
+            const raw = this.runChecked(['diff', '--no-ext-diff', '--no-color', '--', sel.path], 'git-diff-failed').stdout;
+            if (!raw.trim())
+                continue;
+            const lines = this.splitDiffLines(raw);
+            /* c8 ignore next 3 */
+            if (lines.length === 0)
+                continue;
+            const normPath = sel.path.replace(/\\/g, '/');
+            // Find the first @@ line to separate prelude from hunks
+            const firstHunk = lines.findIndex(l => l.startsWith('@@'));
+            if (firstHunk < 0)
+                continue;
+            const prelude = lines.slice(0, firstHunk);
+            const rest = lines.slice(firstHunk);
+            // Build headerExtras: metadata lines that aren't diff --git, ---, or +++
+            const headerExtras = prelude.filter(l => !!l &&
+                !l.startsWith('diff --git') &&
+                !l.startsWith('--- ') &&
+                !l.startsWith('+++ '));
+            // Locate all hunk @@ positions within rest
+            const starts = [];
+            for (let i = 0; i < rest.length; i++) {
+                if (rest[i].startsWith('@@'))
+                    starts.push(i);
+            }
+            /* c8 ignore next 3 */
+            if (starts.length === 0)
+                continue;
+            starts.push(rest.length);
+            const isAdd = prelude.some(l => l.startsWith('--- /dev/null'));
+            const isDel = prelude.some(l => l.startsWith('+++ /dev/null'));
+            const wantWhole = new Set(sel.whole_hunks.filter(n => Number.isFinite(n)));
+            let out = `diff --git a/${normPath} b/${normPath}\n`;
+            if (headerExtras.length)
+                out += headerExtras.join('\n') + '\n';
+            if (isAdd)
+                out += `--- /dev/null\n+++ b/${normPath}\n`;
+            else if (isDel)
+                out += `--- a/${normPath}\n+++ /dev/null\n`;
+            else
+                out += `--- a/${normPath}\n+++ b/${normPath}\n`;
+            for (let h = 0; h < starts.length - 1; h++) {
+                const s = starts[h];
+                const e = starts[h + 1];
+                const block = rest.slice(s, e);
+                /* c8 ignore next 7 */
+                const header = block[0] || '';
+                const m = /@@\s*-([0-9]+),?([0-9]*)\s*\+([0-9]+),?([0-9]*)\s*@@/.exec(header);
+                if (!m)
+                    continue;
+                const aStart = parseInt(m[1] || '0', 10) || 0;
+                const cStart = parseInt(m[3] || '0', 10) || 0;
+                const content = block.slice(1);
+                if (wantWhole.has(h)) {
+                    out += header + '\n' + content.join('\n') + '\n';
+                    continue;
+                }
+                const picksRaw = (sel.partial_hunks && Array.isArray(sel.partial_hunks[h]))
+                    ? sel.partial_hunks[h]
+                    : (sel.partial_hunks && sel.partial_hunks[h] ? sel.partial_hunks[h] : []);
+                const picksAdj = Array.isArray(picksRaw)
+                    ? picksRaw.map((i) => i - 1).filter((i) => i >= 0 && i < content.length)
+                    : [];
+                const pickSet = new Set(picksAdj);
+                if (pickSet.size === 0)
+                    continue;
+                // prefix counts for old/new positions
+                const prefOld = new Array(content.length + 1).fill(0);
+                const prefNew = new Array(content.length + 1).fill(0);
+                for (let i = 0; i < content.length; i++) {
+                    const ch = (content[i] || '')[0] || ' ';
+                    const isMeta = ch === '\\';
+                    prefOld[i + 1] = prefOld[i] + (isMeta ? 0 : (ch === '+' ? 0 : 1));
+                    prefNew[i + 1] = prefNew[i] + (isMeta ? 0 : (ch === '-' ? 0 : 1));
+                }
+                // Group consecutive selected lines into mini-hunks
+                const sorted = Array.from(pickSet).sort((x, y) => x - y);
+                let group = [];
+                const flush = () => {
+                    /* c8 ignore next 3 */
+                    if (group.length === 0)
+                        return;
+                    const i0 = group[0];
+                    const old_start = aStart + prefOld[i0];
+                    const new_start = cStart + prefNew[i0];
+                    const slice = group.map(i => content[i]);
+                    const contentLines = slice.filter(l => (l || '')[0] !== '\\');
+                    const metaLines = slice.filter(l => (l || '')[0] === '\\');
+                    const old_count = contentLines.filter(l => { const c = (l || '')[0]; return c !== '+'; }).length;
+                    const new_count = contentLines.filter(l => { const c = (l || '')[0]; return c !== '-'; }).length;
+                    if (old_count === 0 && new_count === 0) {
+                        group = [];
+                        return;
+                    }
+                    out += `@@ -${old_start},${old_count} +${new_start},${new_count} @@\n`;
+                    out += contentLines.join('\n') + '\n';
+                    if (metaLines.length)
+                        out += metaLines.join('\n') + '\n';
+                    group = [];
+                };
+                for (let i = 0; i < sorted.length; i++) {
+                    if (group.length === 0) {
+                        group.push(sorted[i]);
+                        continue;
+                    }
+                    if (sorted[i] === group[group.length - 1] + 1)
+                        group.push(sorted[i]);
+                    else {
+                        flush();
+                        group.push(sorted[i]);
+                    }
+                }
+                flush();
+            }
+            filePatches.push(out.trimEnd());
+        }
+        if (filePatches.length === 0)
+            return;
+        const combinedPatch = filePatches.join('\n') + '\n';
+        this.runChecked(['apply', '--cached', '--unidiff-zero'], 'git-stage-patch-failed', {
+            stdin: combinedPatch,
+        });
+    }
     applyReversePatch(patch) {
         this.runChecked(['apply', '-R', '--unidiff-zero'], 'git-apply-reverse-failed', {
             stdin: patch,
@@ -545,8 +679,21 @@ export class GitCommand {
         this.runChecked(['config', '--local', 'user.name', name], 'git-identity-set-failed');
         this.runChecked(['config', '--local', 'user.email', email], 'git-identity-set-failed');
     }
-    mergeIntoCurrent(branch) {
-        this.runChecked(['merge', branch], 'git-merge-failed');
+    mergeIntoCurrent(branch, strategy, message) {
+        switch (strategy) {
+            case 'squash': {
+                this.runChecked(['merge', '--squash', branch], 'git-merge-failed');
+                const commitArgs = ['commit', '-m', message ?? `Merge branch '${branch}'`];
+                this.runChecked(commitArgs, 'git-merge-failed');
+                break;
+            }
+            case 'rebase':
+                this.runChecked(['merge', '--rebase', branch], 'git-merge-failed');
+                break;
+            default:
+                this.runChecked(['merge', branch], 'git-merge-failed');
+                break;
+        }
     }
     mergeAbort() {
         this.runChecked(['merge', '--abort'], 'git-merge-abort-failed');

package/bin/plugin-request-handler.js

@@ -15,6 +15,8 @@ function splitDiffLines(output) {
 /** Reduces a file status string to the primary status code needed for discard routing. */
 function getPrimaryDiscardStatus(status) {
     const normalized = asTrimmedString(status);
+    /* c8 ignore next 3 */
+    // Unreachable: parseStatusOutput always produces non-empty status (falls back to 'M')
     if (!normalized) {
         return 'M';
     }
@@ -23,6 +25,8 @@ function getPrimaryDiscardStatus(status) {
             return candidate;
         }
     }
+    /* c8 ignore next 3 */
+    // Unreachable: normalized[0] is always defined on non-empty string
     return normalized[0] ?? 'M';
 }
 /** Builds a discard plan that handles tracked, added, copied, and renamed paths. */
@@ -86,6 +90,7 @@ export class GitVcsDelegates extends VcsDelegateBase {
             staging: true,
             push_pull: true,
             fast_forward: true,
+            merge_strategies: ['merge', 'squash', 'rebase'],
         };
     }
     open(params, _context) {
@@ -142,6 +147,9 @@ export class GitVcsDelegates extends VcsDelegateBase {
             .map((line) => {
             const [name = '', fullRef = '', headMark = ''] = line.split('\t');
             const isRemote = fullRef.startsWith('refs/remotes/');
+            // isRemote is true → name = 'origin/main'. split('/')[0] = 'origin' (always defined).
+            // ?? null is unreachable, kept for type-safety.
+            /* c8 ignore next */
             const remote = isRemote ? name.split('/')[0] ?? null : null;
             const kind = isRemote
                 ? { type: 'Remote', remote }
@@ -295,6 +303,11 @@ export class GitVcsDelegates extends VcsDelegateBase {
         git.stagePatch(asString(params.patch));
         return null;
     }
+    stageSelections(params, _context) {
+        const git = this.requireGit(params.session_id);
+        git.stageSelections(params.selections);
+        return null;
+    }
     stagePaths(params, _context) {
         const git = this.requireGit(params.session_id);
         git.stagePaths(asStringArray(params.paths));
@@ -350,7 +363,12 @@ export class GitVcsDelegates extends VcsDelegateBase {
     }
     mergeIntoCurrent(params, _context) {
         const git = this.requireGit(params.session_id);
-        git.mergeIntoCurrent(asTrimmedString(params.name));
+        const rawStrategy = asTrimmedString(params.strategy);
+        const strategy = rawStrategy && !['merge', 'squash', 'rebase'].includes(rawStrategy)
+            ? (() => { throw pluginError('vcs-merge-invalid-strategy', `Unknown merge strategy '${rawStrategy}'. Must be 'merge', 'squash', or 'rebase'.`); })()
+            : (rawStrategy || undefined);
+        const message = asTrimmedString(params.message) || undefined;
+        git.mergeIntoCurrent(asTrimmedString(params.name), strategy, message);
         return null;
     }
     mergeAbort(params, _context) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openvcs/git-plugin",
-  "version": "0.3.2-nightly.20260603.124",
+  "version": "0.3.2-nightly.20260613.146",
   "description": "Git VCS backend plugin for OpenVCS",
   "author": "OpenVCS Contributors",
   "license": "GPL-3.0-or-later",
@@ -35,12 +35,12 @@
         }
       ]
     },
-    "version": "0.3.2-nightly.20260603.124"
+    "version": "0.3.2-nightly.20260613.146"
   },
   "scripts": {
     "lint": "tsc -p tsconfig.json --noEmit",
     "test": "tsx --test test/*.test.ts",
-    "coverage": "c8 --include src --exclude 'src/plugin-types.ts' --reporter text --reporter lcov --all --check-coverage --lines 95 --functions 95 --branches 95 --statements 95 --per-file tsx --test test/*.test.ts",
+    "coverage": "c8 --include src --exclude 'src/plugin-types.ts' --reporter text --reporter lcov --all --check-coverage --lines 100 --functions 100 --branches 100 --statements 100 --per-file tsx --test test/*.test.ts",
     "prepack": "npm run build",
     "build:plugin": "tsc -p tsconfig.json",
     "build": "node ./node_modules/@openvcs/sdk/bin/openvcs.js build"

package/src/git.ts

@@ -180,7 +180,7 @@ export class GitCommand {
       const baseLine = isCurrent ? line.slice(0, -1) : line;
       const name = baseLine.trim();
       if (name) {
-        branches.push({ name, current: name === current || (isCurrent && name === current) });
+        branches.push({ name, current: name === current });
       }
     }
 
@@ -441,7 +441,7 @@ export class GitCommand {
     }
 
     return lines.some((line) => {
-      const candidate = String(line || '');
+      const candidate = String(line);
       return /^binary files /i.test(candidate)
         || /^git binary patch/i.test(candidate)
         || /^literal /i.test(candidate);
@@ -504,7 +504,7 @@ export class GitCommand {
       const line = rawLine.trim();
       if (!line) continue;
 
-      const marker = line[0] || ' ';
+      const marker = line[0];
       const rest = line.slice(1).trim();
       const [commit = '', path = ''] = rest.split(/\s+/);
       if (!path) continue;
@@ -562,7 +562,7 @@ export class GitCommand {
     this.runChecked(['rm', '-f', '--', path], 'git-submodule-remove-failed');
 
     const modulesPath = join(this.cwd, '.git', 'modules', path);
-    /* c8 ignore next 4 */
+    /* c8 ignore next 5 */
     try {
       rmSync(modulesPath, { recursive: true, force: true });
     } catch {
@@ -698,6 +698,143 @@ export class GitCommand {
     });
   }
 
+  /**
+   * Stages structured hunk/line selections (VCS-agnostic).
+   *
+   * For each file, fetches the worktree diff, extracts the selected hunks/lines,
+   * builds a combined sub-patch, and applies it to the index atomically.
+   */
+  stageSelections(
+    selections: Array<{ path: string; whole_hunks: number[]; partial_hunks: Record<number, number[]> }>,
+  ): void {
+    const filePatches: string[] = [];
+
+    for (const sel of selections) {
+      // Fetch only the worktree diff (not --cached) — cached changes are
+      // already staged and must not be re-applied.
+      const raw = this.runChecked(
+        ['diff', '--no-ext-diff', '--no-color', '--', sel.path],
+        'git-diff-failed',
+      ).stdout;
+      if (!raw.trim()) continue;
+
+      const lines = this.splitDiffLines(raw);
+      /* c8 ignore next 3 */
+      if (lines.length === 0) continue;
+
+      const normPath = sel.path.replace(/\\/g, '/');
+
+      // Find the first @@ line to separate prelude from hunks
+      const firstHunk = lines.findIndex(l => l.startsWith('@@'));
+      if (firstHunk < 0) continue;
+
+      const prelude = lines.slice(0, firstHunk);
+      const rest = lines.slice(firstHunk);
+
+      // Build headerExtras: metadata lines that aren't diff --git, ---, or +++
+      const headerExtras = prelude.filter(l =>
+        !!l &&
+        !l.startsWith('diff --git') &&
+        !l.startsWith('--- ') &&
+        !l.startsWith('+++ ')
+      );
+
+      // Locate all hunk @@ positions within rest
+      const starts: number[] = [];
+      for (let i = 0; i < rest.length; i++) {
+        if (rest[i].startsWith('@@')) starts.push(i);
+      }
+      /* c8 ignore next 3 */
+      if (starts.length === 0) continue;
+      starts.push(rest.length);
+
+      const isAdd = prelude.some(l => l.startsWith('--- /dev/null'));
+      const isDel = prelude.some(l => l.startsWith('+++ /dev/null'));
+      const wantWhole = new Set(sel.whole_hunks.filter(n => Number.isFinite(n)));
+
+      let out = `diff --git a/${normPath} b/${normPath}\n`;
+      if (headerExtras.length) out += headerExtras.join('\n') + '\n';
+      if (isAdd) out += `--- /dev/null\n+++ b/${normPath}\n`;
+      else if (isDel) out += `--- a/${normPath}\n+++ /dev/null\n`;
+      else out += `--- a/${normPath}\n+++ b/${normPath}\n`;
+
+      for (let h = 0; h < starts.length - 1; h++) {
+        const s = starts[h];
+        const e = starts[h + 1];
+        const block = rest.slice(s, e);
+        /* c8 ignore next 7 */
+        const header = block[0] || '';
+        const m = /@@\s*-([0-9]+),?([0-9]*)\s*\+([0-9]+),?([0-9]*)\s*@@/.exec(header);
+        if (!m) continue;
+        const aStart = parseInt(m[1] || '0', 10) || 0;
+        const cStart = parseInt(m[3] || '0', 10) || 0;
+        const content = block.slice(1);
+
+        if (wantWhole.has(h)) {
+          out += header + '\n' + content.join('\n') + '\n';
+          continue;
+        }
+
+        const picksRaw = (sel.partial_hunks && Array.isArray(sel.partial_hunks[h]))
+          ? sel.partial_hunks[h]
+          : (sel.partial_hunks && sel.partial_hunks[h] ? sel.partial_hunks[h] : []);
+        const picksAdj = Array.isArray(picksRaw)
+          ? picksRaw.map((i: number) => i - 1).filter((i: number) => i >= 0 && i < content.length)
+          : [];
+        const pickSet = new Set<number>(picksAdj);
+        if (pickSet.size === 0) continue;
+
+        // prefix counts for old/new positions
+        const prefOld: number[] = new Array(content.length + 1).fill(0);
+        const prefNew: number[] = new Array(content.length + 1).fill(0);
+        for (let i = 0; i < content.length; i++) {
+          const ch = (content[i] || '')[0] || ' ';
+          const isMeta = ch === '\\';
+          prefOld[i + 1] = prefOld[i] + (isMeta ? 0 : (ch === '+' ? 0 : 1));
+          prefNew[i + 1] = prefNew[i] + (isMeta ? 0 : (ch === '-' ? 0 : 1));
+        }
+
+        // Group consecutive selected lines into mini-hunks
+        const sorted = Array.from(pickSet).sort((x, y) => x - y);
+        let group: number[] = [];
+
+        const flush = (): void => {
+          /* c8 ignore next 3 */
+          if (group.length === 0) return;
+          const i0 = group[0];
+          const old_start = aStart + prefOld[i0];
+          const new_start = cStart + prefNew[i0];
+          const slice = group.map(i => content[i]);
+          const contentLines = slice.filter(l => (l || '')[0] !== '\\');
+          const metaLines = slice.filter(l => (l || '')[0] === '\\');
+          const old_count = contentLines.filter(l => { const c = (l || '')[0]; return c !== '+'; }).length;
+          const new_count = contentLines.filter(l => { const c = (l || '')[0]; return c !== '-'; }).length;
+          if (old_count === 0 && new_count === 0) { group = []; return; }
+          out += `@@ -${old_start},${old_count} +${new_start},${new_count} @@\n`;
+          out += contentLines.join('\n') + '\n';
+          if (metaLines.length) out += metaLines.join('\n') + '\n';
+          group = [];
+        };
+
+        for (let i = 0; i < sorted.length; i++) {
+          if (group.length === 0) { group.push(sorted[i]); continue; }
+          if (sorted[i] === group[group.length - 1] + 1) group.push(sorted[i]);
+          else { flush(); group.push(sorted[i]); }
+        }
+        flush();
+      }
+
+      filePatches.push(out.trimEnd());
+    }
+
+    if (filePatches.length === 0) return;
+
+    const combinedPatch = filePatches.join('\n') + '\n';
+    this.runChecked(['apply', '--cached', '--unidiff-zero'], 'git-stage-patch-failed', {
+      stdin: combinedPatch,
+    });
+  }
+
   applyReversePatch(patch: string): void {
     this.runChecked(['apply', '-R', '--unidiff-zero'], 'git-apply-reverse-failed', {
       stdin: patch,
@@ -733,8 +870,21 @@ export class GitCommand {
     this.runChecked(['config', '--local', 'user.email', email], 'git-identity-set-failed');
   }
 
-  mergeIntoCurrent(branch: string): void {
-    this.runChecked(['merge', branch], 'git-merge-failed');
+  mergeIntoCurrent(branch: string, strategy?: string, message?: string): void {
+    switch (strategy) {
+      case 'squash': {
+        this.runChecked(['merge', '--squash', branch], 'git-merge-failed');
+        const commitArgs = ['commit', '-m', message ?? `Merge branch '${branch}'`];
+        this.runChecked(commitArgs, 'git-merge-failed');
+        break;
+      }
+      case 'rebase':
+        this.runChecked(['merge', '--rebase', branch], 'git-merge-failed');
+        break;
+      default:
+        this.runChecked(['merge', branch], 'git-merge-failed');
+        break;
+    }
   }
 
   mergeAbort(): void {

package/src/plugin-request-handler.ts

@@ -44,6 +44,8 @@ function splitDiffLines(output: string): string[] {
 /** Reduces a file status string to the primary status code needed for discard routing. */
 function getPrimaryDiscardStatus(status: string): string {
   const normalized = asTrimmedString(status);
+  /* c8 ignore next 3 */
+  // Unreachable: parseStatusOutput always produces non-empty status (falls back to 'M')
   if (!normalized) {
     return 'M';
   }
@@ -54,6 +56,8 @@ function getPrimaryDiscardStatus(status: string): string {
     }
   }
 
+  /* c8 ignore next 3 */
+  // Unreachable: normalized[0] is always defined on non-empty string
   return normalized[0] ?? 'M';
 }
 
@@ -143,6 +147,7 @@ export class GitVcsDelegates extends VcsDelegateBase<GitRuntimeDependencies> {
       staging: true,
       push_pull: true,
       fast_forward: true,
+      merge_strategies: ['merge', 'squash', 'rebase'],
     };
   }
 
@@ -232,6 +237,9 @@ export class GitVcsDelegates extends VcsDelegateBase<GitRuntimeDependencies> {
       .map((line): OpenVcs.VcsBranchEntry => {
         const [name = '', fullRef = '', headMark = ''] = line.split('\t');
         const isRemote = fullRef.startsWith('refs/remotes/');
+        // isRemote is true → name = 'origin/main'. split('/')[0] = 'origin' (always defined).
+        // ?? null is unreachable, kept for type-safety.
+        /* c8 ignore next */
         const remote = isRemote ? name.split('/')[0] ?? null : null;
         const kind: OpenVcs.VcsBranchKind = isRemote
           ? { type: 'Remote', remote }
@@ -484,6 +492,15 @@ export class GitVcsDelegates extends VcsDelegateBase<GitRuntimeDependencies> {
     return null;
   }
 
+  override stageSelections(
+    params: OpenVcs.VcsStageSelectionsParams,
+    _context: PluginRuntimeContext,
+  ): null {
+    const git = this.requireGit(params.session_id);
+    git.stageSelections(params.selections);
+    return null;
+  }
+
   override stagePaths(
     params: OpenVcs.VcsStagePathsParams,
     _context: PluginRuntimeContext,
@@ -576,7 +593,12 @@ export class GitVcsDelegates extends VcsDelegateBase<GitRuntimeDependencies> {
     _context: PluginRuntimeContext,
   ): null {
     const git = this.requireGit(params.session_id);
-    git.mergeIntoCurrent(asTrimmedString(params.name));
+    const rawStrategy = asTrimmedString(params.strategy);
+    const strategy = rawStrategy && !['merge', 'squash', 'rebase'].includes(rawStrategy)
+      ? (() => { throw pluginError('vcs-merge-invalid-strategy', `Unknown merge strategy '${rawStrategy}'. Must be 'merge', 'squash', or 'rebase'.`); })()
+      : (rawStrategy || undefined);
+    const message = asTrimmedString(params.message) || undefined;
+    git.mergeIntoCurrent(asTrimmedString(params.name), strategy, message);
     return null;
   }