@openui5/sap.ui.table 1.123.1 → 1.124.0

package/.eslintrc.json

@@ -13,7 +13,14 @@
 				"jQuery": "off"
 			},
 			"rules": {
-				"space-before-function-paren": ["error", "never"],
+				"no-var": "error",
+				"one-var": ["error", {"const": "never", "let": "never"}],
+				"one-var-declaration-per-line": ["error", "always"],
+				"space-before-function-paren": ["error", {
+					"anonymous": "never",
+					"named": "never",
+					"asyncArrow": "always"
+				}],
 				"space-before-blocks": "error",
 				"space-in-parens": "error",
 				"block-spacing": "error",
@@ -28,6 +35,7 @@
 				"no-whitespace-before-property": "error",
 				"object-curly-newline": ["error", {"consistent": true}],
 				"object-curly-spacing": "error",
+				"eqeqeq": ["error", "always", {"null": "ignore"}],
 				"max-depth": ["warn", 4],
 				"max-len": ["warn", 150],
 				"complexity": ["warn", { "max": 12 }]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openui5/sap.ui.table",
-  "version": "1.123.1",
+  "version": "1.124.0",
   "description": "OpenUI5 UI Library sap.ui.table",
   "author": "SAP SE (https://www.sap.com)",
   "license": "Apache-2.0",
@@ -14,7 +14,7 @@
     "url": "https://github.com/SAP/openui5.git"
   },
   "dependencies": {
-    "@openui5/sap.ui.core": "1.123.1",
-    "@openui5/sap.ui.unified": "1.123.1"
+    "@openui5/sap.ui.core": "1.124.0",
+    "@openui5/sap.ui.unified": "1.124.0"
   }
 }

package/src/sap/ui/table/.library

@@ -6,7 +6,7 @@
   <copyright>OpenUI5
  * (c) Copyright 2009-2024 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.</copyright>
-  <version>1.123.1</version>
+  <version>1.124.0</version>
 
   <documentation>Table-like controls, mainly for desktop scenarios.</documentation>
 

package/src/sap/ui/table/AnalyticalColumn.js

@@ -30,7 +30,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	var GroupEventType = library.GroupEventType;
+	const GroupEventType = library.GroupEventType;
 
 	function isInstanceOfAnalyticalTable(oControl) {
 		return TableUtils.isA(oControl, "sap.ui.table.AnalyticalTable");
@@ -47,13 +47,13 @@ sap.ui.define([
 	 * @extends sap.ui.table.Column
 	 *
 	 * @author SAP SE
-	 * @version 1.123.1
+	 * @version 1.124.0
 	 *
 	 * @constructor
 	 * @public
 	 * @alias sap.ui.table.AnalyticalColumn
 	 */
-	var AnalyticalColumn = Column.extend("sap.ui.table.AnalyticalColumn", /** @lends sap.ui.table.AnalyticalColumn.prototype */ {metadata: {
+	const AnalyticalColumn = Column.extend("sap.ui.table.AnalyticalColumn", /** @lends sap.ui.table.AnalyticalColumn.prototype */ {metadata: {
 
 		library: "sap.ui.table",
 		properties: {
@@ -105,23 +105,23 @@ sap.ui.define([
 	};
 
 	AnalyticalColumn.prototype._setGrouped = function(bGrouped) {
-		var oTable = this._getTable();
-		var sGroupEventType = bGrouped ? GroupEventType.group : GroupEventType.ungroup;
+		const oTable = this._getTable();
+		const sGroupEventType = bGrouped ? GroupEventType.group : GroupEventType.ungroup;
 
 		this.setGrouped(bGrouped);
 		oTable.fireGroup({column: this, groupedColumns: oTable._aGroupedColumns, type: sGroupEventType});
 	};
 
 	AnalyticalColumn.prototype._isAggregatableByMenu = function() {
-		var oTable = this._getTable(),
-			oBinding = oTable.getBinding(),
-			oResultSet = oBinding && oBinding.getAnalyticalQueryResult();
+		const oTable = this._getTable();
+		const oBinding = oTable.getBinding();
+		const oResultSet = oBinding && oBinding.getAnalyticalQueryResult();
 
 		return oTable && oResultSet && oResultSet.findMeasureByPropertyName(this.getLeadingProperty());
 	};
 
 	AnalyticalColumn.prototype.setGrouped = function(bGrouped) {
-		var oParent = this.getParent();
+		const oParent = this.getParent();
 
 		if (isInstanceOfAnalyticalTable(oParent)) {
 			if (bGrouped) {
@@ -131,14 +131,14 @@ sap.ui.define([
 			}
 		}
 
-		var bReturn = this.setProperty("grouped", bGrouped);
+		const bReturn = this.setProperty("grouped", bGrouped);
 		this._updateColumns();
 
 		return bReturn;
 	};
 
 	AnalyticalColumn.prototype.setSummed = function(bSummed) {
-		var bReturn = this.setProperty("summed", bSummed, true);
+		const bReturn = this.setProperty("summed", bSummed, true);
 		this._updateTableAnalyticalInfo();
 		return bReturn;
 	};
@@ -150,13 +150,13 @@ sap.ui.define([
 	};
 
 	AnalyticalColumn.prototype.getLabel = function() {
-		var oLabel = this.getAggregation("label");
+		let oLabel = this.getAggregation("label");
 		try {
 			if (!oLabel) {
 				if (!this._oBindingLabel) {
-					var oParent = this.getParent();
+					const oParent = this.getParent();
 					if (isInstanceOfAnalyticalTable(oParent)) {
-						var oBinding = oParent.getBinding();
+						const oBinding = oParent.getBinding();
 						if (oBinding) {
 							this._oBindingLabel = TableUtils._getTableTemplateHelper().createLabel();
 							this.addDependent(this._oBindingLabel);
@@ -175,12 +175,12 @@ sap.ui.define([
 	};
 
 	AnalyticalColumn.prototype.getFilterProperty = function() {
-		var sProperty = this.getProperty("filterProperty");
+		let sProperty = this.getProperty("filterProperty");
 		if (!sProperty) {
-			var oParent = this.getParent();
+			const oParent = this.getParent();
 			if (isInstanceOfAnalyticalTable(oParent)) {
-				var oBinding = oParent.getBinding();
-				var sLeadingProperty = this.getLeadingProperty();
+				const oBinding = oParent.getBinding();
+				const sLeadingProperty = this.getLeadingProperty();
 				if (oBinding && oBinding.getFilterablePropertyNames().indexOf(sLeadingProperty) > -1) {
 					sProperty = sLeadingProperty;
 				}
@@ -190,12 +190,12 @@ sap.ui.define([
 	};
 
 	AnalyticalColumn.prototype.getSortProperty = function() {
-		var sProperty = this.getProperty("sortProperty");
+		let sProperty = this.getProperty("sortProperty");
 		if (!sProperty) {
-			var oParent = this.getParent();
+			const oParent = this.getParent();
 			if (isInstanceOfAnalyticalTable(oParent)) {
-				var oBinding = oParent.getBinding();
-				var sLeadingProperty = this.getLeadingProperty();
+				const oBinding = oParent.getBinding();
+				const sLeadingProperty = this.getLeadingProperty();
 				if (oBinding && oBinding.getSortablePropertyNames().indexOf(sLeadingProperty) > -1) {
 					sProperty = sLeadingProperty;
 				}
@@ -205,13 +205,13 @@ sap.ui.define([
 	};
 
 	AnalyticalColumn.prototype.getFilterType = function() {
-		var vFilterType = this.getProperty("filterType");
+		let vFilterType = this.getProperty("filterType");
 		if (!vFilterType) {
-			var oParent = this.getParent();
+			const oParent = this.getParent();
 			if (isInstanceOfAnalyticalTable(oParent)) {
-				var oBinding = oParent.getBinding();
-				var sLeadingProperty = this.getLeadingProperty(),
-					oProperty = oBinding && oBinding.getProperty(sLeadingProperty);
+				const oBinding = oParent.getBinding();
+				const sLeadingProperty = this.getLeadingProperty();
+				const oProperty = oBinding && oBinding.getProperty(sLeadingProperty);
 				if (oProperty) {
 					switch (oProperty.type) {
 						case "Edm.Time":
@@ -243,21 +243,21 @@ sap.ui.define([
 	};
 
 	AnalyticalColumn.prototype._updateColumns = function(bSupressRefresh, bForceChange) {
-		var oParent = this.getParent();
+		const oParent = this.getParent();
 		if (isInstanceOfAnalyticalTable(oParent)) {
 			oParent._updateColumns(bSupressRefresh, bForceChange);
 		}
 	};
 
 	AnalyticalColumn.prototype._updateTableAnalyticalInfo = function(bSupressRefresh) {
-		var oParent = this.getParent();
+		const oParent = this.getParent();
 		if (oParent && isInstanceOfAnalyticalTable(oParent) && !oParent._bSuspendUpdateAnalyticalInfo) {
 			oParent.updateAnalyticalInfo(bSupressRefresh);
 		}
 	};
 
 	AnalyticalColumn.prototype._updateTableColumnDetails = function() {
-		var oParent = this.getParent();
+		const oParent = this.getParent();
 		if (oParent && isInstanceOfAnalyticalTable(oParent) && !oParent._bSuspendUpdateAnalyticalInfo) {
 			oParent._updateTableColumnDetails();
 		}
@@ -276,10 +276,10 @@ sap.ui.define([
 	 * @deprecated As of Version 1.117
 	 */
 	AnalyticalColumn.prototype._menuHasItems = function() {
-		var fnMenuHasItems = function() {
-			var oTable = this.getParent();
-			var oBinding = oTable.getBinding();
-			var oResultSet = oBinding && oBinding.getAnalyticalQueryResult();
+		const fnMenuHasItems = function() {
+			const oTable = this.getParent();
+			const oBinding = oTable.getBinding();
+			const oResultSet = oBinding && oBinding.getAnalyticalQueryResult();
 			return (oTable && oResultSet && oResultSet.findMeasureByPropertyName(this.getLeadingProperty())); // totals menu entry
 		}.bind(this);
 
@@ -301,16 +301,16 @@ sap.ui.define([
 	 * @returns {boolean}
 	 */
 	AnalyticalColumn.prototype.isFilterableByMenu = function() {
-		var sFilterProperty = this.getFilterProperty();
+		const sFilterProperty = this.getFilterProperty();
 		if (!sFilterProperty || !this.getShowFilterMenuEntry()) {
 			// not required to get binding and do addtional checks if there is no filterProperty set or derived
 			// or if the filter menu entry shall not be displayed at all
 			return false;
 		}
 
-		var oParent = this.getParent();
+		const oParent = this.getParent();
 		if (isInstanceOfAnalyticalTable(oParent)) {
-			var oBinding = oParent.getBinding();
+			const oBinding = oParent.getBinding();
 			// metadata must be evaluated which can only be done when the collection is known and the metadata is loaded
 			// this is usually the case when a binding exists.
 			if (oBinding) {
@@ -345,12 +345,12 @@ sap.ui.define([
 	 * @return {boolean} <code>true</code> if the column is groupable
 	 */
 	AnalyticalColumn.prototype.isGroupableByMenu = function() {
-		var oParent = this.getParent();
+		const oParent = this.getParent();
 
 		if (isInstanceOfAnalyticalTable(oParent)) {
-			var oBinding = oParent.getBinding();
+			const oBinding = oParent.getBinding();
 			if (oBinding) {
-				var oResultSet = oBinding.getAnalyticalQueryResult();
+				const oResultSet = oBinding.getAnalyticalQueryResult();
 				if (oResultSet && oResultSet.findDimensionByPropertyName(this.getLeadingProperty())
 					&& oBinding.getSortablePropertyNames().indexOf(this.getLeadingProperty()) > -1
 					&& oBinding.getFilterablePropertyNames().indexOf(this.getLeadingProperty()) > -1) {

package/src/sap/ui/table/AnalyticalColumnMenu.js

@@ -20,7 +20,7 @@ sap.ui.define(['./ColumnMenu', "sap/ui/unified/MenuRenderer", './utils/TableUtil
 	 * @extends sap.ui.table.ColumnMenu
 	 *
 	 * @author SAP SE
-	 * @version 1.123.1
+	 * @version 1.124.0
 	 *
 	 * @constructor
 	 * @public
@@ -29,7 +29,7 @@ sap.ui.define(['./ColumnMenu', "sap/ui/unified/MenuRenderer", './utils/TableUtil
 	 *
 	 * @deprecated As of version 1.117, replaced by the <code>headerMenu</code> association of <code>sap.ui.table.Column</code>.
 	 */
-	var AnalyticalColumnMenu = ColumnMenu.extend("sap.ui.table.AnalyticalColumnMenu", /** @lends sap.ui.table.AnalyticalColumnMenu.prototype */ {
+	const AnalyticalColumnMenu = ColumnMenu.extend("sap.ui.table.AnalyticalColumnMenu", /** @lends sap.ui.table.AnalyticalColumnMenu.prototype */ {
 		metadata: {
 			library: "sap.ui.table"
 		},
@@ -53,8 +53,8 @@ sap.ui.define(['./ColumnMenu', "sap/ui/unified/MenuRenderer", './utils/TableUtil
 	 * @private
 	 */
 	AnalyticalColumnMenu.prototype._addGroupMenuItem = function() {
-		var oColumn = this._getColumn();
-		var oTable = this._getTable();
+		const oColumn = this._getColumn();
+		const oTable = this._getTable();
 
 		if (oColumn.isGroupableByMenu()) {
 			this._oGroupIcon = this._createMenuItem(
@@ -62,11 +62,11 @@ sap.ui.define(['./ColumnMenu', "sap/ui/unified/MenuRenderer", './utils/TableUtil
 				"TBL_GROUP",
 				oColumn.getGrouped() ? "accept" : null,
 				function(oEvent) {
-					var oMenuItem = oEvent.getSource();
-					var bGrouped = !oColumn.getGrouped();
+					const oMenuItem = oEvent.getSource();
+					const bGrouped = !oColumn.getGrouped();
 
 					if (bGrouped && !oColumn.getShowIfGrouped()) {
-						var oDomRef;
+						let oDomRef;
 
 						if (TableUtils.isNoDataVisible(oTable)) {
 							oDomRef = oTable.getDomRef("noDataCnt");
@@ -92,7 +92,7 @@ sap.ui.define(['./ColumnMenu', "sap/ui/unified/MenuRenderer", './utils/TableUtil
 	 * @private
 	 */
 	AnalyticalColumnMenu.prototype._addSumMenuItem = function() {
-		var oColumn = this._getColumn();
+		const oColumn = this._getColumn();
 
 		if (oColumn._isAggregatableByMenu()) {
 			this._oSumItem = this._createMenuItem(
@@ -100,8 +100,8 @@ sap.ui.define(['./ColumnMenu', "sap/ui/unified/MenuRenderer", './utils/TableUtil
 				"TBL_TOTAL",
 				oColumn.getSummed() ? "accept" : null,
 				jQuery.proxy(function(oEvent) {
-					var oMenuItem = oEvent.getSource(),
-						bSummed = oColumn.getSummed();
+					const oMenuItem = oEvent.getSource();
+					const bSummed = oColumn.getSummed();
 
 					oColumn.setSummed(!bSummed);
 					oMenuItem.setIcon(!bSummed ? "sap-icon://accept" : null);
@@ -114,7 +114,7 @@ sap.ui.define(['./ColumnMenu', "sap/ui/unified/MenuRenderer", './utils/TableUtil
 	AnalyticalColumnMenu.prototype.open = function() {
 		ColumnMenu.prototype.open.apply(this, arguments);
 
-		var oColumn = this._getColumn();
+		const oColumn = this._getColumn();
 		this._oSumItem && this._oSumItem.setIcon(oColumn.getSummed() ? "sap-icon://accept" : null);
 		this._oGroupIcon && this._oGroupIcon.setIcon(oColumn.getGrouped() ? "sap-icon://accept" : null);
 	};