@openui5/sap.ui.table 1.119.1 → 1.120.1

package/src/sap/ui/table/rules/Plugins.support.js

@@ -5,46 +5,48 @@
  */
 sap.ui.define([
 	"./TableHelper.support",
-	"sap/ui/support/library"
-], function(SupportHelper, SupportLibrary) {
+	"sap/ui/support/library",
+	"sap/m/plugins/PluginBase"
+], function(SupportHelper, SupportLibrary, PluginBase) {
 	"use strict";
 
 	var Categories = SupportLibrary.Categories;
 	var Severity = SupportLibrary.Severity;
 
-	/*
+	/**
 	 * Checks the number and type of plugins which are applied to the table.
 	 */
-	var oPlugins = SupportHelper.normalizeRule({
+	var oSelectionPlugins = SupportHelper.normalizeRule({
 		id: "Plugins",
 		minversion: "1.64",
 		categories: [Categories.Usage],
-		title: "Plugins validation",
-		description: "Checks the number and type of plugins which are applied to the table. Only one selection plugin can be applied. "
-					 + "No other plugins are allowed.",
-		resolution: "Check if multiple selection plugins are applied, or a plugin of another type is applied to the table.",
+		title: "Single selection plugin",
+		description: "Only one selection plugin should be applied to avoid potential conflicts.",
+		resolution: "Only apply a single selection plugin.",
 		check: function(oIssueManager, oCoreFacade, oScope) {
 			var aTables = SupportHelper.find(oScope, true, "sap.ui.table.Table");
 
 			for (var i = 0; i < aTables.length; i++) {
 				var oTable = aTables[i];
-				var aPlugins = oTable.getPlugins();
-				if (aPlugins.length > 1) {
-					SupportHelper.reportIssue(oIssueManager,
-						"Only one plugin can be applied to the table",
-						Severity.High, oTable.getId());
-				} else if (aPlugins.length == 1) {
-					var oPlugin = aPlugins[0];
-					if (!oPlugin.isA("sap.ui.table.plugins.SelectionPlugin")) {
-						SupportHelper.reportIssue(oIssueManager,
-							"Only a selection plugin can be applied to the table",
-							Severity.High, oTable.getId());
-					}
+				var aSelectionPlugins = oTable.getDependents().filter((oPlugin) => oPlugin.isA("sap.ui.table.plugins.SelectionPlugin"));
+
+				/**
+				 * @deprecated As of version 1.120
+				 */
+				aSelectionPlugins.concat(oTable.getPlugins());
+
+				if (aSelectionPlugins.length > 1) {
+					SupportHelper.reportIssue(
+						oIssueManager,
+						"Only one selection plugin should be applied to the table",
+						Severity.High,
+						oTable.getId()
+					);
 				}
 			}
 		}
 	});
 
-	return [oPlugins];
+	return [oSelectionPlugins];
 
 }, true);

package/src/sap/ui/table/rules/Rows.support.js

@@ -4,11 +4,18 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 sap.ui.define([
+	"sap/ui/table/rowmodes/Type",
 	"./TableHelper.support",
 	"sap/ui/support/library",
 	"sap/ui/Device",
 	"sap/ui/thirdparty/jquery"
-], function(SupportHelper, SupportLibrary, Device, jQuery) {
+], function(
+	RowModeType,
+	SupportHelper,
+	SupportLibrary,
+	Device,
+	jQuery
+) {
 	"use strict";
 
 	var Categories = SupportLibrary.Categories;
@@ -164,13 +171,25 @@ sap.ui.define([
 			}
 
 			function checkConfiguration(oTable, oDynamicPage) {
-				if (oTable._getRowMode().isA("sap.ui.table.rowmodes.Auto") && !oDynamicPage.getFitContent()) {
+				var vRowMode = oTable.getRowMode();
+				var bIsTableInAutoMode = false;
+
+				/**
+				 * @deprecated As of version 1.119
+				 */
+				if (!vRowMode) {
+					bIsTableInAutoMode = oTable.getVisibleRowCountMode() === "Auto";
+				}
+
+				if (vRowMode) {
+					bIsTableInAutoMode = vRowMode === RowModeType.Auto || vRowMode.isA("sap.ui.table.rowmodes.Auto");
+				}
+
+				if (bIsTableInAutoMode && !oDynamicPage.getFitContent()) {
 					SupportHelper.reportIssue(oIssueManager,
 						"A table with an auto row mode is placed inside a sap.f.DynamicPage with fitContent=\"false\"",
 						Severity.High, oTable.getId());
-				} else if ((oTable._getRowMode().isA("sap.ui.table.rowmodes.Fixed")
-							|| oTable._getRowMode().isA("sap.ui.table.rowmodes.Interactive"))
-						   && oDynamicPage.getFitContent()) {
+				} else if (!bIsTableInAutoMode && oDynamicPage.getFitContent()) {
 					SupportHelper.reportIssue(oIssueManager,
 						"A table with a fixed or interactive row mode is placed inside a sap.f.DynamicPage with fitContent=\"true\"",
 						Severity.Low, oTable.getId());

package/src/sap/ui/table/themes/base/Cell.less

@@ -25,7 +25,7 @@
 		position: absolute;
 		inset: 0;
 		pointer-events: none;
-		outline: @_sap_ui_table_FocusOutlineWidth @sapUiContentFocusStyle @sapUiContentFocusColor;
+		outline: @sapUiContentFocusWidth @sapUiContentFocusStyle @sapUiContentFocusColor;
 		outline-offset: @_sap_ui_table_Cell_FocusOutlineOffset;
 
 		.sapUiTableZoomout & {

package/src/sap/ui/table/themes/base/Grouping.less

@@ -8,7 +8,7 @@
 @_sap_ui_table_Grouping_GroupIconHeightCondensed: @_sap_ui_table_RowHeightCondensed;
 @_sap_ui_table_Grouping_GroupHeaderBackground: @sapUiListTableGroupHeaderBackground;
 @_sap_ui_table_Grouping_GroupHeaderFadingWidth: 40px;
-@_sap_ui_table_Grouping_GroupOutlineWidth: @_sap_ui_table_FocusOutlineWidth;
+@_sap_ui_table_Grouping_GroupOutlineWidth: @sapUiContentFocusWidth;
 @_sap_ui_table_Grouping_GroupIconBorderWidth: @_sap_ui_table_BaseBorderWidth;
 @_sap_ui_table_Grouping_GroupIconFontSize: @sapMFontMediumSize;
 

package/src/sap/ui/table/themes/base/Table.less

@@ -187,7 +187,7 @@
 .sapUiTableOverlayArea:focus,
 .sapUiTableCtrlEmpty:focus,
 .sapUiTableCnt > .sapUiLocalBusyIndicator:focus {
-	outline-width: @_sap_ui_table_FocusOutlineWidth;
+	outline-width: @sapUiContentFocusWidth;
 	outline-style: @sapUiContentFocusStyle;
 	outline-offset: -3px;
 	outline-color: @sapUiContentFocusColor;

package/src/sap/ui/table/themes/base/library.source.less

@@ -45,9 +45,6 @@
 @_sap_ui_table_DeleteIcon: sys-cancel;
 @_sap_ui_table_ClearSelectionIcon: clear-all;
 
-/*TBD: Table specific parameter should be removed and replaced with sapUiContentFocusWidth*/
-@_sap_ui_table_FocusOutlineWidth: @sapUiContentFocusWidth;
-
 @import "Table.less";
 @import "Row.less";
 @import "CreationRow.less";

package/src/sap/ui/table/themes/sap_hcb/library.source.less

@@ -7,9 +7,6 @@
 @import "../base/library.source.less";
 @import "../../../../../sap/ui/core/themes/sap_hcb/global.less";
 
-/* shared local library less parameters */
-@_sap_ui_table_FocusOutlineWidth: 2px;
-
 @import "Table.less";
 @import "Row.less";
 @import "RowHighlight.less";

package/src/sap/ui/table/utils/TableUtils.js

@@ -17,6 +17,7 @@ sap.ui.define([
 	"sap/ui/core/library",
 	"sap/ui/core/theming/Parameters",
 	"sap/ui/core/Icon",
+	"sap/ui/core/Lib",
 	"sap/ui/model/ChangeReason",
 	"sap/ui/thirdparty/jquery",
 	"sap/base/util/restricted/_throttle",
@@ -33,6 +34,7 @@ sap.ui.define([
 	coreLibrary,
 	ThemeParameters,
 	Icon,
+	Lib,
 	ChangeReason,
 	jQuery,
 	throttle,
@@ -207,7 +209,7 @@ sap.ui.define([
 	 * Static collection of utility functions related to the sap.ui.table.Table, ...
 	 *
 	 * @author SAP SE
-	 * @version 1.119.1
+	 * @version 1.120.1
 	 * @namespace
 	 * @alias sap.ui.table.utils.TableUtils
 	 * @private
@@ -341,8 +343,7 @@ sap.ui.define([
 		 * @returns {boolean} Whether the no data text is shown.
 		 */
 		isNoDataVisible: function(oTable) {
-			return oTable.getShowNoData() && (oTable._getRowMode() && !oTable._getRowMode().isNoDataDisabled()) && !TableUtils.hasData(oTable)
-				   || TableUtils.getVisibleColumnCount(oTable) === 0;
+			return !oTable._isNoDataDisabled() && !TableUtils.hasData(oTable) || TableUtils.getVisibleColumnCount(oTable) === 0;
 		},
 
 		/**
@@ -380,7 +381,7 @@ sap.ui.define([
 		 * @returns {boolean} Whether this object is an instance of the given type or of any of the given types.
 		 */
 		isA: function(oObject, vTypeName) {
-			return BaseObject.isA(oObject, vTypeName);
+			return BaseObject.isObjectA(oObject, vTypeName);
 		},
 
 		/**
@@ -1182,15 +1183,12 @@ sap.ui.define([
 				}
 			}
 
-			var vResult = sap.ui.getCore().getLibraryResourceBundle("sap.ui.table", mOptions.async === true);
+			var vResult = Lib.getResourceBundleFor("sap.ui.table");
 
-			if (vResult instanceof Promise) {
-				vResult = vResult.then(function(oBundle) {
-					oResourceBundle = oBundle;
-					return oResourceBundle;
-				});
-			} else {
-				oResourceBundle = vResult;
+			oResourceBundle = vResult;
+
+			if (mOptions.async === true) {
+				vResult = Promise.resolve(oResourceBundle);
 			}
 
 			return vResult;

package/src/sap/ui/table/utils/_BindingUtils.js

@@ -14,7 +14,7 @@ sap.ui.define([], function() {
 	 * Note: Do not access the functions of this helper directly, but via <code>sap.ui.table.utils.TableUtils.Binding...</code>
 	 *
 	 * @author SAP SE
-	 * @version 1.119.1
+	 * @version 1.120.1
 	 * @namespace
 	 * @alias sap.ui.table.utils._BindingUtils
 	 * @private

package/src/sap/ui/table/utils/_ColumnUtils.js

@@ -18,7 +18,7 @@ sap.ui.define([
 	 * Note: Do not access the functions of this helper directly, but via <code>sap.ui.table.utils.TableUtils.Column...</code>
 	 *
 	 * @author SAP SE
-	 * @version 1.119.1
+	 * @version 1.120.1
 	 * @namespace
 	 * @alias sap.ui.table.utils._ColumnUtils
 	 * @private

package/src/sap/ui/table/utils/_GroupingUtils.js

@@ -23,7 +23,7 @@ sap.ui.define([
 	 * Note: Do not access the functions of this helper directly, but via <code>sap.ui.table.utils.TableUtils.Grouping...</code>
 	 *
 	 * @author SAP SE
-	 * @version 1.119.1
+	 * @version 1.120.1
 	 * @namespace
 	 * @alias sap.ui.table.utils._GroupingUtils
 	 * @private

package/src/sap/ui/table/utils/_HookUtils.js

@@ -5,7 +5,7 @@
  */
 
 // Provides helper sap.ui.table.utils._HookUtils.
-sap.ui.define(["sap/ui/base/DataType"], function(DataType) {
+sap.ui.define(["sap/ui/base/DataType", "sap/ui/model/ChangeReason"], function(DataType, ChangeReason) {
 	"use strict";
 
 	var Hooks = new window.WeakMap();
@@ -22,7 +22,7 @@ sap.ui.define(["sap/ui/base/DataType"], function(DataType) {
 	 * - There is no concept for public or protected hooks. Never expose a hook directly, only indirectly as can be seen in the examples.
 	 *
 	 * @author SAP SE
-	 * @version 1.119.1
+	 * @version 1.120.1
 	 * @namespace
 	 * @alias sap.ui.table.utils._HookUtils
 	 *
@@ -176,6 +176,33 @@ sap.ui.define(["sap/ui/base/DataType"], function(DataType) {
 				]
 			}
 		},
+		TableRenderer: {
+			RenderTableStyles: {
+				arguments: [
+					{type: "object" /* RenderManager */}
+				]
+			},
+			RenderInTableBottomArea: {
+				arguments: [
+					{type: "object" /* RenderManager */}
+				]
+			},
+			RenderRowContainerStyles: {
+				arguments: [
+					{type: "object" /* RenderManager */}
+				]
+			},
+			RenderRowStyles: {
+				arguments: [
+					{type: "object" /* RenderManager */}
+				]
+			},
+			RenderCellContentStyles: {
+				arguments: [
+					{type: "object" /* RenderManager */}
+				]
+			}
+		},
 		Row: {
 			UpdateState: {
 				arguments: [
@@ -501,8 +528,12 @@ sap.ui.define(["sap/ui/base/DataType"], function(DataType) {
 		});
 	}
 
+	function validateChangeReason(sReason) {
+		return typeof sReason === "string" && Object.values(ChangeReason).includes(sReason);
+	}
+
 	function validateRowsUpdateReason(sReason) { // sap.ui.table.utils.TableUtils.RowsUpdateReason
-		return sReason in HookUtils.TableUtils.RowsUpdateReason || DataType.getType("sap.ui.model.ChangeReason").isValid(sReason);
+		return sReason in HookUtils.TableUtils.RowsUpdateReason || validateChangeReason(sReason);
 	}
 
 	function validateCellInfo(oCellInfo) { // sap.ui.table.utils.TableUtils.CellInfo

package/src/sap/ui/table/utils/_MenuUtils.js

@@ -39,7 +39,7 @@ sap.ui.define([
 	 * Note: Do not access the functions of this helper directly, but via <code>sap.ui.table.utils.TableUtils.Menu...</code>
 	 *
 	 * @author SAP SE
-	 * @version 1.119.1
+	 * @version 1.120.1
 	 * @namespace
 	 * @alias sap.ui.table.utils._MenuUtils
 	 * @private