@openui5/sap.ui.support 1.146.0 → 1.147.1

package/REUSE.toml

@@ -613,57 +613,6 @@ SPDX-License-Identifier = "MIT"
 SPDX-FileComment = "these files belong to: hammer.js"
 
 
-# Library: sap.ui.webc.common:
-
-[[annotations]]
-path = [
-    "src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/base/**",
-    "src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/theming/**",
-    "src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/localization/**",
-    "src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/icons/**",
-    "src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/icons-tnt/**",
-    "src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/icons-business-suite/**"
-]
-precedence = "aggregate"
-SPDX-FileCopyrightText = "SAP"
-SPDX-License-Identifier = "Apache-2.0"
-SPDX-FileComment = "these files belong to: UI5 Web Components"
-
-[[annotations]]
-path = "src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/lit-html/**"
-precedence = "aggregate"
-SPDX-FileCopyrightText = "Google LLC"
-SPDX-License-Identifier = "BSD-3-Clause"
-SPDX-FileComment = "these files belong to: lit-html"
-
-
-# Library: sap.ui.webc.fiori:
-
-[[annotations]]
-path = "src/sap.ui.webc.fiori/src/sap/ui/webc/fiori/thirdparty/**"
-precedence = "aggregate"
-SPDX-FileCopyrightText = "SAP"
-SPDX-License-Identifier = "Apache-2.0"
-SPDX-FileComment = "these files belong to: UI5 Web Components"
-
-[[annotations]]
-path = "src/sap.ui.webc.fiori/src/sap/ui/webc/fiori/lib/zxing.js"
-precedence = "aggregate"
-SPDX-FileCopyrightText = "2005 Sun Microsystems, Inc.; 2010-2014 University of Manchester; 2010-2015 Stian Soiland-Reyes; 2015 Peter Hull"
-SPDX-License-Identifier = "Apache-2.0"
-SPDX-FileComment = "these files belong to: ZXing"
-
-
-# Library: sap.ui.webc.main:
-
-[[annotations]]
-path = "src/sap.ui.webc.main/src/sap/ui/webc/main/thirdparty/**"
-precedence = "aggregate"
-SPDX-FileCopyrightText = "SAP"
-SPDX-License-Identifier = "Apache-2.0"
-SPDX-FileComment = "these files belong to: UI5 Web Components"
-
-
 # Outside of Libraries:
 
 [[annotations]]

package/THIRDPARTY.txt

@@ -446,50 +446,6 @@ License Text: https://github.com/UI5/openui5/blob/master/LICENSES/MIT.txt
 Contained in: src/sap.ui.mdc/test/sap/ui/mdc/demokit/sample/Chart/ChartJS/control/hammerjs.js
 
 
-Library: sap.ui.webc.common:
-
-Component: UI5 Web Components, version: 1.18.0
-Copyright: SAP
-License: Apache-2.0
-License Text: https://github.com/UI5/openui5/blob/master/LICENSES/Apache-2.0.txt
-Contained in: src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/base/**
-	src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/theming/**
-	src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/localization/**
-	src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/icons/**
-	src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/icons-tnt/**
-	src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/icons-business-suite/**
-
-Component: lit-html, version: 2.2.2
-Copyright: Google LLC
-License: BSD-3-Clause
-License Text: https://github.com/UI5/openui5/blob/master/LICENSES/BSD-3-Clause.txt
-Contained in: src/sap.ui.webc.common/src/sap/ui/webc/common/thirdparty/lit-html/**
-
-
-Library: sap.ui.webc.fiori:
-
-Component: UI5 Web Components, version: 1.18.0
-Copyright: SAP
-License: Apache-2.0
-License Text: https://github.com/UI5/openui5/blob/master/LICENSES/Apache-2.0.txt
-Contained in: src/sap.ui.webc.fiori/src/sap/ui/webc/fiori/thirdparty/**
-
-Component: ZXing, version: 0.17.1
-Copyright: 2005 Sun Microsystems, Inc.; 2010-2014 University of Manchester; 2010-2015 Stian Soiland-Reyes; 2015 Peter Hull
-License: Apache-2.0
-License Text: https://github.com/UI5/openui5/blob/master/LICENSES/Apache-2.0.txt
-Contained in: src/sap.ui.webc.fiori/src/sap/ui/webc/fiori/lib/zxing.js
-
-
-Library: sap.ui.webc.main:
-
-Component: UI5 Web Components, version: 1.18.0
-Copyright: SAP
-License: Apache-2.0
-License Text: https://github.com/UI5/openui5/blob/master/LICENSES/Apache-2.0.txt
-Contained in: src/sap.ui.webc.main/src/sap/ui/webc/main/thirdparty/**
-
-
 Outside of Libraries:
 
 Component: JSDoc 3, version: 3.6.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openui5/sap.ui.support",
-  "version": "1.146.0",
+  "version": "1.147.1",
   "description": "OpenUI5 UI Library sap.ui.support",
   "author": "SAP SE (https://www.sap.com)",
   "license": "Apache-2.0",
@@ -14,10 +14,10 @@
     "url": "https://github.com/UI5/openui5.git"
   },
   "dependencies": {
-    "@openui5/sap.m": "1.146.0",
-    "@openui5/sap.ui.codeeditor": "1.146.0",
-    "@openui5/sap.ui.core": "1.146.0",
-    "@openui5/sap.ui.fl": "1.146.0",
-    "@openui5/sap.ui.layout": "1.146.0"
+    "@openui5/sap.m": "1.147.1",
+    "@openui5/sap.ui.codeeditor": "1.147.1",
+    "@openui5/sap.ui.core": "1.147.1",
+    "@openui5/sap.ui.fl": "1.147.1",
+    "@openui5/sap.ui.layout": "1.147.1"
   }
 }

package/src/sap/ui/support/.library

@@ -6,7 +6,7 @@
 	<copyright>OpenUI5
  * (c) Copyright 2026 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.</copyright>
-	<version>1.146.0</version>
+	<version>1.147.1</version>
 
 	<documentation>UI5 library: sap.ui.support</documentation>
 

package/src/sap/ui/support/RuleAnalyzer.js

@@ -32,7 +32,7 @@ sap.ui.define([
 		 * @namespace
 		 * @alias sap.ui.support.RuleAnalyzer
 		 * @author SAP SE
-		 * @version 1.146.0
+		 * @version 1.147.1
 		 * @public
 		 */
 		var RuleAnalyzer = {

package/src/sap/ui/support/jQuery.sap.support.js

@@ -38,7 +38,7 @@ sap.ui.define(["sap/ui/thirdparty/jquery",
 		 * @namespace
 		 * @deprecated Since version 1.60.0. Please use sap/ui/support/RuleAnalyzer instead.
 		 * @author SAP SE
-		 * @version 1.146.0
+		 * @version 1.147.1
 		 * @public
 		 */
 		jQuery.sap.support = {

package/src/sap/ui/support/library.js

@@ -23,7 +23,7 @@ sap.ui.define(["sap/ui/core/Lib", "sap/ui/base/DataType", "sap/ui/core/library"]
 	 * @namespace
 	 * @alias sap.ui.support
 	 * @author SAP SE
-	 * @version 1.146.0
+	 * @version 1.147.1
 	 * @since 1.50
 	 * @public
 	 */
@@ -38,7 +38,7 @@ sap.ui.define(["sap/ui/core/Lib", "sap/ui/base/DataType", "sap/ui/core/library"]
 		controls: [],
 		elements: [],
 		noLibraryCSS: true,
-		version: "1.146.0",
+		version: "1.147.1",
 		extensions: {
 			//Configuration used for rule loading of Support Assistant
 			"sap.ui.support": {
@@ -230,7 +230,7 @@ sap.ui.define(["sap/ui/core/Lib", "sap/ui/base/DataType", "sap/ui/core/library"]
 		 * Preset to find usages of deprecated controls, properties, aggregations and others.
 		 *
 		 * @public
-		 * @experimental since 1.120
+		 * @since 1.120
 		 */
 		Deprecations : {
 			id: "Deprecations",

package/src/sap/ui/support/supportRules/RuleSet.js

@@ -34,7 +34,7 @@ function (Log, Version, library, storage) {
 	 * @private
 	 * @alias sap.ui.support.RuleSet
 	 * @author SAP SE
-	 * @version 1.146.0
+	 * @version 1.147.1
 	 * @param {object} oSettings Name of the initiated
 	 */
 	var RuleSet = function (oSettings) {

package/src/sap/ui/support/supportRules/Storage.js

@@ -53,7 +53,7 @@ sap.ui.define([
 	 *
 	 * @name sap.ui.support.Storage
 	 * @author SAP SE.
-	 * @version 1.146.0
+	 * @version 1.147.1
 	 * @private
 	 */
 	return /** @lends sap.ui.support.Storage */ {

package/src/sap/ui/support/supportRules/WindowCommunicationBus.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * @class
 	 * @alias sap.ui.support.WindowCommunicationBus
 	 * @author SAP SE
-	 * @version 1.146.0
+	 * @version 1.147.1
 	 * @private
 	 */
 	var WindowCommunicationBus = BaseObject.extend("sap.ui.support.supportRules.WindowCommunicationBus", {
@@ -127,37 +127,78 @@ sap.ui.define([
 	};
 
 	/**
-	 * validate messages published from external window to application window (i.e. from tool frame to opener window)
-	 * no validation needed the other way (i.e. from opener window to tool frame)
+	 * Compare the origins of two URLs. Returns false if either value is not a valid URL.
+	 * @private
+	 * @param {string} sOriginA First URL string
+	 * @param {string} sOriginB Second URL string
+	 * @returns {boolean} true if both URLs have the same origin
+	 */
+	WindowCommunicationBus._compareOrigins = function (sOriginA, sOriginB) {
+		try {
+			return new URL(sOriginA).origin === new URL(sOriginB).origin;
+		} catch (e) {
+			return false;
+		}
+	};
+
+	/**
+	 * Validate messages received from external windows.
+	 * Both directions are validated:
+	 * - Tool frame: validates origin of messages from opener window
+	 * - Application window: validates origin, frame identifier, and URL path of messages from tool frame
 	 * @private
 	 * @param {EventListener} eMessage Event fired by the channels attached to the WindowCommunicationBus
 	 * @returns {boolean} true if the message is valid
 	 */
 	WindowCommunicationBus.prototype._validate = function (eMessage) {
+		// 1. Validate origin
+		// tool frame: validate against the configured opener origin
 		if (isEmptyObject(this._frame)) {
-			// there are no channels associated with this bus, or
-			// when loaded in a tool frame, the CommumnicationBus class will always have an empty 'frame' object.
-			// in this case, a message is sent from the opener to the tool frame and no validation is necessary
+			const sExpectedOrigin = this._oConfig.getOrigin();
+
+			if (sExpectedOrigin) {
+				return WindowCommunicationBus._compareOrigins(eMessage.origin, sExpectedOrigin);
+			}
+
 			return true;
 		}
 
-		// when a message is sent from a tool frame to the application (opener) window,
-		// the message should have the correct details, validating that it comes from a known tool frame
+		// application window: validate against the known tool frame origin
+		if (!WindowCommunicationBus._compareOrigins(eMessage.origin, this._frame.origin)) {
+			return false;
+		}
 
-		// check if the frame ID (number represented as string) is the same
-		var bMatchIdentifier = eMessage.data._frameIdentifier === this._frame.identifier;
+		// 2. Validate frame identifier
+		if (eMessage.data._frameIdentifier !== this._frame.identifier) {
+			return false;
+		}
 
-		// check if the URL matches: 1. check if the domain name matches - should be case insensitive
-		var oOriginRegExp = new RegExp("^" + this._frame.origin + "$", "i");
-		var bMatchOrigin = oOriginRegExp.exec(eMessage.origin);
+		// 3. Validate URL path
+		// Compare parsed pathnames to avoid substring-matching attacks.
+		// The frame URL may be absolute or relative — strip query string and relative segments
+		// to extract the path portion, then verify the message origin's pathname ends with it.
+		try {
+			const oOriginUrl = new URL(eMessage.data._origin);
+			const iFrameUrlQuery = this._frame.url.indexOf("?");
+			const sFrameUrlWithoutQuery = this._frame.url.substring(0, iFrameUrlQuery).replace(/\.\.\//g, "").replace(/\.\//g, "");
+
+			// extract just the pathname: parse as URL if absolute, otherwise use the cleaned string as-is
+			let sFramePath;
+			try {
+				sFramePath = new URL(sFrameUrlWithoutQuery).pathname;
+			} catch (e) {
+				// relative URL — use cleaned string directly as a path suffix
+				sFramePath = sFrameUrlWithoutQuery;
+			}
 
-		// check if the URL matches: 2. check if the path to the iframe matches.
-		// if the frame URL is relative to the parent window's URL, remove relative path segments
-		var iFrameUrlQuery = this._frame.url.indexOf("?");
-		var sFrameUrl = this._frame.url.substr(0, iFrameUrlQuery).replace(/\.\.\//g, "").replace(/\.\//g, "") + this._frame.url.substr(iFrameUrlQuery);
-		var bMatchUrl = eMessage.data._origin.indexOf(sFrameUrl) > -1;
+			if (!oOriginUrl.pathname.endsWith(sFramePath)) {
+				return false;
+			}
+		} catch (e) {
+			return false;
+		}
 
-		return bMatchIdentifier && bMatchOrigin && bMatchUrl;
+		return true;
 	};
 
 	WindowCommunicationBus.prototype._getFrameIdentifier = function () {

package/src/sap/ui/support/supportRules/report/ReportProvider.js

@@ -409,7 +409,7 @@ sap.ui.define(['sap/ui/thirdparty/jquery', 'sap/base/Log', 'sap/base/security/en
 
 			jQuery(reportWindow.document).ready(function () {
 				// make sure everything is cleared before writing the new report
-				reportWindow.document.documentElement.innerHTML = '';
+				reportWindow.document.documentElement.replaceChildren();
 
 				reportWindow.document.write(content);
 			});

package/src/sap/ui/support/supportRules/ui/controllers/PresetsController.js

@@ -93,7 +93,7 @@ sap.ui.define([
 	 *
 	 * @extends sap.ui.support.supportRules.ui.controllers.BaseController
 	 * @author SAP SE
-	 * @version 1.146.0
+	 * @version 1.147.1
 	 * @private
 	 * @alias sap.ui.support.supportRules.ui.controllers.PresetsController
 	 */

package/src/sap/ui/support/supportRules/ui/overlay.html

@@ -12,7 +12,7 @@
 				data-sap-ui-compat-version="edge"
 				data-sap-ui-libs="sap.m, sap.ui.table, sap.ui.unified, sap.ui.layout, sap.tnt, sap.ui.support"
 				data-sap-ui-on-init="module:sap/ui/support/supportRules/ui/Overlay"
-				data-sap-ui-theme="sap_belize"
+				data-sap-ui-theme="sap_horizon"
 		></script>
 	</head>
 

package/src/sap/ui/support/supportRules/ui/views/Analysis.view.xml

@@ -22,7 +22,7 @@
 									<m:items>
 										<m:IconTabHeader
 												id="ruleSetsView"
-												select="onSelectedRuleSets"
+												select=".onSelectedRuleSets"
 												selectedKey="{/selectedSetPreviewKey}"
 												class="customIconTabHeader">
 											<m:layoutData>
@@ -34,8 +34,8 @@
 												<m:IconTabFilter key="additionalRulesets" text="Additional Rulesets" />
 											</m:items>
 										</m:IconTabHeader>
-										<m:Button class="supportAnalyzeButton" text="Analyze" press="onAnalyze" type="Emphasized"/>
-										<m:Button class="supportSettingsButton" icon="sap-icon://settings" press="onAnalyzeSettings" type="Emphasized"/>
+										<m:Button class="supportAnalyzeButton" text="Analyze" press=".onAnalyze" type="Emphasized"/>
+										<m:Button class="supportSettingsButton" icon="sap-icon://settings" press=".onAnalyzeSettings" type="Emphasized"/>
 									</m:items>
 								</m:HBox>
 							</m:contentMiddle>
@@ -80,7 +80,7 @@
 										text="Create Rule"
 										icon="sap-icon://add"
 										visible="{= !${/tempRulesDisabled}}"
-										press="createNewRulePress"/>
+										press=".createNewRulePress"/>
 								</m:contentRight>
 							</m:Bar>
 						</m:subHeader>
@@ -97,8 +97,8 @@
 								selectionBehavior="RowSelector"
 								rowActionCount="1"
 								visible="{= ${/selectedSetPreviewKey} === 'availableRules' }"
-								cellClick="onCellClick"
-								rowSelectionChange="onRowSelectionChange"
+								cellClick=".onCellClick"
+								rowSelectionChange=".onRowSelectionChange"
 								>
 							<t:columns>
 								<t:Column id="rulesColumn"
@@ -143,9 +143,9 @@
 							<t:rowActionTemplate>
 									<t:RowAction id="rowActionTemplate">
 										<t:items>
-											<t:RowActionItem icon="sap-icon://edit" text="Edit" press="editRule"  visible="{= ${ruleSets>libName} === 'temporary'}" />
-											<t:RowActionItem icon="sap-icon://delete" text="Delete" press="deleteTemporaryRule" visible="{= ${ruleSets>libName} === 'temporary'}" />
-											<t:RowActionItem icon="sap-icon://copy" text="Copy" press="duplicateRule" visible="{= !${/tempRulesDisabled} &amp;&amp; ${ruleSets>libName} !== 'temporary' &amp;&amp; ${ruleSets>type} !== 'lib'}" />
+											<t:RowActionItem icon="sap-icon://edit" text="Edit" press=".editRule"  visible="{= ${ruleSets>libName} === 'temporary'}" />
+											<t:RowActionItem icon="sap-icon://delete" text="Delete" press=".deleteTemporaryRule" visible="{= ${ruleSets>libName} === 'temporary'}" />
+											<t:RowActionItem icon="sap-icon://copy" text="Copy" press=".duplicateRule" visible="{= !${/tempRulesDisabled} &amp;&amp; ${ruleSets>libName} !== 'temporary' &amp;&amp; ${ruleSets>type} !== 'lib'}" />
 										</t:items>
 									</t:RowAction>
 							</t:rowActionTemplate>
@@ -164,7 +164,7 @@
 							<m:StandardListItem
 								title="{}"/>
 						</m:List>
-						<m:Button class="customMargin" text="Load" type="Emphasized" press="loadMarkedSupportLibraries" />
+						<m:Button class="customMargin" text="Load" type="Emphasized" press=".loadMarkedSupportLibraries" />
 					</l:VerticalLayout>
 				</m:Page>
 			</l:contentAreas>

package/src/sap/ui/support/supportRules/ui/views/AnalyzeSettings.fragment.xml

@@ -6,13 +6,13 @@
 		title="{/executionScopeTitle}"
 		contentMinWidth="250px"
 		class="sapUiContentPadding"
-		beforeOpen="onBeforePopoverOpen"
+		beforeOpen=".onBeforePopoverOpen"
 		placement="Bottom">
 		<content>
 			<VBox>
 				<RadioButton groupName="analyzeContext"
 							 text="{/executionScopes/global/displayName}"
-							 select="onContextSelect"
+							 select=".onContextSelect"
 							 selected="{= ${/analyzeContext/key} === 'global'}"
 							 tooltip="{/executionScopes/global/description}">
 					<customData>
@@ -21,7 +21,7 @@
 				</RadioButton>
 				<RadioButton groupName="analyzeContext"
 							 text="{/executionScopes/subtree/displayName}"
-							 select="onContextSelect"
+							 select=".onContextSelect"
 							 selected="{= ${/analyzeContext/key} === 'subtree'}"
 							 tooltip="{/executionScopes/subtree/description}">
 					<customData>
@@ -35,11 +35,11 @@
 						enabled="{= ${/analyzeContext/key} === 'subtree'}"
 						value="{/subtreeExecutionContextId}"
 						width="300px"
-						liveChange="onExecutionContextChange"/>
+						liveChange=".onExecutionContextChange"/>
 				</l:VerticalLayout>
 				<RadioButton groupName="analyzeContext"
 							 text="{/executionScopes/components/displayName}"
-							 select="onContextSelect"
+							 select=".onContextSelect"
 							 selected="{= ${/analyzeContext/key} === 'components'}"
 							 tooltip="{/executionScopes/components/description}">
 					<customData>
@@ -52,7 +52,7 @@
 					class="sapUiSupportToolSettingsPopoverPadding">
 					<CheckBox text="{text}"
 							  enabled="{= ${/analyzeContext/key} === 'components'}"
-							  select="onScopeComponentSelect"
+							  select=".onScopeComponentSelect"
 							  selected="{selected}"
 					/>
 				</l:VerticalLayout>

package/src/sap/ui/support/supportRules/ui/views/Issues.view.xml

@@ -21,7 +21,7 @@
 									</l:layoutData>
 									<Label text="Severity:" class="customMargin" />
 									<Select id='severityFilter'
-											change="updateIssuesVisibility"
+											change=".updateIssuesVisibility"
 											selectedKey="{/severityFilter}"
 											items="{/severitiesFilter}"
 											class="customMargin" >
@@ -34,7 +34,7 @@
 									</l:layoutData>
 									<Label text="Category:" class="customMargin" />
 									<Select id='categoryFilter'
-											change="updateIssuesVisibility"
+											change=".updateIssuesVisibility"
 											selectedKey="{/categoryFilter}"
 											items="{/categoriesFilter}"
 											class="customMargin">
@@ -47,7 +47,7 @@
 									</l:layoutData>
 									<Label text="Audiences:" class="customMargin" />
 									<Select id='audiencesFilter'
-											change="updateIssuesVisibility"
+											change=".updateIssuesVisibility"
 											selectedKey="{/audienceFilter}"
 											items="{/audiencesFilter}"
 											class="customMargin" >
@@ -66,7 +66,7 @@
 								<Label text="" class="customMargin" />
 								<MenuButton id='ReportMenuButton' text="Report" icon="sap-icon://order-status" visible="{= ${/analyzePressed}}">
 											<menu>
-												<Menu itemSelected="onReportPress">
+												<Menu itemSelected=".onReportPress">
 													<items>
 														<MenuItem text="View" />
 														<MenuItem text="Download" />
@@ -109,7 +109,7 @@
 										<FlexItemData growFactor="2" />
 									</layoutData>
 								</Text>
-								<Button icon="sap-icon://clear-filter"  press="clearFiltersAndElementSelection" enabled="{/bEnabledFilterButton}">
+								<Button icon="sap-icon://clear-filter"  press=".clearFiltersAndElementSelection" enabled="{/bEnabledFilterButton}">
 									<layoutData>
 										<FlexItemData growFactor="0" />
 									</layoutData>
@@ -123,7 +123,7 @@
 							selectionBehavior="RowOnly"
 							enableColumnReordering="false"
 							rows="{path: '/issues'}"
-							rowSelectionChange="onRowSelectionChanged">
+							rowSelectionChange=".onRowSelectionChanged">
 						<t:rowMode>
 							<trm:Auto rowContentHeight="24"/>
 						</t:rowMode>
@@ -154,7 +154,7 @@
 							selectionMode="Single"
 							selectionBehavior="RowOnly"
 							enableColumnReordering="false"
-							rowSelectionChange="onRowSelection"
+							rowSelectionChange=".onRowSelection"
 							id="issueTable">
 							<t:rowMode>
 								<trm:Fixed rowContentHeight="24" rowCount="{/visibleRowCount}"/>
@@ -230,7 +230,7 @@
 															''
 														],
 														formatter: '.formatter.resolutionUrl'
-													}" press="openDocumentation">
+													}" press=".openDocumentation">
 													<layoutData>
 														<f:ColumnElementData cellsLarge="8" cellsSmall="12" />
 													</layoutData>

package/src/sap/ui/support/supportRules/ui/views/Main.view.xml

@@ -13,7 +13,7 @@
 				<Bar class="sapContrast" design="SubHeader" id="sapSTShowButtonBar">
 					<contentMiddle>
 						<Text text="{/constants/SUPPORT_ASSISTANT_NAME}" class="STCustomHeaderInfo" />
-						<c:Icon src="sap-icon://full-screen" press="toggleHide" class="STCustomHeaderInfo" />
+						<c:Icon src="sap-icon://full-screen" press=".toggleHide" class="STCustomHeaderInfo" />
 					</contentMiddle>
 				</Bar>
 
@@ -59,19 +59,19 @@
 					<contentRight>
 					<Toolbar
 							id="navToolbar">
-							<Button id="issuesBtn" text="Issues ({/issuesCount})" enabled="{= ${/analyzedFinish} === true}" press="goToIssues"/>
+							<Button id="issuesBtn" text="Issues ({/issuesCount})" enabled="{= ${/analyzedFinish} === true}" press=".goToIssues"/>
 
-							<Button id="analysisBtn" text="Rules ({/selectedRulesCount})" press="goToAnalysis" type="Emphasized"/>
+							<Button id="analysisBtn" text="Rules ({/selectedRulesCount})" press=".goToAnalysis" type="Emphasized"/>
 
-							<c:Icon id="settingsIcon" src="sap-icon://settings" press="onSettings" class="STCustomHeaderInfo STHelpIcon sapUiTinyMargin"/>
+							<c:Icon id="settingsIcon" src="sap-icon://settings" press=".onSettings" class="STCustomHeaderInfo STHelpIcon sapUiTinyMargin"/>
 
-							<c:Icon src="sap-icon://sys-help" press="goToWiki" class="STCustomHeaderInfo STHelpIcon sapUiTinyMargin" tooltip="Open Documentation" />
+							<c:Icon src="sap-icon://sys-help" press=".goToWiki" class="STCustomHeaderInfo STHelpIcon sapUiTinyMargin" tooltip="Open Documentation" />
 
-							<c:Icon src="sap-icon://minimize" press="toggleHide" class="STCustomHeaderInfo sapUiTinyMargin" visible="{/hasNoOpener}"/>
+							<c:Icon src="sap-icon://minimize" press=".toggleHide" class="STCustomHeaderInfo sapUiTinyMargin" visible="{/hasNoOpener}"/>
 
-							<Button icon="sap-icon://down" press="resizeDown"  visible="{/hasNoOpener}"/>
+							<Button icon="sap-icon://down" press=".resizeDown"  visible="{/hasNoOpener}"/>
 
-							<Button icon="sap-icon://up" press="resizeUp"  visible="{/hasNoOpener}"/>
+							<Button icon="sap-icon://up" press=".resizeUp"  visible="{/hasNoOpener}"/>
 						</Toolbar>
 					</contentRight>
 				</Bar>

package/src/sap/ui/support/supportRules/ui/views/PresetExport.fragment.xml

@@ -52,10 +52,10 @@
 			</f:content>
 		</f:SimpleForm>
 		<beginButton>
-			<Button id="cancel" text="Cancel" press="onExportCancelPress" />
+			<Button id="cancel" text="Cancel" press=".onExportCancelPress" />
 		</beginButton>
 		<endButton>
-			<Button id="exportBtn" text="Export" type="Emphasized" press="onExportFinalizePress" class="sapUiTinyMarginEnd" />
+			<Button id="exportBtn" text="Export" type="Emphasized" press=".onExportFinalizePress" class="sapUiTinyMarginEnd" />
 		</endButton>
 	</Dialog>
 </core:FragmentDefinition>

package/src/sap/ui/support/supportRules/ui/views/PresetImport.fragment.xml

@@ -7,7 +7,7 @@
 	<Dialog
 		id="importDialog"
 		title="Import a Rule Preset"
-		beforeClose="onImportDialogClose"
+		beforeClose=".onImportDialogClose"
 		resizable="true"
 		contentWidth="650px"
 		contentHeight="400px">
@@ -25,8 +25,8 @@
 					id="fileUpload"
 					buttonOnly="true"
 					buttonText="Browse ..."
-					change="onImportFileChange"
-					typeMissmatch="onImportFileMismatch"
+					change=".onImportFileChange"
+					typeMissmatch=".onImportFileMismatch"
 					fileType="json"
 					mimeType="application/json"
 					class="sapUiTinyMarginBottom">
@@ -78,10 +78,10 @@
 			</f:content>
 		</f:SimpleForm>
 		<beginButton>
-			<Button id="cancel" text="Cancel" press="onImportCancelPress" />
+			<Button id="cancel" text="Cancel" press=".onImportCancelPress" />
 		</beginButton>
 		<endButton>
-			<Button id="importBtn" type="Emphasized" text="Import" enabled="false" press="onImportFinalizePress" class="sapUiTinyMarginEnd" />
+			<Button id="importBtn" type="Emphasized" text="Import" enabled="false" press=".onImportFinalizePress" class="sapUiTinyMarginEnd" />
 		</endButton>
 	</Dialog>
 </core:FragmentDefinition>

package/src/sap/ui/support/supportRules/ui/views/Presets.fragment.xml

@@ -13,7 +13,7 @@
 					<Title id="rulePresetsTitle" text="Rule Presets" />
 				</contentMiddle>
 				<contentRight>
-					<core:Icon id="help" width="18px" src="sap-icon://sys-help" decorative="false" press="openHelp" />
+					<core:Icon id="help" width="18px" src="sap-icon://sys-help" decorative="false" press=".openHelp" />
 				</contentRight>
 			</Bar>
 		</customHeader>
@@ -28,8 +28,8 @@
 					},
 					groupHeaderFactory: '.getGroupHeader'
 				}"
-				itemPress="onPresetItemPress"
-				selectionChange="onPresetChange"
+				itemPress=".onPresetItemPress"
+				selectionChange=".onPresetChange"
 				mode="SingleSelectMaster">
 				<CustomListItem selected="{selected}" type="Active" tooltip="{description}">
 					<HBox
@@ -47,13 +47,13 @@
 								tooltip="Return to default selection"
 								icon="sap-icon://refresh"
 								type="Transparent"
-								press="onPresetItemReset"
+								press=".onPresetItemReset"
 								visible="{= ${isModified} ? true : false}"/>
 							<Button
 								tooltip="Delete Preset"
 								icon="sap-icon://sys-cancel"
 								type="Transparent"
-								press="onPresetItemDelete"
+								press=".onPresetItemDelete"
 								visible="{= ${disableDelete} ? false : true}" />
 						</HBox>
 					</HBox>
@@ -62,8 +62,8 @@
 			<footer>
 				<Toolbar>
 					<ToolbarSpacer />
-					<Button id="presetImport" text="Import" press="onImportPress" />
-					<Button id="presetExport" text="Export" press="onExportPress" />
+					<Button id="presetImport" text="Import" press=".onImportPress" />
+					<Button id="presetExport" text="Export" press=".onExportPress" />
 				</Toolbar>
 			</footer>
 		</Page>

package/src/sap/ui/support/supportRules/ui/views/RuleUpdate.fragment.xml

@@ -14,12 +14,12 @@
 				<m:contentLeft>
 					<m:Button
 							icon="sap-icon://arrow-left"
-							press="goToRuleProperties"
+							press=".goToRuleProperties"
 							text="Back"/>
 				</m:contentLeft>
 				<m:contentMiddle>
 					<m:IconTabHeader
-							select="rulesToolbarEditITHSelect"
+							select=".rulesToolbarEditITHSelect"
 							selectedKey="{/selectedRuleEditKey}"
 							class="customIconTabHeader">
 						<m:items>
@@ -46,12 +46,12 @@
 							</f:FormElement>
 							<f:FormElement label="Async">
 								<f:fields>
-									<m:RadioButton groupName="asyncEditContext" text="true" selected="{= ${/editRule/async} === true }" select="onAsyncSwitch">
+									<m:RadioButton groupName="asyncEditContext" text="true" selected="{= ${/editRule/async} === true }" select=".onAsyncSwitch">
 										<m:customData>
 											<c:CustomData key="asyncEditContext" value="true" />
 										</m:customData>
 									</m:RadioButton>
-									<m:RadioButton groupName="asyncEditContext" text="false" selected="{= ${/editRule/async} !== true }" select="onAsyncSwitch">
+									<m:RadioButton groupName="asyncEditContext" text="false" selected="{= ${/editRule/async} !== true }" select=".onAsyncSwitch">
 										<m:customData>
 											<c:CustomData key="asyncEditContext" value="false" />
 										</m:customData>
@@ -110,7 +110,7 @@
 								<f:fields>
 									<m:Input placeholder="Text" value="{/tempLink/text}" />
 									<m:Input placeholder="Href" value="{/tempLink/href}" />
-									<m:Button text="Add Link" press="addLinkToRule" icon="sap-icon://add" />
+									<m:Button text="Add Link" press=".addLinkToRule" icon="sap-icon://add" />
 								</f:fields>
 							</f:FormElement>
 							<f:FormElement label="" fields="{/editRule/resolutionurls}">
@@ -154,7 +154,7 @@
 			<m:Bar>
 				<m:contentRight>
 					<m:Button
-							press="updateRule"
+							press=".updateRule"
 							text="Update"
 							type="Emphasized" />
 				</m:contentRight>
@@ -169,12 +169,12 @@
 				<m:contentLeft>
 					<m:Button
 							icon="sap-icon://arrow-left"
-							press="goToRuleProperties"
+							press=".goToRuleProperties"
 							text="Back"/>
 				</m:contentLeft>
 				<m:contentMiddle>
 					<m:IconTabHeader
-							select="rulesToolbarITHSelect"
+							select=".rulesToolbarITHSelect"
 							selectedKey="{/selectedRuleCreateKey}"
 							class="customIconTabHeader">
 						<m:items>
@@ -201,12 +201,12 @@
 							</f:FormElement>
 							<f:FormElement label="Async">
 								<f:fields>
-									<m:RadioButton groupName="asyncContext" text="true" selected="{= ${/newRule/async} === true }" select="onAsyncSwitch">
+									<m:RadioButton groupName="asyncContext" text="true" selected="{= ${/newRule/async} === true }" select=".onAsyncSwitch">
 										<m:customData>
 											<c:CustomData key="asyncContext" value="true" />
 										</m:customData>
 									</m:RadioButton>
-									<m:RadioButton groupName="asyncContext" text="false" selected="{= ${/newRule/async} !== true }" select="onAsyncSwitch">
+									<m:RadioButton groupName="asyncContext" text="false" selected="{= ${/newRule/async} !== true }" select=".onAsyncSwitch">
 										<m:customData>
 											<c:CustomData key="asyncContext" value="false" />
 										</m:customData>
@@ -265,7 +265,7 @@
 								<f:fields>
 									<m:Input placeholder="Text" value="{/tempLink/text}" />
 									<m:Input placeholder="Href" value="{/tempLink/href}" />
-									<m:Button text="Add" press="addLinkToRule" icon="sap-icon://add" />
+									<m:Button text="Add" press=".addLinkToRule" icon="sap-icon://add" />
 								</f:fields>
 							</f:FormElement>
 							<f:FormElement label="" fields="{/newRule/resolutionurls}">
@@ -310,7 +310,7 @@
 			<m:Bar>
 				<m:contentRight>
 					<m:Button
-							press="addNewRule"
+							press=".addNewRule"
 							text="Add Rule"
 							type="Emphasized" />
 				</m:contentRight>

package/src/sap/ui/support/supportRules/ui/views/StorageSettings.fragment.xml

@@ -45,9 +45,9 @@
 									class="sapUiTinyMarginLeft"
 									src="sap-icon://copy"
 									tooltip="Copy Location"
-									press="copySupportAssistantOriginToClipboard" />
+									press=".copySupportAssistantOriginToClipboard" />
 							</l:HorizontalLayout>
-							
+
 							<l:HorizontalLayout class="sapUiTinyMarginTop">
 								<Text text="Support Assistant Version : {/supportAssistantVersion}" renderWhitespace="true"></Text>
 							</l:HorizontalLayout>

package/src/sap/ui/support/supportRules/util/EvalUtils.js

@@ -1,4 +1,4 @@
-/* eslint-disable no-eval */
+/* eslint-disable no-new-func */
 
 /*!
  * OpenUI5
@@ -9,11 +9,12 @@
 sap.ui.define([], function () {
 	"use strict";
 
-	var bIsEvalAllowed;
+	let bIsEvalAllowed;
 
-	// Checks if eval can be used in the current platform (based on CSP restrictions)
+	// Checks if the Function constructor can be used in the current platform (based on CSP restrictions)
 	try {
-		eval("");
+		// eslint-disable-next-line no-new
+		new Function("");
 		bIsEvalAllowed = true;
 	} catch (e) {
 		bIsEvalAllowed = false;
@@ -34,11 +35,7 @@ sap.ui.define([], function () {
 		 * @throws Error why eval failed, for example invalid syntax
 		 */
 		evalFunction: function (sFunction) {
-			var fn;
-
-			eval("fn = " + sFunction);
-
-			return fn;
+			return new Function("return (" + sFunction + ")")();
 		}
 	};
-});
+});