@openui5/sap.ui.rta 1.93.3 → 1.96.2

package/src/sap/ui/rta/toolbar/Fiori.js

@@ -22,7 +22,7 @@ function(
 	 * This class is being assigned to the original Fiori Header Toolbar when RTA Toolbar shows
 	 * @type {string}
 	 */
-	var FIORI_HIDDEN_CLASS = 'sapUiRtaFioriHeaderInvisible';
+	var FIORI_HIDDEN_CLASS = "sapUiRtaFioriHeaderInvisible";
 
 	/**
 	 * Constructor for a new sap.ui.rta.toolbar.Fiori control
@@ -32,7 +32,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.93.3
+	 * @version 1.96.2
 	 *
 	 * @constructor
 	 * @private
@@ -44,8 +44,8 @@ function(
 		metadata: {
 			library: "sap.ui.rta"
 		},
-		renderer: 'sap.ui.rta.toolbar.AdaptationRenderer',
-		type: 'fiori'
+		renderer: "sap.ui.rta.toolbar.AdaptationRenderer",
+		type: "fiori"
 	});
 
 	Fiori.prototype.init = function () {
@@ -65,7 +65,7 @@ function(
 
 			if (this._oFioriHeader.getShowLogo() && sLogoPath) {
 				// Unstable: if FLP changes ID of <img> element, logo could be not found
-				var $logo = this._oFioriHeader.$().find('#shell-header-icon');
+				var $logo = this._oFioriHeader.$().find("#shell-header-icon");
 				var iWidth;
 				var iHeight;
 
@@ -81,8 +81,8 @@ function(
 				this.getControl("iconBox").addItem(
 					new Image(this.getId() + "_fragment--sapUiRta_icon", {
 						src: sLogoPath,
-						width: iWidth ? iWidth + 'px' : iWidth,
-						height: iHeight ? iHeight + 'px' : iHeight
+						width: iWidth ? iWidth + "px" : iWidth,
+						height: iHeight ? iHeight + "px" : iHeight
 					})
 				);
 			}
@@ -106,7 +106,7 @@ function(
 				"sap.ui.rta: please check Fiori Launchpad logo, expected size is",
 				iWidth + "x" + iHeight + ",",
 				"but actual is " + iNaturalWidth + "x" + iNaturalHeight
-			].join(' '));
+			].join(" "));
 		}
 	};
 
@@ -121,4 +121,4 @@ function(
 	};
 
 	return Fiori;
-}, true);
+});

package/src/sap/ui/rta/toolbar/FioriLike.js

@@ -20,7 +20,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.93.3
+	 * @version 1.96.2
 	 *
 	 * @constructor
 	 * @private
@@ -32,9 +32,9 @@ function(
 		metadata: {
 			library: "sap.ui.rta"
 		},
-		renderer: 'sap.ui.rta.toolbar.AdaptationRenderer',
-		type: 'fiori'
+		renderer: "sap.ui.rta.toolbar.AdaptationRenderer",
+		type: "fiori"
 	});
 
 	return FioriLike;
-}, true);
+});

package/src/sap/ui/rta/toolbar/OverflowToolbarButton.js

@@ -0,0 +1,98 @@
+/*!
+ * OpenUI5
+ * (c) Copyright 2009-2021 SAP SE or an SAP affiliate company.
+ * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
+ */
+
+sap.ui.define([
+	"sap/m/OverflowToolbarButton",
+	"sap/m/ButtonRenderer",
+	"sap/m/Button"
+],
+function(
+	SapMOverflowToolbarButton,
+	ButtonRenderer,
+	Button
+) {
+	"use strict";
+
+	/**
+	 * Constructor for a new sap.ui.rta.toolbar.OverflowToolbarButton control
+	 *
+	 * @class
+	 * Base class for Toolbar control
+	 * @extends sap.m.OverflowToolbarButton
+	 *
+	 * @author SAP SE
+	 * @version 1.96.2
+	 *
+	 * @constructor
+	 * @private
+	 * @since 1.94
+	 * @alias sap.ui.rta.toolbar.OverflowToolbarButton
+	 * @experimental Since 1.94. This class is experimental. The API might be changed in the future.
+	 */
+
+	var OverflowToolbarButton = SapMOverflowToolbarButton.extend("sap.ui.rta.toolbar.OverflowToolbarButton", {
+		metadata: {
+			library: "sap.ui.rta",
+			interfaces: [
+				"sap.m.IOverflowToolbarContent"
+			],
+			properties: {
+				visibleIcon: {type: "string", defaultValue: ""}
+			}
+		},
+		renderer: ButtonRenderer
+	});
+
+	/**
+	 * Remove the icon when entering the OverflowArea
+	 *
+	 * @private
+	 */
+	OverflowToolbarButton.prototype._onBeforeEnterOverflow = function () {
+		SapMOverflowToolbarButton.prototype._onBeforeEnterOverflow.apply(this, arguments);
+		this.setVisibleIcon(this.getIcon());
+		this.setIcon("");
+	};
+
+	/**
+	 * Restore the icon when leaving the OverflowArea
+	 *
+	 * @private
+	 */
+	OverflowToolbarButton.prototype._onAfterExitOverflow = function () {
+		SapMOverflowToolbarButton.prototype._onAfterExitOverflow.apply(this, arguments);
+		this.setIcon(this.getVisibleIcon());
+	};
+
+	/**
+	 * Get the Text if in Overflow-Area or Text in Toolbar is wanted
+	 *
+	 * @private
+	 */
+	OverflowToolbarButton.prototype._getText = function() {
+		if ((this.getIcon() === "" && this.getVisibleIcon() === "") || this._bInOverflow) {
+			return Button.prototype._getText.call(this);
+		}
+		return "";
+	};
+
+	/**
+	 * Special Icon handling when moving the Button in the OverflowArea
+	 * Required by the {@link sap.m.IOverflowToolbarContent} interface.
+	 *
+	 * @public
+	 * @returns {object} Configuration information for the <code>sap.m.IOverflowToolbarContent</code> interface.
+	 */
+	OverflowToolbarButton.prototype.getOverflowToolbarConfig = function () {
+		return {
+			canOverflow: true,
+			onBeforeEnterOverflow: this._onBeforeEnterOverflow.bind(this),
+			onAfterExitOverflow: this._onAfterExitOverflow.bind(this)
+		};
+	};
+
+	return OverflowToolbarButton;
+}, false);

package/src/sap/ui/rta/toolbar/Personalization.js

@@ -22,7 +22,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Base
 	 *
 	 * @author SAP SE
-	 * @version 1.93.3
+	 * @version 1.96.2
 	 *
 	 * @constructor
 	 * @private
@@ -31,8 +31,8 @@ function(
 	 * @experimental Since 1.48. This class is experimental. API might be changed in future.
 	 */
 	var Personalization = Base.extend("sap.ui.rta.toolbar.Personalization", {
-		renderer: 'sap.ui.rta.toolbar.BaseRenderer',
-		type: 'personalization',
+		renderer: "sap.ui.rta.toolbar.BaseRenderer",
+		type: "personalization",
 		metadata: {
 			library: "sap.ui.rta",
 			events: {
@@ -55,13 +55,13 @@ function(
 				type: "Transparent",
 				text: "{i18n>BTN_RESTORE}",
 				visible: true,
-				press: this.eventHandler.bind(this, 'Restore')
-			}).data('name', 'restore'),
+				press: this.eventHandler.bind(this, "Restore")
+			}).data("name", "restore"),
 			new Button("sapUiRta_exit", {
 				type: "Emphasized",
 				text: "{i18n>BTN_DONE}",
-				press: this.eventHandler.bind(this, 'Exit')
-			}).data('name', 'exit')
+				press: this.eventHandler.bind(this, "Exit")
+			}).data("name", "exit")
 		].forEach(function (oControl) {
 			this.addItem(oControl);
 		}.bind(this));
@@ -70,4 +70,4 @@ function(
 	};
 
 	return Personalization;
-}, true);
+});

package/src/sap/ui/rta/toolbar/Standalone.js

@@ -20,7 +20,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.93.3
+	 * @version 1.96.2
 	 *
 	 * @constructor
 	 * @private
@@ -32,9 +32,9 @@ function(
 		metadata: {
 			library: "sap.ui.rta"
 		},
-		renderer: 'sap.ui.rta.toolbar.AdaptationRenderer',
-		type: 'standalone'
+		renderer: "sap.ui.rta.toolbar.AdaptationRenderer",
+		type: "standalone"
 	});
 
 	return Standalone;
-}, true);
+});

package/src/sap/ui/rta/toolbar/translation/Translation.js

@@ -5,11 +5,12 @@
  */
 
 sap.ui.define([
+	"sap/ui/base/ManagedObject",
 	"sap/ui/core/Fragment",
 	"sap/ui/rta/Utils",
 	"sap/ui/model/json/JSONModel"
-],
-function(
+], function(
+	ManagedObject,
 	Fragment,
 	Utils,
 	JSONModel
@@ -17,23 +18,18 @@ function(
 	"use strict";
 
 	var oDialog;
-	var oContext;
-
-	var oTranslationModel = new JSONModel({
-		sourceLanguage: "",
-		downloadChangedTexts: false
-	});
+	var oPopover;
 
 	function resetTranslationDialog() {
-		oTranslationModel.setProperty("/sourceLanguage", "");
-		oTranslationModel.setProperty("/downloadChangedTexts", false);
+		this._oTranslationModel.setProperty("/sourceLanguage", "");
+		this._oTranslationModel.setProperty("/downloadChangedTexts", false);
 		return Promise.resolve(oDialog);
 	}
 
 	function createDownloadTranslationDialog() {
 		return Fragment.load({
 			name: "sap.ui.rta.toolbar.translation.DownloadTranslationDialog",
-			id: oContext.getId() + "_download_translation_fragment",
+			id: this.getContext().getId() + "_download_translation_fragment",
 			controller: {
 				onDownloadFile: function () {
 					oDialog.close();
@@ -44,10 +40,10 @@ function(
 			}
 		}).then(function (oTranslationDialog) {
 			oDialog = oTranslationDialog;
-			oDialog.setModel(oTranslationModel, "translation");
+			oDialog.setModel(this._oTranslationModel, "translation");
 			oDialog.addStyleClass(Utils.getRtaStyleClassName());
-			oContext.addDependent(oDialog);
-		});
+			this.getContext().addDependent(oDialog);
+		}.bind(this));
 	}
 
 	/**
@@ -57,38 +53,57 @@ function(
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.93.3
+	 * @version 1.96.2
 	 *
 	 * @constructor
 	 * @private
 	 * @since 1.93
 	 * @alias sap.ui.rta.toolbar.translation.Translation
 	 */
-	var Translation = {};
-
-	Translation.showTranslationPopover = function (oEvent, oToolbar) {
-		var oTranslationButton = oEvent.getSource();
+	var Translation = ManagedObject.extend("sap.ui.rta.toolbar.translation.Translation", {
+		metadata: {
+			properties: {
+				context: {
+					type: "sap.ui.rta.toolbar.Base"
+				}
+			}
+		},
+		constructor: function() {
+			ManagedObject.prototype.constructor.apply(this, arguments);
+			this._oTranslationModel = new JSONModel({
+				sourceLanguage: "",
+				downloadChangedTexts: false
+			});
+		}
+	});
 
-		// Will reset the dialog information after RTA toolbar was closed and opened again
-		if (oContext !== oToolbar) {
-			oContext = oToolbar;
-			oDialog = undefined;
+	Translation.prototype.exit = function() {
+		if (this._oDialogPromise) {
+			this._oDialogPromise.then(oDialog.destroy.bind(oDialog));
 		}
+		if (this._oPopoverPromise) {
+			this._oPopoverPromise.then(oPopover.destroy.bind(oPopover));
+		}
+	};
 
-		if (!oContext.oTranslationPopoverPromise) {
-			oContext.oTranslationPopoverPromise = Fragment.load({
+	Translation.prototype.showTranslationPopover = function (oEvent) {
+		var oTranslationButton = oEvent.getSource();
+
+		if (!this._oPopoverPromise) {
+			this._oPopoverPromise = Fragment.load({
 				name: "sap.ui.rta.toolbar.translation.TranslationPopover",
-				id: oContext.getId() + "_translationPopoverDialog",
+				id: this.getContext().getId() + "_translationPopoverDialog",
 				controller: {
-					openDownloadTranslationDialog: Translation.openDownloadTranslationDialog
+					openDownloadTranslationDialog: this.openDownloadTranslationDialog.bind(this)
 				}
-			}).then(function (oTranslationDialog) {
-				oTranslationButton.addDependent(oTranslationDialog);
-				return oTranslationDialog;
+			}).then(function (oTranslationPopover) {
+				oPopover = oTranslationPopover;
+				oTranslationButton.addDependent(oTranslationPopover);
+				return oTranslationPopover;
 			});
 		}
 
-		return oContext.oTranslationPopoverPromise.then(function (oTranslationDialog) {
+		return this._oPopoverPromise.then(function (oTranslationDialog) {
 			if (!oTranslationDialog.isOpen()) {
 				oTranslationDialog.openBy(oTranslationButton);
 			} else {
@@ -97,18 +112,16 @@ function(
 		});
 	};
 
-	Translation.openDownloadTranslationDialog = function () {
-		var oDialogPromise;
-
+	Translation.prototype.openDownloadTranslationDialog = function () {
 		if (oDialog) {
-			oDialogPromise = resetTranslationDialog();
+			this._oDialogPromise = resetTranslationDialog.call(this);
 		} else {
-			oDialogPromise = createDownloadTranslationDialog();
+			this._oDialogPromise = createDownloadTranslationDialog.call(this);
 		}
-		return oDialogPromise.then(function () {
-			oContext.addDependent(oDialog);
+		return this._oDialogPromise.then(function () {
+			this.getContext().addDependent(oDialog);
 			return oDialog.open();
-		});
+		}.bind(this));
 	};
 
 	return Translation;

package/src/sap/ui/rta/util/BindingsExtractor.js

@@ -16,6 +16,8 @@ function(
 ) {
 	"use strict";
 
+	var BindingsExtractor = {};
+
 	/**
 	 * Get all relevant binding paths and binding context paths for the element (from all properties)
 	 *
@@ -26,14 +28,14 @@ function(
 	 *
 	 * @private
 	 */
-	function collectBindingPaths(oElement, oModel, oRelevantContainerElement) {
+	BindingsExtractor.collectBindingPaths = function(oElement, oModel, oRelevantContainerElement) {
 		var mBindingsCollection = {
 			bindingPaths: [],
 			bindingContextPaths: []
 		};
 		var sAggregationName = oElement.sParentAggregationName;
 		var oParent = oElement.getParent();
-		var aBindings = getBindings(oElement, oModel, undefined, undefined, oRelevantContainerElement);
+		var aBindings = BindingsExtractor.getBindings(oElement, oModel, undefined, undefined, oRelevantContainerElement);
 
 		if (oParent) {
 			var oDefaultAggregation = oParent.getMetadata().getAggregation();
@@ -50,7 +52,7 @@ function(
 					if (oTemplateDefaultAggregation) {
 						var sTemplateDefaultAggregationName = oTemplateDefaultAggregation.name;
 						var oTemplateElement = ElementUtil.getAggregation(oTemplate, sTemplateDefaultAggregationName)[iPositionOfInvisibleElement];
-						aBindings = aBindings.concat(getBindings(oTemplateElement, null, true, undefined, oRelevantContainerElement));
+						aBindings = aBindings.concat(BindingsExtractor.getBindings(oTemplateElement, null, true, undefined, oRelevantContainerElement));
 					}
 				}
 			}
@@ -70,13 +72,15 @@ function(
 				}
 			}
 			if (isPlainObject(aBindings[i])) {
-				if (mBindingsCollection.bindingPaths.indexOf(aBindings[i].parts[0].path) === -1) {
-					mBindingsCollection.bindingPaths.push(aBindings[i].parts[0].path);
+				var sCurrentPath = aBindings[i].parts[0] && aBindings[i].parts[0].path;
+				// Sometimes the binding does not contain a path
+				if (sCurrentPath && mBindingsCollection.bindingPaths.indexOf(sCurrentPath) === -1) {
+					mBindingsCollection.bindingPaths.push(sCurrentPath);
 				}
 			}
 		}
 		return mBindingsCollection;
-	}
+	};
 
 	function isElementRelatedToRelevantContainer(oElement, oRelevantContainerElement) {
 		if (oRelevantContainerElement && oElement !== oRelevantContainerElement) {
@@ -100,13 +104,13 @@ function(
 	 *
 	 * @private
 	 */
-	function getBindings(oElement, oParentDefaultModel, vTemplate, sAggregationName, oRelevantContainerElement) {
+	BindingsExtractor.getBindings = function(oElement, oParentDefaultModel, vTemplate, sAggregationName, oRelevantContainerElement) {
 		var aBindings = [];
 		if (isElementRelatedToRelevantContainer(oElement, oRelevantContainerElement)) {
 			aBindings = (
 				vTemplate
 					? getBindingsFromTemplateProperties(oElement)
-					: getBindingsFromProperties(oElement, oParentDefaultModel)
+					: BindingsExtractor.getBindingsFromProperties(oElement, oParentDefaultModel)
 			);
 		}
 		var aAggregationNames = sAggregationName ? [sAggregationName] : Object.keys(oElement.getMetadata().getAllAggregations());
@@ -116,7 +120,7 @@ function(
 		});
 
 		return aBindings;
-	}
+	};
 
 	function getBindingsForAggregation(oElement, oParentDefaultModel, vTemplate, sAggregationName, oRelevantContainerElement) {
 		var aBindings = [];
@@ -136,12 +140,11 @@ function(
 					// Fetching bindings from Element and all children of Element
 					aBindings = aBindings.concat(oTemplate || bTemplate
 						? getBindingsFromTemplateProperties(oChildElement, oRelevantContainerElement)
-						: getBindingsFromProperties(oChildElement, oParentDefaultModel));
+						: BindingsExtractor.getBindingsFromProperties(oChildElement, oParentDefaultModel));
 				}
-
 				// For children, templates should not be evaluated (because the delegate also does not consider them)
 				aBindings = aBindings.concat(
-					getBindings(oChildElement, oParentDefaultModel, false, undefined, oRelevantContainerElement)
+					BindingsExtractor.getBindings(oChildElement, oParentDefaultModel, false, undefined, oRelevantContainerElement)
 				);
 			}
 		});
@@ -159,13 +162,13 @@ function(
 	 *
 	 * @private
 	 */
-	function flattenBindings(oBinding, oParentDefaultModel) {
+	BindingsExtractor.flattenBindings = function(oBinding, oParentDefaultModel) {
 		var aBindings = [];
 		var sModelName = oBinding.getMetadata().getName();
 
 		if (sModelName === "sap.ui.model.CompositeBinding") {
 			oBinding.getBindings().forEach(function (oBinding) {
-				aBindings = aBindings.concat(flattenBindings(oBinding, oParentDefaultModel));
+				aBindings = aBindings.concat(BindingsExtractor.flattenBindings(oBinding, oParentDefaultModel));
 			});
 		} else if (
 			(
@@ -185,7 +188,7 @@ function(
 		}
 
 		return aBindings;
-	}
+	};
 
 	/**
 	 * Fetches all bindings from template
@@ -218,7 +221,7 @@ function(
 	 *
 	 * @private
 	 */
-	function getBindingsFromProperties(oElement, oParentDefaultModel) {
+	BindingsExtractor.getBindingsFromProperties = function(oElement, oParentDefaultModel) {
 		var aPropertiesKeys = Object.keys(oElement.getMetadata().getAllProperties());
 
 		return aPropertiesKeys
@@ -226,13 +229,13 @@ function(
 			.filter(oElement.getBinding.bind(oElement))
 			.reduce(function (aBindings, sPropertyName) {
 				return aBindings.concat(
-					flattenBindings(
+					BindingsExtractor.flattenBindings(
 						oElement.getBinding(sPropertyName),
 						oParentDefaultModel
 					)
 				);
 			}, []);
-	}
+	};
 
 	/**
 	 * Retrieving all bindings from all available properties for a specified element of template
@@ -264,18 +267,12 @@ function(
 	 * @return {boolean|string} - Returns the binding context path string from element. If not available <code>false</code> is returned.
 	 * @private
 	 */
-	function getBindingContextPath(oElement) {
+	BindingsExtractor.getBindingContextPath = function(oElement) {
 		if (oElement.getBindingContext() && oElement.getBindingContext().getPath) {
 			return oElement.getBindingContext().getPath();
 		}
 		return undefined;
-	}
-
-	return {
-		getBindings: getBindings,
-		collectBindingPaths: collectBindingPaths,
-		flattenBindings: flattenBindings,
-		getBindingsFromProperties: getBindingsFromProperties,
-		getBindingContextPath: getBindingContextPath
 	};
+
+	return BindingsExtractor;
 }, true);

package/src/sap/ui/rta/util/PluginManager.js

@@ -66,7 +66,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PluginManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.93.3
+	 * @version 1.96.2
 	 * @constructor
 	 * @private
 	 * @since 1.86
@@ -153,9 +153,7 @@ sap.ui.define([
 			});
 
 			this._mDefaultPlugins["additionalElements"] = new AdditionalElementsPlugin({
-				commandFactory: this._oCommandFactory,
-				analyzer: AdditionalElementsAnalyzer,
-				dialog: new AdditionalElementsDialog()
+				commandFactory: this._oCommandFactory
 			});
 
 			this._mDefaultPlugins["createContainer"] = new CreateContainerPlugin({

package/src/sap/ui/rta/util/PopupManager.js

@@ -41,7 +41,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PopupManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.93.3
+	 * @version 1.96.2
 	 * @constructor
 	 * @private
 	 * @since 1.48

package/src/sap/ui/rta/util/ServiceEventBus.js

@@ -19,7 +19,7 @@ function(
 	 *
 	 * @extends sap.ui.core.EventBus
 	 * @author SAP SE
-	 * @version 1.93.3
+	 * @version 1.96.2
 	 * @private
 	 * @since 1.56.0
 	 * @alias sap.ui.rta.util.ServiceEventBus

package/src/sap/ui/rta/util/adaptationStarter.js

@@ -5,7 +5,7 @@
  */
 sap.ui.define([
 	"sap/ui/rta/RuntimeAuthoring",
-	"sap/ui/core/Element",
+	"sap/ui/core/Control",
 	"sap/ui/fl/Utils",
 	"sap/ui/fl/Layer",
 	"sap/ui/fl/write/api/FeaturesAPI",
@@ -13,7 +13,7 @@ sap.ui.define([
 	"sap/base/Log"
 ], function(
 	RuntimeAuthoring,
-	Element,
+	Control,
 	FlexUtils,
 	Layer,
 	FeaturesAPI,
@@ -47,7 +47,7 @@ sap.ui.define([
 	 * @private
 	 */
 	function adaptationStarter(mOptions, loadPlugins, onStart, onFailed, onStop) {
-		if (!(mOptions.rootControl instanceof Element) && !(mOptions.rootControl instanceof UIComponent)) {
+		if (!(mOptions.rootControl instanceof Control) && !(mOptions.rootControl instanceof UIComponent)) {
 			return Promise.reject(new Error("An invalid root control was passed"));
 		}