@openui5/sap.ui.rta 1.130.0 → 1.131.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (96) hide show
  1. package/THIRDPARTY.txt +1 -1
  2. package/package.json +6 -6
  3. package/src/sap/ui/rta/.library +1 -1
  4. package/src/sap/ui/rta/Client.js +1 -1
  5. package/src/sap/ui/rta/RuntimeAuthoring.js +8 -21
  6. package/src/sap/ui/rta/Utils.js +1 -1
  7. package/src/sap/ui/rta/appVariant/AppVariantManager.js +1 -1
  8. package/src/sap/ui/rta/command/AddIFrame.js +2 -2
  9. package/src/sap/ui/rta/command/AddProperty.js +38 -26
  10. package/src/sap/ui/rta/command/AddXML.js +1 -1
  11. package/src/sap/ui/rta/command/AddXMLAtExtensionPoint.js +1 -1
  12. package/src/sap/ui/rta/command/Annotation.js +2 -3
  13. package/src/sap/ui/rta/command/AppDescriptorCommand.js +1 -1
  14. package/src/sap/ui/rta/command/BaseCommand.js +1 -1
  15. package/src/sap/ui/rta/command/BindProperty.js +5 -3
  16. package/src/sap/ui/rta/command/Combine.js +12 -7
  17. package/src/sap/ui/rta/command/CommandFactory.js +1 -1
  18. package/src/sap/ui/rta/command/CompositeCommand.js +1 -1
  19. package/src/sap/ui/rta/command/ControlVariantConfigure.js +1 -1
  20. package/src/sap/ui/rta/command/ControlVariantSave.js +1 -1
  21. package/src/sap/ui/rta/command/ControlVariantSaveAs.js +1 -1
  22. package/src/sap/ui/rta/command/ControlVariantSetTitle.js +1 -1
  23. package/src/sap/ui/rta/command/ControlVariantSwitch.js +1 -1
  24. package/src/sap/ui/rta/command/CreateContainer.js +2 -2
  25. package/src/sap/ui/rta/command/CustomAdd.js +1 -1
  26. package/src/sap/ui/rta/command/FlexCommand.js +6 -4
  27. package/src/sap/ui/rta/command/LREPSerializer.js +1 -1
  28. package/src/sap/ui/rta/command/LocalReset.js +1 -1
  29. package/src/sap/ui/rta/command/Move.js +13 -8
  30. package/src/sap/ui/rta/command/Property.js +7 -4
  31. package/src/sap/ui/rta/command/Remove.js +3 -2
  32. package/src/sap/ui/rta/command/Rename.js +11 -7
  33. package/src/sap/ui/rta/command/Resize.js +2 -3
  34. package/src/sap/ui/rta/command/Reveal.js +6 -4
  35. package/src/sap/ui/rta/command/Settings.js +2 -3
  36. package/src/sap/ui/rta/command/Split.js +12 -7
  37. package/src/sap/ui/rta/command/Stack.js +53 -44
  38. package/src/sap/ui/rta/command/appDescriptor/AddLibrary.js +1 -1
  39. package/src/sap/ui/rta/command/compVariant/CompVariantContent.js +1 -1
  40. package/src/sap/ui/rta/command/compVariant/CompVariantSaveAs.js +1 -1
  41. package/src/sap/ui/rta/command/compVariant/CompVariantSwitch.js +1 -1
  42. package/src/sap/ui/rta/command/compVariant/CompVariantUpdate.js +1 -1
  43. package/src/sap/ui/rta/enablement/elementActionTest.js +135 -27
  44. package/src/sap/ui/rta/library.js +2 -2
  45. package/src/sap/ui/rta/plugin/AddXMLAtExtensionPoint.js +1 -1
  46. package/src/sap/ui/rta/plugin/BaseCreate.js +1 -1
  47. package/src/sap/ui/rta/plugin/Combine.js +1 -1
  48. package/src/sap/ui/rta/plugin/ControlVariant.js +1 -1
  49. package/src/sap/ui/rta/plugin/CreateContainer.js +1 -1
  50. package/src/sap/ui/rta/plugin/CutPaste.js +5 -1
  51. package/src/sap/ui/rta/plugin/DragDrop.js +5 -1
  52. package/src/sap/ui/rta/plugin/LocalReset.js +1 -1
  53. package/src/sap/ui/rta/plugin/Plugin.js +10 -2
  54. package/src/sap/ui/rta/plugin/RTAElementMover.js +1 -1
  55. package/src/sap/ui/rta/plugin/Remove.js +1 -1
  56. package/src/sap/ui/rta/plugin/Rename.js +1 -1
  57. package/src/sap/ui/rta/plugin/RenameHandler.js +1 -1
  58. package/src/sap/ui/rta/plugin/Resize.js +1 -1
  59. package/src/sap/ui/rta/plugin/Selection.js +1 -1
  60. package/src/sap/ui/rta/plugin/Settings.js +1 -6
  61. package/src/sap/ui/rta/plugin/Split.js +1 -1
  62. package/src/sap/ui/rta/plugin/Stretch.js +1 -1
  63. package/src/sap/ui/rta/plugin/additionalElements/ActionExtractor.js +1 -1
  64. package/src/sap/ui/rta/plugin/additionalElements/AddElementsDialog.js +1 -1
  65. package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsPlugin.js +1 -1
  66. package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsUtils.js +1 -1
  67. package/src/sap/ui/rta/plugin/additionalElements/CommandBuilder.js +1 -1
  68. package/src/sap/ui/rta/plugin/iframe/AddIFrame.js +1 -1
  69. package/src/sap/ui/rta/plugin/iframe/AddIFrameDialog.js +1 -1
  70. package/src/sap/ui/rta/service/Action.js +1 -1
  71. package/src/sap/ui/rta/service/ControllerExtension.js +13 -28
  72. package/src/sap/ui/rta/service/Outline.js +1 -1
  73. package/src/sap/ui/rta/service/Property.js +1 -1
  74. package/src/sap/ui/rta/service/Selection.js +1 -1
  75. package/src/sap/ui/rta/service/SupportTools.js +1 -1
  76. package/src/sap/ui/rta/toolbar/ActionsMenu.fragment.xml +1 -2
  77. package/src/sap/ui/rta/toolbar/Adaptation.js +1 -1
  78. package/src/sap/ui/rta/toolbar/Base.js +1 -1
  79. package/src/sap/ui/rta/toolbar/Fiori.js +14 -14
  80. package/src/sap/ui/rta/toolbar/FioriLike.js +1 -1
  81. package/src/sap/ui/rta/toolbar/OverflowToolbarButton.js +1 -1
  82. package/src/sap/ui/rta/toolbar/Standalone.js +1 -1
  83. package/src/sap/ui/rta/toolbar/contextBased/SaveAsAdaptation.js +1 -1
  84. package/src/sap/ui/rta/toolbar/translation/Translation.js +1 -1
  85. package/src/sap/ui/rta/toolbar/versioning/Versioning.js +1 -1
  86. package/src/sap/ui/rta/util/PluginManager.js +10 -9
  87. package/src/sap/ui/rta/util/PopupManager.js +1 -1
  88. package/src/sap/ui/rta/util/ReloadManager.js +1 -1
  89. package/src/sap/ui/rta/util/ServiceEventBus.js +1 -1
  90. package/src/sap/ui/rta/util/ServiceManager.js +1 -1
  91. package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js +1 -1
  92. package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js +1 -1
  93. package/src/sap/ui/rta/util/changeVisualization/ChangeVisualization.js +1 -1
  94. package/src/sap/ui/rta/util/whatsNew/WhatsNew.js +1 -1
  95. package/src/sap/ui/rta/util/whatsNew/WhatsNewOverview.js +3 -1
  96. package/src/sap/ui/rta/util/whatsNew/WhatsNewOverviewDialog.fragment.xml +6 -6
@@ -32,7 +32,7 @@ sap.ui.define([
32
32
  * @extends sap.ui.dt.plugin.CutPaste
33
33
  *
34
34
  * @author SAP SE
35
- * @version 1.130.0
35
+ * @version 1.131.0
36
36
  *
37
37
  * @constructor
38
38
  * @private
@@ -46,6 +46,10 @@ sap.ui.define([
46
46
  commandFactory: {
47
47
  type: "object",
48
48
  multiple: false
49
+ },
50
+ commandStack: {
51
+ type: "object",
52
+ multiple: false
49
53
  }
50
54
  },
51
55
  events: {
@@ -33,7 +33,7 @@ function(
33
33
  * @extends sap.ui.dt.plugin.ControlDragDrop
34
34
  *
35
35
  * @author SAP SE
36
- * @version 1.130.0
36
+ * @version 1.131.0
37
37
  *
38
38
  * @constructor
39
39
  * @private
@@ -47,6 +47,10 @@ function(
47
47
  commandFactory: {
48
48
  type: "object",
49
49
  multiple: false
50
+ },
51
+ commandStack: {
52
+ type: "object",
53
+ multiple: false
50
54
  }
51
55
  },
52
56
  events: {
@@ -41,7 +41,7 @@ sap.ui.define([
41
41
  * @class
42
42
  * @extends sap.ui.rta.plugin.Plugin
43
43
  * @author SAP SE
44
- * @version 1.130.0
44
+ * @version 1.131.0
45
45
  * @constructor
46
46
  * @private
47
47
  * @since 1.90
@@ -103,7 +103,7 @@ sap.ui.define([
103
103
  * @extends sap.ui.dt.Plugin
104
104
  *
105
105
  * @author SAP SE
106
- * @version 1.130.0
106
+ * @version 1.131.0
107
107
  *
108
108
  * @constructor
109
109
  * @private
@@ -119,6 +119,10 @@ sap.ui.define([
119
119
  commandFactory: {
120
120
  type: "object",
121
121
  multiple: false
122
+ },
123
+ commandStack: {
124
+ type: "object",
125
+ multiple: false
122
126
  }
123
127
  },
124
128
  events: {
@@ -169,7 +173,11 @@ sap.ui.define([
169
173
  mDebounceFunctions[sOverlayId][sName]();
170
174
  }
171
175
 
172
- var _onElementModified = function(oEvent) {
176
+ var _onElementModified = async function(oEvent) {
177
+ // Wait for all commands to be executed before evaluating the results of the element modified event
178
+ if (this.getCommandStack()) {
179
+ await this.getCommandStack().getLastCommandExecuted();
180
+ }
173
181
  // Initialize here because plugins may not extend the rta.Plugin and
174
182
  // instead inherit the method via rta.Utils.extendWith
175
183
  // Therefore the constructor/init might not be properly called
@@ -35,7 +35,7 @@ function(
35
35
  * The RTAElementMover is responsible for the RTA specific adaptation of element movements.
36
36
  *
37
37
  * @author SAP SE
38
- * @version 1.130.0
38
+ * @version 1.131.0
39
39
  *
40
40
  * @constructor
41
41
  * @private
@@ -29,7 +29,7 @@ sap.ui.define([
29
29
  * @class The Remove allows trigger remove operations on the overlay
30
30
  * @extends sap.ui.rta.plugin.Plugin
31
31
  * @author SAP SE
32
- * @version 1.130.0
32
+ * @version 1.131.0
33
33
  * @constructor
34
34
  * @private
35
35
  * @since 1.34
@@ -28,7 +28,7 @@ sap.ui.define([
28
28
  * @extends sap.ui.rta.plugin.Plugin
29
29
  *
30
30
  * @author SAP SE
31
- * @version 1.130.0
31
+ * @version 1.131.0
32
32
  *
33
33
  * @constructor
34
34
  * @private
@@ -43,7 +43,7 @@ sap.ui.define([
43
43
  * Provides Rename handling functionality
44
44
  *
45
45
  * @author SAP SE
46
- * @version 1.130.0
46
+ * @version 1.131.0
47
47
  *
48
48
  * @constructor
49
49
  * @private
@@ -27,7 +27,7 @@ sap.ui.define([
27
27
  * @class
28
28
  * @extends sap.ui.rta.plugin.Plugin
29
29
  * @author SAP SE
30
- * @version 1.130.0
30
+ * @version 1.131.0
31
31
  * @constructor
32
32
  * @private
33
33
  * @since 1.101
@@ -31,7 +31,7 @@ sap.ui.define([
31
31
  * @class The Selection plugin allows you to select or focus overlays with mouse or keyboard and navigate to others.
32
32
  * @extends sap.ui.rta.plugin.Plugin
33
33
  * @author SAP SE
34
- * @version 1.130.0
34
+ * @version 1.131.0
35
35
  * @constructor
36
36
  * @private
37
37
  * @since 1.34
@@ -28,7 +28,7 @@ sap.ui.define([
28
28
  * @class The Settings allows trigger change of settings operations on the overlay
29
29
  * @extends sap.ui.rta.plugin.Plugin
30
30
  * @author SAP SE
31
- * @version 1.130.0
31
+ * @version 1.131.0
32
32
  * @constructor
33
33
  * @private
34
34
  * @since 1.44
@@ -37,11 +37,6 @@ sap.ui.define([
37
37
  var Settings = Plugin.extend("sap.ui.rta.plugin.Settings", /** @lends sap.ui.rta.plugin.Settings.prototype */ {
38
38
  metadata: {
39
39
  library: "sap.ui.rta",
40
- properties: {
41
- commandStack: {
42
- type: "any"
43
- }
44
- },
45
40
  associations: {},
46
41
  events: {}
47
42
  }
@@ -23,7 +23,7 @@ sap.ui.define([
23
23
  * @class
24
24
  * @extends sap.ui.rta.plugin.Plugin
25
25
  * @author SAP SE
26
- * @version 1.130.0
26
+ * @version 1.131.0
27
27
  * @constructor
28
28
  * @private
29
29
  * @since 1.46
@@ -29,7 +29,7 @@ sap.ui.define([
29
29
  * @extends sap.ui.rta.plugin.Plugin
30
30
  *
31
31
  * @author SAP SE
32
- * @version 1.130.0
32
+ * @version 1.131.0
33
33
  *
34
34
  * @constructor
35
35
  * @private
@@ -34,7 +34,7 @@ sap.ui.define([
34
34
  * handled by the AdditionalElements Plugin (Reveal, Add Via Delegate, Add Custom)
35
35
  *
36
36
  * @author SAP SE
37
- * @version 1.130.0
37
+ * @version 1.131.0
38
38
  * @private
39
39
  * @since 1.94
40
40
  */
@@ -34,7 +34,7 @@ sap.ui.define([
34
34
  * @class Context - Dialog for available Fields in Runtime Authoring
35
35
  * @extends sap.ui.base.ManagedObject
36
36
  * @author SAP SE
37
- * @version 1.130.0
37
+ * @version 1.131.0
38
38
  * @constructor
39
39
  * @private
40
40
  * @since 1.44
@@ -119,7 +119,7 @@ sap.ui.define([
119
119
  * @class The plugin allows to add additional elements that exist either hidden in the UI or in the OData service
120
120
  * @extends sap.ui.rta.plugin.Plugin
121
121
  * @author SAP SE
122
- * @version 1.130.0
122
+ * @version 1.131.0
123
123
  * @constructor
124
124
  * @private
125
125
  * @since 1.44
@@ -17,7 +17,7 @@ sap.ui.define([
17
17
  * Helper object containing methods for the AdditionalElements plugin
18
18
  *
19
19
  * @author SAP SE
20
- * @version 1.130.0
20
+ * @version 1.131.0
21
21
  * @private
22
22
  * @since 1.94
23
23
  */
@@ -25,7 +25,7 @@ sap.ui.define([
25
25
  * Helper object to build the RTA commands resulting from the AdditionalElements Plugin
26
26
  *
27
27
  * @author SAP SE
28
- * @version 1.130.0
28
+ * @version 1.131.0
29
29
  * @private
30
30
  * @since 1.94
31
31
  */
@@ -119,7 +119,7 @@ sap.ui.define([
119
119
  * @class The AddIFrame allows trigger AddIFrame operations on the overlay.
120
120
  * @extends sap.ui.rta.plugin.BaseCreate
121
121
  * @author SAP SE
122
- * @version 1.130.0
122
+ * @version 1.131.0
123
123
  * @constructor
124
124
  * @private
125
125
  * @since 1.75
@@ -159,7 +159,7 @@ sap.ui.define([
159
159
  * @class Context - Dialog for IFrame settings in Runtime Authoring
160
160
  * @extends sap.ui.base.ManagedObject
161
161
  * @author SAP SE
162
- * @version 1.130.0
162
+ * @version 1.131.0
163
163
  * @constructor
164
164
  * @private
165
165
  * @since 1.78
@@ -24,7 +24,7 @@ sap.ui.define([
24
24
  * @name sap.ui.rta.service.Action
25
25
  * @author SAP SE
26
26
  * @since 1.58
27
- * @version 1.130.0
27
+ * @version 1.131.0
28
28
  * @private
29
29
  * @ui5-restricted
30
30
  *
@@ -6,22 +6,20 @@
6
6
 
7
7
  sap.ui.define([
8
8
  "sap/ui/core/Element",
9
- "sap/ui/dt/Util",
10
9
  "sap/ui/dt/OverlayRegistry",
11
- "sap/ui/fl/Utils",
10
+ "sap/ui/dt/Util",
12
11
  "sap/ui/fl/apply/api/FlexRuntimeInfoAPI",
13
12
  "sap/ui/fl/write/api/ChangesWriteAPI",
14
13
  "sap/ui/fl/write/api/PersistenceWriteAPI",
15
- "sap/ui/thirdparty/jquery"
14
+ "sap/ui/fl/Utils"
16
15
  ], function(
17
16
  Element,
18
- DtUtil,
19
17
  OverlayRegistry,
20
- FlexUtils,
18
+ DtUtil,
21
19
  FlexRuntimeInfoAPI,
22
20
  ChangesWriteAPI,
23
21
  PersistenceWriteAPI,
24
- jQuery
22
+ FlexUtils
25
23
  ) {
26
24
  "use strict";
27
25
 
@@ -32,31 +30,18 @@ sap.ui.define([
32
30
  * @name sap.ui.rta.service.ControllerExtension
33
31
  * @author SAP SE
34
32
  * @since 1.58
35
- * @version 1.130.0
33
+ * @version 1.131.0
36
34
  * @private
37
35
  * @ui5-restricted
38
36
  */
39
37
 
40
38
  return function(oRta) {
41
- function makeAjaxCall(sPath) {
42
- return new Promise(function(resolve, reject) {
43
- var sUrl;
44
- jQuery.ajax({
45
- url: sUrl = `${sap.ui.require.toUrl(sPath)}.js`,
46
- async: true,
47
- success(data) {
48
- resolve(data);
49
- },
50
- error(xhr, textStatus, error) {
51
- var oError = new Error(`resource ${sPath} could not be loaded from ${sUrl}. Check for 'file not found' or parse errors. Reason: ${error}`);
52
- oError.status = textStatus;
53
- oError.error = error;
54
- oError.statusCode = xhr.status;
55
- reject(error);
56
- },
57
- dataType: "text"
58
- });
59
- });
39
+ async function fetchTemplate(sPath) {
40
+ const oResponse = await fetch(`${sap.ui.require.toUrl(sPath)}.js`);
41
+ if (!oResponse.ok) {
42
+ throw new Error(`resource ${sPath} could not be loaded from ${sPath}. Check for 'file not found' or parse errors. Reason: ${oResponse.statusText}`);
43
+ }
44
+ return oResponse.text();
60
45
  }
61
46
 
62
47
  return {
@@ -128,9 +113,9 @@ sap.ui.define([
128
113
  }
129
114
 
130
115
  var sControllerExtensionTemplatePath = oViewOverlay.getDesignTimeMetadata().getControllerExtensionTemplate();
131
- return makeAjaxCall(`${sControllerExtensionTemplatePath}-dbg`)
116
+ return fetchTemplate(`${sControllerExtensionTemplatePath}-dbg`)
132
117
  .catch(function() {
133
- return makeAjaxCall(sControllerExtensionTemplatePath);
118
+ return fetchTemplate(sControllerExtensionTemplatePath);
134
119
  });
135
120
  }
136
121
  }
@@ -43,7 +43,7 @@ sap.ui.define([
43
43
  * @name sap.ui.rta.service.Outline
44
44
  * @author SAP SE
45
45
  * @since 1.56
46
- * @version 1.130.0
46
+ * @version 1.131.0
47
47
  * @private
48
48
  * @ui5-restricted
49
49
  */
@@ -27,7 +27,7 @@ sap.ui.define([
27
27
  * @name sap.ui.rta.service.Property
28
28
  * @author SAP SE
29
29
  * @since 1.58
30
- * @version 1.130.0
30
+ * @version 1.131.0
31
31
  * @private
32
32
  * @ui5-restricted
33
33
  */
@@ -14,7 +14,7 @@ sap.ui.define(function() {
14
14
  * @name sap.ui.rta.service.Selection
15
15
  * @author SAP SE
16
16
  * @since 1.58
17
- * @version 1.130.0
17
+ * @version 1.131.0
18
18
  * @private
19
19
  * @ui5-restricted
20
20
  */
@@ -30,7 +30,7 @@ sap.ui.define([
30
30
  * @name sap.ui.rta.service.SupportTools
31
31
  * @author SAP SE
32
32
  * @since 1.106
33
- * @version 1.130.0
33
+ * @version 1.131.0
34
34
  * @private
35
35
  * @ui5-restricted
36
36
  */
@@ -78,7 +78,6 @@
78
78
  enabled="{controls>/newFeaturesOverview/enabled}"
79
79
  visible="{controls>/newFeaturesOverview/visible}"
80
80
  text="{i18n>BTN_WHATS_NEW_DIALOG_OVERVIEW}"
81
- press=".openWhatsNewOverviewDialog"
82
- ariaHasPopup="Dialog"/>
81
+ press=".openWhatsNewOverviewDialog"/>
83
82
  </Menu>
84
83
  </core:FragmentDefinition>
@@ -57,7 +57,7 @@ sap.ui.define([
57
57
  * @extends sap.ui.rta.toolbar.Base
58
58
  *
59
59
  * @author SAP SE
60
- * @version 1.130.0
60
+ * @version 1.131.0
61
61
  *
62
62
  * @constructor
63
63
  * @private
@@ -33,7 +33,7 @@ sap.ui.define([
33
33
  * @extends sap.m.HBox
34
34
  *
35
35
  * @author SAP SE
36
- * @version 1.130.0
36
+ * @version 1.131.0
37
37
  *
38
38
  * @constructor
39
39
  * @private
@@ -22,7 +22,7 @@ function(
22
22
  * This class is being assigned to the original Fiori Header Toolbar when RTA Toolbar shows
23
23
  * @type {string}
24
24
  */
25
- var FIORI_HIDDEN_CLASS = "sapUiRtaFioriHeaderInvisible";
25
+ const FIORI_HIDDEN_CLASS = "sapUiRtaFioriHeaderInvisible";
26
26
 
27
27
  /**
28
28
  * Constructor for a new sap.ui.rta.toolbar.Fiori control
@@ -32,14 +32,14 @@ function(
32
32
  * @extends sap.ui.rta.toolbar.Adaptation
33
33
  *
34
34
  * @author SAP SE
35
- * @version 1.130.0
35
+ * @version 1.131.0
36
36
  *
37
37
  * @constructor
38
38
  * @private
39
39
  * @since 1.48
40
40
  * @alias sap.ui.rta.toolbar.Fiori
41
41
  */
42
- var Fiori = Adaptation.extend("sap.ui.rta.toolbar.Fiori", {
42
+ const Fiori = Adaptation.extend("sap.ui.rta.toolbar.Fiori", {
43
43
  metadata: {
44
44
  library: "sap.ui.rta"
45
45
  },
@@ -60,14 +60,14 @@ function(
60
60
 
61
61
  Fiori.prototype.buildControls = function(...aArgs) {
62
62
  return Adaptation.prototype.buildControls.apply(this, aArgs).then(function(aControls) {
63
- var sLogoPath = this._oFioriHeader.getLogo();
63
+ const sLogoPath = this._oFioriHeader.getLogo();
64
64
 
65
65
  if (this._oFioriHeader.getShowLogo() && sLogoPath) {
66
66
  // Unstable: if FLP changes ID of <img> element, logo could be not found
67
67
  // $() is still needed because this._oFioriHeader does not offer a getDomRef method
68
- var oLogo = this._oFioriHeader.$().find("#shell-header-icon").get(0);
69
- var iWidth;
70
- var iHeight;
68
+ const oLogo = this._oFioriHeader.$().find("#shell-header-icon").get(0);
69
+ let iWidth;
70
+ let iHeight;
71
71
 
72
72
  if (oLogo) {
73
73
  iWidth = oLogo.getBoundingClientRect().width;
@@ -102,10 +102,10 @@ function(
102
102
  };
103
103
 
104
104
  Fiori.prototype._checkLogoSize = function(oLogo, iWidth, iHeight) {
105
- var iNaturalWidth = oLogo.naturalWidth;
106
- var iNaturalHeight = oLogo.naturalHeight;
105
+ const iNaturalWidth = oLogo.naturalWidth;
106
+ const iNaturalHeight = oLogo.naturalHeight;
107
107
 
108
- if (iWidth !== iNaturalWidth || iHeight !== iNaturalHeight) {
108
+ if (Math.round(iWidth) !== iNaturalWidth || Math.round(iHeight) !== iNaturalHeight) {
109
109
  Log.error([
110
110
  "sap.ui.rta: please check Fiori Launchpad logo, expected size is",
111
111
  `${iWidth}x${iHeight},`,
@@ -124,7 +124,7 @@ function(
124
124
 
125
125
  Fiori.prototype._hideElementsOnIntersection = function(...aArgs) {
126
126
  const [sSectionName, aEntries] = aArgs;
127
- var bWiderThanLogo;
127
+ let bWiderThanLogo;
128
128
 
129
129
  if (aEntries[0].intersectionRatio === 0) {
130
130
  this.adjustToolbarSectionWidths();
@@ -136,7 +136,7 @@ function(
136
136
  !this._iLogoVisibilityLimit
137
137
  && sSectionName === Adaptation.LEFT_SECTION
138
138
  ) {
139
- var iHiddenWidth = aEntries[0].boundingClientRect.width - aEntries[0].intersectionRect.width;
139
+ const iHiddenWidth = aEntries[0].boundingClientRect.width - aEntries[0].intersectionRect.width;
140
140
  bWiderThanLogo = iHiddenWidth > this._iLogoWidth;
141
141
  this._iLogoVisibilityLimit = this._calculateWindowWidth(aEntries);
142
142
  this._setLogoVisibility(false);
@@ -150,8 +150,8 @@ function(
150
150
  };
151
151
 
152
152
  Fiori.prototype._setLogoVisibility = function(bVisible) {
153
- var oIconBox = this.getControl("iconBox");
154
- var oIconSpacer = this.getControl("iconSpacer");
153
+ const oIconBox = this.getControl("iconBox");
154
+ const oIconSpacer = this.getControl("iconSpacer");
155
155
  oIconBox.setVisible(bVisible);
156
156
  oIconSpacer.setVisible(bVisible);
157
157
  };
@@ -20,7 +20,7 @@ function(
20
20
  * @extends sap.ui.rta.toolbar.Adaptation
21
21
  *
22
22
  * @author SAP SE
23
- * @version 1.130.0
23
+ * @version 1.131.0
24
24
  *
25
25
  * @constructor
26
26
  * @private
@@ -23,7 +23,7 @@ sap.ui.define([
23
23
  * @extends sap.m.OverflowToolbarButton
24
24
  *
25
25
  * @author SAP SE
26
- * @version 1.130.0
26
+ * @version 1.131.0
27
27
  *
28
28
  * @constructor
29
29
  * @private
@@ -20,7 +20,7 @@ function(
20
20
  * @extends sap.ui.rta.toolbar.Adaptation
21
21
  *
22
22
  * @author SAP SE
23
- * @version 1.130.0
23
+ * @version 1.131.0
24
24
  *
25
25
  * @constructor
26
26
  * @private
@@ -45,7 +45,7 @@ sap.ui.define([
45
45
  * @class
46
46
  *
47
47
  * @author SAP SE
48
- * @version 1.130.0
48
+ * @version 1.131.0
49
49
  *
50
50
  * @constructor
51
51
  * @private
@@ -53,7 +53,7 @@ sap.ui.define([
53
53
  * @class
54
54
  *
55
55
  * @author SAP SE
56
- * @version 1.130.0
56
+ * @version 1.131.0
57
57
  *
58
58
  * @constructor
59
59
  * @private
@@ -38,7 +38,7 @@ sap.ui.define([
38
38
  * @class
39
39
  *
40
40
  * @author SAP SE
41
- * @version 1.130.0
41
+ * @version 1.131.0
42
42
  *
43
43
  * @constructor
44
44
  * @private
@@ -62,7 +62,7 @@ sap.ui.define([
62
62
  * Constructor for a new sap.ui.rta.util.PluginManager
63
63
  * @extends sap.ui.base.ManagedObject
64
64
  * @author SAP SE
65
- * @version 1.130.0
65
+ * @version 1.131.0
66
66
  * @constructor
67
67
  * @private
68
68
  * @since 1.86
@@ -230,13 +230,13 @@ sap.ui.define([
230
230
  this._destroyDefaultPlugins(this.getPlugins());
231
231
  }
232
232
 
233
- Object.keys(this.getPlugins()).forEach(function(sPluginName) {
233
+ Object.keys(this.getPlugins()).forEach((sPluginName) => {
234
234
  if (this.getPlugin(sPluginName).attachElementModified) {
235
235
  this.getPlugin(sPluginName).attachElementModified(fnHandleElementModified);
236
236
  }
237
- }.bind(this));
237
+ });
238
238
 
239
- this.provideCommandStack("settings", oCommandStack);
239
+ this.provideCommandStack(oCommandStack);
240
240
  };
241
241
 
242
242
  /**
@@ -258,13 +258,14 @@ sap.ui.define([
258
258
 
259
259
  /**
260
260
  * Provides command stack to plugins.
261
- * @param {string} sPluginName - Plugin name
262
261
  * @param {sap.ui.rta.command.Stack} oCommandStack - Command stack required in plugins
263
262
  */
264
- PluginManager.prototype.provideCommandStack = function(sPluginName, oCommandStack) {
265
- if (this.getPlugin(sPluginName)) {
266
- this.getPlugin(sPluginName).setCommandStack(oCommandStack);
267
- }
263
+ PluginManager.prototype.provideCommandStack = function(oCommandStack) {
264
+ Object.keys(this.getPlugins()).forEach((sPluginName) => {
265
+ if (this.getPlugin(sPluginName) && this.getPlugin(sPluginName).setCommandStack) {
266
+ this.getPlugin(sPluginName).setCommandStack(oCommandStack);
267
+ }
268
+ });
268
269
  };
269
270
 
270
271
  /**
@@ -42,7 +42,7 @@ sap.ui.define([
42
42
  * Constructor for a new sap.ui.rta.util.PopupManager
43
43
  * @extends sap.ui.base.ManagedObject
44
44
  * @author SAP SE
45
- * @version 1.130.0
45
+ * @version 1.131.0
46
46
  * @constructor
47
47
  * @private
48
48
  * @since 1.48
@@ -30,7 +30,7 @@ sap.ui.define([
30
30
  * @namespace sap.ui.rta.util.ReloadManager
31
31
  * @alias sap.ui.rta.util.ReloadManager
32
32
  * @since 1.104
33
- * @version 1.130.0
33
+ * @version 1.131.0
34
34
  * @private
35
35
  * @ui5-restricted
36
36
  */
@@ -19,7 +19,7 @@ function(
19
19
  *
20
20
  * @extends sap.ui.core.EventBus
21
21
  * @author SAP SE
22
- * @version 1.130.0
22
+ * @version 1.131.0
23
23
  * @private
24
24
  * @since 1.56.0
25
25
  * @alias sap.ui.rta.util.ServiceEventBus
@@ -27,7 +27,7 @@ sap.ui.define([
27
27
  *
28
28
  * @extends sap.ui.base.ManagedObject
29
29
  * @author SAP SE
30
- * @version 1.130.0
30
+ * @version 1.131.0
31
31
  * @constructor
32
32
  * @private
33
33
  * @since 1.121
@@ -46,7 +46,7 @@ sap.ui.define([
46
46
  * @alias sap.ui.rta.util.changeVisualization.ChangeIndicator
47
47
  * @author SAP SE
48
48
  * @since 1.84.0
49
- * @version 1.130.0
49
+ * @version 1.131.0
50
50
  * @private
51
51
  */
52
52
  const ChangeIndicator = Control.extend("sap.ui.rta.util.changeVisualization.ChangeIndicator", {