@openui5/sap.ui.rta 1.116.0 → 1.117.1

package/src/sap/ui/rta/toolbar/Adaptation.js

@@ -51,7 +51,7 @@ sap.ui.define([
 	 * @extends sap.ui.rta.toolbar.Base
 	 *
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 *
 	 * @constructor
 	 * @private
@@ -352,47 +352,54 @@ sap.ui.define([
 	function confirmMigration(oRtaInformation) {
 		var bDirty = oRtaInformation.commandStack.canSave();
 
-		Utils.showMessageBox("confirm", (bDirty) ? "DAC_DIALOG_MIGRATION_DIRTY_DESCRIPTION" : "DAC_DIALOG_MIGRATION_DESCRIPTION", {
+		return Utils.showMessageBox("confirm", (bDirty) ? "DAC_DIALOG_MIGRATION_DIRTY_DESCRIPTION" : "DAC_DIALOG_MIGRATION_DESCRIPTION", {
 			titleKey: "DAC_DIALOG_MIGRATION_HEADER",
 			actionKeys: ["DAC_DIALOG_MIGRATION_HEADER"],
 			showCancel: true
 		})
 		.then(function(sAction) {
 			if (sAction !== MessageBox.Action.CANCEL) {
-				BusyIndicator.show();
-
 				if (bDirty) {
-					oRtaInformation.commandStack.removeAllCommands(true);
-				}
-
-				ContextBasedAdaptationsAPI.migrate({
-					control: oRtaInformation.rootControl,
-					layer: oRtaInformation.flexSettings.layer
-				})
-				.finally(function() {
-					BusyIndicator.hide();
-				})
-				.then(Utils.showMessageBox.bind(undefined, "information", "DAC_DIALOG_MIGRATION_SUCCESSFULL_DESCRIPTION", {
-					titleKey: "DAC_DIALOG_MIGRATION_HEADER"
-				}))
-				.then(function() {
 					return new Promise(function(resolve) {
-						this.fireEvent("switchAdaptation", {adaptationId: "DEFAULT", callback: resolve});
+						this.fireEvent("save", {callback: resolve});
+					}.bind(this))
+					.then(function() {
+						return performMigration.call(this, oRtaInformation);
 					}.bind(this));
-				}.bind(this))
-				.catch(function(oError) {
-					Log.error(oError.stack || oError);
-					var sMessage = "DAC_DIALOG_MIGRATION_ERROR_DESCRIPTION";
-					var oOptions = {
-						titleKey: "DAC_DIALOG_MIGRATION_HEADER",
-						details: oError.userMessage || oError
-					};
-					Utils.showMessageBox("error", sMessage, oOptions);
-				});
+				}
+				return performMigration.call(this, oRtaInformation);
 			}
 		}.bind(this));
 	}
 
+	function performMigration(oRtaInformation) {
+		BusyIndicator.show();
+		return ContextBasedAdaptationsAPI.migrate({
+			control: oRtaInformation.rootControl,
+			layer: oRtaInformation.flexSettings.layer
+		})
+		.finally(function() {
+			BusyIndicator.hide();
+		})
+		.then(Utils.showMessageBox.bind(undefined, "information", "DAC_DIALOG_MIGRATION_SUCCESSFULL_DESCRIPTION", {
+			titleKey: "DAC_DIALOG_MIGRATION_HEADER"
+		}))
+		.then(function() {
+			return new Promise(function(resolve) {
+				this.fireEvent("switchAdaptation", {adaptationId: "DEFAULT", callback: resolve});
+			}.bind(this));
+		}.bind(this))
+		.catch(function(oError) {
+			Log.error(oError.stack || oError);
+			var sMessage = "DAC_DIALOG_MIGRATION_ERROR_DESCRIPTION";
+			var oOptions = {
+				titleKey: "DAC_DIALOG_MIGRATION_HEADER",
+				details: oError.userMessage || oError
+			};
+			Utils.showMessageBox("error", sMessage, oOptions);
+		});
+	}
+
 	function onSaveAsAdaptation() {
 		var oRtaInformation = this.getRtaInformation();
 		Utils.checkDraftOverwrite(this.getModel("versions")).then(function() {

package/src/sap/ui/rta/toolbar/Base.js

@@ -29,7 +29,7 @@ sap.ui.define([
 	 * @extends sap.m.HBox
 	 *
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/Fiori.js

@@ -32,7 +32,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/FioriLike.js

@@ -20,7 +20,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/OverflowToolbarButton.js

@@ -23,7 +23,7 @@ sap.ui.define([
 	 * @extends sap.m.OverflowToolbarButton
 	 *
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/Personalization.js

@@ -22,7 +22,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Base
 	 *
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/Standalone.js

@@ -20,7 +20,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/contextBased/SaveAsAdaptation.js

@@ -41,7 +41,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/contextBased/SaveAsAdaptationDialog.fragment.xml

@@ -38,7 +38,6 @@
 							<form:label>
 								<Label id="saveAdaptation-title-label"
 									text="{i18n>APP_DIALOG_TITLE_TEXT}"
-									textAlign="Left"
 									required="true">
 								</Label>
 							</form:label>
@@ -53,7 +52,6 @@
 							<form:label>
 								<Label id="saveAdaptation-rank-label"
 									text="{i18n>CLM_HEADER_PRIORITY}"
-									textAlign="Left"
 									required="true">
 								</Label>
 							</form:label>

package/src/sap/ui/rta/toolbar/translation/Translation.js

@@ -49,7 +49,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/versioning/Versioning.js

@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/util/PluginManager.js

@@ -68,7 +68,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PluginManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 * @constructor
 	 * @private
 	 * @since 1.86

package/src/sap/ui/rta/util/PopupManager.js

@@ -42,7 +42,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PopupManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 * @constructor
 	 * @private
 	 * @since 1.48

package/src/sap/ui/rta/util/ReloadManager.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @namespace sap.ui.rta.util.ReloadManager
 	 * @alias sap.ui.rta.util.ReloadManager
 	 * @since 1.104
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 * @private
 	 * @ui5-restricted
 	 */

package/src/sap/ui/rta/util/ServiceEventBus.js

@@ -19,7 +19,7 @@ function(
 	 *
 	 * @extends sap.ui.core.EventBus
 	 * @author SAP SE
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 * @private
 	 * @since 1.56.0
 	 * @alias sap.ui.rta.util.ServiceEventBus

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js

@@ -42,7 +42,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicator
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 * @private
 	 */
 	var ChangeIndicator = Control.extend("sap.ui.rta.util.changeVisualization.ChangeIndicator", {
@@ -175,6 +175,8 @@ sap.ui.define([
 		// the indicator should be centered only if the element has a small enough height to improve the design and visibility
 		if (iOverlayHeight < iIndicatorHeight * 5) {
 			oIndicator.addStyleClass("sapUiRtaChangeIndicatorVerticallyCentered");
+		} else {
+			oIndicator.removeStyleClass("sapUiRtaChangeIndicatorVerticallyCentered");
 		}
 	}
 

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js

@@ -39,7 +39,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry
 	 * @author SAP SE
 	 * @since 1.86.0
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 * @private
 	 */
 	var ChangeIndicatorRegistry = ManagedObject.extend("sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry", {

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualization.js

@@ -7,12 +7,12 @@
 sap.ui.define([
 	"sap/ui/core/Core",
 	"sap/ui/core/Fragment",
+	"sap/base/util/isEmptyObject",
 	"sap/base/util/restricted/_difference",
 	"sap/base/util/deepEqual",
 	"sap/ui/core/util/reflection/JsControlTreeModifier",
 	"sap/ui/core/Control",
 	"sap/ui/dt/OverlayRegistry",
-	"sap/ui/dt/OverlayUtil",
 	"sap/ui/dt/ElementUtil",
 	"sap/ui/fl/write/api/PersistenceWriteAPI",
 	"sap/ui/fl/Layer",
@@ -26,12 +26,12 @@ sap.ui.define([
 ], function(
 	Core,
 	Fragment,
+	isEmptyObject,
 	difference,
 	deepEqual,
 	JsControlTreeModifier,
 	Control,
 	OverlayRegistry,
-	OverlayUtil,
 	ElementUtil,
 	PersistenceWriteAPI,
 	Layer,
@@ -82,7 +82,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeVisualization
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.116.0
+	 * @version 1.117.1
 	 * @private
 	 */
 	var ChangeVisualization = Control.extend("sap.ui.rta.util.changeVisualization.ChangeVisualization", {
@@ -406,7 +406,7 @@ sap.ui.define([
 			return sCommand;
 		}
 
-		if (!oChange.getSelector || !oChange.getSelector()) {
+		if (!oChange.getSelector || !oChange.getSelector() || isEmptyObject(oChange.getSelector())) {
 			return false;
 		}
 

package/ui5.yaml

@@ -1,5 +1,5 @@
 ---
-specVersion: "2.0"
+specVersion: "3.0"
 type: library
 metadata:
   name: sap.ui.rta