@openui5/sap.ui.rta 1.115.1 → 1.117.0

package/src/sap/ui/rta/service/Property.js

@@ -28,7 +28,7 @@ sap.ui.define([
 	 * @author SAP SE
 	 * @experimental Since 1.58
 	 * @since 1.58
-	 * @version 1.115.1
+	 * @version 1.117.0
 	 * @private
 	 * @ui5-restricted
 	*/
@@ -92,7 +92,7 @@ sap.ui.define([
 		 * @return {object} Object containing properties, annotations, label and name
 		 * @private
 		 */
-		oProperty._getDesignTimeProperties = function (sControlId) {
+		oProperty._getDesignTimeProperties = function(sControlId) {
 			var oOverlay = OverlayRegistry.getOverlay(sControlId);
 			// if overlay could not be found
 			if (!oOverlay) {
@@ -117,16 +117,16 @@ sap.ui.define([
 					oProperty._getResolvedLinks(oDesignTimeMetadataData.links, oElement)
 				]
 			)
-				.then(function (aPromiseResults) {
-					return Object.assign(
-						{},
-						aPromiseResults[0] && !isEmptyObject(aPromiseResults[0]) && {annotations: aPromiseResults[0]},
-						aPromiseResults[1] && {properties: aPromiseResults[1]},
-						aPromiseResults[2] && {label: validate(aPromiseResults[2])},
-						oDesignTimeMetadataData.name && {name: oDesignTimeMetadata.getName(oElement)},
-						!isEmptyObject(aPromiseResults[3]) && {links: aPromiseResults[3]}
-					);
-				});
+			.then(function(aPromiseResults) {
+				return Object.assign(
+					{},
+					aPromiseResults[0] && !isEmptyObject(aPromiseResults[0]) && {annotations: aPromiseResults[0]},
+					aPromiseResults[1] && {properties: aPromiseResults[1]},
+					aPromiseResults[2] && {label: validate(aPromiseResults[2])},
+					oDesignTimeMetadataData.name && {name: oDesignTimeMetadata.getName(oElement)},
+					!isEmptyObject(aPromiseResults[3]) && {links: aPromiseResults[3]}
+				);
+			});
 		};
 
 		/**
@@ -140,75 +140,75 @@ sap.ui.define([
 		 * @return {object} Promise resolving to an object containing all properties consolidated
 		 * @private
 		 */
-		oProperty._getConsolidatedProperties = function (vDtProperties, mMetadataObj, oElement) {
+		oProperty._getConsolidatedProperties = function(vDtProperties, mMetadataObj, oElement) {
 			var mFilteredMetadataObject = Object.keys(mMetadataObj)
-				.reduce(function (mFiltered, sKey) {
-					mFiltered[sKey] = {
-						value: validate(oElement.getProperty(sKey)),
-						virtual: false,
-						type: mMetadataObj[sKey].type,
-						name: mMetadataObj[sKey].name,
-						ignore: false, // default value, might be overwritten below if required by designtime metadata
-						group: mMetadataObj[sKey].group,
-						deprecated: mMetadataObj[sKey].deprecated,
-						defaultValue: mMetadataObj[sKey].defaultValue,
-						visibility: mMetadataObj[sKey].visibility
-					};
-					var mBindingInfo = oProperty._getBindingInfo(sKey, oElement);
-					Object.assign(
-						mFiltered[sKey],
-						mBindingInfo && {binding: mBindingInfo}
-					);
-					return mFiltered;
-				}, {});
+			.reduce(function(mFiltered, sKey) {
+				mFiltered[sKey] = {
+					value: validate(oElement.getProperty(sKey)),
+					virtual: false,
+					type: mMetadataObj[sKey].type,
+					name: mMetadataObj[sKey].name,
+					ignore: false, // default value, might be overwritten below if required by designtime metadata
+					group: mMetadataObj[sKey].group,
+					deprecated: mMetadataObj[sKey].deprecated,
+					defaultValue: mMetadataObj[sKey].defaultValue,
+					visibility: mMetadataObj[sKey].visibility
+				};
+				var mBindingInfo = oProperty._getBindingInfo(sKey, oElement);
+				Object.assign(
+					mFiltered[sKey],
+					mBindingInfo && {binding: mBindingInfo}
+				);
+				return mFiltered;
+			}, {});
 
 			return oProperty._getResolvedFunction(vDtProperties, oElement)
-				.then(function(mDtObj) {
-					return Promise.all(
-						// for each property in the mDtObj.properties a promise is returned
-						Object.keys(mDtObj)
-							.map(function (sKey) {
-								return oProperty._getResolvedFunction(mDtObj[sKey].ignore, oElement)
-									.then(function (bIgnore) {
-										if (typeof bIgnore !== "boolean") {
-											throw DtUtil.createError(
-												"services.Property#get",
-												"Invalid ignore property value found in designtime for element with id " + oElement.getId() + " .", "sap.ui.rta"
-											);
-										}
+			.then(function(mDtObj) {
+				return Promise.all(
+					// for each property in the mDtObj.properties a promise is returned
+					Object.keys(mDtObj)
+					.map(function(sKey) {
+						return oProperty._getResolvedFunction(mDtObj[sKey].ignore, oElement)
+						.then(function(bIgnore) {
+							if (typeof bIgnore !== "boolean") {
+								throw DtUtil.createError(
+									"services.Property#get",
+									"Invalid ignore property value found in designtime for element with id " + oElement.getId() + " .", "sap.ui.rta"
+								);
+							}
 
-										var mResult = {};
+							var mResult = {};
 
-										// ensure ignore function is replaced by a boolean value
-										if (!mFilteredMetadataObject[sKey]) {
-											//  if not available in control metadata
-											if (mDtObj[sKey].virtual === true) {
-												// virtual properties
-												mResult = oProperty._getEvaluatedVirtualProperty(mDtObj, sKey, oElement, bIgnore);
-											} else {
-												// dt-metadata properties
-												mResult[sKey] = {
-													value: validate(_omit(mDtObj[sKey], "ignore")),
-													virtual: false,
-													ignore: bIgnore
-												};
-											}
-										} else {
-											mResult[sKey] = {
-												ignore: bIgnore
-											};
-										}
+							// ensure ignore function is replaced by a boolean value
+							if (!mFilteredMetadataObject[sKey]) {
+								//  if not available in control metadata
+								if (mDtObj[sKey].virtual === true) {
+									// virtual properties
+									mResult = oProperty._getEvaluatedVirtualProperty(mDtObj, sKey, oElement, bIgnore);
+								} else {
+									// dt-metadata properties
+									mResult[sKey] = {
+										value: validate(_omit(mDtObj[sKey], "ignore")),
+										virtual: false,
+										ignore: bIgnore
+									};
+								}
+							} else {
+								mResult[sKey] = {
+									ignore: bIgnore
+								};
+							}
 
-										return mResult;
-									});
-							})
-					);
-				})
-				.then(function (aFilteredResults) {
-					return aFilteredResults.reduce(function (mConsolidatedObject, oFilteredResult) {
-						return merge(mConsolidatedObject, oFilteredResult);
-					}, mFilteredMetadataObject);
-				});
+							return mResult;
+						});
+					})
+				);
+			})
+			.then(function(aFilteredResults) {
+				return aFilteredResults.reduce(function(mConsolidatedObject, oFilteredResult) {
+					return merge(mConsolidatedObject, oFilteredResult);
+				}, mFilteredMetadataObject);
+			});
 		};
 
 		/**
@@ -237,16 +237,16 @@ sap.ui.define([
 
 			// evaluate possibleValues
 			return oProperty._getResolvedFunction(mDtObj[sPropertyName].possibleValues, oElement)
-				.then(function(vPossibleValues) {
-					Object.assign(
-						mEvaluatedProperty[sPropertyName],
-						mBindingInfo && {binding: mBindingInfo},
-						vPossibleValues && {possibleValues: validate(vPossibleValues)},
-						typeof mDtObj[sPropertyName].nullable === "boolean" && {nullable: mDtObj[sPropertyName].nullable} // nullable property
-					);
+			.then(function(vPossibleValues) {
+				Object.assign(
+					mEvaluatedProperty[sPropertyName],
+					mBindingInfo && {binding: mBindingInfo},
+					vPossibleValues && {possibleValues: validate(vPossibleValues)},
+					typeof mDtObj[sPropertyName].nullable === "boolean" && {nullable: mDtObj[sPropertyName].nullable} // nullable property
+				);
 
-					return mEvaluatedProperty;
-				});
+				return mEvaluatedProperty;
+			});
 		};
 
 		/**
@@ -259,39 +259,39 @@ sap.ui.define([
 		 * @return {Promise} Promise resolving to an object containing all annotations consolidated
 		 * @private
 		 */
-		oProperty._getConsolidatedAnnotations = function (mDtObj, oElement) {
+		oProperty._getConsolidatedAnnotations = function(mDtObj, oElement) {
 			return Promise.all(
 				Object.keys(mDtObj)
-					.map(function (sKey) {
-						return oProperty._getResolvedFunction(mDtObj[sKey].ignore, oElement)
-							.then(function (bIgnore) {
-								var mFiltered = {};
-								if (typeof bIgnore !== "boolean" && typeof bIgnore !== "undefined") {
-									throw DtUtil.createError(
-										"services.Property#get",
-										"Invalid ignore property value found in designtime for element with id " + oElement.getId() + " .", "sap.ui.rta"
-									);
-								}
-								// to ensure ignore function is replaced by a boolean value
-								mDtObj[sKey].ignore = bIgnore;
-								if (!bIgnore) {
-									mFiltered[sKey] = Object.assign({}, mDtObj[sKey]);
-									return oProperty._getResolvedLinks(mFiltered[sKey].links, oElement)
-									.then(function (mLinks) {
-										if (!isEmptyObject(mLinks)) {
-											mFiltered[sKey].links = mLinks;
-										}
-										return mFiltered;
-									});
+				.map(function(sKey) {
+					return oProperty._getResolvedFunction(mDtObj[sKey].ignore, oElement)
+					.then(function(bIgnore) {
+						var mFiltered = {};
+						if (typeof bIgnore !== "boolean" && typeof bIgnore !== "undefined") {
+							throw DtUtil.createError(
+								"services.Property#get",
+								"Invalid ignore property value found in designtime for element with id " + oElement.getId() + " .", "sap.ui.rta"
+							);
+						}
+						// to ensure ignore function is replaced by a boolean value
+						mDtObj[sKey].ignore = bIgnore;
+						if (!bIgnore) {
+							mFiltered[sKey] = Object.assign({}, mDtObj[sKey]);
+							return oProperty._getResolvedLinks(mFiltered[sKey].links, oElement)
+							.then(function(mLinks) {
+								if (!isEmptyObject(mLinks)) {
+									mFiltered[sKey].links = mLinks;
 								}
+								return mFiltered;
 							});
-					})
+						}
+					});
+				})
 			)
-				.then(function (aFilteredResults) {
-					return aFilteredResults.reduce(function (mConsolidatedObject, oFilteredResult) {
-						return Object.assign(mConsolidatedObject, oFilteredResult);
-					}, {});
-				});
+			.then(function(aFilteredResults) {
+				return aFilteredResults.reduce(function(mConsolidatedObject, oFilteredResult) {
+					return Object.assign(mConsolidatedObject, oFilteredResult);
+				}, {});
+			});
 		};
 
 		/**
@@ -315,30 +315,30 @@ sap.ui.define([
 		 * @return {Promise} Promise resolving to links map
 		 * @private
 		 */
-		oProperty._getResolvedLinks = function (mLinks, oElement) {
+		oProperty._getResolvedLinks = function(mLinks, oElement) {
 			var aTextPromises = [];
 			var mResolvedLinks = Object.assign({}, mLinks);
 
-			Object.keys(mResolvedLinks).forEach(function (sLinkName) {
+			Object.keys(mResolvedLinks).forEach(function(sLinkName) {
 				if (Array.isArray(mResolvedLinks[sLinkName])) {
-					mResolvedLinks[sLinkName].forEach(function (oLink) {
+					mResolvedLinks[sLinkName].forEach(function(oLink) {
 						aTextPromises.push(
-							DtUtil.wrapIntoPromise(function () {
+							DtUtil.wrapIntoPromise(function() {
 								if (typeof oLink.text === "function") {
 									return oLink.text(oElement);
 								}
 							})(oLink)
-								.then(function (sLinkText) {
-									oLink.text = validate(sLinkText || oLink.text);
-								})
+							.then(function(sLinkText) {
+								oLink.text = validate(sLinkText || oLink.text);
+							})
 						);
 					});
 				}
 			});
 			return Promise.all(aTextPromises)
-				.then(function () {
-					return mResolvedLinks;
-				});
+			.then(function() {
+				return mResolvedLinks;
+			});
 		};
 
 		/**
@@ -350,7 +350,7 @@ sap.ui.define([
 		 * @return {object} Object containing the binding information
 		 * @private
 		 */
-		oProperty._getBindingInfo = function (sKey, oElement) {
+		oProperty._getBindingInfo = function(sKey, oElement) {
 			var mPropertyBindingInfo = oElement.getBindingInfo(sKey);
 			if (!mPropertyBindingInfo) {
 				return;
@@ -395,8 +395,8 @@ sap.ui.define([
 		 * @return {Promise} Promise resolving to the property value
 		 * @private
 		 */
-		oProperty._getResolvedFunction = function (vProperty, oElement) {
-			return DtUtil.wrapIntoPromise(function () {
+		oProperty._getResolvedFunction = function(vProperty, oElement) {
+			return DtUtil.wrapIntoPromise(function() {
 				return typeof vProperty === "function"
 					? (vProperty(oElement) || false) // could return a promise
 					: (vProperty || false);

package/src/sap/ui/rta/service/Receiver.js

@@ -8,32 +8,32 @@ sap.ui.define([
 	"sap/ui/core/postmessage/Bus",
 	"sap/ui/dt/Util",
 	"sap/base/util/uid"
-], function (
+], function(
 	PostMessageBus,
 	DtUtil,
 	uid
 ) {
 	"use strict";
 
-	var CHANNEL_ID = 'sap.ui.rta.service.receiver';
+	var CHANNEL_ID = "sap.ui.rta.service.receiver";
 	var oPostMessageBus;
 
-	return function (oRta) {
+	return function(oRta) {
 		var mEventHandlers = {};
 
-		var fnReceiver = function (oEvent) {
+		var fnReceiver = function(oEvent) {
 			var mData = oEvent.data;
 			var mRequestBody = mData.body;
 
 			switch (oEvent.eventId) {
 				case "getService":
 					var sServiceName = mRequestBody.arguments[0];
-					oRta.getService(sServiceName).then(function (oService) {
+					oRta.getService(sServiceName).then(function(oService) {
 						var mProperties = {};
 						var aMethods = [];
 
-						Object.keys(oService).forEach(function (sKey) {
-							if (typeof oService[sKey] === 'function') {
+						Object.keys(oService).forEach(function(sKey) {
+							if (typeof oService[sKey] === "function") {
 								if (!/^(at|de)tach/.test(sKey)) { // ignore system methods
 									aMethods.push(sKey);
 								}
@@ -59,33 +59,11 @@ sap.ui.define([
 						});
 					});
 					break;
-				case 'callMethod':
+				case "callMethod":
 					oRta.getService(mRequestBody.service)
-						.then(function (oService) {
-							oService[mRequestBody.method].apply(null, mRequestBody.arguments)
-								.then(function (vResult) {
-									oPostMessageBus.publish({
-										target: oEvent.source,
-										origin: oEvent.origin,
-										channelId: CHANNEL_ID,
-										eventId: 'callMethod',
-										data: {
-											type: 'response',
-											status: 'success',
-											id: mData.id,
-											body: vResult
-										}
-									});
-								});
-						})
-						.catch(function (vError) {
-							var oError = DtUtil.propagateError(
-								vError,
-								"service.Receiver",
-								DtUtil.printf("Can't execute method {0} of service {1} due unexpected error.", mRequestBody.method, mRequestBody.service),
-								"sap.ui.rta"
-							);
-
+					.then(function(oService) {
+						oService[mRequestBody.method].apply(null, mRequestBody.arguments)
+						.then(function(vResult) {
 							oPostMessageBus.publish({
 								target: oEvent.source,
 								origin: oEvent.origin,
@@ -93,69 +71,92 @@ sap.ui.define([
 								eventId: "callMethod",
 								data: {
 									type: "response",
-									status: "error",
+									status: "success",
 									id: mData.id,
-									body: oError.toString()
+									body: vResult
 								}
 							});
 						});
+					})
+					.catch(function(vError) {
+						var oError = DtUtil.propagateError(
+							vError,
+							"service.Receiver",
+							DtUtil.printf("Can't execute method {0} of service {1} due unexpected error.", mRequestBody.method, mRequestBody.service),
+							"sap.ui.rta"
+						);
+
+						oPostMessageBus.publish({
+							target: oEvent.source,
+							origin: oEvent.origin,
+							channelId: CHANNEL_ID,
+							eventId: "callMethod",
+							data: {
+								type: "response",
+								status: "error",
+								id: mData.id,
+								body: oError.toString()
+							}
+						});
+					});
 					break;
-				case 'subscribe':
+				case "subscribe":
 					oRta.getService(mRequestBody.service)
-						.then(function (oService) {
-							var fnHandler = function (vData) {
-								oPostMessageBus.publish({
-									target: oEvent.source,
-									origin: oEvent.origin,
-									channelId: CHANNEL_ID,
-									eventId: 'event',
-									data: {
-										body: {
-											service: mRequestBody.service,
-											event: mRequestBody.event,
-											data: vData
-										}
-									}
-								});
-							};
-							var sHandlerId = uid();
-							mEventHandlers[sHandlerId] = fnHandler;
-							oService.attachEvent(mRequestBody.event, fnHandler);
+					.then(function(oService) {
+						var fnHandler = function(vData) {
 							oPostMessageBus.publish({
 								target: oEvent.source,
 								origin: oEvent.origin,
 								channelId: CHANNEL_ID,
-								eventId: 'subscribe',
+								eventId: "event",
 								data: {
-									type: 'response',
-									status: 'success',
-									id: mData.id,
 									body: {
-										id: sHandlerId
+										service: mRequestBody.service,
+										event: mRequestBody.event,
+										data: vData
 									}
 								}
 							});
+						};
+						var sHandlerId = uid();
+						mEventHandlers[sHandlerId] = fnHandler;
+						oService.attachEvent(mRequestBody.event, fnHandler);
+						oPostMessageBus.publish({
+							target: oEvent.source,
+							origin: oEvent.origin,
+							channelId: CHANNEL_ID,
+							eventId: "subscribe",
+							data: {
+								type: "response",
+								status: "success",
+								id: mData.id,
+								body: {
+									id: sHandlerId
+								}
+							}
 						});
+					});
 					break;
-				case 'unsubscribe':
+				case "unsubscribe":
 					oRta.getService(mRequestBody.service)
-						.then(function (oService) {
-							oService.detachEvent(mRequestBody.event, mEventHandlers[mRequestBody.id]);
-							delete mEventHandlers[mRequestBody.id];
-							oPostMessageBus.publish({
-								target: oEvent.source,
-								origin: oEvent.origin,
-								channelId: CHANNEL_ID,
-								eventId: 'unsubscribe',
-								data: {
-									type: 'response',
-									status: 'success',
-									id: mData.id
-								}
-							});
+					.then(function(oService) {
+						oService.detachEvent(mRequestBody.event, mEventHandlers[mRequestBody.id]);
+						delete mEventHandlers[mRequestBody.id];
+						oPostMessageBus.publish({
+							target: oEvent.source,
+							origin: oEvent.origin,
+							channelId: CHANNEL_ID,
+							eventId: "unsubscribe",
+							data: {
+								type: "response",
+								status: "success",
+								id: mData.id
+							}
 						});
+					});
 					break;
-				// no default
+				default:
+					// no default
 			}
 		};
 
@@ -171,7 +172,7 @@ sap.ui.define([
 		oPostMessageBus.subscribe(CHANNEL_ID, "unsubscribe", fnReceiver);
 
 		return {
-			destroy: function () {
+			destroy: function() {
 				if (oPostMessageBus) {
 					oPostMessageBus.unsubscribe(CHANNEL_ID, "getService", fnReceiver);
 					oPostMessageBus.unsubscribe(CHANNEL_ID, "callMethod", fnReceiver);

package/src/sap/ui/rta/service/Selection.js

@@ -4,7 +4,7 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
-sap.ui.define(function () {
+sap.ui.define(function() {
 	"use strict";
 
 	/**
@@ -15,21 +15,21 @@ sap.ui.define(function () {
 	 * @author SAP SE
 	 * @experimental Since 1.58
 	 * @since 1.58
-	 * @version 1.115.1
+	 * @version 1.117.0
 	 * @private
 	 * @ui5-restricted
 	*/
 
-	return function (oRta, fnPublish) {
+	return function(oRta, fnPublish) {
 		var oSelectionManager = oRta._oDesignTime.getSelectionManager();
 
 		function getControlIds(aElementOverlays) {
-			return aElementOverlays.map(function (oElementOverlay) {
+			return aElementOverlays.map(function(oElementOverlay) {
 				return oElementOverlay.getElement().getId();
 			});
 		}
 
-		oSelectionManager.attachEvent("change", function (oEvent) {
+		oSelectionManager.attachEvent("change", function(oEvent) {
 			fnPublish("change", getControlIds(oEvent.getParameter("selection")));
 		});
 
@@ -48,7 +48,7 @@ sap.ui.define(function () {
 				 * @return {string[]} Selected control IDs
 				 * @public
 				 */
-				get: function () {
+				get: function() {
 					return getControlIds(oSelectionManager.get());
 				},