@openui5/sap.ui.rta 1.113.0 → 1.114.1

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualization.js

@@ -12,6 +12,7 @@ sap.ui.define([
 	"sap/ui/core/util/reflection/JsControlTreeModifier",
 	"sap/ui/core/Control",
 	"sap/ui/dt/OverlayRegistry",
+	"sap/ui/dt/OverlayUtil",
 	"sap/ui/dt/ElementUtil",
 	"sap/ui/fl/write/api/PersistenceWriteAPI",
 	"sap/ui/fl/Layer",
@@ -30,6 +31,7 @@ sap.ui.define([
 	JsControlTreeModifier,
 	Control,
 	OverlayRegistry,
+	OverlayUtil,
 	ElementUtil,
 	PersistenceWriteAPI,
 	Layer,
@@ -53,7 +55,7 @@ sap.ui.define([
 		}
 	}
 
-	function _isOverlayVisible(oOverlay) {
+	function _isOverlayInvisible(oOverlay) {
 		return !oOverlay || !oOverlay.getDomRef() || !oOverlay.isVisible();
 	}
 
@@ -65,7 +67,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeVisualization
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.113.0
+	 * @version 1.114.1
 	 * @private
 	 */
 	var ChangeVisualization = Control.extend("sap.ui.rta.util.changeVisualization.ChangeVisualization", {
@@ -106,9 +108,10 @@ sap.ui.define([
 			}), "i18n");
 
 			this._oChangeVisualizationModel = new JSONModel({
-				active: this.getIsActive()
+				active: this.getIsActive(),
+				changeState: ChangeStates.ALL
 			});
-			this._oChangeVisualizationModel.setDefaultBindingMode("OneWay");
+			this._oChangeVisualizationModel.setDefaultBindingMode("TwoWay");
 			this._sSelectedChangeCategory = ChangeCategories.ALL;
 			this._bSetModeChanged = false;
 
@@ -176,7 +179,11 @@ sap.ui.define([
 	ChangeVisualization.prototype._determineChangeVisibility = function(aRegisteredIndependentChanges, aAllRelevantChanges, sVisualizedChangeState) {
 		function filterRelevantChanges(aChanges) {
 			return aChanges.filter(function(oChange) {
-				if (!sVisualizedChangeState || sVisualizedChangeState === "all" || oChange.changeStates.includes(sVisualizedChangeState)) {
+				if (
+					!sVisualizedChangeState ||
+					sVisualizedChangeState === ChangeStates.ALL ||
+					oChange.changeStates.includes(sVisualizedChangeState)
+				) {
 					return true;
 				}
 				return false;
@@ -206,7 +213,7 @@ sap.ui.define([
 
 			if (!aAllRelevantChangeIds.includes(oChange.change.getId())) {
 				aHiddenChanges.push(oChange);
-			} else if (_isOverlayVisible(oOverlay)) {
+			} else if (_isOverlayInvisible(oOverlay)) {
 				aHiddenChanges.push(oChange);
 			} else {
 				aVisualizedChanges.push(oChange);
@@ -498,7 +505,7 @@ sap.ui.define([
 			var oOverlay = OverlayRegistry.getOverlay(sSelectorId);
 			if (!oOverlay) {
 				// When the selector has no Overlay, check if there is a relevant container Overlay
-				// e.g. when a SmartForm group is removed
+				// e.g. change on a SmartForm group (Selector: parent Form; Relevant Container: SmartForm)
 				aChangesOnIndicator.some(function(oChange) {
 					var oElementOverlay = OverlayRegistry.getOverlay(oChange.affectedElementId);
 					var oRelevantContainer = oElementOverlay && oElementOverlay.getRelevantContainer();
@@ -509,7 +516,7 @@ sap.ui.define([
 					return false;
 				});
 			}
-			if (_isOverlayVisible(oOverlay)) {
+			if (_isOverlayInvisible(oOverlay)) {
 				// Change is not visible
 				return undefined;
 			}
@@ -559,7 +566,7 @@ sap.ui.define([
 				)
 				&& (
 					!oRootData.changeState
-					|| oRootData.changeState === "all"
+					|| oRootData.changeState === ChangeStates.ALL
 					|| oChangeVizInfo.changeStates.includes(oRootData.changeState)
 				)
 			);