@openui5/sap.ui.mdc 1.99.0 → 1.100.1

package/src/sap/ui/mdc/filterbar/p13n/AdaptationFilterBar.js

@@ -4,8 +4,8 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 sap.ui.define([
-	"sap/ui/mdc/filterbar/p13n/GroupContainer", "sap/ui/mdc/filterbar/p13n/FilterGroupLayout","sap/ui/mdc/filterbar/p13n/TableContainer", "sap/ui/mdc/filterbar/p13n/FilterColumnLayout", "sap/ui/mdc/filterbar/FilterBarBase", "sap/ui/mdc/filterbar/FilterBarBaseRenderer"
-], function( GroupContainer, FilterGroupLayout, TableContainer, FilterColumnLayout, FilterBarBase, FilterBarBaseRenderer) {
+	"sap/ui/mdc/filterbar/p13n/GroupContainer", "sap/ui/mdc/filterbar/p13n/FilterColumnLayout", "sap/ui/mdc/filterbar/p13n/FilterGroupLayout","sap/ui/mdc/filterbar/p13n/TableContainer", "sap/ui/mdc/filterbar/FilterBarBase", "sap/ui/mdc/filterbar/FilterBarBaseRenderer", "sap/base/util/merge", "sap/base/util/UriParameters", "sap/ui/core/Core"
+], function( GroupContainer, FilterColumnLayout, FilterGroupLayout, TableContainer, FilterBarBase, FilterBarBaseRenderer, merge, SAPUriParameters, Core) {
 	"use strict";
 
 	/**
@@ -18,7 +18,7 @@ sap.ui.define([
 	 *
 	 * @extends sap.ui.mdc.filterbar.FilterBarBase
 	 * @author SAP SE
-	 * @version 1.99.0
+	 * @version 1.100.1
 	 * @constructor
 	 * @private
 	 * @since 1.80.0
@@ -28,12 +28,13 @@ sap.ui.define([
 	var AdaptationFilterBar = FilterBarBase.extend("sap.ui.mdc.filterbar.p13n.AdaptationFilterBar", {
 		metadata: {
 			library: "sap.ui.mdc",
-			properties: {
+			associations: {
 				/**
 				 * Determines the parent on which the condition changes should be applied on.
 				 */
 				adaptationControl: {
-					type: "object"
+					type: "sap.ui.mdc.Control",
+					multiple: false
 				}
 			},
 			events: {
@@ -49,15 +50,51 @@ sap.ui.define([
 
 	AdaptationFilterBar.prototype.init = function() {
 		FilterBarBase.prototype.init.apply(this,arguments);
+		this.addStyleClass("sapUIAdaptationFilterBar");
 		this._bPersistValues = true;
+
+		this._fnResolveAdaptationControlPromise = null;
+		this._oAdaptationControlPromise = new Promise(function(resolve, reject) {
+			this._fnResolveAdaptationControlPromise = resolve;
+		}.bind(this));
+	};
+	AdaptationFilterBar.prototype.applySettings = function() {
+		FilterBarBase.prototype._applySettings.apply(this, arguments);
+		this._waitForAdaptControlAndPropertyHelper().then(function() {
+			this._initControlDelegate();
+		}.bind(this));
 	};
 
+	AdaptationFilterBar.prototype._waitForAdaptControlAndPropertyHelper = function(){
+		return this._oAdaptationControlPromise.then(function() {
+			return this._getAdaptationControlInstance().awaitPropertyHelper().then(function(oPropertyHelper) {
+				this._oPropertyHelper = oPropertyHelper;
+			}.bind(this));
+		}.bind(this));
+	};
 	AdaptationFilterBar.prototype._initControlDelegate = function() {
-		this._retrieveMetadata().then(function() {
-			this._applyInitialFilterConditions();
+		return this.initControlDelegate().then(function() {
+			//this.getTypeUtil();
+			if (!this._bIsBeingDestroyed) {
+				this._applyInitialFilterConditions();
+			}
+		}.bind(this));
+	};
+
+	AdaptationFilterBar.prototype.initControlDelegate = function() {
+		return this._oAdaptationControlPromise.then(function() {
+			return this._getAdaptationControlInstance().initControlDelegate();
 		}.bind(this));
 	};
 
+	AdaptationFilterBar.prototype.getTypeUtil = function() {
+		if (!this._getAdaptationControlInstance()) {
+			throw new Error("No adaptation control assigned yet.");
+		}
+
+		return this._getAdaptationControlInstance().getTypeUtil();
+	};
+
 	AdaptationFilterBar.prototype.setMessageStrip = function(oStrip) {
 		this._oFilterBarLayout.setMessageStrip(oStrip);
 	};
@@ -73,14 +110,13 @@ sap.ui.define([
 		//update adaptationModel while dialog is open
 		this._oConditionModel.attachPropertyChange(function(oEvt){
 			var sKey = oEvt.getParameter("path").substring(12);
-			if (this.oAdaptationModel){
-				var aItems = this.oAdaptationModel.getProperty("/items");
+			if (this.oAdaptationData){
+				var aItems = this.oAdaptationData.items;
 				var oItem = aItems.find(function(o){
 					return o.name == sKey;
 				});
 				if (oItem) {
-					oItem.isFiltered = this._getConditionModel().getConditions(sKey).length > 0 ? true : false;
-					this.oAdaptationModel.setProperty("/items", aItems);
+					oItem.active = this._getConditionModel().getConditions(sKey).length > 0 ? true : false;
 				}
 			}
 		}.bind(this));
@@ -88,37 +124,53 @@ sap.ui.define([
 		return this;
 	};
 
+	AdaptationFilterBar.prototype._retrieveMetadata = function() {
+
+		return this._oAdaptationControlPromise.then(function() {
+			return this._getAdaptationControlInstance().awaitPropertyHelper().then(function(oPropertyHelper) {
+				this._oMetadataAppliedPromise = Promise.resolve();
+				if (!this._getAdaptationControlInstance().isPropertyHelperFinal()) {
+					return this.finalizePropertyHelper();
+				}
+
+				return FilterBarBase.prototype._retrieveMetadata.apply(this, arguments);
+			}.bind(this));
+		}.bind(this));
+	};
+
 	AdaptationFilterBar.prototype.createConditionChanges = function() {
-		var mConditions = this._getModelConditions(this._getConditionModel(), false, true);
-		if (this._bPersistValues) {
-			//this.getAdaptationControl(), "Filter", mConditions, true, true
-			return this.getEngine().createChanges({
-				control: this.getAdaptationControl(),
-				key: "Filter",
-				state: mConditions,
-				suppressAppliance: true
-			});
-		} else {
-			//TODO: currently only required once the parent FilterBar has p13nMode 'value' disabled.
-			this.getAdaptationControl()._setXConditions(mConditions, true);
-			return Promise.resolve(null);
-		}
+		return Promise.all([this._oAdaptationControlPromise, this._getAdaptationControlInstance().awaitControlDelegate()]).then(function() {
+			var mConditions = this._getModelConditions(this._getConditionModel(), false, true);
+			if (this._bPersistValues) {
+				//this._getAdaptationControlInstance(), "Filter", mConditions, true, true
+				return this.getEngine().createChanges({
+					control: this._getAdaptationControlInstance(),
+					key: "Filter",
+					state: mConditions,
+					suppressAppliance: true
+				});
+			} else {
+				//TODO: currently only required once the parent FilterBar has p13nMode 'value' disabled.
+				this._getAdaptationControlInstance()._setXConditions(mConditions, true);
+				return Promise.resolve(null);
+			}
+			}.bind(this));
 	};
 
 	/**
 	 *
 	 * Please note that the provided model should be created with sap.ui.mdc.p13n.P13nBuilder
 	 *
-	 * @param {object} oP13nModel Model providing the necessary data to display and create <code>FilterColumnLayout</code> instances.
+	 * @param {object} oP13nData Necessary data to display and create <code>FilterColumnLayout</code> instances.
 	 *
 	 */
-	AdaptationFilterBar.prototype.setP13nModel = function(oP13nModel) {
-		this.oAdaptationModel = oP13nModel;
-		this._oFilterBarLayout.update();
+	AdaptationFilterBar.prototype.setP13nData = function(oP13nData) {
+		this.oAdaptationData = oP13nData;
+		this._oFilterBarLayout.update(oP13nData);
 	};
 
-	AdaptationFilterBar.prototype.getP13nModel = function(oP13nModel) {
-		return this.oAdaptationModel;
+	AdaptationFilterBar.prototype.getP13nData = function() {
+		return this.oAdaptationData;
 	};
 
 	AdaptationFilterBar.prototype._handleFilterItemSubmit = function() {
@@ -127,7 +179,7 @@ sap.ui.define([
 
 	AdaptationFilterBar.prototype._getWaitForChangesPromise = function() {
 		//Change is applied on parent --> wait for the parent promise not the child
-		return this.getEngine().waitForChanges(this.getAdaptationControl());
+		return this.getEngine().waitForChanges(this._getAdaptationControlInstance());
 	};
 
 	AdaptationFilterBar.prototype.applyConditionsAfterChangesApplied = function() {
@@ -135,13 +187,6 @@ sap.ui.define([
 		this.triggerSearch();
 	};
 
-
-	AdaptationFilterBar.prototype.initPropertyHelper = function(){
-		return this.getAdaptationControl().awaitPropertyHelper().then(function(oPropertyHelper) {
-			this._oPropertyHelper = oPropertyHelper;
-		}.bind(this));
-	};
-
 	/**
 	 * Method which will initialize the <code>AdaptationFilterBar</code> and create the required FilterFields
 	 *
@@ -149,14 +194,15 @@ sap.ui.define([
 	 */
 	AdaptationFilterBar.prototype.createFilterFields = function(){
 		return this.initialized().then(function(){
-			var mConditions = this._bPersistValues ? this.getAdaptationControl().getFilterConditions() : this.getAdaptationControl()._getXConditions();
+			var mConditions = this._bPersistValues ? this._getAdaptationControlInstance().getFilterConditions() : this._getAdaptationControlInstance()._getXConditions();
 			this._setXConditions(mConditions, true);
 
 			if (this._bFilterFieldsCreated) {
+				this._oFilterBarLayout.setP13nData(this.oAdaptationData);
 				return this;
 			}
 
-			var oAdaptationControl = this.getAdaptationControl();
+			var oAdaptationControl = this._getAdaptationControlInstance();
 			var oDelegate = oAdaptationControl.getControlDelegate();
 			var oFilterDelegate = this._checkAdvancedParent(oAdaptationControl) ? oDelegate : oDelegate.getFilterDelegate();
 
@@ -165,7 +211,7 @@ sap.ui.define([
 
 			var aFieldPromises = [];
 
-			this.oAdaptationModel.getProperty("/items").forEach(function(oItem, iIndex){
+			this.oAdaptationData.items.forEach(function(oItem, iIndex){
 				var oFilterFieldPromise;
 
 				oFilterFieldPromise = this._checkExisting(oItem, oFilterDelegate);
@@ -198,14 +244,12 @@ sap.ui.define([
 			}.bind(this));
 
 			return Promise.all(aFieldPromises).then(function(){
-				this.oAdaptationModel.getProperty("/items").forEach(function(oItem){
+				this.oAdaptationData.items.forEach(function(oItem){
 					this.addAggregation("filterItems", oItem.filterfield);
 					delete oItem.filterfield;
 				}.bind(this));
 
-				if (this._oFilterBarLayout.getInner().setP13nModel){
-					this._oFilterBarLayout.getInner().setP13nModel(this.oAdaptationModel);
-				}
+				this._oFilterBarLayout.setP13nData(this.oAdaptationData);
 				this._bFilterFieldsCreated = true;
 
 				return this;
@@ -226,7 +270,7 @@ sap.ui.define([
 	AdaptationFilterBar.prototype._checkExisting = function(oItem, oFilterDelegate) {
 		var oFilterFieldPromise;
 
-		var oAdaptationControl = this.getAdaptationControl();
+		var oAdaptationControl = this._getAdaptationControlInstance();
 		var aExistingItems = this._checkAdvancedParent(oAdaptationControl) ? oAdaptationControl.getFilterItems() : [];
 
 		var mExistingFilterItems = aExistingItems.reduce(function(mMap, oField){
@@ -238,7 +282,7 @@ sap.ui.define([
 			oFilterFieldPromise = Promise.resolve(mExistingFilterItems[oItem.name]);
 		} else  {
 
-			oFilterFieldPromise = oFilterDelegate.addItem(oItem.name, this.getAdaptationControl());
+			oFilterFieldPromise = oFilterDelegate.addItem(oItem.name, this._getAdaptationControlInstance());
 
 			oFilterFieldPromise = oFilterFieldPromise.then(function(oFilterField){
 
@@ -260,10 +304,10 @@ sap.ui.define([
 		var aOriginalsToRemove = [];
 
 		Object.keys(this._mOriginalsForClone).forEach(function(sKey){
-			var oDelegate = this.getAdaptationControl().getControlDelegate();
+			var oDelegate = this._getAdaptationControlInstance().getControlDelegate();
 
 			if (aExistingItems.indexOf(sKey) < 0) {//Originals that have not been selected --> use continue similar to 'ItemBaseFlex'
-				var oRemovePromise = oDelegate.removeItem.call(oDelegate, sKey, this.getAdaptationControl()).then(function(bContinue){
+				var oRemovePromise = oDelegate.removeItem.call(oDelegate, sKey, this._getAdaptationControlInstance()).then(function(bContinue){
 					if (bContinue && this._mOriginalsForClone[sKey]) {
 						// destroy the item
 						this._mOriginalsForClone[sKey].destroy();
@@ -292,32 +336,58 @@ sap.ui.define([
 	 * @param {boolean} bSuppressInvalidate suppress invalidation
 	 */
 	AdaptationFilterBar.prototype.setAdaptationControl = function(oControl, bSuppressInvalidate) {
-		this.setProperty("adaptationControl", oControl, bSuppressInvalidate);
 
-		this._checkAdvancedParent(oControl);
+		if (this._fnResolveAdaptationControlPromise) {
+			this._fnResolveAdaptationControlPromise();
+			this._fnResolveAdaptationControlPromise = null;
+		}
+
+		this.setAssociation("adaptationControl", oControl, bSuppressInvalidate);
+
+		//FIXME: remove once the UI has been decided
+		var bUseQueryPanel = new SAPUriParameters(window.location.search).getAll("sap-ui-xx-filterQueryPanel")[0] === "true";
+		this._cLayoutItem = bUseQueryPanel || this._checkAdvancedParent(oControl) ? FilterGroupLayout : FilterColumnLayout; //Note: once the URL parameter is removed, FilterColumnLayout can be deleted
 
-		//TODO: use 'GroupView' for inbuilt filtering enabled Controls
-		this._cLayoutItem = this._checkAdvancedParent(oControl) ? FilterGroupLayout : FilterColumnLayout;
 		this._oFilterBarLayout = this._checkAdvancedParent(oControl) ? new GroupContainer() : new TableContainer();
+
 		this._oFilterBarLayout.getInner().setParent(this);
 		this.setAggregation("layout", this._oFilterBarLayout, true);
-		this.addStyleClass("sapUIAdaptationFilterBar");
 
 		if (this._oFilterBarLayout.getInner().attachChange) {
-			this._oFilterBarLayout.getInner().attachChange(function(){
+			this._oFilterBarLayout.getInner().attachChange(function(oEvt){
+				if (oEvt.getParameter("reason") === "Remove") {
+					var oItem = oEvt.getParameter("item");
+					var mConditions = this._bPersistValues ? merge({}, this._getAdaptationControlInstance().getFilterConditions()) : this._getAdaptationControlInstance()._getXConditions();
+					mConditions[oItem.name] = [];
+					this._setXConditions(mConditions, true);
+				}
 				this.fireChange();
 			}.bind(this));
 		}
 		return this;
 	};
 
+	/**
+	 * Returns an instance of the associated adaptation control, if available.
+	 * @private
+	 * @ui5-restricted sap.ui.mdc
+	 * @returns {sap.ui.mdc.Control} The adaptation control instance.
+	 */
+	AdaptationFilterBar.prototype._getAdaptationControlInstance = function () {
+		var sAdaptationControlId = this.getAdaptationControl();
+		return sAdaptationControlId && Core.byId(sAdaptationControlId);
+	};
+
 	AdaptationFilterBar.prototype.exit = function() {
 		FilterBarBase.prototype.exit.apply(this, arguments);
 		for (var sKey in this._mOriginalsForClone) {
 			this._mOriginalsForClone[sKey].destroy();
 		}
 		this._mOriginalsForClone = null;
-		this.oAdaptationModel = null;
+		this.oAdaptationData = null;
+
+		this._fnResolveAdaptationControlPromise = null;
+		this._oAdaptationControlPromise = null;
 	};
 
 	return AdaptationFilterBar;

package/src/sap/ui/mdc/filterbar/p13n/FilterColumnLayout.js

@@ -1,3 +1,4 @@
+
 /*
  * ! OpenUI5
  * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
@@ -62,5 +63,4 @@ sap.ui.define(['sap/m/ColumnListItem', 'sap/m/ColumnListItemRenderer', 'sap/m/La
 	};
 
 	return FilterColumnLayout;
-
-});
+});

package/src/sap/ui/mdc/filterbar/p13n/GroupContainer.js

@@ -12,7 +12,7 @@ sap.ui.define([
 
 	/**
 	 * Constructor for a new filterBar/p13n/GroupContainer.
-     * Used for a complex groupable FilterBar UI, should be used in combination with <code>FilterColumnLayout</code>
+     * Used for a complex groupable FilterBar UI, should be used in combination with <code>FilterGroupLayout</code>
 	 * @param {string} [sId] ID for the new control, generated automatically if no ID is given
 	 * @class The GroupContainer is a IFilterContainer implementation for <code>sap.m.Table</code>
 	 * @extends sap.ui.mdc.filterbar.IFilterContainer
@@ -34,7 +34,7 @@ sap.ui.define([
 		this.oLayout = new AdaptFiltersPanel();
 
 		this.oLayout.setItemFactory(function(oBindingContext){
-			var sKey = this.oLayout.getModel(this.oLayout.P13N_MODEL).getProperty(oBindingContext.sPath).name;
+			var sKey = oBindingContext.getProperty(oBindingContext.sPath).name;
 			var oFilterItem = this.mFilterItems[sKey];
 			return oFilterItem;
 		}.bind(this));
@@ -62,10 +62,14 @@ sap.ui.define([
 		return aFilterItems;
 	};
 
-	GroupContainer.prototype.update = function() {
+	GroupContainer.prototype.update = function(oP13nData) {
 		this.oLayout.restoreDefaults();
 	};
 
+	GroupContainer.prototype.setP13nData = function(oAdaptationData) {
+		this.oLayout.setP13nData(oAdaptationData);
+	};
+
 	GroupContainer.prototype.exit = function() {
 		this.mFilterItems = null;
 		this.mFilterFields = null;

package/src/sap/ui/mdc/filterbar/p13n/TableContainer.js

@@ -6,13 +6,13 @@
 
 // Provides control sap.ui.mdc.filterbar.FilterItemLayout.
 sap.ui.define([
-	'sap/ui/mdc/filterbar/IFilterContainer','sap/m/Table', 'sap/m/Column', 'sap/m/Text', 'sap/m/VBox'
-], function(IFilterContainer, Table, Column, Text, VBox) {
+	'sap/ui/mdc/filterbar/IFilterContainer','sap/m/Table', 'sap/m/Column', 'sap/m/Text', 'sap/m/VBox', 'sap/ui/mdc/p13n/panels/FilterPanel', 'sap/base/util/UriParameters'
+], function(IFilterContainer, Table, Column, Text, VBox, FilterPanel, SAPUriParameters) {
 	"use strict";
 
 	/**
 	 * Constructor for a new filterBar/p13n/TableContainer.
-     * Used for a simple FilterBar table like view, should be used in combination with <code>FilterCellLayout</code>
+     * Used for a simple FilterBar table like view, should be used in combination with <code>FilterGroupLayout</code>
 	 * @param {string} [sId] ID for the new control, generated automatically if no ID is given
 	 * @class The TableContainer is a IFilterContainer implementation for <code>sap.m.Table</code>
 	 * @extends sap.ui.mdc.filterbar.IFilterContainer
@@ -44,18 +44,51 @@ sap.ui.define([
 			]
 		});
 
-		this._oMessageStripContainer = new VBox(this.getId() + "-messageStripContainer");
+		var oURLParams = new SAPUriParameters(window.location.search);
+		this._bUseQueryPanel = oURLParams.getAll("sap-ui-xx-filterQueryPanel")[0] === "true";
+
+		//FIXME: remove check once the UI has been decided
+		if (this._bUseQueryPanel) {
+			this.oLayout = new FilterPanel({
+				enableReorder: false
+			});
+
+			this.mFilterItems = {};
+
+			this.oLayout.setItemFactory(function(oItem){
+				var sKey = oItem.name;
+				var oFilterItem = this.mFilterItems[sKey];
+				return oFilterItem;
+			}.bind(this));
+		} else {
+			this._oMessageStripContainer = new VBox(this.getId() + "-messageStripContainer");
+
+			this.oLayout = new VBox({
+				items: [
+					this._oMessageStripContainer,
+					this._oTable
+				]
+			});
+		}
 
-		this.oLayout = new VBox({
-			items: [
-				this._oMessageStripContainer,
-				this._oTable
-			]
-		});
 	};
 
 	TableContainer.prototype.insertFilterField = function(oControl, iIndex) {
-		this._oTable.insertItem(oControl, iIndex);
+
+		//FIXME: remove check once the UI has been decided
+		if (this._bUseQueryPanel) {
+			this.mFilterItems[oControl._getFieldPath()] = oControl;
+		} else {
+			this._oTable.insertItem(oControl, iIndex);
+		}
+
+	};
+
+	TableContainer.prototype.setP13nData = function(oAdaptationData) {
+		//FIXME: remove check once the UI has been decided
+		if (this._bUseQueryPanel) {
+			this.oLayout.setP13nData(oAdaptationData.items);
+		}
 	};
 
 	TableContainer.prototype.removeFilterField = function(oControl) {
@@ -63,15 +96,20 @@ sap.ui.define([
 	};
 
 	TableContainer.prototype.setMessageStrip = function(oStrip) {
-		this._oMessageStripContainer.removeAllItems();
-		this._oMessageStripContainer.addItem(oStrip);
+		//FIXME: remove check once the UI has been decided
+		if (this._bUseQueryPanel) {
+			this.oLayout.setMessageStrip(oStrip);
+		} else {
+			this._oMessageStripContainer.removeAllItems();
+			this._oMessageStripContainer.addItem(oStrip);
+		}
 	};
 
 	TableContainer.prototype.getFilterFields = function() {
 		return this._oTable.getItems();
 	};
 
-	TableContainer.prototype.update = function() {
+	TableContainer.prototype.update = function(oP13nModel) {
 		//Called when the UI model is being set - trigger update logic here
 	};
 

package/src/sap/ui/mdc/filterbar/vh/FilterBar.js

@@ -33,9 +33,11 @@ sap.ui.define(
 		 * The metadata information is provided via the {@link sap.ui.mdc.FilterBarDelegate FilterBarDelegate} implementation. This implementation has to be provided by the application.
 		 * @extends sap.ui.mdc.filterbar.FilterBarBase
 		 * @author SAP SE
-		 * @version 1.99.0
+		 * @version 1.100.1
 		 * @constructor
 		 * @private
+		 * @ui5-restricted sap.fe
+		 * @MDC_PUBLIC_CANDIDATE
 		 * @since 1.84.0
 		 * @alias sap.ui.mdc.filterbar.vh.FilterBar
 		 * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
@@ -59,23 +61,8 @@ sap.ui.define(
 							type: "int",
 							defaultValue: 8
 						}
-
-						// delegate: {
-						// 	type: "object",
-						// 	group: "Data",
-						// 	defaultValue: {name: 'sap/ui/mdc/filterbar/vh/GenericFilterBarDelegate'}
-						// }
 					},
 					aggregations : {
-						/**
-						 * <code>collectiveSearch</code> control of the filterbar.
-						 *
-						 * @since 1.87.0
-						 */
-						collectiveSearch: {
-							type: "sap.ui.mdc.filterbar.vh.CollectiveSearchSelect",
-							multiple: false
-						}
 					}
 				},
 
@@ -145,11 +132,18 @@ sap.ui.define(
 			this._waitForMetadata();
 		};
 
+		FilterBar.prototype._handleConditionModelPropertyChange = function() {
+			this.fireFiltersChanged({conditionsBased: true});
+		};
+
 
 		FilterBar.prototype.exit = function() {
+			if (this._oCollectiveSearch) { // do not destroy CollectiveSearch as it is owned by value help and might be reused there
+				this._oFilterBarLayout.removeControl(this._oCollectiveSearch);
+				this._oCollectiveSearch = null;
+			}
 			FilterBarBase.prototype.exit.apply(this, arguments);
 			this._oBasicSearchField = null;
-			this._oCollectiveSearch = null;
 			this._oBtnFilters = null;
 			this._oShowAllFiltersBtn = null;
 		};
@@ -162,6 +156,15 @@ sap.ui.define(
 			this._oFilterBarLayout._updateFilterBarLayout(true);
 		};
 
+		/**
+		 * Sets the <code>CollectiveSearch</code> control
+		 *
+		 * <b>Note:</b> This must only be done by the corresponding value help, not from outside.
+		 *
+		 * @param {sap.ui.mdc.filterbar.vh.CollectiveSearchSelect} oCollectiveSearch <code>CollectiveSearch</code> control
+		 * @returns {this} Reference to <code>this</code> to allow method chaining
+		 * @protected
+		 */
 		FilterBar.prototype.setCollectiveSearch = function (oCollectiveSearch) {
 			if (this._oCollectiveSearch) {
 				if (this._oFilterBarLayout) {
@@ -176,11 +179,27 @@ sap.ui.define(
 			return this;
 		};
 
+		/**
+		 * Gets the <code>CollectiveSearch</code> control
+		 *
+		 * <b>Note:</b> This must only be used by the corresponding value help, not from outside.
+		 *
+		 * @returns {sap.ui.mdc.filterbar.vh.CollectiveSearchSelect} <code>CollectiveSearch</code> control
+		 * @protected
+		 */
 		FilterBar.prototype.getCollectiveSearch = function () {
 			return this._oCollectiveSearch;
 		};
 
-		FilterBar.prototype.destroyCollectiveSearch = function () {
+		/**
+		 * Destroyes the <code>CollectiveSearch</code> control
+		 *
+		 * <b>Note:</b> This must only be used by the corresponding value help, not from outside.
+		 *
+		 * @returns {this} Reference to <code>this</code> to allow method chaining
+		 * @protected
+		 */
+		 FilterBar.prototype.destroyCollectiveSearch = function () {
 			if (this._oCollectiveSearch && this._oFilterBarLayout) {
 				this._oFilterBarLayout.removeControl(this._oCollectiveSearch);
 				this._oCollectiveSearch.destroy();
@@ -190,7 +209,6 @@ sap.ui.define(
 			return this;
 		};
 
-
 		FilterBar.prototype.setBasicSearchField = function (oBasicSearchField) {
 			if (this._oBasicSearchField) {
 				if (this._oFilterBarLayout) {

package/src/sap/ui/mdc/filterbar/vh/FilterContainer.js

@@ -27,7 +27,7 @@ sap.ui.define(
 		 * @class The FilterContainer is a IFilterContainer implementation for <code>AlignedFlowLayout</code>
 		 * @extends sap.ui.mdc.filterbar.IFilterContainer
 		 * @constructor
-		 * @private
+		 * @protected
 		 * @since 1.84.0
 		 * @alias sap.ui.mdc.filterbar.vh.FilterContainer
 		 * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel