@openui5/sap.ui.mdc 1.98.0 → 1.101.0

package/src/sap/ui/mdc/odata/v4/vizChart/ChartDelegate.js

@@ -22,7 +22,12 @@ sap.ui.define([
     "sap/ui/base/ManagedObjectObserver",
     "sap/ui/core/ResizeHandler",
     "sap/ui/mdc/p13n/panels/ChartItemPanel",
-    "sap/m/MessageStrip"
+    "sap/m/MessageStrip",
+    "../TypeUtil",
+    "../FilterBarDelegate",
+    "sap/ui/model/Filter",
+    "sap/ui/mdc/odata/v4/ChartPropertyHelper",
+    "sap/ui/thirdparty/jquery"
 ], function (
     V4ChartDelegate,
     loadModules,
@@ -41,7 +46,12 @@ sap.ui.define([
     ManagedObjectObserver,
     ResizeHandler,
     ChartItemPanel,
-    MessageStrip
+    MessageStrip,
+    V4TypeUtil,
+    V4FilterBarDelegate,
+    Filter,
+    PropertyHelper,
+    jQuery
 ) {
     "use strict";
     /**
@@ -82,6 +92,44 @@ sap.ui.define([
         mStateMap.set(oMDCChart, oState);
     };
 
+    ChartDelegate.getTypeUtil = function() {
+        return V4TypeUtil;
+    };
+
+    ChartDelegate.getFilterDelegate = function() {
+        return V4FilterBarDelegate;
+    };
+
+	/**
+	 * This methods is called during the appliance of the add condition change.
+	 * This intention is to update the propertyInfo property.
+	 *
+	 * @param {string} sPropertyName The name of a property.
+	 * @param {sap.ui.mdc.Control} oControl - the instance of the mdc control
+	 * @param {Object} mPropertyBag Instance of property bag from Flex change API
+	 * @returns {Promise} Promise that resolves once the properyInfo property was updated
+	 */
+    ChartDelegate.addCondition = function(sPropertyName, oControl, mPropertyBag) {
+		//return this.getFilterDelegate().addCondition(sPropertyName, oControl, mPropertyBag);
+        // will be activated, once mdc.Chart has the property propertyInfo.
+        return Promise.resolve();
+    };
+
+	/**
+	 * This methods is called during the appliance of the remove condition change.
+	 * This intention is to update the propertyInfo property.
+	 *
+	 * @param {string} sPropertyName The name of a property.
+	 * @param {sap.ui.mdc.Control} oControl - the instance of the mdc control
+	 * @param {Object} mPropertyBag Instance of property bag from Flex change API
+	 * @returns {Promise} Promise that resolves once the properyInfo property was updated
+	 */
+    ChartDelegate.removeCondition = function(sPropertyName, oControl, mPropertyBag) {
+		//return this.getFilterDelegate().removeCondition(sPropertyName, oControl, mPropertyBag);
+        // will be activated, once mdc.Chart has the property propertyInfo.
+        return Promise.resolve();
+    };
+
     ChartDelegate._deleteState = function(oMDCChart) {
 
         if (this._getState(oMDCChart).vizTooltip) {
@@ -176,36 +224,6 @@ sap.ui.define([
      * ...
      */
 
-    /**
-     * Provides the table's filter delegate that provides basic filter functionality such as adding filter fields.
-     * <b>Note:</b> The functionality provided in this delegate should act as a subset of a FilterBarDelegate
-     * to enable the table for inbuilt filtering.
-     *
-     * @example <caption>Example usage of <code>getFilterDelegate</code></caption>
-     * oFilterDelegate = {
-     * 		addItem: function() {
-     * 			var oFilterFieldPromise = new Promise(...);
-     * 			return oFilterFieldPromise;
-     * 		}
-     * }
-     * @returns {Object} Object for the chart filter personalization
-     * @public
-     */
-    ChartDelegate.getFilterDelegate = function () {
-        return {
-            /**
-             *
-             * @param {String} sPropertyName The property name
-             * @param {Object} oMDCChart Instance of the chart TODO: Which one? MDC or inner?
-             *
-             * @returns {Promise} Promise that resolves with an instance of a <code>sap.ui.mdc.FilterField</code>.
-             * For more information, see {@link sap.ui.mdc.AggregationBaseDelegate#addItem AggregationBaseDelegate}.
-             */
-            addItem: function (sPropertyName, oMDCChart) {
-                return Promise.resolve(null);
-            }
-        };
-    };
 
     ChartDelegate.exit = function(oMDCChart) {
         if (this._getInnerStructure(oMDCChart)){
@@ -229,7 +247,7 @@ sap.ui.define([
 
     /**
      * Gets the current zooming information for the inner chart
-     * @returns {integer} Current zoom level on the inner chart
+     * @returns {int} Current zoom level on the inner chart
      */
     ChartDelegate.getZoomState = function (oMDCChart) {
 
@@ -312,6 +330,10 @@ sap.ui.define([
 
     ChartDelegate.getAdaptionUI = function(oMDCChart) {
 
+        return Promise.resolve(this._setupAdaptionUI(oMDCChart));
+    };
+
+    ChartDelegate._setupAdaptionUI = function(oMDCChart) {
         var oLayoutConfig = this.getChartTypeLayoutConfig().find(function(it){return it.key === oMDCChart.getChartType();});
 
         //Default case -> everything allowed
@@ -338,13 +360,14 @@ sap.ui.define([
             oPanel.setMessageStrip(new MessageStrip({text: MDCRb.getText("chart.PERSONALIZATION_DIALOG_MEASURE_WARNING"), type:"Warning"}));
         }
 
-        return Promise.resolve(oPanel);
+        return oPanel;
     };
 
     /**
      * Sets the visibility of the legend
      * This is called by the MDC Chart, do not call it directly!
-     * @param {bool} bVisible true to show legend, false to hide
+     * @param {sap.ui.mdc.Chart} oMDCChart Chart to the set the legend visibility on
+     * @param {boolean} bVisible true to show legend, false to hide
      *
      * @experimental
      * @private
@@ -386,7 +409,8 @@ sap.ui.define([
     /**
      * Inserts an MDC Chart Item (in case of sap.chart.Chart a Measure/Dimension) on the inner chart
      * This function is called by MDC Chart on a change of the <code>Items</code> aggregation
-     * @param {sap.ui.mdc.chart-Item} oMDCChartItem the MDC CHart Item to insert into the inner chart
+     * @param {sap.ui.mdc.Chart} oMDCChart the MDC Chart to insert the item into
+     * @param {sap.ui.mdc.chart.Item} oMDCChartItem the MDC Chart Item to insert into the inner chart
      * @param {int} iIndex the index to insert into
      */
     ChartDelegate.insertItemToInnerChart = function (oMDCChart, oMDCChartItem, iIndex) {
@@ -420,14 +444,14 @@ sap.ui.define([
             this._updateColoring(oMDCChart, this._getChart(oMDCChart).getVisibleDimensions(), this._getChart(oMDCChart).getVisibleMeasures());
         }.bind(this));
 
-        this.fetchProperties(oMDCChartItem.getParent()).then(function (aProperties) {
-            this._updateSemanticalPattern(oMDCChart, aProperties);
-        }.bind(this));
+        this._updateSemanticalPattern(oMDCChart);
+
     };
 
     /**
      * Removes an Item (in case of sap.chart.Chart a Measure/Dimension) from the inner chart
      * This function is called by MDC Chart on a change of the <code>Items</code> aggregation
+     * @param {sap.ui.mdc.Chart} oMDCChart the MDC Chart to remove the item from
      * @param {sap.ui.mdc.chart.Item} oMDCChartItem The Item to remove from the inner chart
      */
     ChartDelegate.removeItemFromInnerChart = function (oMDCChart, oMDCChartItem) {
@@ -457,9 +481,8 @@ sap.ui.define([
 
         //Update coloring and semantical patterns on Item change
         this._updateColoring(oMDCChart, this._getChart(oMDCChart).getVisibleDimensions(), this._getChart(oMDCChart).getVisibleMeasures());
-        this.fetchProperties(oMDCChartItem.getParent()).then(function (aProperties) {
-            this._updateSemanticalPattern(oMDCChart, aProperties);
-        }.bind(this));
+
+        this._updateSemanticalPattern(oMDCChart);
     };
 
     /**
@@ -474,29 +497,64 @@ sap.ui.define([
         if (oMDCChart.getModel) {
             return Promise.resolve(this._createMDCChartItem(sPropertyName, oMDCChart, sRole));
         }
-        return Promise.resolve(null);
     };
 
     ChartDelegate.removeItem = function (oProperty, oMDCChart) {
         return Promise.resolve(true);
     };
 
-    ChartDelegate._createMDCChartItem = function (sPropertyName, oMDCChart, sRole) {
-        return this.fetchProperties(oMDCChart).then(function (aProperties) {
+    /**
+     * This will iterate over all items of the MDC Chart to make sure all necessary information is available on them
+     * If something is missing, this method will update the item accordingly
+     * @param {sap.ui.mdc.Chart} oMDCChart the MDC Chart to check the items on
+     * @returns {Promise} resolves once check is complete
+     */
+    ChartDelegate.checkAndUpdateMDCItems = function(oMDCChart) {
+        return new Promise(function(resolve, reject){
+            var aPropPromises = [];
+
+            oMDCChart.getItems().forEach(function(oMDCItem){
+                var bIsComplete = oMDCItem.getName() && oMDCItem.getLabel() && oMDCItem.getType() && oMDCItem.getRole();
+
+                if (!bIsComplete) {
+                    aPropPromises.push(this._getPropertyInfosByName(oMDCItem.getName(), oMDCChart).then(function(oPropertyInfo){
+                        oMDCItem.setLabel(oPropertyInfo.label);
+
+                        if (oPropertyInfo.groupable) {
+                            oMDCItem.setType("groupable");
+                            oMDCItem.setRole(oMDCItem.getRole() ? oMDCItem.getRole() : "category");
+                        } else if (oPropertyInfo.aggregatable) {
+                            oMDCItem.setType("aggregatable");
+                            oMDCItem.setRole(oMDCItem.getRole() ? oMDCItem.getRole() : "axis1");
+                        }
+                    }));
+                }
+            }.bind(this));
 
-            //Uses excact MDC Chart Item id
-            var oPropertyInfo = aProperties.find(function (oCurrentPropertyInfo) {
-                return oCurrentPropertyInfo.name === sPropertyName;
+            Promise.all(aPropPromises).then(function(){
+                resolve();
             });
+        }.bind(this));
 
+    };
+
+    ChartDelegate._createMDCChartItem = function (sPropertyName, oMDCChart, sRole) {
+
+        return this._getPropertyInfosByName(sPropertyName, oMDCChart).then(function(oPropertyInfo){
             if (!oPropertyInfo) {
                 return null;
             }
 
+            return this._createMDCItemFromProperty(oPropertyInfo, oMDCChart.getId(), sRole);
+
+        }.bind(this));
+
+    };
+
+    ChartDelegate._createMDCItemFromProperty = function(oPropertyInfo, idPrefix, sRole) {
 
-            //TODO: Check for case: both aggegatable and groupable
             if (oPropertyInfo.groupable) {
-                return new MDCChartItem(oMDCChart.getId() + "--GroupableItem--" + oPropertyInfo.name, {
+                return new MDCChartItem(idPrefix + "--GroupableItem--" + oPropertyInfo.name, {
                     name: oPropertyInfo.name,
                     label: oPropertyInfo.label,
                     type: "groupable",
@@ -506,14 +564,15 @@ sap.ui.define([
 
             if (oPropertyInfo.aggregatable) {
 
-                return new MDCChartItem(oMDCChart.getId() + "--AggregatableItem--" + oPropertyInfo.name, {
+                return new MDCChartItem(idPrefix + "--AggregatableItem--" + oPropertyInfo.name, {
                     name: oPropertyInfo.name,
                     label: oPropertyInfo.label,
                     type: "aggregatable",
                     role: sRole ? sRole : "axis1"
                 });
             }
-        });
+
+            return null;
     };
 
     /**
@@ -558,114 +617,121 @@ sap.ui.define([
     };
 
     ChartDelegate._createContentFromItems = function (oMDCChart) {
-        //This is done so the user doesn't have to specify property path & aggregation method in the XML
-        this.fetchProperties(oMDCChart).then(function (aProperties) {
+        return new Promise(function(resolve, reject){
+            //This is done so the user doesn't have to specify property path & aggregation method in the XML
             var aColorPromises = [];
+            var aPropPromises = [];
 
             var aVisibleDimensions = [];
             var aVisibleMeasures = [];
             oMDCChart.getItems().forEach(function (oItem, iIndex) {
 
                 //Uses excact mdc chart item id
-                var oPropertyInfo = aProperties.find(function (oCurrentPropertyInfo) {
-                    return oCurrentPropertyInfo.name === oItem.getName();
-                });
+                aPropPromises.push(this._getPropertyInfosByName( oItem.getName(), oMDCChart).then(function(oPropertyInfo){
+                    //Skip a Item if there is no property representing the Item inside the backend
+                    if (!oPropertyInfo){
+                        Log.error("sap.ui.mdc.Chart: Item " + oItem.getName() + " has no property info representing it in the metadata. Make sure the name is correct and the metadata is defined correctly. Skipping the item!");
+                        return;
+                    }
 
-                //Skip a Item if there is no property representing the Item inside the backend
-                if (!oPropertyInfo){
-                    Log.error("sap.ui.mdc.Chart: Item " + oItem.getName() + " has no property info representing it in the metadata. Make sure the name is correct and the metadata is defined correctly. Skipping the item!");
-                    return;
-                }
+                    switch (oItem.getType()) {
+                        case "groupable":
+                            aVisibleDimensions.push(this.getInternalChartNameFromPropertyNameAndKind(oItem.getName(), "groupable", oMDCChart));
 
-                switch (oItem.getType()) {
-                    case "groupable":
-                        aVisibleDimensions.push(this.getInternalChartNameFromPropertyNameAndKind(oItem.getName(), "groupable", oMDCChart));
+                            this._addInnerDimension(oMDCChart, oItem, oPropertyInfo);
+                            break;
+                        case "aggregatable":
 
-                        this._addInnerDimension(oMDCChart, oItem, oPropertyInfo);
-                        break;
-                    case "aggregatable":
+                            //TODO: Alias might be changing after backend request
+                            aVisibleMeasures.push(this._getAggregatedMeasureNameForMDCItem(oItem));
 
-                        //TODO: Alias might be changing after backend request
-                        aVisibleMeasures.push(this._getAggregatedMeasureNameForMDCItem(oItem));
+                            this._addInnerMeasure(oMDCChart, oItem, oPropertyInfo);
+                            break;
 
-                        this._addInnerMeasure(oMDCChart, oItem, oPropertyInfo);
-                        break;
+                        default:
+                            Log.error("MDC Chart Item " + oItem.getId() + " with label " + oItem.getLabel() + " has no known type. Supported typed are: \"groupable\" & \"aggregatable\"");
+                    }
 
-                    default:
-                        Log.error("MDC Chart Item " + oItem.getId() + " with label " + oItem.getLabel() + " has no known type. Supported typed are: \"groupable\" & \"aggregatable\"");
-                }
+                    aColorPromises.push(this._prepareColoringForItem(oItem));
+                }.bind(this)));
 
-                aColorPromises.push(this._prepareColoringForItem(oItem));
             }.bind(this));
 
-            this._getState(oMDCChart).aColMeasures.forEach(function(sKey) {
+            Promise.all(aPropPromises).then(function(){
+                this._getState(oMDCChart).aColMeasures.forEach(function(sKey) {
 
-                if (this._getState(oMDCChart).aInSettings.indexOf(sKey) == -1) {
+                    if (this._getState(oMDCChart).aInSettings.indexOf(sKey) == -1) {
 
-                    var oPropertyInfo = oMDCChart.getPropertyHelper().getProperty(sKey); //this.getPropertyFromNameAndKind not used as the key is the name of the MDC Chart Item
+                        aColorPromises.push(new Promise(function(resolve, reject){
+                            oMDCChart._getPropertyByNameAsync(sKey).then(function(oPropertyInfo){
+                                var aggregationMethod = oPropertyInfo.aggregationMethod;
+                                var propertyPath = oPropertyInfo.propertyPath;
+                                var sName = this.getInternalChartNameFromPropertyNameAndKind(sKey, "aggregatable", oMDCChart);
 
-                    var aggregationMethod = oPropertyInfo.aggregationMethod;
-                    var propertyPath = oPropertyInfo.propertyPath;
-                    var sName = this.getInternalChartNameFromPropertyNameAndKind(sKey, "aggregatable", oMDCChart);
+                                var oMeasureSettings = {
+                                    name: sName,
+                                    label: oPropertyInfo.label,
+                                    role: "axis1"
+                                };
 
-                    var oMeasureSettings = {
-                        name: sName,
-                        label: oPropertyInfo.label,
-                        role: "axis1"
-                    };
+                                if (aggregationMethod && propertyPath) {
+                                    oMeasureSettings.analyticalInfo = {
+                                        propertyPath: propertyPath,
+                                        "with": aggregationMethod
+                                    };
+                                }
 
-                    if (aggregationMethod && propertyPath) {
-                        oMeasureSettings.analyticalInfo = {
-                            propertyPath: propertyPath,
-                            "with": aggregationMethod
-                        };
-                    }
+                                var oMeasure = new Measure(oMeasureSettings);
 
-                    var oMeasure = new Measure(oMeasureSettings);
+                                aVisibleMeasures.push(oMeasure);
+                                this._getChart(oMDCChart).addMeasure(oMeasure);
+                                resolve();
+                            }); //this.getPropertyFromNameAndKind not used as the key is the name of the MDC Chart Item
 
-                    aVisibleMeasures.push(oMeasure);
-                    this._getChart(oMDCChart).addMeasure(oMeasure);
-                }
+                        }));
+                    }
 
-            }.bind(this));
+                }.bind(this));
 
-            Promise.all(aColorPromises).then(function(){
-                this._getChart(oMDCChart).setVisibleDimensions(aVisibleDimensions);
-                this._getChart(oMDCChart).setVisibleMeasures(aVisibleMeasures);
+                Promise.all(aColorPromises).then(function(){
+                    this._getChart(oMDCChart).setVisibleDimensions(aVisibleDimensions);
+                    this._getChart(oMDCChart).setVisibleMeasures(aVisibleMeasures);
 
-                var aInResultDimensions = oMDCChart.getDelegate().inResultDimensions; //TODO: Does this use internal name? If so, change _getPropertyInfosByName  below; Most likely not the case
-                if (aInResultDimensions && aInResultDimensions instanceof Array && aInResultDimensions.length != 0) {
+                    var aInResultDimensions = oMDCChart.getDelegate().inResultDimensions; //TODO: Does this use internal name? If so, change _getPropertyInfosByName  below; Most likely not the case
+                    if (aInResultDimensions && aInResultDimensions instanceof Array && aInResultDimensions.length != 0) {
 
-                    var aInResultPromises = [];
+                        var aInResultPromises = [];
 
-                    aInResultDimensions.forEach(function(sInResultDim){
+                        aInResultDimensions.forEach(function(sInResultDim){
 
-                        aInResultPromises.push(this._getPropertyInfosByName(sInResultDim, oMDCChart).then(function(oPropertyInfos){
-                            var sName = this.getInternalChartNameFromPropertyNameAndKind(oPropertyInfos.name, "groupable", oMDCChart);
+                            aInResultPromises.push(this._getPropertyInfosByName(sInResultDim, oMDCChart).then(function(oPropertyInfos){
+                                var sName = this.getInternalChartNameFromPropertyNameAndKind(oPropertyInfos.name, "groupable", oMDCChart);
 
-                            var oDim = new Dimension({
-                                name: sName,
-                                label: oPropertyInfos.label
-                            });
+                                var oDim = new Dimension({
+                                    name: sName,
+                                    label: oPropertyInfos.label
+                                });
 
-                            this._getState(oMDCChart).inResultDimensions.push(sName);
-                            this._getChart(oMDCChart).addDimension(oDim);
-                        }.bind(this)));
+                                this._getState(oMDCChart).inResultDimensions.push(sName);
+                                this._getChart(oMDCChart).addDimension(oDim);
+                            }.bind(this)));
 
-                    }.bind(this));
+                        }.bind(this));
 
-                    Promise.all(aInResultPromises).then(function(){
-                        this._getChart(oMDCChart).setInResultDimensions(this._getState(oMDCChart).inResultDimensions);
-                    }.bind(this));
+                        Promise.all(aInResultPromises).then(function(){
+                            this._getChart(oMDCChart).setInResultDimensions(this._getState(oMDCChart).inResultDimensions);
+                        }.bind(this));
 
-                }
+                    }
+
+                    this._updateColoring(oMDCChart, aVisibleDimensions, aVisibleMeasures);
+                    this._updateSemanticalPattern(oMDCChart);
 
-                this._updateColoring(oMDCChart, aVisibleDimensions, aVisibleMeasures);
-                this._updateSemanticalPattern(oMDCChart, aProperties);
+                    resolve();
+                }.bind(this));
             }.bind(this));
 
         }.bind(this));
-
     };
 
     ChartDelegate.getInnerChart = function (oMDCChart) {
@@ -768,7 +834,7 @@ sap.ui.define([
 
     /**
      * Updates the coloring on the inner chart
-     * @param {sap.chart.Chart} oChart inner chart
+     * @param {sap.chart.Chart} oMDCChart inner chart
      * @param {array} aVisibleDimensions visible dimensions for inner chart
      * @param {array} aVisibleMeasures visible measures for inner chart
      *
@@ -826,15 +892,14 @@ sap.ui.define([
     /**
      * Updates the semantical pattern for given measures
      *
-     * @param {sap.chart.Chart} oChart the inner chart
-     * @param {array} aVisibleMeasures array containing the visible measures on the inner chart
-     * @param {*} mDataPoints data points of the inner chart
+     * @param {sap.chart.Chart} oMDCChart the inner chart
+     * @param {*} aProperties // TODO what is this parameter used for?
      *
      * @experimental
      * @private
      * @ui5-restricted Fiori Elements, sap.ui.mdc
      */
-    ChartDelegate._updateSemanticalPattern = function (oMDCChart, aProperties) {
+    ChartDelegate._updateSemanticalPattern = function (oMDCChart) {
 
         var aVisibleMeasures = this._getChart(oMDCChart).getVisibleMeasures();
 
@@ -985,23 +1050,31 @@ sap.ui.define([
      */
     ChartDelegate.getSortedDimensions = function (oMDCChart) {
         return new Promise(function (resolve, reject) {
-            this.fetchProperties(oMDCChart).then(function (aProperties) {
 
-                var aDimensions = aProperties.filter(function (oItem) {
-                    return oItem.groupable; //Groupable means "Dimension" for sap.chart.Chart
-                });
+            if (oMDCChart.isPropertyHelperFinal()){
+                resolve(this._sortPropertyDimensions(oMDCChart.getPropertyHelper().getProperties()));
+            } else {
+                oMDCChart.finalizePropertyHelper().then(function(){
+                    resolve(this._sortPropertyDimensions(oMDCChart.getPropertyHelper().getProperties()));
+                }.bind(this));
+            }
+        }.bind(this));
+    };
 
-                if (aDimensions) {
-                    aDimensions.sort(function (a, b) {
-                        if (a.label && b.label) {
-                            return a.label.localeCompare(b.label);
-                        }
-                    });
-                }
+    ChartDelegate._sortPropertyDimensions = function(aProperties) {
+        var aDimensions = aProperties.filter(function (oItem) {
+            return oItem.groupable; //Groupable means "Dimension" for sap.chart.Chart
+        });
 
-                resolve(aDimensions);
+        if (aDimensions) {
+            aDimensions.sort(function (a, b) {
+                if (a.label && b.label) {
+                    return a.label.localeCompare(b.label);
+                }
             });
-        }.bind(this));
+        }
+
+        return aDimensions;
     };
 
     /**
@@ -1022,6 +1095,7 @@ sap.ui.define([
     /**
      * Sets the chart type of the inner chart
      * Is called by MDC Chart when <code>chartType</code> property is updated
+     * @param {sap.ui.mdc.Chart} oMDCChart the MDC Chart to set the chart type for
      * @param {string} sChartType the new chart type
      */
     ChartDelegate.setChartType = function (oMDCChart, sChartType) {
@@ -1033,53 +1107,64 @@ sap.ui.define([
      */
     ChartDelegate.createInnerChartContent = function (oMDCChart, fnCallbackDataLoaded) {
 
-        this._setChart(oMDCChart, new Chart({
-            id: oMDCChart.getId() + "--innerChart",
-            chartType: "column",
-            width: "100%",
-            isAnalytical: true//,
-        }));
+        return new Promise(function(resolve,reject){
+            this._setChart(oMDCChart, new Chart({
+                id: oMDCChart.getId() + "--innerChart",
+                chartType: "column",
+                width: "100%",
+                isAnalytical: true//,
+            }));
 
-        //Initialize empty; will get filled later on
-        this._getState(oMDCChart).inResultDimensions = [];
+            this._getChart(oMDCChart).setCustomMessages({
+			    'NO_DATA': oMDCChart.getNoDataText()
+		    });
 
-        if (oMDCChart.getHeight()){
-            this._getChart(oMDCChart).setHeight(this._calculateInnerChartHeight(oMDCChart));
-        }
+            //Initialize empty; will get filled later on
+            this._getState(oMDCChart).inResultDimensions = [];
 
-        //Set height correctly again if chart changes
-        ResizeHandler.register(oMDCChart, function(){
-            this.adjustChartHeight(oMDCChart);
-        }.bind(this));
-
-        var oState = this._getState(oMDCChart);
-        oState.aColMeasures = [];
-        oState.aInSettings = [];
-        this._setState(oMDCChart, oState);
-
-        //Create initial content during pre-processing
-        this._createContentFromItems(oMDCChart);
-
-        //Since zoom information is not yet available for sap.chart.Chart after data load is complete, do it on renderComplete instead
-        //This is a workaround which is hopefully not needed in other chart libraries
-        this._getChart(oMDCChart).attachRenderComplete(function () {
-            if (this._getState(oMDCChart).toolbarUpdateRequested){
-                oMDCChart._updateToolbar();
-                this._getState(oMDCChart).toolbarUpdateRequested = false;
+            if (oMDCChart.getHeight()){
+                this._getChart(oMDCChart).setHeight(this._calculateInnerChartHeight(oMDCChart));
             }
-        }.bind(this));
 
-        this._getInnerStructure(oMDCChart).removeAllItems();
-        this._getInnerStructure(oMDCChart).setJustifyContent(FlexJustifyContent.Start);
-        this._getInnerStructure(oMDCChart).setAlignItems(FlexAlignItems.Stretch);
-        this._getInnerStructure(oMDCChart).addItem(this._getChart(oMDCChart));
+            //Set height correctly again if chart changes
+            ResizeHandler.register(oMDCChart, function(){
+                this.adjustChartHeight(oMDCChart);
+            }.bind(this));
+
+            var oState = this._getState(oMDCChart);
+            oState.aColMeasures = [];
+            oState.aInSettings = [];
+            this._setState(oMDCChart, oState);
+
+            //Create initial content during pre-processing
+            this._createContentFromItems(oMDCChart).then(function(){
+                //Since zoom information is not yet available for sap.chart.Chart after data load is complete, do it on renderComplete instead
+                //This is a workaround which is hopefully not needed in other chart libraries
+                this._getChart(oMDCChart).attachRenderComplete(function () {
+                    if (this._getState(oMDCChart).toolbarUpdateRequested){
+                        oMDCChart._updateToolbar();
+                        this._getState(oMDCChart).toolbarUpdateRequested = false;
+                    }
+                }.bind(this));
+
+                this._getInnerStructure(oMDCChart).removeAllItems();
+                this._getInnerStructure(oMDCChart).setJustifyContent(FlexJustifyContent.Start);
+                this._getInnerStructure(oMDCChart).setAlignItems(FlexAlignItems.Stretch);
+                this._getInnerStructure(oMDCChart).addItem(this._getChart(oMDCChart));
+
+                oState.dataLoadedCallback = fnCallbackDataLoaded;
+
+                this._setState(oMDCChart, oState);
+                var oBindingInfo = this._getBindingInfo(oMDCChart);
+                this.updateBindingInfo(oMDCChart, oBindingInfo); //Applies filters
+                this.rebind(oMDCChart, oBindingInfo);
+
+                resolve();
+            }.bind(this));
+
 
-        oState.dataLoadedCallback = fnCallbackDataLoaded;
+        }.bind(this));
 
-        this._setState(oMDCChart, oState);
-        var oBindingInfo = this._getBindingInfo(oMDCChart);
-        this.updateBindingInfo(oMDCChart, oBindingInfo); //Applies filters
-        this.rebind(oMDCChart, oBindingInfo);
     };
 
     ChartDelegate._calculateInnerChartHeight = function(oMDCChart) {
@@ -1126,32 +1211,18 @@ sap.ui.define([
         //TODO: Check for Hierachy and Time
         //TODO: Check for role annotation
 
-        this.fetchProperties(oMDCChartItem.getParent()).then(function (aProperties) {
-
-            //Uses MDC Chart Item ID to identify preoperty, not internal chart id
-            var oPropertyInfo = aProperties.find(function (oCurrentPropertyInfo) {
-                return oCurrentPropertyInfo.name === oMDCChartItem.getName();
-            });
-
-            this._addInnerDimension(oMDCChart, oMDCChartItem, oPropertyInfo);
-
+        this._getPropertyInfosByName(oMDCChartItem.getName(), oMDCChart).then(function(oPropInfo){
+            this._addInnerDimension(oMDCChart, oMDCChartItem, oPropInfo);
         }.bind(this));
 
+
     };
 
     ChartDelegate.createInnerMeasure = function (oMDCChart, oMDCChartItem) {
 
-        this.fetchProperties(oMDCChartItem.getParent()).then(function (aProperties) {
-
-            //Uses MDC Chart Item ID to identify preoperty, not internal chart id
-            var oPropertyInfo = aProperties.find(function (oCurrentPropertyInfo) {
-                return oCurrentPropertyInfo.name === oMDCChartItem.getName();
-            });
-
-            this._addInnerMeasure(oMDCChart, oMDCChartItem, oPropertyInfo);
-
+        this._getPropertyInfosByName(oMDCChartItem.getName(), oMDCChart).then(function(oPropInfo){
+            this._addInnerMeasure(oMDCChart, oMDCChartItem, oPropInfo);
         }.bind(this));
-
     };
 
     /**
@@ -1167,7 +1238,7 @@ sap.ui.define([
         if (oPropertyInfo.textProperty){
             oDimension.setTextProperty(oPropertyInfo.textProperty);
             if (oPropertyInfo.textFormatter){
-                oDimension.setTextFormatter(oPropertyInfo.textFormatter);
+                oDimension.setTextFormatter(this._formatText.bind(oPropertyInfo));
             }
             oDimension.setDisplayText(true);
         }
@@ -1257,7 +1328,7 @@ sap.ui.define([
 
     /**
      * Returns whether the inner chart is currently bound
-     * @returns {bool} true if inner chart is bound; false if not
+     * @returns {boolean} true if inner chart is bound; false if not
      */
     ChartDelegate.getInnerChartBound = function (oMDCChart) {
         var oState = this._getState(oMDCChart);
@@ -1276,47 +1347,114 @@ sap.ui.define([
      * @param {Object} oBindingInfo The binding info of the chart
      */
     ChartDelegate.updateBindingInfo = function (oMDCChart, oBindingInfo) {
-        var oFilter = Core.byId(oMDCChart.getFilter());
-        if (oFilter) {
-            var mConditions = oFilter.getConditions();
+        var aFilters = createInnerFilters.call(this, oMDCChart).concat(createOuterFilters.call(this, oMDCChart));
+        addSearchParameter(oMDCChart, oBindingInfo);
+		oBindingInfo.filters = new Filter(aFilters, true);
+        oBindingInfo.sorter = this.getSorters(oMDCChart);
 
-            if (mConditions) {
+    };
 
-                if (!oBindingInfo) {
-                    oBindingInfo = {};
-                }
+    function createInnerFilters(oChart) {
+		var bFilterEnabled = oChart.getP13nMode().indexOf("Filter") > -1;
+		var aFilters = [];
 
-                var aPropertiesMetadata = oFilter.getPropertyInfoSet ? oFilter.getPropertyInfoSet() : null;
-                var aParameterNames = DelegateUtil.getParameterNames(oFilter);
-                var oFilterInfo = FilterUtil.getFilterInfo(ChartDelegate.getTypeUtil(), mConditions, aPropertiesMetadata, aParameterNames);
-                if (oFilterInfo) {
-                    oBindingInfo.filters = oFilterInfo.filters;
-                }
+		if (bFilterEnabled) {
+			var aChartProperties = oChart.getPropertyHelper().getProperties();
+			var oInnerFilterInfo = FilterUtil.getFilterInfo(this.getTypeUtil(), oChart.getConditions(), aChartProperties);
 
-                var sParameterPath = DelegateUtil.getParametersInfo(oFilter);
-                if (sParameterPath) {
-                    oBindingInfo.path = sParameterPath;
-                }
-            }
+			if (oInnerFilterInfo.filters) {
+				aFilters.push(oInnerFilterInfo.filters);
+			}
+		}
 
-            // get the basic search
-            var sSearchText = oFilter.getSearch instanceof Function ? oFilter.getSearch() :  "";
-            if (sSearchText) {
+		return aFilters;
+	}
 
-                if (!oBindingInfo) {
-                    oBindingInfo = {};
-                }
+	function createOuterFilters(oChart) {
+		var oFilter = Core.byId(oChart.getFilter());
+		var aFilters = [];
 
-                if (!oBindingInfo.parameters) {
-                    oBindingInfo.parameters = {};
-                }
-                // add basic search parameter as expected by v4.ODataListBinding
-                oBindingInfo.parameters.$search = sSearchText;
-            } else if (oBindingInfo.parameters && oBindingInfo.parameters.$search) {
-                delete oBindingInfo.parameters.$search;
-            }
+		if (!oFilter) {
+			return aFilters;
+		}
+
+		var mConditions = oFilter.getConditions();
+
+		if (mConditions) {
+			var aPropertiesMetadata = oFilter.getPropertyInfoSet ? oFilter.getPropertyInfoSet() : null;
+			var aParameterNames = DelegateUtil.getParameterNames(oFilter);
+			var oOuterFilterInfo = FilterUtil.getFilterInfo(this.getTypeUtil(), mConditions, aPropertiesMetadata, aParameterNames);
+
+			if (oOuterFilterInfo.filters) {
+				aFilters.push(oOuterFilterInfo.filters);
+			}
+		}
 
+		return aFilters;
+	}
+
+	function addSearchParameter(oChart, oBindingInfo) {
+		var oFilter = Core.byId(oChart.getFilter());
+		if (!oFilter) {
+			return;
+		}
+
+		var mConditions = oFilter.getConditions();
+		// get the basic search
+		var sSearchText = oFilter.getSearch instanceof Function ? oFilter.getSearch() :  "";
+
+		if (mConditions) {
+			var sParameterPath = DelegateUtil.getParametersInfo(oFilter, mConditions);
+			if (sParameterPath) {
+				oBindingInfo.path = sParameterPath;
+			}
+		}
+
+        if (!oBindingInfo.parameters) {
+            oBindingInfo.parameters = {};
         }
+
+		oBindingInfo.parameters["$search"] = sSearchText || undefined;
+	}
+
+    /**
+     * Returns sorters available for the data
+     *
+     * @returns {array} Array containing available sorters
+     *
+     * @experimental
+     * @private
+     * @ui5-restricted sap.ui.mdc
+    */
+    ChartDelegate.getSorters = function (oMDCChart) {
+        var aSorters;
+        var aSorterProperties = oMDCChart.getSortConditions() ? oMDCChart.getSortConditions().sorters : [];
+
+        aSorterProperties.forEach(function (oSortProp) {
+
+            var oMDCItem = oMDCChart.getItems().find(function (oProp) {
+                return oProp.getName() === oSortProp.name;
+            });
+
+            //Ignore not visible Items
+            if (!oMDCItem) {
+                return;
+            }
+
+            //TODO: Check for inResultDimensions
+            var oSorter = this.getSorterForItem(oMDCItem, oSortProp);
+
+            if (aSorters) {
+                aSorters.push(oSorter);
+            } else {
+                aSorters = [
+                    oSorter
+                ];//[] has special meaning in sorting
+            }
+        }.bind(this));
+
+        return aSorters;
+
     };
 
     ChartDelegate._getAggregatedMeasureNameForMDCItem = function(oMDCItem){
@@ -1348,41 +1486,6 @@ sap.ui.define([
         return oMDCChart.getPropertyHelper().getProperty(sName);
     };
 
-    /**
-     * This returns the layout options for a specific type of Item (measure/dimension,groupable/aggregatable)
-     * It is used by p13n to determine which layout options to show in the p13n panel
-     * @param {string} sType the type for which the layout options are requested
-     */
-    ChartDelegate._getLayoutOptionsForType = function(sType){
-        var MDCRb = sap.ui.getCore().getLibraryResourceBundle("sap.ui.mdc");
-		var oAvailableRoles = {
-		    groupable: [
-				{
-					key: MDCLib.ChartItemRoleType.category,
-					text: MDCRb.getText('chart.PERSONALIZATION_DIALOG_CHARTROLE_CATEGORY')
-				}, {
-					key: MDCLib.ChartItemRoleType.category2,
-					text: MDCRb.getText('chart.PERSONALIZATION_DIALOG_CHARTROLE_CATEGORY2')
-				}, {
-					key: MDCLib.ChartItemRoleType.series,
-					text: MDCRb.getText('chart.PERSONALIZATION_DIALOG_CHARTROLE_SERIES')
-				}
-			],
-			aggregatable: [
-				{
-					key: MDCLib.ChartItemRoleType.axis1,
-					text: MDCRb.getText('chart.PERSONALIZATION_DIALOG_CHARTROLE_AXIS1')
-				}, {
-					key: MDCLib.ChartItemRoleType.axis2,
-					text: MDCRb.getText('chart.PERSONALIZATION_DIALOG_CHARTROLE_AXIS2')
-				}, {
-					key: MDCLib.ChartItemRoleType.axis3,
-					text: MDCRb.getText('chart.PERSONALIZATION_DIALOG_CHARTROLE_AXIS3')
-				}
-			]
-		};
-		return oAvailableRoles[sType];
-    };
 
     /**
      * Adds an item to the inner chart (measure/dimension)
@@ -1408,7 +1511,8 @@ sap.ui.define([
 
     /**
      * Sets tooltips visible/invisible on inner chart
-     * @param {bool}  bFlag true for visible, false for invisible
+     * @param {sap.ui.mdc.Chart} oMDCChart the MDC Chart
+     * @param {boolean}  bFlag true for visible, false for invisible
      */
     ChartDelegate.setChartTooltipVisibility = function (oMDCChart, bFlag) {
 
@@ -1459,44 +1563,35 @@ sap.ui.define([
     };
 
     /**
-     * Initializes a new table property helper for V4 analytics with the property extensions merged into the property infos.
-     *
-     * @param {sap.ui.mdc.Chart} oMDCChart reference to the MDC Chart
-     * @returns {Promise<sap.ui.mdc.table.V4AnalyticsPropertyHelper>} A promise that resolves with the property helper.
-     * @private
-     * @ui5-restricted sap.ui.mdc
+     * Returns the propertyHelper used for the chart delegate
+     * @returns {Promise} Promise with the property helper reference
      */
-    ChartDelegate.initPropertyHelper = function (oMDCChart) {
-        // TODO: Do this in the DelegateMixin, or provide a function in the base delegate to merge properties and extensions
-        return Promise.all([
-            this.fetchProperties(oMDCChart),
-            loadModules("sap/ui/mdc/odata/v4/ChartPropertyHelper")
-        ]).then(function (aResult) {
-            return Promise.all(aResult.concat(this.fetchPropertyExtensions(oMDCChart, aResult[0])));
-        }.bind(this)).then(function (aResult) {
-            var aProperties = aResult[0];
-            var PropertyHelper = aResult[1][0];
-            var mExtensions = aResult[2];
-            var iMatchingExtensions = 0;
-            var aPropertiesWithExtension = [];
-
-            for (var i = 0; i < aProperties.length; i++) {
-                aPropertiesWithExtension.push(Object.assign({}, aProperties[i], {
-                    extension: mExtensions[aProperties[i].name] || {}
-                }));
-
-                if (aProperties[i].name in mExtensions) {
-                    iMatchingExtensions++;
-                }
-            }
+    ChartDelegate.getPropertyHelperClass = function () {
+        return PropertyHelper;
+    };
 
-            if (iMatchingExtensions !== Object.keys(mExtensions).length) {
-                throw new Error("At least one property extension does not point to an existing property");
-            }
+    /**
+     * This allows formatting for axis labels of the inner sap.chart.Chart.
+     * Note: As the inner chart has no association to the propertyInfo, "this" will be bound to the propertyInfo object when calling this method
+     * @param {string} sKey the key of the dimension
+     * @param {string} SDesc the description provided by the metadata
+     * @returns {string} the label which should be shown on the chart axis
+     */
+    ChartDelegate._formatText = function(sKey, SDesc) {
+        return sKey;
+    };
 
-            return new PropertyHelper(aPropertiesWithExtension, oMDCChart);
+    /**
+     * Defines a <code>noDataText</code>text for the inner chart.
+     * @param {sap.ui.mdc.Chart} oMDCChart Reference to chart
+     * @param {string} sText Text to show if no data is displayed in the chart
+     */
+    ChartDelegate.setNoDataText = function(oMDCChart, sText) {
+        this._getChart(oMDCChart).setCustomMessages({
+            'NO_DATA': sText
         });
     };
+
     /**
      * Returns the relevant propery infos based on the metadata used with the MDC Chart instance.
      *
@@ -1504,6 +1599,7 @@ sap.ui.define([
      * @returns {array} Array of the property infos to be used within MDC Chart
      */
     ChartDelegate.fetchProperties = function (oMDCChart) {
+
         var oModel = this._getModel(oMDCChart);
         var pCreatePropertyInfos;
 
@@ -1513,10 +1609,10 @@ sap.ui.define([
                     resolver: resolve
                 }, onModelContextChange, this);
             }.bind(this)).then(function (oModel) {
-                return this._createPropertyInfos(oMDCChart, oModel);
+                return this._createPropertyInfos(oMDCChart.getDelegate().payload, oModel);
             }.bind(this));
         } else {
-            pCreatePropertyInfos = this._createPropertyInfos(oMDCChart, oModel);
+            pCreatePropertyInfos = this._createPropertyInfos(oMDCChart.getDelegate().payload, oModel);
         }
 
         return pCreatePropertyInfos.then(function (aProperties) {
@@ -1537,10 +1633,10 @@ sap.ui.define([
         }
     }
 
-    ChartDelegate._createPropertyInfos = function (oMDCChart, oModel) {
-        var oMetadataInfo = oMDCChart.getDelegate().payload;
+    ChartDelegate._createPropertyInfos = function (oDelegatePayload, oModel) {
+        //var oMetadataInfo = oMDCChart.getDelegate().payload;
         var aProperties = [];
-        var sEntitySetPath = "/" + oMetadataInfo.collectionName;
+        var sEntitySetPath = "/" + oDelegatePayload.collectionName;
         var oMetaModel = oModel.getMetaModel();
 
         return Promise.all([
@@ -1574,7 +1670,7 @@ sap.ui.define([
                     }
 
                     if (oPropertyAnnotations["@Org.OData.Aggregation.V1.Aggregatable"]){
-                        aProperties = aProperties.concat(this._createPropertyInfosForAggregatable(sKey, oPropertyAnnotations, oFilterRestrictionsInfo, oSortRestrictionsInfo));
+                        aProperties = aProperties.concat(this._createPropertyInfosForAggregatable(sKey, oPropertyAnnotations, oObj, oFilterRestrictionsInfo, oSortRestrictionsInfo));
                     }
 
                     if (oPropertyAnnotations["@Org.OData.Aggregation.V1.Groupable"]) {
@@ -1589,12 +1685,13 @@ sap.ui.define([
                             aggregatable: false,
                             maxConditions: ODataMetaModelUtil.isMultiValueFilterExpression(oFilterRestrictionsInfo.propertyInfo[sKey]) ? -1 : 1,
                             sortKey: sKey,
-                            kind:  "Groupable", //TODO: Rename in type; Only needed for P13n Item Panel
-                            availableRoles: this._getLayoutOptionsForType("groupable"), //for p13n
+                            dataType: oObj.$Type,
+                            //formatOptions: null,
+                            //constraints: {},
                             role: MDCLib.ChartItemRoleType.category, //standard, normally this should be interpreted from UI.Chart annotation
                             criticality: null ,//To be implemented by FE
                             textProperty: oPropertyAnnotations["@com.sap.vocabularies.Common.v1.Text"] ? oPropertyAnnotations["@com.sap.vocabularies.Common.v1.Text"].$Path  : null //To be implemented by FE
-                            //textFormatter: function(){} -> can be used to provide a custom formatter for the textProperty
+                            //textFormatter: string-> can be used to provide a custom formatter for the textProperty
                         });
                     }
                 }
@@ -1603,7 +1700,7 @@ sap.ui.define([
         }.bind(this));
     };
 
-    ChartDelegate._createPropertyInfosForAggregatable = function(sKey, oPropertyAnnotations, oFilterRestrictionsInfo, oSortRestrictionsInfo) {
+    ChartDelegate._createPropertyInfosForAggregatable = function(sKey, oPropertyAnnotations, oObj, oFilterRestrictionsInfo, oSortRestrictionsInfo) {
         var aProperties = [];
 
         if (oPropertyAnnotations["@Org.OData.Aggregation.V1.SupportedAggregationMethods"]){
@@ -1618,13 +1715,10 @@ sap.ui.define([
                     aggregatable: oPropertyAnnotations["@Org.OData.Aggregation.V1.Aggregatable"],
                     aggregationMethod: sAggregationMethod,
                     maxConditions: ODataMetaModelUtil.isMultiValueFilterExpression(oFilterRestrictionsInfo.propertyInfo[sKey]) ? -1 : 1,
-                    sortKey: oPropertyAnnotations["@Org.OData.Aggregation.V1.RecommendedAggregationMethod"] + sKey,
-                    kind: "Aggregatable",//Only needed for P13n Item Panel
-                    availableRoles: this._getLayoutOptionsForType("aggregatable"), //for p13n
-                    role: MDCLib.ChartItemRoleType.axis1,
+                    dataType: oObj.$Type,
                     datapoint: null //To be implemented by FE
                 });
-            }.bind(this));
+            });
         }
 
         return aProperties;
@@ -1632,15 +1726,7 @@ sap.ui.define([
 
     //Gets internal property infos by excact property name
     ChartDelegate._getPropertyInfosByName = function(sName, oMDCChart){
-        return new Promise(function(resolve){
-            this.fetchProperties(oMDCChart).then(function(aProperties){
-                var oPropertyInfo = aProperties.find(function (oCurrentPropertyInfo) {
-                    return oCurrentPropertyInfo.name === sName;
-                });
-
-                resolve(oPropertyInfo);
-            });
-        }.bind(this));
+        return oMDCChart._getPropertyByNameAsync(sName);
     };