@openui5/sap.ui.mdc 1.131.0 → 1.132.0

package/THIRDPARTY.txt

@@ -468,7 +468,7 @@ License: Apache-2.0
 License Text: https://github.com/SAP/openui5/blob/master/LICENSES/Apache-2.0.txt
 Contained in: lib/jsdoc/ui5/plugin.js
 
-Component: SAP Theming Base Content, version: 11.22.0
+Component: SAP Theming Base Content, version: 11.24.0
 Copyright: SAP SE or an SAP affiliate company and Theming Base Content contributors
 License: Apache-2.0
 License Text: https://github.com/SAP/openui5/blob/master/LICENSES/Apache-2.0.txt

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openui5/sap.ui.mdc",
-  "version": "1.131.0",
+  "version": "1.132.0",
   "description": "OpenUI5 UI Library sap.ui.mdc",
   "author": "SAP SE (https://www.sap.com)",
   "license": "Apache-2.0",
@@ -14,8 +14,8 @@
     "url": "https://github.com/SAP/openui5.git"
   },
   "dependencies": {
-    "@openui5/sap.m": "1.131.0",
-    "@openui5/sap.ui.core": "1.131.0",
-    "@openui5/sap.ui.layout": "1.131.0"
+    "@openui5/sap.m": "1.132.0",
+    "@openui5/sap.ui.core": "1.132.0",
+    "@openui5/sap.ui.layout": "1.132.0"
   }
 }

package/src/sap/ui/mdc/.library

@@ -4,9 +4,9 @@
 	  <name>sap.ui.mdc</name>
 	<vendor>SAP SE</vendor>
 	<copyright>OpenUI5
- * (c) Copyright 2009-2024 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2025 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.</copyright>
-	<version>1.131.0</version>
+	<version>1.132.0</version>
 
 	<documentation>UI5 library: sap.ui.mdc</documentation>
 

package/src/sap/ui/mdc/ActionToolbar.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2024 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2025 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
@@ -33,7 +33,7 @@ sap.ui.define([
 	 * The content aggregation of the control must not be used.
 	 * @extends sap.m.OverflowToolbar
 	 * @author SAP SE
-	 * @version 1.131.0
+	 * @version 1.132.0
 	 * @constructor
 	 * @since 1.58
 	 * @private

package/src/sap/ui/mdc/AggregationBaseDelegate.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2024 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2025 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 

package/src/sap/ui/mdc/BaseDelegate.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2024 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2025 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 

package/src/sap/ui/mdc/Chart.js

@@ -1,6 +1,6 @@
 /*!
 * OpenUI5
- * (c) Copyright 2009-2024 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2025 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
 */
 
@@ -75,7 +75,7 @@ sap.ui.define([
 		 * @extends sap.ui.mdc.Control
 		 * @borrows sap.ui.mdc.mixin.FilterIntegrationMixin.rebind as #rebind
 		 * @author SAP SE
-		 * @version 1.131.0
+		 * @version 1.132.0
 		 * @constructor
 		 *
 		 * @public
@@ -171,7 +171,7 @@ sap.ui.define([
 					},
 
 					/**
-					 * Enables the legend of the chart.
+					 * Enables the legend of the chart.<br>
 					 * <b>Note:</b> The setter calls <code>setLegendVisible</code> of the delegate class.
 					 *
 					 * @since 1.88
@@ -239,7 +239,7 @@ sap.ui.define([
 
 					/**
 					 * Controls the visibility of the chart tooltip.<br>
-					 * If set to <code>true</code>, a call of the <code>delegate.setChartTooltipVisibility</code> will be triggered and can be used to make the <code>Chart</code> tooltip visible.
+					 * <b>Note:</b> If set to <code>true</code>, a call of the <code>delegate.setChartTooltipVisibility</code> is triggered and can be used to make the <code>Chart</code> tooltip visible.
 					 *
 					 * @since 1.88
 					 */
@@ -281,15 +281,13 @@ sap.ui.define([
 					 * Specifies the chart metadata.<br>
 					 * <b>Note:</b> This property must not be bound.<br>
 					 * <b>Note:</b> This property is exclusively used for handling SAPUI5 flexibility changes. Do not use it otherwise.<br>
-					 * <b>Note</b>: Existing properties (set via <code>sap.ui.mdc.Chart#setPropertyInfo</code>) must not be removed and their attributes must not be changed during the {@link module:sap/ui/mdc/ChartDelegate.fetchProperties fetchProperties} callback
-					 * Otherwise validation errors might occur whenever personalization-related control features (such as the opening of any personalization dialog) are activated.
-					 *
+					 * <b>Note</b>: Existing properties (set via <code>sap.ui.mdc.Chart#setPropertyInfo</code>) must not be removed and their attributes must not be changed during the {@link module:sap/ui/mdc/ChartDelegate.fetchProperties fetchProperties} callback. Otherwise validation errors might occur whenever personalization-related control features (such as the opening of any personalization dialog) are activated.
 					 * <b>Note</b>: For more information about the supported inner elements, see {@link sap.ui.mdc.chart.PropertyInfo PropertyInfo}.
 					 *
 					 * @since 1.99
 					 */
 					propertyInfo: {
-						type: "object", //TODO this should be an object[], but when I change this the TwFb does not start
+						type: "object",
 						defaultValue: []
 					},
 
@@ -332,6 +330,7 @@ sap.ui.define([
 					/**
 					 * This property describes the measures and dimensions visible in the chart.
 					 * Changes in the personalization are also reflected here.
+					 *
 					 * <b>Note:</b>
 					 * This aggregation is managed by the control, can only be populated during the definition in the XML view, and is not bindable.
 					 * Any changes of the initial aggregation content might result in undesired effects.
@@ -359,7 +358,7 @@ sap.ui.define([
 						}
 					},
 					/**
-					 * Feeds details popover actions for data point selection in the mdc chart.<br>
+					 * Feeds details popover actions for data point selection in the chart.<br>
 					 * For more information, see {@link sap.ui.mdc.chart.SelectionDetailsActions SelectionDetailsActions}.
 					 */
 					selectionDetailsActions: {
@@ -483,29 +482,15 @@ sap.ui.define([
 		 * 	Defines whether the property is groupable and is selectable as a dimension in the chart
 		 * @property {boolean} aggregatable
 		 *  Defines whether the property is aggregatable and is selectable as a measure in the chart
-		 * @property {string} [aggregationMethod]
-		 * 	The aggregation method used if the property is aggregatable
 		 * @property {string} role
 		 * 	Defines the role that the property visualizes inside the chart
-		 * @property {object} [datapoint]
-		 * 	Implementation-specific object containing information about the data point
-		 * @property {object} [criticality]
-		 *  Implementation-specific object containing information about the criticality
-		 * @property {string} [textProperty]
-		 * 	The text property used for the dimension
-		 * @property {object} [textFormatter]
-		 * 	The text formatter object which can be used to format the textProperty
-		 * @property {object} [unitPath]
-		 *  The name of the unit property which will be used to display and format measure values with a unit value on a selectionDetails popover
-		 * @property {string} [timeUnitType]
-		 *  The <code>timeUnitType</code> type for a <code>TimeDimension</code>. If set, a <code>TimeDimension</code> is created instead of a <code>Dimension</code>
 		 * @public
 		 * @experimental As of version 1.80
 		 */
 
 
 		/**
-		 * Initialises the MDC Chart
+		 * Initializes the chart.
 		 *
 		 * @private
 		 */
@@ -605,9 +590,9 @@ sap.ui.define([
 			return this.getInbuiltFilter() ? this.getInbuiltFilter().getConditions() : [];
 		};
 		/**
-		 * Registers the chart rebind to the filter bar search event.
+		 * Registers the chart rebind function call to the filter bar search event.
 		 *
-		 * @param {sap.ui.mdc.filterbar.p13n.AdaptionFilterBar} oFilter The FilterBar instance to be attached to.
+		 * @param {sap.ui.mdc.filterbar.p13n.AdaptionFilterBar} oFilter The FilterBar instance
 		 * @private
 		 */
 		Chart.prototype._registerInnerFilter = function(oFilter) {
@@ -617,7 +602,7 @@ sap.ui.define([
 		};
 
 		/**
-		 * Applies given settings onto the MDC chart, loads the delegate and initializes the MDC chart
+		 * Applies the given settings to the chart, loads the delegate, and initializes the chart.
 		 *
 		 * @param {*} mSettings settings to apply
 		 *
@@ -654,8 +639,8 @@ sap.ui.define([
 		};
 
 		/**
-		 * Initializes the inner controls of the MDC chart (toolbar, inner chart)
-		 * Inner chart is initialized via the delegate
+		 * Initializes the inner controls of the chart (toolbar, inner chart).
+		 * The inner chart is initialized via the delegate.
 		 */
 		Chart.prototype._initInnerControls = function() {
 
@@ -698,9 +683,9 @@ sap.ui.define([
 			const aIgnoreToolbarActions = this.getIgnoreToolbarActions();
 
 			const bShowSelectionDetails = this.getShowSelectionDetails();
-			const bShowDrillDown = (aP13nMode.includes("Item") && !(aIgnoreToolbarActions.length || aIgnoreToolbarActions.includes(ChartToolbarActionType.DrillDownUp)));
-			const bShowLegend = !(aIgnoreToolbarActions.length || aIgnoreToolbarActions.includes(ChartToolbarActionType.Legend));
-			const bShowZoom = !(aIgnoreToolbarActions.length || aIgnoreToolbarActions.includes(ChartToolbarActionType.ZoomInOut));
+			const bShowDrillDown = (aP13nMode.includes("Item") && !(aIgnoreToolbarActions.length && aIgnoreToolbarActions.includes(ChartToolbarActionType.DrillDownUp)));
+			const bShowLegend = !(aIgnoreToolbarActions.length && aIgnoreToolbarActions.includes(ChartToolbarActionType.Legend));
+			const bShowZoom = !(aIgnoreToolbarActions.length && aIgnoreToolbarActions.includes(ChartToolbarActionType.ZoomInOut));
 			const bShowSettings = aP13nMode.includes("Sort") || aP13nMode.includes("Item") || aP13nMode.includes("Filter");
 			const bShowChartType = this._getTypeBtnActive();
 
@@ -817,7 +802,11 @@ sap.ui.define([
 							}
 						}
 					}).then((vResult) => {
-						this.getControlDelegate().requestToolbarUpdate(this);
+						if (this.getControlDelegate().requestToolbarUpdate) {
+							this.getControlDelegate().requestToolbarUpdate(this);
+						} else {
+							this._updateToolbar();
+						}
 					});
 
 				});
@@ -882,10 +871,10 @@ sap.ui.define([
 			this._updateVariantManagementStyle();
 		};
 		/**
-		 * Creates the SelectionDetails control used in the toolbar.
+		 * Creates the <code>SelectionDetails</code> control used in the toolbar.
 		 *
-		 * @param {string} sId Id of the MDC chart
-		 * @returns {sap.m.SelectionDetails} The SelectionDetails instance
+		 * @param {string} sId ID of the chart
+		 * @returns {sap.m.SelectionDetails} The <code>SelectionDetails</code> instance
 		 * @private
 		 */
 		Chart.prototype._createSelectionDetails = function(sId) {
@@ -970,7 +959,7 @@ sap.ui.define([
 			}
 		};
 		/**
-		 * Getter for the filter info text used to update the info toolbar.
+		 * Gets the filter info text used to update the info toolbar.
 		 *
 		 * @returns {string} The info text
 		 * @private
@@ -996,6 +985,43 @@ sap.ui.define([
 			return undefined;
 		};
 
+		/**
+		 * This iterates over all items of the chart to make sure all necessary information is available on them.
+		 * If something is missing, this method updates the item accordingly. This is the last check before the inner chart is rendered.
+		 * @returns {Promise} Resolves once check is complete
+		 *
+		 * @private
+		 */
+		Chart.prototype.checkAndUpdateItems = function() {
+			return new Promise((resolve, reject) => {
+				const aPropPromises = [];
+
+				const fnCheckAndUpdateItemProperty = function(oItem, oPropertyInfoProValue, sPropertyName, sDefaultValue) {
+					const value = oItem.getProperty(sPropertyName);
+					if (!value || value !== oPropertyInfoProValue) {
+						if (value !== oPropertyInfoProValue) {
+							Log.error("sap.ui.mdc.Chart", `the propertyInfo.${sPropertyName} for Item '${oItem.getId()}' has a different value! new value = ${ oPropertyInfoProValue || sDefaultValue }`);
+						}
+						oItem.setProperty(sPropertyName, oPropertyInfoProValue || sDefaultValue);
+					}
+				};
+
+				this.getItems().forEach((oItem) => {
+					aPropPromises.push(this._getPropertyByNameAsync(oItem.getPropertyKey()).then((oPropertyInfo) => {
+						if (oPropertyInfo) {
+							fnCheckAndUpdateItemProperty(oItem, oPropertyInfo.label, "label");
+							fnCheckAndUpdateItemProperty(oItem, oPropertyInfo.groupable ? "groupable" : "aggregatable", "type");
+							fnCheckAndUpdateItemProperty(oItem, oPropertyInfo.role, "role", oPropertyInfo.groupable ? "category" : "axis1");
+						}
+					}));
+				});
+
+				Promise.all(aPropPromises).then(() => {
+					resolve();
+				});
+			});
+		};
+
 		/**
 		 * Creates the content for the inner chart from properties.
 		 * The properties are given via the PropertyHelper which is initialized here.
@@ -1006,7 +1032,7 @@ sap.ui.define([
 		 */
 		Chart.prototype._createContentfromPropertyInfos = function(oInnerChart) {
 			//Make sure all MDC Items have the necessary information to create a chart
-			this.getControlDelegate().checkAndUpdateMDCItems(this).then(() => {
+			this.checkAndUpdateItems().then(() => {
 				//Create content on inner chart instance
 				if (!this._oInnerChartContentPromise) {
 					this._oInnerChartContentPromise = this.getControlDelegate().createInnerChartContent(this, this._innerChartDataLoadComplete.bind(this));
@@ -1031,7 +1057,7 @@ sap.ui.define([
 			});
 		};
 		/**
-		 * Creates the bread crumbs control to visualize the drill depth of the chart.
+		 * Creates the <code>Breadcrumbs</code> control to visualize the drilling depth of the chart.
 		 * @private
 		 */
 		Chart.prototype._createBreadcrumbs = function() {
@@ -1140,10 +1166,6 @@ sap.ui.define([
 					break;
 			}
 
-			//Needed to apply current sorters when sorted measure/dimension was not selected yet
-			//However, since this gets called multiple times when the aggregation adds/removes multiple properties, the binding seems to break
-			this._rebind();
-
 			//Update the breadcrumbs after an MDC Item change
 			const aItems = this.getControlDelegate().getDrillableItems(this).map((oItem) => { return { key: oItem.getPropertyKey(), text: oItem.getLabel() }; });
 			this.getAggregation("_breadcrumbs").update(aItems);
@@ -1266,7 +1288,7 @@ sap.ui.define([
 		};
 
 		/**
-		 * Calls the update function on the toolbar, if a toolbar exists
+		 * Calls the update function for the toolbar if a toolbar exists.
 		 *
 		 * @private
 		 */
@@ -1286,8 +1308,8 @@ sap.ui.define([
 		};
 
 		/**
-		 * This checks the enablement of the zoom buttons in the toolbar.
-		 * <b>Note:</b> Buttons will be disabled when no zoom state is available or is disabled.
+		 * Checks the enablement of the zoom buttons in the toolbar.
+		 * <b>Note:</b> Buttons will be disabled if no zoom state is available or if it is disabled.
 		 *
 		 * @experimental
 		 * @private
@@ -1324,7 +1346,7 @@ sap.ui.define([
 		};
 
 		/**
-		 * Initialises the selection details control by attaching to its selection handler.
+		 * Initializes the <code>SelectionDetails</code> control by attaching it to the provided chart selection handler.
 		 * @private
 		 */
 		Chart.prototype._initSelectionDetails = function() {
@@ -1377,7 +1399,7 @@ sap.ui.define([
 		};
 
 		/**
-		 * Zooms in on the inner chart.
+		 * Zooms in from the inner chart.
 		 *
 		 * @private
 		 * @ui5-restricted sap.ui.mdc
@@ -1388,7 +1410,7 @@ sap.ui.define([
 		};
 
 		/**
-		 * Zooms out on the inner chart.
+		 * Zooms out from the inner chart.
 		 *
 		 * @private
 		 * @ui5-restricted sap.ui.mdc
@@ -1484,7 +1506,7 @@ sap.ui.define([
 		};
 
 		/**
-		 * Getter for information about the current chart type.
+		 * Gets the information about the current chart type.
 		 *
 		 * @returns {object} object containing information about the chart type
 		 *
@@ -1497,7 +1519,7 @@ sap.ui.define([
 		};
 
 		/**
-		 * Getter for the available chart types of inner chart based on its current state.
+		 * Gets the available chart types of the inner chart based on its current state.
 		 *
 		 * @returns {sap.ui.mdc.chart.ChartTypeObject[]} Array containing the currently available chart types
 		 *
@@ -1537,7 +1559,7 @@ sap.ui.define([
 			this.setAggregation("noData", oControl);
 
 			try {
-				this.getControlDelegate().changedNoDataStruct(this);
+				this.getControlDelegate().changedNoDataStruct(this, oControl);
 			} catch (err) {
 				//This fails when the delegate instance is not yet available.
 				//It is not a problem as the delegate will use getNoData() on init of the chart, thus using the correct noData struct.
@@ -1560,7 +1582,6 @@ sap.ui.define([
 		/**
 		 * This is a callback function which is called from the delegate once the inner chart finished loading data
 		 * Updates the Toolbar
-		 * Fires the innerChartLoadedData event
 		 *
 		 * @private
 		 */
@@ -1569,7 +1590,11 @@ sap.ui.define([
 			this.setBusy(false);
 			this._renderOverlay(false);
 
-			this.getControlDelegate().requestToolbarUpdate(this);
+			if (this.getControlDelegate().requestToolbarUpdate) {
+				this.getControlDelegate().requestToolbarUpdate(this);
+			} else {
+				this._updateToolbar();
+			}
 		};
 
 		Chart.prototype._checkStyleClassesForDimensions = function() {
@@ -1726,7 +1751,7 @@ sap.ui.define([
 			return this;
 		};
 		/**
-		 * Returns the variant management control of the MDC Chart.
+		 * Returns the <code>VariantManagement</code> control of the chart.
 		 * @returns {sap.ui.fl.variants.VariantManagement} The variant management instance
 		 */
 		Chart.prototype.getVariant = function() {