@openui5/sap.ui.layout 1.127.1 → 1.129.0

package/THIRDPARTY.txt

@@ -468,7 +468,7 @@ License: Apache-2.0
 License Text: https://github.com/SAP/openui5/blob/master/LICENSES/Apache-2.0.txt
 Contained in: lib/jsdoc/ui5/plugin.js
 
-Component: SAP Theming Base Content, version: 11.16.1
+Component: SAP Theming Base Content, version: 11.18.0
 Copyright: SAP SE or an SAP affiliate company and Theming Base Content contributors
 License: Apache-2.0
 License Text: https://github.com/SAP/openui5/blob/master/LICENSES/Apache-2.0.txt

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openui5/sap.ui.layout",
-  "version": "1.127.1",
+  "version": "1.129.0",
   "description": "OpenUI5 UI Library sap.ui.layout",
   "author": "SAP SE (https://www.sap.com)",
   "license": "Apache-2.0",
@@ -14,6 +14,6 @@
     "url": "https://github.com/SAP/openui5.git"
   },
   "dependencies": {
-    "@openui5/sap.ui.core": "1.127.1"
+    "@openui5/sap.ui.core": "1.129.0"
   }
 }

package/src/sap/ui/layout/.library

@@ -6,7 +6,7 @@
   <copyright>OpenUI5
  * (c) Copyright 2009-2024 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.</copyright>
-  <version>1.127.1</version>
+  <version>1.129.0</version>
 
   <documentation>SAPUI5 library with layout controls.</documentation>
 

package/src/sap/ui/layout/AlignedFlowLayout.js

@@ -40,7 +40,7 @@ sap.ui.define([
 		 * @extends sap.ui.core.Control
 		 *
 		 * @author SAP SE
-		 * @version 1.127.1
+		 * @version 1.129.0
 		 *
 		 * @constructor
 		 * @private

package/src/sap/ui/layout/AssociativeSplitter.js

@@ -25,7 +25,7 @@ sap.ui.define([
 	 * @extends sap.ui.layout.Splitter
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/layout/BlockLayout.js

@@ -63,7 +63,7 @@ sap.ui.define([
 		 * @extends sap.ui.core.Control
 		 *
 		 * @author SAP SE
-		 * @version 1.127.1
+		 * @version 1.129.0
 		 *
 		 * @constructor
 		 * @public

package/src/sap/ui/layout/BlockLayoutCell.js

@@ -26,7 +26,7 @@ sap.ui.define([
 		 * @extends sap.ui.core.Control
 		 *
 		 * @author SAP SE
-		 * @version 1.127.1
+		 * @version 1.129.0
 		 *
 		 * @constructor
 		 * @public

package/src/sap/ui/layout/BlockLayoutCellData.js

@@ -18,7 +18,7 @@ sap.ui.define(['sap/ui/core/LayoutData', './library'],
 	 * @class
 	 * Holds layout data for the BlockLayoutCells contents.
 	 * @extends sap.ui.core.LayoutData
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 * @constructor
 	 * @public
 	 * @since 1.50.0

package/src/sap/ui/layout/BlockLayoutRow.js

@@ -32,7 +32,7 @@ sap.ui.define([
 		 * @extends sap.ui.core.Control
 		 *
 		 * @author SAP SE
-		 * @version 1.127.1
+		 * @version 1.129.0
 		 *
 		 * @constructor
 		 * @public

package/src/sap/ui/layout/DynamicSideContent.js

@@ -97,7 +97,7 @@ sap.ui.define([
 		 * @extends sap.ui.core.Control
 		 *
 		 * @author SAP SE
-		 * @version 1.127.1
+		 * @version 1.129.0
 		 *
 		 * @constructor
 		 * @public

package/src/sap/ui/layout/FixFlex.js

@@ -53,7 +53,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/Grid.js

@@ -59,7 +59,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/GridData.js

@@ -28,7 +28,7 @@ sap.ui.define(['sap/ui/core/LayoutData', './library', "sap/base/Log"],
 	 * @extends sap.ui.core.LayoutData
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/GridRenderer.js

@@ -15,7 +15,7 @@ sap.ui.define(["sap/ui/Device", "sap/ui/layout/library"],
 	/**
 	 * @author SAP SE
 	 * @version
-	 * 1.127.1
+	 * 1.129.0
 	 * @namespace
 	 */
 	var GridRenderer = {

package/src/sap/ui/layout/HorizontalLayout.js

@@ -22,7 +22,7 @@ sap.ui.define(['sap/ui/core/Control', './library', "./HorizontalLayoutRenderer"]
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/PaneContainer.js

@@ -24,7 +24,7 @@ sap.ui.define(['./library', 'sap/ui/core/Element', './AssociativeSplitter', 'sap
 	 * @extends sap.ui.core.Element
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/ResponsiveFlowLayout.js

@@ -42,7 +42,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/ResponsiveFlowLayoutData.js

@@ -22,7 +22,7 @@ sap.ui.define(['sap/ui/core/LayoutData', './library', "sap/base/Log"],
 	 * @extends sap.ui.core.LayoutData
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/ResponsiveSplitter.js

@@ -72,7 +72,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/ResponsiveSplitterPage.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/layout/SplitPane.js

@@ -26,7 +26,7 @@ sap.ui.define(['./library', 'sap/ui/core/Element'],
 	 * @extends sap.ui.core.Element
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/Splitter.js

@@ -72,7 +72,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/SplitterLayoutData.js

@@ -21,7 +21,7 @@ sap.ui.define(['sap/ui/core/LayoutData', './library'],
 	 * Holds layout data for the splitter contents.
 
 	 * @extends sap.ui.core.LayoutData
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/VerticalLayout.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/ui/layout/changeHandler/AddFormContainer.js

@@ -17,7 +17,7 @@ sap.ui.define([
 		* Change handler for adding a form group.
 		* @alias sap.ui.layout.changeHandler.AddFormContainer
 		* @author SAP SE
-		* @version 1.127.1
+		* @version 1.129.0
 		* @experimental Since 1.48.0
 		*/
 	var AddGroup = { };

package/src/sap/ui/layout/changeHandler/AddFormField.js

@@ -19,7 +19,7 @@ sap.ui.define([
 	 *
 	 * @author SAP SE
 	 *
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @experimental Since 1.50.0 This class is experimental and provides only limited functionality. Also the API might be
 	 *               changed in future.

package/src/sap/ui/layout/changeHandler/AddSimpleFormField.js

@@ -77,7 +77,7 @@ sap.ui.define([
 	 *
 	 * @author SAP SE
 	 *
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 *
 	 * @experimental Since 1.49.0 This class is experimental and provides only limited functionality. Also the API might be
 	 *               changed in future.
@@ -155,17 +155,30 @@ sap.ui.define([
 	});
 
 	AddSimpleFormField.getChangeVisualizationInfo = function(oChange, oAppComponent) {
-		var oRevertData = oChange.getRevertData();
+		const oFormSelector = oChange.getSelector();
+		const oForm = JsControlTreeModifier.bySelector(oFormSelector, oAppComponent);
+		const oRevertData = oChange.getRevertData();
+		const oReturn = {
+			updateRequired: true
+		};
 
 		if (oRevertData && oRevertData.labelSelector) {
-			return {
-				affectedControls: [JsControlTreeModifier.bySelector(oRevertData.labelSelector, oAppComponent).getParent().getId()],
-				updateRequired: true
-			};
+			const oLabel = JsControlTreeModifier.bySelector(oRevertData.labelSelector, oAppComponent);
+			oReturn.affectedControls = [oLabel.getParent().getId()];
+			// If the label is currently invisible, the indicator should be on the form (it can't be the group because it could have been headerless)
+			if (!oLabel.getVisible()) {
+				oReturn.displayControls = [oForm];
+			}
+		} else {
+			const oElement = JsControlTreeModifier.bySelector(oChange.getContent().elementSelector, oAppComponent);
+			oReturn.affectedControls = [oChange.getContent().newFieldSelector];
+			// If the element is currently invisible, the indicator should be on on the form (it can't be the group because it could have been headerless)
+			if (!oElement.getVisible()) {
+				oReturn.displayControls = [oForm];
+			}
 		}
-		return {
-			affectedControls: [oChange.getContent().newFieldSelector]
-		};
+
+		return oReturn;
 	};
 
 	AddSimpleFormField.getCondenserInfo = function() {

package/src/sap/ui/layout/changeHandler/AddSimpleFormGroup.js

@@ -17,7 +17,7 @@ sap.ui.define([
 		* Change handler for adding a simple form group.
 		* @alias sap.ui.layout.changeHandler.AddSimpleFormGroup
 		* @author SAP SE
-		* @version 1.127.1
+		* @version 1.129.0
 		* @experimental Since 1.27.0
 		*/
 	var AddSimpleFormGroup = {};

package/src/sap/ui/layout/changeHandler/HideSimpleForm.js

@@ -19,7 +19,7 @@ sap.ui.define([
 	 * Change handler for hiding of a control.
 	 * @alias sap.ui.fl.changeHandler.HideControl
 	 * @author SAP SE
-	 * @version 1.127.1
+	 * @version 1.129.0
 	 * @experimental Since 1.27.0
 	 */
 	var HideForm = { };
@@ -276,12 +276,29 @@ sap.ui.define([
 			});
 	};
 
-	HideForm.getChangeVisualizationInfo = function(oChange) {
-		var oSelector = oChange.getContent().elementSelector;
-		var oDisplaySelector = oChange.getSelector();
+	HideForm.getChangeVisualizationInfo = function(oChange, oAppComponent) {
+		const oElementSelector = oChange.getContent().elementSelector;
+		const oFormSelector = oChange.getSelector();
+		const oForm = JsControlTreeModifier.bySelector(oFormSelector, oAppComponent);
+		const oElement = JsControlTreeModifier.bySelector(oElementSelector, oAppComponent);
+		const oElementParent = oElement.getParent();
+
+		// If a Group is being hidden, always show on the form since groups can't be revealed
+		let sDisplayElementId = oForm.getId();
+
+		// FormElement is being hidden
+		if (oElementParent.isA("sap.ui.layout.form.FormElement")) {
+			// If the Label is currently visible, the indicator should be on the form element (e.g. after the element is revealed)
+			// Otherwise we show it on the form, since the group element could have been in a group that got removed, leading to
+			// inconsistencies in the visualization
+			if (oElement.getVisible()) {
+				sDisplayElementId = oElementParent.getId();
+			}
+		}
+
 		return {
-			affectedControls: [oSelector],
-			displayControls: [oDisplaySelector],
+			affectedControls: [oElement.getId()],
+			displayControls: [sDisplayElementId],
 			updateRequired: true
 		};
 	};