@openui5/sap.ui.layout 1.103.0 → 1.105.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (64) hide show
  1. package/.eslintrc.json +2 -3
  2. package/.reuse/dep5 +18 -1
  3. package/LICENSES/LicenseRef-tzdata-PublicDomain.txt +5 -0
  4. package/THIRDPARTY.txt +36 -3
  5. package/package.json +2 -2
  6. package/src/sap/ui/layout/.library +1 -1
  7. package/src/sap/ui/layout/AlignedFlowLayout.js +1 -1
  8. package/src/sap/ui/layout/AssociativeSplitter.js +3 -4
  9. package/src/sap/ui/layout/BlockLayout.js +1 -1
  10. package/src/sap/ui/layout/BlockLayoutCell.js +2 -3
  11. package/src/sap/ui/layout/BlockLayoutCellData.js +1 -1
  12. package/src/sap/ui/layout/BlockLayoutRow.js +1 -1
  13. package/src/sap/ui/layout/DynamicSideContent.js +1 -1
  14. package/src/sap/ui/layout/FixFlex.js +1 -1
  15. package/src/sap/ui/layout/Grid.js +1 -1
  16. package/src/sap/ui/layout/GridData.js +1 -1
  17. package/src/sap/ui/layout/GridRenderer.js +1 -1
  18. package/src/sap/ui/layout/HorizontalLayout.js +1 -1
  19. package/src/sap/ui/layout/PaneContainer.js +1 -1
  20. package/src/sap/ui/layout/ResponsiveFlowLayout.js +1 -1
  21. package/src/sap/ui/layout/ResponsiveFlowLayoutData.js +1 -1
  22. package/src/sap/ui/layout/ResponsiveSplitter.js +1 -1
  23. package/src/sap/ui/layout/ResponsiveSplitterPage.js +1 -1
  24. package/src/sap/ui/layout/SplitPane.js +1 -1
  25. package/src/sap/ui/layout/Splitter.js +1 -1
  26. package/src/sap/ui/layout/SplitterLayoutData.js +1 -1
  27. package/src/sap/ui/layout/VerticalLayout.js +1 -1
  28. package/src/sap/ui/layout/changeHandler/AddFormContainer.js +24 -34
  29. package/src/sap/ui/layout/changeHandler/AddFormField.js +1 -1
  30. package/src/sap/ui/layout/changeHandler/AddSimpleFormField.js +1 -1
  31. package/src/sap/ui/layout/changeHandler/AddSimpleFormGroup.js +27 -32
  32. package/src/sap/ui/layout/changeHandler/HideSimpleForm.js +11 -9
  33. package/src/sap/ui/layout/changeHandler/MoveSimpleForm.js +12 -12
  34. package/src/sap/ui/layout/changeHandler/RenameFormContainer.js +8 -19
  35. package/src/sap/ui/layout/changeHandler/RenameSimpleForm.js +18 -20
  36. package/src/sap/ui/layout/changeHandler/UnhideSimpleForm.js +13 -13
  37. package/src/sap/ui/layout/cssgrid/CSSGrid.js +1 -1
  38. package/src/sap/ui/layout/cssgrid/GridBasicLayout.js +1 -1
  39. package/src/sap/ui/layout/cssgrid/GridBoxLayout.js +1 -1
  40. package/src/sap/ui/layout/cssgrid/GridItemLayoutData.js +1 -1
  41. package/src/sap/ui/layout/cssgrid/GridLayoutBase.js +1 -1
  42. package/src/sap/ui/layout/cssgrid/GridLayoutDelegate.js +1 -1
  43. package/src/sap/ui/layout/cssgrid/GridResponsiveLayout.js +1 -1
  44. package/src/sap/ui/layout/cssgrid/GridSettings.js +1 -1
  45. package/src/sap/ui/layout/cssgrid/ResponsiveColumnItemLayoutData.js +1 -1
  46. package/src/sap/ui/layout/cssgrid/ResponsiveColumnLayout.js +1 -1
  47. package/src/sap/ui/layout/designtime/form/Form.designtime.js +3 -0
  48. package/src/sap/ui/layout/designtime/form/FormContainer.designtime.js +4 -1
  49. package/src/sap/ui/layout/designtime/form/SimpleForm.designtime.js +4 -1
  50. package/src/sap/ui/layout/form/ColumnContainerData.js +1 -1
  51. package/src/sap/ui/layout/form/ColumnElementData.js +1 -1
  52. package/src/sap/ui/layout/form/ColumnLayout.js +1 -1
  53. package/src/sap/ui/layout/form/Form.js +1 -1
  54. package/src/sap/ui/layout/form/FormContainer.js +1 -1
  55. package/src/sap/ui/layout/form/FormElement.js +1 -1
  56. package/src/sap/ui/layout/form/FormLayout.js +1 -1
  57. package/src/sap/ui/layout/form/GridContainerData.js +1 -1
  58. package/src/sap/ui/layout/form/GridElementData.js +1 -1
  59. package/src/sap/ui/layout/form/GridLayout.js +1 -1
  60. package/src/sap/ui/layout/form/ResponsiveGridLayout.js +1 -1
  61. package/src/sap/ui/layout/form/ResponsiveLayout.js +1 -1
  62. package/src/sap/ui/layout/form/SemanticFormElement.js +1 -1
  63. package/src/sap/ui/layout/form/SimpleForm.js +1 -1
  64. package/src/sap/ui/layout/library.js +2 -2
@@ -6,12 +6,10 @@
6
6
 
7
7
  sap.ui.define([
8
8
  "sap/ui/fl/changeHandler/Base",
9
- "sap/ui/core/util/reflection/JsControlTreeModifier",
10
- "sap/base/Log"
9
+ "sap/ui/core/util/reflection/JsControlTreeModifier"
11
10
  ], function (
12
11
  Base,
13
- JsControlTreeModifier,
14
- Log
12
+ JsControlTreeModifier
15
13
  ) {
16
14
  "use strict";
17
15
 
@@ -19,7 +17,7 @@ sap.ui.define([
19
17
  * Change handler for adding a simple form group.
20
18
  * @alias sap.ui.layout.changeHandler.AddSimpleFormGroup
21
19
  * @author SAP SE
22
- * @version 1.103.0
20
+ * @version 1.105.0
23
21
  * @experimental Since 1.27.0
24
22
  */
25
23
  var AddSimpleFormGroup = {};
@@ -94,11 +92,14 @@ sap.ui.define([
94
92
  var oAppComponent = mPropertyBag.appComponent;
95
93
  var iInsertIndex;
96
94
 
97
- var oChange = oChangeWrapper.getDefinition();
98
- if (oChange.texts && oChange.texts.groupLabel && oChange.texts.groupLabel.value &&
99
- oChange.content && oChange.content.group &&
100
- (oChange.content.group.selector || oChange.content.group.id)) {
101
- var oGroupSelector = oChange.content.group.selector;
95
+ var oTexts = oChangeWrapper.getTexts();
96
+ var oContent = oChangeWrapper.getContent();
97
+ if (
98
+ oTexts && oTexts.groupLabel && oTexts.groupLabel.value
99
+ && oContent && oContent.group &&
100
+ (oContent.group.selector || oContent.group.id)
101
+ ) {
102
+ var oGroupSelector = oContent.group.selector;
102
103
  var sGroupId;
103
104
  if (oGroupSelector) {
104
105
  if (oGroupSelector.idIsLocal) {
@@ -107,21 +108,21 @@ sap.ui.define([
107
108
  sGroupId = oGroupSelector.id;
108
109
  }
109
110
  } else {
110
- sGroupId = oChange.content.group.id;
111
+ sGroupId = oContent.group.id;
111
112
  }
112
113
  oChangeWrapper.setRevertData({groupId: sGroupId});
113
- var sLabelText = oChange.texts.groupLabel.value;
114
+ var sLabelText = oTexts.groupLabel.value;
114
115
  var iRelativeIndex;
115
116
  return Promise.resolve()
116
117
  .then(function(){
117
118
  return oModifier.getAggregation(oForm, AddSimpleFormGroup.CONTENT_AGGREGATION);
118
119
  })
119
120
  .then(function(aContent){
120
- if (typeof oChange.content.group.index === "number") {
121
+ if (typeof oContent.group.index === "number") {
121
122
  // The old code support
122
- return oChange.content.group.index;
123
+ return oContent.group.index;
123
124
  } else {
124
- iRelativeIndex = oChange.content.group.relativeIndex;
125
+ iRelativeIndex = oContent.group.relativeIndex;
125
126
  return fnMapGroupIndexToContentAggregationIndex(oModifier,
126
127
  ["sap.ui.core.Title", "sap.m.Title", "sap.m.Toolbar", "sap.m.OverflowToolbar"],
127
128
  aContent, iRelativeIndex);
@@ -139,17 +140,13 @@ sap.ui.define([
139
140
  oModifier.setProperty(oTitle, "text", sLabelText);
140
141
  return oModifier.insertAggregation(oForm, "content", oTitle, iInsertIndex, oView);
141
142
  });
142
-
143
- } else {
144
- Log.error("Change does not contain sufficient information to be applied: [" + oChange.layer + "]" + oChange.namespace + "/" + oChange.fileName + "." + oChange.fileType);
145
- //however subsequent changes should be applied
146
143
  }
147
144
  };
148
145
 
149
146
  /**
150
147
  * Completes the change by adding change handler specific content
151
148
  *
152
- * @param {sap.ui.fl.Change} oChangeWrapper Change wrapper object to be completed
149
+ * @param {sap.ui.fl.Change} oChange Change wrapper object to be completed
153
150
  * @param {object} oSpecificChangeInfo with attributes "groupLabel", the group label to be included in the change and "newControlId", the control ID for the control to be added
154
151
  * @param {object} mPropertyBag Property bag containing the modifier, the appComponent and the view
155
152
  * @param {object} mPropertyBag.modifier Modifier for the controls
@@ -157,23 +154,19 @@ sap.ui.define([
157
154
  * @param {object} mPropertyBag.view Application view
158
155
  * @public
159
156
  */
160
- AddSimpleFormGroup.completeChangeContent = function (oChangeWrapper, oSpecificChangeInfo, mPropertyBag) {
161
- var oChange = oChangeWrapper.getDefinition();
157
+ AddSimpleFormGroup.completeChangeContent = function (oChange, oSpecificChangeInfo, mPropertyBag) {
162
158
  var oAppComponent = mPropertyBag.appComponent;
159
+ var oContent = {
160
+ group: {}
161
+ };
163
162
 
164
163
  if (oSpecificChangeInfo.newLabel) {
165
- Base.setTextInChange(oChange, "groupLabel", oSpecificChangeInfo.newLabel, "XFLD");
164
+ oChange.setText("groupLabel", oSpecificChangeInfo.newLabel, "XFLD");
166
165
  } else {
167
166
  throw new Error("oSpecificChangeInfo.newLabel attribute required");
168
167
  }
169
- if (!oChange.content) {
170
- oChange.content = {};
171
- }
172
- if (!oChange.content.group) {
173
- oChange.content.group = {};
174
- }
175
168
  if (oSpecificChangeInfo.newControlId) {
176
- oChange.content.group.selector = JsControlTreeModifier.getSelector(oSpecificChangeInfo.newControlId, oAppComponent);
169
+ oContent.group.selector = JsControlTreeModifier.getSelector(oSpecificChangeInfo.newControlId, oAppComponent);
177
170
  } else {
178
171
  throw new Error("oSpecificChangeInfo.newControlId attribute required");
179
172
  }
@@ -181,8 +174,10 @@ sap.ui.define([
181
174
  if (oSpecificChangeInfo.index === undefined) {
182
175
  throw new Error("oSpecificChangeInfo.index attribute required");
183
176
  } else {
184
- oChange.content.group.relativeIndex = oSpecificChangeInfo.index;
177
+ oContent.group.relativeIndex = oSpecificChangeInfo.index;
185
178
  }
179
+
180
+ oChange.setContent(oContent);
186
181
  };
187
182
 
188
183
  /**
@@ -233,7 +228,7 @@ sap.ui.define([
233
228
  };
234
229
 
235
230
  AddSimpleFormGroup.getChangeVisualizationInfo = function(oChange, oAppComponent) {
236
- var oSelector = oChange.getDefinition().content.group.selector;
231
+ var oSelector = oChange.getContent().group.selector;
237
232
  var oAffectedGroup = JsControlTreeModifier.bySelector(oSelector, oAppComponent).getParent().getId();
238
233
  return {
239
234
  affectedControls: [oAffectedGroup]
@@ -17,7 +17,7 @@ sap.ui.define([
17
17
  * Change handler for hiding of a control.
18
18
  * @alias sap.ui.fl.changeHandler.HideControl
19
19
  * @author SAP SE
20
- * @version 1.103.0
20
+ * @version 1.105.0
21
21
  * @experimental Since 1.27.0
22
22
  */
23
23
  var HideForm = { };
@@ -58,7 +58,6 @@ sap.ui.define([
58
58
  var oView = mPropertyBag.view;
59
59
  var oAppComponent = mPropertyBag.appComponent;
60
60
 
61
- var oChangeDefinition = oChange.getDefinition();
62
61
 
63
62
  // in case of custom fields the application needs to be on JS.
64
63
  // In the other case the visuality of the hidden control will be overriden by the custom field binding afterwards
@@ -66,8 +65,9 @@ sap.ui.define([
66
65
  return Promise.reject(Error("Change cannot be applied in XML. Retrying in JS."));
67
66
  }
68
67
 
68
+ var oContent = oChange.getContent();
69
69
  // !important : sHideId was used in 1.40, do not remove for compatibility!
70
- var oRemovedElement = oModifier.bySelector(oChangeDefinition.content.elementSelector || oChangeDefinition.content.sHideId, oAppComponent, oView);
70
+ var oRemovedElement = oModifier.bySelector(oContent.elementSelector || oContent.sHideId, oAppComponent, oView);
71
71
  var aContent;
72
72
 
73
73
  return this._getState(oControl, oModifier, oAppComponent)
@@ -88,7 +88,8 @@ sap.ui.define([
88
88
  })
89
89
  .then(function() {
90
90
  var iStart = -1;
91
- if (oChangeDefinition.changeType === "hideSimpleFormField") {
91
+ var sChangeType = oChange.getChangeType();
92
+ if (sChangeType === "hideSimpleFormField") {
92
93
  aContent.some(function (oField, index) {
93
94
  if (oField === oRemovedElement) {
94
95
  iStart = index;
@@ -104,7 +105,7 @@ sap.ui.define([
104
105
  }
105
106
  }
106
107
  });
107
- } else if (oChangeDefinition.changeType === "removeSimpleFormGroup") {
108
+ } else if (sChangeType === "removeSimpleFormGroup") {
108
109
  var aPromises = [];
109
110
  var oTitleOrToolbar = fnGetFirstToolbarOrTitle(aContent, oModifier);
110
111
  var bFirstContainerWithoutTitle = oTitleOrToolbar && !oRemovedElement;
@@ -161,7 +162,7 @@ sap.ui.define([
161
162
  }
162
163
  return Promise.resolve();
163
164
  })
164
- . catch(function(oError) {
165
+ .catch(function(oError) {
165
166
  oChange.resetRevertData();
166
167
  Log.error(oError.message || oError.name);
167
168
  });
@@ -192,10 +193,11 @@ sap.ui.define([
192
193
  * @public
193
194
  */
194
195
  HideForm.completeChangeContent = function(oChangeWrapper, oSpecificChangeInfo, mPropertyBag) {
195
- var oChange = oChangeWrapper.getDefinition();
196
196
  if (oSpecificChangeInfo.removedElement && oSpecificChangeInfo.removedElement.id) {
197
197
  var oStableElement = this._getStableElement(sap.ui.getCore().byId(oSpecificChangeInfo.removedElement.id));
198
- oChange.content.elementSelector = JsControlTreeModifier.getSelector(oStableElement, mPropertyBag.appComponent);
198
+ oChangeWrapper.setContent({
199
+ elementSelector: JsControlTreeModifier.getSelector(oStableElement, mPropertyBag.appComponent)
200
+ });
199
201
  oChangeWrapper.addDependentControl(oStableElement, "elementSelector", mPropertyBag);
200
202
  } else {
201
203
  throw new Error("oSpecificChangeInfo.removedElement.id attribute required");
@@ -268,7 +270,7 @@ sap.ui.define([
268
270
  };
269
271
 
270
272
  HideForm.getChangeVisualizationInfo = function(oChange, oAppComponent) {
271
- var oSelector = oChange.getDefinition().content.elementSelector;
273
+ var oSelector = oChange.getContent().elementSelector;
272
274
  var oElement = JsControlTreeModifier.bySelector(oSelector, oAppComponent);
273
275
  var oDisplaySelector = oChange.getChangeType() === "removeSimpleFormGroup"
274
276
  ? oElement.getParent().getId()
@@ -20,7 +20,7 @@ sap.ui.define([
20
20
  *
21
21
  * @alias sap.ui.layout.changeHandler.MoveSimpleForm
22
22
  * @author SAP SE
23
- * @version 1.103.0
23
+ * @version 1.105.0
24
24
  * @experimental Since 1.34.0
25
25
  */
26
26
  var MoveSimpleForm = {};
@@ -410,11 +410,13 @@ sap.ui.define([
410
410
  Log.error("Element not found. This may be caused by an unstable id!");
411
411
  }
412
412
 
413
- var mChangeData = oChange.getDefinition();
414
- mChangeData.content.targetSelector = mStableChangeInfo.targetSelector;
415
- mChangeData.content.movedElements = mStableChangeInfo.movedElements;
416
- // legacy changes had only a string with <appComponentId>---<uid>
417
- mChangeData.content.newControlId = oModifier.getSelector(oView.createId(uid()), oAppComponent);
413
+ var oContent = {
414
+ targetSelector: mStableChangeInfo.targetSelector,
415
+ movedElements: mStableChangeInfo.movedElements,
416
+ // legacy changes had only a string with <appComponentId>---<uid>
417
+ newControlId: oModifier.getSelector(oView.createId(uid()), oAppComponent)
418
+ };
419
+ oChange.setContent(oContent);
418
420
 
419
421
  if (mStableChangeInfo.source && mStableChangeInfo.target){
420
422
  oChange.addDependentControl(mStableChangeInfo.source, "sourceParent", mPropertyBag);
@@ -469,12 +471,10 @@ sap.ui.define([
469
471
  var oGroupSelector = oMovedElement.source.groupSelector;
470
472
  var oAffectedControlSelector = JsControlTreeModifier.bySelector(oMovedElement.elementSelector, oAppComponent).getParent().getId();
471
473
  if (oChange.getChangeType() === MoveSimpleForm.CHANGE_TYPE_MOVE_FIELD) {
472
- var mPropertyBag = {
473
- modifier: JsControlTreeModifier,
474
- appComponent: oAppComponent
475
- };
476
- oSourceParentContainer = oChange.getDependentControl("sourceParent", mPropertyBag).getParent().getId();
477
- oTargetParentContainer = oChange.getDependentControl("targetParent", mPropertyBag).getParent().getId();
474
+ var oSourceParentTitleElement = JsControlTreeModifier.bySelector(oMovedElement.source.groupSelector, oAppComponent);
475
+ var oTargetParentTitleElement = JsControlTreeModifier.bySelector(oMovedElement.target.groupSelector, oAppComponent);
476
+ oSourceParentContainer = oSourceParentTitleElement ? oSourceParentTitleElement.getParent().getId() : null;
477
+ oTargetParentContainer = oTargetParentTitleElement ? oTargetParentTitleElement.getParent().getId() : null;
478
478
  oGroupSelector = {
479
479
  id: oSourceParentContainer
480
480
  };
@@ -5,11 +5,7 @@
5
5
  */
6
6
 
7
7
  sap.ui.define([
8
- "sap/ui/fl/changeHandler/Base",
9
- "sap/base/Log"
10
8
  ], function(
11
- BaseChangeHandler,
12
- Log
13
9
  ) {
14
10
  "use strict";
15
11
 
@@ -18,7 +14,7 @@ sap.ui.define([
18
14
  *
19
15
  * @alias sap.ui.layout.changeHandler.RenameFormContainer
20
16
  * @author SAP SE
21
- * @version 1.103.0
17
+ * @version 1.105.0
22
18
  * @since 1.48
23
19
  * @private
24
20
  * @experimental Since 1.48. This class is experimental and provides only limited functionality. Also the API might be changed in future.
@@ -42,7 +38,7 @@ sap.ui.define([
42
38
  */
43
39
  RenameFormContainer.applyChange = function(oChangeWrapper, oControl, mPropertyBag) {
44
40
  var oModifier = mPropertyBag.modifier,
45
- oChangeDefinition = oChangeWrapper.getDefinition(),
41
+ oTexts = oChangeWrapper.getTexts(),
46
42
  oRenamedElement = oChangeWrapper.getDependentControl(_CONSTANTS.TARGET_ALIAS, mPropertyBag);
47
43
 
48
44
  return Promise.resolve()
@@ -50,9 +46,8 @@ sap.ui.define([
50
46
  return oModifier.getAggregation(oRenamedElement, "title");
51
47
  })
52
48
  .then(function(oTitle) {
53
- if (oChangeDefinition.texts && oChangeDefinition.texts.formText && this._isProvided(oChangeDefinition.texts.formText.value)) {
54
-
55
- var sValue = oChangeDefinition.texts.formText.value;
49
+ if (oTexts && oTexts.formText && this._isProvided(oTexts.formText.value)) {
50
+ var sValue = oTexts.formText.value;
56
51
  var oRevertDataPromise;
57
52
  if (typeof oTitle === "string") {
58
53
  oRevertDataPromise = Promise.resolve(oModifier.getProperty(oRenamedElement, "title")).then(function(sTitle) {
@@ -66,9 +61,6 @@ sap.ui.define([
66
61
  });
67
62
  }
68
63
  return oRevertDataPromise;
69
- } else {
70
- Log.error("Change does not contain sufficient information to be applied: [" + oChangeDefinition.layer + "]" + oChangeDefinition.namespace + "/" + oChangeDefinition.fileName + "." + oChangeDefinition.fileType);
71
- //however subsequent changes should be applied
72
64
  }
73
65
  }.bind(this));
74
66
  };
@@ -76,14 +68,12 @@ sap.ui.define([
76
68
  /**
77
69
  * Completes the change by adding change handler specific content
78
70
  *
79
- * @param {sap.ui.fl.Change} oChangeWrapper Change wrapper object to be completed
71
+ * @param {sap.ui.fl.Change} oChange Change wrapper object to be completed
80
72
  * @param {object} oSpecificChangeInfo With attribute fieldLabel, the new field label to be included in the change
81
73
  * @param {object} mPropertyBag Map containing the application component
82
74
  * @private
83
75
  */
84
- RenameFormContainer.completeChangeContent = function(oChangeWrapper, oSpecificChangeInfo, mPropertyBag) {
85
- var oChangeDefinition = oChangeWrapper.getDefinition();
86
-
76
+ RenameFormContainer.completeChangeContent = function(oChange, oSpecificChangeInfo, mPropertyBag) {
87
77
  if (!(oSpecificChangeInfo.renamedElement && oSpecificChangeInfo.renamedElement.id)) {
88
78
  throw new Error("Rename of the group cannot be executed: oSpecificChangeInfo.renamedElement attribute required");
89
79
  }
@@ -92,9 +82,8 @@ sap.ui.define([
92
82
  throw new Error("Rename of the group cannot be executed: oSpecificChangeInfo.value attribute required");
93
83
  }
94
84
 
95
- oChangeWrapper.addDependentControl(oSpecificChangeInfo.renamedElement.id, _CONSTANTS.TARGET_ALIAS, mPropertyBag);
96
- BaseChangeHandler.setTextInChange(oChangeDefinition, "formText", oSpecificChangeInfo.value, "XGRP");
97
-
85
+ oChange.addDependentControl(oSpecificChangeInfo.renamedElement.id, _CONSTANTS.TARGET_ALIAS, mPropertyBag);
86
+ oChange.setText("formText", oSpecificChangeInfo.value, "XGRP");
98
87
  };
99
88
 
100
89
  /**
@@ -5,11 +5,9 @@
5
5
  */
6
6
 
7
7
  sap.ui.define([
8
- "sap/ui/fl/changeHandler/Base",
9
8
  "sap/ui/core/util/reflection/JsControlTreeModifier",
10
9
  "sap/base/Log"
11
10
  ], function(
12
- BaseChangeHandler,
13
11
  JsControlTreeModifier,
14
12
  Log
15
13
  ) {
@@ -20,7 +18,7 @@ sap.ui.define([
20
18
  *
21
19
  * @alias sap.ui.layout.changeHandler.RenameForm
22
20
  * @author SAP SE
23
- * @version 1.103.0
21
+ * @version 1.105.0
24
22
  * @since 1.40
25
23
  * @private
26
24
  * @experimental Since 1.40. This class is experimental and provides only limited functionality. Also the API might be changed in future.
@@ -42,25 +40,23 @@ sap.ui.define([
42
40
  var oView = mPropertyBag.view;
43
41
  var oAppComponent = mPropertyBag.appComponent;
44
42
 
45
- var oChangeDefinition = oChangeWrapper.getDefinition();
46
-
43
+ var oTexts = oChangeWrapper.getTexts();
44
+ var oContent = oChangeWrapper.getContent();
47
45
  // !important : sRenameId was used in 1.40, do not remove for compatibility!
48
- var vSelector = oChangeDefinition.content.elementSelector || oChangeDefinition.content.sRenameId;
46
+ var vSelector = oContent.elementSelector || oContent.sRenameId;
49
47
  var oRenamedElement = oModifier.bySelector(vSelector, oAppComponent, oView);
50
48
 
51
- if (oChangeDefinition.texts && oChangeDefinition.texts.formText && this._isProvided(oChangeDefinition.texts.formText.value)) {
49
+ if (oTexts && oTexts.formText && this._isProvided(oTexts.formText.value)) {
52
50
  if (!oControl) {
53
51
  return Promise.reject(new Error("no Control provided for renaming"));
54
52
  }
55
53
 
56
54
  return oModifier.getProperty(oRenamedElement, "text").then(function(sProperty) {
57
55
  oChangeWrapper.setRevertData(sProperty);
58
- var sValue = oChangeDefinition.texts.formText.value;
56
+ var sValue = oTexts.formText.value;
59
57
  oModifier.setProperty(oRenamedElement, "text", sValue);
60
58
  });
61
59
  } else {
62
- Log.error("Change does not contain sufficient information to be applied: [" + oChangeDefinition.layer + "]" + oChangeDefinition.namespace + "/" + oChangeDefinition.fileName + "." + oChangeDefinition.fileType);
63
- //however subsequent changes should be applied
64
60
  return Promise.resolve();
65
61
  }
66
62
  };
@@ -77,12 +73,12 @@ sap.ui.define([
77
73
  RenameForm.revertChange = function(oChangeWrapper, oControl, mPropertyBag) {
78
74
  var sOldText = oChangeWrapper.getRevertData();
79
75
  var oAppComponent = mPropertyBag.appComponent;
80
- var oChangeDefinition = oChangeWrapper.getDefinition();
76
+ var oChangeContent = oChangeWrapper.getContent();
81
77
  var oView = mPropertyBag.view;
82
78
  var oModifier = mPropertyBag.modifier;
83
79
 
84
80
  // !important : sRenameId was used in 1.40, do not remove for compatibility!
85
- var vSelector = oChangeDefinition.content.elementSelector || oChangeDefinition.content.sRenameId;
81
+ var vSelector = oChangeContent.elementSelector || oChangeContent.sRenameId;
86
82
  var oRenamedElement = oModifier.bySelector(vSelector, oAppComponent, oView);
87
83
 
88
84
  if (sOldText || sOldText === "") {
@@ -98,13 +94,13 @@ sap.ui.define([
98
94
  /**
99
95
  * Completes the change by adding change handler specific content
100
96
  *
101
- * @param {sap.ui.fl.Change} oChangeWrapper - change wrapper object to be completed
97
+ * @param {sap.ui.fl.Change} oChange - change wrapper object to be completed
102
98
  * @param {object} oSpecificChangeInfo - with attribute fieldLabel, the new field label to be included in the change
103
99
  * @param {object} mPropertyBag - map containing the application component
104
100
  * @private
105
101
  */
106
- RenameForm.completeChangeContent = function(oChangeWrapper, oSpecificChangeInfo, mPropertyBag) {
107
- var oChangeDefinition = oChangeWrapper.getDefinition();
102
+ RenameForm.completeChangeContent = function(oChange, oSpecificChangeInfo, mPropertyBag) {
103
+ var oContent = {};
108
104
 
109
105
  if (!oSpecificChangeInfo.changeType) {
110
106
  throw new Error("oSpecificChangeInfo.changeType attribute required");
@@ -118,17 +114,19 @@ sap.ui.define([
118
114
  } else if (oSpecificChangeInfo.changeType === "renameTitle") {
119
115
  oStableRenamedElement = oRenamedElement.getTitle();
120
116
  }
121
- oChangeDefinition.content.elementSelector = JsControlTreeModifier.getSelector(oStableRenamedElement, mPropertyBag.appComponent);
122
- oChangeWrapper.addDependentControl(oStableRenamedElement, "elementSelector", mPropertyBag);
117
+ oContent.elementSelector = JsControlTreeModifier.getSelector(oStableRenamedElement, mPropertyBag.appComponent);
118
+ oChange.addDependentControl(oStableRenamedElement, "elementSelector", mPropertyBag);
123
119
  } else {
124
120
  throw new Error("oSpecificChangeInfo.renamedElement attribute required");
125
121
  }
126
122
 
127
123
  if (this._isProvided(oSpecificChangeInfo.value)) {
128
- BaseChangeHandler.setTextInChange(oChangeDefinition, "formText", oSpecificChangeInfo.value, "XFLD");
124
+ oChange.setText("formText", oSpecificChangeInfo.value, "XFLD");
129
125
  } else {
130
126
  throw new Error("oSpecificChangeInfo.value attribute required");
131
127
  }
128
+
129
+ oChange.setContent(oContent);
132
130
  };
133
131
 
134
132
  RenameForm._isProvided = function(sString){
@@ -136,13 +134,13 @@ sap.ui.define([
136
134
  };
137
135
 
138
136
  RenameForm.getChangeVisualizationInfo = function(oChange, oAppComponent) {
139
- var oElementSelector = oChange.getDefinition().content.elementSelector;
137
+ var oElementSelector = oChange.getContent().elementSelector;
140
138
  var oAffectedControlSelector = JsControlTreeModifier.bySelector(oElementSelector, oAppComponent).getParent().getId();
141
139
  return {
142
140
  affectedControls: [oAffectedControlSelector],
143
141
  payload: {
144
142
  originalLabel: oChange.getRevertData(),
145
- newLabel: oChange.getDefinition().texts.formText.value
143
+ newLabel: oChange.getTexts().formText.value
146
144
  }
147
145
  };
148
146
  };
@@ -13,7 +13,7 @@ sap.ui.define([
13
13
  * Change handler for hiding of a control.
14
14
  * @alias sap.ui.fl.changeHandler.HideControl
15
15
  * @author SAP SE
16
- * @version 1.103.0
16
+ * @version 1.105.0
17
17
  * @experimental Since 1.27.0
18
18
  */
19
19
  var UnhideForm = { };
@@ -37,16 +37,15 @@ sap.ui.define([
37
37
  var oView = mPropertyBag.view;
38
38
  var oAppComponent = mPropertyBag.appComponent;
39
39
 
40
- var oChangeDefinition = oChangeWrapper.getDefinition();
41
-
40
+ var oContent = oChangeWrapper.getContent();
42
41
  // in case of custom fields the application needs to be on JS.
43
- // In the other case the visuality of the control will be overriden by the custom field binding afterwards
42
+ // In the other case the visibility of the control will be overridden by the custom field binding afterwards
44
43
  if (_isXmlModifier(mPropertyBag)) {
45
44
  return Promise.reject(Error("Change cannot be applied in XML. Retrying in JS."));
46
45
  }
47
46
 
48
47
  // !important : sUnhideId was used in 1.40, do not remove for compatibility reasons!
49
- var oControlToUnhide = oModifier.bySelector(oChangeDefinition.content.elementSelector || oChangeDefinition.content.sUnhideId, oAppComponent, oView);
48
+ var oControlToUnhide = oModifier.bySelector(oContent.elementSelector || oContent.sUnhideId, oAppComponent, oView);
50
49
  return Promise.resolve()
51
50
  .then(function() {
52
51
  return oModifier.getAggregation(oControl, "content");
@@ -54,7 +53,7 @@ sap.ui.define([
54
53
  .then(function(aContent) {
55
54
  var iStart = -1;
56
55
 
57
- if (oChangeDefinition.changeType === "unhideSimpleFormField") {
56
+ if (oChangeWrapper.getChangeType() === "unhideSimpleFormField") {
58
57
  oChangeWrapper.setRevertData(true);
59
58
  aContent.some(function (oField, index) {
60
59
  if (oField === oControlToUnhide) {
@@ -86,21 +85,22 @@ sap.ui.define([
86
85
  * @public
87
86
  */
88
87
  UnhideForm.completeChangeContent = function(oChangeWrapper, oSpecificChangeInfo, mPropertyBag) {
89
- var oChangeDefinition = oChangeWrapper.getDefinition();
90
88
  //TODO remove sUnhideId when rta is switched to new logic to create reveal changes
89
+ var oContent = {};
91
90
  if (oSpecificChangeInfo.sUnhideId) {
92
91
  var oUnhideElement = sap.ui.getCore().byId(oSpecificChangeInfo.sUnhideId);
93
- oChangeDefinition.content.elementSelector = JsControlTreeModifier.getSelector(oUnhideElement, mPropertyBag.appComponent);
92
+ oContent.elementSelector = JsControlTreeModifier.getSelector(oUnhideElement, mPropertyBag.appComponent);
94
93
  oChangeWrapper.addDependentControl(oUnhideElement, "elementSelector", mPropertyBag);
95
94
  } else if (oSpecificChangeInfo.revealedElementId ) {
96
95
  //translate from FormElement (unstable id) to the label control (stable id and in public aggregation)
97
96
  var oFormElement = sap.ui.getCore().byId(oSpecificChangeInfo.revealedElementId || oSpecificChangeInfo.sUnhideId);
98
97
  var oLabel = oFormElement.getLabel();
99
- oChangeDefinition.content.elementSelector = JsControlTreeModifier.getSelector(oLabel, mPropertyBag.appComponent);
98
+ oContent.elementSelector = JsControlTreeModifier.getSelector(oLabel, mPropertyBag.appComponent);
100
99
  oChangeWrapper.addDependentControl(oLabel, "elementSelector", mPropertyBag);
101
100
  } else {
102
101
  throw new Error("oSpecificChangeInfo.revealedElementId attribute required");
103
102
  }
103
+ oChangeWrapper.setContent(oContent);
104
104
  };
105
105
 
106
106
  /**
@@ -120,10 +120,10 @@ sap.ui.define([
120
120
  var oView = mPropertyBag.view;
121
121
  var oAppComponent = mPropertyBag.appComponent;
122
122
 
123
- var oChangeDefinition = oChangeWrapper.getDefinition();
123
+ var oChangeContent = oChangeWrapper.getContent();
124
124
 
125
125
  // !important : sUnhideId was used in 1.40, do not remove for compatibility reasons!
126
- var oControlToRevertUnhide = oModifier.bySelector(oChangeDefinition.content.elementSelector || oChangeDefinition.content.sUnhideId, oAppComponent, oView);
126
+ var oControlToRevertUnhide = oModifier.bySelector(oChangeContent.elementSelector || oChangeContent.sUnhideId, oAppComponent, oView);
127
127
  return Promise.resolve()
128
128
  .then(function() {
129
129
  return oModifier.getAggregation(oControl, "content");
@@ -131,7 +131,7 @@ sap.ui.define([
131
131
  .then(function(aContent) {
132
132
  var iStart = -1;
133
133
 
134
- if (oChangeDefinition.changeType === "unhideSimpleFormField") {
134
+ if (oChangeWrapper.getChangeType() === "unhideSimpleFormField") {
135
135
  aContent.some(function (oField, index) {
136
136
  if (oField === oControlToRevertUnhide) {
137
137
  iStart = index;
@@ -157,7 +157,7 @@ sap.ui.define([
157
157
 
158
158
  UnhideForm.getChangeVisualizationInfo = function(oChange, oAppComponent) {
159
159
  return {
160
- affectedControls: [JsControlTreeModifier.bySelector(oChange.getDefinition().content.elementSelector, oAppComponent).getParent().getId()]
160
+ affectedControls: [JsControlTreeModifier.bySelector(oChange.getContent().elementSelector, oAppComponent).getParent().getId()]
161
161
  };
162
162
  };
163
163
 
@@ -96,7 +96,7 @@ sap.ui.define([
96
96
  * @see {@link https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout MDN web docs: CSS Grid Layout}
97
97
  *
98
98
  * @author SAP SE
99
- * @version 1.103.0
99
+ * @version 1.105.0
100
100
  *
101
101
  * @extends sap.ui.core.Control
102
102
  * @implements sap.ui.layout.cssgrid.IGridConfigurable
@@ -21,7 +21,7 @@ sap.ui.define([
21
21
  * Applies a sap.ui.layout.cssgrid.GridSettings to a provided DOM element or Control.
22
22
  *
23
23
  * @author SAP SE
24
- * @version 1.103.0
24
+ * @version 1.105.0
25
25
  *
26
26
  * @extends sap.ui.layout.cssgrid.GridLayoutBase
27
27
  *
@@ -48,7 +48,7 @@ sap.ui.define([
48
48
  * Applies a sap.ui.layout.cssgrid.GridSettings to a provided DOM element or Control.
49
49
  *
50
50
  * @author SAP SE
51
- * @version 1.103.0
51
+ * @version 1.105.0
52
52
  *
53
53
  * @extends sap.ui.layout.cssgrid.GridLayoutBase
54
54
  *
@@ -29,7 +29,7 @@ sap.ui.define([
29
29
  * Holds layout data for a grid item.
30
30
  *
31
31
  * @extends sap.ui.core.LayoutData
32
- * @version 1.103.0
32
+ * @version 1.105.0
33
33
  *
34
34
  * @constructor
35
35
  * @public
@@ -36,7 +36,7 @@ sap.ui.define([
36
36
  * Applies a sap.ui.layout.cssgrid.GridSettings to a provided DOM element or Control.
37
37
  *
38
38
  * @author SAP SE
39
- * @version 1.103.0
39
+ * @version 1.105.0
40
40
  *
41
41
  * @extends sap.ui.base.ManagedObject
42
42
  *
@@ -20,7 +20,7 @@ sap.ui.define([
20
20
  *
21
21
  * @extends sap.ui.base.Object
22
22
  *
23
- * @version 1.103.0
23
+ * @version 1.105.0
24
24
  * @alias sap.ui.layout.cssgrid.GridLayoutDelegate
25
25
  * @public
26
26
  */
@@ -21,7 +21,7 @@ sap.ui.define([
21
21
  * Have to possibility to hold multiple sap.ui.layout.cssgrid.GridSettings and apply the currently active GridSettings.
22
22
  *
23
23
  * @author SAP SE
24
- * @version 1.103.0
24
+ * @version 1.105.0
25
25
  *
26
26
  * @extends sap.ui.layout.cssgrid.GridLayoutBase
27
27
  *
@@ -20,7 +20,7 @@ sap.ui.define([
20
20
  * Holds a set of CSS display:grid properties
21
21
  *
22
22
  * @author SAP SE
23
- * @version 1.103.0
23
+ * @version 1.105.0
24
24
  *
25
25
  * @extends sap.ui.base.ManagedObject
26
26
  *
@@ -20,7 +20,7 @@ sap.ui.define([
20
20
  * Holds layout data for an item inside a responsive column layout.
21
21
  *
22
22
  * @extends sap.ui.core.LayoutData
23
- * @version 1.103.0
23
+ * @version 1.105.0
24
24
  *
25
25
  * @since 1.72
26
26
  * @constructor
@@ -33,7 +33,7 @@ sap.ui.define([
33
33
  * Grid row's height is dynamically determined by the height of the highest grid element on this row.
34
34
  *
35
35
  * @author SAP SE
36
- * @version 1.103.0
36
+ * @version 1.105.0
37
37
  *
38
38
  * @extends sap.ui.layout.cssgrid.GridLayoutBase
39
39
  *