@openui5/sap.ui.fl 1.92.0 → 1.95.0

package/src/sap/ui/fl/write/_internal/fieldExtensibility/cap/editor/propertyEditor/dateTimeEditor/DateTimeEditor.js

@@ -0,0 +1,38 @@
+/*!
+ * OpenUI5
+ * (c) Copyright 2009-2021 SAP SE or an SAP affiliate company.
+ * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
+ */
+
+// Customization of the default datetime editor to support custom output formats
+// To be implemented in base class
+
+sap.ui.define([
+	"sap/ui/integration/designtime/baseEditor/propertyEditor/dateTimeEditor/DateTimeEditor"
+], function (
+	BaseDateTimeEditor
+) {
+	"use strict";
+
+	var DateTimeEditor = BaseDateTimeEditor.extend("sap.ui.fl.write._internal.fieldExtensibility.cap.editor.propertyEditor.dateTimeEditor.DateTimeEditor", {
+		xmlFragment: "sap.ui.integration.designtime.baseEditor.propertyEditor.dateTimeEditor.DateTimeEditor",
+		metadata: {
+			library: "sap.ui.fl"
+		},
+		renderer: BaseDateTimeEditor.getMetadata().getRenderer().render
+	});
+
+	DateTimeEditor.prototype._parse = function (sValue) {
+		if (sValue === "") {
+			return undefined;
+		}
+		var sParsedDate = new Date(sValue);
+
+		// TODO: For now use a hardcoded format, move to default config later
+		return this._isValidDate(sParsedDate)
+			? sParsedDate.toISOString().split(".")[0] + "Z" // Cut ms
+			: sValue;
+	};
+
+	return DateTimeEditor;
+});

package/src/sap/ui/fl/write/_internal/fieldExtensibility/cap/editor/propertyEditor/rangeEditor/RangeEditor.fragment.xml

@@ -0,0 +1,22 @@
+<core:FragmentDefinition
+	xmlns="sap.m"
+	xmlns:core="sap.ui.core"
+	xmlns:baseEditor="sap.ui.integration.designtime.baseEditor"
+>
+	<HBox>
+		<baseEditor:PropertyEditor
+			init="wrapperInit"
+			config="{contentModel>/0/config}"
+			value="{contentModel>/0/value}"
+			renderLabel="false"
+			valueChange="_onChange"
+		/>
+		<baseEditor:PropertyEditor
+			init="wrapperInit"
+			config="{contentModel>/1/config}"
+			value="{contentModel>/1/value}"
+			renderLabel="false"
+			valueChange="_onChange"
+		/>
+	</HBox>
+</core:FragmentDefinition>

package/src/sap/ui/fl/write/_internal/fieldExtensibility/cap/editor/propertyEditor/rangeEditor/RangeEditor.js

@@ -0,0 +1,84 @@
+/*!
+ * OpenUI5
+ * (c) Copyright 2009-2021 SAP SE or an SAP affiliate company.
+ * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
+ */
+sap.ui.define([
+	"sap/ui/integration/designtime/baseEditor/propertyEditor/BasePropertyEditor",
+	"sap/ui/model/json/JSONModel"
+], function (
+	BasePropertyEditor,
+	JSONModel
+) {
+	"use strict";
+
+	/**
+	 * @class
+	 * Constructor for a new <code>RangeEditor</code>.
+	 *
+	 * @extends sap.ui.integration.designtime.baseEditor.propertyEditor.BasePropertyEditor
+	 * @alias sap.ui.fl.write._internal.fieldExtensibility.cap.editor.propertyEditor.rangeEditor.RangeEditor
+	 * @author SAP SE
+	 * @since 1.93
+	 * @version 1.95.0
+	 *
+	 * @private
+	 * @experimental 1.93
+	 * @ui5-restricted sap.ui.fl
+	 */
+	var RangeEditor = BasePropertyEditor.extend("sap.ui.fl.write._internal.fieldExtensibility.cap.editor.propertyEditor.rangeEditor.RangeEditor", {
+		xmlFragment: "sap.ui.fl.write._internal.fieldExtensibility.cap.editor.propertyEditor.rangeEditor.RangeEditor",
+		metadata: {
+			library: "sap.ui.fl"
+		},
+		renderer: BasePropertyEditor.getMetadata().getRenderer().render
+	});
+
+	RangeEditor.configMetadata = Object.assign({}, BasePropertyEditor.configMetadata, {
+		rangeType: {
+			defaultValue: "string"
+		}
+	});
+
+	RangeEditor.prototype.init = function() {
+		BasePropertyEditor.prototype.init.apply(this, arguments);
+		this._oContentModel = new JSONModel();
+		this._oContentModel.setDefaultBindingMode("OneWay");
+		this.setModel(this._oContentModel, "contentModel");
+	};
+
+	RangeEditor.prototype.getExpectedWrapperCount = function () {
+		return 2;
+	};
+
+	RangeEditor.prototype.setConfig = function() {
+		// RangeType might change, make sure to update nested editors
+		BasePropertyEditor.prototype.setConfig.apply(this, arguments);
+		this.setValue(this.getValue());
+	};
+
+	RangeEditor.prototype.setValue = function(aValues) {
+		BasePropertyEditor.prototype.setValue.apply(this, arguments);
+		var oConfig = {
+			type: this.getConfig().rangeType
+		};
+		var aRangeValues = Array.isArray(aValues) ? aValues : [];
+		this._oContentModel.setData([{
+			value: aRangeValues[0],
+			config: Object.assign({ index: 0 }, oConfig)
+		}, {
+			value: aRangeValues[1],
+			config: Object.assign({ index: 1 }, oConfig)
+		}]);
+	};
+
+	RangeEditor.prototype._onChange = function(oEvent) {
+		var vValue = oEvent.getParameter("value");
+		var iIndex = oEvent.getSource().getConfig().index;
+		var aNewValue = (this.getValue() || []).slice();
+		aNewValue[iIndex] = vValue;
+		this.setValue(aNewValue);
+	};
+
+	return RangeEditor;
+});

package/src/sap/ui/fl/write/_internal/fieldExtensibility/cap/editor/propertyEditor/timeEditor/TimeEditor.fragment.xml

@@ -0,0 +1,10 @@
+<core:FragmentDefinition
+	xmlns="sap.m"
+	xmlns:core="sap.ui.core"
+>
+	<TimePicker
+		value="{displayValue}"
+		valueFormat="HH:mm:ss"
+		change="_onChange"
+	/>
+</core:FragmentDefinition>

package/src/sap/ui/fl/write/_internal/fieldExtensibility/cap/editor/propertyEditor/timeEditor/TimeEditor.js

@@ -0,0 +1,70 @@
+/*!
+ * OpenUI5
+ * (c) Copyright 2009-2021 SAP SE or an SAP affiliate company.
+ * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
+ */
+sap.ui.define([
+	"sap/ui/integration/designtime/baseEditor/propertyEditor/BasePropertyEditor",
+	"sap/ui/integration/designtime/baseEditor/propertyEditor/dateEditor/DateEditor",
+	"sap/ui/core/format/DateFormat"
+], function (
+	BasePropertyEditor,
+	DateEditor,
+	DateFormat
+) {
+	"use strict";
+
+	/**
+	 * @class
+	 * Constructor for a new <code>TimeEditor</code>.
+	 *
+	 * @extends sap.ui.integration.designtime.baseEditor.propertyEditor.dateEditor.DateEditor
+	 * @alias sap.ui.fl.write._internal.fieldExtensibility.cap.editor.propertyEditor.timeEditor.TimeEditor
+	 * @author SAP SE
+	 * @since 1.93
+	 * @version 1.95.0
+	 *
+	 * @private
+	 * @experimental 1.93
+	 * @ui5-restricted sap.ui.fl
+	 */
+	var TimeEditor = DateEditor.extend("sap.ui.fl.write._internal.fieldExtensibility.cap.editor.propertyEditor.timeEditor.TimeEditor", {
+		xmlFragment: "sap.ui.fl.write._internal.fieldExtensibility.cap.editor.propertyEditor.timeEditor.TimeEditor",
+		metadata: {
+			library: "sap.ui.fl"
+		},
+		renderer: BasePropertyEditor.getMetadata().getRenderer().render
+	});
+
+	TimeEditor.prototype.getDefaultValidators = function () {
+		return Object.assign(
+			{},
+			BasePropertyEditor.prototype.getDefaultValidators.call(this)
+		);
+	};
+
+	TimeEditor.prototype.formatValue = function (sValue) {
+		return sValue;
+	};
+
+	TimeEditor.prototype._parse = function (sValue) {
+		if (sValue === "") {
+			return undefined;
+		}
+
+		// For now use a hardcoded format, move to default config later
+		var oTimeFormatterInstance = DateFormat.getTimeInstance({
+			pattern: "HH:mm:ss"
+		});
+		var oParsedDate = oTimeFormatterInstance.parse(sValue);
+		return this._isValidDate(oParsedDate)
+			? oTimeFormatterInstance.format(oParsedDate)
+			: sValue;
+	};
+
+	TimeEditor.prototype.getFormatterInstance = function () {
+		return DateFormat.getTimeInstance();
+	};
+
+	return TimeEditor;
+});

package/src/sap/ui/fl/write/_internal/flexState/FlexObjectState.js

@@ -10,6 +10,7 @@ sap.ui.define([
 	"sap/ui/fl/apply/_internal/flexState/ManifestUtils",
 	"sap/ui/fl/apply/_internal/ChangesController",
 	"sap/ui/fl/write/_internal/flexState/compVariants/CompVariantState",
+	"sap/ui/fl/apply/_internal/flexState/compVariants/CompVariantMerger",
 	"sap/ui/fl/ChangePersistenceFactory",
 	"sap/ui/fl/LayerUtils",
 	"sap/ui/fl/apply/_internal/flexState/compVariants/Utils",
@@ -20,6 +21,7 @@ sap.ui.define([
 	ManifestUtils,
 	ChangesController,
 	CompVariantState,
+	CompVariantMerger,
 	ChangePersistenceFactory,
 	LayerUtils,
 	CompVariantsUtils,
@@ -30,7 +32,7 @@ sap.ui.define([
 	/**
 	 * @namespace sap.ui.fl.apply._internal.flexState.FlexObjectState
 	 * @since 1.83
-	 * @version 1.92.0
+	 * @version 1.95.0
 	 * @private
 	 * @ui5-restricted sap.ui.fl
 	 */
@@ -50,6 +52,17 @@ sap.ui.define([
 	function getCompVariantEntities(mPropertyBag) {
 		var mCompEntities = FlexState.getCompVariantsMap(mPropertyBag.reference);
 		var aEntities = [];
+		//Enhance CompVariantsMap with external data and standard variant after FlexState has been cleared and reinitialized
+		if (mPropertyBag.invalidateCache) {
+			var oDataToRestore = FlexState.getInitialNonFlCompVariantData(mPropertyBag.reference);
+			if (oDataToRestore) {
+				Object.keys(oDataToRestore).forEach(function(sPersistencyKey) {
+					mCompEntities._initialize(sPersistencyKey, oDataToRestore[sPersistencyKey].variants);
+					CompVariantMerger.merge(sPersistencyKey, mCompEntities[sPersistencyKey], oDataToRestore[sPersistencyKey].standardVariant);
+				});
+			}
+		}
+
 		for (var sPersistencyKey in mCompEntities) {
 			var mCompVariantsOfPersistencyKey = mCompEntities[sPersistencyKey];
 			for (var sId in mCompVariantsOfPersistencyKey.byId) {
@@ -108,15 +121,8 @@ sap.ui.define([
 	FlexObjectState.getFlexObjects = function (mPropertyBag) {
 		return initFlexStateAndSetReference(mPropertyBag)
 			.then(function () {
-				var aCompVariantEntities = getCompVariantEntities(mPropertyBag);
-				var aChangePersistenceEntities = getChangePersistenceEntities(mPropertyBag);
-
-				return Promise.all([
-					aCompVariantEntities,
-					aChangePersistenceEntities
-				]).then(function (aEntities) {
-					return aEntities[0] // compVariant entities (changes of type defaultVariant / standardVariant, variant)
-						.concat(aEntities[1]); // ChangePersistence entities (change, ctrl_variant, ctrl_variant_change, ctrl_variant_management_change)
+				return getChangePersistenceEntities(mPropertyBag).then(function (aChangePersistenceEntities) {
+					return getCompVariantEntities(mPropertyBag).concat(aChangePersistenceEntities);
 				});
 			});
 	};

package/src/sap/ui/fl/write/_internal/flexState/compVariants/CompVariantState.js

@@ -220,7 +220,7 @@ sap.ui.define([
 	 *
 	 * @namespace sap.ui.fl.write._internal.flexState.compVariants.CompVariantState
 	 * @since 1.83
-	 * @version 1.92.0
+	 * @version 1.95.0
 	 * @private
 	 * @ui5-restricted sap.ui.fl
 	 */
@@ -383,6 +383,7 @@ sap.ui.define([
 	 * @param {string} mPropertyBag.persistencyKey - Key of the variant management
 	 * @param {string} mPropertyBag.id - ID of the variant
 	 * @param {string} [mPropertyBag.packageName] - ID of the package in which the update should be transported - only valid for sap-ui-layer=VENDOR use case
+	 * @param {string} [mPropertyBag.transportId] - ID of the transport in which the update should be transported
 	 * @param {object} [mPropertyBag.revert=false] - Flag if the update is a revert operation
 	 * @param {object} [mPropertyBag.name] - Title of the variant
 	 * @param {object} [mPropertyBag.content] - Content of the new change
@@ -397,7 +398,7 @@ sap.ui.define([
 	CompVariantState.updateVariant = function (mPropertyBag) {
 		function variantCanBeUpdated(oVariant, sLayer) {
 			var bSameLayer = oVariant.getLayer() === sLayer;
-			var sPackageName = oVariant.getDefinition().packageName;
+			var sPackageName = oVariant.getPackage();
 			var bNotTransported = !sPackageName || sPackageName === "$TMP";
 			// in case changes were already done within the layer, no update of the variant can be done to safeguard the execution order
 			var bIsChangedOnLayer = oVariant.getChanges().some(function (oChange) {
@@ -446,8 +447,8 @@ sap.ui.define([
 			if (mPropertyBag.name) {
 				oVariant.storeName(mPropertyBag.name);
 			}
-			if (mPropertyBag.packageName) {
-				oVariant.setRequest(mPropertyBag.packageName);
+			if (mPropertyBag.transportId) {
+				oVariant.setRequest(mPropertyBag.transportId);
 			}
 			oVariant.storeContent(mPropertyBag.content || oVariant.getContent());
 		}
@@ -488,6 +489,9 @@ sap.ui.define([
 				};
 			}
 			oChange.setContent(oChangeContent);
+			if (mPropertyBag.transportId) {
+				oChange.setRequest(mPropertyBag.transportId);
+			}
 			CompVariantMerger.applyChangeOnVariant(oVariant, oChange);
 			storeRevertDataInVariant(mPropertyBag, oVariant, CompVariantState.operationType.UpdateVariantViaChangeUpdate, oChange);
 		}
@@ -531,6 +535,9 @@ sap.ui.define([
 			}
 
 			var oChange = new Change(oChangeDefinition);
+			if (mPropertyBag.transportId) {
+				oChange.setRequest(mPropertyBag.transportId);
+			}
 			addChange(oChange);
 			storeRevertDataInVariant(mPropertyBag, oVariant, CompVariantState.operationType.NewChange, oChange);
 			CompVariantMerger.applyChangeOnVariant(oVariant, oChange);

package/src/sap/ui/fl/write/_internal/transport/TransportSelection.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @alias sap.ui.fl.write._internal.transport.TransportSelection
 	 * @constructor
 	 * @author SAP SE
-	 * @version 1.92.0
+	 * @version 1.95.0
 	 * @since 1.74.0
 	 * Helper object to select an ABAP transport for an LREP object. This is not a generic utility to select a transport request, but part
 	 *        of the SmartVariant control.

package/src/sap/ui/fl/write/_internal/transport/Transports.js

@@ -28,7 +28,7 @@ sap.ui.define([
 	 * Entity that handles ABAP transport related information.
 	 * @alias sap.ui.fl.write._internal.transport.Transports
 	 * @author SAP SE
-	 * @version 1.92.0
+	 * @version 1.95.0
 	 * @since 1.74.0
 	 * @private
 	 * @ui5-restricted sap.ui.fl.write._internal.transport

package/src/sap/ui/fl/write/api/ChangesWriteAPI.js

@@ -125,7 +125,7 @@ sap.ui.define([
 		 * @ui5-restricted
 		 */
 		apply: function(mPropertyBag) {
-			if (!mPropertyBag.element instanceof Element) {
+			if (!(mPropertyBag.element instanceof Element)) {
 				return Promise.reject("Please provide an Element");
 			}
 

package/src/sap/ui/fl/write/api/FeaturesAPI.js

@@ -111,6 +111,7 @@ sap.ui.define([
 					return oSettings.isKeyUserTranslationEnabled();
 				});
 			}
+			return Promise.resolve(false);
 		},
 
 		/**

package/src/sap/ui/fl/write/api/FieldExtensibility.js

@@ -5,9 +5,13 @@
  */
 
 sap.ui.define([
-	"sap/ui/fl/write/_internal/fieldExtensibility/ABAPAccess"
+	"sap/ui/fl/write/_internal/fieldExtensibility/ABAPAccess",
+	"sap/ui/fl/write/_internal/fieldExtensibility/cap/CAPAccess",
+	"sap/base/util/UriParameters"
 ], function(
-	ABAPAccess
+	ABAPAccess,
+	CAPAccess,
+	UriParameters
 ) {
 	"use strict";
 
@@ -16,7 +20,7 @@ sap.ui.define([
 	 *
 	 * @namespace sap.ui.fl.write.api.FieldExtensibility
 	 * @since 1.87
-	 * @version 1.92.0
+	 * @version 1.95.0
 	 * @private
 	 * @ui5-restricted sap.ui.fl, sap.ui.rta
 	 */
@@ -27,15 +31,21 @@ sap.ui.define([
 	// we can add parameters here, but the assumption is that this is not dependent on a single control
 	function getImplementationForCurrentScenario() {
 		if (!_oCurrentScenario) {
-			// currently there is only one case, but here would be the differentiation between the scenarios (CAP, ABAP, ...)
-			_oCurrentScenario = ABAPAccess;
+			var oUriParams = UriParameters.fromQuery(window.location.search);
+			if (oUriParams.get("sap-ui-fl-xx-capScenario") === "true") {
+				_oCurrentScenario = CAPAccess;
+			} else {
+				_oCurrentScenario = ABAPAccess;
+			}
 		}
 		return _oCurrentScenario;
 	}
 
-	function callFunctionInImplementation(sFunctionName, vArgs) {
+	function callFunctionInImplementation() {
+		var aArgs = Array.from(arguments);
+		var sFunctionName = aArgs.shift();
 		var oImplementation = getImplementationForCurrentScenario();
-		return Promise.resolve(oImplementation[sFunctionName](vArgs));
+		return Promise.resolve(oImplementation[sFunctionName].apply(null, aArgs));
 	}
 
 	/**
@@ -102,8 +112,13 @@ sap.ui.define([
 	 *
 	 * @param {object} oExtensibilityInfo - Information about the extension data. Should be the return value of <code>FieldExtensibility.getExtensionData</code>
 	 */
-	FieldExtensibility.onTriggerCreateExtensionData = function(oExtensibilityInfo) {
-		return callFunctionInImplementation("onTriggerCreateExtensionData", oExtensibilityInfo);
+	FieldExtensibility.onTriggerCreateExtensionData = function(oExtensibilityInfo, sRtaStyleClassName) {
+		return callFunctionInImplementation("onTriggerCreateExtensionData", oExtensibilityInfo, sRtaStyleClassName);
+	};
+
+	// Resets the current scenario for testing purposes
+	FieldExtensibility._resetCurrentScenario = function() {
+		_oCurrentScenario = null;
 	};
 
 	return FieldExtensibility;

package/src/sap/ui/fl/write/api/LocalResetAPI.js

@@ -88,16 +88,17 @@ sap.ui.define([
 
 		var aRevertQueue = aReverseChanges.map(function (oChange) {
 			var oControl = JsControlTreeModifier.bySelector(oChange.getSelector(), oAppComponent);
-			PersistenceWriteAPI.remove({
-				change: oChange,
-				selector: oControl
-			});
-
-			oChange.setQueuedForRevert();
 			return function () {
-				return ChangesWriteAPI.revert({
+				return PersistenceWriteAPI.remove({
 					change: oChange,
-					element: oControl
+					selector: oControl
+				})
+				.then(function () {
+					oChange.setQueuedForRevert();
+					return ChangesWriteAPI.revert({
+						change: oChange,
+						element: oControl
+					});
 				});
 			};
 		});

package/src/sap/ui/fl/write/api/PersistenceWriteAPI.js

@@ -141,15 +141,15 @@ sap.ui.define([
 			var bIsLayerTransportable = mPropertyBag.layer !== Layer.USER && mPropertyBag.layer !== Layer.PUBLIC;
 			// By default:
 			// Reset is enabled if there is change
-			// Publish is enabled if there is change + layer is transportable + system is enabled for publish
+			// Publish is by default disabled
 			// All contexts provided is true to not trigger a reload and add additional parameter to flex/data request
 			var oFlexInfo = {
 				isResetEnabled: bHasChanges,
-				isPublishEnabled: bHasChanges && bIsLayerTransportable && bIsPublishAvailable,
+				isPublishEnabled: false,
 				allContextsProvided: true
 			};
 			// If there is change and the layer is transportable , the request to back end is always necessary
-			// because of control variant reset logic through setVisible change
+			// because of control variant reset logic through setVisible change and app descriptor changes
 			if (bIsLayerTransportable) {
 				return ChangesController.getFlexControllerInstance(mPropertyBag.selector).getResetAndPublishInfo(mPropertyBag)
 					.then(function(oResponse) {
@@ -157,7 +157,7 @@ sap.ui.define([
 						oFlexInfo.isResetEnabled = oResponse.isResetEnabled;
 						// Together with publish info from back end,
 						// system setting info for publish availability also need to be checked
-						oFlexInfo.isPublishEnabled = oFlexInfo.isPublishEnabled && oResponse.isPublishEnabled;
+						oFlexInfo.isPublishEnabled = bIsPublishAvailable && oResponse.isPublishEnabled;
 						return oFlexInfo;
 					})
 					.catch(function(oError) {
@@ -252,32 +252,38 @@ sap.ui.define([
 	 * @param {object} mPropertyBag - Object with parameters as properties
 	 * @param {sap.ui.fl.Change} mPropertyBag.change - Change to be removed
 	 * @param {sap.ui.fl.Selector} mPropertyBag.selector - To retrieve the associated flex persistence
-	 *
+	 * @returns {Promise} resolves when changes are removed
 	 * @private
 	 * @ui5-restricted
 	 */
 	PersistenceWriteAPI.remove = function(mPropertyBag) {
-		if (!mPropertyBag.selector) {
-			throw new Error("An invalid selector was passed so change could not be removed with id: " + mPropertyBag.change.getId());
-		}
-		var oAppComponent = ChangesController.getAppComponentForSelector(mPropertyBag.selector);
-		if (!oAppComponent) {
-			throw new Error("Invalid application component for selector, change could not be removed with id: " + mPropertyBag.change.getId());
-		}
-		// descriptor change
-		if (isDescriptorChange(mPropertyBag.change)) {
-			var oDescriptorFlexController = ChangesController.getDescriptorFlexControllerInstance(oAppComponent);
-			oDescriptorFlexController.deleteChange(mPropertyBag.change, oAppComponent);
-			return;
-		}
-		var oElement = JsControlTreeModifier.bySelector(mPropertyBag.change.getSelector(), oAppComponent);
-		var oFlexController = ChangesController.getFlexControllerInstance(oAppComponent);
-		// remove custom data for flex change
-		if (oElement) {
-			FlexCustomData.destroyAppliedCustomData(oElement, mPropertyBag.change, JsControlTreeModifier);
-		}
-		// delete from flex persistence map
-		oFlexController.deleteChange(mPropertyBag.change, oAppComponent);
+		var oFlexController;
+		var oAppComponent;
+		return Promise.resolve()
+			.then(function () {
+				if (!mPropertyBag.selector) {
+					return Promise.reject(new Error("An invalid selector was passed so change could not be removed with id: " + mPropertyBag.change.getId()));
+				}
+				oAppComponent = ChangesController.getAppComponentForSelector(mPropertyBag.selector);
+				if (!oAppComponent) {
+					return Promise.reject(new Error("Invalid application component for selector, change could not be removed with id: " + mPropertyBag.change.getId()));
+				}
+				// descriptor change
+				if (isDescriptorChange(mPropertyBag.change)) {
+					var oDescriptorFlexController = ChangesController.getDescriptorFlexControllerInstance(oAppComponent);
+					oDescriptorFlexController.deleteChange(mPropertyBag.change, oAppComponent);
+					return undefined;
+				}
+				var oElement = JsControlTreeModifier.bySelector(mPropertyBag.change.getSelector(), oAppComponent);
+				oFlexController = ChangesController.getFlexControllerInstance(oAppComponent);
+				// remove custom data for flex change
+				if (oElement) {
+					FlexCustomData.sync.destroyAppliedCustomData(oElement, mPropertyBag.change, JsControlTreeModifier);
+				}
+				// delete from flex persistence map
+				oFlexController.deleteChange(mPropertyBag.change, oAppComponent);
+				return undefined;
+			});
 	};
 
 	/**

package/src/sap/ui/fl/write/api/SmartVariantManagementWriteAPI.js

@@ -84,6 +84,7 @@ sap.ui.define([
 		 * 			sap.ui.comp.smartchart.SmartChart} mPropertyBag.control - Variant management control for which the variant should be updated
 		 * @param {string} mPropertyBag.id - ID of the variant
 		 * @param {string} [mPropertyBag.packageName] - ID of the package in which the update should be transported - only valid for sap-ui-layer=VENDOR use case
+		 * @param {string} [mPropertyBag.transportId] - ID of the transport in which the update should be assigned
 		 * @param {object} [mPropertyBag.name] - Title of the variant
 		 * @param {object} [mPropertyBag.content] - Content of the new change
 		 * @param {object} [mPropertyBag.favorite] - Flag if the variant should be flagged as a favorite