@openui5/sap.ui.fl 1.115.1 → 1.116.0

package/src/sap/ui/fl/FlexController.js

@@ -41,35 +41,36 @@ sap.ui.define([
 
 	function revertChangesAndUpdateVariantModel(oComponent, bSkipUrlUpdate, aChanges) {
 		return Promise.resolve()
-			.then(function() {
-				if (aChanges.length !== 0) {
-					// Always revert changes in reverse order
-					aChanges.reverse();
-					return Reverter.revertMultipleChanges(aChanges, {
-						appComponent: oComponent,
-						modifier: JsControlTreeModifier,
-						flexController: this
-					});
-				}
-			}.bind(this))
-			.then(function() {
-				if (oComponent) {
-					var oModel = oComponent.getModel(ControlVariantApplyAPI.getVariantModelName());
-					if (oModel) {
-						// Temporary fix, parameters generally should not be removed
-						if (!bSkipUrlUpdate) {
-							URLHandler.update({
-								parameters: [],
-								updateURL: true,
-								updateHashEntry: true,
-								model: oModel
-							});
-						}
+		.then(function() {
+			if (aChanges.length !== 0) {
+				// Always revert changes in reverse order
+				aChanges.reverse();
+				return Reverter.revertMultipleChanges(aChanges, {
+					appComponent: oComponent,
+					modifier: JsControlTreeModifier,
+					flexController: this
+				});
+			}
+			return undefined;
+		}.bind(this))
+		.then(function() {
+			if (oComponent) {
+				var oModel = oComponent.getModel(ControlVariantApplyAPI.getVariantModelName());
+				if (oModel) {
+					// Temporary fix, parameters generally should not be removed
+					if (!bSkipUrlUpdate) {
+						URLHandler.update({
+							parameters: [],
+							updateURL: true,
+							updateHashEntry: true,
+							model: oModel
+						});
 					}
 				}
+			}
 
-				return aChanges;
-			});
+			return aChanges;
+		});
 	}
 
 	/**
@@ -81,7 +82,7 @@ sap.ui.define([
 	 * @alias sap.ui.fl.FlexController
 	 * @experimental Since 1.27.0
 	 * @author SAP SE
-	 * @version 1.115.1
+	 * @version 1.116.0
 	 */
 	var FlexController = function(sComponentName) {
 		this._oChangePersistence = undefined;
@@ -133,11 +134,15 @@ sap.ui.define([
 	 */
 	FlexController.prototype.createBaseChange = function(oChangeSpecificData, oAppComponent) {
 		if (!oAppComponent) {
-			throw new Error("No application component found. To offer flexibility a valid relation to its owning component must be present.");
+			throw new Error(
+				"No application component found. To offer flexibility a valid relation to its owning component must be present."
+			);
 		}
 
-		oChangeSpecificData.reference = this.getComponentName(); //in this case the component name can also be the value of sap-app-id
-		oChangeSpecificData.packageName = "$TMP"; // first a flex change is always local, until all changes of a component are made transportable
+		 // in this case the component name can also be the value of sap-app-id
+		oChangeSpecificData.reference = this.getComponentName();
+		// first a flex change is always local, until all changes of a component are made transportable
+		oChangeSpecificData.packageName = "$TMP";
 
 		var oChange = FlexObjectFactory.createUIChange(oChangeSpecificData);
 
@@ -154,25 +159,31 @@ sap.ui.define([
 
 		var oChange = this.createBaseChange(oChangeSpecificData, oAppComponent);
 
-		return ChangeHandlerStorage.getChangeHandler(oChange.getChangeType(), sControlType, oControl, JsControlTreeModifier, oChange.getLayer())
-			.then(function(oChangeHandler) {
-				if (oChangeHandler) {
-					return oChangeHandler.completeChangeContent(oChange, oChangeSpecificData, {
-						modifier: JsControlTreeModifier,
-						appComponent: oAppComponent,
-						view: Utils.getViewForControl(oControl)
-					});
-				}
-				throw new Error("Change handler could not be retrieved for change " + JSON.stringify(oChangeSpecificData) + ".");
-			})
-			.then(function () {
-				// completeChangeContent changes the content and might make it dirty
-				oChange.setState(States.LifecycleState.NEW);
-				return oChange;
-			})
-			.catch(function(oError) {
-				return Promise.reject(oError);
-			});
+		return ChangeHandlerStorage.getChangeHandler(
+			oChange.getChangeType(),
+			sControlType,
+			oControl,
+			JsControlTreeModifier,
+			oChange.getLayer()
+		)
+		.then(function(oChangeHandler) {
+			if (oChangeHandler) {
+				return oChangeHandler.completeChangeContent(oChange, oChangeSpecificData, {
+					modifier: JsControlTreeModifier,
+					appComponent: oAppComponent,
+					view: Utils.getViewForControl(oControl)
+				});
+			}
+			throw new Error("Change handler could not be retrieved for change " + JSON.stringify(oChangeSpecificData) + ".");
+		})
+		.then(function() {
+			// completeChangeContent changes the content and might make it dirty
+			oChange.setState(States.LifecycleState.NEW);
+			return oChange;
+		})
+		.catch(function(oError) {
+			return Promise.reject(oError);
+		});
 	};
 
 	/**
@@ -189,21 +200,21 @@ sap.ui.define([
 	 */
 	FlexController.prototype.createChangeWithExtensionPointSelector = function(oChangeSpecificData, mExtensionPointReference) {
 		return Promise.resolve()
-			.then(function() {
-				if (!mExtensionPointReference) {
-					throw new Error("A flexibility change on extension point cannot be created without a valid extension point reference.");
-				}
-				var oView = mExtensionPointReference.view;
-				var oAppComponent = Utils.getAppComponentForControl(oView);
-				oChangeSpecificData.selector = {
-					name: mExtensionPointReference.name,
-					viewSelector: JsControlTreeModifier.getSelector(oView.getId(), oAppComponent)
-				};
-				return oAppComponent;
-			})
-			.then(function(oAppComponent) {
-				return this._createChange(oChangeSpecificData, oAppComponent);
-			}.bind(this));
+		.then(function() {
+			if (!mExtensionPointReference) {
+				throw new Error("A flexibility change on extension point cannot be created without a valid extension point reference.");
+			}
+			var oView = mExtensionPointReference.view;
+			var oAppComponent = Utils.getAppComponentForControl(oView);
+			oChangeSpecificData.selector = {
+				name: mExtensionPointReference.name,
+				viewSelector: JsControlTreeModifier.getSelector(oView.getId(), oAppComponent)
+			};
+			return oAppComponent;
+		})
+		.then(function(oAppComponent) {
+			return this._createChange(oChangeSpecificData, oAppComponent);
+		}.bind(this));
 	};
 
 	/**
@@ -219,32 +230,25 @@ sap.ui.define([
 	 * @public
 	 */
 	FlexController.prototype.createChangeWithControlSelector = function(oChangeSpecificData, oControl) {
-		var oAppComponent;
-		return new Utils.FakePromise()
-			.then(function() {
-				if (!oControl) {
-					throw new Error("A flexibility change cannot be created without a targeted control.");
-				}
+		if (!oControl) {
+			return Promise.reject(new Error("A flexibility change cannot be created without a targeted control."));
+		}
 
-				var sControlId = oControl.id || oControl.getId();
+		var sControlId = oControl.id || oControl.getId();
 
-				if (!oChangeSpecificData.selector) {
-					oChangeSpecificData.selector = {};
-				}
-				oAppComponent = oControl.appComponent || Utils.getAppComponentForControl(oControl);
-				if (!oAppComponent) {
-					throw new Error("No application component found. To offer flexibility, the control with the ID '"
-						+ sControlId + "' has to have a valid relation to its owning application component.");
-				}
+		if (!oChangeSpecificData.selector) {
+			oChangeSpecificData.selector = {};
+		}
+		var oAppComponent = oControl.appComponent || Utils.getAppComponentForControl(oControl);
+		if (!oAppComponent) {
+			return Promise.reject(new Error("No application component found. To offer flexibility, the control with the ID '"
+				+ sControlId + "' has to have a valid relation to its owning application component."));
+		}
 
-				// differentiate between controls containing the component id as a prefix and others
-				// get local Id for control at root component and use it as selector id
-				Object.assign(oChangeSpecificData.selector, JsControlTreeModifier.getSelector(sControlId, oAppComponent));
-				return oAppComponent;
-			})
-			.then(function(oAppComponent) {
-				return this._createChange(oChangeSpecificData, oAppComponent, oControl);
-			}.bind(this));
+		// differentiate between controls containing the component id as a prefix and others
+		// get local Id for control at root component and use it as selector id
+		Object.assign(oChangeSpecificData.selector, JsControlTreeModifier.getSelector(sControlId, oAppComponent));
+		return this._createChange(oChangeSpecificData, oAppComponent, oControl);
 	};
 
 	/**
@@ -258,19 +262,19 @@ sap.ui.define([
 	 */
 	FlexController.prototype.addChange = function(oChangeSpecificData, oControl) {
 		return this.createChangeWithControlSelector(oChangeSpecificData, oControl)
-			.then(function(oChange) {
-				var oAppComponent = Utils.getAppComponentForControl(oControl);
-				// adding a change to the persistence will trigger the propagation listener which would try to apply the change
-				// but in this scenario the change is applied in .createAndApplyChange and no dependencies are added,
-				// so the propagation listener should ignore this change once
-				oChange._ignoreOnce = true;
-				this.addPreparedChange(oChange, oAppComponent);
-
-				// TODO this should go into an API that applied multiple changes, that does not yet exist
-				// all changes should be queued to apply before the first change gets applied
-				oChange.setQueuedForApply();
-				return oChange;
-			}.bind(this));
+		.then(function(oChange) {
+			var oAppComponent = Utils.getAppComponentForControl(oControl);
+			// adding a change to the persistence will trigger the propagation listener which would try to apply the change
+			// but in this scenario the change is applied in .createAndApplyChange and no dependencies are added,
+			// so the propagation listener should ignore this change once
+			oChange._ignoreOnce = true;
+			this.addPreparedChange(oChange, oAppComponent);
+
+			// TODO this should go into an API that applied multiple changes, that does not yet exist
+			// all changes should be queued to apply before the first change gets applied
+			oChange.setQueuedForApply();
+			return oChange;
+		}.bind(this));
 	};
 
 	/**
@@ -375,10 +379,10 @@ sap.ui.define([
 			return this._waitForChangesToBeApplied(mSelector);
 		}.bind(this));
 		return Promise.all(aPromises)
-			.then(function() {
-				// the return value is not important in this function, only that it resolves
-				return undefined;
-			});
+		.then(function() {
+			// the return value is not important in this function, only that it resolves
+			return undefined;
+		});
 	};
 
 	/**
@@ -450,7 +454,14 @@ sap.ui.define([
 	 * @returns {Promise} resolving with an array of responses or rejecting with the first error
 	 * @public
 	 */
-	FlexController.prototype.saveAll = function(oAppComponent, bSkipUpdateCache, bDraft, sLayer, bRemoveOtherLayerChanges, bCondenseAnyLayer) {
+	FlexController.prototype.saveAll = function(
+		oAppComponent,
+		bSkipUpdateCache,
+		bDraft,
+		sLayer,
+		bRemoveOtherLayerChanges,
+		bCondenseAnyLayer
+	) {
 		var sParentVersion;
 		var aDraftFilenames;
 		if (bDraft) {
@@ -462,26 +473,35 @@ sap.ui.define([
 			aDraftFilenames = oVersionModel.getProperty("/draftFilenames");
 		}
 		return this._removeOtherLayerChanges(oAppComponent, sLayer, bRemoveOtherLayerChanges)
-			.then(this._oChangePersistence.saveDirtyChanges.bind(this._oChangePersistence, oAppComponent, bSkipUpdateCache, undefined, sParentVersion, aDraftFilenames, bCondenseAnyLayer, sLayer))
-			.then(function(oResult) {
-				if (bDraft && oResult && oResult.response) {
-					var vChangeDefinition = oResult.response;
-					var aDraftFilenames = [];
-					if (Array.isArray(vChangeDefinition)) {
-						vChangeDefinition.forEach(function(change) {
-							aDraftFilenames.push(change.fileName);
-						});
-						// the reference and layer of all items are the same
-						vChangeDefinition = vChangeDefinition[0];
-					}
-					Versions.onAllChangesSaved({
-						reference: vChangeDefinition.reference,
-						layer: vChangeDefinition.layer,
-						draftFilenames: aDraftFilenames
+		.then(this._oChangePersistence.saveDirtyChanges.bind(
+			this._oChangePersistence,
+			oAppComponent,
+			bSkipUpdateCache,
+			undefined,
+			sParentVersion,
+			aDraftFilenames,
+			bCondenseAnyLayer,
+			sLayer
+		))
+		.then(function(oResult) {
+			if (bDraft && oResult && oResult.response) {
+				var vChangeDefinition = oResult.response;
+				var aDraftFilenames = [];
+				if (Array.isArray(vChangeDefinition)) {
+					vChangeDefinition.forEach(function(change) {
+						aDraftFilenames.push(change.fileName);
 					});
+					// the reference and layer of all items are the same
+					vChangeDefinition = vChangeDefinition[0];
 				}
-				return oResult;
-			});
+				Versions.onAllChangesSaved({
+					reference: vChangeDefinition.reference,
+					layer: vChangeDefinition.layer,
+					draftFilenames: aDraftFilenames
+				});
+			}
+			return oResult;
+		});
 	};
 
 	/**
@@ -503,8 +523,8 @@ sap.ui.define([
 		mPropertyBag.view = oView;
 
 		return this._oChangePersistence.getChangesForView(mPropertyBag)
-			.then(Applier.applyAllChangesForXMLView.bind(Applier, mPropertyBag))
-			.catch(handleXMLApplyError.bind(this, mPropertyBag.view));
+		.then(Applier.applyAllChangesForXMLView.bind(Applier, mPropertyBag))
+		.catch(handleXMLApplyError.bind(this, mPropertyBag.view));
 	};
 
 	function handleXMLApplyError(oView, oError) {
@@ -554,7 +574,7 @@ sap.ui.define([
 	 */
 	FlexController.prototype.resetChanges = function(sLayer, sGenerator, oComponent, aSelectorIds, aChangeTypes) {
 		return this._oChangePersistence.resetChanges(sLayer, sGenerator, aSelectorIds, aChangeTypes)
-			.then(revertChangesAndUpdateVariantModel.bind(this, oComponent, undefined));
+		.then(revertChangesAndUpdateVariantModel.bind(this, oComponent, undefined));
 	};
 
 	/**
@@ -596,21 +616,28 @@ sap.ui.define([
 					return Applier.applyChangeOnControl(oChange, oControl, mPropertyBag);
 				}
 				Log.error("A flexibility change tries to change a nonexistent control.");
+				return undefined;
 			}.bind(this));
-		}.bind(this), new Utils.FakePromise());
+		}.bind(this), (Utils.FakePromise ? new Utils.FakePromise() : Promise.resolve()));
 	};
 
 	/**
 	 * Saves changes sequentially on the associated change persistence instance;
-	 * This API must be only used in scnarios without draft (like personalization).
+	 * This API must be only used in scenarios without draft (like personalization).
 	 *
 	 * @param {sap.ui.fl.apply._internal.flexObjects.FlexObject[]} aDirtyChanges Array of dirty changes to be saved
 	 * @param {sap.ui.core.UIComponent} [oAppComponent] - AppComponent instance
-	 * @returns {Promise} A Promise which resolves when all changes have been saved
+	 * @returns {Promise} A Promise which resolves when all changes have been saved with the backend response
 	 * @public
 	 */
 	FlexController.prototype.saveSequenceOfDirtyChanges = function(aDirtyChanges, oAppComponent) {
-		return this._oChangePersistence.saveDirtyChanges(oAppComponent, false, aDirtyChanges);
+		return this._oChangePersistence.saveDirtyChanges(oAppComponent, false, aDirtyChanges)
+		.then(function(oResponse) {
+			aDirtyChanges.forEach(function(oDirtyChange) {
+				oDirtyChange.setState(States.LifecycleState.PERSISTED);
+			});
+			return oResponse;
+		});
 	};
 
 	return FlexController;

package/src/sap/ui/fl/FlexControllerFactory.js

@@ -22,7 +22,7 @@ sap.ui.define([
 	 * @alias sap.ui.fl.FlexControllerFactory
 	 * @experimental Since 1.27.0
 	 * @author SAP SE
-	 * @version 1.115.1
+	 * @version 1.116.0
 	 *
 	 * @private
 	 * @ui5-restricted sap.ui.fl

package/src/sap/ui/fl/Layer.js

@@ -4,7 +4,7 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
-sap.ui.define([], function () {
+sap.ui.define([], function() {
 	"use strict";
 
 	/**

package/src/sap/ui/fl/LayerUtils.js

@@ -15,7 +15,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	//Stack of layers in the layered repository
+	// Stack of layers in the layered repository
 	var aLayers = [
 		Layer.BASE,
 		Layer.VENDOR,
@@ -26,7 +26,7 @@ sap.ui.define([
 		Layer.USER
 	];
 
-	//Precalculates index of layers
+	// Precalculates index of layers
 	var mLayersIndex = {};
 	aLayers.forEach(function(sLayer, iIndex) {
 		mLayersIndex[sLayer] = iIndex;
@@ -41,7 +41,7 @@ sap.ui.define([
 	 *
 	 * @namespace sap.ui.fl.LayerUtils
 	 * @author SAP SE
-	 * @version 1.115.1
+	 * @version 1.116.0
 	 */
 	var LayerUtils = {
 		_mLayersIndex: mLayersIndex,
@@ -55,8 +55,8 @@ sap.ui.define([
 		 * @returns {boolean} <code>true</code> if the layer is valid
 		 * @public
 		 */
-		isValidLayer: function (sLayer) {
-			return Object.keys(Layer).some(function (sExistingLayer) {
+		isValidLayer: function(sLayer) {
+			return Object.keys(Layer).some(function(sExistingLayer) {
 				return sExistingLayer === sLayer;
 			});
 		},
@@ -67,7 +67,7 @@ sap.ui.define([
 		 * @returns {boolean} true if it's an application variant
 		 * @public
 		 */
-		isVendorLayer: function () {
+		isVendorLayer: function() {
 			return this.getCurrentLayer() === Layer.VENDOR;
 		},
 
@@ -101,7 +101,7 @@ sap.ui.define([
 		 * @returns {boolean} Indicates whether a new variant needs an ABAP package
 		 * @public
 		 */
-		doesCurrentLayerRequirePackage: function () {
+		doesCurrentLayerRequirePackage: function() {
 			var sCurrentLayer = this.getCurrentLayer();
 			return (sCurrentLayer === Layer.VENDOR) || (sCurrentLayer === Layer.PARTNER) || (sCurrentLayer === Layer.CUSTOMER_BASE);
 		},
@@ -113,7 +113,7 @@ sap.ui.define([
 		 * @param {sap.ui.core.service.Service} oURLParsingService Unified Shell URL Parsing Service
 		 * @return {string} maxLayer
 		 */
-		getMaxLayer: function (oURLParsingService) {
+		getMaxLayer: function(oURLParsingService) {
 			var sParseMaxLayer = LayerUtils.getMaxLayerTechnicalParameter(hasher.getHash(), oURLParsingService);
 			return sParseMaxLayer || getUrlParameter(this.FL_MAX_LAYER_PARAM) || LayerUtils._sTopLayer;
 		},
@@ -148,7 +148,7 @@ sap.ui.define([
 		 * @returns {boolean} <code>true</code> if the first input layer is higher than the second input layer, otherwise <code>false</code>
 		 * @public
 		 */
-		isOverLayer: function (sObjectsLayer, sComparedLayer) {
+		isOverLayer: function(sObjectsLayer, sComparedLayer) {
 			return this.getLayerIndex(sObjectsLayer) > this.getLayerIndex(sComparedLayer);
 		},
 
@@ -189,7 +189,7 @@ sap.ui.define([
 		 * @returns {boolean} <code>true</code> if the top layer is also the max layer, otherwise <code>false</code>
 		 * @public
 		 */
-		isSapUiLayerParameterProvided: function () {
+		isSapUiLayerParameterProvided: function() {
 			return !!getUrlParameter("sap-ui-layer");
 		},
 
@@ -199,7 +199,7 @@ sap.ui.define([
 		 * @returns {string} the current layer
 		 * @public
 		 */
-		getCurrentLayer: function () {
+		getCurrentLayer: function() {
 			var sLayer = getUrlParameter("sap-ui-layer") || "";
 			return sLayer.toUpperCase() || Layer.CUSTOMER;
 		},

package/src/sap/ui/fl/Utils.js

@@ -37,7 +37,6 @@ sap.ui.define([
 ) {
 	"use strict";
 
-
 	/**
 	 * Returns the type of "sap.app" from the manifest object passed.
 	 * @param {sap.ui.core.Manifest} oManifest - Manifest object
@@ -67,7 +66,7 @@ sap.ui.define([
 	 * @namespace
 	 * @alias sap.ui.fl.Utils
 	 * @author SAP SE
-	 * @version 1.115.1
+	 * @version 1.116.0
 	 *
 	 * @private
 	 * @ui5-restricted sap.ui.fl, sap.ui.rta
@@ -82,7 +81,7 @@ sap.ui.define([
 		 * @param {string} [sCallStack] - Passes the callstack to the logging function
 		 */
 		formatAndLogMessage: function(sLogType, aMessageComponents, aValuesToInsert, sCallStack) {
-			var sLogMessage = aMessageComponents.join(' ');
+			var sLogMessage = aMessageComponents.join(" ");
 			sLogMessage = formatMessage(sLogMessage, aValuesToInsert);
 			Log[sLogType](sLogMessage, sCallStack || "");
 		},
@@ -197,7 +196,7 @@ sap.ui.define([
 		 * @ui5-restricted sap.ui.fl
 		 */
 		getComponentForControl: function(oControl) {
-			function getComponentIdForControl (oControl) {
+			function getComponentIdForControl(oControl) {
 				var sComponentId = Component.getOwnerIdFor(oControl);
 				if (!sComponentId) {
 					if (oControl && typeof oControl.getParent === "function") {
@@ -319,7 +318,6 @@ sap.ui.define([
 			return Utils.convertBrowserLanguageToISO639_1(sLanguage);
 		},
 
-
 		/**
 		 * Converts the browser language into a 2-character ISO 639-1 language. If the browser language is in format RFC4646, the first part will be
 		 * used: For example en-us will be converted to EN. If the browser language already is in ISO 639-1, it will be returned after an upper case
@@ -418,7 +416,7 @@ sap.ui.define([
 		createDefaultFileName: function(sNameAddition) {
 			var sFileName = uid().replace(/-/g, "_");
 			if (sNameAddition) {
-				sFileName += '_' + sNameAddition;
+				sFileName += "_" + sNameAddition;
 			}
 			return sFileName;
 		},
@@ -428,8 +426,8 @@ sap.ui.define([
 			if (sFileType === "ctrl_variant") {
 				sSubfolder = "variants";
 			}
-			var sReferenceName = oPropertyBag.reference.replace('.Component', '');
-			var sNamespace = 'apps/' + sReferenceName + "/" + sSubfolder + "/";
+			var sReferenceName = oPropertyBag.reference.replace(".Component", "");
+			var sNamespace = "apps/" + sReferenceName + "/" + sSubfolder + "/";
 			return sNamespace;
 		},
 
@@ -570,7 +568,7 @@ sap.ui.define([
 				if (bAsync) {
 					return Promise.resolve();
 				}
-				return new Utils.FakePromise();
+				return (Utils.FakePromise ? new Utils.FakePromise() : Promise.resolve());
 			}
 			var fnPromise = aPromiseQueue.shift();
 			if (typeof fnPromise === "function") {
@@ -614,6 +612,7 @@ sap.ui.define([
 		 * @param {any} vError - value on reject FakePromise
 		 * @param {string} sInitialPromiseIdentifier - value identifies previous promise in chain. If the identifier is passed to the function and don't match with the FakePromiseIdentifier then native Promise execution is used for further processing
 		 * @returns {sap.ui.fl.Utils.FakePromise|Promise} Returns instantiated FakePromise only if no Promise is passed by value parameter
+		 * @deprecated As of Version 1.114
 		 * @private
 		 * @ui5-restricted
 		 */
@@ -724,7 +723,7 @@ sap.ui.define([
 					sParameters = "?" + aFilterUrl.join("&");
 				}
 			} else {
-				sParameters += (sParameters.length > 0 ? '&' : '?') + sParameterName + "=" + sParameterValue;
+				sParameters += (sParameters.length > 0 ? "&" : "?") + sParameterName + "=" + sParameterValue;
 			}
 			return sParameters;
 		},
@@ -748,7 +747,7 @@ sap.ui.define([
 		 * @param  {sap.ushell.services.URLParsing} oURLParsingService - The Unified Shell's internal URL parsing service
 		 * @returns {string} The value of the given parameter or undefined
 		 */
-		getParameter: function (sParameterName, oURLParsingService) {
+		getParameter: function(sParameterName, oURLParsingService) {
 			if (oURLParsingService) {
 				var mParsedHash = Utils.getParsedURLHash(oURLParsingService);
 				return mParsedHash.params &&
@@ -783,7 +782,7 @@ sap.ui.define([
 		 * @param {string} sAggregationName - Aggregation name
 		 * @returns {sap.ui.base.ManagedObject[]|Element[]} Aggregation content
 		 */
-		getAggregation: function (oParent, sAggregationName) {
+		getAggregation: function(oParent, sAggregationName) {
 			var oAggregation = Utils.findAggregation(oParent, sAggregationName);
 			if (oAggregation) {
 				return oParent[oAggregation._sGetter]();
@@ -797,7 +796,7 @@ sap.ui.define([
 		 * @param {string} sPropertyName - Property name
 		 * @returns {any} Value of the property
 		 */
-		getProperty: function (oControl, sPropertyName) {
+		getProperty: function(oControl, sPropertyName) {
 			var oMetadata = oControl.getMetadata().getPropertyLikeSetting(sPropertyName);
 			if (oMetadata) {
 				var sPropertyGetter = oMetadata._sGetter;
@@ -827,12 +826,12 @@ sap.ui.define([
 		 * @param {array} aServiceNames - List of service names
 		 * @returns {Promise<object>} Resolves to an object with the requested ushell services
 		 */
-		getUShellServices: function (aServiceNames) {
-			var aServicePromises = aServiceNames.map(function (sServiceName) {
+		getUShellServices: function(aServiceNames) {
+			var aServicePromises = aServiceNames.map(function(sServiceName) {
 				return this.getUShellService(sServiceName);
 			}.bind(this));
-			return Promise.all(aServicePromises).then(function (aServices) {
-				return aServiceNames.reduce(function (mServices, sService, iIndex) {
+			return Promise.all(aServicePromises).then(function(aServices) {
+				return aServiceNames.reduce(function(mServices, sService, iIndex) {
 					mServices[sService] = aServices && aServices[iIndex];
 					return mServices;
 				}, {});