@openui5/sap.ui.dt 1.96.5 → 1.99.0

package/src/sap/ui/dt/TaskManager.js

@@ -21,7 +21,7 @@ function(
 	 * The TaskManager keeps list of task and allows to manage them via simple API.
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @constructor
 	 * @private
@@ -65,7 +65,7 @@ function(
 		_iTaskCounter: 0
 	});
 
-	TaskManager.prototype._validateTask = function(mTask) {
+	function validateTask(mTask) {
 		if (
 			!isPlainObject(mTask)
 			|| !mTask.type
@@ -73,35 +73,50 @@ function(
 		) {
 			throw new Error("Invalid task specified");
 		}
-	};
+	}
 
-	TaskManager.prototype._removeOutdatedTasks = function(mTask, vDoubleIdentifier) {
-		if (vDoubleIdentifier) {
-			var fnDoubleIdentifier;
-			if (typeof vDoubleIdentifier === "string") {
-				fnDoubleIdentifier = function (mTask) { return mTask[vDoubleIdentifier]; };
-			} else if (typeof vDoubleIdentifier === "function") {
-				fnDoubleIdentifier = vDoubleIdentifier;
-			} else {
-				throw new Error("Validator needs to be a function or a string");
-			}
-			var aTaskList = this._mQueuedTasks[mTask.type];
-			var sNewTaskIdentifier = fnDoubleIdentifier(mTask);
-			if (
-				aTaskList
-				&& sNewTaskIdentifier
-			) {
-				this._mQueuedTasks[mTask.type] = aTaskList.filter(function (oTask) {
-					if (fnDoubleIdentifier(oTask) === sNewTaskIdentifier) {
-						this._iTaskCounter--;
-						return false;
-					}
-					return true;
-				}.bind(this));
+	function getTaskIdentifierFunction(vTaskIdentifier) {
+		var fnTaskIdentifier;
+		if (typeof vTaskIdentifier === "string") {
+			fnTaskIdentifier = function (mTask) { return mTask[vTaskIdentifier]; };
+		} else if (typeof vTaskIdentifier === "function") {
+			fnTaskIdentifier = vTaskIdentifier;
+		} else {
+			throw new Error("Validator needs to be a function or a string");
+		}
+		return fnTaskIdentifier;
+	}
+
+	function filterTasks(fnTaskIdentifier, sNewTaskIdentifier, oTask) {
+		if (fnTaskIdentifier(oTask) === sNewTaskIdentifier) {
+			this._iTaskCounter--;
+			return false;
+		}
+		return true;
+	}
+
+	TaskManager.prototype._removeTasksByIdentifier = function(mTask, vTaskIdentifier, sListName) {
+		if (vTaskIdentifier) {
+			var fnTaskIdentifier = getTaskIdentifierFunction(vTaskIdentifier);
+			var sNewTaskIdentifier = fnTaskIdentifier(mTask);
+			if (this[sListName][mTask.type] && sNewTaskIdentifier) {
+				this[sListName][mTask.type] = this[sListName][mTask.type].filter(filterTasks.bind(this, fnTaskIdentifier, sNewTaskIdentifier));
 			}
 		}
 	};
 
+	TaskManager.prototype._removeTaskById = function (iTaskId, sListName) {
+		Object.keys(this[sListName]).forEach(function (sTypeName) {
+			this[sListName][sTypeName] = this[sListName][sTypeName].filter(function (mTask) {
+				if (mTask.id === iTaskId) {
+					this._iTaskCounter--;
+					return false;
+				}
+				return true;
+			}.bind(this));
+		}, this);
+	};
+
 	TaskManager.prototype._addTask = function(mTask) {
 		var iTaskId = this._iNextId++;
 		this._mQueuedTasks[mTask.type] = this._mQueuedTasks[mTask.type] || [];
@@ -127,29 +142,16 @@ function(
 	 * @return {number} Task ID
 	 */
 	TaskManager.prototype.add = function (mTask, vDoubleIdentifier) {
-		this._validateTask(mTask);
-		this._removeOutdatedTasks(mTask, vDoubleIdentifier);
+		validateTask(mTask);
+		this._removeTasksByIdentifier(mTask, vDoubleIdentifier, "_mQueuedTasks");
 		return this._addTask(mTask);
 	};
 
-	TaskManager.prototype._removeTaskById = function (iTaskId, sListName) {
-		Object.keys(this[sListName]).forEach(function (sTypeName) {
-			this[sListName][sTypeName] = this[sListName][sTypeName].filter(function (mTask) {
-				if (mTask.id === iTaskId) {
-					this._iTaskCounter--;
-					return false;
-				}
-				return true;
-			}.bind(this));
-		}, this);
-	};
-
 	/**
 	 * Completes the task by its ID
 	 * @param {number} iTaskId - Task ID
 	 */
 	TaskManager.prototype.complete = function (iTaskId) {
-		// TODO: performance improvements?
 		this._removeTaskById(iTaskId, "_mQueuedTasks");
 		this._removeTaskById(iTaskId, "_mPendingTasks");
 		if (!this.getSuppressEvents()) {
@@ -166,7 +168,7 @@ function(
 	 * @param {object} mTask.type - Task type
 	 */
 	TaskManager.prototype.completeBy = function (mTask) {
-		this._validateTask(mTask);
+		validateTask(mTask);
 		var aCompledTaskIds = [];
 		// TODO: get rid of filtering other task parameters then type for performance reasons
 		var _removeTasksByDefinition = function (aTasks) {
@@ -199,6 +201,19 @@ function(
 		this.complete(iTaskId);
 	};
 
+	/**
+	 * Cancels the task typespecific by its parameters defined by the callbackfunction
+	 *
+	 * @param {object} mTask - Task definition map
+	 * @param {string} mTask.type - Task type
+	 * @param {string} sTaskIdentifier - Identifier for tasks in <code>TaskManager</code> related to the specific task type.
+	 *  The existing tasks that are identified by <code>sTaskIdentifier</code> are removed
+	 */
+	TaskManager.prototype.cancelBy = function (mTask, sTaskIdentifier) {
+		this._removeTasksByIdentifier(mTask, sTaskIdentifier, "_mQueuedTasks");
+		this._removeTasksByIdentifier(mTask, sTaskIdentifier, "_mPendingTasks");
+	};
+
 	/**
 	 * Checks if the queue is empty
 	 * @return {boolean} <code>true</code> if there is no pending task

package/src/sap/ui/dt/TaskRunner.js

@@ -24,7 +24,7 @@ function(
 	 * TaskRunner run tasks defined in sap.ui.dt.TaskManager.
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @constructor
 	 * @private
@@ -59,9 +59,10 @@ function(
 	TaskRunner.prototype._observe = function (oEvent) {
 		this._oTaskPromise = this._oTaskPromise.then(function() {
 			if (this._shouldObserveBreak()) {
-				return this.stop();
+				this.stop();
+			} else {
+				this._runTasksFromManager(oEvent);
 			}
-			this._runTasksFromManager(oEvent);
 		}.bind(this));
 	};
 
@@ -73,19 +74,18 @@ function(
 	};
 
 	TaskRunner.prototype._runTasks = function (aTasks) {
-		var aTaskPromises = [];
-		for (var i = 0, n = aTasks.length; i < n; i++) {
-			if (aTasks[i].callbackFn) {
-				try {
-					aTaskPromises.push(
-						aTasks[i].callbackFn()
-							.then(this._oTaskManager.complete.bind(this._oTaskManager, aTasks[i].id))
-					);
-				} catch (vError) {
-					BaseLog.error(DtUtil.errorToString(vError));
-				}
+		aTasks.forEach(function (oTask) {
+			if (oTask.callbackFn) {
+				oTask.callbackFn()
+					.then(function () {
+						this._oTaskManager.complete(oTask.id);
+					}.bind(this))
+					.catch(function (vError) {
+						this._oTaskManager.complete(oTask.id);
+						BaseLog.error(DtUtil.errorToString(vError) + " / related task: " + JSON.stringify(oTask));
+					}.bind(this));
 			}
-		}
+		}.bind(this));
 	};
 
 	TaskRunner.prototype.run = function (sTaskType) {

package/src/sap/ui/dt/Util.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * Utilities for sap.ui.dt library
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @private
 	 * @static
@@ -239,7 +239,7 @@ sap.ui.define([
 
 	/**
 	 * Webkit can be safari or chrome mobile
-	 * @return {Boolean} Returns true if the device browser uses webkit
+	 * @return {boolean} Returns true if the device browser uses webkit
 	 */
 	Util.isWebkit = function() {
 		return Device.browser.webkit && (Device.browser.safari || Device.browser.chrome && Device.browser.mobile);

package/src/sap/ui/dt/enablement/ElementEnablementTest.js

@@ -13,8 +13,7 @@ sap.ui.define([
 	"sap/ui/dt/ElementOverlay",
 	"sap/ui/qunit/utils/waitForThemeApplied",
 	"sap/ui/thirdparty/sinon-4"
-],
-function(
+], function(
 	jQuery,
 	Test,
 	DesignTime,
@@ -38,7 +37,7 @@ function(
 	 * @extends sap.ui.dt.test.Test
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/dt/enablement/Test.js

@@ -7,8 +7,7 @@
 // Provides class sap.ui.dt.test.Test.
 sap.ui.define([
 	"sap/ui/base/ManagedObject"
-],
-function(ManagedObject) {
+], function(ManagedObject) {
 	"use strict";
 
 	/**
@@ -23,7 +22,7 @@ function(ManagedObject) {
 	 * @extends sap.ui.base.ManagedObject
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @constructor
 	 * @private
@@ -83,9 +82,9 @@ function(ManagedObject) {
 	/**
 	 * Creates a new suite and returns it.
 	 *
-	 * @param {string} sName The name of the suite.
-	 * @param {string} sMessage A message to display
-	 * @return {map} the entry object
+	 * @param {string} sName - Name of the suite
+	 * @param {string} sMessage - Message to display
+	 * @return {map} Entry object
 	 *
 	 * @protected
 	 */
@@ -104,10 +103,11 @@ function(ManagedObject) {
 	/**
 	 * Adds a new group to an array.
 	 *
-	 * @param {object[]} aParentChildren the array to insert the group
-	 * @param {string} sName The name of the group.
-	 * @param {string} sMessage A message to display
-	 * @return {map} the entry object
+	 * @param {object[]} aParentChildren - Array to insert the group
+	 * @param {string} sName - Name of the group
+	 * @param {string} sMessage - Message to display
+	 * @param {string} sNamePostfix - Namepostfix
+	 * @returns {map} Entry object
 	 *
 	 * @protected
 	 */
@@ -125,12 +125,12 @@ function(ManagedObject) {
 	/**
 	 * Adds a new test to an array.
 	 *
-	 * @param {object[]} aParentChildren the array to insert the test
-	 * @param {boolean} bResult The result of the test.
-	 * @param {string} sName The name of the test.
-	 * @param {string} sMessage A message to display
-	 * @param {map} status The status of the test.
-	 * @return {map} the entry object
+	 * @param {object[]} aParentChildren - Array to insert the test
+	 * @param {boolean} bResult - Result of the test
+	 * @param {string} sName - Name of the test
+	 * @param {string} sMessage - Message to display
+	 * @param {map} mStatus - Status of the test
+	 * @return {map} Entry object
 	 *
 	 * @protected
 	 */
@@ -148,13 +148,13 @@ function(ManagedObject) {
 	/**
 	 * Adds a new entry to an array.
 	 *
-	 * @param {object[]} aParentChildren the array to insert the entry
-	 * @param {boolean} bResult The result of the entry.
-	 * @param {string} sName The name of the entry.
-	 * @param {string} sMessage A message to display
-	 * @param {map} mStatus The status of the entry.
-	 * @param {string} sType The type of the entry.
-	 * @return {map} the entry object
+	 * @param {object[]} aParentChildren - Array to insert the entry
+	 * @param {boolean} bResult - Result of the entry
+	 * @param {string} sName - Name of the entry
+	 * @param {string} sMessage - Message to display
+	 * @param {map} mStatus - Status of the entry
+	 * @param {string} sType - Type of the entry
+	 * @return {map} Entry object
 	 *
 	 * @protected
 	 */
@@ -197,7 +197,8 @@ function(ManagedObject) {
 
 	/**
 	 * Aggregates the tests results.
-	 * @return {map} the aggregated result
+	 * @param {map} mResult - Result to aggregate
+	 * @return {map} Aggregated result
 	 *
 	 * @protected
 	 */

package/src/sap/ui/dt/enablement/Util.js

@@ -9,8 +9,7 @@ sap.ui.define([
 	"sap/ui/dt/ElementUtil",
 	"sap/ui/dt/DOMUtil",
 	"sap/ui/dt/OverlayRegistry"
-],
-function(
+], function(
 	ElementUtil,
 	DOMUtil,
 	OverlayRegistry
@@ -23,7 +22,7 @@ function(
 	 * @namespace
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @private
 	 * @static
@@ -37,8 +36,8 @@ function(
 
 	/**
 	 * Returns all design time information of the element
-	 * @param  {sap.ui.core.Element} oElement the element to test
-	 * @return {map} result object
+	 * @param {sap.ui.core.Element} oElement - Element to test
+	 * @returns {map} Result object
 	 */
 	ElementTest.getInfo = function(oElement) {
 		var oMetadata = oElement.getMetadata();
@@ -53,8 +52,9 @@ function(
 
 	/**
 	 * Returns all aggregation infos of the element
-	 * @param  {sap.ui.core.Element} oElement the element to test
-	 * @return {map} result object
+	 * @param {sap.ui.core.Element} oElement - Element to test
+	 * @param {string} sAggregationName - Name of the aggregation
+	 * @returns {map} Result object
 	 */
 	ElementTest.getAggregationInfo = function(oElement, sAggregationName) {
 		var mAggregationTest = {
@@ -98,8 +98,8 @@ function(
 
 	/**
 	 * Returns all information of all aggregations of the element
-	 * @param  {sap.ui.core.Element} oElement the element to test
-	 * @return {map} result object
+	 * @param {sap.ui.core.Element} oElement - Element to test
+	 * @returns {map} Result object
 	 */
 	ElementTest.getAggregationsInfo = function(oElement) {
 		var mAggregationTests = {};

package/src/sap/ui/dt/enablement/libraryTest.js

@@ -4,7 +4,7 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
-/* global QUnit, XMLHttpRequest */
+/* global QUnit */
 
 sap.ui.define([
 	"sap/ui/model/resource/ResourceModel",
@@ -246,7 +246,7 @@ sap.ui.define([
 						oController: this
 					});
 					//check the controls type
-					assert.strictEqual((oControl instanceof jQuery.sap.getObject(sControlName)) ||  , true, sCreateTemplate + " created a control with the right type " + sControlName + "/" + oControl.getMetadata().getName());
+					assert.strictEqual((oControl instanceof ObjectPath.get(sControlName)) ||  , true, sCreateTemplate + " created a control with the right type " + sControlName + "/" + oControl.getMetadata().getName());
 					*/
 				}
 			}

package/src/sap/ui/dt/enablement/report/LibraryReport.js

@@ -25,7 +25,7 @@ sap.ui.define([
 	 * @extends sap.ui.dt.enablement.Test
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/dt/enablement/report/QUnitReport.js

@@ -8,8 +8,7 @@
 
 sap.ui.define([
 	"sap/ui/base/ManagedObject"
-],
-function(
+], function(
 	ManagedObject
 ) {
 	"use strict";
@@ -25,7 +24,7 @@ function(
 	 * @extends sap.ui.base.ManagedObject
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/dt/enablement/report/Statistic.js

@@ -32,7 +32,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/dt/enablement/report/StatisticRenderer.js

@@ -10,7 +10,7 @@ sap.ui.define(function() {
 
 	/**
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 * @namespace
 	 */
 	var StatisticRenderer = {};
@@ -19,7 +19,7 @@ sap.ui.define(function() {
 	 * Renders the HTML for the given control, using the provided {@link sap.ui.core.RenderManager}.
 	 *
 	 * @param {sap.ui.core.RenderManager} rm The RenderManager that can be used for writing to the render output buffer.
-	 * @param {sap.ui.core.Control} oStatistic An object representation of the control that should be rendered.
+	 * @param {sap.ui.dt.enablement.report.Statistic} oStatistic An object representation of the control that should be rendered.
 	 */
 	StatisticRenderer.render = function(rm, oStatistic) {
 		rm.addClass("sapUiDtStatisticReport");

package/src/sap/ui/dt/enablement/report/Table.js

@@ -17,8 +17,7 @@ sap.ui.define([
 	"sap/m/Text",
 	"sap/m/RatingIndicator",
 	"./TableRenderer"
-],
-function(
+], function(
 	Control,
 	JSONModel,
 	TreeTable,
@@ -43,7 +42,7 @@ function(
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/dt/enablement/report/TableRenderer.js

@@ -10,7 +10,7 @@ sap.ui.define(function() {
 
 	/**
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 * @namespace
 	 */
 	var TableRenderer = {};
@@ -19,7 +19,7 @@ sap.ui.define(function() {
 	 * Renders the HTML for the given control, using the provided {@link sap.ui.core.RenderManager}.
 	 *
 	 * @param {sap.ui.core.RenderManager} rm The RenderManager that can be used for writing to the render output buffer.
-	 * @param {sap.ui.core.Control} oTable An object representation of the control that should be rendered.
+	 * @param {sap.ui.dt.enablement.report.Table} oTable An object representation of the control that should be rendered.
 	 */
 	TableRenderer.render = function(rm, oTable) {
 		rm.addClass("sapUiDtTableReport");

package/src/sap/ui/dt/library.js

@@ -23,7 +23,7 @@ function (
 	 * @namespace
 	 * @name sap.ui.dt
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 * @since 1.30
 	 * @experimental This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 * @private
@@ -32,7 +32,7 @@ function (
 	// delegate further initialization of this library to the Core
 	sap.ui.getCore().initLibrary({
 		name: "sap.ui.dt",
-		version: "1.96.5",
+		version: "1.99.0",
 		dependencies: ["sap.ui.core"],
 		types: [
 			"sap.ui.dt.SelectionMode"

package/src/sap/ui/dt/plugin/ContextMenu.js

@@ -34,7 +34,7 @@ sap.ui.define([
 	 * @class The ContextMenu registers event handler to open the context menu. Menu entries can dynamically be added
 	 * @extends sap.ui.dt.Plugin
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 * @constructor
 	 * @private
 	 * @since 1.53
@@ -136,11 +136,13 @@ sap.ui.define([
 
 	/**
 	 * Opens the Context Menu
-	 * @param {sap.ui.dt.Overlay} oOverlay overlay object
-	 * @param {boolean} bContextMenu whether the control should be opened as a context menu
-	 * @param {boolean} bIsSubMenu whether the new ContextMenu is a SubMenu opened by a menu item inside another ContextMenu
+	 * @param {sap.ui.dt.Overlay} oOverlay - Overlay object
+	 * @param {boolean} bContextMenu - Whether the control should be opened as a context menu
+	 * @param {boolean} bIsSubMenu - Whether the new ContextMenu is a SubMenu opened by a menu item inside another ContextMenu
+	 * @param {object} oEvent - Click event of the menu
 	 */
 	ContextMenu.prototype.open = function (oOverlay, bContextMenu, bIsSubMenu, oEvent) {
+		var aSelectedOverlays;
 		function addMenuItems(oMenu, aMenuItems) {
 			aMenuItems.forEach(function(oMenuItem, index) {
 				var sText = typeof oMenuItem.text === "function" ? oMenuItem.text(oOverlay) : oMenuItem.text;
@@ -183,7 +185,7 @@ sap.ui.define([
 		this.setContextElement(oNewContextElement);
 		this.getDesignTime().getSelectionManager().attachChange(this._onSelectionChanged, this);
 
-		var aSelectedOverlays = this.getSelectedOverlays().filter(function (oElementOverlay) {
+		aSelectedOverlays = this.getSelectedOverlays().filter(function (oElementOverlay) {
 			return oElementOverlay !== oOverlay;
 		});
 		aSelectedOverlays.unshift(oOverlay);

package/src/sap/ui/dt/plugin/ControlDragDrop.js

@@ -26,7 +26,7 @@ sap.ui.define([
 	 * @class The ControlDragDrop enables D&D functionality for the overlays based on aggregation types
 	 * @extends sap.ui.dt.plugin.DragDrop
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 * @constructor
 	 * @private
 	 * @since 1.30

package/src/sap/ui/dt/plugin/CutPaste.js

@@ -33,7 +33,7 @@ sap.ui.define([
 	 * @class The CutPaste enables Cut & Paste functionality for the overlays based on aggregation types
 	 * @extends sap.ui.dt.Plugin
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 * @constructor
 	 * @private
 	 * @since 1.34