@openui5/sap.ui.documentation 1.144.0 → 1.146.0

package/src/sap/ui/documentation/sdk/controller/util/UsageTracker.js

@@ -26,8 +26,10 @@ sap.ui.define(
             const oURL = new URL(sURL),
                 sSectionTitle = oRouter.getRouteTopLevelTitle(oRouteConfig);
 
+            var sHash = oURL.hash.replace(/\.html/, '');
+
             this.url = sURL;
-            this.name = oURL.pathname + oURL.hash;
+            this.name = oURL.pathname + sHash;
             this.section = sSectionTitle || "/";
             this.title = undefined;
             this.language = oUserLanguageTag.language;
@@ -67,6 +69,7 @@ sap.ui.define(
             "sap.ui.documentation.sdk.controller.util.UsageTracker",
             {
                 constructor: function (oComponent) {
+                    BaseObject.call(this);
                     this._oComponent = oComponent;
                     this._oRouter = oComponent.getRouter();
                     this._oConfig = oComponent.getConfig();
@@ -250,6 +253,7 @@ sap.ui.define(
                  * Triggered when router does not find the route
                  */
                 _logPageNotFound: function (sHash) {
+                    sHash = sHash.replace(/\.html/, '');
                     this._addToLogs({
                         event: "errorPage",
                         page: {
@@ -274,9 +278,10 @@ sap.ui.define(
                         oPageInfo = new PageInfo(oRouteConfig, this._oRouter);
                     } else {
                         var oURL = new URL(window.location.href);
+                        var sHash = oURL.hash.replace(/\.html/, '');
                         oPageInfo = {
                             url: window.location.href,
-                            name: oURL.pathname + oURL.hash,
+                            name: oURL.pathname + sHash,
                             section: "/"
                         };
                     }

package/src/sap/ui/documentation/sdk/cookieSettingsDialog/controller/CookieSettingsDialog.controller.js

@@ -16,6 +16,7 @@ sap.ui.define([
 		return Controller.extend("sap.ui.documentation.sdk.cookieSettingsDialog.controller.CookieSettingsDialog", {
 
 			constructor: function() {
+				Controller.call(this);
 				this._oCookiesUtil = null;
 				this._oRootView = null;
 				this._oInitOptions = null;

package/src/sap/ui/documentation/sdk/thirdparty/highlight.js/highlight.js

@@ -998,10 +998,10 @@ var hljs = (function () {
    * @param {string} message
    */
   const deprecated = (version, message) => {
-    if (seenDeprecations[`1.144.0/${message}`]) return;
+    if (seenDeprecations[`1.146.0/${message}`]) return;
 
-    console.log(`Deprecated as of 1.144.0. ${message}`);
-    seenDeprecations[`1.144.0/${message}`] = true;
+    console.log(`Deprecated as of 1.146.0. ${message}`);
+    seenDeprecations[`1.146.0/${message}`] = true;
   };
 
   /* eslint-disable no-throw-literal */

package/src/sap/ui/documentation/sdk/util/DocumentationRouter.js

@@ -732,6 +732,11 @@ sap.ui.define([
 		return sNewHref;
 	};
 
+	DocumentationRouter.prototype.destroy = function () {
+		this.detachPopstateHandler();
+		Router.prototype.destroy.apply(this, arguments);
+	};
+
 	// util
 	function getClosestParentLink(oAnchorElement, bSameWindow, iMaxDrillUp) {
 		var bIsAnchor = isAnchorElement(oAnchorElement, bSameWindow), iDrillUp = 0;

package/src/sap/ui/documentation/sdk/view/FooterMaster.fragment.xml

@@ -2,7 +2,7 @@
 		xmlns="sap.m"
 		xmlns:tnt="sap.tnt"
 		xmlns:core="sap.ui.core">
-	<tnt:NavigationList itemSelect="handleFooterMasterItemPress">
+	<tnt:NavigationList visible="{= !${device>/system/phone} }" itemSelect="handleFooterMasterItemPress">
 		<tnt:NavigationListItem icon="sap-icon://compare" key="legal" text="{i18n>APP_INFORMATION_BTN_LEGAL}" />
 		<tnt:NavigationListItem icon="sap-icon://locked" key="privacy" text="{i18n>APP_INFORMATION_BTN_PRIVACY}" />
 		<tnt:NavigationListItem icon="sap-icon://permission" text="{i18n>APP_INFORMATION_BTN_LICENSE}" key="license" visible="{versionData>/isOpenUI5}" />

package/src/sap/ui/documentation/sdk/view/SubApiDetail.view.xml

@@ -26,16 +26,16 @@
 				<headerTitle>
 					<ObjectPageDynamicHeaderTitle id="title">
 						<expandedHeading>
-							<m:FlexBox fitContainer="true" alignItems="Center">
+							<m:FlexBox fitContainer="true" direction="Column" alignItems="Start">
 								<m:Title text="{/title}" wrapping="true" />
-								<m:Label text="{/subTitle}" />
+								<m:Label text="{/subTitle}" class="sapUiTinyMarginTop" />
 							</m:FlexBox>
 						</expandedHeading>
 
 						<snappedHeading>
-							<m:FlexBox fitContainer="true" alignItems="Center">
+							<m:FlexBox fitContainer="true" direction="Column" alignItems="Start">
 								<m:Title text="{/title}" wrapping="true" />
-								<m:Label text="{/subTitle}" />
+								<m:Label text="{/subTitle}" class="sapUiTinyMarginTop" />
 							</m:FlexBox>
 						</snappedHeading>
 
@@ -248,7 +248,7 @@
 														columnTitles="Param,Type,Default Value,Description"
 														columnCount="4"
 														class="sapUiDocumentationParamsTable">
-													<custom:Row>
+													<custom:Row expandable="{= ${typeInfo/refersToTypedef} === true}" typedefName="{= ${typeInfo/UI5Types} ? ${typeInfo/UI5Types/0} : ${typeInfo/type} }" expandToggle="onTypedefToggle">
 														<custom:ParamText text="{name}" phoneText="{phoneName}" depth="{depth}" optional="{optional}"/>
 														<custom:JSDocType typeInfo="{parts: ['typeInfo', 'types', 'type', 'linkEnabled'], formatter: '.formatter.formatJSDocType'}"/>
 														<m:Text text="{defaultValue}" wrapping="false"/>
@@ -295,7 +295,7 @@
 												<m:Text text="{defaultValue}"/>
 												<layout:VerticalLayout width="100%">
 													<custom:JSDocText sanitizeContent="false" text="{description}"/>
-													<layout:HorizontalLayout width="100%">
+													<layout:HorizontalLayout>
 														<m:ObjectStatus text="Visibility: {parts : [{path : 'visibility'}, {path : 'allowedFor'}], formatter : '.formatter.formatVisibility'}"
 															state="{= ${visibility} === 'public' ? 'Success' : 'Warning'}"/>
 														<core:Icon
@@ -512,7 +512,7 @@
 
 												<custom:JSDocText sanitizeContent="false" text="{path: 'event>description', formatter: '.formatter.escapeSettingsValue'}"/>
 
-												<layout:HorizontalLayout width="100%">
+												<layout:HorizontalLayout>
 													<m:ObjectStatus text="Visibility: {parts : [{path : 'event>visibility'}, {path : 'event>allowedFor'}], formatter : '.formatter.formatVisibility'}"
 													state="{= ${event>visibility} === 'public' ? 'Success' : 'Warning'}" class="sapUiSmallMarginBottom"/>
 													<core:Icon
@@ -544,7 +544,7 @@
 												<template:if test="{= !!${event>parameters} &amp;&amp; ${event>parameters}.length > 0}">
 													<custom:LightTable columnTitles="Param,Type,Description" columnCount="3">
 														<template:repeat list="{event>parameters}" var="parameter">
-															<custom:Row>
+															<custom:Row expandable="{= ${parameter>typeInfo/refersToTypedef} === true}" typedefName="{= ${parameter>typeInfo/UI5Types} ? ${parameter>typeInfo/UI5Types/0} : ${parameter>typeInfo/type} }" expandToggle="onTypedefToggle">
 																<custom:ParamText text="{parameter>name}" phoneText="{parameter>phoneName}" depth="{parameter>depth}" optional="{parameter>optional}"/>
 																<custom:JSDocType typeInfo="{parts: ['parameter>typeInfo', 'parameter>types', 'parameter>type', 'parameter>linkEnabled'], formatter: '.formatter.stringifyJSDocType'}"/>
 																<layout:VerticalLayout>
@@ -627,7 +627,7 @@
 													</layout:VerticalLayout>
 
 													<m:FlexBox class="sapUiTinyMarginBottom">
-														<layout:HorizontalLayout width="100%">
+														<layout:HorizontalLayout>
 														<m:ObjectStatus text="Visibility: {parts : [{path : 'method>visibility'}, {path : 'method>allowedFor'}], formatter : '.formatter.formatVisibility'}"
 														state="{= ${method>visibility} === 'public' ? 'Success' : 'Warning'}"/>
 														<core:Icon
@@ -668,7 +668,7 @@
 																columnTitles="Param,Type,Default Value,Description"
 																class="sapUiDocumentationParamsTable">
 															<template:repeat list="{method>parameters}" var="parameter">
-																<custom:Row>
+																<custom:Row expandable="{= ${parameter>typeInfo/refersToTypedef} === true}" typedefName="{= ${parameter>typeInfo/UI5Types} ? ${parameter>typeInfo/UI5Types/0} : ${parameter>typeInfo/type} }" expandToggle="onTypedefToggle">
 																	<custom:ParamText text="{parameter>name}" phoneText="{parameter>phoneName}" depth="{parameter>depth}" optional="{parameter>optional}"/>
 																	<custom:JSDocType typeInfo="{parts: ['parameter>typeInfo','parameter>types'], formatter: '.formatter.stringifyJSDocType'}"/>
 																	<m:Text text="{parameter>defaultValue}" wrapping="false"/>
@@ -782,20 +782,6 @@
 						</ObjectPageSection>
 					</template:if>
 
-					<template:if test="{data>/hasFAQ}">
-						<ObjectPageSection id="faq" title="FAQ" class="faqContent">
-							<subSections>
-								<custom:ObjectPageSubSection>
-									<custom:blocks>
-										<core:HTML id="parserId" content="{/faqContent}"/>
-									</custom:blocks>
-								</custom:ObjectPageSubSection>
-							</subSections>
-						</ObjectPageSection>
-					</template:if>
-
-					<core:ExtensionPoint name="customSections" />
-
 				</sections>
 
 			</ObjectPageLayout>

package/src/sap/ui/documentation/themes/base/Documentation.less

@@ -42,7 +42,7 @@ html.sap-tablet:not(.sap-desktop) {
     }
 }
 
-.faqContent {
+.sectionContent {
     details {
         margin: 0.8em;
     }
@@ -67,10 +67,10 @@ html.sap-tablet:not(.sap-desktop) {
 }
 
 #d4h5-main-container,
-.faqContent {
+.sectionContent {
     font-size: 0.875em;
 
-    &.faqContent pre > code {
+    &.sectionContent pre > code {
         font-family: monospace;
     }
 
@@ -157,7 +157,7 @@ html.sap-tablet:not(.sap-desktop) {
         }
     }
 
-    &.faqContent h2,
+    &.sectionContent h2,
     .section.topic > .innerTitle > h2 {
         font-size: 2em;
         font-weight: 400;

package/src/sap/ui/documentation/themes/base/LightTable.less

@@ -144,6 +144,30 @@
 	border-bottom: solid 1px #e5e5e5;
 	border-left: solid 1px #e5e5e5;
 	border-right: solid 1px #e5e5e5;
+
+	&.subrow,
+	&.expanded {
+		background-color: #f5f5f5;
+	}
+
+	/* Expandable rows - display icon and ParamText inline */
+	&.collapsed,
+	&.expanded {
+		> .cell:first-child {
+			display: flex;
+			align-items: flex-start;
+
+			.sapUiDocTypedefExpandIcon {
+				margin-top: 0.25rem;
+				flex-shrink: 0;
+				color: var(--sapButton_Lite_TextColor);
+			}
+
+			.sapUiParamText {
+				flex: 1;
+			}
+		}
+	}
 }
 
 .sapUiTheme-sap_belize_hcb .sapUiDocLightTable .head,
@@ -182,6 +206,11 @@
 	.sapUiDocLightTable .row {
 		background-color: @sapBaseColor;
 		border-bottom: solid 1px @sapPageHeader_BorderColor;
+
+		&.subrow,
+		&.expanded {
+			background-color: #282c34;
+		}
 	}
 
 	.sapUiDocLightTable .head,

package/src/sap/ui/documentation/themes/sap_belize_base/Documentation.less

@@ -42,7 +42,7 @@ html.sap-tablet:not(.sap-desktop) {
     }
 }
 
-.faqContent {
+.sectionContent {
     details {
         margin: 0.8em;
     }
@@ -67,10 +67,10 @@ html.sap-tablet:not(.sap-desktop) {
 }
 
 #d4h5-main-container,
-.faqContent {
+.sectionContent {
     font-size: 0.875em;
 
-    &.faqContent pre > code {
+    &.sectionContent pre > code {
         font-family: monospace;
     }
 
@@ -156,7 +156,7 @@ html.sap-tablet:not(.sap-desktop) {
         }
     }
 
-    &.faqContent h2,
+    &.sectionContent h2,
     .section.topic > .innerTitle > h2 {
         font-size: 2em;
         font-weight: 400;

package/src/sap/ui/documentation/themes/sap_horizon_dark/Documentation.less

@@ -3,7 +3,7 @@
 @code-highlight-color: #24435e;
 
 #d4h5-main-container,
-.faqContent {
+.sectionContent {
 
 	.note,
 	pre.codeblock,