@openui5/sap.ui.core 1.96.5 → 1.99.0

package/src/sap/ui/performance/trace/Passport.js

@@ -53,7 +53,7 @@ sap.ui.define(["sap/ui/performance/XHRInterceptor", "sap/ui/thirdparty/URI"], fu
 	var Passport = {};
 
 	/**
-	 * @returns {String} a generated a passport header
+	 * @returns {string} a generated a passport header
 	 * @private
 	 */
 	Passport.header = function(trcLvl, RootID, TransID, component, action) {
@@ -125,7 +125,7 @@ sap.ui.define(["sap/ui/performance/XHRInterceptor", "sap/ui/thirdparty/URI"], fu
 	};
 
 	/**
-	 * @param {String} lvl Tracing level to be calculated
+	 * @param {string} lvl Tracing level to be calculated
 	 * @return {int[]} Array with two int representations of characters for trace level
 	 * @private
 	 */
@@ -151,7 +151,7 @@ sap.ui.define(["sap/ui/performance/XHRInterceptor", "sap/ui/thirdparty/URI"], fu
 	};
 
 	/**
-	 * @returns {String} a generated GUID
+	 * @returns {string} a generated GUID
 	 * @private
 	 */
 	Passport.createGUID = function() {

package/src/sap/ui/qunit/utils/ControlIterator.js

@@ -53,7 +53,7 @@ sap.ui.define(['sap/ui/core/Core', "sap/ui/VersionInfo"],
 	 * @namespace
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @public
 	 * @since 1.48.0

package/src/sap/ui/qunit/utils/MemoryLeakCheck.js

@@ -27,7 +27,7 @@ sap.ui.define([ 'sap/ui/core/Element', 'sap/ui/core/Control', 'sap/ui/core/Core'
 	 * @namespace
 	 *
 	 * @author SAP SE
-	 * @version 1.96.5
+	 * @version 1.99.0
 	 *
 	 * @public
 	 * @since 1.48.0

package/src/sap/ui/test/BlanketReporter.js

@@ -514,4 +514,4 @@ sap.ui.define([
 			});
 		}
 	};
-}, /* bExport= */ false);
+});

package/src/sap/ui/test/Opa5.js

@@ -1115,7 +1115,7 @@ sap.ui.define([
 		/**
 		 * Settings for a new page object, consisting of actions and assertions.
 		 *
-		 * @typedef {Object} sap.ui.test.PageObjectDefinition
+		 * @typedef {object} sap.ui.test.PageObjectDefinition
 		 *
 		 * @property {string} [viewName]
 		 *   When a <code>viewName</code> is given, all <code>waitFor</code> calls inside of the page object

package/src/sap/ui/test/TestUtils.js

@@ -5,12 +5,12 @@
  */
 
 sap.ui.define([
-	"jquery.sap.sjax",
 	"sap/base/Log",
 	"sap/base/util/merge",
 	"sap/base/util/UriParameters",
+	"sap/ui/thirdparty/jquery",
 	"sap/ui/core/Core" // provides sap.ui.getCore()
-], function (jQuery, Log, merge, UriParameters) {
+], function (Log, merge, UriParameters, jQuery) {
 	"use strict";
 	/*global QUnit, sinon */
 	// Note: The dependency to Sinon.JS has been omitted deliberately. Most test files load it via

package/src/sap/ui/test/_LogCollector.js

@@ -15,7 +15,7 @@ sap.ui.define([
 
 	/**
 	 * A central place to collect logs during the execution of a task
-	 * Listens to jQuery.sap.log.* to collect the logs
+	 * Listens to sap/base/Log.* to collect the logs
 	 * Only collects logs from loggers with a certain component name
 	 * By default only logs from components in sap.ui.test are collected - this can be used to collect all the logs during an OPA test
 	 * You always need to start the collector to control when to actually collect logs

package/src/sap/ui/test/actions/Action.js

@@ -207,9 +207,12 @@ function (ManagedObject, QUnitUtils, Opa5, Device, jQueryDOM, _OpaLogger) {
 		 *
 		 * @param {string} sName Name of the mouse event
 		 * @param {Element} oDomRef DOM element on which the event is going to be triggered
+		 * @param {boolean} bShiftKey Indicates whether the shift key is down in addition
+	 	 * @param {boolean} bAltKey Indicates whether the alt key is down in addition
+	 	 * @param {boolean} bCtrlKey Indicates whether the ctrl key is down in addition
 		 * @private
 		 */
-		_createAndDispatchMouseEvent: function (sName, oDomRef) {
+		_createAndDispatchMouseEvent: function (sName, oDomRef, bShiftKey, bAltKey, bCtrlKey, iClientX, iClientY) {
 			// ignore scrolled down stuff (client X, Y not set)
 			// and assume stuff is over the whole screen (screen X, Y not set)
 			// See file jquery.sap.events.js for some insights to the magic
@@ -224,8 +227,14 @@ function (ManagedObject, QUnitUtils, Opa5, Device, jQueryDOM, _OpaLogger) {
 				radiusY: 1,
 				rotationAngle: 0,
 				button: iLeftMouseButtonIndex,
-				type: sName // include the type so jQuery.event.fixHooks can copy properties properly
+				type: sName, // include the type so jQuery.event.fixHooks can copy properties properly
+				shiftKey: bShiftKey,
+				altKey: bAltKey,
+				ctrlKey: bCtrlKey,
+				clientX: iClientX,
+				clientY: iClientY
 			});
+
 			oDomRef.dispatchEvent(oMouseEvent);
 		},
 

package/src/sap/ui/test/actions/Press.js

@@ -42,6 +42,45 @@ sap.ui.define([
 	var Press = Action.extend("sap.ui.test.actions.Press", /** @lends sap.ui.test.actions.Press.prototype */ {
 
 		metadata : {
+			properties: {
+				/**
+				 * If it is set to <code>true</code>, the Alt Key modifier will be used
+				 * @since 1.97
+				 */
+				altKey: {
+					type: "boolean"
+				},
+				/**
+				 * If it is set to <code>true</code>, the Shift Key modifier will be used
+				 * @since 1.97
+				 */
+				shiftKey: {
+					type: "boolean"
+				},
+				/**
+				 * If it is set to <code>true</code>, the Control Key modifier will be used
+				 * @since 1.97
+				 */
+				ctrlKey: {
+					type: "boolean"
+				},
+				/**
+				 * Provide percent value for the X coordinate axis to calculate the position of the click event.
+				 * The value must be in the range [0 - 100]
+				 * @since 1.98
+				 */
+				xPercentage: {
+					type: "float"
+				},
+				/**
+				 * Provide percent value for the Y coordinate axis to calculate the position of the click event.
+				 * The value must be in the range [0 - 100]
+				 * @since 1.98
+				 */
+				yPercentage: {
+					type: "float"
+				}
+			},
 			publicMethods : [ "executeOn" ]
 		},
 
@@ -62,6 +101,43 @@ sap.ui.define([
 			var $ActionDomRef = this.$(oControl),
 				oActionDomRef = $ActionDomRef[0];
 
+			var iClientX, iClientY;
+
+			var bAltKey = this.getAltKey();
+			var bCtrlKey = this.getCtrlKey();
+			var bShiftKey = this.getShiftKey();
+
+			var iXPercentage = this.getXPercentage();
+			var iYPercentage = this.getYPercentage();
+
+			// check if the percentage is in the range 0-100
+			if (iXPercentage < 0 || iXPercentage > 100){
+				this.oLogger.error("Please provide a valid X percentage in the range: 0 - 100");
+				return;
+			}
+
+			if (iYPercentage < 0 || iYPercentage > 100){
+				this.oLogger.error("Please provide a valid Y percentage in the range: 0 - 100");
+				return;
+			}
+
+			// get the width and the height of the control
+			var oRect = oActionDomRef.getBoundingClientRect();
+
+			var iWidth = oRect.width;
+			var iHeight = oRect.height;
+
+			var iX = oRect.left + window.scrollX;
+			var iY = oRect.top + window.scrollY;
+
+			if (iXPercentage || iXPercentage === 0){
+				iClientX = ((iXPercentage / 100) * iWidth) + iX;
+			}
+
+			if (iYPercentage || iYPercentage === 0){
+				iClientY = ((iYPercentage / 100) * iHeight) + iY;
+			}
+
 			if ($ActionDomRef.length) {
 				this.oLogger.timestamp("opa.actions.press");
 				this.oLogger.debug("Pressed the control " + oControl);
@@ -69,10 +145,10 @@ sap.ui.define([
 				this._tryOrSimulateFocusin($ActionDomRef, oControl);
 
 				// the missing events like saptouchstart and tap will be fired by the event simulation
-				this._createAndDispatchMouseEvent("mousedown", oActionDomRef);
+				this._createAndDispatchMouseEvent("mousedown", oActionDomRef, null, null, null, iClientX, iClientY);
 				this.getUtils().triggerEvent("selectstart", oActionDomRef);
-				this._createAndDispatchMouseEvent("mouseup", oActionDomRef);
-				this._createAndDispatchMouseEvent("click", oActionDomRef);
+				this._createAndDispatchMouseEvent("mouseup", oActionDomRef, null, null, null, iClientX, iClientY);
+				this._createAndDispatchMouseEvent("click", oActionDomRef, bShiftKey, bAltKey, bCtrlKey);
 				//Focusout simulation removed in order to fix Press action behavior
 				//since in real scenario manual press action does not fire focusout event
 			}

package/src/sap/ui/test/autowaiter/_XHRWaiter.js

@@ -49,7 +49,7 @@ sap.ui.define([
 	// Check if sinon is already faking the Xhr
 	hookIntoSinonRestore();
 
-	// Hook into XHR opent for sinon XHRs
+	// Hook into XHR open for sinon XHRs
 	var fnOriginalFakeOpen = sinon.FakeXMLHttpRequest.prototype.open;
 	sinon.FakeXMLHttpRequest.prototype.open = function () {
 		return fnOriginalFakeOpen.apply(this, hookIntoXHROpen.apply(this, arguments));

package/src/sap/ui/test/generic/_EnforceSemanticRendering.js

@@ -0,0 +1,111 @@
+/*!
+ * OpenUI5
+ * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
+ */
+
+/* global QUnit */
+sap.ui.define([], function() {
+	"use strict";
+
+	/**
+	 * @namespace
+	 * @private
+	 * @ui5-restricted Only for DIST layer libraries
+	 */
+	var _EnforceSemanticRendering = {
+		/**
+		 * @param {object} mLibInfo Info object containing the library name and an array with excludes
+		 * @param {string} mLibInfo.library The library name in dot notation, e.g. "sap.ui.core"
+		 * @param {string[]} mLibInfo.exlcudes An array of control names in dot notation, which are NOT migrated and should be excluded from the test
+		 * @returns {Promise<undefined>} Returns resovled Promise after all tests are executed
+		 *
+		 * @private
+		 * @ui5-restricted Only for DIST layer libraries
+		 */
+		run : function(mLibInfo) {
+			var sLib = mLibInfo.library;
+			var aExcludes = mLibInfo.excludes || [];
+
+			return new Promise(function(res, rej) {
+				sap.ui.getCore().loadLibrary(sLib, { async: true }).then(function(library) {
+					var aControls = (library && library.controls) || [];
+					var aPromises = [];
+
+					aControls.forEach(function(sClass) {
+						// Generate QUnit test for all controls
+						aPromises.push(new Promise(function(res, rej) {
+							var oInfo = {
+								control: sClass
+							};
+
+							var sControlClass = sClass.replace(/\./g, "/");
+							sap.ui.require([sControlClass], function(ControlClass) {
+								try {
+									var oRenderer = ControlClass.getMetadata().getRenderer();
+
+									if (oRenderer) {
+										oInfo.version = Object.prototype.hasOwnProperty.call(oRenderer, "apiVersion") ? oRenderer.apiVersion : 1;
+
+										if (aExcludes.includes(sClass)) {
+											if (oInfo.version == 2) {
+												oInfo.wrongExclude = true;
+												oInfo.description = "defined in the excludes";
+											} else { // version 1
+												oInfo.skip = true;
+											}
+										}
+									} else {
+										oInfo.description = "No Renderer Class available";
+										oInfo.skip = true;
+									}
+
+								} catch (e) {
+									oInfo.description = "No Renderer Class available";
+									oInfo.skip = true;
+								}
+
+								res(oInfo);
+							}, function() {
+								oInfo.description = "Control Class could not be loaded";
+
+								if (aExcludes.includes(sClass)) {
+									oInfo.skip = true;
+								} // else don't skip if control class is not maintained in excludes
+
+								res(oInfo);
+							});
+						}));
+					});
+
+					res(aPromises);
+				});
+			}).then(function(aPromises) {
+				// Add tests
+				return new Promise(function(res, rej) {
+					Promise.all(aPromises).then(function(aInfo) {
+						QUnit.module("EnforceSemanticRendering Tests: " + mLibInfo.library);
+
+						QUnit.test("library controls loaded", function(assert) {
+							assert.ok(aInfo, aInfo.length + " controls loaded");
+						});
+
+						aInfo.forEach(function(oInfo) {
+							QUnit[oInfo.skip ? "skip" : "test"](oInfo.control + " " + (oInfo.description || ""), function(assert) {
+								if (oInfo.wrongExclude) {
+									assert.ok(false, "The control '" + oInfo.control + "' is maintained in the exclude configuration, but its renderer is configured with apiVersion 2.");
+								} else {
+									assert.equal(oInfo.version, 2, "Semantic Rendering enabled.");
+								}
+							});
+						});
+
+						res();
+					});
+				});
+			});
+		}
+	};
+
+	return _EnforceSemanticRendering;
+});

package/src/sap/ui/test/starter/createSuite.js

@@ -216,8 +216,7 @@
 
 	};
 
-	var oSuiteReadyEvent = document.createEvent("CustomEvent");
-	oSuiteReadyEvent.initCustomEvent("sap-ui-testsuite-ready", true, true, {});
+	var oSuiteReadyEvent = new CustomEvent("sap-ui-testsuite-ready");
 	window.dispatchEvent(oSuiteReadyEvent);
 
 }));

package/src/sap/ui/thirdparty/jquery-mobile-custom.js

@@ -1857,12 +1857,9 @@ if ( eventCaptureSupported ) {
 	// coordinate is proximitely the same as the coordinate of recorded touch
 	// events and the mouse event's target is different than the target of the
 	// touch event.
-	// Do not suppress mouse and click events on Windows Phone.
-	if (!(sap.ui.Device.os.windows_phone && sap.ui.Device.os.version < 10)) {
-		document.addEventListener( "mousedown", suppressEvent, true );
-		document.addEventListener( "mouseup", suppressEvent, true );
-		document.addEventListener( "click", suppressEvent, true );
-	}
+	document.addEventListener( "mousedown", suppressEvent, true );
+	document.addEventListener( "mouseup", suppressEvent, true );
+	document.addEventListener( "click", suppressEvent, true );
 }
 })( jQuery, window, document );
 

package/src/sap/ui/thirdparty/jqueryui/jquery-ui-datepicker.js

@@ -197,7 +197,12 @@ $.extend(Datepicker.prototype, {
 			inst.append.remove();
 		}
 		if (appendText) {
-			inst.append = $("<span class='" + this._appendClass + "'>" + appendText + "</span>");
+			// ##### BEGIN: MODIFIED BY SAP
+			// inst.append = $("<span class='" + this._appendClass + "'>" + appendText + "</span>");
+			inst.append = $( "<span></span>" )
+				.addClass( this._appendClass )
+				.text( appendText );
+			// ##### END: MODIFIED BY SAP
 			input[isRTL ? "before" : "after"](inst.append);
 		}
 
@@ -220,12 +225,43 @@ $.extend(Datepicker.prototype, {
 		if (showOn === "button" || showOn === "both") { // pop-up date picker when button clicked
 			buttonText = this._get(inst, "buttonText");
 			buttonImage = this._get(inst, "buttonImage");
-			inst.trigger = $(this._get(inst, "buttonImageOnly") ?
+
+			// ##### BEGIN: MODIFIED BY SAP
+			/*
+			inst.trigger = $( this._get(inst, "buttonImageOnly" ) ?
 				$("<img/>").addClass(this._triggerClass).
 					attr({ src: buttonImage, alt: buttonText, title: buttonText }) :
 				$("<button type='button'></button>").addClass(this._triggerClass).
 					html(!buttonImage ? buttonText : $("<img/>").attr(
 					{ src:buttonImage, alt:buttonText, title:buttonText })));
+			*/
+
+			if ( this._get( inst, "buttonImageOnly" ) ) {
+				inst.trigger = $( "<img>" )
+				.addClass( this._triggerClass )
+				.attr( {
+					src: buttonImage,
+					alt: buttonText,
+					title: buttonText
+				} );
+			} else {
+				inst.trigger = $( "<button type='button'></button>" )
+				.addClass( this._triggerClass );
+				if ( buttonImage ) {
+					inst.trigger.html(
+						$( "<img>" )
+						.attr( {
+							src: buttonImage,
+							alt: buttonText,
+							title: buttonText
+						} )
+					);
+				} else {
+					inst.trigger.text( buttonText );
+				}
+			}
+			// ##### END: MODIFIED BY SAP
+
 			input[isRTL ? "before" : "after"](inst.trigger);
 			inst.trigger.click(function() {
 				if ($.datepicker._datepickerShowing && $.datepicker._lastInput === input[0]) {
@@ -1047,7 +1083,10 @@ $.extend(Datepicker.prototype, {
 			altFormat = this._get(inst, "altFormat") || this._get(inst, "dateFormat");
 			date = this._getDate(inst);
 			dateStr = this.formatDate(altFormat, date, this._getFormatConfig(inst));
-			$(altField).each(function() { $(this).val(dateStr); });
+			// ##### BEGIN: MODIFIED BY SAP
+			// $(altField).each(function() { $(this).val(dateStr); });
+			$( document ).find( altField ).val( dateStr );
+			// ##### END: MODIFIED BY SAP
 		}
 	},
 
@@ -1654,32 +1693,133 @@ $.extend(Datepicker.prototype, {
 			this._daylightSavingAdjust(new Date(drawYear, drawMonth - stepMonths, 1)),
 			this._getFormatConfig(inst)));
 
+		// ##### BEGIN: MODIFIED BY SAP
+		/*
 		prev = (this._canAdjustMonth(inst, -1, drawYear, drawMonth) ?
 			"<a class='ui-datepicker-prev ui-corner-all' data-handler='prev' data-event='click'" +
 			" title='" + prevText + "'><span class='ui-icon ui-icon-circle-triangle-" + ( isRTL ? "e" : "w") + "'>" + prevText + "</span></a>" :
 			(hideIfNoPrevNext ? "" : "<a class='ui-datepicker-prev ui-corner-all ui-state-disabled' title='"+ prevText +"'><span class='ui-icon ui-icon-circle-triangle-" + ( isRTL ? "e" : "w") + "'>" + prevText + "</span></a>"));
+		*/
+
+		if ( this._canAdjustMonth( inst, -1, drawYear, drawMonth ) ) {
+			prev = $( "<a></a>" )
+			.attr( {
+				"class": "ui-datepicker-prev ui-corner-all",
+				"data-handler": "prev",
+				"data-event": "click",
+				title: prevText
+			} )
+			.append(
+				$( "<span></span>" )
+				.addClass( "ui-icon ui-icon-circle-triangle-" +
+					( isRTL ? "e" : "w" ) )
+				.text( prevText )
+			)[ 0 ].outerHTML;
+		} else if ( hideIfNoPrevNext ) {
+			prev = "";
+		} else {
+			prev = $( "<a></a>" )
+			.attr( {
+				"class": "ui-datepicker-prev ui-corner-all ui-state-disabled",
+				title: prevText
+			} )
+			.append(
+				$( "<span></span>" )
+				.addClass( "ui-icon ui-icon-circle-triangle-" +
+					( isRTL ? "e" : "w" ) )
+				.text( prevText )
+			)[ 0 ].outerHTML;
+		}
+		// ##### END: MODIFIED BY SAP
 
 		nextText = this._get(inst, "nextText");
 		nextText = (!navigationAsDateFormat ? nextText : this.formatDate(nextText,
 			this._daylightSavingAdjust(new Date(drawYear, drawMonth + stepMonths, 1)),
 			this._getFormatConfig(inst)));
 
+		// ##### BEGIN: MODIFIED BY SAP
+		/*
 		next = (this._canAdjustMonth(inst, +1, drawYear, drawMonth) ?
 			"<a class='ui-datepicker-next ui-corner-all' data-handler='next' data-event='click'" +
 			" title='" + nextText + "'><span class='ui-icon ui-icon-circle-triangle-" + ( isRTL ? "w" : "e") + "'>" + nextText + "</span></a>" :
 			(hideIfNoPrevNext ? "" : "<a class='ui-datepicker-next ui-corner-all ui-state-disabled' title='"+ nextText + "'><span class='ui-icon ui-icon-circle-triangle-" + ( isRTL ? "w" : "e") + "'>" + nextText + "</span></a>"));
+		*/
+
+		if ( this._canAdjustMonth( inst, +1, drawYear, drawMonth ) ) {
+			next = $( "<a></a>" )
+			.attr( {
+				"class": "ui-datepicker-next ui-corner-all",
+				"data-handler": "next",
+				"data-event": "click",
+				title: nextText
+			} )
+			.append(
+				$( "<span></span>" )
+				.addClass( "ui-icon ui-icon-circle-triangle-" +
+					( isRTL ? "w" : "e" ) )
+				.text( nextText )
+			)[ 0 ].outerHTML;
+		} else if ( hideIfNoPrevNext ) {
+			next = "";
+		} else {
+			next = $( "<a></a>" )
+			.attr( {
+				"class": "ui-datepicker-next ui-corner-all ui-state-disabled",
+				title: nextText
+			} )
+			.append(
+				$( "<span></span>" )
+				.attr( "class", "ui-icon ui-icon-circle-triangle-" +
+					( isRTL ? "w" : "e" ) )
+				.text( nextText )
+			)[ 0 ].outerHTML;
+		}
+		// ##### END: MODIFIED BY SAP
 
 		currentText = this._get(inst, "currentText");
 		gotoDate = (this._get(inst, "gotoCurrent") && inst.currentDay ? currentDate : today);
 		currentText = (!navigationAsDateFormat ? currentText :
 			this.formatDate(currentText, gotoDate, this._getFormatConfig(inst)));
 
+		// ##### BEGIN: MODIFIED BY SAP
+		/*
 		controls = (!inst.inline ? "<button type='button' class='ui-datepicker-close ui-state-default ui-priority-primary ui-corner-all' data-handler='hide' data-event='click'>" +
 			this._get(inst, "closeText") + "</button>" : "");
 
 		buttonPanel = (showButtonPanel) ? "<div class='ui-datepicker-buttonpane ui-widget-content'>" + (isRTL ? controls : "") +
 			(this._isInRange(inst, gotoDate) ? "<button type='button' class='ui-datepicker-current ui-state-default ui-priority-secondary ui-corner-all' data-handler='today' data-event='click'" +
 			">" + currentText + "</button>" : "") + (isRTL ? "" : controls) + "</div>" : "";
+		*/
+
+		controls = "";
+		if ( !inst.inline ) {
+			controls = $( "<button></button>" )
+			.attr( {
+				type: "button",
+				"class": "ui-datepicker-close ui-state-default ui-priority-primary ui-corner-all",
+				"data-handler": "hide",
+				"data-event": "click"
+			} )
+			.text( this._get( inst, "closeText" ) )[ 0 ].outerHTML;
+		}
+
+		buttonPanel = "";
+		if ( showButtonPanel ) {
+			buttonPanel = $( "<div class='ui-datepicker-buttonpane ui-widget-content'></div>" )
+			.append( isRTL ? controls : "" )
+			.append( this._isInRange( inst, gotoDate ) ?
+				$( "<button></button>" )
+				.attr( {
+					type: "button",
+					"class": "ui-datepicker-current ui-state-default ui-priority-secondary ui-corner-all",
+					"data-handler": "today",
+					"data-event": "click"
+				} )
+				.text( currentText ) :
+				"" )
+			.append( isRTL ? "" : controls )[ 0 ].outerHTML;
+		}
+		// ##### END: MODIFIED BY SAP
 
 		firstDay = parseInt(this._get(inst, "firstDay"),10);
 		firstDay = (isNaN(firstDay) ? 0 : firstDay);

package/src/sap/ui/thirdparty/jqueryui/jquery-ui-position.js

@@ -157,7 +157,14 @@ $.fn.position = function( options ) {
 	options = $.extend( {}, options );
 
 	var atOffset, targetWidth, targetHeight, targetOffset, basePosition, dimensions,
-		target = $( options.of ),
+		// ##### BEGIN: MODIFIED BY SAP
+		// target = $( options.of ),
+
+		// Make sure string options are treated as CSS selectors
+		target = typeof options.of === "string" ?
+			$( document ).find( options.of ) :
+			$( options.of ),
+		// ##### END: MODIFIED BY SAP
 		within = $.position.getWithinInfo( options.within ),
 		scrollInfo = $.position.getScrollInfo( within ),
 		collision = ( options.collision || "flip" ).split( " " ),