@openui5/sap.ui.core 1.96.2 → 1.97.0

package/src/sap/ui/model/TreeBindingAdapter.js

@@ -78,8 +78,6 @@ sap.ui.define([
 
 		/**
 		 * Returns a tree state handle to encapsulate the actual tree state.
-		 * TODO: Encode the list to avoid conflicts with delimiters in the flat expanded list?
-		 *       Re-Check this when back-end support is implemented.
 		 *
 		 * This function is exposed in the sub-classes/adapters (e.g. ODataTreeBindingAdapter) if
 		 * necessary/possible.

package/src/sap/ui/model/TreeBindingUtils.js

@@ -110,6 +110,8 @@ sap.ui.define(function() {
 		} else if (iNewSectionEndIndex <= oPendingRequest.iSkip || oNewRequest.iSkip >= iPendingSectionEndIndex) {
 			//old and new sections do not overlap, either the new section is completely left or right from the old one
 		}
+
+		return undefined;
 	};
 
 	return TreeBindingUtils;

package/src/sap/ui/model/Type.js

@@ -19,7 +19,7 @@ sap.ui.define(['sap/ui/base/Object'],
 	 *
 	 * @extends sap.ui.base.Object
 	 * @public
-	 * @version 1.96.2
+	 * @version 1.97.0
 	 */
 	var Type = BaseObject.extend("sap.ui.model.Type", /** @lends sap.ui.model.Type.prototype */ {
 

package/src/sap/ui/model/analytics/AnalyticalBinding.js

@@ -4,7 +4,7 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
-// Disable some ESLint rules. camelcase (some "_" in names to indicate indexed variables (like in math)), valid-jsdoc (not completed yet), no-warning-comments (some TODOs are left)
+// Disable some ESLint rules. camelcase (some "_" in names to indicate indexed variables (like in math)), valid-jsdoc (not completed yet)
 // All other warnings, errors should be resolved
 /*eslint camelcase:0, valid-jsdoc:0, no-warning-comments:0, max-len:0 */
 
@@ -1476,7 +1476,6 @@ sap.ui.define([
 						oGroupIdRange.threshold);
 			}
 
-			// TODO check current code works, but it would be more natural if this _considerRequestGrouping would be outside of this loop
 			var aRequestId = [];
 			for (var j = -1, sGroupId2; (sGroupId2 = aGroupId[++j]) !== undefined; ) {
 				aRequestId.push(this._getRequestId(AnalyticalBinding._requestType.groupMembersQuery, {groupId: sGroupId2}));
@@ -2425,7 +2424,7 @@ sap.ui.define([
 				aGroupMembersAutoExpansionRequestDetails.push(oLevelMembersRequestDetails);
 				aRequestId.push(oLevelMembersRequestDetails.sRequestId);
 			} else if (oLevelFilter && oLevelFilter.aFilters.length > 0) {
-				if (!oLevelFilter._bMultiFilter || oLevelFilter.bAnd) { // TODO remove this test once impl got mature to get rid of access to internal member; it is a consistency check if break-up will deliver expected results...
+				if (!oLevelFilter._bMultiFilter || oLevelFilter.bAnd) {
 					oLogger.fatal("level filter in wrong shape; cannot break it up");
 				}
 				for (var i = 0; i < oLevelFilter.aFilters.length; i++) { // break up level filter into its tuple filters combined with logical OR
@@ -2941,7 +2940,7 @@ sap.ui.define([
 			this.mServiceFinalLength[sGroupId] = true;
 			this._setServiceKey(this._getKeyIndexMapping(sGroupId, 0), AnalyticalBinding._artificialRootContextGroupId);
 			this.bNeedsUpdate = true;
-			// simulate the async behavior for the root context in case of having no sums (TODO: reconsider!)
+			// simulate the async behavior for the root context in case of having no sums
 			setTimeout(function() {
 				if (that._cleanupGroupingForCompletedRequest(oRequestDetails.sRequestId)) {
 					that.fireDataReceived({__simulateAsyncAnalyticalBinding: true});
@@ -4215,8 +4214,6 @@ sap.ui.define([
 
 	// substitute for indexOf in the key array for some group
 	AnalyticalBinding.prototype._findKeyIndex = function(sGroupId, sKey) {
-		// TODO optimize by first looking into mMultiUnitKey; if not found, search in mServiceKey; if not found, return -1
-
 		// naive implementation follows
 		var aKeyIndex = this.mKeyIndex[sGroupId];
 		var aServiceKey = this.mServiceKey[sGroupId];
@@ -4601,10 +4598,14 @@ sap.ui.define([
 							bChangeDetected = true;
 							return false;
 						}
+
+						return true;
 					});
 					if (bChangeDetected) {
 						return false;
 					}
+
+					return true;
 				});
 			}
 			if (!mChangedEntities && !mEntityTypes) { // default
@@ -4640,10 +4641,14 @@ sap.ui.define([
 							bChangeDetected = true;
 							return false;
 						}
+
+						return true;
 					});
 					if (bChangeDetected) {
 						return false;
 					}
+
+					return true;
 				});
 			}
 		}
@@ -4782,6 +4787,7 @@ sap.ui.define([
 			return this.oModel._createRequestUrl(sPath, null, aParam).replace(/ /g, "%20");
 		}
 
+		return undefined;
 	};
 
 	//**********************************

package/src/sap/ui/model/analytics/AnalyticalTreeBindingAdapter.js

@@ -54,9 +54,7 @@ sap.ui.define([
 	 * Used by the AnalyticalTable to display the sum row.
 	 */
 	AnalyticalTreeBindingAdapter.prototype.getGrandTotalContext = function () {
-		if (this._oRootNode) {
-			return this._oRootNode.context;
-		}
+		return this._oRootNode && this._oRootNode.context;
 	};
 
 	/*
@@ -64,9 +62,7 @@ sap.ui.define([
 	 * Used by the AnalyticalTable to display the sum row.
 	 */
 	AnalyticalTreeBindingAdapter.prototype.getGrandTotalNode = function () {
-		if (this._oRootNode) {
-			return this._oRootNode;
-		}
+		return this._oRootNode;
 	};
 
 	/*
@@ -109,7 +105,6 @@ sap.ui.define([
 
 		// if the node was not found in the current tree snapshot -> rebuild the tree, and if necessary request the node
 		if (!oNode || !oNode.context) {
-			//@TODO: Maybe preserve the Row Index Cache, before calling getContexts, and restore it afterwards
 			//Beware: getContexts might return nothing, if the context was not yet loaded!
 			oNode = {context: this.getContexts(iIndex, 1, 0)[0]};
 		}
@@ -192,8 +187,9 @@ sap.ui.define([
 		var aContexts = [];
 		//find missing spots in our visible section
 		var mMissingSections;
+		var oNode;
 		for (var i = 0; i < aNodes.length; i++) {
-			var oNode = aNodes[i];
+			oNode = aNodes[i];
 
 			//user scrolled into the water mark node, which is the last of the guaranteed loaded page (length + threshold)
 			if (this._isRunningInAutoExpand(TreeAutoExpandMode.Bundled) && this._oWatermark) {
@@ -233,7 +229,7 @@ sap.ui.define([
 			// try to fill gaps in our return array if we already have new data (thanks to thresholding)
 			aContexts = [];
 			for (var j = 0; j < aNodes.length; j++) {
-				var oNode = aNodes[j];
+				oNode = aNodes[j];
 				aContexts.push(oNode.context);
 			}
 		}
@@ -281,6 +277,8 @@ sap.ui.define([
 				aResults.push(oNode.sumNode);
 			}
 		}
+
+		return undefined;
 	};
 
 	/*
@@ -589,17 +587,15 @@ sap.ui.define([
 		// in case we have no grouping at all, the "groupID" for each node is based on its position as the roots child
 		if (!this.isGrouped() && oNode && oNode.positionInParent) {
 			sGroupID = "/" + oNode.positionInParent + "/";
-		} else {
+		} else if (oNode.level > iMaxLevel) {
 			// if the level of the node exceeds the maximum level (in the analytical case, this is the aggregation level),
 			// the group id is also appended with the relative parent position
-			if (oNode.level > iMaxLevel) {
-				sGroupID = this._getGroupIdFromContext(oNode.context, iMaxLevel);
-				assert(oNode.positionInParent != undefined, "If the node level is greater than the number of grouped columns, the position of the node to its parent must be defined!");
-				sGroupID +=  oNode.positionInParent + "/";
-			} else {
-				//this is the best case, the node sits on a higher level than the aggregation level
-				sGroupID = this._getGroupIdFromContext(oNode.context, oNode.level);
-			}
+			sGroupID = this._getGroupIdFromContext(oNode.context, iMaxLevel);
+			assert(oNode.positionInParent != undefined, "If the node level is greater than the number of grouped columns, the position of the node to its parent must be defined!");
+			sGroupID +=  oNode.positionInParent + "/";
+		} else {
+			//this is the best case, the node sits on a higher level than the aggregation level
+			sGroupID = this._getGroupIdFromContext(oNode.context, oNode.level);
 		}
 		return sGroupID;
 	};
@@ -779,6 +775,8 @@ sap.ui.define([
 				bHasMeasures = true;
 				return false;
 			}
+
+			return true;
 		});
 		return bHasMeasures;
 	};

package/src/sap/ui/model/json/JSONModel.js

@@ -44,7 +44,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.ClientModel
 	 *
 	 * @author SAP SE
-	 * @version 1.96.2
+	 * @version 1.97.0
 	 * @public
 	 * @alias sap.ui.model.json.JSONModel
 	 */
@@ -294,7 +294,7 @@ sap.ui.define([
 		return this.pSequentialImportCompleted;
 	};
 
-	/**
+	/*
 	 * @see sap.ui.model.Model.prototype.bindProperty
 	 *
 	 */
@@ -303,7 +303,7 @@ sap.ui.define([
 		return oBinding;
 	};
 
-	/**
+	/*
 	 * @see sap.ui.model.Model.prototype.bindList
 	 *
 	 */
@@ -312,10 +312,10 @@ sap.ui.define([
 		return oBinding;
 	};
 
-	/**
+	/*
 	 * @see sap.ui.model.Model.prototype.bindTree
 	 *
-	 * @param {object} [mParameters=null]
+	 * @param {object} [mParameters]
 	 *   Additional model specific parameters; if the mParameter <code>arrayNames</code> is
 	 *   specified with an array of string names these names will be checked against the tree data
 	 *   structure and the found data in this array is included in the tree, but only if the parent
@@ -335,7 +335,7 @@ sap.ui.define([
 	 *
 	 * @param {string}  sPath path of the property to set
 	 * @param {any}     oValue value to set the property to
-	 * @param {object} [oContext=null] the context which will be used to set the property
+	 * @param {object} [oContext] the context which will be used to set the property
 	 * @param {boolean} [bAsyncUpdate] whether to update other bindings dependent on this property asynchronously
 	 * @return {boolean} true if the value was set correctly and false if errors occurred like the entry was not found.
 	 * @public
@@ -374,7 +374,7 @@ sap.ui.define([
 	 *
 	 * @param {string} sPath
 	 *   The path to the property
-	 * @param {sap.ui.model.Context} [oContext=null]
+	 * @param {sap.ui.model.Context} [oContext]
 	 *   The context which will be used to retrieve the property
 	 * @return {any}
 	 *   The value of the property. If the property is not found, <code>null</code> or

package/src/sap/ui/model/json/JSONPropertyBinding.js

@@ -34,7 +34,7 @@ sap.ui.define([
 	 */
 	var JSONPropertyBinding = ClientPropertyBinding.extend("sap.ui.model.json.JSONPropertyBinding");
 
-	/**
+	/*
 	 * @see sap.ui.model.PropertyBinding.prototype.setValue
 	 */
 	JSONPropertyBinding.prototype.setValue = function(oValue){

package/src/sap/ui/model/message/MessageModel.js

@@ -29,7 +29,7 @@ sap.ui.define(['sap/ui/model/BindingMode', 'sap/ui/model/ClientModel', 'sap/ui/m
 	 * @extends sap.ui.model.ClientModel
 	 *
 	 * @author SAP SE
-	 * @version 1.96.2
+	 * @version 1.97.0
 	 *
 	 * @param {sap.ui.core.message.MessageManager} oMessageManager The MessageManager instance
 	 * @public
@@ -68,7 +68,7 @@ sap.ui.define(['sap/ui/model/BindingMode', 'sap/ui/model/ClientModel', 'sap/ui/m
 		return this;
 	};
 
-	/**
+	/*
 	 * @see sap.ui.model.Model.prototype.bindProperty
 	 *
 	 */
@@ -77,7 +77,7 @@ sap.ui.define(['sap/ui/model/BindingMode', 'sap/ui/model/ClientModel', 'sap/ui/m
 		return oBinding;
 	};
 
-	/**
+	/*
 	 * @see sap.ui.model.Model.prototype.bindList
 	 *
 	 */

package/src/sap/ui/model/message/MessagePropertyBinding.js

@@ -28,7 +28,7 @@ sap.ui.define([
 	 */
 	var MessagePropertyBinding = ClientPropertyBinding.extend("sap.ui.model.message.MessagePropertyBinding");
 
-	/**
+	/*
 	 * @see sap.ui.model.PropertyBinding.prototype.setValue
 	 */
 	MessagePropertyBinding.prototype.setValue = function(oValue){

package/src/sap/ui/model/odata/AnnotationHelper.js

@@ -46,7 +46,7 @@ sap.ui.define([
 		 * instructions in XML template views, e.g. <code>&lt;template:with path="meta>Value"
 		 * helper="sap.ui.model.odata.AnnotationHelper.resolvePath" var="target"></code>.
 		 *
-		 * Since 1.31.0, you DO NOT need to {@link jQuery.sap.require} this module before use.
+		 * Since 1.31.0, you DO NOT need to {@link sap.ui.require} this module before use.
 		 *
 		 * @public
 		 * @since 1.27.0
@@ -90,7 +90,7 @@ sap.ui.define([
 			 * Example:
 			 * <pre>
 			 * function myRootFormatter(oValue1, oValue2, sFullName, sGreeting, iAnswer) {
-			 *     return ...; //TODO compute something useful from the given values
+			 *     return ...;
 			 * }
 			 *
 			 * oSupplierContext = oMetaModel.getMetaContext("/ProductSet('HT-1021')/ToSupplier");

package/src/sap/ui/model/odata/AnnotationParser.js

@@ -895,8 +895,10 @@ var AnnotationParser =  {
 			var oNode = xPath.nextNode(oNodeList, i);
 			var oValue = {};
 			var sText = xPath.getNodeText(oNode);
-			// TODO: Is nodeName correct or should we remove the namespace?
-			oValue[oNode.nodeName] = AnnotationParser._parserData.aliases ? AnnotationParser.replaceWithAlias(sText) : sText;
+
+			oValue[oNode.nodeName] = AnnotationParser._parserData.aliases
+				? AnnotationParser.replaceWithAlias(sText)
+				: sText;
 			aNodeValues.push(oValue);
 		}
 

package/src/sap/ui/model/odata/ODataAnnotations.js

@@ -25,7 +25,7 @@ sap.ui.define([
 	 *
 	 * @author SAP SE
 	 * @version
-	 * 1.96.2
+	 * 1.97.0
 	 *
 	 * @public
 	 * @deprecated As of version 1.66, please use {@link sap.ui.model.odata.v2.ODataAnnotations} instead.

package/src/sap/ui/model/odata/ODataListBinding.js

@@ -84,7 +84,6 @@ sap.ui.define([
 
 			// if nested list is already available and no filters or sorters are set,
 			// use the data and don't send additional requests
-			// TODO: what if nested list is not complete, because it was too large?
 			var oRef = this.oModel._getObject(this.sPath, this.oContext);
 			this.aExpandRefs = oRef;
 			if (Array.isArray(oRef) && !aSorters && !aFilters) {
@@ -97,25 +96,27 @@ sap.ui.define([
 				this.iLength = 0;
 				this.bLengthFinal = true;
 				this.bDataAvailable = true;
-			}	else {
+			} else if (this.oModel.getServiceMetadata()) {
 				// call getLength when metadata is already loaded or don't do anything
 				// if the metadata gets loaded it will call a refresh on all bindings
-				if (this.oModel.getServiceMetadata()) {
-					this.resetData();
-				}
+				this.resetData();
 			}
-
 		}
-
 	});
 
 	/**
 	 * Return contexts for the list
 	 *
-	 * @param {int} [iStartIndex=0] the start index of the requested contexts
-	 * @param {int} [iLength] the requested amount of contexts
+	 * @param {int} [iStartIndex=0]
+	 *   The start index of the requested contexts
+	 * @param {int} [iLength]
+	 *   The requested amount of contexts
 	 * @param {int} [iThreshold=0]
-	 * @return {sap.ui.model.Context[]} the array of contexts for each row of the bound list
+	 *   The maximum number of contexts to read before and after the given range; with this,
+	 *   controls can prefetch data that is likely to be needed soon, e.g. when scrolling down in a
+	 *   table
+	 * @return {sap.ui.model.Context[]}
+	 *   The array of contexts for each row of the bound list
 	 * @protected
 	 */
 	ODataListBinding.prototype.getContexts = function(iStartIndex, iLength, iThreshold) {
@@ -333,7 +334,6 @@ sap.ui.define([
 
 				if (!this.bInitial) {
 					// if nested list is already available, use the data and don't send additional requests
-					// TODO: what if nested list is not complete, because it was too large?
 					var oRef = this.oModel._getObject(this.sPath, this.oContext);
 					this.aExpandRefs = oRef;
 					// eslint-disable-next-line no-unsafe-negation
@@ -384,13 +384,15 @@ sap.ui.define([
 
 		sPath = this.oModel.resolve(this.sPath,this.oContext);
 
-		if (sPath) {
-			return this.oModel._createRequestUrl(sPath, null, aParams);
-		}
+		return sPath && this.oModel._createRequestUrl(sPath, null, aParams);
 	};
 
 	/**
-	 * Load list data from the server
+	 * Load list data from the server.
+	 *
+	 * @param {number} iStartIndex The first index to load
+	 * @param {number} iLength The number of entries to load
+	 * @param {boolean} bPretend Whether the request should be pretended
 	 */
 	ODataListBinding.prototype.loadData = function(iStartIndex, iLength, bPretend) {
 
@@ -536,9 +538,7 @@ sap.ui.define([
 	};
 
 	/**
-	 * Return the length of the list
-	 *
-	 * @return {int} the length
+	 * Request the length of the list from the backend and cache it.
 	 */
 	ODataListBinding.prototype._getLength = function() {
 
@@ -589,12 +589,14 @@ sap.ui.define([
 	};
 
 	/**
-	 * Refreshes the binding, checks whether the model data has been changed and fires a change event
-	 * if this is the case. For server side models this should refetch the data from the server.
-	 * To update a control, even if no data has been changed, e.g. to reset a control after failed
-	 * validation, use the parameter <code>bForceUpdate</code>.
+	 * Refreshes the binding, checks whether the model data has been changed and fires a change
+	 * event if this is the case. For server side models this should refetch the data from the
+	 * server. To update a control, even if no data has been changed, e.g. to reset a control after
+	 * failed validation, use the parameter <code>bForceUpdate</code>.
 	 *
 	 * @param {boolean} [bForceUpdate] Update the bound control even if no data has been changed
+	 * @param {object} [mChangedEntities] A map of changed entities
+	 * @param {object} [mEntityTypes] A map of entity types
 	 * @public
 	 */
 	ODataListBinding.prototype.refresh = function(bForceUpdate, mChangedEntities, mEntityTypes) {
@@ -614,6 +616,8 @@ sap.ui.define([
 						bChangeDetected = true;
 						return false;
 					}
+
+					return true;
 				});
 			}
 			if (!mChangedEntities && !mEntityTypes) { // default
@@ -628,7 +632,9 @@ sap.ui.define([
 	};
 
 	/**
-	 * fireRefresh
+	 * Fires a <code>refresh</code> event.
+	 *
+	 * @param {object} oParameters Parameters for the event
 	 */
 	ODataListBinding.prototype._fireRefresh = function(oParameters) {
 		 if (this.oModel.resolve(this.sPath, this.oContext)) {
@@ -655,14 +661,16 @@ sap.ui.define([
 	};
 
 	/**
-	 * Check whether this Binding would provide new values and in case it changed,
-	 * inform interested parties about this.
+	 * Checks whether this Binding would provide new values and in case it changed, fires a change
+	 * event.
 	 *
 	 * @param {boolean} bForceUpdate
+	 *   Whether the event should be fired regardless of the bindings state
 	 * @param {object} mChangedEntities
+	 *   A map of changed entities
 	 */
 	ODataListBinding.prototype.checkUpdate = function(bForceUpdate, mChangedEntities) {
-		var bChangeReason = this.sChangeReason ? this.sChangeReason : ChangeReason.Change,
+		var sChangeReason = this.sChangeReason ? this.sChangeReason : ChangeReason.Change,
 			bChangeDetected = false,
 			oLastData, oCurrentData,
 			that = this,
@@ -698,6 +706,8 @@ sap.ui.define([
 						bChangeDetected = true;
 						return false;
 					}
+
+					return true;
 				});
 			} else {
 				bChangeDetected = true;
@@ -719,13 +729,15 @@ sap.ui.define([
 							bChangeDetected = true;
 							return false;
 						}
+
+						return true;
 					});
 				}
 			}
 		}
 		if (bForceUpdate || bChangeDetected || this.bNeedsUpdate) {
 			this.bNeedsUpdate = false;
-			this._fireChange({reason: bChangeReason});
+			this._fireChange({reason: sChangeReason});
 		}
 		this.sChangeReason = undefined;
 		this.bIgnoreSuspend = false;
@@ -768,8 +780,14 @@ sap.ui.define([
 	/**
 	 * Sorts the list.
 	 *
-	 * @param {sap.ui.model.Sorter|Array} aSorters the Sorter or an array of sorter objects object which define the sort order
-	 * @return {this} returns <code>this</code> to facilitate method chaining
+	 * @param {sap.ui.model.Sorter|sap.ui.model.Sorter[]} aSorters
+	 *   The Sorter or an array of sorter objects which define the sort order
+	 * @param {boolean} [bReturnSuccess=false]
+	 *   Whether to return <code>true</code> or <code>false</code>, instead of <code>this</code>,
+	 *   depending on whether the sorting has been done
+	 * @return {this}
+	 *   Returns <code>this</code> to facilitate method chaining or the success state
+	 *
 	 * @public
 	 */
 	ODataListBinding.prototype.sort = function(aSorters, bReturnSuccess) {
@@ -793,7 +811,6 @@ sap.ui.define([
 			this.abortPendingRequest();
 			this.sChangeReason = ChangeReason.Sort;
 			this._fireRefresh({reason : this.sChangeReason});
-			// TODO remove this if the sort event gets removed which is now deprecated
 			this._fireSort({sorter: aSorters});
 			bSuccess = true;
 		}
@@ -812,16 +829,23 @@ sap.ui.define([
 	 *
 	 * Filters the list.
 	 *
-	 * When using sap.ui.model.Filter the filters are first grouped according to their binding path.
-	 * All filters belonging to a group are combined with OR and after that the
+	 * When using <code>sap.ui.model.Filter</code> the filters are first grouped according to their
+	 * binding path. All filters belonging to a group are combined with OR and after that the
 	 * results of all groups are combined with AND.
-	 * Usually this means, all filters applied to a single table column
-	 * are combined with OR, while filters on different table columns are combined with AND.
+	 * Usually this means, all filters applied to a single table column are combined with OR, while
+	 * filters on different table columns are combined with AND.
 	 * Please note that a custom filter function is not supported.
 	 *
-	 * @param {sap.ui.model.Filter|sap.ui.model.Filter[]} aFilters Single filter object or an array of filter objects
-	 * @param {sap.ui.model.FilterType} sFilterType Type of the filter which should be adjusted, if it is not given, the standard behaviour applies
-	 * @return {this} returns <code>this</code> to facilitate method chaining
+	 * @param {sap.ui.model.Filter|sap.ui.model.Filter[]} aFilters
+	 *   Single filter object or an array of filter objects
+	 * @param {sap.ui.model.FilterType} sFilterType
+	 *   Type of the filter which should be adjusted, if it is not given, the standard behaviour
+	 *   applies
+	 * @param {boolean} [bReturnSuccess=false]
+	 *   Whether to return <code>true</code> or <code>false</code>, instead of <code>this</code>,
+	 *   depending on whether the filtering has been done
+	 * @return {this}
+	 *   Returns <code>this</code> to facilitate method chaining or the success state
 	 *
 	 * @public
 	 */
@@ -864,7 +888,6 @@ sap.ui.define([
 			this.abortPendingRequest();
 			this.sChangeReason = ChangeReason.Filter;
 			this._fireRefresh({reason : this.sChangeReason});
-			// TODO remove this if the filter event gets removed which is now deprecated
 			if (sFilterType == FilterType.Application) {
 				this._fireFilter({filters: this.aApplicationFilters});
 			} else {

package/src/sap/ui/model/odata/ODataMessageParser.js

@@ -84,7 +84,7 @@ var sClassName = "sap.ui.model.odata.ODataMessageParser",
  * @extends sap.ui.core.message.MessageParser
  *
  * @author SAP SE
- * @version 1.96.2
+ * @version 1.97.0
  * @public
  * @alias sap.ui.model.odata.ODataMessageParser
  */
@@ -435,7 +435,7 @@ ODataMessageParser._isResponseForCreate = function (mRequestInfo) {
 	if (oRequest.key && oRequest.created && oResponse.statusCode >= 400) {
 		return false;
 	}
-	// return undefined; otherwise
+	return undefined;
 };
 
 /**

package/src/sap/ui/model/odata/ODataMetaModel.js

@@ -26,7 +26,6 @@ sap.ui.define([
 		BindingMode, ClientContextBinding, Context, FilterProcessor, MetaModel, JSONListBinding,
 		JSONModel, JSONPropertyBinding, JSONTreeBinding, Measurement) {
 	"use strict";
-	/*global Map */
 
 	var // maps the metadata URL with query parameters concatenated with the code list collection
 		// path (e.g. /foo/bar/$metadata#SAP__Currencies) to a SyncPromise resolving with the code
@@ -208,7 +207,7 @@ sap.ui.define([
 	 * {@link #loaded loaded} has been resolved!
 	 *
 	 * @author SAP SE
-	 * @version 1.96.2
+	 * @version 1.97.0
 	 * @alias sap.ui.model.odata.ODataMetaModel
 	 * @extends sap.ui.model.MetaModel
 	 * @public
@@ -855,7 +854,6 @@ sap.ui.define([
 					vResult = bAsPath
 						? "/dataServices/schema/" + i + "/entityContainer/" + j
 						: oSchema.entityContainer[j];
-					return false; //break
 				}
 			});
 
@@ -1298,6 +1296,8 @@ sap.ui.define([
 		} else if (sDataPath === "/##@@requestUnitsOfMeasure") {
 			return "UnitsOfMeasure";
 		}
+
+		return undefined;
 	};
 
 	return ODataMetaModel;