@openui5/sap.ui.core 1.93.3 → 1.96.2

package/src/sap/ui/core/support/plugins/Debugging.js

@@ -94,8 +94,8 @@ sap.ui.define([
 
 			rm.write('<div id="sapUiSupportDebuggingRebootContainer" class="sapUiSupportContainer">');
 
-			rm.write('<div style="font-weight: bold" class="sapUISupportLabel">Note: Designed to work with apps loaded with the standard UI5 loading bootstrap script tag:</div>');
-			rm.write('<div style="font-weight: bold" class="sapUISupportLabel">&lt;script id="sap-ui-bootstrap" src="somepath/resources/sap-ui-core.js" ...<br/><br/></div>');
+			rm.write('<div class="sapUISupportLabel sapUISupportLabelBold">Note: Designed to work with apps loaded with the standard UI5 loading bootstrap script tag:</div>');
+			rm.write('<div class="sapUISupportLabel sapUISupportLabelBold">&lt;script id="sap-ui-bootstrap" src="somepath/resources/sap-ui-core.js" ...<br/><br/></div>');
 
 			rm.write('<div class="sapUISupportLabel">Boot application with different UI5 version on next reload:</div>');
 			rm.write('<select id="sapUiSupportDebuggingRebootSelect" class="sapUiSupportSelect">');
@@ -103,7 +103,7 @@ sap.ui.define([
 			rm.write('<option value="other" id="sapUiSupportDebuggingRebootOther">Other (enter URL to sap-ui-core.js below)...:</option>');
 			rm.write('</select>');
 			rm.write('<input type="text" id="sapUiSupportDebuggingRebootInput" disabled="disabled">');
-			rm.write('<button id="sapUiSupportDebuggingReboot" class="sapUiSupportRoundedButton" style="margin-right:0;">Activate Reboot URL</button>');
+			rm.write('<button id="sapUiSupportDebuggingReboot" class="sapUiSupportRoundedButton">Activate Reboot URL</button>');
 			rm.write('</div>');
 
 			rm.write('<div id="sapUiSupportDebuggingClassContainer" class="sapUiSupportContainer"></div>');
@@ -120,7 +120,7 @@ sap.ui.define([
 			var aClasses = this._aClasses;
 			var rm = sap.ui.getCore().createRenderManager();
 
-			rm.write('<div class="sapUISupportLabel" style="margin-right:5px">Select Class:</div>');
+			rm.write('<div class="sapUISupportLabel">Select Class:</div>');
 
 			rm.write('<select id="sapUiSupportDebuggingClassSelect" class="sapUiSupportAutocomplete  sapUiSupportSelect"><option></option>');
 
@@ -161,8 +161,7 @@ sap.ui.define([
 
 				rm.write('><div><span class="className">' + encodeXML(oValue + "") + '</span>' +
 						 '<span class="breakpoints">' + encodeXML(bpCountText + "") + '</span></div>' +
-						 '<img class="remove-class" style="cursor:pointer;margin-left:5px" ' +
-						 'src="../../debug/images/delete.gif" alt="X"></li>');
+						 '<img class="remove-class" src="../../debug/images/delete.gif" alt="X"></li>');
 			});
 
 			rm.write('</ul>');
@@ -176,13 +175,13 @@ sap.ui.define([
 			var rm = sap.ui.getCore().createRenderManager();
 
 			if (typeof (mMethods) === 'undefined') {
-				rm.write('<p style="text-align:center;font-weight: bold">Select a class in the list on the left side to add breakpoint.</p>');
+				rm.write('<p>Select a class in the list on the left side to add breakpoint.</p>');
 				rm.flush($("#sapUiSupportDebuggingMethodContainer").get(0));
 				rm.destroy();
 				return;
 			}
 
-			rm.write('<div class="sapUISupportLabel" style="margin-right:5px">Select Method:</div>');
+			rm.write('<div class="sapUISupportLabel">Select Method:</div>');
 
 			rm.write('<select id="sapUiSupportDebuggingMethodSelect" class="sapUiSupportAutocomplete sapUiSupportSelect"><option></option>');
 
@@ -209,8 +208,7 @@ sap.ui.define([
 				}
 
 				rm.write('<li data-method-type="' + encodeXML(oValue.type + "") + '"><span>' + encodeXML(oValue.name + "") + '</span>' +
-						 '<img class="remove-breakpoint" style="cursor:pointer;margin-left:5px" ' +
-						 'src="../../debug/images/delete.gif" alt="Remove"></li>');
+						 '<img class="remove-breakpoint" src="../../debug/images/delete.gif" alt="Remove"></li>');
 			});
 
 			rm.write('</ul>');
@@ -240,7 +238,7 @@ sap.ui.define([
 
 			// Update breakpoint-count
 			var $breakpoints = $('li[data-class-name="' + sClassName + '"] span.breakpoints');
-			$breakpoints.text(mBreakpointCount.active + " / " + mBreakpointCount.all).show();
+			$breakpoints.text(mBreakpointCount.active + " / " + mBreakpointCount.all);
 
 			$('#sapUiSupportDebuggingMethodInput').trigger("focus");
 		};

package/src/sap/ui/core/support/plugins/Interaction.js

@@ -38,7 +38,7 @@ sap.ui.define([
 		 * With this plugIn the performance measurements are displayed
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.93.3
+		 * @version 1.96.2
 		 * @private
 		 * @alias sap.ui.core.support.plugins.Interaction
 		 */
@@ -117,7 +117,7 @@ sap.ui.define([
 			rm.write("</div>");
 
 			rm.write('<div class="sapUiPerformanceStatsDiv sapUiSupportIntHidden">');
-			rm.write('<div class="sapUiPerformanceTimeline" style="height: 50px;"></div>');
+			rm.write('<div class="sapUiPerformanceTimeline"></div>');
 			rm.write('<div class="sapUiPerformanceTop">');
 			rm.write('</div>');
 

package/src/sap/ui/core/support/plugins/LocalStorage.js

@@ -15,7 +15,7 @@ sap.ui.define(['sap/ui/core/support/Plugin', "sap/base/Log"],
 		 * @class This class represents the LocalStorage plugin for the support tool functionality of UI5. This class is internal and all its functions must not be used by an application.
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.93.3
+		 * @version 1.96.2
 		 * @private
 		 * @alias sap.ui.core.support.plugins.LocalStorage
 		 */

package/src/sap/ui/core/support/plugins/Performance.js

@@ -6,11 +6,12 @@
 
 // Provides class sap.ui.core.support.plugins.Performance
 sap.ui.define([
-	'sap/ui/core/support/Plugin',
+	"sap/ui/core/Core",
+	"sap/ui/core/support/Plugin",
 	"sap/ui/performance/Measurement",
 	"sap/base/security/encodeXML"
 ],
-	function(Plugin, Measurement, encodeXML) {
+	function(Core, Plugin, Measurement, encodeXML) {
 		"use strict";
 
 		var _rawdata = [];
@@ -55,7 +56,7 @@ sap.ui.define([
 		 * With this plugIn the performance measurements are displayed
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.93.3
+		 * @version 1.96.2
 		 * @private
 		 * @alias sap.ui.core.support.plugins.Performance
 		 */
@@ -98,7 +99,7 @@ sap.ui.define([
 		};
 
 		function initInTools(oSupportStub) {
-			var rm = sap.ui.getCore().createRenderManager();
+			var rm = Core.createRenderManager();
 
 			//create the initial html for the performance tool
 			rm.write(_getPerformanceToolHTML());
@@ -420,10 +421,43 @@ sap.ui.define([
 			return stepsData;
 		}
 
+		/**
+		 * @param {sap.ui.core.RenderManager} rm Render Manager
+		 * @param {Object} step
+		 * @param {string} type - Type is 'duration' or 'time'
+		 * @private
+		 */
+		function _renderSubBarHTML(rm, step, type) {
+			/*
+				step = {
+					time: {
+						_total: 20ms,
+						rendering: 10ms,
+						require: 10ms
+					},
+					duration: {
+						_total: 20ms,
+						rendering: 10ms,
+						require: 10ms
+					}
+				}
+			*/
+
+			Object.keys(step.duration).sort().forEach(function (categoryType) {
+				if (categoryType !== '_total') {
+					var heightInPercent = (step[type][categoryType] / step[type]._total) * 100;
+
+					rm.openStart("div")
+						.class(_getBarClassType(categoryType))
+						.style("height", heightInPercent.toFixed(2) + "%")
+						.openEnd()
+						.close("div");
+				}
+			});
+		}
+
 		function _renderTimelineOverview(data) {
 			var domParent = document.querySelector('#sapUiSupportPerfHeaderTimelineOverview .timeline');
-
-			var HTML = '<ol>';
 			var copiedData = (JSON.parse(JSON.stringify(data)));
 
 			//TODO: optimise this logic to loop only once
@@ -458,68 +492,57 @@ sap.ui.define([
 			allTimeSum = topSumTimeStep.time._total;
 			allDurationSum = topSumDurationStep.duration._total;
 
-			/**
-			 *
-			 * @param {Object} step
-			 * @param {string} type - Type is 'duration' or 'time'
-			 * @param {string} html - html string to add to
-			 * @private
-			 */
-			function __getSubBarHTML(step, type) {
-				/*
-				 step = {
-				 time: {
-				 _total: 20ms,
-				 rendering: 10ms,
-				 require: 10ms
-				 },
-				 duration: {
-				 _total: 20ms,
-				 rendering: 10ms,
-				 require: 10ms
-				 }
-				 }
-				 */
-				var HTML = '';
-
-				Object.keys(step.duration).sort().forEach(function (categoryType) {
-					if (categoryType !== '_total') {
-						var heightInPercent = (step[type][categoryType] / step[type]._total) * 100;
-						HTML += '<div class="' + _getBarClassType(categoryType) + '" style="height: ' + heightInPercent.toFixed(2) + '%;"></div>';
-					}
-				});
+			var rm = Core.createRenderManager();
 
-				return HTML;
-			}
+			rm.openStart("ol").openEnd();
 
 			stepsData.forEach(function (step) {
 				var stepDurationInPercent = Math.ceil((step.duration._total / allDurationSum) * 100);
 				var stepTimeInPercent = Math.ceil((step.time._total / allTimeSum) * 100);
 
-				var stepDurationInPercentInlineStyle = 'height: ' + stepDurationInPercent + '%;';
+				rm.openStart("li").openEnd();
+
+				rm.openStart("div")
+					.class("bars-wrapper")
+					.attr("title", _getTimelineOverViewBarTitle(step.duration._total, step.time._total))
+					.openEnd();
+
+				rm.openStart("div")
+					.class("duration")
+					.style("height", stepDurationInPercent + "%");
+
 				if (stepDurationInPercent > 0) {
-					stepDurationInPercentInlineStyle += ' min-height: 1px;';
+					rm.style("min-height", "1px");
 				}
 
-				var stepTimeInPercentInlineStyle = 'height: ' + stepTimeInPercent + '%;';
+				rm.openEnd();
+
+				_renderSubBarHTML(rm, step, "duration");
+
+				rm.close("div"); // duration
+
+				rm.openStart("div")
+					.class("time")
+					.style("height", stepTimeInPercent + "%");
+
 				if (stepTimeInPercent > 0) {
-					stepTimeInPercentInlineStyle += ' min-height: 1px;';
+					rm.style("min-height", "1px");
 				}
 
-				HTML += '<li>';
-				HTML += '<div class="bars-wrapper" title="' + _getTimelineOverViewBarTitle(step.duration._total, step.time._total) + '">';
-				HTML += '<div class="duration" style="' + stepDurationInPercentInlineStyle + '">';
-				HTML += __getSubBarHTML(step, 'duration');
-				HTML += '</div>';
-				HTML += '<div class="time" style="' + stepTimeInPercentInlineStyle + '">';
-				HTML += __getSubBarHTML(step, 'time');
-				HTML += '</div>';
-				HTML += '</div></li>';
+				rm.openEnd();
+
+				_renderSubBarHTML(rm, step, "time");
+
+				rm.close("div"); // time
+
+				rm.close("div"); // bars-wrapper
+				rm.close("li");
 			});
 
-			HTML += '</ol>';
+			rm.close("ol");
 
-			domParent.innerHTML = HTML;
+			rm.flush(domParent);
+			rm.destroy();
 		}
 
 		/* =============================================================================================================
@@ -527,8 +550,8 @@ sap.ui.define([
 		 ============================================================================================================= */
 
 		function _render() {
-			var HTML = '<ol>';
-			var barInfoHTML = '<ol>';
+			var barRm = Core.createRenderManager();
+			var barInfoRm = Core.createRenderManager();
 
 			//get all data from the filter ui elements
 			var filterOptions = _getFilterOptions();
@@ -537,29 +560,82 @@ sap.ui.define([
 
 			//no data bar
 			if (data.length === 0) {
-				HTML += '<li class="line nodata" data-uid="' + -1 + '"></li>';
-				barInfoHTML += '<li class="line nodata" data-uid="' + -1 + '"><div class="info line">No data</div></li>';
+				barRm.openStart("li")
+					.class("line")
+					.class("nodata")
+					.attr("data-uid", -1)
+					.openEnd()
+					.close("li");
+
+				barInfoRm.openStart("li")
+					.class("line")
+					.class("nodata")
+					.attr("data-uid", -1)
+					.openEnd();
+
+				barInfoRm.openStart("div")
+					.class("info")
+					.class("line")
+					.openEnd()
+					.text("No data")
+					.close("div");
+
+				barInfoRm.close("li");
 			}
 
 			data.forEach(function (item) {
 				var rawItem = _getBarById(item.uid);
-				HTML += '<li data-uid="' + item.uid + '" class="line" title="' + _getBarTitle(rawItem) + '"' + _getBarDataAttributes(rawItem) + '  >';
-				HTML += '<div class="bar ' + _getBarColor(rawItem.duration) + '" style="width: ' + _calculateBarWidth(item.duration) + ' margin-left: ' + _calculateBarOffset(item, filterOptions.filterByTime.start) + '">';
-				HTML += '<div class="sub-bar ' + _getBarColor(rawItem.time) + '" style="width: ' + _calculateBarWidth(item.time) + '"></div>';
-				HTML += '</div>';
-				HTML += '</li>';
+				barRm.openStart("li")
+					.class("line")
+					.attr("data-uid", item.uid)
+					.attr("title", _getBarTitle(rawItem))
+					.attr("data-item-category", rawItem.categories[0])
+					.openEnd();
+
+				barRm.openStart("div")
+					.class("bar")
+					.class(_getBarColor(rawItem.duration))
+					.style("width", _calculateBarWidth(item.duration))
+					.style("margin-left", _calculateBarOffset(item, filterOptions.filterByTime.start))
+					.openEnd();
+
+				barRm.openStart("div")
+					.class("sub-bar")
+					.class(_getBarColor(rawItem.time))
+					.style("width", _calculateBarWidth(item.time))
+					.openEnd()
+					.close("div");
+
+				barRm.close("div"); // bar
+				barRm.close("li");
 
 				//render bar info ==================================================================================
-				barInfoHTML += '<li data-uid="' + item.uid + '" title="' + _getBarTitle(rawItem) + '" class="line ' + _getBarClassType(rawItem.categories[0]) + '" ' + _getBarDataAttributes(rawItem) + '>';
-				barInfoHTML += '<div class="info line">' + _formatInfo(rawItem) + ' (' + (rawItem.time).toFixed(0) + ' ms)</div>';
-				barInfoHTML += '</li>';
+				barInfoRm.openStart("li")
+					.class("line")
+					.class(_getBarClassType(rawItem.categories[0]))
+					.attr("data-uid", item.uid)
+					.attr("title", _getBarTitle(rawItem))
+					.attr("data-item-category", rawItem.categories[0])
+					.openEnd();
+
+				barInfoRm.openStart("div")
+					.class("line")
+					.class("info")
+					.openEnd()
+					.text(_formatInfo(rawItem) + " (" + (rawItem.time).toFixed(0) + " ms)")
+					.close("div");
+
+				barInfoRm.close("li");
 			});
 
-			HTML += '</ol>';
-			barInfoHTML += '</ol>';
+			barRm.close("ol");
+			barInfoRm.close("ol");
 
-			document.querySelector('#sapUiSupportPerfHeaderTimelineBarWrapper').innerHTML = HTML;
-			document.querySelector('#sapUiSupportPerfHeaderTimelineBarInfoWrapper').innerHTML = barInfoHTML;
+			barRm.flush(document.querySelector("#sapUiSupportPerfHeaderTimelineBarWrapper"));
+			barInfoRm.flush(document.querySelector("#sapUiSupportPerfHeaderTimelineBarInfoWrapper"));
+
+			barRm.destroy();
+			barInfoRm.destroy();
 
 			_createTimelineGrid(filterOptions);
 			_filterByCategory(); // Don't change the order, this is applying css styles on the rendered content
@@ -580,7 +656,7 @@ sap.ui.define([
 		}
 
 		function _getBarTitle(bar) {
-			return encodeXML(bar.info + '\nduration: ' + bar.duration.toFixed(2) + ' ms. \ntime: ' + bar.time.toFixed(2) + ' ms. \nstart: ' + bar.start.toFixed(2) + ' ms.\nend: ' + bar.end.toFixed(2) + ' ms.');
+			return bar.info + "\nduration: " + bar.duration.toFixed(2) + " ms. \ntime: " + bar.time.toFixed(2) + " ms. \nstart: " + bar.start.toFixed(2) + " ms.\nend: " + bar.end.toFixed(2) + " ms.";
 		}
 
 		function _formatInfo(bar) {
@@ -590,7 +666,7 @@ sap.ui.define([
 			barInfo = barInfo.substring(barInfo.lastIndexOf('sap.m.'), barInfo.length);
 			barInfo = barInfo.replace('Rendering of ', '');
 
-			return encodeXML(barInfo);
+			return barInfo;
 		}
 
 		function _getBarClassType(category) {
@@ -652,10 +728,6 @@ sap.ui.define([
 			return categories;
 		}
 
-		function _getBarDataAttributes(bar) {
-			return 'data-item-category = ' + bar.categories[0];
-		}
-
 		function _lineHover(e) {
 			var dom = e.srcElement;
 

package/src/sap/ui/core/support/plugins/Selector.js

@@ -6,25 +6,21 @@
 
 // Provides class sap.ui.core.support.plugins.Selector (Selector support plugin)
 sap.ui.define([
-	'sap/ui/core/Popup',
-	'../Plugin',
-	'../Support',
+	"sap/ui/core/Core",
+	"sap/ui/core/Popup",
+	"../Plugin",
+	"../Support",
 	"sap/ui/thirdparty/jquery",
 	"sap/base/util/uid"
-],
-	function(Popup, Plugin, Support, jQueryDOM, uid) {
+], function (Core, Popup, Plugin, Support, jQuery, uid) {
 	"use strict";
 
-
-
-
-
 		/**
 		 * Creates an instance of sap.ui.core.support.plugins.Selector.
 		 * @class This class represents the selector plugin for the support tool functionality of UI5. This class is internal and all its functions must not be used by an application.
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.93.3
+		 * @version 1.96.2
 		 * @private
 		 * @alias sap.ui.core.support.plugins.Selector
 		 */
@@ -50,7 +46,6 @@ sap.ui.define([
 			highlight(oEvent.getParameter("id"), this, oEvent.getParameter("sendInfo"));
 		};
 
-
 		Selector.prototype.init = function(oSupportStub){
 			Plugin.prototype.init.apply(this, arguments);
 
@@ -58,15 +53,20 @@ sap.ui.define([
 
 			if (!this._sPopupId) {
 				this._sPopupId = this.getId() + "-" + uid();
-				var rm = sap.ui.getCore().createRenderManager();
-				rm.write("<div id='" + this._sPopupId + "' style='border: 2px solid rgb(0, 128, 0); background-color: rgba(0, 128, 0, .55);'></div>");
-				rm.flush(sap.ui.getCore().getStaticAreaRef(), false, true);
+				var rm = Core.createRenderManager();
+				rm.openStart("div", this._sPopupId)
+					.style("border", "2px solid rgb(0, 128, 0)")
+					.style("background-color", "rgba(0, 128, 0, .55)")
+					.openEnd()
+					.close("div");
+
+				rm.flush(Core.getStaticAreaRef(), false, true);
 				rm.destroy();
 
-				jPopupRef = jQueryDOM(document.getElementById(this._sPopupId));
+				jPopupRef = jQuery(document.getElementById(this._sPopupId));
 				this._oPopup.setContent(jPopupRef[0]);
 			} else {
-				jPopupRef = jQueryDOM(document.getElementById(this._sPopupId));
+				jPopupRef = jQuery(document.getElementById(this._sPopupId));
 			}
 
 			var that = this;
@@ -92,11 +92,10 @@ sap.ui.define([
 
 		};
 
-
 		Selector.prototype.exit = function(oSupportStub){
 			this._oPopup.close(0);
 			if (this._fCloseHandler) {
-				jQueryDOM(document.getElementById(this._sPopupId)).off("click", this._fCloseHandler);
+				jQuery(document.getElementById(this._sPopupId)).off("click", this._fCloseHandler);
 				this._fCloseHandler = null;
 			}
 			if (this._fSelectHandler) {
@@ -106,12 +105,11 @@ sap.ui.define([
 			Plugin.prototype.exit.apply(this, arguments);
 		};
 
-
 		function highlight(sId, oPlugin, bSend){
 			if (sId) {
-				var oElem = sap.ui.getCore().byId(sId);
+				var oElem = Core.byId(sId);
 				if (oElem) {
-					var jPopupRef = jQueryDOM(document.getElementById(oPlugin._sPopupId));
+					var jPopupRef = jQuery(document.getElementById(oPlugin._sPopupId));
 					var jRef = oElem.$();
 					if (jRef.is(":visible")) {
 						jPopupRef.width(jRef.outerWidth());
@@ -130,14 +128,11 @@ sap.ui.define([
 			return false;
 		}
 
-
 		function getElementDetailsForEvent(oElement, oPlugin){
 			//TODO: to be extended
 			return {"id": oElement.getId()};
 		}
 
-
-
 	return Selector;
 
 });

package/src/sap/ui/core/support/plugins/TechInfo.js

@@ -23,7 +23,7 @@ sap.ui.define([
 		 * @class This class represents the technical info plugin for the support tool functionality of UI5. This class is internal and all its functions must not be used by an application.
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.93.3
+		 * @version 1.96.2
 		 * @private
 		 * @alias sap.ui.core.support.plugins.TechInfo
 		 */
@@ -136,10 +136,10 @@ sap.ui.define([
 					"</select>"
 				);
 				buffer.push("<button id='" + that.getId() + "-startE2ETrace' class='sapUiSupportRoundedButton " +
-						(oData["e2e-trace"].isStarted ? " active" : "") + "' style='margin-left: 10px;'>" + (oData["e2e-trace"].isStarted ? "Running..." : "Start") + "</button>");
-				buffer.push("<div style='margin-top:5px'>");
+						(oData["e2e-trace"].isStarted ? " active" : "") + "'>" + (oData["e2e-trace"].isStarted ? "Running..." : "Start") + "</button>");
+				buffer.push("<div class='sapUiSupportTechInfoXMLOutput'>");
 				buffer.push("<label class='sapUiSupportLabel'>XML Output:</label>");
-				buffer.push("<textarea id='" + that.getId() + "-outputE2ETrace' style='width:100%;height:50px;margin-top:5px;resize:none;box-sizing:border-box'></textarea>");
+				buffer.push("<textarea id='" + that.getId() + "-outputE2ETrace'></textarea>");
 				buffer.push("</div>");
 			});
 
@@ -312,7 +312,7 @@ sap.ui.define([
 
 		function multiline(buffer, right, border, label, content){
 			line(buffer, right, border, label, function(buffer){
-				buffer.push("<table border='0' cellspacing='0' cellpadding='3' style='width: 100%'>");
+				buffer.push("<table border='0' cellspacing='0' cellpadding='3'>");
 				jQuery.each(content, function(i,v){
 					var val = "";
 					if (v) {