@openui5/sap.ui.core 1.91.0 → 1.93.2

package/src/sap/ui/core/.library

@@ -6,7 +6,7 @@
   <copyright>OpenUI5
  * (c) Copyright 2009-2021 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.</copyright>
-  <version>1.91.0</version>
+  <version>1.93.2</version>
 
   <documentation>The SAPUI5 Core Runtime.
 
@@ -234,6 +234,8 @@
         <exclude name="sap.ui.test.starter.runTest" />
         <exclude name="sap.ui.qunit." />
         <exclude name="sap.ui.thirdparty." />
+        <exclude name="sap.ui.model.odata.datajs" /> <!-- legacy redirect, only part of internal core overlay -->
+        <exclude name="sap.ui.core.designtime.mvc.ControllerExtensionTemplate" /> <!-- template file with partially unexpected content --> 
     </jsdoc>
     <!-- excludes for the JSCoverage -->
     <jscoverage xmlns="http://www.sap.com/ui5/buildext/jscoverage" >
@@ -398,7 +400,7 @@
             <copyright>2010-2011, Christian Johansen</copyright>
             <pattern>sap/ui/thirdparty/sinon-qunit.js</pattern>
         </lib>
-        <lib name="urijs" displayName="URI.js" version="1.19.6" homepage="http://medialize.github.com/URI.js/">
+        <lib name="urijs" displayName="URI.js" version="1.19.7" homepage="http://medialize.github.com/URI.js/">
             <license url="http://opensource.org/licenses/mit-license" type="MIT" />
             <copyright>Rodney Rehm</copyright>
             <pattern>sap/ui/thirdparty/URI.js</pattern>

package/src/sap/ui/core/BusyIndicator.js

@@ -38,7 +38,7 @@ sap.ui.define([
 	 * Provides methods to show or hide a waiting animation covering the whole
 	 * page and blocking user interaction.
 	 * @namespace
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 * @public
 	 * @alias sap.ui.core.BusyIndicator
 	 */

package/src/sap/ui/core/BusyIndicatorUtils.js

@@ -14,7 +14,8 @@ sap.ui.define(['./BlockLayerUtils'], //require of sap/ui/core/library not possib
 	/**
 	 * @alias sap.ui.core.BusyIndicatorUtils
 	 * @namespace
-	 * @public
+	 * @private
+	 * @ui5-restricted sap.ui.core, sap.chart
 	 */
 	var BusyIndicatorUtils = function() {};
 
@@ -24,6 +25,8 @@ sap.ui.define(['./BlockLayerUtils'], //require of sap/ui/core/library not possib
 	 *
 	 * @param {string} sSize either "Large" or "Medium". Other sizes will be mapped to "Medium"
 	 * @returns {DOM.element} the element for the busy indicator
+	 * @private
+	 * @ui5-restricted sap.ui.core, sap.chart
 	 */
 	BusyIndicatorUtils.getElement = function(sSize) {
 		//default size is medium

package/src/sap/ui/core/Component.js

@@ -228,7 +228,7 @@ sap.ui.define([
 	 * @extends sap.ui.base.ManagedObject
 	 * @abstract
 	 * @author SAP SE
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 * @alias sap.ui.core.Component
 	 * @since 1.9.2
 	 */
@@ -302,6 +302,7 @@ sap.ui.define([
 			}
 
 			this._bIsActive = true;
+			this._aDestroyables = [];
 
 			ManagedObject.apply(this, args);
 		},
@@ -639,12 +640,15 @@ sap.ui.define([
 		// make user specific data available during component instantiation
 		this.oComponentData = mSettings && mSettings.componentData;
 
-		// static initialization (loading dependencies, includes, ... / register customizing)
-		//   => either init the static or the instance manifest
-		if (!this._isVariant()) {
-			this.getMetadata().init();
-		} else {
+		// manifest initialization (loading dependencies, includes, ... / register customizing)
+		//   => either call init on the instance specific manifest or the static one on the ComponentMetadata
+		if (this._oManifest) {
 			this._oManifest.init(this);
+		} else {
+			this.getMetadata().init();
+		}
+
+		if (this._isVariant()) {
 			// in case of variants we ensure to register the module path for the variant
 			// to allow module loading of code extensibility relative to the manifest
 			var sAppId = this._oManifest.getEntry("/sap.app/id");
@@ -689,6 +693,27 @@ sap.ui.define([
 
 	};
 
+	/**
+	 * Returns the list of Promises for which an automatic destroy is scheduled.
+	 * Logs an error in case the application Component is missing a mandatory
+	 * constructor super call.
+	 * For compatibility reason we must not fail in this obviously broken scenario!
+	 *
+	 * @private
+	 */
+	Component.prototype._getDestroyables = function() {
+		if (!this._aDestroyables) {
+			Log.error("Mandatory super constructor not called for Component: '" + this.getManifestObject().getComponentName() + "'.",
+				null,
+				"sap.ui.support",
+				function() {
+					return { type: "missingSuperConstructor" };
+				});
+			this._aDestroyables = [];
+		}
+		return this._aDestroyables;
+	};
+
 	/*
 	 * clean up the component and its dependent entities like models or event handlers
 	 */
@@ -728,21 +753,33 @@ sap.ui.define([
 			delete this._oEventBus;
 		}
 
+		function fnDestroy(oInstance) {
+			if (oInstance && !oInstance._bIsBeingDestroyed) {
+				oInstance.destroy();
+			}
+		}
+
+		// trigger an async destroy for all registered commponent promises
+		var aDestroyables = this._getDestroyables();
+		for (var i = 0; i < aDestroyables.length; i++ ) {
+			aDestroyables[i] = aDestroyables[i].then(fnDestroy);
+		}
+
 		// destroy the object
 		ManagedObject.prototype.destroy.apply(this, arguments);
 
 		// unregister for messaging (on MessageManager)
 		sap.ui.getCore().getMessageManager().unregisterObject(this);
 
-		// static initialization (unload includes, ... / unregister customzing)
-		//   => either exit the static or the instance manifest
-		if (!this._isVariant()) {
-			this.getMetadata().exit();
-		} else {
+		// manifest exit (unload includes, ... / unregister customzing)
+		//   => either call exit on the instance specific manifest or the static one on the ComponentMetadata
+		if (this._oManifest) {
 			this._oManifest.exit(this);
 			delete this._oManifest;
+		} else {
+			this.getMetadata().exit();
 		}
-
+		return Promise.all(aDestroyables);
 	};
 
 
@@ -1112,7 +1149,11 @@ sap.ui.define([
 		}
 
 		// create the component in the owner context of the current component
-		return Component._createComponent(mConfig, this);
+		var oComponent = Component._createComponent(mConfig, this);
+		if (oComponent instanceof Promise) {
+			this.registerForDestroy(oComponent);
+		}
+		return oComponent;
 	};
 
 	/**
@@ -1884,8 +1925,6 @@ sap.ui.define([
 		LoaderExtensions.registerResourcePath(sModuleNamePrefix.replace(/\./g, "/"), vUrlPrefix);
 	}
 
-
-
 	function loadManifests(oRootMetadata) {
 		var aManifestsToLoad = [];
 		var aMetadataObjects = [];
@@ -1992,14 +2031,28 @@ sap.ui.define([
 	 *   };
 	 * });
 	 * </pre>
-	 * <b>ATTENTION:</b> This hook must only be used by UI flexibility (library:
-	 * sap.ui.fl) and will be replaced with a more generic solution!
+	 * <b>ATTENTION:</b> This hook must only be used by UI flexibility (sap.ui.fl)
+	 * or the sap.ui.integration library.
 	 *
 	 * @private
-	 * @ui5-restricted sap.ui.fl
+	 * @ui5-restricted sap.ui.fl,sap.ui.integration
 	 * @since 1.43.0
 	 */
-	Component._fnOnInstanceCreated = null;
+	var _aInstanceCreatedListeners = [];
+
+	// [Compatibility]: We need to accept multiple onInstanceCreated listeners,
+	//                  but still want to support the definition via assignment
+	Object.defineProperty(Component, "_fnOnInstanceCreated", {
+		get : function () { return _aInstanceCreatedListeners[0]; },
+		set : function (fn) {
+			if (typeof fn === "function") {
+				_aInstanceCreatedListeners.push(fn);
+			} else {
+				// falsy values clear the list of listeners (a null assignment is used in different unit-tests)
+				_aInstanceCreatedListeners = [];
+			}
+		}
+	});
 
 	/**
 	 * Callback handler which will be executed once the manifest.json was
@@ -2066,6 +2119,7 @@ sap.ui.define([
 	 *     If it is set to a falsy value, the manifest will not be evaluated before the controller. It might still be loaded synchronously
 	 *     if declared in the Component metadata.
 	 *     A non-empty string value will be interpreted as the URL to load the manifest from.
+	 *     If the manifest could not be loaded from a given URL, the Promise returned by the </code>Component.create</code> factory rejects.
 	 *     A non-null object value will be interpreted as manifest content.
 	 * @param {string} [mOptions.altManifestUrl] @since 1.61.0 Alternative URL for the manifest.json. If <code>mOptions.manifest</code>
 	 *     is set to an object value, this URL specifies the location to which the manifest object should resolve the relative
@@ -2233,19 +2287,26 @@ sap.ui.define([
 			}
 		}
 
+		// collect instance-created listeners
+		function callInstanceCreatedListeners(oInstance, vConfig) {
+			return _aInstanceCreatedListeners.map(function(fn) {
+				return fn(oInstance, vConfig);
+			});
+		}
+
 		function notifyOnInstanceCreated(oInstance, vConfig) {
 			if (vConfig.async) {
 				var pRootControlReady = oInstance.rootControlLoaded ? oInstance.rootControlLoaded() : Promise.resolve();
-				if (typeof Component._fnOnInstanceCreated === "function") {
-					return pRootControlReady.then(function() {
-						return Component._fnOnInstanceCreated(oInstance, vConfig);
-					});
-				}
-				// If we're async but we don't have a promise we still need to be one !
-				return pRootControlReady;
-			}
-			if (typeof Component._fnOnInstanceCreated === "function") {
-				Component._fnOnInstanceCreated(oInstance, vConfig);
+
+				// collect instance-created listeners
+				var aOnInstanceCreatedPromises = callInstanceCreatedListeners(oInstance, vConfig);
+
+				// root control loaded promise
+				aOnInstanceCreatedPromises.push(pRootControlReady);
+
+				return Promise.all(aOnInstanceCreatedPromises);
+			} else {
+				callInstanceCreatedListeners(oInstance, vConfig);
 			}
 			return oInstance;
 		}
@@ -2317,9 +2378,25 @@ sap.ui.define([
 			//        constructor and delegate the current owner id for the instance creation
 			var sCurrentOwnerId = ManagedObject._sOwnerId;
 			return vClassOrPromise.then(function(oClass) {
-				return runWithOwner(function() {
-					return createInstance(oClass);
-				}, sCurrentOwnerId);
+				// [Compatibility]: We sequentialize the dependency loading for the inheritance chain of the component.
+				// This keeps the order of the dependency execution stable (e.g. thirdparty script includes).
+				var loadDependenciesAndIncludes = function (oMetadata) {
+					var oParent = oMetadata.getParent();
+					var oPromise = Promise.resolve();
+					if (oParent instanceof ComponentMetadata) {
+						oPromise = oPromise.then(function () {
+							return loadDependenciesAndIncludes(oParent);
+						});
+					}
+					return oPromise.then(function () {
+						return oMetadata.getManifestObject().loadDependenciesAndIncludes(true);
+					});
+				};
+				return loadDependenciesAndIncludes(oClass.getMetadata()).then(function () {
+					return runWithOwner(function() {
+						return createInstance(oClass);
+					}, sCurrentOwnerId);
+				});
 			});
 		} else {
 			// sync: constructor has been returned, instantiate component immediately
@@ -2355,10 +2432,10 @@ sap.ui.define([
 	 *     is set to a non-empty string, this URL specifies the location of the final component defined via that
 	 *     manifest, otherwise it specifies the location of the component defined via its name <code>mOptions.name</code>.
 	 * @param {boolean|string|object} [mOptions.manifest=true] Whether and from where to load the manifest.json for the Component.
-	 *     When set to any truthy value, the manifest will be loaded and evaluated before the Component controller.
-	 *     If it is set to a falsy value, the manifest will not be evaluated before the controller. It might still be loaded synchronously
-	 *     if declared in the Component metadata.
+	 *     When set to a truthy value, the manifest will be loaded and evaluated <b>before</b> the Component controller.
+	 *     When set to a falsy value, the manifest will be loaded and evaluated <b>after</b> the Component controller.
 	 *     A non-empty string value will be interpreted as the URL to load the manifest from.
+	 *     This implies that the manifest is loaded and evaluated <b>before</b> the Component controller.
 	 *     A non-null object value will be interpreted as manifest content.
 	 * @param {string} [mOptions.altManifestUrl] @since 1.61.0 Alternative URL for the manifest.json. If <code>mOptions.manifest</code>
 	 *     is set to an object value, this URL specifies the location to which the manifest object should resolve the relative
@@ -3080,13 +3157,21 @@ sap.ui.define([
 				Log.debug("Component.load: all promises fulfilled, then " + v);
 				if (oManifest) {
 					return oManifest.then(function(oLoadedManifest) {
-						// store the loaded manifest in the oManifest variable
-						// which is used for the scope constructor function
-						oManifest = oLoadedManifest;
-						// read the component name from the manifest and
-						// preload the dependencies defined in the manifest
-						sName = oManifest.getComponentName();
-						return preloadDependencies(sName, oManifest, true);
+						if (!oLoadedManifest._bLoadManifestRequestFailed) {
+							// store the loaded manifest in the oManifest variable
+							// which is used for the scope constructor function
+							oManifest = oLoadedManifest;
+							// read the component name from the manifest and
+							// preload the dependencies defined in the manifest
+							sName = oManifest.getComponentName();
+							return preloadDependencies(sName, oManifest, true);
+						} else {
+							// Set oManifest to undefined in case the loadManifest request failed
+							// This should be only the case if manifestFirst is true but there was
+							// no manifest.json
+							oManifest = undefined;
+							return oManifest;
+						}
 					});
 				} else {
 					return v;
@@ -3578,7 +3663,23 @@ sap.ui.define([
 				}, this);
 		}
 
-		return bIsKeepAliveSupported;
+		return !!bIsKeepAliveSupported;
+	};
+
+	/**
+	 * Register a <code>Promise</code> to handle asynchronous destroy
+	 *
+	 * @param {Promise} pInstance Promise to handle asynchronous destroy
+	 * @private
+	 */
+	Component.prototype.registerForDestroy = function(pInstance) {
+		var aDestroyables = this._getDestroyables();
+		pInstance = pInstance.then(function(oInstance) {
+			// if already resolved, destroy must be done by the application
+			aDestroyables.splice(aDestroyables.indexOf(pInstance),1);
+			return oInstance;
+		});
+		aDestroyables.push(pInstance);
 	};
 
 	/**

package/src/sap/ui/core/ComponentContainer.js

@@ -61,7 +61,7 @@ sap.ui.define([
 	 * See also {@link module:sap/ui/core/ComponentSupport}.
 	 *
 	 * @extends sap.ui.core.Control
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 *
 	 * @public
 	 * @alias sap.ui.core.ComponentContainer
@@ -69,7 +69,9 @@ sap.ui.define([
 	 */
 	var ComponentContainer = Control.extend("sap.ui.core.ComponentContainer", /** @lends sap.ui.core.ComponentContainer.prototype */ {
 		metadata : {
-
+			interfaces: [
+				"sap.ui.core.IPlaceholderSupport"
+			],
 			library : "sap.ui.core",
 			properties : {
 
@@ -253,6 +255,53 @@ sap.ui.define([
 		return sComponentId && Core.getComponent(sComponentId);
 	};
 
+	// Delegate registered by the ComponentContainer#showPlaceholder function
+	var oPlaceholderDelegate = {
+		"onAfterRendering": function() {
+			// check whether the placeholder is still active. If yes, show the placeholder again
+			if (this._placeholder) {
+				this._placeholder.show(this);
+			}
+		}
+	};
+
+	/**
+	 * Shows the provided placeholder on the component container.
+	 *
+	 * @param {object} mSettings Object containing the placeholder object
+	 * @param {sap.ui.core.Placeholder} mSettings.placeholder The placeholder instance
+	 * @public
+	 * @since 1.91
+	 */
+	ComponentContainer.prototype.showPlaceholder = function(mSettings) {
+		if (this._placeholder) {
+			this.hidePlaceholder();
+		}
+
+		if (this.getDomRef() && mSettings.placeholder) {
+			this._placeholder = mSettings.placeholder;
+			this._placeholder.show(this);
+		}
+
+		// Add an event delegate to reinsert the placeholder after it's removed after a rerendering
+		this.addEventDelegate(oPlaceholderDelegate, this);
+	};
+
+	/**
+	 * Hides the placeholder that is shown on the component container.
+	 *
+	 * @public
+	 * @since 1.91
+	 */
+	ComponentContainer.prototype.hidePlaceholder = function() {
+		if (this._placeholder) {
+			this._placeholder.hide();
+
+			// remove the delegate because the placeholder is hidden
+			this.removeEventDelegate(oPlaceholderDelegate);
+			this._placeholder = undefined;
+		}
+	};
 
 	/**
 	 * Sets the component of the container. Depending on the ComponentContainer's

package/src/sap/ui/core/ComponentMetadata.js

@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @public
 	 * @class
 	 * @author SAP SE
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 * @since 1.9.2
 	 * @alias sap.ui.core.ComponentMetadata
 	 * @extends sap.ui.base.ManagedObjectMetadata

package/src/sap/ui/core/ComponentSupport.js

@@ -97,7 +97,7 @@ sap.ui.define([
 	 * @author SAP SE
 	 * @public
 	 * @since 1.58.0
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 * @namespace
 	 * @alias module:sap/ui/core/ComponentSupport
 	 */

package/src/sap/ui/core/Configuration.js

@@ -164,6 +164,7 @@ sap.ui.define([
 					"xx-waitForTheme"       : { type : "string",  defaultValue : ""}, // rendering|init
 					"xx-hyphenation" : { type : "string",  defaultValue : ""}, // (empty string)|native|thirdparty|disable
 					"xx-flexBundleRequestForced" : { type : "boolean",  defaultValue : false },
+					// TODO: check and remove "xx-cssVariables" value after tooling also support CSS variables if possible
 					"xx-cssVariables"       : { type : "string",   defaultValue : "false" }, // false|true|additional (additional just includes the css_variables.css in addition)
 					"statistics"            : { type : "boolean",  defaultValue : false }
 			};
@@ -2282,4 +2283,4 @@ sap.ui.define([
 
 	return Configuration;
 
-});
+});

package/src/sap/ui/core/Control.js

@@ -77,7 +77,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Element
 	 * @abstract
 	 * @author SAP SE
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 * @alias sap.ui.core.Control
 	 * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
 	 */

package/src/sap/ui/core/Core.js

@@ -18,7 +18,6 @@ sap.ui.define([
 	'sap/ui/performance/trace/Interaction',
 	'./Component',
 	'./Configuration',
-	'./Control',
 	'./Element',
 	'./ElementMetadata',
 	'./FocusHandler',
@@ -59,7 +58,6 @@ sap.ui.define([
 		Interaction,
 		Component,
 		Configuration,
-		Control,
 		Element,
 		ElementMetadata,
 		FocusHandler,
@@ -212,7 +210,7 @@ sap.ui.define([
 	 * @extends sap.ui.base.Object
 	 * @final
 	 * @author SAP SE
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 * @alias sap.ui.core.Core
 	 * @public
 	 * @hideconstructor
@@ -1304,6 +1302,7 @@ sap.ui.define([
 						 * in the global context, without closure variables.
 						 * See http://www.ecma-international.org/ecma-262/5.1/#sec-10.4.2
 						 */
+						// eslint-disable-next-line no-eval
 						window.eval(vOnInit);  // csp-ignore-legacy-api
 					}
 				}
@@ -1620,7 +1619,7 @@ sap.ui.define([
 			libPackage = lib.replace(/\./g, '/'),
 			http2 = this.oConfiguration.getDepCache();
 
-		if ( fileType === 'none' || !!sap.ui.loader._.getModuleState(libPackage + '/library.js') ) {
+		if ( fileType === 'none' || sap.ui.loader._.getModuleState(libPackage + '/library.js') ) {
 			return Promise.resolve(true);
 		}
 
@@ -2645,6 +2644,15 @@ sap.ui.define([
 
 	// ---- UIArea and Rendering -------------------------------------------------------------------------------------
 
+	function placeControlAt(oDomRef, oControl) {
+		assert(typeof oDomRef === "string" || typeof oDomRef === "object", "oDomRef must be a string or object");
+		assert(oControl instanceof Interface || BaseObject.isA(oControl, "sap.ui.core.Control"), "oControl must be a Control or Interface");
+
+		if (oControl) {
+			oControl.placeAt(oDomRef, "only");
+		}
+	}
+
 	/**
 	 * Implicitly creates a new <code>UIArea</code> (or reuses an exiting one) for the given DOM reference and
 	 * adds the given control reference to the UIAreas content (existing content will be removed).
@@ -2654,15 +2662,9 @@ sap.ui.define([
 	 *            oControl the Control that should be the added to the <code>UIArea</code>.
 	 * @public
 	 * @deprecated As of version 1.1, use {@link sap.ui.core.Control#placeAt oControl.placeAt(oDomRef, "only")} instead.
+	 * @function
 	 */
-	Core.prototype.setRoot = function(oDomRef, oControl) {
-		assert(typeof oDomRef === "string" || typeof oDomRef === "object", "oDomRef must be a string or object");
-		assert(oControl instanceof Interface || oControl instanceof Control, "oControl must be a Control or Interface");
-
-		if (oControl) {
-			oControl.placeAt(oDomRef, "only");
-		}
-	};
+	Core.prototype.setRoot = placeControlAt;
 
 	/**
 	 * Creates a new {@link sap.ui.core.UIArea UIArea}.
@@ -2823,6 +2825,7 @@ sap.ui.define([
 				bUIUpdated = mUIAreas[sId].rerender() || bUIUpdated;
 			}
 
+		// eslint-disable-next-line no-unmodified-loop-condition
 		} while ( bLooped && this._sRerenderTimer ); // iterate if there are new rendering tasks
 
 		this._bRendering = false;
@@ -3186,7 +3189,7 @@ sap.ui.define([
 		var sName = oMetadata.getName(),
 			sLibraryName = oMetadata.getLibraryName() || "",
 			oLibrary = this.mLibraries[sLibraryName],
-			sCategory = Control.prototype.isPrototypeOf(oMetadata.getClass().prototype) ? 'controls' : 'elements';
+			sCategory = oMetadata.isA("sap.ui.core.Control") ? 'controls' : 'elements';
 
 		// if library has not been loaded yet, create empty 'adhoc' library
 		// don't set 'loaded' marker, so it might be loaded later
@@ -3702,7 +3705,7 @@ sap.ui.define([
 	 */
 	Core.prototype.byFieldGroupId = function(vFieldGroupIds) {
 		return Element.registry.filter(function(oElement) {
-			return oElement instanceof Control && oElement.checkFieldGroupIds(vFieldGroupIds);
+			return oElement.isA("sap.ui.core.Control") && oElement.checkFieldGroupIds(vFieldGroupIds);
 		});
 	};
 
@@ -3714,7 +3717,7 @@ sap.ui.define([
 	 * Note: to be compatible with future versions of this API, applications must not use the value <code>null</code>,
 	 * the empty string <code>""</code> or the string literals <code>"null"</code> or <code>"undefined"</code> as model name.
 	 *
-	 * @param {string|undefined} [sName] name of the model to be retrieved
+	 * @param {string} [sName] name of the model to be retrieved
 	 * @return {sap.ui.model.Model} oModel
 	 * @public
 	 */
@@ -4214,14 +4217,9 @@ sap.ui.define([
 	 * @public
 	 * @deprecated As of version 1.1, use {@link sap.ui.core.Control#placeAt Control#placeAt} instead.
 	 * @ui5-global-only
+	 * @function
 	 */
-	sap.ui.setRoot = function(oDomRef, oControl) {
-		assert(typeof oDomRef === "string" || typeof oDomRef === "object", "oDomRef must be a string or object");
-		assert(oControl instanceof Interface || oControl instanceof Control, "oControl must be a Control or Interface");
-
-		sap.ui.getCore().setRoot(oDomRef, oControl);
-	};
-
+	sap.ui.setRoot = placeControlAt;
 
 	/*
 	 * Create a new (the only) instance of the Core and return it's interface as module value.

package/src/sap/ui/core/CustomData.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * in the documentation.
 	 *
 	 * @extends sap.ui.core.Element
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 *
 	 * @public
 	 * @alias sap.ui.core.CustomData

package/src/sap/ui/core/CustomizingConfiguration.js

@@ -75,7 +75,7 @@ sap.ui.define([
 		 * gets removed again.
 		 *
 		 * @author SAP SE
-		 * @version 1.91.0
+		 * @version 1.93.2
 		 * @constructor
 		 * @private
 		 * @since 1.15.1
@@ -245,7 +245,7 @@ sap.ui.define([
 			hasCustomProperties: function(sViewName, vObject) {
 				var mSettings = {};
 				findConfig(CONFIG_VIEW_MODIFICATIONS, vObject, function(oConfig) {
-					if (!!oConfig[sViewName]) {
+					if (oConfig[sViewName]) {
 						mSettings = oConfig[sViewName];
 					}
 				});

package/src/sap/ui/core/DeclarativeSupport.js

@@ -40,7 +40,7 @@ sap.ui.define([
 	 * @class Static class for enabling declarative UI support.
 	 *
 	 * @author Peter Muessig, Tino Butz
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 * @since 1.7.0
 	 * @public
 	 * @alias sap.ui.core.DeclarativeSupport

package/src/sap/ui/core/Element.js

@@ -126,7 +126,7 @@ sap.ui.define([
 	 *
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 * @public
 	 * @alias sap.ui.core.Element
 	 * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel

package/src/sap/ui/core/ElementMetadata.js

@@ -4,8 +4,6 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
-/*global Promise */
-
 // Provides class sap.ui.core.ElementMetadata
 sap.ui.define([
 	'sap/base/Log',
@@ -25,7 +23,7 @@ sap.ui.define([
 	 *
 	 * @class
 	 * @author SAP SE
-	 * @version 1.91.0
+	 * @version 1.93.2
 	 * @since 0.8.6
 	 * @alias sap.ui.core.ElementMetadata
 	 * @extends sap.ui.base.ManagedObjectMetadata