@openui5/sap.ui.core 1.125.0 → 1.126.1

package/test/sap/ui/core/qunit/odata/v4/ODataModel.qunit.js

@@ -71,11 +71,11 @@ sap.ui.define([
 	QUnit.test("basics", function (assert) {
 		var oModel;
 
-		// @deprecated As of Version 1.110.0
+		/** @deprecated As of Version 1.110.0 */
 		assert.throws(function () {
 			return new ODataModel({synchronizationMode : undefined});
 		}, new Error("Synchronization mode must be 'None'"));
-		// @deprecated As of Version 1.110.0
+		/** @deprecated As of Version 1.110.0 */
 		assert.throws(function () {
 			return new ODataModel({synchronizationMode : "Nope"});
 		}, new Error("Synchronization mode must be 'None'"));
@@ -98,7 +98,7 @@ sap.ui.define([
 		// code under test: operation mode Server must not throw an error
 		oModel = this.createModel("", {
 			operationMode : OperationMode.Server,
-			// @deprecated As of Version 1.110.0
+			/** @deprecated As of Version 1.110.0 */
 			synchronizationMode : "None" // deprecated and optional, but still allowed
 		});
 
@@ -143,6 +143,7 @@ sap.ui.define([
 		assert.deepEqual(oModel.aAllBindings, []);
 		assert.strictEqual(oModel.aPrerenderingTasks, null);
 		assert.strictEqual(oModel.getOptimisticBatchEnabler(), null);
+		assert.strictEqual(oModel.fnHttpListener, null);
 		oMetaModel = oModel.getMetaModel();
 		assert.ok(oMetaModel instanceof ODataMetaModel);
 		assert.strictEqual(oMetaModel.oRequestor, oMetadataRequestor);
@@ -455,6 +456,7 @@ sap.ui.define([
 					getReporter : sinon.match.func,
 					isIgnoreETag : sinon.match.func,
 					onCreateGroup : sinon.match.func,
+					onHttpResponse : sinon.match.func,
 					reportStateMessages : sinon.match.func,
 					reportTransitionMessages : sinon.match.func,
 					updateMessages : sinon.match.func
@@ -509,6 +511,7 @@ sap.ui.define([
 					getReporter : "~fnGetReporter~",
 					isIgnoreETag : sinon.match.func,
 					onCreateGroup : sinon.match.func,
+					onHttpResponse : sinon.match.func,
 					reportStateMessages : "~fnReportStateMessages~",
 					reportTransitionMessages : "~fnReportTransitionMessages~",
 					updateMessages : sinon.match.func
@@ -585,6 +588,35 @@ sap.ui.define([
 		oModelInterface.updateMessages("~oldMessages~", "~newMessages~");
 
 		assert.strictEqual(oModelInterface.isIgnoreETag(), "~bIgnoreETag~");
+
+		assert.strictEqual(oModel.fnHttpListener, null, "not yet there");
+
+		// code under test (MUST NOT fail)
+		oModelInterface.onHttpResponse();
+
+		const fnHttpListener = sinon.spy();
+
+		// code under test
+		oModel.setHttpListener(fnHttpListener);
+
+		assert.strictEqual(oModel.fnHttpListener, fnHttpListener);
+
+		// code under test
+		oModelInterface.onHttpResponse("~mHeaders~");
+
+		assert.ok(fnHttpListener.calledOnce);
+		assert.ok(fnHttpListener.calledOn(undefined), "no this");
+		assert.ok(fnHttpListener.calledWithExactly({responseHeaders : "~mHeaders~"}));
+
+		// code under test
+		oModel.setHttpListener("foo");
+
+		assert.strictEqual(oModel.fnHttpListener, "foo");
+
+		// code under test
+		oModel.setHttpListener(null);
+
+		assert.strictEqual(oModel.fnHttpListener, null);
 	});
 });
 
@@ -1114,7 +1146,7 @@ sap.ui.define([
 		message : "Failure\n_Helper.createError@_Helper.js"
 	}].forEach(function (oFixture, i) {
 		QUnit.test("reportError, i:" + i, function () {
-			var sClassName = "sap.ui.model.odata.v4.ODataPropertyBinding",
+			var sClassName0 = "sap.ui.model.odata.v4.ODataPropertyBinding",
 				oError = new Error("Failure"),
 				oHelperMock = this.mock(_Helper),
 				sLogMessage = "Failed to read path /Product('1')/Unknown",
@@ -1126,7 +1158,7 @@ sap.ui.define([
 
 			oHelperMock.expects("extractMessages").withExactArgs(sinon.match.same(oError))
 				.returns("~extractedMessages~");
-			this.oLogMock.expects("error").withExactArgs(sLogMessage, oFixture.message, sClassName)
+			this.oLogMock.expects("error").withExactArgs(sLogMessage, oFixture.message, sClassName0)
 				.twice();
 			oModelMock.expects("reportStateMessages").never();
 			oModelMock.expects("reportTransitionMessages")
@@ -1134,8 +1166,8 @@ sap.ui.define([
 				.withExactArgs("~extractedMessages~", "resource/path");
 
 			// code under test
-			oModel.reportError(sLogMessage, sClassName, oError);
-			oModel.reportError(sLogMessage, sClassName, oError); // oError.$reported is now true
+			oModel.reportError(sLogMessage, sClassName0, oError);
+			oModel.reportError(sLogMessage, sClassName0, oError); // oError.$reported is now true
 		});
 	});
 

package/test/sap/ui/core/qunit/odata/v4/ODataModel.realOData.qunit.js

@@ -194,6 +194,7 @@ sap.ui.define([
 			getGroupProperty : defaultGetGroupProperty,
 			isIgnoreETag : function () {},
 			onCreateGroup : function () {},
+			onHttpResponse : function () {},
 			reportStateMessages : function () {},
 			reportTransitionMessages : function () {}
 		},
@@ -1031,12 +1032,12 @@ sap.ui.define([
 					method : "POST",
 					headers : oBatchHeaders,
 					data : oBatchRequestContent.body
-				}).then(function (oData, _sTextStatus, jqXHR) {
+				}).then(function (oData, _sTextStatus0, jqXHR0) {
 					var aResponses;
 
-					assert.strictEqual(jqXHR.status, 200);
+					assert.strictEqual(jqXHR0.status, 200);
 					aResponses = _Batch.deserializeBatchResponse(
-						jqXHR.getResponseHeader("Content-Type"), oData);
+						jqXHR0.getResponseHeader("Content-Type"), oData);
 
 					parseResponses(aResponses);
 
@@ -1080,12 +1081,12 @@ sap.ui.define([
 					"X-CSRF-Token" : sCsrfToken
 				},
 				data : oBatchRequestContent.body
-			}).then(function (oData, _sTextStatus, jqXHR) {
+			}).then(function (oData, _sTextStatus0, jqXHR0) {
 				var aResponses, oResponse;
 
-				assert.strictEqual(jqXHR.status, 200);
+				assert.strictEqual(jqXHR0.status, 200);
 				aResponses = _Batch.deserializeBatchResponse(
-					jqXHR.getResponseHeader("Content-Type"), oData);
+					jqXHR0.getResponseHeader("Content-Type"), oData);
 
 				assert.strictEqual(aResponses.length, 1);
 				oResponse = aResponses[0];

package/test/sap/ui/core/qunit/odata/v4/ODataPropertyBinding.qunit.js

@@ -596,7 +596,10 @@ sap.ui.define([
 	});
 
 	//*********************************************************************************************
-	QUnit.test("checkUpdateInternal with object value, success", function (assert) {
+[BindingMode.OneTime, BindingMode.OneWay].forEach((sBindingMode) => {
+	const sTitle = "checkUpdateInternal with object value, success: " + sBindingMode;
+
+	QUnit.test(sTitle, function (assert) {
 		var oContext = Context.create(this.oModel, {}, "/EntitySet('foo')"),
 			sPath = "nonPrimitive",
 			oBinding = this.oModel.bindProperty(sPath, oContext),
@@ -604,7 +607,7 @@ sap.ui.define([
 			vValueClone = {};
 
 		oBinding.sReducedPath = "~reduced~";
-		oBinding.setBindingMode(BindingMode.OneTime);
+		oBinding.setBindingMode(sBindingMode);
 		oBinding.setType(null, "any");
 		this.mock(oContext).expects("fetchValue")
 			.withExactArgs(oBinding.sReducedPath, sinon.match.same(oBinding))
@@ -619,6 +622,7 @@ sap.ui.define([
 			assert.strictEqual(oBinding.getValue(), vValueClone);
 		});
 	});
+});
 
 	//*********************************************************************************************
 	QUnit.test("checkUpdateInternal with action advertisement object value, success",
@@ -655,15 +659,11 @@ sap.ui.define([
 		internalType : "any",
 		mode : BindingMode.OneTime,
 		path : "/EntitySet('bar')/nonPrimitive"
-	}, { // must have mode OneTime
-		internalType : "any",
-		mode : BindingMode.OneWay,
-		path : "nonPrimitive"
-	}, { // must have mode OneTime
+	}, { // must have mode OneTime/OneWay
 		internalType : "any",
 		mode : BindingMode.TwoWay,
 		path : "nonPrimitive"
-	}, { // must have mode OneTime, also for the case "branch into metadata via ##"
+	}, { // must have mode OneTime for the case "branch into metadata via ##"
 		internalType : "any",
 		mode : BindingMode.OneWay,
 		path : "##@SAP_Common.Label"
@@ -690,7 +690,7 @@ sap.ui.define([
 					.withExactArgs(sinon.match.same(oGroupLock), undefined, sinon.match.func,
 						sinon.match.same(oBinding))
 					.returns(SyncPromise.resolve(Promise.resolve().then(function () {
-						that.mock(oBinding).expects("assertSameCache")
+						that.mock(oBinding).expects("checkSameCache")
 							.withExactArgs(sinon.match.same(oCache));
 						return vValue;
 					})));
@@ -1256,8 +1256,7 @@ sap.ui.define([
 		// e.g. {"type" : "point", "coordinates" : [142.1, 64.1]}
 	].forEach(function (oValue) {
 		QUnit.test("bindProperty with non-primitive " + JSON.stringify(oValue), function (assert) {
-			var oBinding,
-				oCache = {
+			var oCache = {
 					fetchValue : function (_sGroupId, _sPath, fnDataRequested) {
 						fnDataRequested();
 						return Promise.resolve(oValue);
@@ -1298,7 +1297,7 @@ sap.ui.define([
 				}
 			}});
 
-			oBinding = oControl.getBinding("text");
+			const oBinding = oControl.getBinding("text");
 			return Promise.all([
 				oDataReceivedPromise,
 				fnSpy.returnValues[0].then(function () {
@@ -1324,8 +1323,8 @@ sap.ui.define([
 		this.mock(_Cache).expects("createProperty").returns(oCache);
 		this.mock(this.oModel).expects("reportError")
 			.withExactArgs("Failed to read path /path", sClassName, sinon.match.same(oError))
-			.callsFake(function (_sLogMessage, _sReportingClassName, oError) {
-				oError.$reported = true; // important for #getReporter
+			.callsFake(function (_sLogMessage, _sReportingClassName, oError0) {
+				oError0.$reported = true; // important for #getReporter
 			});
 
 		//code under test

package/test/sap/ui/core/qunit/odata/v4/_AnnotationHelperExpression.qunit.js

@@ -72,7 +72,7 @@ sap.ui.define([
 		oFixture.values.forEach(function (vConstantValue) {
 			var oValue = {};
 
-			function testIt(oRawValue, sProperty, vConstantValue) {
+			function testIt(oRawValue, sProperty, vConstantValue0) {
 				QUnit.test("14.4.x Constant Expression: " + JSON.stringify(oRawValue),
 					function (assert) {
 						var oBasics = this.mock(Basics),
@@ -93,14 +93,14 @@ sap.ui.define([
 								.withExactArgs({
 										model : sinon.match.same(oModel),
 										path : "/my/path/" + sProperty,
-										value : vConstantValue
+										value : vConstantValue0
 									}, oFixture.expectType);
 						}
 
 						oExpectedResult = {
 							result : "constant",
 							type : oFixture.type,
-							value : vConstantValue
+							value : vConstantValue0
 						};
 
 						// code under test