npm - @openui5/sap.ui.core - Versions diffs - 1.125.0 → 1.126.0 - Mend

@openui5/sap.ui.core 1.125.0 → 1.126.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (462) hide show

package/test/sap/ui/core/qunit/fieldhelp/FieldHelpUtil.qunit.js ADDED Viewed

@@ -0,0 +1,55 @@
+/*!
+ * ${copyright}
+ */
+sap.ui.define([
+	"sap/base/Log",
+	"sap/ui/core/Element",
+	"sap/ui/core/fieldhelp/FieldHelpUtil"
+], function (Log, Element, FieldHelpUtil) {
+	/*global sinon, QUnit*/
+	"use strict";
+	//*********************************************************************************************
+	QUnit.module("sap/ui/core/fieldhelp/FieldHelpUtil", {
+		beforeEach : function () {
+			this.oLogMock = this.mock(Log);
+			this.oLogMock.expects("error").never();
+			this.oLogMock.expects("warning").never();
+		}
+	});
+	//*********************************************************************************************
+[true, false].forEach((bFieldHelpActive) => {
+	QUnit.test("setDocumentationRef: field help is active: " + bFieldHelpActive, function (assert) {
+		const oElement = new Element();
+		const oElementMock = this.mock(oElement);
+		const aDocumentationRefs = ["~vValue"];
+		oElementMock.expects("data")
+			.withExactArgs("sap-ui-DocumentationRef",
+				sinon.match.same(aDocumentationRefs).and(sinon.match(["~vValue"])),
+				false);
+		if (bFieldHelpActive) {
+			oElement.updateFieldHelp = () => {};
+			oElementMock.expects("updateFieldHelp").withExactArgs();
+		}
+		// code under test
+		FieldHelpUtil.setDocumentationRef(oElement, aDocumentationRefs);
+		oElementMock.expects("data").withExactArgs("sap-ui-DocumentationRef", ["~vValue0"], false);
+		if (bFieldHelpActive) {
+			oElementMock.expects("updateFieldHelp").withExactArgs();
+		}
+		// code under test - single documentation ref is always passed as array for the update
+		FieldHelpUtil.setDocumentationRef(oElement, "~vValue0");
+		if (bFieldHelpActive) {
+			oElementMock.expects("updateFieldHelp").withExactArgs();
+		}
+		// code under test
+		oElement.destroy();
+	});
+});
+});

package/test/sap/ui/core/qunit/fieldhelp/testsuite.fieldhelp.qunit.html ADDED Viewed

@@ -0,0 +1,12 @@
+<html>
+	<head>
+		<title>TestSuite for sap.ui.core.fieldhelp: GTP testcase CORE/FIELDHELP</title>
+		<meta charset="utf-8">
+		<base href="../../../../../../">
+		<script src="resources/sap/ui/test/starter/createSuite.js"
+				data-sap-ui-testsuite="test-resources/sap/ui/core/qunit/fieldhelp/testsuite.fieldhelp.qunit">
+		</script>
+	</head>
+	<body>
+	</body>
+</html>

package/test/sap/ui/core/qunit/fieldhelp/testsuite.fieldhelp.qunit.js ADDED Viewed

@@ -0,0 +1,50 @@
+sap.ui.define(function () {
+	"use strict";
+	return {
+		name : "TestSuite for sap.ui.core.fieldhelp: GTP testcase CORE/FIELDHELP",
+		defaults : {
+			group : "Models",
+			qunit : {
+				versions : {
+					"2.18" : {
+						module : "test-resources/sap/ui/core/qunit/thirdparty/qunit-2.18",
+						css : "test-resources/sap/ui/core/qunit/thirdparty/qunit-2.18.css"
+					}
+				},
+				version : "2.18"
+			},
+			sinon : {
+				versions : {
+					"14.0" : {
+						module : "test-resources/sap/ui/core/qunit/thirdparty/sinon-14.0",
+						bridge : "sap/ui/qunit/sinon-qunit-bridge"
+					}
+				},
+				version : "14.0",
+				qunitBridge : true,
+				useFakeTimer : false
+			},
+			ui5 : {
+				language : "en-US",
+				rtl : false,
+				libs : [],
+				"xx-waitForTheme" : "init"
+			},
+			coverage : {
+				only : "[sap/ui/core/fieldhelp]",
+				branchTracking : true
+			},
+			loader : {
+				paths : {
+					"sap/ui/core/qunit" : "test-resources/sap/ui/core/qunit"
+				}
+			},
+			autostart : true
+		},
+		tests : {
+			FieldHelp : {},
+			FieldHelpUtil : {}
+		}
+	};
+});

package/test/sap/ui/core/qunit/internal/1RingModels.qunit.html CHANGED Viewed

@@ -38,7 +38,7 @@
 		<script src="resources/sap/ui/test/ModuleTracking.js"></script>
 		<script src="resources/sap/ui/qunit/qunit-coverage-istanbul.js"
 			data-sap-ui-cover-never="[.qunit.js,/model/base/,/model/controlhelper/,/odata/v4/]"
-			data-sap-ui-cover-only="[CalendarType,ExpressionParser,LocaleData,Model.support,/core/date/,/core/format/,/ui/model/]">
+			data-sap-ui-cover-only="[CalendarType,ExpressionParser,LocaleData,Model.support,/core/date/,/core/format/,/fieldhelp/,/ui/model/]">
 		</script>
 		<script src="test-resources/sap/ui/core/qunit/internal/1RingModels.qunit.js"></script>

package/test/sap/ui/core/qunit/internal/1RingModels.qunit.js CHANGED Viewed

@@ -44,6 +44,12 @@ sap.ui.require([
 		"sap/ui/core/qunit/i18n/UniversalDate.qunit",
 		"sap/ui/core/qunit/i18n/UniversalDateUtils.qunit",
+		// ***************************************************************************************
+		// sap.ui.core.fieldhelp.* - tests are contained in testsuite.fieldhelp.qunit.js
+		// ***************************************************************************************
+		"sap/ui/core/qunit/fieldhelp/FieldHelp.qunit",
+		"sap/ui/core/qunit/fieldhelp/FieldHelpUtil.qunit",
 		// ***************************************************************************************
 		// sap.ui.core.format.* - tests are contained in testsuite.types.qunit.js
 		// ***************************************************************************************
@@ -92,7 +98,6 @@ sap.ui.require([
 		"sap/ui/core/qunit/model/CompositeDataState.qunit",
 		"sap/ui/core/qunit/model/Context.qunit",
 		"sap/ui/core/qunit/model/ContextBinding.qunit",
-		"sap/ui/core/qunit/model/FieldHelp.qunit",
 		"sap/ui/core/qunit/model/Filter.qunit",
 		"sap/ui/core/qunit/model/FilterProcessor.qunit",
 		"sap/ui/core/qunit/model/ListBinding.qunit",

package/test/sap/ui/core/qunit/internal/testsuite.feature-odata-v4.qunit.js CHANGED Viewed

@@ -15,7 +15,7 @@ sap.ui.define(function () {
 			ui5 : {
 				language : "en-US",
 				rtl : false,
-				libs : null,
+				libs : [],
 				"xx-waitForTheme" : "init"
 			},
 			coverage : {

package/test/sap/ui/core/qunit/jquery-mobile-custom.beforeBootstrap.js ADDED Viewed

@@ -0,0 +1,11 @@
+/* global sinon */
+sap.ui.define([
+	"sap/ui/Device"
+], (
+	Device
+) => {
+	"use strict";
+	// Stub touch support
+	sinon.stub(Device, "support").value({ touch: true });
+});

package/test/sap/ui/core/qunit/jquery-mobile-custom.qunit.js CHANGED Viewed

@@ -8,9 +8,6 @@ sap.ui.define(["sap/ui/Device"], function (Device) {
 		// Preparation
 		var done = assert.async();
-		// Stub touch support
-		this.stub(Device, "support").value({ touch: true });
 		// load and boot the core
 		sap.ui.require(["sap/ui/core/Core", "sap/ui/thirdparty/jquery"], function (Core, jQuery) {
 			Core.ready().then(function () {
@@ -24,6 +21,9 @@ sap.ui.define(["sap/ui/Device"], function (Device) {
 				done();
 			});
+			/**
+			 * @deprecated
+			 */
 			Core.boot();
 		}, function (oErr) {
 			assert.strictEqual(oErr, {}, "Requiring the Core must not fail");

package/test/sap/ui/core/qunit/json/JSONModel.qunit.js CHANGED Viewed

@@ -999,4 +999,25 @@ sap.ui.define([
 		oLabel.unbindElement();
 		assert.equal(oLabel.getText(), "", "text value from model");
 	});
+	//*********************************************************************************************
+	// DINC0180763
+	QUnit.test("loadData: calls _ajax with jsonp=false", function () {
+		const oModel = {
+			_ajax() {},
+			fireRequestSent() {}
+		};
+		this.mock(oModel).expects("fireRequestSent").withExactArgs({
+			async: false, headers: "~mHeaders", info: "cache=~bCache;bMerge=~bMerge",
+			infoObject: {cache: "~bCache", merge: "~bMerge"}, type: "~sType", url: "~sURL"
+		});
+		this.mock(oModel).expects("_ajax").withExactArgs({
+			async: false, cache: "~bCache", data: "~oParameters", dataType: 'json', error: sinon.match.func,
+			headers: "~mHeaders", jsonp: false, success: sinon.match.func, type: "~sType", url: "~sURL"
+		});
+		// code under test
+		JSONModel.prototype.loadData.call(oModel, "~sURL", "~oParameters", false, "~sType", "~bMerge", "~bCache",
+			"~mHeaders");
+	});
 });

package/test/sap/ui/core/qunit/loader/asyncMode.qunit.js CHANGED Viewed

@@ -899,17 +899,13 @@
 	QUnit.module("Complex Scenario");
-	QUnit.test("Boot UI5 Core", function(assert) {
+	QUnit.test("Test jQuery shim", function(assert) {
 		var done = assert.async();
-		assert.equal(sap.ui.require('sap/ui/core/Core'), null, "Core must not have been loaded");
 		// Act
-		sap.ui.require(['sap/ui/core/Core'], function(Core) {
-			// loading succeeded, that's a good news on its own
-			assert.ok(!!Core, "Core has been loaded");
+		sap.ui.require(['sap/ui/thirdparty/jquery'], function(jQ1) {
 			// the duplicate registration of jQuery should have worked
-			var jQ1 = sap.ui.require('sap/ui/thirdparty/jquery');
 			var jQ2 = sap.ui.require('jquery');
 			assert.ok(jQ1, "...thirdparty/jquery has been loaded");
 			assert.ok(jQ2, "jquery should have registered itself as 'jquery'");

package/test/sap/ui/core/qunit/loader/config.qunit.js CHANGED Viewed

@@ -186,7 +186,9 @@
 	});
+	/**
+	 * @deprecated
+	 */
 	QUnit.module("Config variants for async", {
 		afterEach: function() {
 			removeUi5Loader();
@@ -294,6 +296,9 @@
 		});
 	});
+	/**
+	 * @deprecated
+	 */
 	QUnit.test("Expose loader via bootstrap attribute", function(assert) {
 		var done = assert.async();
@@ -320,7 +325,41 @@
 		}, {"data-sap-ui-amd": "true"});
 	});
+	QUnit.module("Bootstrap config");
-	QUnit.start();
+	QUnit.test("Expose loader via bootstrap attribute", function(assert) {
+		const done = assert.async(),
+			startCore = (callback, mTagAttributes) => {
+			appendScript("../../../../../../resources/sap-ui-core.js", function() {
+				sap.ui.loader.config({
+					baseUrl: "./"
+				});
+				callback();
+			}, "sap-ui-bootstrap", mTagAttributes);
+		};
+		assert.strictEqual(window.require, otherRequire, "global require should be the 'other' loader's implementation again");
+		assert.strictEqual(window.define, otherDefine, "global define should be the 'other' loader's implementation again");
+		startCore(function() {
+			var privateLoaderAPI = sap.ui.loader._;
+			assert.notStrictEqual(window.require, otherRequire, "global require should have changed");
+			assert.notStrictEqual(window.define, otherDefine, "global define should have changed");
+			assert.strictEqual(window.require, privateLoaderAPI.amdRequire, "global require should be the UI5 implementation");
+			assert.strictEqual(window.define, privateLoaderAPI.amdDefine, "global define should be the UI5 implementation");
+			// hide UI5 implementation again
+			sap.ui.loader.config({
+				amd: false
+			});
+			assert.strictEqual(window.require, otherRequire, "global require should be the 'other' loader's implementation again");
+			assert.strictEqual(window.define, otherDefine, "global define should be the 'other' loader's implementation again");
+			done();
+		}, {"data-sap-ui-amd": "true"});
+	});
+	QUnit.start();
 }());

package/test/sap/ui/core/qunit/mvc/testsuite.mvc.qunit.js CHANGED Viewed

@@ -7,16 +7,21 @@ sap.ui.define(["sap/ui/Device"], function(Device) {
 			loader: {
 				paths: {
 					"testdata/fragments": "test-resources/sap/ui/core/qunit/testdata/fragments/", // fragments used in views
-// @deprecated as of 1.110
+					/**
+					 * @deprecated as of 1.110
+					 */
 					"testdata/fragments_legacyAPIs": "test-resources/sap/ui/core/qunit/testdata/fragments_legacyAPIs/", // fragments used in views
 					"testdata/mvc": "test-resources/sap/ui/core/qunit/mvc/testdata", // used by async tests
-					// @deprecated as of 1.110
+					/**
+					 * @deprecated as of 1.110
+					 */
 					"testdata/mvc_legacyAPIs": "test-resources/sap/ui/core/qunit/mvc_legacyAPIs/testdata",
 					"example/mvc": "test-resources/sap/ui/core/qunit/mvc/testdata", // used by sync tests
-					// @deprecated as of 1.110
+					/**
+					 * @deprecated as of 1.110
+					 */
 					"example/mvc_legacyAPIs": "test-resources/sap/ui/core/qunit/mvc_legacyAPIs/testdata",
 					"sap/ui/testlib": "test-resources/sap/ui/core/qunit/testdata/uilib/" // used by sync tests
 				}

package/test/sap/ui/core/qunit/odata/ODataUtils.qunit.js CHANGED Viewed

@@ -686,45 +686,38 @@ sap.ui.define([
 [{
 	description : "range w/o prefetch, no elements",
 	range : [0, 10, 0],
-	readRange : {start : 0, length : 10},
 	aElements : [],
 	intervals : [{start : 0, end : 10}]
 }, {
 	description : "range w/o prefetch, 1 element",
 	range : [0, 10, 0],
-	readRange : {start : 0, length : 10},
 	aElements : [{}],
 	intervals : [{start : 1, end : 10}]
 }, {
 	description : "range w/o prefetch, 1 element, limit = 1",
 	range : [0, 10, 0],
-	readRange : {start : 0, length : 10},
 	aElements : [{}],
 	limit : 1,
 	intervals : []
 }, {
 	description : "range w/o prefetch, 3 elements, limit 9, 2 gaps",
 	range : [0, 10, 0],
-	readRange : {start : 0, length : 10},
 	aElements : [{}, undefined, undefined, {}, undefined, {}],
 	limit : 9,
 	intervals : [{start : 1, end : 3}, {start : 4, end : 5}, {start : 6, end : 9}]
 }, {
 	description : "range w/ prefetch, no elements, left gap < prefetch",
 	range : [51, 10, 100],
-	readRange : {start : 0, length : 161},
 	aElements : [],
 	intervals : [{start : 0, end : 161}]
 }, {
 	description : "range w/ prefetch, no elements, left gap > prefetch",
 	range : [151, 10, 100],
-	readRange : {start : 51, length : 210},
 	aElements : [],
 	intervals : [{start : 51, end : 261}]
 }, {
 	description : "range w/ prefetch outside of limit, 3 elements, limit 111, 2 gaps",
 	range : [6, 10, 100],
-	readRange : {start : 0, length : 116},
 	aElements : [{}, undefined, undefined, {}, undefined, {}],
 	limit : 111,
 	intervals : [{start : 1, end : 3}, {start : 4, end : 5}, {start : 6, end : 111}]
@@ -735,7 +728,7 @@ sap.ui.define([
 		this.mock(ODataUtils).expects("_getReadRange")
 			.withExactArgs(sinon.match.same(oFixture.aElements), oFixture.range[0],
 				oFixture.range[1], oFixture.range[2])
-			.returns(oFixture.readRange);
+			.callThrough();
 		// code under test
 		aIntervals = ODataUtils._getReadIntervals(oFixture.aElements, oFixture.range[0],
@@ -770,11 +763,11 @@ sap.ui.define([
 }, { // missing a row at the end
 	current : [[0, 110]],
 	range : [51, 10, 100],
-	expected : {start : 51, length : 110}
+	expected : {start : 51, length : 159}
 }, { // missing a row before the start
 	current : [[100, 260]],
 	range : [149, 10, 100],
-	expected : {start : 49, length : 110}
+	expected : {start : 0, length : 159}
 }, { // missing a row before the start, do not read beyond 0
 	current : [[40, 200]],
 	range : [89, 10, 100],
@@ -785,7 +778,7 @@ sap.ui.define([
 }, { // missing data on both sides, do not read beyond 0
 	current : [[40, 100]],
 	range : [89, 10, 100],
-	expected : {start : 0, length : 199}
+	expected : {start : 0, length : 200}
 }, { // fetch all data
 	range : [0, 0, Infinity],
 	expected : {start : 0, length : Infinity}
@@ -799,7 +792,7 @@ sap.ui.define([
 }, { // odd prefetch length, prefetch before
 	current : [[25, 50]],
 	range : [27, 3, 5],
-	expected : {start : 22, length : 8}
+	expected : {start : 20, length : 10}
 }].forEach(function (oFixture) {
 	QUnit.test("_getReadRange: " + oFixture.range, function (assert) {
 		var aElements = [],

package/test/sap/ui/core/qunit/odata/type/testsuite.odata.types.qunit.js CHANGED Viewed

@@ -13,6 +13,7 @@ sap.ui.define(function () {
 				version : "edge"
 			},
 			ui5 : {
+				libs: ["sap.ui.core"],
 				language : "en-US",
 				rtl : false,
 				"xx-waitForTheme" : true