@openui5/sap.ui.core 1.123.1 → 1.124.1

package/test/sap/ui/core/qunit/messages/messagesGeneral.qunit.js

@@ -1,8 +1,11 @@
-/*global QUnit */
+/*global QUnit, sinon */
 sap.ui.define([
+	"sap/base/future",
+	"sap/base/Log",
 	"sap/ui/core/library",
 	"sap/ui/core/message/ControlMessageProcessor",
 	"sap/ui/core/message/Message",
+	"sap/ui/core/message/MessageType",
 	"sap/ui/core/Messaging",
 	"sap/ui/core/UIAreaRegistry",
 	"sap/ui/model/FormatException",
@@ -17,9 +20,12 @@ sap.ui.define([
 	"sap/ui/qunit/utils/createAndAppendDiv",
 	"sap/ui/test/TestUtils"
 ], function(
+	future,
+	Log,
 	coreLibrary,
 	ControlMessageProcessor,
 	Message,
+	MessageType,
 	Messaging,
 	UIAreaRegistry,
 	FormatException,
@@ -40,7 +46,6 @@ sap.ui.define([
 	createAndAppendDiv("content");
 
 	// shortcuts for enums from the sap.ui.core namespace
-	var MessageType = coreLibrary.MessageType;
 	var ValueState = coreLibrary.ValueState;
 
 	var oModel;
@@ -119,7 +124,6 @@ sap.ui.define([
 		if (oControl.propagateMessages) {
 			var fnPropagate = oControl.propagateMessages;
 			oControl.propagateMessages = function(sProp, aMessages) {
-				Input.prototype.propagateMessages.apply(oControl, arguments);
 				fnTest(sProp, aMessages);
 				oControl.propagateMessages = fnPropagate;
 			};
@@ -189,6 +193,38 @@ sap.ui.define([
 		assert.equal(oMessageModel.getObject('/').length, 0, 'No Messages');
 	});
 
+	/**
+	 * @deprecated
+	 */
+	QUnit.test("addMessage: propagateMessages not implemented (future=false)", function(assert) {
+		future.active = false;
+		const WarningLogSpy = sinon.spy(Log, "warning");
+		const oTestInput = new Input("TESTID", {value:""});
+		const oMessage = createControlMessage("TEST", oTestInput.getId() + "/value");
+		const expectedMessage = "[FUTURE FATAL] Message for Element sap.m.Input#TESTID, Property value received. Control sap.m.Input does not support messaging without using data binding.";
+		Messaging.addMessages(oMessage);
+		assert.equal(WarningLogSpy.callCount, 1, "Warning logged");
+		assert.equal(WarningLogSpy.getCall(0).args[0], expectedMessage, "Not Implemented text logged logged");
+		future.active = undefined;
+		Messaging.removeAllMessages();
+		oTestInput.destroy();
+	});
+
+	QUnit.test("addMessage: propagateMessages not implemented (future=true)", function(assert) {
+		future.active = true;
+		const oTestInput = new Input("TESTID", {value:""});
+		const oMessage = createControlMessage("TEST", oTestInput.getId() + "/value");
+		const expectedMessage = "Message for Element sap.m.Input#TESTID, Property value received. Control sap.m.Input does not support messaging without using data binding.";
+		assert.throws(() => {
+			Messaging.addMessages(oMessage);
+		}, new Error(expectedMessage));
+		assert.throws(() => {
+			Messaging.removeAllMessages();
+		}, new Error(expectedMessage));
+		oTestInput.destroy();
+		future.active = undefined;
+	});
+
 	QUnit.test("addMessage", function(assert) {
 		var done = assert.async();
 		var oMessageModel = Messaging.getMessageModel();
@@ -448,7 +484,7 @@ sap.ui.define([
 		var count = 0;
 		var done = assert.async();
 		Messaging.removeAllMessages();
-		var oTestInput = new Input({value:""});
+		var oTestInput = new Input({value:"{/}"});
 		oTestInput.placeAt("content");
 		var sControlId = oTestInput.getId();
 		var oMessage = createControlMessage("TEST", "/" + sControlId + "/value");
@@ -646,6 +682,7 @@ sap.ui.define([
 			value: "{/test}"
 		});
 
+		spyPropagateMessages(oInput, () => {});
 
 		oInput.setModel(oModel);
 		Messaging.registerObject(oInput);

package/test/sap/ui/core/qunit/messages/messagesUsage.qunit.js

@@ -5,6 +5,7 @@ sap.ui.define([
 	'sap/ui/model/Model',
 	'sap/ui/model/type/Integer',
 	'sap/ui/core/message/Message',
+	'sap/ui/core/message/MessageType',
 	'sap/ui/core/Messaging',
 	'sap/ui/core/library',
 	'sap/ui/core/Component',
@@ -15,7 +16,7 @@ sap.ui.define([
 	'sap/ui/qunit/utils/createAndAppendDiv',
 	"sap/ui/qunit/utils/nextUIUpdate",
 	"sap/ui/test/TestUtils"
-], function(isPlainObject, Input, Model, Integer, Message, Messaging, library, Component, ComponentContainer, Element, JSONModel, UIComponent, createAndAppendDiv, nextUIUpdate, TestUtils){
+], function(isPlainObject, Input, Model, Integer, Message, MessageType, Messaging, library, Component, ComponentContainer, Element, JSONModel, UIComponent, createAndAppendDiv, nextUIUpdate, TestUtils){
 	"use strict";
 
 	// create content div
@@ -281,7 +282,7 @@ sap.ui.define([
 	QUnit.test("Model: Refresh with force update", function(assert) {
 		var done = assert.async();
 		var oModel = new Model();
-		var oMessage = new Message({message: "myMessage", type: library.MessageType.Error, processor: oModel});
+		var oMessage = new Message({message: "myMessage", type: MessageType.Error, processor: oModel});
 		oModel.setMessages({"/test": oMessage});
 		oModel.attachMessageChange(function(oEvent){
 			assert.strictEqual(oMessage, oEvent.getParameter("oldMessages")[0]);

package/test/sap/ui/core/qunit/model/Context.qunit.js

@@ -78,4 +78,33 @@ sap.ui.define([
 		// code under test
 		assert.strictEqual(Context.hasChanged(oContext, oContext), false);
 	});
+
+	//*********************************************************************************************
+	QUnit.test("setProperty", function (assert) {
+		const oModel = {setProperty() {}};
+		const oContext = new Context(oModel, "~sContextPath");
+
+		this.mock(oModel).expects("setProperty")
+			.withExactArgs("~sBindingPath", "~vValue", sinon.match.same(oContext), true)
+			.returns(true);
+
+		// code under test
+		oContext.setProperty("~sBindingPath", "~vValue");
+	});
+
+	//*********************************************************************************************
+	QUnit.test("setProperty: value cannot be set by model", function (assert) {
+		const oModel = {setProperty() {}};
+		const oContext = new Context(oModel, "~sContextPath");
+
+		this.mock(oModel).expects("setProperty")
+			.withExactArgs("~sBindingPath", "~vValue", sinon.match.same(oContext), true)
+			.returns(false);
+
+		assert.throws(function () {
+			// code under test
+			oContext.setProperty("~sBindingPath", "~vValue");
+		 }, new Error("Cannot set the value ~vValue for the property ~sBindingPath as the context path ~sContextPath"
+				+ " does not refer to an entry in the model data."));
+	});
 });