@openui5/sap.ui.core 1.121.1 → 1.122.0

package/test/sap/ui/core/demokit/tutorial/odatav4/02/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/03/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/04/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/05/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/06/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/07/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/08/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/09/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/10/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/11/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/troubleshooting/01/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.122.0" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.ui.layout

package/test/sap/ui/core/qunit/CompositeBinding.qunit.js

@@ -391,6 +391,73 @@ sap.ui.define([
 		CompositeBinding.prototype.setType.call(oCompositeBinding, oType, "~internalType");
 	});
 
+	QUnit.test("CompositeBinding: setType, register binding parts for type changes", function(assert) {
+		const oPart0 = {getType() {}, registerTypeChanged() {}};
+		const oPart1 = {getType() {}, registerTypeChanged() {}};
+		const oPart2 = {getType() {}, registerTypeChanged() {}};
+		const oCompositeBinding = {aBindings : [oPart0, oPart1, oPart2]};
+		const oCompositeType = new CompositeType();
+		const oCompositeTypeMock = this.mock(oCompositeType);
+		const oPart0Mock = this.mock(oPart0);
+		const oPart1Mock = this.mock(oPart1);
+		const oPart2Mock = this.mock(oPart2);
+		const oPropertyBindingMock = this.mock(PropertyBinding.prototype);
+
+		oPropertyBindingMock.expects("setType").withExactArgs(oCompositeType, "~internalType").callThrough();
+		oCompositeTypeMock.expects("getPartsIgnoringMessages").withExactArgs().returns([]);
+		oCompositeTypeMock.expects("getUseRawValues").withExactArgs();
+		oCompositeTypeMock.expects("getUseInternalValues").withExactArgs();
+		oPart0Mock.expects("getType").withExactArgs().returns("~type0");
+		oPart1Mock.expects("getType").withExactArgs().returns("~type1");
+		oPart2Mock.expects("getType").withExactArgs().returns("~type2");
+		oCompositeTypeMock.expects("processPartTypes").withExactArgs(["~type0", "~type1", "~type2"]);
+		oPart0Mock.expects("registerTypeChanged").never();
+		oPart1Mock.expects("registerTypeChanged").never();
+		oPart2Mock.expects("registerTypeChanged").never();
+		oCompositeTypeMock.expects("getPartsListeningToTypeChanges").withExactArgs().returns([]);
+
+		// code under test (no relevant type)
+		CompositeBinding.prototype.setType.call(oCompositeBinding, oCompositeType, "~internalType");
+
+		oPropertyBindingMock.expects("setType").withExactArgs(oCompositeType, "~internalType").callThrough();
+		oCompositeTypeMock.expects("getPartsIgnoringMessages").withExactArgs().returns([]);
+		oCompositeTypeMock.expects("getUseRawValues").withExactArgs();
+		oCompositeTypeMock.expects("getUseInternalValues").withExactArgs();
+		oPart0Mock.expects("getType").withExactArgs().returns("~type0");
+		oPart1Mock.expects("getType").withExactArgs().returns("~type1");
+		oPart2Mock.expects("getType").withExactArgs().returns("~type2");
+		oCompositeTypeMock.expects("processPartTypes").withExactArgs(["~type0", "~type1", "~type2"]);
+		oCompositeTypeMock.expects("getPartsListeningToTypeChanges").withExactArgs().returns([0,2]);
+		const oExpectation0 = oPart0Mock.expects("registerTypeChanged").withExactArgs(sinon.match.func);
+		oPart1Mock.expects("registerTypeChanged").never();
+		const oExpectation2 = oPart2Mock.expects("registerTypeChanged").withExactArgs(sinon.match.func);
+
+		// code under test (relevant types for binding part 0 and 2)
+		CompositeBinding.prototype.setType.call(oCompositeBinding, oCompositeType, "~internalType");
+
+		oPart0Mock.expects("getType").withExactArgs().returns("~type0");
+		oPart1Mock.expects("getType").withExactArgs().returns("~type1");
+		oPart2Mock.expects("getType").withExactArgs().returns("~type2");
+		oCompositeTypeMock.expects("processPartTypes").withExactArgs(["~type0", "~type1", "~type2"]);
+
+		// code under test (callback triggered via binding part0 type change)
+		oExpectation0.firstCall.args[0]();
+
+		oPart0Mock.expects("getType").withExactArgs().returns("~type0");
+		oPart1Mock.expects("getType").withExactArgs().returns("~type1");
+		oPart2Mock.expects("getType").withExactArgs().returns("~type2");
+		oCompositeTypeMock.expects("processPartTypes").withExactArgs(["~type0", "~type1", "~type2"]);
+
+		// code under test (callback triggered via binding part2 type change)
+		oExpectation2.firstCall.args[0]();
+
+		oPropertyBindingMock.expects("setType").withExactArgs(null, "~internalType").callThrough();
+		CompositeBinding.prototype.setType.call(oCompositeBinding, null, "~internalType");
+
+		// code under test (change part2 inner type after composite type was reset)
+		oExpectation2.firstCall.args[0]();
+	});
+
 	QUnit.module("sap.ui.model.CompositeBinding: With inner types/formatters", {
 		before() {
 			this.__ignoreIsolatedCoverage__ = true;

package/test/sap/ui/core/qunit/EventProvider.qunit.js

@@ -1,7 +1,8 @@
-/*global QUnit */
+/*global QUnit sinon */
 sap.ui.define([
+	"sap/base/Log",
 	"sap/ui/base/EventProvider"
-], function(EventProvider) {
+], function(Log, EventProvider) {
 	"use strict";
 
 	QUnit.test("InitialObject", function(assert) {
@@ -381,4 +382,31 @@ sap.ui.define([
 		assert.equal(iCount, 3, "Handler is called three times");
 	});
 
+	QUnit.test("FireEvent with Async Listener", async (assert) => {
+		const oEventProvider = new EventProvider();
+		const aPromises = [];
+
+		const myPromiseFunction = () => {
+			const oPromise = Promise.reject(new Error("Function failed."));
+			aPromises.push(oPromise);
+			return oPromise;
+		};
+		const myAsyncFunction = async () => {
+			const oPromise = Promise.reject(new Error("Async function failed."));
+			aPromises.push(oPromise);
+			await oPromise;
+		};
+
+		const myLogSpy = sinon.spy(Log, "error");
+		oEventProvider.attachEvent("MyEvent1", myPromiseFunction);
+		oEventProvider.attachEvent("MyEvent2", myAsyncFunction);
+		oEventProvider.fireEvent("MyEvent1");
+		oEventProvider.fireEvent("MyEvent2");
+
+		await Promise.allSettled(aPromises).then(() => {
+			assert.equal(myLogSpy.callCount, 2, "Error log should be displayed");
+			assert.ok(myLogSpy.getCall(0).calledWith("EventProvider.fireEvent: Event Listener for event 'MyEvent1' failed during execution."), "Correct Error Log displayed.");
+			assert.ok(myLogSpy.getCall(1).calledWith("EventProvider.fireEvent: Event Listener for event 'MyEvent2' failed during execution."), "Correct Error Log displayed.");
+		});
+	});
 });

package/test/sap/ui/core/qunit/{Core_libraryPreloadFiles.qunit.html → Lib_preloadFiles.qunit.html}

@@ -10,7 +10,7 @@
 
 	<script src="../../../../../resources/sap/ui/test/starter/runTest.js"
 		data-sap-ui-testsuite="test-resources/sap/ui/core/qunit/testsuite.core.framework.qunit"
-		data-sap-ui-test="Core_libraryPreloadFiles"></script>
+		data-sap-ui-test="Lib_preloadFiles"></script>
 </head>
 
 <body>

package/test/sap/ui/core/qunit/{Core_libraryPreloadFiles.qunit.js → Lib_preloadFiles.qunit.js}

@@ -37,8 +37,8 @@ sap.ui.define([
 	 *   lib5 (js)
 	 */
 	var EXPECTATIONS = {
-		'none':	[ 'none', 'none', 'none', 'none', 'none' ],
-		'js':   [ 'js', 'jserror', 'js', 'none', 'js' ]
+		'none':	[ 'none', 'none', 'none' ],
+		'js':   [ 'js', 'jserror', 'js' ]
 	};
 
 	var match = /(?:[?&])sap-ui-xx-libraryPreloadFiles=([^&]*)(?:&|$)/.exec(window.location.search);
@@ -69,12 +69,10 @@ sap.ui.define([
 		// Main question: log early (place where an error is detected first) or log late (where the most significant context can be given)
 		this.spy(privateLoaderAPI.logger, 'error');
 
-		var vResult = sap.ui.getCore().loadLibraries([
+		var vResult = Library._load([
 			'testlibs.scenario7.lib1', // both, not configured
 			'testlibs.scenario7.lib2', // json, not configured
-			'testlibs.scenario7.lib3', // js, not configured
-			{ name: 'testlibs.scenario7.lib4', json: true }, // json, configured
-			{ name: 'testlibs.scenario7.lib5', json: false } // js, configured
+			'testlibs.scenario7.lib3'  // js, not configured
 		]);
 
 		return vResult.then(function() {
@@ -89,7 +87,7 @@ sap.ui.define([
 					return sinon.match(new RegExp("scenario7\\/" + lib + "\\/library" + suffix));
 				}
 				var matcherLibPreloadJS = matcher("-preload\\.js$");
-				var matcherLibPreloadJSON = matcher("-preload\\.json$");
+
 				var matcherLibraryModule = "testlibs/scenario7/" + lib + "/library";
 				var matcherLibraryResource = matcher("\\.js$");
 
@@ -97,16 +95,13 @@ sap.ui.define([
 
 				if ( expected === 'none' ) {
 					assert.ok(privateLoaderAPI.loadJSResourceAsync.neverCalledWith(matcherLibPreloadJS), "library-preload.js should not have been requested for '" + lib + "'");
-					assert.ok(XMLHttpRequest.prototype.open.neverCalledWith("GET", matcherLibPreloadJSON), "library-preload.json should not have been requested for '" + lib + "'");
 					assert.ok(sap.ui.require.load.calledWith(sinon.match.any, matcherLibraryResource, matcherLibraryModule), "library.js should have been loaded for '" + lib + "'");
 				} else if ( expected === 'js' ) {
 					assert.ok(privateLoaderAPI.loadJSResourceAsync.calledWith(matcherLibPreloadJS), "library-preload.js should have been loaded for '" + lib + "'");
-					assert.ok(XMLHttpRequest.prototype.open.neverCalledWith("GET", matcherLibPreloadJSON), "library-preload.json should not have been requested for '" + lib + "'");
 					assert.ok(sap.ui.require.load.neverCalledWith(sinon.match.any, matcherLibraryResource, matcherLibraryModule), "library.js should not have been requested for '" + lib + "'");
 				} else if ( expected === 'jserror' ) {
 					assert.ok(privateLoaderAPI.loadJSResourceAsync.calledWith(matcherLibPreloadJS), "library-preload.js should have been requested for '" + lib + "'");
 					assert.ok(privateLoaderAPI.logger.error.calledWith(matcher("-preload\\.js").and(sinon.match(/failed to load/))), "error should have been logged for failing request");
-					assert.ok(XMLHttpRequest.prototype.open.neverCalledWith("GET", matcherLibPreloadJSON), "library-preload.json should not have been loaded for '" + lib + "'");
 					assert.ok(sap.ui.require.load.calledWith(sinon.match.any, matcherLibraryResource, matcherLibraryModule), "library.js should have been loaded for '" + lib + "'");
 				} else {
 					assert.ok(false, "[test code broken] unhandled expectation " + expected);

package/test/sap/ui/core/qunit/ThemeHelper.qunit.js

@@ -17,7 +17,7 @@ sap.ui.define([
 				assert.deepEqual(oMetadata, {
 					"Path": "UI5.sample/path",
 					"PathPattern": "/%UI5%/sample/%pattern%.css",
-					"Extends": ["sap_hcb","base"],
+					"Extends": ["sap_horizon_hcb","base"],
 					"Version": {
 						"Build": "1.0.0",
 						"Source": "1.0.0",

package/test/sap/ui/core/qunit/ThemeParameters.qunit.js

@@ -52,11 +52,11 @@ sap.ui.define([
 
 	function checkLibraryParametersJsonRequestForLib(sLibNumber) {
 		return performance.getEntriesByType("resource").filter(function (oResource) {
-			return oResource.name.endsWith("themeParameters/lib" + sLibNumber + "/themes/sap_hcb/library-parameters.json");
+			return oResource.name.endsWith("themeParameters/lib" + sLibNumber + "/themes/sap_horizon_hcb/library-parameters.json");
 		});
 	}
 	function createLinkElement (sId, bBase) {
-		var sUrl = sap.ui.require.toUrl("test-resources/sap/ui/core/qunit/testdata/libraries/themeParameters/lib17/themes/" + (bBase ? "base" : "sap_hcb") + "/library.css");
+		var sUrl = sap.ui.require.toUrl("test-resources/sap/ui/core/qunit/testdata/libraries/themeParameters/lib17/themes/" + (bBase ? "base" : "sap_horizon_hcb") + "/library.css");
 		return includeStylesheet({
 			url: sUrl,
 			id: bBase ? sId : undefined
@@ -283,7 +283,7 @@ sap.ui.define([
 		};
 
 		var fnApplied = async function (oEvent) {
-			if (oEvent.theme === "sap_hcb") {
+			if (oEvent.theme === "sap_horizon_hcb") {
 				Theming.detachApplied(fnApplied);
 
 				await Library.load({name: "testlibs.themeParameters.lib14"});
@@ -295,7 +295,7 @@ sap.ui.define([
 						assert.equal(getParameterInUnifiedHexNotation("sapUiThemeParamForLib13"), "#efefef", "sapUiThemeParamForLib13 must be defined as '#efefef' for theme 'base'");
 
 						Theming.attachApplied(fnContinue);
-						Theming.setTheme("sap_hcb");
+						Theming.setTheme("sap_horizon_hcb");
 					}
 				});
 				assert.equal(getParameterInUnifiedHexNotation("sapUiThemeParamForLib13"), "#fefefe", "sapUiThemeParamForLib13 must be defined as '#fefefe' for theme 'hcb'");

package/test/sap/ui/core/qunit/ThemeParameters_legacyAPIs.qunit.js

@@ -66,11 +66,11 @@ sap.ui.define([
 
 	function checkLibraryParametersJsonRequestForLib(sLibNumber) {
 		return performance.getEntriesByType("resource").filter(function (oResource) {
-			return oResource.name.endsWith("themeParameters/lib" + sLibNumber + "/themes/sap_hcb/library-parameters.json");
+			return oResource.name.endsWith("themeParameters/lib" + sLibNumber + "/themes/sap_horizon_hcb/library-parameters.json");
 		});
 	}
 	function createLinkElement (sId, bBase) {
-		var sUrl = sap.ui.require.toUrl("test-resources/sap/ui/core/qunit/testdata/libraries/themeParameters/lib17/themes/" + (bBase ? "base" : "sap_hcb") + "/library.css");
+		var sUrl = sap.ui.require.toUrl("test-resources/sap/ui/core/qunit/testdata/libraries/themeParameters/lib17/themes/" + (bBase ? "base" : "sap_horizon_hcb") + "/library.css");
 		return includeStylesheet({
 			url: sUrl,
 			id: bBase ? sId : undefined
@@ -177,7 +177,7 @@ sap.ui.define([
 	QUnit.test("After Theme Change", function(assert) {
 		var done = assert.async();
 		var fnContinue = function(oEvent) {
-			if (oEvent.theme === "sap_hcb") {
+			if (oEvent.theme === "sap_horizon_hcb") {
 				Theming.detachApplied(fnContinue);
 				done();
 			}
@@ -190,7 +190,7 @@ sap.ui.define([
 
 				Theming.detachApplied(fnAssertApplied);
 				Theming.attachApplied(fnContinue);
-				Theming.setTheme("sap_hcb");
+				Theming.setTheme("sap_horizon_hcb");
 			}
 		};
 
@@ -344,9 +344,9 @@ sap.ui.define([
 				url1: sPath + "/testdata/libraries/themeParameters/lib4/img1.jpg",
 				url2: sPath + "/testdata/libraries/themeParameters/lib4/foo/img2.jpg",
 				url3: sPath + "/testdata/libraries/themeParameters/lib4/foo/bar/img3.jpg",
-				url4: sPath + "/testdata/libraries/themeParameters/lib4/themes/sap_hcb/",
-				url5: sPath + "/testdata/libraries/themeParameters/lib4/themes/sap_hcb/",
-				url6: sPath + "/testdata/libraries/themeParameters/lib4/themes/sap_hcb/",
+				url4: sPath + "/testdata/libraries/themeParameters/lib4/themes/sap_horizon_hcb/",
+				url5: sPath + "/testdata/libraries/themeParameters/lib4/themes/sap_horizon_hcb/",
+				url6: sPath + "/testdata/libraries/themeParameters/lib4/themes/sap_horizon_hcb/",
 				url7: "blob:http://example.com/6e88648c-00e1-4512-9695-5b702d8455b4",
 				url8: "data:text/plain;utf-8,foo",
 				url9: {
@@ -360,9 +360,9 @@ sap.ui.define([
 			assert.equal(Parameters.get("sapUiThemeParamUrl1"), "url('" + expected.url1 + "')", "Relative URL should be resolved correctly 'sap/ui/core/qunit/testdata/libraries/themeParameters/lib4/img1.jpg'.");
 			assert.equal(Parameters.get("sapUiThemeParamUrl2"), "url('" + expected.url2 + "')", "Relative URL should be resolved correctly 'sap/ui/core/qunit/testdata/libraries/themeParameters/lib4/foo/img2.jpg'.");
 			assert.equal(Parameters.get("sapUiThemeParamUrl3"), "url('" + expected.url3 + "')", "Relative URL should be resolved correctly 'sap/ui/core/qunit/testdata/libraries/themeParameters/lib4/foo/bar/img3.jpg'.");
-			assert.equal(Parameters.get("sapUiThemeParamUrl4"), "url('" + expected.url4 + "')", "Relative URL should be resolved correctly 'sap/ui/core/qunit/testdata/libraries/themeParameters/lib4/themes/sap_hcb/'.");
-			assert.equal(Parameters.get("sapUiThemeParamUrl5"), "url('" + expected.url5 + "')", "Relative URL should be resolved correctly 'sap/ui/core/qunit/testdata/libraries/themeParameters/lib4/themes/sap_hcb/'.");
-			assert.equal(Parameters.get("sapUiThemeParamUrl6"), "url('" + expected.url6 + "')", "Relative URL should be resolved correctly 'sap/ui/core/qunit/testdata/libraries/themeParameters/lib4/themes/sap_hcb/'.");
+			assert.equal(Parameters.get("sapUiThemeParamUrl4"), "url('" + expected.url4 + "')", "Relative URL should be resolved correctly 'sap/ui/core/qunit/testdata/libraries/themeParameters/lib4/themes/sap_horizon_hcb/'.");
+			assert.equal(Parameters.get("sapUiThemeParamUrl5"), "url('" + expected.url5 + "')", "Relative URL should be resolved correctly 'sap/ui/core/qunit/testdata/libraries/themeParameters/lib4/themes/sap_horizon_hcb/'.");
+			assert.equal(Parameters.get("sapUiThemeParamUrl6"), "url('" + expected.url6 + "')", "Relative URL should be resolved correctly 'sap/ui/core/qunit/testdata/libraries/themeParameters/lib4/themes/sap_horizon_hcb/'.");
 			assert.equal(Parameters.get("sapUiThemeParamUrl7"), "url('" + expected.url7 + "')", "Relative URL should be resolved correctly 'blob:http://example.com/6e88648c-00e1-4512-9695-5b702d8455b4'.");
 			assert.equal(Parameters.get("sapUiThemeParamUrl8"), "url('" + expected.url8 + "')", "Relative URL should be resolved correctly 'data:text/plain;utf-8,foo'.");
 			assert.equal(Parameters.get("sapUiThemeParamUrl9"), expected.url9.plain, "'none' should stay as defined");
@@ -640,7 +640,7 @@ sap.ui.define([
 		};
 
 		var fnApplied = function (oEvent) {
-			if (oEvent.theme === "sap_hcb") {
+			if (oEvent.theme === "sap_horizon_hcb") {
 				Theming.detachApplied(fnApplied);
 
 				sap.ui.getCore().loadLibraries(["testlibs.themeParameters.lib14"]).then(function () {
@@ -651,7 +651,7 @@ sap.ui.define([
 							assert.equal(getParameterInUnifiedHexNotation("sapUiThemeParamForLib13"), "#efefef", "sapUiThemeParamForLib13 must be defined as '#efefef' for theme 'base'");
 
 							Theming.attachApplied(fnContinue);
-							Theming.setTheme("sap_hcb");
+							Theming.setTheme("sap_horizon_hcb");
 						}
 					});
 					assert.equal(getParameterInUnifiedHexNotation("sapUiThemeParamForLib13"), "#fefefe", "sapUiThemeParamForLib13 must be defined as '#fefefe' for theme 'hcb'");