@openui5/sap.ui.core 1.121.1 → 1.121.2

package/test/sap/ui/core/demokit/tutorial/navigation/13/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.ui.core

package/test/sap/ui/core/demokit/tutorial/navigation/14/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.ui.core

package/test/sap/ui/core/demokit/tutorial/navigation/15/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.ui.core

package/test/sap/ui/core/demokit/tutorial/navigation/16/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.ui.core

package/test/sap/ui/core/demokit/tutorial/navigation/17/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.ui.core

package/test/sap/ui/core/demokit/tutorial/odatav4/01/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/02/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/03/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/04/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/05/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/06/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/07/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/08/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/09/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/10/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/odatav4/11/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.f

package/test/sap/ui/core/demokit/tutorial/troubleshooting/01/ui5.yaml

@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
   name: OpenUI5
-  version: "1.121.1" #MainVersion#
+  version: "1.121.2" #MainVersion#
   libraries:
     - name: sap.m
     - name: sap.ui.layout

package/test/sap/ui/core/qunit/odata/v4/ODataModel.integration.qunit.js

@@ -2667,6 +2667,59 @@ sap.ui.define([
 		});
 	});
 
+	//*********************************************************************************************
+	// Scenario: PATCH an entity with a key predicate consisting of a single key property of type
+	// Edm.DateTimeOffset. The PATCH failed and a UI5 message is created.
+	// SNOW: CS20240007200281
+	QUnit.test("CS20240007200281: key property is Edm.DateTimeOffset", async function (assert) {
+		const oModel = this.createSpecialCasesModel({autoExpandSelect : true});
+		const sView = `
+<Table id="table" items="{/Artists(ArtistID='42',IsActiveEntity=true)/_Event}">
+	<Input id="name" value="{Name}"/>
+</Table>`;
+
+		this.expectRequest("Artists(ArtistID='42',IsActiveEntity=true)/_Event"
+				+ "?$select=Name,TimeStamp&$skip=0&$top=100", {
+				value : [
+					{Name : "Taubertal Festival", TimeStamp : "08-08-2024T01:02:03Z"}
+				]
+			})
+			.expectChange("name", ["Taubertal Festival"]);
+
+		await this.createView(assert, sView, oModel);
+		const aTableRows = this.oView.byId("table").getItems();
+
+		this.expectChange("name", ["Woodstock"])
+			.expectRequest({
+				method : "PATCH",
+				url : "Artists(ArtistID='42',IsActiveEntity=true)"
+					+ "/_Event(08-08-2024T01%3A02%3A03Z)",
+				payload : {Name : "Woodstock"}
+			}, createErrorInsideBatch({target : "Name"}))
+			.expectMessages([{
+				code : "CODE",
+				message : "Request intentionally failed",
+				persistent : true,
+				target : "/Artists(ArtistID='42',IsActiveEntity=true)"
+					+ "/_Event(08-08-2024T01%3A02%3A03Z)/Name",
+				technical : true,
+				type : "Error"
+			}]);
+
+		this.oLogMock.expects("error")
+			.withArgs("Failed to update path /Artists(ArtistID='42',IsActiveEntity=true)"
+				+ "/_Event(08-08-2024T01%3A02%3A03Z)/Name");
+
+		const oInput = aTableRows[0].getCells()[0];
+		// code under test
+		oInput.getBinding("value").setValue("Woodstock");
+
+		await this.waitForChanges(assert);
+
+		await this.checkValueState(assert, oInput, "Error",
+			"Request intentionally failed");
+	});
+
 	//*********************************************************************************************
 	// Scenario: Minimal test for an absolute ODataPropertyBinding. This scenario is comparable with
 	// "FavoriteProduct" in the SalesOrders application.
@@ -15188,6 +15241,79 @@ sap.ui.define([
 			]);
 		});
 	});
+
+	//*********************************************************************************************
+	// Scenario: We simulate parts of a file upload here. Initially, the Edm.Stream property is
+	// missing from the response (of course) and a late property request is sent leading to
+	// "Picture@$ui5.noData : true" being set. File upload happens outside the model and only a file
+	// name would be PATCHed, this is omitted here. Removal of the file requires the model to PATCH
+	// a null value, which ruins the URL. Thus the property is reset to undefined on the client side
+	// only. This must not prevent a side effect from setting "Picture@$ui5.noData : true" again!
+	// Thus upload and removal can be repeated (endlessly) while a URL is implicitly available for
+	// up- and download at all times.
+	// SNOW: DINC0088146
+	QUnit.test("DINC0088146", async function (assert) {
+		const oModel = this.createSpecialCasesModel({autoExpandSelect : true});
+		const sView = `
+<Table id="list" items="{/Artists}">
+	<Text id="id" text="{ArtistID}"/>
+</Table>
+<FlexBox id="detail">
+	<Text id="link" text="{Picture}"/>
+</FlexBox>`;
+		const sLink = "/special/cases/Artists(ArtistID='42',IsActiveEntity=true)/Picture";
+
+		this.expectRequest("Artists?$select=ArtistID,IsActiveEntity&$skip=0&$top=100", {
+				value : [{
+					ArtistID : "42",
+					IsActiveEntity : true
+				}]
+			})
+			.expectChange("link");
+
+		await this.createView(assert, sView, oModel);
+
+		this.expectRequest("Artists(ArtistID='42',IsActiveEntity=true)?$select=Picture", {
+				ArtistID : "42",
+				// Picture (Edm.Stream) missing here
+				"Picture@odata.mediaContentType" : null
+			})
+			.expectChange("link", sLink);
+
+		const oContext = this.oView.byId("list").getItems()[0].getBindingContext();
+		this.oView.byId("detail").setBindingContext(oContext);
+
+		await this.waitForChanges(assert, "detail");
+
+		for (let i = 0; i < 3; i += 1) {
+			this.expectChange("link", null)
+				.expectChange("link", sLink)
+				.expectRequest({
+					method : "PATCH",
+					url : "Artists(ArtistID='42',IsActiveEntity=true)",
+					payload : {Picture : null}
+				})
+				.expectRequest("Artists?$select=ArtistID,IsActiveEntity,Picture"
+					+ "&$filter=ArtistID eq '42' and IsActiveEntity eq true", {
+					value : [{
+						ArtistID : "42",
+						IsActiveEntity : true,
+						// Picture (Edm.Stream) missing here
+						"Picture@odata.mediaContentType" : null
+					}]
+				})
+				.expectChange("link", sLink); // due to "Picture@$ui5.noData : true" being set
+
+			// eslint-disable-next-line no-await-in-loop
+			await Promise.all([
+				oContext.setProperty("Picture", null),
+				oContext.requestSideEffects(["Picture"]),
+				oContext.setProperty("Picture", undefined, /*sGroupId*/null),
+				this.waitForChanges(assert, "remove #" + i)
+			]);
+		}
+	});
+
 	//*********************************************************************************************
 	// Scenario: Writing instance annotations via create and update.
 	// 1. POST: Initial payload containing instance annotations

package/test/sap/ui/core/qunit/odata/v4/data/metadata_special_cases.xml

@@ -26,6 +26,14 @@
 				<NavigationProperty Name="_Publication" Type="Collection(special.cases.PublicationsType)" Partner="_Artist"/>
 				<NavigationProperty Name="BestFriend" Type="special.cases.ArtistsType" />
 				<NavigationProperty Name="_Friend" Type="Collection(special.cases.ArtistsType)" />
+				<NavigationProperty Name="_Event" Type="Collection(special.cases.EventsType)" />
+			</EntityType>
+			<EntityType Name="EventsType">
+				<Key>
+					<PropertyRef Name="TimeStamp"/>
+				</Key>
+				<Property Name="TimeStamp" Type="Edm.DateTimeOffset" Nullable="false"/>
+				<Property Name="Name" Type="Edm.String"/>
 			</EntityType>
 			<EntityType Name="DraftAdministrativeDataType">
 				<Key>
@@ -185,6 +193,7 @@
 					<NavigationPropertyBinding Path="BestFriend" Target="Artists"/>
 					<NavigationPropertyBinding Path="SiblingEntity" Target="Artists" />
 				</EntitySet>
+				<EntitySet Name="Events" EntityType="special.cases.EventsType"/>
 				<EntitySet Name="As" EntityType="special.cases.A">
 					<NavigationPropertyBinding Path="AtoEntityWithComplexKey"
 						Target="EntitiesWithComplexKey"/>

package/test/sap/ui/core/qunit/odata/v4/lib/_Helper.qunit.js

@@ -1468,12 +1468,16 @@ sap.ui.define([
 	});
 
 	//*********************************************************************************************
-	QUnit.test("updateSelected: private annotations", function (assert) {
+[false, true].forEach((bUndefined) => {
+	QUnit.test("updateSelected: private annotations, undefined: " + bUndefined, function (assert) {
 		var oBinding = {},
 			oContext = {oBinding : oBinding},
 			// oContext is recursive and must not be descended into
 			oOldValue = {"@$ui5._" : {context : oContext}};
 
+		if (bUndefined) {
+			oOldValue.foo = undefined; // MUST NOT make a difference
+		}
 		oBinding.oContext = oContext;
 		this.mock(_Helper).expects("fireChange").withExactArgs("~mChangeListener~", "foo",
 			undefined, true);
@@ -1483,18 +1487,30 @@ sap.ui.define([
 			{"@$ui5._" : {predicate : "(1)"}, bar : {}},
 			["foo", "bar/*"]);
 
-		assert.deepEqual(oOldValue,
-			{"@$ui5._" : {context : oContext, predicate : "(1)"}, bar : {},
-				"foo@$ui5.noData" : true});
+		assert.deepEqual(oOldValue, bUndefined ? {
+			"@$ui5._" : {context : oContext, predicate : "(1)"},
+			bar : {},
+			foo : undefined,
+			"foo@$ui5.noData" : true
+		} : {
+			"@$ui5._" : {context : oContext, predicate : "(1)"},
+			bar : {},
+			"foo@$ui5.noData" : true
+		});
 	});
+});
 
 	//*********************************************************************************************
-	QUnit.test("updateSelected: create annotation", function (assert) {
+[false, true].forEach((bUndefined) => {
+	QUnit.test("updateSelected: create annotation, undefined: " + bUndefined, function (assert) {
 		var oBinding = {},
 			oHelperMock = this.mock(_Helper),
 			oOldValue0 = {},
 			oOldValue1 = {};
 
+		if (bUndefined) {
+			oOldValue0.foo = undefined; // MUST NOT make a difference
+		}
 		oBinding.oContext = {oBinding : oBinding};
 		oHelperMock.expects("fireChange").withExactArgs("~mChangeListener~", "foo", undefined,
 			true);
@@ -1510,20 +1526,24 @@ sap.ui.define([
 		_Helper.updateSelected("~mChangeListener~", "", oOldValue0,
 			{baz : {bar : {}}}, ["foo", "bar", "baz/bar"]);
 
-		assert.deepEqual(oOldValue0, {
-			"foo@$ui5.noData" : true,
+		assert.deepEqual(oOldValue0, bUndefined ? {
 			"bar@$ui5.noData" : true,
-			baz : {bar : {}}
+			baz : {bar : {}},
+			foo : undefined,
+			"foo@$ui5.noData" : true
+		} : {
+			"bar@$ui5.noData" : true,
+			baz : {bar : {}},
+			"foo@$ui5.noData" : true
 		});
 
 		// code under test (do not create annotation)
 		_Helper.updateSelected("~mChangeListener~", "", oOldValue1,
 			{baz : {bar : {}}}, ["foo", "bar", "baz/bar"], undefined, /*bOkIfMissing*/ true);
 
-		assert.deepEqual(oOldValue1, {
-			baz : {bar : {}}
-		});
+		assert.deepEqual(oOldValue1, {baz : {bar : {}}});
 	});
+});
 
 	//*********************************************************************************************
 	QUnit.test("updateSelected: $postBodyCollection", function (assert) {

package/test/sap/ui/core/qunit/odata/v4/lib/_Parser.qunit.js

@@ -382,6 +382,11 @@ sap.ui.define([
 			string : "$filter=foo eq %2b1e%2B10",
 			parsed : {$filter : "foo eq %2b1e%2B10"},
 			converted : {$filter : "foo eq %2b1e%2B10"}
+		}, {
+			//       "$filter=foo eq 2016-01-13T14:08:31Z"
+			string : "$filter=foo eq 2016-01-13T14%3a08%3A31Z",
+			parsed : {$filter : "foo eq 2016-01-13T14%3a08%3A31Z"},
+			converted : {$filter : "foo eq 2016-01-13T14%3a08%3A31Z"}
 		}, {
 			//       "$filter=foo eq  ' a '  '  ' "
 			string : "$filter=foo eq %27a%27%27%27",
@@ -838,8 +843,9 @@ sap.ui.define([
 	//*********************************************************************************************
 	QUnit.test("parseKeyPredicate", function (assert) {
 		[
-			"false", "true", "3.14", "2016-04-23", "2016-01-13T14:08:31Z", "-1", "'foo'",
-			"'foo''bar'", "'foo/bar'", "F050568D-393C-1ED4-9D97-E65F0F3FCC23"
+			"false", "true", "3.14", "2016-04-23", "2016-01-13T14:08:31Z",
+			"2016-01-13T14%3a08%3A31Z", "-1", "'foo'", "'foo''bar'", "'foo/bar'",
+			"F050568D-393C-1ED4-9D97-E65F0F3FCC23"
 		].forEach(function (sValue) {
 			var sPredicate = "(" + sValue + ")";
 

package/test/sap/ui/core/qunit/odata/v4/lib/_Requestor.qunit.js

@@ -1427,19 +1427,29 @@ sap.ui.define([
 	});
 
 	//*********************************************************************************************
+[false, true].forEach(function (bWithCredentials) {
 	[false, true].forEach(function (bSuccess) {
-		QUnit.test("refreshSecurityToken: success = " + bSuccess, function (assert) {
+		const sTitle = "refreshSecurityToken, success=" + bSuccess + ", withCredentials="
+			+ bWithCredentials;
+		QUnit.test(sTitle, function (assert) {
 			var oError = {},
 				oPromise,
 				mHeaders = {},
-				mRequestHeaders = {},
+				oAjaxSettings = {
+					headers : "~requestHeaders~",
+					method : "HEAD"
+				},
 				oRequestor = _Requestor.create("/Service/", oModelInterface, mHeaders,
-					{"sap-client" : "123"}),
+					{"sap-client" : "123"}, /*sODataVersion*/undefined, bWithCredentials),
 				oTokenRequiredResponse = {};
 
+			if (bWithCredentials) {
+				oAjaxSettings.xhrFields = {withCredentials : true};
+			}
+
 			this.mock(Object).expects("assign").twice()
 				.withExactArgs({}, sinon.match.same(mHeaders), {"X-CSRF-Token" : "Fetch"})
-				.returns(mRequestHeaders);
+				.returns("~requestHeaders~");
 			this.mock(_Helper).expects("createError")
 				.exactly(bSuccess ? 0 : 2)
 				.withExactArgs(sinon.match.same(oTokenRequiredResponse),
@@ -1447,10 +1457,7 @@ sap.ui.define([
 				.returns(oError);
 
 			this.mock(jQuery).expects("ajax").twice()
-				.withExactArgs("/Service/?sap-client=123", sinon.match({
-					headers : sinon.match.same(mRequestHeaders),
-					method : "HEAD"
-				}))
+				.withExactArgs("/Service/?sap-client=123", oAjaxSettings)
 				.callsFake(function () {
 					var jqXHR;
 
@@ -1503,6 +1510,7 @@ sap.ui.define([
 			});
 		});
 	});
+});
 
 	//*********************************************************************************************
 	QUnit.test("refreshSecurityToken: keep fetching even if none is sent", function (assert) {
@@ -4424,28 +4432,35 @@ sap.ui.define([
 	});
 
 	//*****************************************************************************************
-	QUnit.test("setSessionContext: successful ping", function (assert) {
-		var oExpectation,
-			oRequestor = _Requestor.create(sServiceUrl, oModelInterface, {}, {
-				"sap-client" : "120"
-			});
+[false, true].forEach(function (bWithCredentials) {
+	const sTitle = "setSessionContext: successful ping, bWithCredentials: " + bWithCredentials;
+	QUnit.test(sTitle, function (assert) {
+		var oAjaxSettings = {
+				headers : {
+					"SAP-ContextId" : "context"
+				},
+				method : "HEAD"
+			},
+			oExpectation,
+			oRequestor = _Requestor.create(sServiceUrl, oModelInterface, {}, {"sap-client" : "120"},
+				/*sODataVersion*/undefined, bWithCredentials);
 
+		if (bWithCredentials) {
+			oAjaxSettings.xhrFields = {withCredentials : true};
+		}
 		oExpectation = this.mock(window).expects("setInterval")
 			.withExactArgs(sinon.match.func, 115000);
 
 		oRequestor.setSessionContext("context", "120");
 
-		this.mock(jQuery).expects("ajax").withExactArgs(sServiceUrl + "?sap-client=120", {
-				headers : sinon.match({
-					"SAP-ContextId" : "context"
-				}),
-				method : "HEAD"
-			})
+		this.mock(jQuery).expects("ajax")
+			.withExactArgs(sServiceUrl + "?sap-client=120", oAjaxSettings)
 			.returns(createMock(assert, undefined, "OK", {}));
 
 		// code under test - call setInterval function
 		oExpectation.callArg(0);
 	});
+});
 
 	//*****************************************************************************************
 	[false, true].forEach(function (bErrorId) {