@openui5/sap.ui.core 1.121.0 → 1.122.0

package/test/sap/ui/core/qunit/types/Types.qunit.js

@@ -2676,4 +2676,69 @@ sap.ui.define([
 		assert.strictEqual(oResult.message, oFixture.sResult);
 	});
 });
+
+	//*********************************************************************************************
+	QUnit.test("Unit: getPartsListeningToTypeChanges", function (assert) {
+		const oUnitType = {bShowNumber: true};
+
+		// code under test
+		assert.deepEqual(UnitType.prototype.getPartsListeningToTypeChanges.call(oUnitType), [0]);
+
+		oUnitType.bShowNumber = false;
+
+		// code under test
+		assert.deepEqual(UnitType.prototype.getPartsListeningToTypeChanges.call(oUnitType), []);
+	});
+
+	//*********************************************************************************************
+[
+	{iScale : undefined},
+	{iScale : -1},
+	{iScale : 0, bUseScale : true},
+	{iScale : 42, bUseScale : true}
+].forEach(({iScale, bUseScale}, i) => {
+	QUnit.test("Unit: _getInstance: consider iScale= " + iScale, function (assert) {
+		const oFormatOptionsByArgs = {foo : "byArgs"};
+		const oFormatOptionsByThis = {bar : "byThis"};
+		const oMetadata = {getClass() {}};
+		const oUnitType = {
+			oFormatOptions : oFormatOptionsByThis,
+			iScale : iScale,
+			createFormatOptions() {},
+			getMetadata : () => oMetadata
+		};
+
+		this.mock(oUnitType).expects("createFormatOptions").withExactArgs("~aArgs").returns(oFormatOptionsByArgs);
+		this.mock(oMetadata).expects("getClass")
+			.withExactArgs()
+			.returns(i % 2 ? UnitType : "~NotUnitType"); // alternate between UnitType and other class
+		this.mock(NumberFormat).expects("getUnitInstance")
+			.withExactArgs(bUseScale
+				? {foo : "byArgs", bar : "byThis", maxFractionDigits : iScale}
+				: {foo : "byArgs", bar : "byThis"})
+			.returns("~UnitInstance");
+
+		// code under test
+		assert.strictEqual(UnitType.prototype._getInstance.call(oUnitType, "~aArgs"), "~UnitInstance");
+	});
+});
+
+
+	//*********************************************************************************************
+[
+	{aTypes : []},
+	{aTypes : [{}]},
+	{aTypes : [{oConstraints : {}}]},
+	{aTypes : [{oConstraints : {scale : 24}}], iScale : 24},
+	{aTypes : [{oConstraints : {scale : 24}}, {oConstraints : {scale : 42}}], iScale : 24}
+].forEach(({aTypes, iScale}, i) => {
+	QUnit.test("Unit: processPartTypes, i=" + i, function (assert) {
+		const oUnitType = {};
+
+		// code under test
+		UnitType.prototype.processPartTypes.call(oUnitType, aTypes);
+
+		assert.strictEqual(oUnitType.iScale, iScale);
+	});
+});
 });

package/test/sap/ui/core/qunit/types/testsuite.types.qunit.js

@@ -63,9 +63,6 @@ sap.ui.define(function () {
 				coverage : {
 					only : "sap/ui/core/format/NumberFormat"
 				},
-				qunit: {
-					reorder: false
-				},
 				title: "QUnit Page for sap/ui/core/format/NumberFormat"
 			},
 			NumberFormatCurrencies: {

package/test/sap/ui/core/qunit/ui5classes/ManagedObject.qunit.js

@@ -16,8 +16,10 @@ sap.ui.define([
 	"sap/ui/base/ManagedObjectMetadata",
 	"sap/base/strings/escapeRegExp",
 	"sap/base/util/isEmptyObject",
-	"sap/base/util/ObjectPath"
-], function(BindingInfo, BindingParser, DataType, ManagedObject, Element, JSONModel, Context, ManagedObjectModel, StringType, Control, Component, UIComponent, Sorter, ManagedObjectMetadata, escapeRegExp, isEmptyObject, ObjectPath) {
+	"sap/base/util/ObjectPath",
+	"sap/base/future",
+	"sap/base/Log"
+], function(BindingInfo, BindingParser, DataType, ManagedObject, Element, JSONModel, Context, ManagedObjectModel, StringType, Control, Component, UIComponent, Sorter, ManagedObjectMetadata, escapeRegExp, isEmptyObject, ObjectPath, future, Log) {
 	"use strict";
 	var mObjects = {};
 
@@ -617,6 +619,28 @@ sap.ui.define([
 		oModel.setProperty("/value", "testvalue");
 	});
 
+	QUnit.test("Bind property OneWay - isPropertyBeingUpdated", function(assert) {
+		assert.strictEqual(this.obj.isPropertyBeingUpdated("value"), false, "'isPropertyBeingUpdated' returns false before the property is bound");
+		this.obj.bindProperty("value", {
+			path: "/value",
+			mode: "OneWay"
+		});
+
+		assert.strictEqual(this.obj.isPropertyBeingUpdated("value"), false, "'isPropertyBeingUpdated' returns false when there's no change for the bound property");
+
+		assert.equal(this.obj.isBound("value"), true, "isBound must return true for bound properties");
+		assert.equal(this.obj.getProperty("value"), "testvalue", "Property must return model value");
+
+		this.stub(this.obj, "setProperty").callsFake(() => {
+			assert.strictEqual(this.obj.isPropertyBeingUpdated("value"), true, "'isPropertyBeingUpdated' returns true during the property value update");
+		});
+
+		oModel.setProperty("/value", "newvalue");
+		assert.equal(this.obj.setProperty.callCount, 1, "Setter is called");
+		// restore
+		oModel.setProperty("/value", "testvalue");
+	});
+
 	QUnit.test("Bind property TwoWay", function(assert) {
 		this.obj.bindProperty("value", {
 			path: "/value",
@@ -3260,4 +3284,45 @@ sap.ui.define([
 			done();
 		});
 	});
-});
+
+	QUnit.module("init/exit");
+
+	QUnit.test("Ensure that hooks do not return a value", async function(assert) {
+		const oFutureFatalSpy = sinon.spy(Log, "fatal");
+		const aPromises = [];
+
+		const MySampleManagedObject = ManagedObject.extend("sap.ui.core.MySampleManagedObject", {
+			metadata: {
+				properties: {
+					name: { type: "string", defaultValue: "hello" }
+				}
+			},
+			init: function() {
+				return "init() shouldn't return a value.";
+			},
+			exit: async function() {
+				const oPromise = Promise.reject(new Error("exit() failed."));
+				aPromises.push(oPromise);
+				await oPromise;
+			}
+		});
+
+		// init
+		const oMySample = new MySampleManagedObject();
+		assert.ok(oFutureFatalSpy.getCall(0).calledWith("[FUTURE FATAL] The registered Event Listener 'init' must not have a return value."), "init() should be logged correctly.");
+
+		// exit
+		const oErrorLogSpy = sinon.spy(Log, "error");
+		oMySample.destroy();
+
+		await Promise.allSettled(aPromises);
+		assert.ok(oFutureFatalSpy.getCall(1).calledWith("[FUTURE FATAL] The registered Event Listener 'exit' must not have a return value."), "exit() should be logged correctly.");
+
+		await Promise.resolve(() => {
+			assert.ok(oErrorLogSpy.getCall(0).calledWith("The registered Event Listener 'exit' of '__object0' failed."), "Promise rejection caught successfully.");
+
+			oFutureFatalSpy.restore();
+			oErrorLogSpy.restore();
+		});
+	});
+});