@openui5/sap.ui.core 1.120.1 → 1.120.2

package/test/sap/ui/core/qunit/ui5classes/ManagedObjectRegistry.qunit.js

@@ -0,0 +1,161 @@
+/* global QUnit, sinon */
+sap.ui.define(["sap/ui/base/ManagedObjectRegistry", "sap/ui/base/ManagedObject"],
+	function (ManagedObjectRegistry, ManagedObject) {
+		"use strict";
+
+		function createInstance(aInstanceId, FNClass) {
+			var aInstance = [];
+			var sTimeStamp = Date.now().toString(); // Ensure that ids are unique
+			aInstanceId.forEach(function (sId) {
+				aInstance.push(new FNClass(sId + sTimeStamp));
+			});
+			return aInstance;
+		}
+
+		function destroyInstance(aInstance) {
+			aInstance.forEach(function (oInstance) {
+				oInstance.destroy();
+			});
+		}
+
+		QUnit.module("ManagedObjectRegistry (Happy Path)");
+
+		QUnit.test("Should mixin register/deregister", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			const registry = ManagedObjectRegistry.create();
+			registry.init(Foo);
+
+			assert.ok(Foo.prototype.register, "Has register prototype function");
+			assert.ok(Foo.prototype.deregister, "Has deregister prototype function");
+		});
+
+		QUnit.test("Construction and destruction", function (assert) {
+			var aInstanceId = ["A", "B", "C"];
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			const registry = ManagedObjectRegistry.create();
+			registry.init(Foo);
+
+			var aInstance = createInstance(aInstanceId, Foo);
+			assert.equal(registry.size, 3, "3 instances added");
+			destroyInstance(aInstance);
+			assert.equal(registry.size, 0, "3 instances removed");
+		});
+
+		QUnit.test("Should retrieve added instances as copy", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			const registry = ManagedObjectRegistry.create();
+			registry.init(Foo);
+
+			var oFoo = new Foo("A");
+
+			var mElementsInRegistry = registry.all();
+			assert.equal(Object.keys(mElementsInRegistry).length, 1, "Contains 1 instance in map");
+			assert.equal(Object.getPrototypeOf(mElementsInRegistry), null, "Retrieved object contains no prototype functions");
+
+			oFoo.destroy();
+		});
+
+		QUnit.test("Should retrieve instance by id", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			const registry = ManagedObjectRegistry.create();
+			registry.init(Foo);
+
+			var oFoo1 = new Foo("A");
+			var oFoo2 = new Foo("B");
+
+			assert.ok(registry.get("B"), "Retrieves instance with id B");
+			destroyInstance([oFoo1, oFoo2]);
+		});
+
+		QUnit.test("Should execute callback for all instances", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			const registry = ManagedObjectRegistry.create();
+			registry.init(Foo);
+
+			var aCallbackCallee = [];
+			var oFoo1 = new Foo("A");
+			var oFoo2 = new Foo("B");
+			var oFoo3 = new Foo("C");
+
+			var fnCallback = function(oInstance, sId) {
+				aCallbackCallee.push(oInstance);
+			};
+			var fnCallbackSpy = sinon.spy(fnCallback);
+
+			registry.forEach(fnCallbackSpy);
+			assert.equal(fnCallbackSpy.callCount, 3, "Executed callback 3 times");
+			assert.ok(aCallbackCallee.indexOf(oFoo1) !== -1, "Executed callback for oFoo1");
+			assert.ok(aCallbackCallee.indexOf(oFoo2) !== -1, "Executed callback for oFoo2");
+			assert.ok(aCallbackCallee.indexOf(oFoo3) !== -1, "Executed callback for oFoo3");
+
+			destroyInstance([oFoo1, oFoo2, oFoo3]);
+		});
+
+		QUnit.module("ManagedObjectRegistry (Sad Path)");
+
+		QUnit.test("Should ensure that static registry property is immutable", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			const registry = ManagedObjectRegistry.create();
+			registry.init(Foo);
+
+			assert.throws(function () {
+				registry.mutator = null;
+			}, "Throw on mutation");
+		});
+
+
+		QUnit.test("Should ensure that extended function is subclass of ManagedObject", function (assert) {
+			assert.throws(function () {
+				const registry = ManagedObjectRegistry.create();
+				registry.init(function Foo() { });
+			}, new TypeError("ManagedObjectRegistry mixin can only be applied to subclasses of sap.ui.base.ManagedObject"),
+				"throws because function is not subclass of ManagedObject");
+		});
+
+		QUnit.test("Should throw when object with same id is added", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			const registry = ManagedObjectRegistry.create();
+			registry.init(Foo);
+
+			assert.throws(function () {
+				new Foo("A");
+				new Foo("A");
+			}, new Error("Error: adding object \"object\" with duplicate id 'A'"), "Same ids are not allowed");
+		});
+
+	});

package/test/sap/ui/core/qunit/ui5classes/ManagedObjectRegistry_legacyAPIs.qunit.js

@@ -0,0 +1,150 @@
+/* global QUnit, sinon */
+sap.ui.define(["sap/ui/base/ManagedObjectRegistry", "sap/ui/base/ManagedObject"],
+	function (ManagedObjectRegistry, ManagedObject) {
+		"use strict";
+
+		function createInstance(aInstanceId, FNClass) {
+			var aInstance = [];
+			var sTimeStamp = Date.now().toString(); // Ensure that ids are unique
+			aInstanceId.forEach(function (sId) {
+				aInstance.push(new FNClass(sId + sTimeStamp));
+			});
+			return aInstance;
+		}
+
+		function destroyInstance(aInstance) {
+			aInstance.forEach(function (oInstance) {
+				oInstance.destroy();
+			});
+		}
+
+		QUnit.module("ManagedObjectRegistry (Happy Path)");
+
+		QUnit.test("Should mixin object", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			ManagedObjectRegistry.apply(Foo);
+
+			assert.ok(Foo.prototype.register, "Has register prototype function");
+			assert.ok(Foo.prototype.deregister, "Has deregister prototype function");
+			assert.ok(Foo.hasOwnProperty("registry"), "Extended object has static property \"registry\"");
+		});
+
+		QUnit.test("Construction and destruction", function (assert) {
+			var aInstanceId = ["A", "B", "C"];
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+			ManagedObjectRegistry.apply(Foo);
+
+			var aInstance = createInstance(aInstanceId, Foo);
+			assert.equal(Foo.registry.size, 3, "3 instances added");
+			destroyInstance(aInstance);
+			assert.equal(Foo.registry.size, 0, "3 instances removed");
+		});
+
+		QUnit.test("Should retrieve added instances as copy", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			ManagedObjectRegistry.apply(Foo);
+
+			var oFoo = new Foo("A");
+
+			var mElementsInRegistry = Foo.registry.all();
+			assert.equal(Object.keys(mElementsInRegistry).length, 1, "Contains 1 instance in map");
+			assert.equal(Object.getPrototypeOf(mElementsInRegistry), null, "Retrieved object contains no prototype functions");
+
+			oFoo.destroy();
+		});
+
+		QUnit.test("Should retrieve instance by id", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			ManagedObjectRegistry.apply(Foo);
+
+			var oFoo1 = new Foo("A");
+			var oFoo2 = new Foo("B");
+
+			assert.ok(Foo.registry.get("B"), "Retrieves instance with id B");
+			destroyInstance([oFoo1, oFoo2]);
+		});
+
+		QUnit.test("Should execute callback for all instances", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+
+			ManagedObjectRegistry.apply(Foo);
+			var aCallbackCallee = [];
+			var oFoo1 = new Foo("A");
+			var oFoo2 = new Foo("B");
+			var oFoo3 = new Foo("C");
+
+			var fnCallback = function(oInstance, sId) {
+				aCallbackCallee.push(oInstance);
+			};
+			var fnCallbackSpy = sinon.spy(fnCallback);
+
+			Foo.registry.forEach(fnCallbackSpy);
+			assert.equal(fnCallbackSpy.callCount, 3, "Executed callback 3 times");
+			assert.ok(aCallbackCallee.indexOf(oFoo1) !== -1, "Executed callback for oFoo1");
+			assert.ok(aCallbackCallee.indexOf(oFoo2) !== -1, "Executed callback for oFoo2");
+			assert.ok(aCallbackCallee.indexOf(oFoo3) !== -1, "Executed callback for oFoo3");
+
+			destroyInstance([oFoo1, oFoo2, oFoo3]);
+		});
+
+		QUnit.module("ManagedObjectRegistry (Sad Path)");
+
+		QUnit.test("Should ensure that static registry property is immutable", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+			ManagedObjectRegistry.apply(Foo);
+
+			assert.throws(function () {
+				Foo.registry.mutator = null;
+			}, "Throw on mutation");
+		});
+
+
+		QUnit.test("Should ensure that extended function is subclass of ManagedObject", function (assert) {
+			assert.throws(function () {
+				ManagedObjectRegistry.apply(function Foo() { });
+			}, new TypeError("ManagedObjectRegistry mixin can only be applied to subclasses of sap.ui.base.ManagedObject"),
+				"throws because function is not subclass of ManagedObject");
+		});
+
+		QUnit.test("Should throw when object with same id is added", function (assert) {
+			var Foo = ManagedObject.extend("Foo", {
+				constructor: function () {
+					ManagedObject.apply(this, arguments);
+				}
+			});
+			ManagedObjectRegistry.apply(Foo);
+
+			assert.throws(function () {
+				new Foo("A");
+				new Foo("A");
+			}, new Error("Error: adding object \"object\" with duplicate id 'A'"), "Same ids are not allowed");
+		});
+
+	});

package/test/sap/ui/core/qunit/ui5classes/testsuite.ui5classes.qunit.js

@@ -0,0 +1,84 @@
+sap.ui.define(function() {
+
+	"use strict";
+	return {
+		name: "TestSuite for BaseObject, ManagedObject and their Helpers",
+		defaults: {
+			loader:{
+				paths:{
+					"fixture": "test-resources/sap/ui/core/qunit/ui5classes/fixture/"
+				}
+			},
+			qunit: {
+				version: 2
+			},
+			sinon: {
+				version: 4
+			},
+			module: "./{name}.qunit"
+		},
+		tests: {
+			AlternativeTypes: {
+				title: "QUnit Page for AlternativeTypes",
+				loader: {
+					paths: {
+						"sap/ui/testlib": "test-resources/sap/ui/core/qunit/testdata/uilib/"
+					}
+				},
+				ui5: {
+					libs: "sap.ui.testlib"
+				}
+			},
+			DataType: {
+				coverage : {
+					only : "sap/ui/base/DataType"
+				},
+				title: "QUnit Page for sap/ui/base/DataType"
+			},
+			ManagedObject: {
+				title: "sap.ui.base.ManagedObject"
+			},
+			ManagedObject_BindingParser: {
+				title: "sap.ui.base.ManagedObject (no core boot)",
+				bootCore: false
+			},
+			ManagedObject_forwardAggregation: {
+				title: "sap.ui.base.ManagedObject (forward Aggregation)"
+			},
+			ManagedObject_isPropertyInitial: {
+				title: "sap.ui.base.ManagedObject (is Property Initial)"
+			},
+			ManagedObjectObserver: {
+				title: "sap.ui.base.ManagedObjectObserver"
+			},
+			ManagedObjectRegistry: {
+				title: "sap.ui.base.ManagedObjectRegistry"
+			},
+			ManagedObjectRegistry_legacyAPIs: {
+				title: "sap.ui.base.ManagedObjectRegistry_legacyAPIs"
+			},
+			ManagedObjectMetadata: {
+				title: "sap.ui.base.ManagedObjectMetadata",
+				sinon: {
+					version: 1, // bridge does not support nested modules
+					qunitBridge: true
+				}
+			},
+			/**
+			 * @deprecated As of version 1.111 Mostly testing deprecated APIs
+			 */
+			Metadata: {
+				title: "sap.ui.base.Metadata"
+			},
+			Object: {
+				title: "sap.ui.base.Object"
+			},
+			/**
+			 * @deprecated As of version 1.111
+			 */
+			Object_legacyAPIs: {
+				title: "sap.ui.base.Object (legacy APIs)"
+			}
+		}
+	};
+});

package/test/sap/ui/core/qunit/util/ViewSerializer.qunit.js

@@ -6,11 +6,12 @@ sap.ui.define([
 	"sap/m/Image",
 	"sap/m/Label",
 	"sap/ui/core/UIArea",
+	"sap/ui/core/UIAreaRegistry",
 	"sap/ui/core/mvc/XMLView",
 	"sap/ui/core/util/serializer/ViewSerializer",
 	"sap/ui/qunit/utils/createAndAppendDiv"
 ],
-	function (Log, Button, Image, Label, UIArea, XMLView, ViewSerializer, createAndAppendDiv) {
+	function (Log, Button, Image, Label, UIArea, UIAreaRegistry, XMLView, ViewSerializer, createAndAppendDiv) {
 		"use strict";
 
 		createAndAppendDiv(["xmlViewArea", "xmlViewWithoutControllerArea"]);
@@ -68,7 +69,7 @@ sap.ui.define([
 		});
 
 		QUnit.test("Serialize, Re-Instantiate and Check an XML View", function (assert) {
-			var oViewSerializer = new ViewSerializer(UIArea.registry.get("xmlViewArea"), null, "sap.m");
+			var oViewSerializer = new ViewSerializer(UIAreaRegistry.get("xmlViewArea"), null, "sap.m");
 
 			var mXMLViews = oViewSerializer.serializeToXML();
 			var sXMLResult = mXMLViews["serializer.view.TestXml"];
@@ -84,7 +85,7 @@ sap.ui.define([
 		});
 
 		QUnit.test("Serialize, Check if a view that has no controller is still serializable", function (assert) {
-			var oViewSerializer = new ViewSerializer(UIArea.registry.get("xmlViewWithoutControllerArea"), null, "sap.m");
+			var oViewSerializer = new ViewSerializer(UIAreaRegistry.get("xmlViewWithoutControllerArea"), null, "sap.m");
 
 			var mXMLViews = oViewSerializer.serializeToXML();
 			var sResult = mXMLViews["serializer.view.TestViewWithoutController"];

package/test/sap/ui/core/relnotes/changes-1.120.json

@@ -438,5 +438,230 @@
         ]
       }
     ]
+  },
+  "1.120.2": {
+    "date": "December 2023",
+    "notes": [
+      {
+        "id": "fa524006c44e83ff1f045be04a397c2382ebc896",
+        "type": "FIX",
+        "text": " Add 'FUTURE FATAL' Marker for error/warning logs",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "b910288d2ef9b5a568ef6e02dd4f18c3d0c5ec3b",
+        "type": "FIX",
+        "text": " sap.ui.model.odata.v4.lib._CollectionCache#read: avoid endless busy indicator sometimes when scrolling up",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "c776473e21141e6449663689f0ea7744a406bd8c",
+        "type": "FIX",
+        "text": " CLDR: allow user input based on historical variants for month abbreviations",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2380137559"
+          }
+        ]
+      },
+      {
+        "id": "e1d0c83dc46fb8a43896d52dcd1374f0e1a5bdb9",
+        "type": "FIX",
+        "text": " core.Lib: Add debug log statement when registering enums",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "4f27ed11de744b0af2ab5c975441b04781573db9",
+        "type": "FIX",
+        "text": " Introduce sap/ui/core/ElementRegistry/ComponentRegistry/UIAreaRegistry",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "d5c21234e93bf8c49b160260924231a5c74936d4",
+        "type": "FIX",
+        "text": " core/qunit: Deprecate ControlRenderer test",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "66cbd78ca43eec4347f71d2f2f7f4d838ab00d73",
+        "type": "FIX",
+        "text": " core/routing: find parent route from the router of the inheritance parent",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "002075129400009859762023"
+          }
+        ]
+      },
+      {
+        "id": "8dc6069a1c360553ea78afc2590af8af3378e6c2",
+        "type": "FIX",
+        "text": " XMLTemplateProcessor: Reintroduce FUTURE-FATAL log for missing control classes",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "7255d2ac1d4dbbf0211050fbc9033b986da90509",
+        "type": "FIX",
+        "text": " sap.ui.model.FilterProcessor.combineFilters: combine Filter.NONE with other filters",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2380132519"
+          }
+        ]
+      },
+      {
+        "id": "a93abb73f5b5a62a99073d2e40c42c43b72d4962",
+        "type": "FIX",
+        "text": " core/XMLTemplateProcessor: load class of nested view before instance creation",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "a11ff7effe5c7953fb6129dd3cc66078d527a76e",
+        "type": "FIX",
+        "text": " sap.ui.model.odata.ODataMessageParser#_createTarget: normalize also the full target",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2370146338"
+          }
+        ]
+      },
+      {
+        "id": "1d01293c83c42f2ae2b9f4d837c8b872dff638d7",
+        "type": "FIX",
+        "text": " sap.ui.model.analytics.odata4analytics.FilterExpression#renderUI5FilterArray: fix sorting of filters",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "002075129500009851762023"
+          }
+        ]
+      },
+      {
+        "id": "59c08dae771b6a19f2961cebca8ba9d639475847",
+        "type": "FIX",
+        "text": " sap.ui.core.message.Message fix references to MessageType",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "86d9b992f1c93649c0e53b414114169061f19886",
+        "type": "FIX",
+        "text": " Deprecate sap.ui.core.Message/MessageType",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "59f0716e512e0a355df4a9305399cbab553a318f",
+        "type": "FIX",
+        "text": " Deprecate public registry of Component, Element and UIArea",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "3daff460c7f10d5aad3d077522ce58e8714062d3",
+        "type": "FIX",
+        "text": " Views: Cloning a View is deprecated in favor of the specific factory functions",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      },
+      {
+        "id": "0c6f59fa5db2a9b981f049bd3b029b9d8f98c00f",
+        "type": "FIX",
+        "text": " Ensure correct 'resource-root' and 'theme-root' configuration",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "002028376700065110512023"
+          }
+        ]
+      },
+      {
+        "id": "864aa716ad7cf92e208349b578f3a6ee65c3fd3d",
+        "type": "FIX",
+        "text": " sap.ui.test.action.EnterText: Revert restriction",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2370143073"
+          }
+        ]
+      },
+      {
+        "id": "0deed48088af2e884eb6bb2ab502298b76694890",
+        "type": "FIX",
+        "text": " Lib/ui5loader: Provide deprecation message for pseudo-modules",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2370138723"
+          }
+        ]
+      },
+      {
+        "id": "3c7eea4b30f97ce1e1e1370926c5b64d18a32400",
+        "type": "FIX",
+        "text": " core/Shortcut: trigger \"blur\" within a timeout",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "002075129500007245922023"
+          }
+        ]
+      }
+    ]
   }
 }