@openui5/sap.ui.core 1.119.1 → 1.120.1

package/test/sap/ui/core/qunit/odata/v2/ODataListBindingNoFakeService.qunit.js

@@ -40,7 +40,7 @@ sap.ui.define([
 		var oBinding, oRemoveExpectation, oResetDataExpectation,
 			oContext = {},
 			oModel = {
-				checkFilterOperation : function () {},
+				checkFilter : function () {},
 				createCustomParams : function () {},
 				read : function () {},
 				resolveDeep : function () {}
@@ -51,7 +51,7 @@ sap.ui.define([
 		this.mock(oModel).expects("resolveDeep")
 			.withExactArgs("path", sinon.match.same(oContext))
 			.returns("~deep");
-		this.mock(oModel).expects("checkFilterOperation").withExactArgs([]);
+		this.mock(oModel).expects("checkFilter").withExactArgs([]);
 		this.mock(ODataListBinding.prototype).expects("checkExpandedList")
 			.withExactArgs()
 			.returns(false);
@@ -708,7 +708,7 @@ sap.ui.define([
 		var oBinding,
 			oModel = {
 				read : function () {},
-				checkFilterOperation : function () {},
+				checkFilter : function () {},
 				createCustomParams : function () {},
 				resolve : function () {},
 				resolveDeep : function () {}
@@ -718,7 +718,7 @@ sap.ui.define([
 			.withExactArgs(sinon.match.same(oFixture.parameters))
 			.returns("~custom");
 		this.mock(oModel).expects("resolveDeep").withExactArgs("path", "context").returns("~deep");
-		this.mock(oModel).expects("checkFilterOperation").withExactArgs([]);
+		this.mock(oModel).expects("checkFilter").withExactArgs([]);
 		this.mock(ODataListBinding.prototype).expects("checkExpandedList").withExactArgs()
 			.returns(true);
 		this.mock(ODataListBinding.prototype).expects("_reassignCreateActivate").withExactArgs();
@@ -735,14 +735,14 @@ sap.ui.define([
 	QUnit.test("constructor: remove persisted created contexts without expanded list",
 			function (assert) {
 		var oModel = {
-				checkFilterOperation : function () {},
+				checkFilter : function () {},
 				createCustomParams : function () {},
 				resolveDeep : function () {}
 			};
 
 		this.mock(oModel).expects("createCustomParams").withExactArgs(undefined).returns("~custom");
 		this.mock(oModel).expects("resolveDeep").withExactArgs("path", "context").returns("~deep");
-		this.mock(oModel).expects("checkFilterOperation").withExactArgs([]);
+		this.mock(oModel).expects("checkFilter").withExactArgs([]);
 		this.mock(ODataListBinding.prototype).expects("checkExpandedList")
 			.withExactArgs()
 			.returns(false);
@@ -766,7 +766,7 @@ sap.ui.define([
 		var oBinding,
 			oModel = {
 				read : function () {},
-				checkFilterOperation : function () {},
+				checkFilter : function () {},
 				createCustomParams : function () {},
 				resolve : function () {},
 				resolveDeep : function () {}
@@ -776,7 +776,7 @@ sap.ui.define([
 			.withExactArgs(sinon.match.same(oFixture.parameters))
 			.returns("~custom");
 		this.mock(oModel).expects("resolveDeep").withExactArgs("path", "context").returns("~deep");
-		this.mock(oModel).expects("checkFilterOperation").withExactArgs([]);
+		this.mock(oModel).expects("checkFilter").withExactArgs([]);
 		this.mock(ODataListBinding.prototype).expects("checkExpandedList").withExactArgs()
 			.returns(true);
 		this.mock(ODataListBinding.prototype).expects("_reassignCreateActivate").withExactArgs();
@@ -796,7 +796,7 @@ sap.ui.define([
 				sDefaultCountMode : "~sDefaultCountMode",
 				sDefaultOperationMode : "~sDefaultOperationMode",
 				bPreliminaryContext : "~bPreliminaryContext",
-				checkFilterOperation : function () {},
+				checkFilter : function () {},
 				createCustomParams : function () {},
 				resolveDeep : function () {}
 			};
@@ -805,7 +805,7 @@ sap.ui.define([
 		this.mock(oModel).expects("resolveDeep")
 			.withExactArgs("~sPath", "~oContext")
 			.returns("~sDeepPath");
-		this.mock(oModel).expects("checkFilterOperation").withExactArgs([]);
+		this.mock(oModel).expects("checkFilter").withExactArgs([]);
 		this.mock(ODataListBinding.prototype).expects("checkExpandedList")
 			.withExactArgs()
 			.returns(true);
@@ -864,7 +864,7 @@ sap.ui.define([
 				isPreliminary : function () {}
 			},
 			oModel = {
-				checkFilterOperation : function () {},
+				checkFilter : function () {},
 				createCustomParams : function () {},
 				resolve : function () {},
 				resolveDeep : function () {}
@@ -876,7 +876,7 @@ sap.ui.define([
 		this.mock(oModel).expects("resolveDeep")
 			.withExactArgs("relativePath", bUsePreliminary ? sinon.match.same(oContext) : undefined)
 			.returns("~deepPath"); // resolveDeep returns undefined for oContext === undefined
-		this.mock(oModel).expects("checkFilterOperation").withExactArgs([]);
+		this.mock(oModel).expects("checkFilter").withExactArgs([]);
 		this.mock(ODataListBinding.prototype).expects("checkExpandedList").withExactArgs().returns(true);
 		this.mock(ODataListBinding.prototype).expects("_reassignCreateActivate").withExactArgs();
 
@@ -1072,14 +1072,15 @@ sap.ui.define([
 			aFullTargets : ["~parentEntity~", "~deepPath~(~keyPredicate~)/B"],
 			message : "in"
 		}]
-	}, { // BCP 2370088390: only messages on transient entries (filter null expected)
+	}, { // BCP 2370088390: only messages for transient entries (Filter.NONE expected)
 		aCreatedContextDeepPaths : ["~deepPath~(~uid0~)", "~deepPath~(~uid1~)", "~deepPath~(~uid2~)"],
 		aFilterForPredicate : [],
 		aMessages : [
 			{aFullTargets : ["~deepPath~(~uid0~)"], message : "in"},
 			{aFullTargets : ["~deepPath~(~uid1~)/property"], message : "in"}
-		]
-	}, { // BCP 2370088390: messages on both persistent and transient entries (filter w/o transient expected)
+		],
+		bFilterNoneExpected : true
+	}, { // BCP 2370088390: messages for both persistent and transient entries (filter w/o transient expected)
 		aCreatedContextDeepPaths : ["~deepPath~(~uid0~)", "~deepPath~(~uid1~)", "~deepPath~(~uid2~)"],
 		aFilterForPredicate : ["(~keyPredicate~)"],
 		aMessages : [
@@ -1098,7 +1099,7 @@ sap.ui.define([
 			aCreatedContexts = (oFixture.aCreatedContextDeepPaths || [])
 				.map((sDeepPath) => ({ getDeepPath() {return sDeepPath;} })),
 			aFilterForPredicate = oFixture.aFilterForPredicate,
-			aFilters = [],
+			aFilters = oFixture.bFilterNoneExpected ? [Filter.NONE] : [],
 			aMessages = oFixture.aMessages,
 			oModel = {getMessagesByPath : function () {}},
 			oBinding = {
@@ -1940,6 +1941,12 @@ sap.ui.define([
 	});
 });
 
+	//*********************************************************************************************
+	QUnit.test("getDownloadUrl: return null for Filter.NONE", function (assert) {
+		// code under test
+		assert.strictEqual(ODataListBinding.prototype.getDownloadUrl.call({oCombinedFilter : Filter.NONE}), null);
+	});
+
 	//*********************************************************************************************
 	QUnit.test("_initSortersFilters: getResolvedPath is called", function (assert) {
 		var oBinding = {getResolvedPath : function () {}};
@@ -2506,8 +2513,10 @@ sap.ui.define([
 	});
 
 	//*********************************************************************************************
-	QUnit.test("getContexts: do not load data in case of transient parent", function (assert) {
+[false, true].forEach((bFilterNone) => {
+	QUnit.test("getContexts: do not load data: " + bFilterNone ? "Filter.NONE" : "transient parent", function (assert) {
 		var oBinding = {
+				oCombinedFilter : bFilterNone ? Filter.NONE : undefined,
 				bLengthFinal : true,
 				bRefresh : true,
 				_fireChange : function () {},
@@ -2523,7 +2532,10 @@ sap.ui.define([
 		this.mock(oBinding).expects("_updateLastStartAndLength")
 			.withExactArgs(0, 2, undefined, undefined);
 		this.mock(oBinding).expects("_getContexts").withExactArgs(0, 2).returns(aContexts);
-		this.mock(oBinding).expects("_hasTransientParentContext").withExactArgs().returns(true);
+		this.mock(oBinding).expects("_hasTransientParentContext")
+			.withExactArgs()
+			.exactly(bFilterNone ? 0 : 1)
+			.returns(true);
 		this.mock(oBinding).expects("isFirstCreateAtEnd").withExactArgs().returns(false);
 		this.mock(oBinding).expects("_fireChange").withExactArgs({reason : ChangeReason.Change});
 
@@ -2532,6 +2544,7 @@ sap.ui.define([
 
 		assert.strictEqual(aResultContexts, aContexts);
 	});
+});
 
 	//*********************************************************************************************
 	QUnit.test("_updateLastStartAndLength: bKeepCurrent = false", function (assert) {
@@ -3344,13 +3357,14 @@ sap.ui.define([
 });
 
 	//*********************************************************************************************
-	QUnit.test("filter: removes persisted created entries", function (assert) {
+[false, true].forEach((bFilterNone) => {
+	QUnit.test("filter: removes persisted created entries, with Filter.NONE: " + bFilterNone, function (assert) {
 		var oRemoveExpectation, oResetDataExpectation,
 			aApplicationFilters = [],
 			oBinding = {
 				aApplicationFilters : aApplicationFilters,
 				bInitial : false,
-				oModel : {checkFilterOperation : function () {}},
+				oModel : {checkFilter : function () {}},
 				_fireRefresh : function () {},
 				_removePersistedCreatedContexts : function () {},
 				addComparators : function () {},
@@ -3360,9 +3374,9 @@ sap.ui.define([
 				useClientMode : function () {}
 			},
 			oBindingMock = this.mock(oBinding),
-			aFilters = [];
+			aFilters = bFilterNone ? [Filter.NONE] : [];
 
-		this.mock(oBinding.oModel).expects("checkFilterOperation")
+		this.mock(oBinding.oModel).expects("checkFilter")
 			.withExactArgs(sinon.match.same(aFilters));
 		/** @deprecated As of version 1.22.0, reason sap.ui.model.odata.Filter.js */
 		(function() {
@@ -3371,11 +3385,12 @@ sap.ui.define([
 		}.bind(this)());
 		this.mock(FilterProcessor).expects("combineFilters")
 			.withExactArgs(sinon.match.same(aFilters), sinon.match.same(aApplicationFilters))
-			.returns("~oCombinedFilter");
+			.returns(bFilterNone ? Filter.NONE : "~oCombinedFilter");
 		oBindingMock.expects("useClientMode").withExactArgs().twice().returns(false);
-		oBindingMock.expects("createFilterParams").withExactArgs("~oCombinedFilter");
-		oBindingMock.expects("addComparators").withExactArgs(sinon.match.same(aFilters));
-		oBindingMock.expects("addComparators").withExactArgs(sinon.match.same(aApplicationFilters));
+		oBindingMock.expects("createFilterParams").exactly(bFilterNone ? 0 : 1).withExactArgs("~oCombinedFilter");
+		oBindingMock.expects("addComparators").exactly(bFilterNone ? 0 : 1).withExactArgs(sinon.match.same(aFilters));
+		oBindingMock.expects("addComparators").exactly(bFilterNone ? 0 : 1)
+			.withExactArgs(sinon.match.same(aApplicationFilters));
 		oRemoveExpectation = oBindingMock.expects("_removePersistedCreatedContexts")
 			.withExactArgs();
 		oResetDataExpectation = oBindingMock.expects("resetData").withExactArgs();
@@ -3391,16 +3406,17 @@ sap.ui.define([
 		assert.strictEqual(ODataListBinding.prototype.filter.call(oBinding, aFilters), oBinding);
 
 		assert.strictEqual(oBinding.aFilters, aFilters);
-		assert.strictEqual(oBinding.oCombinedFilter, "~oCombinedFilter");
+		assert.strictEqual(oBinding.oCombinedFilter, bFilterNone ? Filter.NONE : "~oCombinedFilter");
 		assert.ok(oResetDataExpectation.calledImmediatelyAfter(oRemoveExpectation));
 	});
+});
 
 	//*********************************************************************************************
 	QUnit.test("filter: handle created persisted in Client mode", function (assert) {
 		var oBinding = {
 				aAllKeys : [],
 				bInitial : false,
-				oModel : {checkFilterOperation : function () {}},
+				oModel : {checkFilter : function () {}},
 				_moveCreatedPersistedToAllKeys : function () {},
 				_fireChange : function () {},
 				addComparators : function () {},
@@ -3409,7 +3425,7 @@ sap.ui.define([
 				useClientMode : function () {}
 			};
 
-		this.mock(oBinding.oModel).expects("checkFilterOperation").withExactArgs([]);
+		this.mock(oBinding.oModel).expects("checkFilter").withExactArgs([]);
 		/** @deprecated As of version 1.22.0, reason sap.ui.model.odata.Filter.js */
 		(function() {
 			oBinding.convertFilters = function () {};
@@ -3642,15 +3658,22 @@ sap.ui.define([
 	bResolved : true,
 	bResult : false,
 	bTransient : false
+}, {
+	filterNone : Filter.NONE,
+	bResolved : undefined,
+	bResult : true,
+	bTransient : undefined
 }].forEach(function (oFixture, i) {
 	QUnit.test("resetData: set bLengthFinal #" + i, function (assert) {
 		var oBinding = {
+				oCombinedFilter : oFixture.filterNone,
 				_hasTransientParentContext : function () {},
 				isResolved : function () {}
 			};
 
 		this.mock(oBinding).expects("_hasTransientParentContext")
 			.withExactArgs()
+			.exactly(oFixture.bTransient === undefined ? 0 : 1)
 			.returns(oFixture.bTransient);
 		this.mock(oBinding).expects("isResolved")
 			.withExactArgs()