@openui5/sap.ui.core 1.117.2 → 1.117.3

package/src/sap/ui/model/odata/v4/Context.js

@@ -42,7 +42,7 @@ sap.ui.define([
 		 * @hideconstructor
 		 * @public
 		 * @since 1.39.0
-		 * @version 1.117.2
+		 * @version 1.117.3
 		 */
 		Context = BaseContext.extend("sap.ui.model.odata.v4.Context", {
 				constructor : constructor

package/src/sap/ui/model/odata/v4/ODataContextBinding.js

@@ -74,7 +74,7 @@ sap.ui.define([
 		 * @mixes sap.ui.model.odata.v4.ODataParentBinding
 		 * @public
 		 * @since 1.37.0
-		 * @version 1.117.2
+		 * @version 1.117.3
 		 *
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getGroupId as #getGroupId
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getRootBinding as #getRootBinding

package/src/sap/ui/model/odata/v4/ODataListBinding.js

@@ -57,7 +57,7 @@ sap.ui.define([
 		 * @mixes sap.ui.model.odata.v4.ODataParentBinding
 		 * @public
 		 * @since 1.37.0
-		 * @version 1.117.2
+		 * @version 1.117.3
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getGroupId as #getGroupId
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getRootBinding as #getRootBinding
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getUpdateGroupId as #getUpdateGroupId

package/src/sap/ui/model/odata/v4/ODataMetaModel.js

@@ -156,7 +156,7 @@ sap.ui.define([
 		 * @hideconstructor
 		 * @public
 		 * @since 1.37.0
-		 * @version 1.117.2
+		 * @version 1.117.3
 		 */
 		ODataMetaModel = MetaModel.extend("sap.ui.model.odata.v4.ODataMetaModel", {
 				constructor : constructor

package/src/sap/ui/model/odata/v4/ODataModel.js

@@ -233,7 +233,7 @@ sap.ui.define([
 		 * @extends sap.ui.model.Model
 		 * @public
 		 * @since 1.37.0
-		 * @version 1.117.2
+		 * @version 1.117.3
 		 */
 		ODataModel = Model.extend("sap.ui.model.odata.v4.ODataModel",
 			/** @lends sap.ui.model.odata.v4.ODataModel.prototype */{

package/src/sap/ui/model/odata/v4/ODataPropertyBinding.js

@@ -42,7 +42,7 @@ sap.ui.define([
 		 * @mixes sap.ui.model.odata.v4.ODataBinding
 		 * @public
 		 * @since 1.37.0
-		 * @version 1.117.2
+		 * @version 1.117.3
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getGroupId as #getGroupId
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getRootBinding as #getRootBinding
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getUpdateGroupId as #getUpdateGroupId

package/src/sap/ui/model/resource/ResourceModel.js

@@ -227,7 +227,7 @@ sap.ui.define([
 	 *
 	 * @extends sap.ui.model.Model
 	 * @public
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 */
 	var ResourceModel = Model.extend("sap.ui.model.resource.ResourceModel", /** @lends sap.ui.model.resource.ResourceModel.prototype */ {
 

package/src/sap/ui/model/type/Boolean.js

@@ -19,7 +19,7 @@ sap.ui.define(['sap/ui/model/SimpleType', 'sap/ui/model/FormatException', 'sap/u
 	 * @extends sap.ui.model.SimpleType
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions]

package/src/sap/ui/model/type/Currency.js

@@ -32,7 +32,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.CompositeType
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions]

package/src/sap/ui/model/type/Date.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.SimpleType
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions] Formatting options. For a list of all available options, see {@link sap.ui.core.format.DateFormat.getDateInstance DateFormat}.

package/src/sap/ui/model/type/DateInterval.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.CompositeType
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @alias sap.ui.model.type.DateInterval
 	 * @param {object} [oFormatOptions]

package/src/sap/ui/model/type/DateTime.js

@@ -19,7 +19,7 @@ sap.ui.define(['./Date', 'sap/ui/core/format/DateFormat'],
 	 * @extends sap.ui.model.type.Date
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions] Formatting options. For a list of all available options, see {@link sap.ui.core.format.DateFormat.getDateTimeInstance DateFormat}.

package/src/sap/ui/model/type/DateTimeInterval.js

@@ -19,7 +19,7 @@ sap.ui.define(['./DateInterval', 'sap/ui/core/format/DateFormat'],
 	 * @extends sap.ui.model.type.DateInterval
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions] Formatting options. For a list of all available options, see {@link sap.ui.core.format.DateFormat.getDateTimeInstance DateFormat}.

package/src/sap/ui/model/type/FileSize.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.SimpleType
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions]

package/src/sap/ui/model/type/Float.js

@@ -26,7 +26,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.SimpleType
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions]

package/src/sap/ui/model/type/Integer.js

@@ -26,7 +26,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.SimpleType
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions]

package/src/sap/ui/model/type/String.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.SimpleType
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @alias sap.ui.model.type.String
 	 * @param {object} [oFormatOptions]

package/src/sap/ui/model/type/Time.js

@@ -19,7 +19,7 @@ sap.ui.define(['./Date', 'sap/ui/core/format/DateFormat'],
 	 * @extends sap.ui.model.type.Date
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions] Formatting options. For a list of all available options, see {@link sap.ui.core.format.DateFormat.getTimeInstance DateFormat}.

package/src/sap/ui/model/type/TimeInterval.js

@@ -19,7 +19,7 @@ sap.ui.define(['./DateInterval', 'sap/ui/core/format/DateFormat'],
 	 * @extends sap.ui.model.type.DateInterval
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions] Formatting options. For a list of all available options, see {@link sap.ui.core.format.DateFormat.getTimeInstance DateFormat}.

package/src/sap/ui/model/type/Unit.js

@@ -48,7 +48,7 @@ sap.ui.define([
 	 *
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @param {object} [oFormatOptions]

package/src/sap/ui/model/xml/XMLModel.js

@@ -47,7 +47,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.ClientModel
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @param {XMLDocument|string} oData
 	 *   Either the URL where to load the XML from or an XML document

package/src/sap/ui/performance/BeaconRequest.js

@@ -32,22 +32,20 @@ sap.ui.define([], function () {
 		this._sUrl = option.url;
 
 		/**
-		 * Send data if the browser has been closed
-		 *
-		 * The "visibilitychange" event is not fired in Safari when the browser tab is closed.
+		 * Send data if the document visibility has changed to 'hidden'.
+		 * That's the case if the tab inactive e.g. by switching to another tab
+		 * or in case the active tab is closed. On mobile devices it's the only
+		 * reliable event for detecting tab switch or minimizing/closing the
+		 * browser.
+		 * Previously also the pagehinde event was needed because safari did not
+		 * fire the 'visibilitychange' event on navigating away from a page but
+		 * but as of Safari 14.5 this issue is fixed.
 		 */
 		document.addEventListener("visibilitychange", function () {
 			if (document.visibilityState === "hidden") {
 				this.send();
 			}
 		}.bind(this));
-
-		/**
-		 * Ensure that the date is sent if the "visibilitychange" event was not fired.
-		 */
-		window.addEventListener("beforeunload", function () {
-			this.send();
-		}.bind(this));
 	};
 
 	/**

package/src/sap/ui/qunit/utils/ControlIterator.js

@@ -53,7 +53,7 @@ sap.ui.define(['sap/ui/core/Core', "sap/ui/VersionInfo"],
 	 * @namespace
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @since 1.48.0

package/src/sap/ui/qunit/utils/MemoryLeakCheck.js

@@ -27,7 +27,7 @@ sap.ui.define([ 'sap/ui/core/Element', 'sap/ui/core/Control', 'sap/ui/core/Core'
 	 * @namespace
 	 *
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 *
 	 * @public
 	 * @since 1.48.0

package/src/sap/ui/test/generic/TestBase.js

@@ -26,7 +26,7 @@ sap.ui.define([
 	 * @extends sap.ui.base.Object
 	 * @abstract
 	 * @author SAP SE
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 * @since 1.100
 	 */
 	return BaseObject.extend("sap.ui.test.generic.TestBase", {

package/src/sap/ui/util/Storage.js

@@ -277,7 +277,7 @@ sap.ui.define(["sap/base/assert"], function (assert) {
 	 *
 	 * @enum {string}
 	 * @public
-	 * @version 1.117.2
+	 * @version 1.117.3
 	 */
 	Storage.Type = {
 		/**

package/test/sap/ui/core/qunit/component/Component.qunit.js

@@ -1742,6 +1742,9 @@ sap.ui.define([
 	});
 
 
+	/**
+	 * @deprecated As of 1.117
+	 */
 	QUnit.module("Window Event Handler", {
 		beforeEach: function() {
 
@@ -1754,6 +1757,9 @@ sap.ui.define([
 		}
 	});
 
+	/**
+	 * @deprecated As of 1.117
+	 */
 	QUnit.test("onWindowError", function(assert) {
 		var MyOnWindowErrorComponent = Component.extend("test.onWindowError.Component");
 
@@ -1787,6 +1793,9 @@ sap.ui.define([
 		assert.equal(this.removeEventListenerSpy.getCall(0).thisValue, window, "removeEventListener has been called on the window object");
 	});
 
+	/**
+	 * @deprecated As of 1.117
+	 */
 	QUnit.test("onWindowBeforeUnload", function(assert) {
 		var MyOnWindowBeforeUnloadComponent = Component.extend("test.onWindowBeforeUnload.Component");
 
@@ -1813,6 +1822,9 @@ sap.ui.define([
 		assert.equal(this.removeEventListenerSpy.getCall(0).thisValue, window, "removeEventListener has been called on the window object");
 	});
 
+	/**
+	 * @deprecated As of 1.117
+	 */
 	QUnit.test("onWindowUnload", function(assert) {
 		var MyOnWindowUnloadComponent = Component.extend("test.onWindowUnload.Component");
 

package/test/sap/ui/core/qunit/odata/v2/ODataModel.integration.qunit.js

@@ -5430,7 +5430,7 @@ usePreliminaryContext : false}}">\
 		}).then(function () {
 			var oResetPromise;
 
-			if (bWithFailedPOST && bPersistTechnicalMessages && !bDeleteCreatedEntities) {
+			if (bWithFailedPOST && bPersistTechnicalMessages) {
 				that.expectMessages([{
 						code : "UF0",
 						fullTarget : "/SalesOrderSet('1')/ToLineItems('~key~')",

package/test/sap/ui/core/qunit/odata/v2/ODataModelNoFakeService.qunit.js

@@ -6709,7 +6709,7 @@ sap.ui.define([
 				.withExactArgs("~oAbortedError");
 		}
 		oModelMock.expects("getMessagesByEntity")
-			.withExactArgs("~sKey", !bDeleteEntity)
+			.withExactArgs("~sKey", true)
 			.returns("~aMessages");
 		oMessageManagerMock.expects("removeMessages").withExactArgs("~aMessages");
 
@@ -6766,7 +6766,7 @@ sap.ui.define([
 			.withExactArgs(sinon.match.same(oContext));
 		this.mock(oModel).expects("_removeEntity").withExactArgs("~sKey");
 		this.mock(oModel).expects("getMessagesByEntity")
-			.withExactArgs("~sKey", false)
+			.withExactArgs("~sKey", true)
 			.returns("~aMessages");
 		this.mock(sap.ui.getCore().getMessageManager()).expects("removeMessages")
 			.withExactArgs("~aMessages");

package/test/sap/ui/core/qunit/performance/BeaconRequest.qunit.js

@@ -80,6 +80,14 @@ sap.ui.define(["sap/ui/performance/BeaconRequest"], function (BeaconRequest) {
 	QUnit.test("Send beacon on window close", function(assert) {
 		var done = assert.async();
 		assert.expect(2);
+		let resLoad, resArranged;
+		const pLoaded = Promise.all([
+			new Promise((res) => {
+				resLoad = res;
+			}), new Promise((res) => {
+				resArranged = res;
+			})
+		]);
 
 		// setup iframe which will apply a stub on BeaconRequest#send to check
 		// if it is called on the iframe's window unload event - defined in
@@ -92,18 +100,26 @@ sap.ui.define(["sap/ui/performance/BeaconRequest"], function (BeaconRequest) {
 		function arranged(msg) {
 			assert.equal(msg.data.token, "arranged", "BeaconRequest#send has been replaced");
 			window.removeEventListener("message", arranged);
-			window.addEventListener("message", assertions);
-			oIframe.contentWindow.location.reload();
+			resArranged();
 		}
 
 		// checks the if the stub has been called
 		function assertions(msg) {
+			if (msg.data.token !== "called") {
+				return;
+			}
 			assert.equal(msg.data.token, "called", "BeaconRequest#send has been called");
 			window.removeEventListener("message", assertions);
 			done();
 		}
 
+		oIframe.onload = resLoad;
 		window.addEventListener("message", arranged);
+
+		pLoaded.then(() => {
+			window.addEventListener("message", assertions);
+			document.getElementById('qunit-fixture').removeChild(oIframe);
+		});
 	});
 
 	QUnit.test("Do not send beacon if the buffer is empty", function(assert) {

package/test/sap/ui/core/relnotes/changes-1.117.json

@@ -172,5 +172,43 @@
         ]
       }
     ]
+  },
+  "1.117.3": {
+    "date": "November 2023",
+    "notes": [
+      {
+        "id": "80b8a198488fa04923bbfe835ff31fe159b4d7e2",
+        "type": "FIX",
+        "text": " Stabilize QUnit test for BeaconRequest",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2370118287"
+          }
+        ]
+      },
+      {
+        "id": "b7e444c6657e8768be7af233651cdb73e3dc03b2",
+        "type": "FIX",
+        "text": " sap.ui.model.odata.v2.ODataModel#resetChanges: do not remove persistent messages",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2370086388"
+          }
+        ]
+      },
+      {
+        "id": "ef142c77cae7d1c6cdc76853b925dafa6ed8c315",
+        "type": "FEATURE",
+        "text": " Prepare for upcoming 'unload' event deprecation and deprecate APIs 'onWindowBeforeUnload', 'onWindowUnload' and 'onWindowError' in 'sap/ui/core/Component'",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      }
+    ]
   }
 }