@openui5/sap.ui.core 1.117.1 → 1.117.3

package/test/sap/ui/core/qunit/odata/v2/ODataModel.integration.qunit.js

@@ -5430,7 +5430,7 @@ usePreliminaryContext : false}}">\
 		}).then(function () {
 			var oResetPromise;
 
-			if (bWithFailedPOST && bPersistTechnicalMessages && !bDeleteCreatedEntities) {
+			if (bWithFailedPOST && bPersistTechnicalMessages) {
 				that.expectMessages([{
 						code : "UF0",
 						fullTarget : "/SalesOrderSet('1')/ToLineItems('~key~')",
@@ -14254,6 +14254,57 @@ ToProduct/ToSupplier/BusinessPartnerID\'}}">\
 		});
 	});
 
+	//*********************************************************************************************
+	// Scenario: If a list binding contains created entries at the start of the list and the
+	// binding's length is final, ensure that all data is requested if the user scrolls to the end
+	// of the list.
+	// BCP: 002075129400006921272023
+	QUnit.test("Created entries at start: scrolling to the end reads all data", function (assert) {
+		var oTable,
+			oModel = createSalesOrdersModel({defaultCountMode : CountMode.Inline}),
+			sView = '\
+<Table growing="true" growingThreshold="3" id="table" items="{/SalesOrderSet}">\
+	<Input id="note" value="{Note}"/>\
+</Table>',
+		that = this;
+
+		this.expectHeadRequest()
+			.expectRequest("SalesOrderSet?$skip=0&$top=3&$inlinecount=allpages", {
+				__count : "5",
+				results : [
+					{__metadata : {uri : "SalesOrderSet('1')"}, Note : "SO1", SalesOrderID : "1"},
+					{__metadata : {uri : "SalesOrderSet('2')"}, Note : "SO2", SalesOrderID : "2"},
+					{__metadata : {uri : "SalesOrderSet('3')"}, Note : "SO3", SalesOrderID : "3"}
+				]
+			})
+			.expectValue("note", ["SO1", "SO2", "SO3"]);
+
+		return this.createView(assert, sView, oModel).then(function () {
+			oTable = that.oView.byId("table");
+
+			that.expectValue("note", ["SONew", "SO1", "SO2", "SO3"]);
+
+			// code under test - create an item at the start of the list
+			oTable.getBinding("items").create({Note : "SONew"});
+
+			return that.waitForChanges(assert);
+		}).then(function () {
+			that.expectRequest("SalesOrderSet?$skip=3&$top=2", {
+				results : [
+					{__metadata : {uri : "SalesOrderSet('4')"}, Note : "SO4", SalesOrderID : "4"},
+					{__metadata : {uri : "SalesOrderSet('5')"}, Note : "SO5", SalesOrderID : "5"}
+				]
+			});
+
+			that.expectValue("note", ["SO3", "SO4", "SO5"], 3);
+
+			// code under test - scroll down to get all data from server
+			oTable.requestItems();
+
+			return that.waitForChanges(assert);
+		});
+	});
+
 	//*********************************************************************************************
 	// Scenario: If the table displays only transient entities (no threshold is set) and a new
 	// control filter is set on the table the number of available entities is properly displayed.
@@ -20209,4 +20260,95 @@ ToProduct/ToSupplier/BusinessPartnerID\'}}">\
 			return that.waitForChanges(assert);
 		});
 	});
+
+	//*********************************************************************************************
+	// Scenario: If the server uses server side paging and the OData model uses "Client" mode all
+	// data is requested up to the model size limit.
+	// BCP: 2380127053
+[false, true].forEach(function (bShortRead) {
+	QUnit.test("OperationMode.Client: with server side paging, short read:" + bShortRead, function (assert) {
+		var oTable,
+			iDataReceived = 0,
+			iDataRequested = 0,
+			iExpectedSize = bShortRead ? 15 : 30,
+			oModel = createSalesOrdersModel({defaultOperationMode: "Client"}),
+			sView = '\
+<t:Table id="table">\
+	<Text id="note" text="{Note}"/>\
+</t:Table>',
+			that = this;
+
+		function dataRequested() {
+			iDataRequested += 1;
+		}
+		function dataReceived(oEvent) {
+			var oEventData = oEvent.getParameter("data");
+
+			iDataReceived += 1;
+			// responses are merged
+			assert.strictEqual(oEventData.results.length, iExpectedSize);
+			oEventData.results.forEach((oData, i) => {
+				assert.strictEqual(oData.Note, "SO" + (i + 1));
+			});
+			assert.strictEqual(oEventData.__count, "" + iExpectedSize);
+		}
+
+		oModel.setSizeLimit(30);
+
+		return this.createView(assert, sView, oModel).then(function () {
+			function createItems(iFrom, iLength) {
+				var i,
+					aItems = [];
+
+				for (i = 0; i < iLength; i += 1) {
+					aItems.push({
+						__metadata: {uri : "SalesOrderSet('" + iFrom + "')"},
+						Note: "SO" + iFrom,
+						SalesOrderID: "" + iFrom
+					});
+					iFrom += 1;
+				}
+
+				return aItems;
+			}
+
+			that.expectHeadRequest()
+				.expectRequest("SalesOrderSet", {
+					__next: "/sap/opu/odata/sap/ZUI5_GWSAMPLE_BASIC/SalesOrderSet?$skiptoken=3",
+					results: createItems(1, 3) // whitout $top server returns 3; in real maybe 100
+				})
+				.expectRequest("SalesOrderSet?$skip=3&$top=27", {
+					// if $top is given server limit is used; here 10, in real maybe 5000
+					__next: "/sap/opu/odata/sap/ZUI5_GWSAMPLE_BASIC/SalesOrderSet?$top=24$skiptoken=13",
+					results: createItems(4, 10)
+				})
+				.expectRequest("SalesOrderSet?$skip=13&$top=17", {
+					// no _next link, that means server returned all requestd entries; there may be
+					// more on the server but the amount of data exceeds the model size limit
+					results: createItems(14, bShortRead ? 2 : 17)
+				});
+
+			oTable = that.oView.byId("table");
+			// code under test - client mode reads all data
+			oTable.bindRows({
+					events: {
+						dataRequested: dataRequested,
+						dataReceived: dataReceived
+					},
+					filter: [new Filter("GrossAmount", FilterOperator.GT, 500)],
+					path: "/SalesOrderSet",
+					sorter: [new Sorter("CompanyCode", true)]
+				});
+
+			return that.waitForChanges(assert);
+		}).then(function () {
+			var oBinding = oTable.getBinding("rows");
+
+			assert.strictEqual(oBinding.getLength(), iExpectedSize);
+			assert.strictEqual(oBinding.getCount(), iExpectedSize);
+			assert.strictEqual(iDataRequested, 1);
+			assert.strictEqual(iDataReceived, 1);
+		});
+	});
+});
 });

package/test/sap/ui/core/qunit/odata/v2/ODataModelNoFakeService.qunit.js

@@ -6709,7 +6709,7 @@ sap.ui.define([
 				.withExactArgs("~oAbortedError");
 		}
 		oModelMock.expects("getMessagesByEntity")
-			.withExactArgs("~sKey", !bDeleteEntity)
+			.withExactArgs("~sKey", true)
 			.returns("~aMessages");
 		oMessageManagerMock.expects("removeMessages").withExactArgs("~aMessages");
 
@@ -6766,7 +6766,7 @@ sap.ui.define([
 			.withExactArgs(sinon.match.same(oContext));
 		this.mock(oModel).expects("_removeEntity").withExactArgs("~sKey");
 		this.mock(oModel).expects("getMessagesByEntity")
-			.withExactArgs("~sKey", false)
+			.withExactArgs("~sKey", true)
 			.returns("~aMessages");
 		this.mock(sap.ui.getCore().getMessageManager()).expects("removeMessages")
 			.withExactArgs("~aMessages");

package/test/sap/ui/core/qunit/performance/BeaconRequest.qunit.js

@@ -80,6 +80,14 @@ sap.ui.define(["sap/ui/performance/BeaconRequest"], function (BeaconRequest) {
 	QUnit.test("Send beacon on window close", function(assert) {
 		var done = assert.async();
 		assert.expect(2);
+		let resLoad, resArranged;
+		const pLoaded = Promise.all([
+			new Promise((res) => {
+				resLoad = res;
+			}), new Promise((res) => {
+				resArranged = res;
+			})
+		]);
 
 		// setup iframe which will apply a stub on BeaconRequest#send to check
 		// if it is called on the iframe's window unload event - defined in
@@ -92,18 +100,26 @@ sap.ui.define(["sap/ui/performance/BeaconRequest"], function (BeaconRequest) {
 		function arranged(msg) {
 			assert.equal(msg.data.token, "arranged", "BeaconRequest#send has been replaced");
 			window.removeEventListener("message", arranged);
-			window.addEventListener("message", assertions);
-			oIframe.contentWindow.location.reload();
+			resArranged();
 		}
 
 		// checks the if the stub has been called
 		function assertions(msg) {
+			if (msg.data.token !== "called") {
+				return;
+			}
 			assert.equal(msg.data.token, "called", "BeaconRequest#send has been called");
 			window.removeEventListener("message", assertions);
 			done();
 		}
 
+		oIframe.onload = resLoad;
 		window.addEventListener("message", arranged);
+
+		pLoaded.then(() => {
+			window.addEventListener("message", assertions);
+			document.getElementById('qunit-fixture').removeChild(oIframe);
+		});
 	});
 
 	QUnit.test("Do not send beacon if the buffer is empty", function(assert) {

package/test/sap/ui/core/qunit/testsuite.core.framework.qunit.js

@@ -59,12 +59,6 @@ sap.ui.define(function() {
 				 */
 				page: "test-resources/sap/ui/core/qunit/Core_unavoidablyUsingEval.qunit.html"
 			},
-			CoreLock: {
-				title: "sap.ui.core.Core: Core unlocks unconditionally itself upon load/init",
-				ui5: {
-					libs: "sap.m"
-				}
-			},
 			/**
 			 * The tests for the preload files all share the same test configuration.
 			 * There is only one HTML test page, which is opened with different URL parameters.

package/test/sap/ui/core/qunit/types/DateInterval.qunit.js

@@ -130,7 +130,7 @@ sap.ui.define([
 	//*********************************************************************************************
 	QUnit.test("parseValue", function (assert) {
 		var oDate1 = UI5Date.getInstance(2003, 10, 6),
-			oDate2 = UI5Date.getInstance(2003, 11, 6, 23, 59, 59, 999),
+			oDate2 = UI5Date.getInstance(2003, 11, 6, 23, 59, 59, 0),
 			oDateInterval = new DateInterval({format: "yMMMd"});
 
 		assert.deepEqual(oDateInterval.parseValue("", "string"), [null, null],
@@ -158,7 +158,7 @@ sap.ui.define([
 	QUnit.test("parseValue: UTC", function (assert) {
 		var oDateInterval = new DateInterval({UTC: true}),
 			oUTCDate1 = UI5Date.getInstance(Date.UTC(2003, 10, 6, 0, 0, 0, 0)),
-			oUTCDate2 = UI5Date.getInstance(Date.UTC(2003, 11, 6, 23, 59, 59, 999));
+			oUTCDate2 = UI5Date.getInstance(Date.UTC(2003, 11, 6, 23, 59, 59, 0));
 
 		// code under test
 		assert.deepEqual(oDateInterval.parseValue("Nov 6, 2003 - Dec 6, 2003", "string"), [oUTCDate1, oUTCDate2]);

package/test/sap/ui/core/relnotes/changes-1.117.json

@@ -123,5 +123,92 @@
         ]
       }
     ]
+  },
+  "1.117.2": {
+    "date": "October 2023",
+    "notes": [
+      {
+        "id": "35f5ee9865ab77db23321440812472799586f9dd",
+        "type": "FIX",
+        "text": " sap.ui.model.odata.v2.ODataListBinding#loadData: read all data (up to model size limit) in \"Client\" mode",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2380127053"
+          }
+        ]
+      },
+      {
+        "id": "61138d76952718c7461d311c8d6879f0b337dedb",
+        "type": "FIX",
+        "text": " sap.ui.model.type.DateInterval#parseValue: no milliseconds at interval end",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "002075129400006908592023"
+          }
+        ]
+      },
+      {
+        "id": "e548182650511d0232c32dac93c312d5b78bb7b4",
+        "type": "FIX",
+        "text": " sap.ui.model.odata.v2.ODataListBinding#_getSkipAndTop: fix calculation of \"iLimit\"",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "002075129400006921272023"
+          }
+        ]
+      },
+      {
+        "id": "17c4c620e67233d18911e2369c9d29547d7e4a93",
+        "type": "FIX",
+        "text": " Fix Core Qunit tests",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      }
+    ]
+  },
+  "1.117.3": {
+    "date": "November 2023",
+    "notes": [
+      {
+        "id": "80b8a198488fa04923bbfe835ff31fe159b4d7e2",
+        "type": "FIX",
+        "text": " Stabilize QUnit test for BeaconRequest",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2370118287"
+          }
+        ]
+      },
+      {
+        "id": "b7e444c6657e8768be7af233651cdb73e3dc03b2",
+        "type": "FIX",
+        "text": " sap.ui.model.odata.v2.ODataModel#resetChanges: do not remove persistent messages",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2370086388"
+          }
+        ]
+      },
+      {
+        "id": "ef142c77cae7d1c6cdc76853b925dafa6ed8c315",
+        "type": "FEATURE",
+        "text": " Prepare for upcoming 'unload' event deprecation and deprecate APIs 'onWindowBeforeUnload', 'onWindowUnload' and 'onWindowError' in 'sap/ui/core/Component'",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": ""
+          }
+        ]
+      }
+    ]
   }
 }

package/test/sap/ui/core/qunit/CoreLock.qunit.js

@@ -1,61 +0,0 @@
-/*global QUnit */
-sap.ui.define([
-	"sap/m/Button",
-	"sap/ui/thirdparty/jquery"
-], function(Button, jQuery) {
-	"use strict";
-
-	// Lock the Core.
-	// This can be done anywhen after the Core has been loaded and executed, potentially
-	// before it has been initialized
-	sap.ui.getCore().lock();
-
-	// create some UI that shows whether lock/unlock works or not
-	var oButton = new Button({
-		id : "button",
-		text : "Click",
-		tooltip : "This SAPUI5 Button should be 'locked' until the Core is explicitly unlocked"
-	});
-
-	/*
-	 * the following is a workaround that applications can implement
-
-	sap.ui.getCore().attachInit(function() {
-		// we have to use setTimeout as the unanted unlock happens just after init events have been processed
-		setTimeout(function() {
-			sap.ui.getCore().lock();
-		}, 10);
-	} );
-
-	/* */
-
-	QUnit.module("Check for Unlocked Core");
-
-	QUnit.test("Control Events should be blocked depending on Core lock", function(assert) {
-		var pressed = false;
-		oButton.attachPress(function() {
-			pressed = true;
-		});
-
-		assert.ok(!pressed, "Button must not have fired 'press' yet");
-		jQuery("#button").trigger("focus").trigger("click");
-		assert.ok(!pressed, "Button still must not have fired 'press'");
-
-		sap.ui.getCore().unlock();
-
-		assert.ok(!pressed, "Button still must not have fired 'press'");
-		jQuery("#button").trigger("focus").trigger("tap");
-		assert.ok(pressed, "Button should have fired 'press'");
-	});
-
-	sap.ui.getCore().attachInit(function() {
-		// create content div
-		var oDIV = document.createElement("div");
-		oDIV.id = "content";
-		document.body.appendChild(oDIV);
-
-		oButton.placeAt("content");
-		sap.ui.getCore().applyChanges();
-	});
-
-});