@openui5/sap.ui.core 1.115.1 → 1.116.0

package/test/sap/ui/core/demokit/sample/odata/v4/DeepCreate/manifest.json

@@ -0,0 +1,134 @@
+{
+	"_version" : "1.115.0",
+	"sap.app" : {
+		"ach" : "CA-UI5-COR",
+		"applicationVersion" : {
+			"version" : "${version}"
+		},
+		"description" : "Demo Application for Deep Create",
+		"dataSources" : {
+			"default" : {
+				"uri" : "/sap/opu/odata4/sap/zui5_testv4/default/sap/zui5_epm_sample/0002/",
+				"type" : "OData"
+			}
+		},
+		"id" : "sap.ui.core.sample.odata.v4.DeepCreate",
+		"title" : "Deep Create Application",
+		"type" : "application"
+	},
+	"sap.ui" : {
+		"deviceTypes" : {
+			"desktop" : true,
+			"phone" : true,
+			"tablet" : true
+		},
+		"technology" : "UI5"
+	},
+	"sap.ui5" : {
+		"config" : {
+			"sample" : {
+				"files" : [
+					"Component.js",
+					"ListReport.controller.js",
+					"ListReport.view.xml",
+					"Main.controller.js",
+					"Main.view.xml",
+					"manifest.json",
+					"NotFound.view.xml",
+					"ObjectPage.controller.js",
+					"ObjectPage.view.xml",
+					"README.html",
+					"SandboxModel.js",
+					"data/metadata.xml",
+					"data/POST-SalesOrderList.json",
+					"data/SalesOrderList('0500000000').json",
+					"data/SalesOrderList('0500000000')-SO_2_SOITEM.json",
+					"data/SalesOrderList('0500000001').json",
+					"data/SalesOrderList('0500000007')-SO_2_BP.json",
+					"data/SalesOrderList.json",
+					"data/VH_CurrencyCode.json",
+					"data/VH_CurrencyCode.xml",
+					"data/VH_ProductID.json",
+					"data/VH_ProductID.xml",
+					"../../../common/Controller.js",
+					"../../../common/SandboxModelHelper.js",
+					"../../../common/ValueHelp.js"
+				]
+			}
+		},
+		"contentDensities" : {
+			"compact" : true,
+			"cozy" : true
+		},
+		"dependencies" : {
+			"minUI5Version" : "1.115.0",
+			"libs" : {
+				"sap.m" : {},
+				"sap.ui.layout" : {}
+			}
+		},
+		"handleValidation" : true,
+		"models" : {
+			"" : {
+				"dataSource" : "default",
+				"preload" : true,
+				"settings" : {
+					"autoExpandSelect" : true,
+					"earlyRequests" : true,
+					"updateGroupId" : "UpdateGroup"
+				},
+				"type" : "sap.ui.core.sample.odata.v4.DeepCreate.SandboxModel",
+				"uriSettingName" : "serviceUrl"
+			}
+		},
+		"rootView" : {
+			"async" : true,
+			"type" : "XML",
+			"viewName" : "sap.ui.core.sample.odata.v4.DeepCreate.Main"
+		},
+		"routing" : {
+			"config" : {
+				"async" : true,
+				"bypassed": {
+					"target": "notFound"
+				},
+				"controlAggregation" : "pages",
+				"controlId" : "app",
+				"path" : "sap.ui.core.sample.odata.v4.DeepCreate",
+				"routerClass" : "sap.m.routing.Router",
+				"type" : "View",
+				"viewType" : "XML"
+			},
+			"routes" : [{
+				"name" : "listReport",
+				"pattern" : "",
+				"target" : ["listReport"]
+			}, {
+				"name" : "objectPage",
+				"pattern" : "id={id}",
+				"target" : ["objectPage"]
+			}, {
+				"name" : "create",
+				"pattern" : "create",
+				"target" : ["objectPage"]
+			}],
+			"targets" : {
+				"listReport" : {
+					"id" : "listReport",
+					"level" : 1,
+					"name" : "ListReport"
+				},
+				"objectPage" : {
+					"id" : "objectPage",
+					"level" : 1,
+					"name" : "ObjectPage"
+				},
+				"notFound": {
+					"id": "notFound",
+					"name": "NotFound",
+					"transition": "show"
+				}
+			}
+		}
+	}
+}

package/test/sap/ui/core/demokit/sample/odata/v4/DeepCreate/pages/Main.js

@@ -0,0 +1,119 @@
+/*!
+ * ${copyright}
+ */
+sap.ui.define([
+	"sap/ui/core/sample/common/Helper",
+	"sap/ui/test/Opa",
+	"sap/ui/test/Opa5",
+	"sap/ui/test/TestUtils",
+	"sap/ui/test/actions/Press"
+], function (Helper, Opa, Opa5, TestUtils, Press) {
+	"use strict";
+	var sListReport = "sap.ui.core.sample.odata.v4.DeepCreate.ListReport",
+		sObjectPage = "sap.ui.core.sample.odata.v4.DeepCreate.ObjectPage";
+
+	Opa5.createPageObjects({
+		onTheListReport : {
+			actions : {
+				pressCreate : function () {
+					Helper.pressButton(this, sListReport, "create");
+					if (TestUtils.isRealOData()) {
+						// remember created sales order for cleanup
+						this.waitFor({id : "objectPage",
+							success : function (oControl) {
+								var oCreated = oControl.getBindingContext();
+
+								oCreated.created().then(function () {
+									var aCreatedEntityPaths = Opa.getContext().aCreatedEntityPaths,
+										sPath = oCreated.getPath();
+
+									if (!aCreatedEntityPaths) {
+										Opa.getContext().aCreatedEntityPaths
+											= aCreatedEntityPaths = [];
+									}
+									aCreatedEntityPaths.push(sPath);
+									Opa5.assert.ok(true, "Remembered SalesOrder: " + sPath);
+								}, function () { /* ignore */ });
+							},
+							viewName : sObjectPage});
+					}
+				}
+			}
+		},
+		onTheObjectPage : {
+			actions : {
+				changeNote : function (sNote) {
+					Helper.changeInputValue(this, sObjectPage, "SalesOrder::note", sNote);
+				},
+				pressCreateLineItem : function () {
+					Helper.pressButton(this, sObjectPage, "createLineItem");
+				},
+				pressDeleteSelectedLineItems : function () {
+					Helper.pressButton(this, sObjectPage, "deleteLineItem");
+				},
+				pressResetChanges : function () {
+					Helper.pressButton(this, sObjectPage, "resetChanges");
+				},
+				pressSave : function () {
+					Helper.pressButton(this, sObjectPage, "save");
+				},
+				pressValueHelpOnProductID : function (iRow) {
+					this.waitFor({
+						actions : function (oControl) {
+							new Press().executeOn(oControl.getAggregation("field"));
+						},
+						matchers : function (oControl) {
+							return oControl.getBindingContext().getIndex() === iRow;
+						},
+						controlType : "sap.ui.core.sample.common.ValueHelp",
+						id : /SO_2_SOITEM:ProductID/,
+						success : function (oControls) {
+							Opa5.assert.ok(true, "ValueHelp pressed: " + oControls[0].getValue());
+						},
+						viewName : sObjectPage
+					});
+				},
+				selectLineItem : function (iRow) {
+					this.waitFor({
+						actions : new Press(),
+						controlType : "sap.m.CheckBox",
+						id : /selectMulti/,
+						matchers : function (oControl) {
+							return oControl.getBindingContext().getIndex() === iRow;
+						},
+						success : function (aControls) {
+							aControls.forEach(function (oControl) {
+								Opa5.assert.ok(true, "Item selected: "
+									+ oControl.getBindingContext());
+							});
+						},
+						viewName : sObjectPage
+					});
+				}
+			},
+			assertions : {
+				checkGrossAmount : function (sGrossAmount) {
+					Helper.checkInputValue(this, sObjectPage, "SalesOrder::grossAmount",
+						sGrossAmount);
+				},
+				checkSalesOrderID : function (sSalesOrderID) {
+					Helper.checkInputValue(this, sObjectPage, "SalesOrder::id", sSalesOrderID);
+				},
+				checkSalesOrderItemsCount : function (iCount) {
+					Helper.waitForSortedByID(this, {
+						id : /SO_2_SOITEM-trigger|lineItemsTitle/,
+						success : function (aControls) {
+							if (aControls.length === 2) {
+								Helper.checkMoreButtonCount(aControls.shift(),
+									"[5/" + iCount + "]");
+							}
+							Opa5.assert.strictEqual(aControls[0].getText(),
+								iCount + " Sales Order Line Items", "Count in title is " + iCount);
+						},
+						viewName : sObjectPage
+					});
+				}
+			}
+		}
+	});
+});

package/test/sap/ui/core/demokit/sample/odata/v4/MultipleInlineCreationRowsGrid/pages/Main.js

@@ -104,47 +104,6 @@ sap.ui.define([
 				}
 			}
 		},
-		onTheMessagePopover : {
-			actions : {
-				close : function () {
-					this.waitFor({
-						actions : function (oMessagePopover) {
-							oMessagePopover.close();
-						},
-						controlType : "sap.m.MessagePopover",
-						success : function (aControls) {
-							Opa5.assert.strictEqual(aControls.length, 1, "Message Popover closed");
-						}
-					});
-				}
-			}, assertions : {
-				checkMessages : function (aExpectedMessages) {
-					this.waitFor({
-						controlType : "sap.m.MessagePopover",
-						success : function (aMessagePopover) {
-							var iExpectedCount = aExpectedMessages.length,
-								aItems = aMessagePopover[0].getItems();
-
-							Opa5.assert.ok(aMessagePopover.length === 1);
-							Opa5.assert.strictEqual(aItems.length, iExpectedCount,
-								"Check Messages: message count is as expected: " + iExpectedCount
-							);
-							aExpectedMessages.forEach(function (oExpectedMessage, i) {
-								var bFound;
-
-								bFound = aItems.some(function (oItem) {
-									return oItem.getTitle() === oExpectedMessage.message
-										&& oItem.getType() === oExpectedMessage.type;
-								});
-								Opa5.assert.ok(bFound, "Check Messages: expected message[" + i
-									+ "]: " + oExpectedMessage.message + " type: "
-									+ oExpectedMessage.type);
-							});
-						}
-					});
-				}
-			}
-		},
 		onTheObjectPage : {
 			actions : {
 				confirmDeletion : function () {

package/test/sap/ui/core/demokit/sample/odata/v4/SalesOrderTP100_V2/manifest.json

@@ -39,7 +39,7 @@
 					"Main.view.xml",
 					"manifest.json",
 					"SandboxModel.js",
-					"../../../common/Helper",
+					"../../../common/Helper.js",
 					"../../../common/SandboxModelHelper.js"
 				]
 			}

package/test/sap/ui/core/demokit/sample/odata/v4/SalesOrderTP100_V4/manifest.json

@@ -39,7 +39,7 @@
 					"Main.view.xml",
 					"manifest.json",
 					"SandboxModel.js",
-					"../../../common/Helper",
+					"../../../common/Helper.js",
 					"../../../common/SandboxModelHelper.js"
 				]
 			}

package/test/sap/ui/core/demokit/sample/odata/v4/SalesOrders/Main.controller.js

@@ -154,7 +154,6 @@ sap.ui.define([
 					+ ", " + oContext.getProperty("SO_2_BP/CompanyName"));
 			}).catch(function (oError) {
 				if (!oError.canceled) {
-					MessageBox.error("" + oError);
 					throw oError; // unexpected error
 				}
 			});
@@ -274,7 +273,7 @@ sap.ui.define([
 			this.setSalesOrderBindingContext(null); // hide the object page
 			this.aDeletedSalesOrders.push(oContext);
 			this.updateUndoButton();
-			oContext.delete().catch(function (oError) {
+			oContext.delete().catch(function () { // canceled or error already reported
 				var oItem;
 
 				if (!oSalesOrderTable.getSelectedItem()) {
@@ -286,10 +285,6 @@ sap.ui.define([
 						that.setSalesOrderBindingContext(oContext); // show the object page again
 					}
 				}
-				if (!oError.canceled) {
-					MessageToast.show("Could not delete sales order "
-						+ oContext.getProperty("SalesOrderID"));
-				}
 			}).finally(function () {
 				that.aDeletedSalesOrders.splice(that.aDeletedSalesOrders.indexOf(oContext), 1);
 				that.updateUndoButton();
@@ -297,15 +292,8 @@ sap.ui.define([
 		},
 
 		onDeleteSalesOrderLineItem : function () {
-			var oContext = this.byId("SO_2_SOITEM").getSelectedItem().getBindingContext();
-
-			oContext.delete().catch(function (oError) {
-				if (!oError.canceled) {
-					MessageToast.show("Could not delete line item "
-						+ oContext.getProperty("ItemPosition") + " of sales order "
-						+ oContext.getProperty("SalesOrderID"));
-				}
-			});
+			this.byId("SO_2_SOITEM").getSelectedItem().getBindingContext().delete()
+				.catch(function () { /* canceled or error already reported */ });
 		},
 
 		onDeleteSalesOrderSchedules : function () {
@@ -328,13 +316,13 @@ sap.ui.define([
 			// removing schedule(s) implicitly removes items
 			// -> remove context of dependent bindings and hide details
 			this.setSalesOrderLineItemBindingContext();
-			this.requestSideEffects(sGroupId, "SO_2_SOITEM");
+			aPromises.push(this.requestSideEffects(sGroupId, "SO_2_SOITEM"));
 
 			Promise.all(aPromises).then(function () {
 				oTable.removeSelections();
 				oUiModel.setProperty("/bScheduleSelected", false);
 				MessageBox.success("Deleted " + aPromises.length + " sales order schedule(s)");
-			});
+			}, function () { /* error already reported */ });
 		},
 
 		onExecuteSimulateDiscount : function () {

package/test/sap/ui/core/demokit/sample/odata/v4/ServerDrivenPaging/Main.view.xml

@@ -6,7 +6,7 @@
 	xmlns:mvc="sap.ui.core.mvc">
 	<IconTabBar select=".onTabSelect">
 		<items>
-			<IconTabFilter id="list" text="m.Table">
+			<IconTabFilter id="list" key="m" text="m.Table">
 				<Table id="businessPartnerList" growing="true" growingThreshold="21">
 					<headerToolbar>
 						<Toolbar>
@@ -27,7 +27,7 @@
 					</columns>
 				</Table>
 			</IconTabFilter>
-			<IconTabFilter id="table" text="table.Table">
+			<IconTabFilter id="table" key="table" text="table.Table">
 				<t:Table ariaLabelledBy="title" id="businessPartnerTable" selectionMode="None"
 						visibleRowCount="21">
 					<t:extension>
@@ -55,4 +55,4 @@
 			</IconTabFilter>
 		</items>
 	</IconTabBar>
-</mvc:View>
+</mvc:View>

package/test/sap/ui/core/demokit/tutorial/odatav4/08/webapp/test/integration/arrangements/Startup.js

@@ -17,7 +17,7 @@ sap.ui.define([
 					async : true
 				},
 				autoWait : true,
-				timeout : 30 // BCP: 2270085466
+				timeout : 45 // BCP: 2270085466
 			});
 		}
 	});

package/test/sap/ui/core/demokit/tutorial/odatav4/11/webapp/test/integration/arrangements/Startup.js

@@ -17,7 +17,7 @@ sap.ui.define([
 					async : true
 				},
 				autoWait : true,
-				timeout : 30 // BCP: 2270085466
+				timeout : 45 // BCP: 2270085466
 			});
 		}
 	});

package/test/sap/ui/core/qunit/CompositeBinding.qunit.js

@@ -16,11 +16,10 @@ sap.ui.define([
 	"sap/ui/model/type/Date",
 	"sap/ui/model/type/Float",
 	"sap/ui/model/type/Integer",
-	"sap/ui/model/type/String",
-	"sap/ui/test/TestUtils"
+	"sap/ui/model/type/String"
 ], function (Log, deepEqual, Configuration, UI5Date, BindingMode, CompositeBinding, CompositeType,
 		Context, ParseException, PropertyBinding, StaticBinding, ValidateException, JSONModel,
-		TypeDate, TypeFloat, TypeInteger, TypeString, TestUtils
+		TypeDate, TypeFloat, TypeInteger, TypeString
 ) {
 	"use strict";
 
@@ -255,6 +254,28 @@ sap.ui.define([
 		this.composite.resume();
 	});
 
+	//**********************************************************************************************
+	QUnit.test("constructor", function (assert) {
+		var aBindings = [],
+			oBinding = new CompositeBinding(aBindings, "~bRawValues", "~bInternalValues");
+
+		// CompositeBinding has its own #getModel and #getPath methods always returning null; values passed to the base
+		// class constructor are not used there
+		assert.strictEqual(oBinding.oModel, null, "model passed to PropertyBinding c'tor");
+		assert.strictEqual(oBinding.sPath, "", "path passed to PropertyBinding c'tor");
+		assert.strictEqual(oBinding.aValues, null);
+		assert.strictEqual(oBinding.bRawValues, "~bRawValues");
+		assert.strictEqual(oBinding.bPreventUpdate, false);
+		assert.strictEqual(oBinding.bInternalValues, "~bInternalValues");
+		assert.ok(oBinding.hasOwnProperty("aOriginalValues"));
+		assert.strictEqual(oBinding.aOriginalValues, undefined);
+		assert.ok(oBinding.hasOwnProperty("fnChangeHandler"));
+		assert.strictEqual(oBinding.fnChangeHandler, undefined);
+		assert.ok(oBinding.hasOwnProperty("fnDataStateChangeHandler"));
+		assert.strictEqual(oBinding.fnDataStateChangeHandler, undefined);
+
+	});
+
 [{
 	aModels : [{}, null /*static binding*/],
 	bMultipleModels : false
@@ -268,7 +289,7 @@ sap.ui.define([
 	aModels : [{}], // same model
 	bMultipleModels : false
 }].forEach(function (oFixture, i) {
-	QUnit.test("Constructor, bMultipleModels, # " + i, function (assert) {
+	QUnit.test("constructor, bMultipleModels, # " + i, function (assert) {
 		var aBinding0 = {getModel : function () {}},
 			aBinding1 = {getModel : function () {}},
 			aModels = oFixture.aModels;
@@ -811,9 +832,6 @@ sap.ui.define([
 			this.oLogMock = this.mock(Log);
 			this.oLogMock.expects("error").never();
 			this.oLogMock.expects("warning").never();
-		},
-		afterEach : function (assert) {
-			return TestUtils.awaitRendering();
 		}
 	});
 

package/test/sap/ui/core/qunit/ControlRenderer.qunit.js

@@ -7,8 +7,9 @@ sap.ui.define([
 	"sap/ui/core/InvisibleText",
 	"sap/ui/core/EnabledPropagator",
 	"sap/ui/core/dnd/DragInfo",
-	"sap/ui/qunit/utils/createAndAppendDiv"
-], function(Core, Control, Element, Renderer, RenderManager, InvisibleText, EnabledPropagator, DragInfo, createAndAppendDiv) {
+	"sap/ui/qunit/utils/createAndAppendDiv",
+	"sap/ui/model/json/JSONModel"
+], function(Core, Control, Element, Renderer, RenderManager, InvisibleText, EnabledPropagator, DragInfo, createAndAppendDiv, JSONModel) {
 
 	"use strict";
 	/*global QUnit,sinon*/
@@ -1608,4 +1609,87 @@ sap.ui.define([
 		oParent.destroy();
 	});
 
+	QUnit.module("SupressInvalidate", {
+		before: function() {
+			this.oApiVerionStub = sinon.stub(PatchingControl.getMetadata().getRenderer(), "apiVersion").value(4);
+			this.oJSONModel = new JSONModel([{ header: "Header1"}, { header: "Header2"} ]);
+		},
+		beforeEach: function() {
+			this.oParent = new PatchingControl({
+				models: this.oJSONModel,
+				items: {
+					path: "/",
+					template: new PatchingControl({
+						header: "{header}"
+					})
+				}
+			});
+			this.oParent.placeAt("qunit-fixture");
+			Core.applyChanges();
+		},
+		afterEach: function() {
+			this.oParent.destroy();
+		},
+		after: function() {
+			this.oApiVerionStub.restore();
+			this.oJSONModel.destroy();
+		}
+	});
+
+	QUnit.test("Insert aggregation with bSupressInvalidate=true and binding propagation should be reflected in the child", function(assert) {
+		var oChild = this.oParent.getItems()[0];
+		var sId = oChild.getId();
+		this.oParent.destroyAggregation("items", "KeepDom");
+		assert.strictEqual(oChild.getDomRef().textContent, "Header1", "child dom is rendered correctly");
+
+		var oBinding = this.oParent.getBinding("items");
+		var oSecondContext = oBinding.getContexts(1, 1)[0];
+		var oNewChild = new PatchingControl(sId, {
+			header: "{header}"
+		}).setBindingContext(oSecondContext);
+
+		var oParentInvalidateSpy = sinon.spy(this.oParent, "invalidate");
+		var oNewChildInvalidateSpy = sinon.spy(oNewChild, "invalidate");
+		this.oParent.addAggregation("items", oNewChild, true);
+		assert.ok(oParentInvalidateSpy.notCalled, "Invalidate is not called on the parent");
+		assert.ok(oNewChildInvalidateSpy.calledOnce, "Invalidate is called for the header property change on the child");
+
+		this.oParent.invalidate();
+		Core.applyChanges();
+		assert.strictEqual(oNewChild.getDomRef().textContent, "Header2", "new child dom is rendered correctly");
+
+		oNewChildInvalidateSpy.restore();
+		oParentInvalidateSpy.restore();
+	});
+
+	QUnit.test("Move aggregation with bSupressInvalidate=true and rendering should start for the child only once", function(assert) {
+		var oAnotherParent = new PatchingControl({
+			models: this.oJSONModel,
+			items: {
+				path: "/",
+				template: new PatchingControl({
+					header: "{header}"
+				})
+			}
+		});
+		oAnotherParent.placeAt("qunit-fixture");
+		Core.applyChanges();
+
+		oAnotherParent.destroyItems();
+		Core.applyChanges();
+
+		var oBinding = this.oParent.getBinding("items");
+		var oSecondContext = oBinding.getContexts(1, 1)[0];
+		var oChild = this.oParent.getItems()[0];
+		oChild.setBindingContext(oSecondContext);
+
+		oChild.onAfterRendering = sinon.spy();
+		oAnotherParent.addAggregation("items", oChild, true);
+		oAnotherParent.invalidate();
+		Core.applyChanges();
+
+		assert.strictEqual(oChild.getDomRef().textContent, "Header2", "child dom is rendered correctly");
+		assert.ok(oChild.onAfterRendering.calledOnce, "oChild.onAfterRendering is called only once");
+	});
+
 });

package/test/sap/ui/core/qunit/DataState.qunit.js

@@ -2,9 +2,8 @@ sap.ui.define([
 	"sap/base/Log",
 	"sap/base/util/deepEqual",
 	"sap/ui/core/message/Message",
-	"sap/ui/model/DataState",
-	"sap/ui/test/TestUtils"
-], function (Log, deepEqual, Message, DataState, TestUtils) {
+	"sap/ui/model/DataState"
+], function (Log, deepEqual, Message, DataState) {
 	/*global QUnit*/
 	"use strict";
 
@@ -14,10 +13,6 @@ sap.ui.define([
 			this.oLogMock = this.mock(Log);
 			this.oLogMock.expects("error").never();
 			this.oLogMock.expects("warning").never();
-		},
-
-		afterEach : function (assert) {
-			return TestUtils.awaitRendering();
 		}
 	});