@openui5/sap.ui.core 1.107.0 → 1.108.0

package/src/sap/ui/model/odata/v4/ODataParentBinding.js

@@ -342,7 +342,9 @@ sap.ui.define([
 	 *   are ignored if they relate to a
 	 *   {@link sap.ui.model.odata.v4.Context#isKeepAlive kept-alive} context of this binding.
 	 *   Since 1.98.0, {@link sap.ui.model.odata.v4.Context#isTransient transient} contexts
-	 *   of a {@link #getRootBinding root binding} do not count as pending changes.
+	 *   of a {@link #getRootBinding root binding} do not count as pending changes. Since 1.108.0,
+	 *   {@link sap.ui.model.odata.v4.Context#delete deleted} contexts do not count as pending
+	 *   changes.
 	 *
 	 * @public
 	 * @since 1.45.0
@@ -601,7 +603,7 @@ sap.ui.define([
 	 *   A lock for the group ID to be used for the DELETE request; w/o a lock, no DELETE is sent.
 	 *   For a transient entity, the lock is ignored (use NULL)!
 	 * @param {string} sEditUrl
-	 *   The entity's edit URL to be used for the DELETE request;  w/o a lock, this is mostly
+	 *   The entity's edit URL to be used for the DELETE request; w/o a lock, this is mostly
 	 *   ignored.
 	 * @param {string} sPath
 	 *   The path of the entity relative to this binding
@@ -609,10 +611,6 @@ sap.ui.define([
 	 *   An entity with the ETag of the binding for which the deletion was requested. This is
 	 *   provided if the deletion is delegated from a context binding with empty path to a list
 	 *   binding. W/o a lock, this is ignored.
-	 * @param {boolean} [bDoNotRequestCount]
-	 *   Whether not to request the new count from the server; useful in case of
-	 *   {@link sap.ui.model.odata.v4.Context#replaceWith} where it is known that the count remains
-	 *   unchanged; only relevant for the list binding
 	 * @param {function} [fnCallback]
 	 *  A function which is called immediately when an entity has been deleted from the cache, or
 	 *   when it was re-inserted due to an error; only used in the list binding; the index of the
@@ -627,10 +625,9 @@ sap.ui.define([
 	 * @private
 	 */
 	ODataParentBinding.prototype.deleteFromCache = function (oGroupLock, sEditUrl, sPath,
-			oETagEntity, bDoNotRequestCount, fnCallback) {
+			oETagEntity, fnCallback) {
 		return this.withCache(function (oCache, sCachePath) {
-			return oCache._delete(oGroupLock, sEditUrl, sCachePath, oETagEntity, bDoNotRequestCount,
-				fnCallback);
+			return oCache._delete(oGroupLock, sEditUrl, sCachePath, oETagEntity, fnCallback);
 		}, sPath, /*bSync*/true);
 	};
 
@@ -1097,7 +1094,7 @@ sap.ui.define([
 	 * Whether the dataRequested and dataReceived events related to the refresh must not be bubbled
 	 * up to the model.
 	 *
-	 * @returns {boolean}  Whether to prevent bubbling
+	 * @returns {boolean} Whether to prevent bubbling
 	 *
 	 * @private
 	 * @see #createRefreshPromise
@@ -1301,10 +1298,10 @@ sap.ui.define([
 	 * @throws {Error}
 	 *   If this binding
 	 *   <ul>
-	 *   <li>is relative to a {@link sap.ui.model.odata.v4.Context},
-	 *   <li>is an operation binding,
-	 *   <li>has {@link sap.ui.model.Binding#isSuspended} set to <code>false</code>,
-	 *   <li>is not a root binding. Use {@link #getRootBinding} to determine the root binding.
+	 *     <li> is relative to a {@link sap.ui.model.odata.v4.Context},
+	 *     <li> is an operation binding,
+	 *     <li> has {@link sap.ui.model.Binding#isSuspended} set to <code>false</code>,
+	 *     <li> is not a root binding. Use {@link #getRootBinding} to determine the root binding.
 	 *   </ul>
 	 *
 	 * @public
@@ -1360,16 +1357,18 @@ sap.ui.define([
 	 * was not supported and threw an error. Since 1.97.0, pending changes are ignored if they
 	 * relate to a {@link sap.ui.model.odata.v4.Context#isKeepAlive kept-alive} context of this
 	 * binding. Since 1.98.0, {@link sap.ui.model.odata.v4.Context#isTransient transient} contexts
-	 * of a {@link #getRootBinding root binding} do not count as pending changes.
+	 * of a {@link #getRootBinding root binding} do not count as pending changes. Since 1.108.0
+	 * {@link sap.ui.model.odata.v4.Context#delete deleted} contexts do not count as pending
+	 * changes.
 	 *
 	 * @throws {Error}
 	 *   If this binding
 	 *   <ul>
-	 *   <li>is relative to a {@link sap.ui.model.odata.v4.Context},
-	 *   <li>is an operation binding,
-	 *   <li>has {@link sap.ui.model.Binding#isSuspended} set to <code>true</code>,
-	 *   <li>has pending changes that cannot be ignored,
-	 *   <li>is not a root binding. Use {@link #getRootBinding} to determine the root binding.
+	 *     <li> is relative to a {@link sap.ui.model.odata.v4.Context},
+	 *     <li> is an operation binding,
+	 *     <li> has {@link sap.ui.model.Binding#isSuspended} set to <code>true</code>,
+	 *     <li> has pending changes that cannot be ignored,
+	 *     <li> is not a root binding. Use {@link #getRootBinding} to determine the root binding.
 	 *   </ul>
 	 *
 	 * @public

package/src/sap/ui/model/odata/v4/ODataPropertyBinding.js

@@ -42,7 +42,7 @@ sap.ui.define([
 		 * @mixes sap.ui.model.odata.v4.ODataBinding
 		 * @public
 		 * @since 1.37.0
-		 * @version 1.107.0
+		 * @version 1.108.0
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getGroupId as #getGroupId
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getRootBinding as #getRootBinding
 		 * @borrows sap.ui.model.odata.v4.ODataBinding#getUpdateGroupId as #getUpdateGroupId
@@ -746,11 +746,11 @@ sap.ui.define([
 	 */
 	ODataPropertyBinding.prototype.setValue = function (vValue, sGroupId) {
 		var oGroupLock,
+			sResolvedPath = this.getResolvedPath(),
 			that = this;
 
 		function reportError(oError) {
-			that.oModel.reportError("Failed to update path " + that.getResolvedPath(), sClassName,
-				oError);
+			that.oModel.reportError("Failed to update path " + sResolvedPath, sClassName, oError);
 
 			return oError;
 		}

package/src/sap/ui/model/odata/v4/_AnnotationHelperExpression.js

@@ -105,7 +105,7 @@ sap.ui.define([
 		 *       <li> when "constant": {any} the constant value (not escaped if string)
 		 *       <li> when "expression": {string} the expression unwrapped (no "{=" and "}")
 		 *     </ul>
-		 *   <li> <code>type</code>:  the EDM data type (like "Edm.String") if it could be
+		 *   <li> <code>type</code>: the EDM data type (like "Edm.String") if it could be
 		 *      determined
 		 *   <li> <code>constraints</code>: {object} type constraints if result is "binding"
 		 *   <li> <code>formatOptions</code>: {object} format options if result is "binding"

package/src/sap/ui/model/odata/v4/lib/_AggregationCache.js

@@ -328,7 +328,7 @@ sap.ui.define([
 
 				if (sPredicate) {
 					that.aElements.$byPredicate[sPredicate] = oElement;
-					if (_Helper.getPrivateAnnotation(oElement, "expanding")) {
+					if (_Helper.hasPrivateAnnotation(oElement, "expanding")) {
 						_Helper.deletePrivateAnnotation(oElement, "expanding");
 						iCount += that.expand(_GroupLock.$cached, oElement).getResult();
 					}
@@ -476,7 +476,7 @@ sap.ui.define([
 		}
 
 		aAllElements = this.aElements.map(function (oElement) {
-			return _Helper.getPrivateAnnotation(oElement, "parent") ? undefined : oElement;
+			return _Helper.hasPrivateAnnotation(oElement, "parent") ? undefined : oElement;
 		});
 		aAllElements.$count = this.aElements.$count;
 
@@ -686,7 +686,7 @@ sap.ui.define([
 			for (i = iIndex, n = Math.min(iIndex + iLength, this.aElements.length); i < n; i += 1) {
 				oCurrentParent = _Helper.getPrivateAnnotation(this.aElements[i], "parent");
 				if (oCurrentParent !== oGapParent) {
-					if (iGapStart) { // end of gap
+					if (iGapStart !== undefined) { // end of gap
 						readGap(iGapStart, i);
 						oGapParent = iGapStart = undefined;
 					}
@@ -696,7 +696,7 @@ sap.ui.define([
 					}
 				}
 			}
-			if (iGapStart) { // gap at end
+			if (iGapStart !== undefined) { // gap at end
 				readGap(iGapStart, i);
 			}
 			oGroupLock.unlock();
@@ -895,7 +895,8 @@ sap.ui.define([
 	 *   are combined with min/max or with grouping via sorter, or if the system query options
 	 *   "$expand" or "$select" are combined with pure data aggregation (no recursive hierarchy), or
 	 *   if the system query option "$search" is combined with grand totals or group levels or a
-	 *   recursive hierarchy
+	 *   recursive hierarchy, or if shared requests are combined with min/max or with grand totals
+	 *   or group levels or recursive hierarchy
 	 *
 	 * @public
 	 */
@@ -926,6 +927,9 @@ sap.ui.define([
 				if (oAggregation.hierarchyQualifier) {
 					throw new Error("Unsupported recursive hierarchy together with min/max");
 				}
+				if (bSharedRequest) {
+					throw new Error("Unsupported $$sharedRequest together with min/max");
+				}
 				checkExpandSelect();
 
 				return _MinMaxHelper.createCache(oRequestor, sResourcePath, oAggregation,
@@ -948,6 +952,9 @@ sap.ui.define([
 				if (bIsGrouped) {
 					throw new Error("Unsupported grouping via sorter");
 				}
+				if (bSharedRequest) {
+					throw new Error("Unsupported $$sharedRequest");
+				}
 
 				return new _AggregationCache(oRequestor, sResourcePath, oAggregation, mQueryOptions,
 						bHasGrandTotal);