@openui5/sap.m 1.96.19 → 1.96.21

package/src/sap/m/GroupHeaderListItem.js

@@ -30,7 +30,7 @@ sap.ui.define(["sap/ui/core/library", "./library", "./ListItemBase", "./GroupHea
 	 * @extends sap.m.ListItemBase
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/GrowingEnablement.js

@@ -154,9 +154,7 @@ sap.ui.define([
 		},
 
 		onScrollToLoad: function() {
-			var oTriggerButton = this._oControl.getDomRef("triggerList");
-
-			if (this._bLoading || !oTriggerButton || oTriggerButton.style.display != "none") {
+			if (this._bLoading) {
 				return;
 			}
 
@@ -637,7 +635,7 @@ sap.ui.define([
 
 				// put the focus to the newly added item if growing button is pressed
 				if (oTriggerDomRef && oTriggerDomRef.contains(document.activeElement)) {
-					(aItems[this._iLastItemsCount] || oControl).focus();
+					(aItems[this._iLastItemsCount] || aItems[iItemsLength - 1] ||  oControl).focus();
 				}
 
 				// show, update or hide the growing button

package/src/sap/m/GrowingList.js

@@ -22,7 +22,7 @@ sap.ui.define(['./List', './library', './GrowingListRenderer'],
 	 * @extends sap.m.List
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/HBox.js

@@ -25,7 +25,7 @@ sap.ui.define(['./FlexBox', './library', './HBoxRenderer'],
 	 * @extends sap.m.FlexBox
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/HeaderContainer.js

@@ -124,7 +124,7 @@ sap.ui.define([
 		 * @since 1.44.0
 		 *
 		 * @author SAP SE
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @public
 		 * @alias sap.m.HeaderContainer

package/src/sap/m/HeaderContainerItemNavigator.js

@@ -19,7 +19,7 @@ sap.ui.define([
 	 * @since 1.67.0
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @alias sap.m.HeaderContainerItemNavigator

package/src/sap/m/IconTabBar.js

@@ -94,7 +94,7 @@ sap.ui.define([
 	 * @implements sap.m.ObjectHeaderContainer, sap.f.IDynamicPageStickyContent
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @public
 	 * @alias sap.m.IconTabBar

package/src/sap/m/IconTabBarSelectList.js

@@ -40,7 +40,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @private

package/src/sap/m/IconTabFilter.js

@@ -94,7 +94,7 @@ sap.ui.define([
 	 * @implements sap.m.IconTab
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/IconTabFilterExpandButtonBadge.js

@@ -31,7 +31,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @private

package/src/sap/m/IconTabHeader.js

@@ -77,7 +77,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/IconTabSeparator.js

@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @implements sap.m.IconTab
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/Image.js

@@ -57,7 +57,7 @@ sap.ui.define([
 	 * @implements sap.ui.core.IFormContent
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @public
 	 * @alias sap.m.Image

package/src/sap/m/ImageContent.js

@@ -33,7 +33,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 * @since 1.38
 	 *
 	 * @public

package/src/sap/m/Input.js

@@ -159,7 +159,7 @@ function(
 	 *
 	 * @extends sap.m.InputBase
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public
@@ -1466,7 +1466,7 @@ function(
 
 		this.bValueHelpRequested = false;
 
-		if (!this._sProposedItemText || this.isMobileDevice()) {
+		if (!this._getProposedItemText() || this.isMobileDevice()) {
 			return;
 		}
 
@@ -1481,7 +1481,7 @@ function(
 			// but there is a proposed item due to the typeahead
 			var oSelectedItem = this.getSuggestionItems()
 				.filter(function (oItem) {
-					return oItem.getText() === this._sProposedItemText;
+					return oItem.getText() === this._getProposedItemText();
 				}.bind(this))[0];
 
 			if (oSelectedItem) {
@@ -1550,8 +1550,7 @@ function(
 	};
 
 	/**
-	 * Updates the selection, when the picker is closed and the suggestions selection
-	 * was updated, while navigating.
+	 * Updates the selection, when the picker closes and there is selected item/row in the list/table.
 	 *
 	 * @param {sap.m.StandardListItem | sap.m.ColumnListItem | sap.m.GroupHeaderListItem} oSelectedItem The selected from navigation item
 	 * @private
@@ -1782,10 +1781,21 @@ function(
 	Input.prototype.onkeyup = function (oEvent) {
 		var sValue = this.getValue();
 		var sLastValue = this.getLastValue();
+		var bIsNavigationKey = (oEvent.which === KeyCodes.ARROW_DOWN) || (oEvent.which === KeyCodes.ARROW_UP);
+		var oSuggestionsPopover, oItemsContainer, oSelectedItem;
 
-		if ([KeyCodes.BACKSPACE, KeyCodes.DELETE].indexOf(oEvent.which) !== -1 && !sValue) {
+		if (!this._bDoTypeAhead && !sValue) {
 			this.getShowSuggestion() && this.setSelectedKey(null);
 			(sLastValue !== sValue) && this.setLastValue(sLastValue);
+		} else if (!this._bDoTypeAhead && !bIsNavigationKey && sValue) {
+			oSuggestionsPopover = this.getShowSuggestion() && this._getSuggestionsPopover();
+			oItemsContainer = oSuggestionsPopover && oSuggestionsPopover.getItemsContainer();
+			oSelectedItem = oItemsContainer && oItemsContainer.getSelectedItem();
+
+			this._setProposedItemText(null);
+			if (oSelectedItem) {
+				oSelectedItem.setSelected(false);
+			}
 		}
 
 		this.getShowClearIcon() && this.setProperty("effectiveShowClearIcon", !!sValue);
@@ -2133,19 +2143,24 @@ function(
 	/**
 	 * Handles Input's specific type ahead logic.
 	 *
-	 * @param oInput {sap.m.Input} Input's instance to which the type ahead would be applied. For example: this OR Dialog's Input instance.
+	 * @param {sap.m.Input} oInput Input's instance to which the type ahead would be applied. For example: this OR Dialog's Input instance.
+	 * @returns {null|object} Map object containing type-ahead info or null if no type-ahead is performed.
 	 * @private
 	 */
 	Input.prototype._handleTypeAhead = function (oInput) {
 		var sValue = this.getValue();
+		var mTypeAheadInfo = {
+			value: "",
+			selectedItem: null
+		};
 
 		// check if typeahead is already performed
-		if ((oInput && oInput.getValue().toLowerCase()) === (this._sProposedItemText && this._sProposedItemText.toLowerCase())) {
+		if ((oInput && oInput.getValue().toLowerCase()) === (this._getProposedItemText() && this._getProposedItemText().toLowerCase())) {
 			return;
 		}
 
 		this._setTypedInValue(sValue);
-		oInput._sProposedItemText = null;
+		oInput._setProposedItemText(null);
 
 		if (!this._bDoTypeAhead || sValue === "" ||
 			sValue.length < this.getStartSuggestion() || document.activeElement !== this.getFocusDomRef()) {
@@ -2166,7 +2181,12 @@ function(
 			return this._formatTypedAheadValue(fnExtractText(oItem));
 		}.bind(this));
 
-		oInput._sProposedItemText = fnExtractText(aItemsToSelect[0]);
+		mTypeAheadInfo.value = fnExtractText(aItemsToSelect[0]);
+		mTypeAheadInfo.selectedItem = aItemsToSelect[0];
+
+		oInput._setProposedItemText(mTypeAheadInfo.value);
+
+		return mTypeAheadInfo;
 	};
 
 	/**
@@ -2178,7 +2198,7 @@ function(
 	Input.prototype._resetTypeAhead = function (oInput) {
 		oInput = oInput || this;
 
-		oInput._sProposedItemText = null;
+		oInput._setProposedItemText(null);
 		this._setTypedInValue('');
 	};
 
@@ -2774,7 +2794,7 @@ function(
 
 		oInput.addEventDelegate({
 			onsapenter: function () {
-				this.setValue(this._sProposedItemText);
+				this.setValue(this._getProposedItemText());
 			}
 		}, this);
 
@@ -2894,7 +2914,25 @@ function(
 		}, this);
 
 		oPopover.attachAfterOpen(function () {
-			this._handleTypeAhead(this);
+			var mTypeAheadInfo;
+			var oSuggPopover = this.getShowSuggestion() && this._getSuggestionsPopover();
+			var oList = oSuggPopover && oSuggPopover.getItemsContainer();
+			var oItemToBeSelected;
+
+			mTypeAheadInfo = this._handleTypeAhead(this);
+
+			// In case the items were provided on a later stage and the type-ahead was called
+			// when the items were refreshed, there will be no selected item / row in the list,
+			// no matter that we use the first matching item to auto-complete the user's input.
+			// This will, later on, result in no item being added in the selectedItem/Row association.
+			// Here we need to make sure that the first item (which's text was already used) is indeed selected.
+			if (!(this._getProposedItemText() && oList && !oList.getSelectedItem() && mTypeAheadInfo && mTypeAheadInfo.selectedItem)) {
+				return;
+			}
+
+			oItemToBeSelected = this._hasTabularSuggestions() ? mTypeAheadInfo.selectedItem : ListHelpers.getListItem(mTypeAheadInfo.selectedItem);
+			oItemToBeSelected.setSelected(true);
+			this.setSelectionUpdatedFromList(true);
 		}, this);
 
 		if (this.isMobileDevice()) {
@@ -3217,7 +3255,10 @@ function(
 				oTabularRow.setVisible(bShowItem);
 				bShowItem && aFilteredItems.push(oTabularRow);
 
-				if (!bIsAnySuggestionAlreadySelected && bShowItem && this._sProposedItemText === this._getRowResultFunction()(oTabularRow)) {
+				if (!bIsAnySuggestionAlreadySelected && bShowItem && this._getProposedItemText() === this._getRowResultFunction()(oTabularRow)) {
+					// Setting the row to selected only works in case the items were there prior the user's input
+					// as otherwise there will be no proposed text.
+					// In case the items became available on a later stage, the typeahead functionality will set the selected row.
 					oTabularRow.setSelected(true);
 					bIsAnySuggestionAlreadySelected = true;
 				}
@@ -3264,7 +3305,10 @@ function(
 				oListItem = ListHelpers.createListItemFromCoreItem(oItem, true);
 				oList.addItem(oListItem);
 
-				if (!bIsAnySuggestionAlreadySelected && this._sProposedItemText === oItem.getText()) {
+				if (!bIsAnySuggestionAlreadySelected && this._getProposedItemText() === oItem.getText()) {
+					// Setting the item to selected only works in case the items were there prior the user's input
+					// as otherwise there will be no proposed text.
+					// In case the items became available on a later stage, the typeahead functionality will set the selected item.
 					oListItem.setSelected(true);
 					bIsAnySuggestionAlreadySelected = true;
 				}
@@ -3319,6 +3363,27 @@ function(
 		return true;
 	};
 
+	/**
+	 * Setter for the _sProposedItemText property, representing the text extracted from the proposed item/row.
+	 *
+	 * @private
+	 * @param {string} sProposedText The new proposed text, extracted from the item/row.
+	 * @returns {this} <code>this</code> to allow method chaining.
+	 */
+	Input.prototype._setProposedItemText = function (sProposedText) {
+		this._sProposedItemText = sProposedText;
+		return this;
+	};
+
+	/**
+	 * Getter for the _sProposedItemText property representing the text extracted from the proposed item/row.
+	 *
+	 * @private
+	 * @returns {string} The text extracted from the proposed item/row.
+	 */
+	Input.prototype._getProposedItemText = function () {
+		return this._sProposedItemText;
+	};
 
 	return Input;
 

package/src/sap/m/InputBase.js

@@ -64,7 +64,7 @@ function(
 	 * @implements sap.ui.core.IFormContent
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/InputListItem.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @extends sap.m.ListItemBase
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/Label.js

@@ -76,7 +76,7 @@ function(
 	 * @implements sap.ui.core.Label, sap.ui.core.IShrinkable
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/LightBox.js

@@ -99,7 +99,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/LightBoxItem.js

@@ -43,7 +43,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Element
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/Link.js

@@ -81,7 +81,7 @@ function(
 	 * @implements sap.ui.core.IShrinkable, sap.ui.core.IFormContent, sap.ui.core.ITitleContent
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public
@@ -253,14 +253,6 @@ function(
 	 */
 	Link.prototype.onBeforeRendering = function() {};
 
-	Link.prototype.onAfterRendering = function() {
-		var oAnchorRef = this.getDomRef();
-		// TODO: Adjust sap.m.internal.ObjectMarkerCustomLink rendering part of the sap.m.ObjectMarker implementation
-		if (oAnchorRef && oAnchorRef.getAttribute("href") == "#") {
-			oAnchorRef.onclick = function() { return false; };
-		}
-	};
-
 	/**
 	 * Handle the key down event for SPACE
 	 * SHIFT or ESCAPE on pressed SPACE cancels the action
@@ -327,11 +319,15 @@ function(
 	 * @private
 	 */
 	Link.prototype._handlePress = function(oEvent) {
+		var oTarget = oEvent.target,
+			bEmptyHref;
+
 		if (this.getEnabled()) {
 			// mark the event for components that needs to know if the event was handled by the link
 			oEvent.setMarked();
 
-			if (!this.firePress({ctrlKey: !!oEvent.ctrlKey, metaKey: !!oEvent.metaKey})) { // fire event and check return value whether default action should be prevented
+			bEmptyHref = oTarget.classList.contains("sapMLnk") && oTarget.getAttribute("href") == "#";
+			if (!this.firePress({ctrlKey: !!oEvent.ctrlKey, metaKey: !!oEvent.metaKey}) || bEmptyHref) { // fire event and check return value whether default action should be prevented
 				oEvent.preventDefault();
 			}
 		} else { // disabled
@@ -346,12 +342,7 @@ function(
 	 * @private
 	 */
 	Link.prototype.onsapenter = Link.prototype._handlePress;
-
-	if (Device.support.touch) {
-		Link.prototype.ontap = Link.prototype._handlePress;
-	} else {
-		Link.prototype.onclick = Link.prototype._handlePress;
-	}
+	Link.prototype.onclick = Link.prototype._handlePress;
 
 	/**
 	 * Handles the touch event on mobile devices.

package/src/sap/m/List.js

@@ -30,7 +30,7 @@ sap.ui.define(["./library", "./ListBase", "./ListRenderer"],
 	 * @extends sap.m.ListBase
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/ListBase.js

@@ -90,7 +90,7 @@ function(
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/ListItemBase.js

@@ -76,7 +76,7 @@ function(
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/MaskEnabler.js

@@ -26,7 +26,7 @@ sap.ui.define([
 	 * Applies mask support for input controls.
 	 * It should should be applied to the prototype of a <code>sap.m.InputBase</code>.
 	 *
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 * @private
 	 * @mixin
 	 * @alias sap.m.MaskEnabler

package/src/sap/m/MaskInput.js

@@ -21,7 +21,7 @@ sap.ui.define(['./InputBase', './MaskEnabler', './MaskInputRenderer'], function(
 	 *
 	 * @author SAP SE
 	 * @extends sap.m.InputBase
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/MaskInputRule.js

@@ -20,7 +20,7 @@ sap.ui.define(['sap/ui/core/Element', "sap/base/Log"], function(Element, Log) {
 	 *
 	 * @author SAP SE
 	 * @extends sap.ui.core.Element
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 * @public
 	 * @constructor
 	 * @since 1.34.0

package/src/sap/m/Menu.js

@@ -68,7 +68,7 @@ sap.ui.define([
 		 * @implements sap.ui.core.IContextMenu
 		 *
 		 * @author SAP SE
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/MenuButton.js

@@ -58,7 +58,7 @@ sap.ui.define([
 		 * @extends sap.ui.core.Control
 		 *
 		 * @author SAP SE
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/MenuItem.js

@@ -23,7 +23,7 @@ sap.ui.define(['./library', 'sap/ui/core/Item', 'sap/ui/base/ManagedObjectObserv
 		 * @extends sap.ui.core.Item
 		 *
 		 * @author SAP SE
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/MenuListItem.js

@@ -32,7 +32,7 @@ sap.ui.define([
 		 * @extends sap.m.ListItemBase
 		 *
 		 * @author SAP SE
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @constructor
 		 * @private

package/src/sap/m/MessageItem.js

@@ -37,7 +37,7 @@ sap.ui.define([
 		 *
 		 * @extends sap.ui.core.Item
 		 * @author SAP SE
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/MessageListItem.js

@@ -33,7 +33,7 @@ sap.ui.define([
 		 * @extends sap.m.StandardListItem
 		 *
 		 * @author SAP SE
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @constructor
 		 * @private

package/src/sap/m/MessagePage.js

@@ -69,7 +69,7 @@ sap.ui.define([
 		 * @see {@link fiori:https://experience.sap.com/fiori-design-web/message-page/ Message Page}
 		 *
 		 * @extends sap.ui.core.Control
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/MessagePopover.js

@@ -91,7 +91,7 @@ function(
 		 * @extends sap.ui.core.Control
 		 *
 		 * @author SAP SE
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/MessagePopoverItem.js

@@ -19,7 +19,7 @@ sap.ui.define(["./library", "./MessageItem"],
 		 * @extends sap.m.MessageItem
 		 *
 		 * @author SAP SE
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/MessageStrip.js

@@ -83,7 +83,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/MessageToast.js

@@ -70,7 +70,7 @@ sap.ui.define([
 		 * The message toast has the same behavior on all devices. However, you can adjust the width of the control, for example, for use on a desktop device.
 		 *
 		 * @author SAP SE
-		 * @version 1.96.19
+		 * @version 1.96.21
 		 *
 		 * @namespace
 		 * @public

package/src/sap/m/MessageView.js

@@ -112,7 +112,7 @@ sap.ui.define([
 	 * The responsiveness of the <code>MessageView</code> is determined by the container in which it is embedded. For that reason the control could not be visualized if the
 	 * container’s sizes are not defined.
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @extends sap.ui.core.Control
 	 * @constructor

package/src/sap/m/MultiComboBox.js

@@ -159,7 +159,7 @@ function(
 	 * </ul>
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 *
 	 * @constructor
 	 * @extends sap.m.ComboBoxBase

package/src/sap/m/MultiEditField.js

@@ -17,7 +17,7 @@ sap.ui.define(["sap/ui/core/XMLComposite", "./library", "sap/ui/core/Item"], fun
 	 * @implements sap.ui.core.IFormContent
 	 *
 	 * @author SAP SE
-	 * @version 1.96.19
+	 * @version 1.96.21
 	 * @experimental since 1.52
 	 * @since 1.52.0
 	 * @alias sap.m.MultiEditField