@openui5/sap.m 1.139.0 → 1.141.0

package/src/sap/m/PDFViewer.js

@@ -45,7 +45,7 @@ sap.ui.define([
 		 * @extends sap.ui.core.Control
 		 *
 		 * @author SAP SE
-		 * @version 1.139.0
+		 * @version 1.141.0
 		 * @since 1.48
 		 *
 		 * @constructor
@@ -180,6 +180,11 @@ sap.ui.define([
 						 * domain.
 						 * If you want no error message to be displayed when this event is fired, call the
 						 * preventDefault() method inside the event handler.
+						 *
+						 * Modern browsers implement strict policies for validating external resources loaded within an iframe.
+						 * PDFViewer cannot determine whether the resource inside the iframe is a valid PDF by itself.
+						 * As the validation cannot be performed the sourceValidationFailed event cannot be triggered.
+						 * @deprecated As of version 1.141.0 with no replacement.
 						 */
 						sourceValidationFailed: {}
 					}
@@ -326,159 +331,50 @@ sap.ui.define([
 		};
 
 		/**
-		 * @param {string} [src] - url of pdf
-		 * @param {string} [method] - GET or HEAD mothod
-		 * @returns - content-type header from the response header
-		 * @description - this method fetches response headers from server to validate content-type.
 		 * @private
+		 * Handles the iframe load event for PDFViewer.
+		 * - Checks if PDF plugin is enabled, fires error if not.
+		 * - Tries to access children of the iframe document body.
+		 * - If children exist, checks for embed tag to validate PDF rendering.
+		 * - Fires loaded event if valid, error event otherwise.
+		 * - Catches and logs any unexpected errors, fires error event in such cases.
 		 */
-		PDFViewer.prototype._getHeaderInfo = function (src, sMethod) {
-			if (window.fetch) {
-				// Trigger fetch call to retrieve the content-type header for the given PDF
-				return window.fetch(src, { method: sMethod })
-					.then(function(response) {
-						if (response.status === 200) {
-							// If the HEAD request is successful, return the content-type header
-							return response.headers.get("content-type");
-						} else if (response.status === 404) {
-							// If the HEAD request fails to fetch the content defined in source, an error event is triggered and LoadingError IllustratedMessage is displayed.
-							var error = new Error("Error fetching header: " + response.statusText);
-							error.status = response.status;
-							throw error;
-						} else {
-							// If the HEAD request fails for any other reason, throw an error
-							var error = new Error("Error in fetching header with method " + sMethod + ", status " + response.status + ", statusText " + response.statusText);
-							error.status = response.status;
-							throw error;
-						}
-					});
-			} else {
-				return new Promise(function(resolve, reject) {
-					var oXMLHttpRequest = new window.XMLHttpRequest();
-					oXMLHttpRequest.open(sMethod, src, false);
-					oXMLHttpRequest.onload = function() {
-						var sStatus = oXMLHttpRequest.status;
-						if (sStatus === 200) {
-							var response = oXMLHttpRequest.getAllResponseHeaders().toLowerCase().trim();
-							var items = response.split("\n");
-							var responseHeader = [];
-							for (var i = 0; i < items.length; i++) {
-								var parts = items[i].split(': ');
-								responseHeader[parts[0].trim()] = parts[1].trim();
-							}
-							resolve(responseHeader['content-type']);
-						} else if (sStatus === 404) {
-							// If the HEAD request fails to fetch the content defined in source, an error event is triggered and LoadingError IllustratedMessage is displayed.
-							var error = new Error("Error fetching header: " + oXMLHttpRequest.statusText);
-							error.status = oXMLHttpRequest.status;
-							reject(error);
-						} else {
-							var error = new Error("Error in fetching header with method " + sMethod + ", status " + oXMLHttpRequest.status + " and statusText " + oXMLHttpRequest.statusText);
-							error.status = oXMLHttpRequest.status;
-							reject(error);
-						}
-					};
-					oXMLHttpRequest.onerror = function(error) {
-						var error = new Error("Error in fetching header with method " + sMethod + ", status " + oXMLHttpRequest.status + " and statusText " + oXMLHttpRequest.statusText);
-						error.status = oXMLHttpRequest.status;
-						reject(error);
-					};
-					oXMLHttpRequest.send(null);
-				});
-			}
-		};
-
-		/**
-		 * @param oEvent
-		 * @private
-		 */
-		PDFViewer.prototype._onLoadListener = function (oEvent) {
+		 PDFViewer.prototype._onLoadListener = function (oEvent) {
 			try {
-				var oTarget = jQuery(oEvent.target);
-				var bContinue = true, sCurrentContentType = '';
-
-				//HTML body.children can be accessed only in scenario when chrome://flags/#pdf-oopif = disabled OR invalid path given to the iframe src
-				try {
-					var aTargetChildren = oTarget[0]?.contentWindow?.document?.body?.children;
-				} catch (error) {
-					/* Firefox
-						https://bugzilla.mozilla.org/show_bug.cgi?id=911444
-						because of the embedded pdf plugin in firefox it is not possible to check contentType of the iframe document
-						if the content is pdf. If the content is not a pdf and it is from the same origin, it can be accessed.
-						Other browsers allow access to the mimeType of the iframe's document if the content is from the same origin.
-						If browser is Firefox we triggerHEADRequest to fetch the ContentType.
-					*/
-					if (Device.browser.firefox) {
+				// Check if PDF plugin is enabled
+				if (PDFViewerRenderer._isPdfPluginEnabled()) {
+					var bContinue = true;
+					var oTarget = jQuery(oEvent.target);
+					try {
+						// Try to access children of the iframe document body
+						var aTargetChildren = oTarget[0]?.contentWindow?.document?.body?.children;
+					} catch (error) {
+						// If access fails, log warning and treat as no children
 						aTargetChildren = [];
+						Log.warning("Error in fetching children entity for given source of PDFViewer.");
 					}
-				}
-				//If chrome://flags/#pdf-oopif = disabled follow the existing approach to validate contentType.
-				if (aTargetChildren?.length) {
-					try {
-						// browsers render pdf in iframe as html page with embed tag
+					// If children exist, check for embed tag
+					if (aTargetChildren?.length) {
 						var aEmbeds = oTarget[0].contentWindow.document.embeds;
 						bContinue = !!aEmbeds && aEmbeds.length === 1;
-						if (bContinue) {
-							sCurrentContentType = aEmbeds[0].attributes.getNamedItem("type").value;
-						}
-					} catch (error) {
-						// even though the sourceValidationFailed event is fired, the default behaviour is to continue.
-						// when preventDefault is on event object is called, the rendering ends up with error
-						if (!Device.browser.firefox && this.fireEvent("sourceValidationFailed", {}, true)) {
-							this._fireLoadedEvent();
-							return;
-						}
 					}
-					/*	LoadedEvent will be triggered if all the below criteria matches and PDF is displayed
-							1. If embed tag is present.
-							2. If ContentType = "application/pdf" / "application/x-google-chrome-pdf".
-							3. If Browser PDFPlugin is enabled.
-						else the ErrorEvent will be triggered, It will also be triggered if an invalid path is proveded as src for the iframe and LoadingError IllustratedMessage is displayed.
-					*/
-					if (bContinue && PDFViewerRenderer._isSupportedMimeType(sCurrentContentType) && PDFViewerRenderer._isPdfPluginEnabled()) {
+					// If valid PDF rendering, fire loaded event; else, fire error event
+					if (bContinue) {
 						this._fireLoadedEvent();
 					} else {
 						this._fireErrorEvent(oEvent.target);
 					}
 				} else {
-					// Check if PDF plugin is enabled before proceeding
-					if (!PDFViewerRenderer._isPdfPluginEnabled()) {
-						this._fireErrorEvent(oEvent.target);
-						return;
-					}
-					//If chrome://flags/#pdf-oopif = enabled trigger the HEAD Request
-					var sMethod = 'HEAD';
-					this._getHeaderInfo(this._sParametrizedSource, sMethod)
-					.then(function(sCurrentContentType) {
-						/*	LoadedEvent will be triggered if all the below criteria matches
-								1. If ContentType = "application/pdf" / "application/x-google-chrome-pdf".
-								2. If Browser PDFPlugin is enabled.
-							else the ErrorEvent will be triggered and LoadingError IllustratedMessage is displayed.
-						*/
-						if (PDFViewerRenderer._isSupportedMimeType(sCurrentContentType)) {
-							this._fireLoadedEvent();
-						} else {
-							this._fireErrorEvent(oEvent.target);
-						}
-					}.bind(this)).catch(function(error) {
-						if (error.status === 404) {
-							//If the HEAD Request fails to get the content defined in source, the ErrorEvent is triggered and LoadingError IllustratedMessage is displayed.
-							this._fireErrorEvent(oEvent.target);
-						} else {
-							// If the HEAD Requets fails for any other scenario, the default behaviour is to continue the display of PDF based on isTrustedSource.
-							Log.warning("PDF is displayed based on isTrustedSource property skipping the content type validation.");
-							this._fireLoadedEvent();
-							this.fireEvent("sourceValidationFailed", {}, true);
-						}
-					}.bind(this));
+					// PDF plugin not enabled, fire error event
+					this._fireErrorEvent(oEvent.target);
 				}
 			} catch (error) {
-				//Generic Error Handling
+				// Generic Error Handling: fire error event and log details
 				this._fireErrorEvent(oEvent.target);
 				Log.fatal(false, "Fatal error during the handling of load event happened.");
 				Log.fatal(false, error.message);
 			}
-		};
+        };
 
 		/**
 		 * @private

package/src/sap/m/Page.js

@@ -97,7 +97,7 @@ function(
 		 * @extends sap.ui.core.Control
 		 * @mixes sap.ui.core.ContextMenuSupport
 		 * @author SAP SE
-		 * @version 1.139.0
+		 * @version 1.141.0
 		 *
 		 * @public
 		 * @alias sap.m.Page

package/src/sap/m/PageAccessibleLandmarkInfo.js

@@ -22,7 +22,7 @@ sap.ui.define(['sap/ui/core/Element', './library'],
 	 * @extends sap.ui.core.Element
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/PagingButton.js

@@ -27,7 +27,7 @@ sap.ui.define([
 		 * @extends sap.ui.core.Control
 		 *
 		 * @author SAP SE
-		 * @version 1.139.0
+		 * @version 1.141.0
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/Panel.js

@@ -68,7 +68,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/PlanningCalendar.js

@@ -208,7 +208,7 @@ sap.ui.define([
 	 * {@link sap.m.PlanningCalendarView PlanningCalendarView}'s properties.
 	 *
 	 * @extends sap.ui.core.Control
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/PlanningCalendarHeader.js

@@ -106,7 +106,7 @@ function(
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/m/PlanningCalendarLegend.js

@@ -23,7 +23,7 @@ sap.ui.define(["sap/ui/core/Lib", 'sap/ui/unified/CalendarLegend', 'sap/ui/unifi
 		 * @extends sap.ui.unified.CalendarLegend
 		 *
 		 * @author SAP SE
-		 * @version 1.139.0
+		 * @version 1.141.0
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/PlanningCalendarRow.js

@@ -37,7 +37,7 @@ sap.ui.define([
 	 * The <code>sap.m.PlanningCalendarRow</code> allows you to modify appointments at row level.
 	 *
 	 * @extends sap.ui.core.Element
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/PlanningCalendarView.js

@@ -25,7 +25,7 @@ sap.ui.define(['sap/ui/core/Element', './library', 'sap/ui/unified/library'],
 	 * The <code>PlanningCalendarView</code> defines the type of the intervals (hours, days, months)
 	 * and how many intervals are displayed.
 	 * @extends sap.ui.core.Element
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/Popover.js

@@ -121,7 +121,7 @@ sap.ui.define([
 		* @extends sap.ui.core.Control
 		* @implements sap.ui.core.PopupInterface
 		* @author SAP SE
-		* @version 1.139.0
+		* @version 1.141.0
 		*
 		* @public
 		* @alias sap.m.Popover
@@ -266,6 +266,7 @@ sap.ui.define([
 
 					/**
 					 * Any control that needed to be displayed in the header area. When this is set, the showHeader property is ignored, and only this customHeader is shown on the top of popover.
+					* <br/><b>Note:</b> To improve accessibility, titles with heading level <code>H1</code> should be used inside the custom header.
 					 */
 					customHeader: {type: "sap.ui.core.Control", multiple: false},
 
@@ -436,14 +437,39 @@ sap.ui.define([
 			this.oPopup.setAnimations(jQuery.proxy(this._openAnimation, this), jQuery.proxy(this._closeAnimation, this));
 
 			// This is data used to position the popover depending on the placement property
-			this._placements = [PlacementType.Top, PlacementType.Right, PlacementType.Bottom, PlacementType.Left,
-				PlacementType.Vertical, PlacementType.Horizontal, PlacementType.Auto,
-				PlacementType.VerticalPreferedTop, PlacementType.VerticalPreferedBottom,
-				PlacementType.HorizontalPreferedLeft, PlacementType.HorizontalPreferedRight,
-				PlacementType.VerticalPreferredTop, PlacementType.VerticalPreferredBottom,
-				PlacementType.HorizontalPreferredLeft, PlacementType.HorizontalPreferredRight,
-				PlacementType.PreferredRightOrFlip, PlacementType.PreferredLeftOrFlip,
-				PlacementType.PreferredTopOrFlip, PlacementType.PreferredBottomOrFlip];
+			this._placements = [
+				PlacementType.Top,
+				PlacementType.Right,
+				PlacementType.Bottom,
+				PlacementType.Left,
+				PlacementType.Vertical,
+				PlacementType.Horizontal,
+				PlacementType.Auto,
+				/**
+				* @deprecated As of version 1.36
+				*/
+				PlacementType.VerticalPreferedTop,
+				/**
+				* @deprecated As of version 1.36
+				*/
+				PlacementType.VerticalPreferedBottom,
+				/**
+				* @deprecated As of version 1.36
+				*/
+				PlacementType.HorizontalPreferedLeft,
+				/**
+				* @deprecated As of version 1.36
+				*/
+				PlacementType.HorizontalPreferedRight,
+				PlacementType.VerticalPreferredTop,
+				PlacementType.VerticalPreferredBottom,
+				PlacementType.HorizontalPreferredLeft,
+				PlacementType.HorizontalPreferredRight,
+				PlacementType.PreferredRightOrFlip,
+				PlacementType.PreferredLeftOrFlip,
+				PlacementType.PreferredTopOrFlip,
+				PlacementType.PreferredBottomOrFlip
+			];
 
 			this._myPositions = ["center bottom", "begin center", "center top", "end center"];
 			this._atPositions = ["center top", "end center", "center bottom", "begin center"];
@@ -1688,7 +1714,7 @@ sap.ui.define([
 			this._bPosCalced = true;
 
 			//set position of popover to calculated position
-			var iPlacePos = this._placements.indexOf(this._oCalcedPos);
+			var iPlacePos = this._placements.indexOf(this._getCalculatedPlacement());
 			this.oPopup.setPosition(this._myPositions[iPlacePos], this._atPositions[iPlacePos], oParentDomRef, this._calcOffset(this._offsets[iPlacePos]), "fit");
 		};
 
@@ -2670,6 +2696,12 @@ sap.ui.define([
 			}
 		};
 
+		Popover.prototype._getTitles = function (oContainer) {
+			return oContainer.findAggregatedObjects(true, function(oObject) {
+				return oObject.isA("sap.m.Title");
+			});
+		};
+
 		/**
 		 * Provides the accessibility options of the control.
 		 *
@@ -2688,10 +2720,23 @@ sap.ui.define([
 				return mAccOptions;
 			}
 
-			var oHeaderId = oCustomHeader ? oCustomHeader.getId() : this.getHeaderTitle().getId();
+			if (oCustomHeader) {
+				// if there are titles in the header, add all of them to labels, else use the full header
+				var aTitles = this._getTitles(oHeader);
+
+				if (aTitles.length) {
+					aAriaLabels = aTitles.map(function (oTitle) {
+						return oTitle.getId();
+					});
+				} else {
+					aAriaLabels = oHeader.getId();
+				}
+			} else {
+				aAriaLabels = this.getHeaderTitle().getId();
+			}
 
 			// If we have a header/title, we add a reference to it in the beginning of the aria-labelledby attribute
-			aAriaLabels = Array.prototype.concat(oHeaderId, this.getAssociation("ariaLabelledBy", []));
+			aAriaLabels = Array.prototype.concat(aAriaLabels, this.getAssociation("ariaLabelledBy", []));
 			mAccOptions.labelledby = aAriaLabels.join(' ');
 
 			return mAccOptions;

package/src/sap/m/PopoverRenderer.js

@@ -284,6 +284,10 @@ sap.ui.define([
 				aClassNames.push("sapMPopoverHorScrollDisabled");
 			}
 
+			if (oControl.getShowArrow()) {
+				aClassNames.push("sapMPopoverWithArrow");
+			}
+
 			aClassNames.push("sapMPopup-CTX");
 
 			// Adds styles for compact mode

package/src/sap/m/ProgressIndicator.js

@@ -61,7 +61,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/PullToRefresh.js

@@ -37,7 +37,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/QuickView.js

@@ -59,7 +59,7 @@ sap.ui.define([
 	 * @extends sap.m.QuickViewBase
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/QuickViewBase.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/QuickViewCard.js

@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @extends sap.m.QuickViewBase
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/QuickViewGroup.js

@@ -22,7 +22,7 @@ sap.ui.define([
 	* @extends sap.ui.core.Element
 	*
 	* @author SAP SE
-	* @version 1.139.0
+	* @version 1.141.0
 	*
 	* @constructor
 	* @public

package/src/sap/m/QuickViewGroupElement.js

@@ -28,7 +28,7 @@ sap.ui.define([
 	* @extends sap.ui.core.Element
 	*
 	* @author SAP SE
-	* @version 1.139.0
+	* @version 1.141.0
 	*
 	* @constructor
 	* @public

package/src/sap/m/QuickViewPage.js

@@ -103,7 +103,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/RadioButton.js

@@ -94,7 +94,7 @@ function(
 	 * @implements sap.ui.core.IFormContent
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/RadioButtonGroup.js

@@ -68,7 +68,7 @@ sap.ui.define([
 			 * @borrows sap.ui.core.ISemanticFormContent.getFormRenderAsControl as #getFormRenderAsControl
 			 *
 			 * @author SAP SE
-			 * @version 1.139.0
+			 * @version 1.141.0
 			 *
 			 * @constructor
 			 * @public

package/src/sap/m/RangeSlider.js

@@ -53,7 +53,7 @@ sap.ui.define([
          * @extends sap.m.Slider
          *
          * @author SAP SE
-         * @version 1.139.0
+         * @version 1.141.0
          *
          * @constructor
          * @public

package/src/sap/m/RatingIndicator.js

@@ -56,7 +56,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public
@@ -773,15 +773,15 @@ sap.ui.define([
 		if (this.getEnabled()) {
 			var fValue = this._calculateSelectedValue(oEvent);
 
-			// When the value is 1 and the first star is pressed we should toggle to 0
-			if (this.getValue() === 1 && fValue === 1) {
+			// When same rating is chosen, set the rating to 0
+			if (this.getValue() === fValue) {
 				fValue = 0;
 			}
 
-			this.setProperty("value", fValue, true);
 			this._updateUI(fValue, false);
 
-			if (this._fStartValue !== fValue) {	// if the value if not the same
+			 if (this.getValue() !== fValue) {	// if the value if not the same
+				this.setProperty("value", fValue, true);
 				this.fireLiveChange({value: fValue});
 				this.fireChange({value: fValue});
 			}

package/src/sap/m/ResponsivePopover.js

@@ -63,7 +63,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @public

package/src/sap/m/ResponsiveScale.js

@@ -34,7 +34,7 @@ sap.ui.define([
 		 * @extends sap.ui.core.Element
 		 *
 		 * @author SAP SE
-		 * @version 1.139.0
+		 * @version 1.141.0
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/ScrollBar.js

@@ -25,7 +25,7 @@ function(Control, ScrollBarRenderer) {
 	 * care of only rendering the currently visible rows and use this <code>ScrollBar</code> control to make
 	 * the users think they are actually scrolling through a long list.
 	 * @extends sap.ui.core.Control
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @private
 	 * @alias sap.m.ScrollBar

package/src/sap/m/ScrollContainer.js

@@ -39,7 +39,7 @@ sap.ui.define([
 		 * @extends sap.ui.core.Control
 		 *
 		 * @author SAP SE
-		 * @version 1.139.0
+		 * @version 1.141.0
 		 *
 		 * @constructor
 		 * @public

package/src/sap/m/SearchField.js

@@ -67,7 +67,7 @@ sap.ui.define([
 	* @extends sap.ui.core.Control
 	* @implements sap.ui.core.IFormContent
 	* @author SAP SE
-	* @version 1.139.0
+	* @version 1.141.0
 	*
 	* @constructor
 	* @public