@openui5/sap.m 1.105.1 → 1.107.0

package/src/sap/m/GenericTileRenderer.js

@@ -4,8 +4,8 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
-sap.ui.define(["sap/m/library", "sap/base/security/encodeCSS"],
-	function(library, encodeCSS) {
+sap.ui.define(["sap/m/library", "sap/base/security/encodeCSS", "sap/ui/core/Configuration"],
+	function(library, encodeCSS, Configuration) {
 	"use strict";
 
 	// shortcut for sap.m.GenericTileMode
@@ -48,6 +48,7 @@ sap.ui.define(["sap/m/library", "sap/base/security/encodeCSS"],
 		var sAriaRoleDescription = oControl.getAriaRoleDescription();
 		var sAriaRole = oControl.getAriaRole();
 		var isHalfFrame = frameType === frameTypes.OneByHalf || frameType === frameTypes.TwoByHalf;
+		var sBGColor = oControl._sBGColor;
 
 		// Render a link when URL is provided, not in action scope and the state is enabled
 		var bRenderLink = oControl.getUrl() && (!oControl._isInActionScope() || oControl.getMode() === GenericTileMode.IconMode) && sState !== LoadState.Disabled && !oControl._isNavigateActionEnabled() && !oControl._isActionMode();
@@ -62,7 +63,9 @@ sap.ui.define(["sap/m/library", "sap/base/security/encodeCSS"],
 			oRm.openStart("a", oControl);
 			oRm.attr("href", oControl.getUrl());
 			oRm.attr("rel", "noopener noreferrer");
-			oRm.attr("draggable", "false"); // <a> elements are draggable per default, use UI5 DnD instead
+			if (!this._isDragabble(oControl)) {
+				oRm.attr("draggable", "false"); // <a> elements are draggable per default, use UI5 DnD instead
+			}
 		} else {
 			oRm.openStart("div",oControl );
 		}
@@ -112,10 +115,10 @@ sap.ui.define(["sap/m/library", "sap/base/security/encodeCSS"],
 				oRm.class("sapMGTTwoByHalf");
 			} else if (frameType === frameTypes.OneByOne) {
 				if (!this._isThemeHighContrast()) {
-					oRm.style("background-color", oControl.getBackgroundColor());
+					oRm.style("background-color", sBGColor);
 				} else {
-					oRm.style("border-color", oControl.getBackgroundColor());
-					oRm.style("box-shadow", "0 0 0 1px" + oControl.getBackgroundColor());
+					oRm.style("border-color", sBGColor);
+					oRm.style("box-shadow", "0 0 0 1px" + sBGColor);
 				}
 			}
 		}
@@ -256,11 +259,11 @@ sap.ui.define(["sap/m/library", "sap/base/security/encodeCSS"],
 					} else {
 						oRm.class("sapMGTTwoByHalfIcon");
 						if (!this._isThemeHighContrast()) {
-							oRm.style("background-color", oControl.getBackgroundColor());
+							oRm.style("background-color", sBGColor);
 						} else {
 							oRm.class("HighContrastTile");
-							oRm.style("border-color", oControl.getBackgroundColor());
-							oRm.style("box-shadow", "0 0 0 1px" + oControl.getBackgroundColor());
+							oRm.style("border-color", sBGColor);
+							oRm.style("box-shadow", "0 0 0 1px" + sBGColor);
 						}
 					}
 					oRm.openEnd();
@@ -391,6 +394,29 @@ sap.ui.define(["sap/m/library", "sap/base/security/encodeCSS"],
 		}
 	};
 
+	/**
+	 * Checks if the GenericTile should be draggable or not.
+	 * @param {sap.m.GenericTile} oControl The GenericTile control
+	 * @returns {boolean} True if the GenericTile is draggable, false otherwise
+	 * @private
+	 */
+	 GenericTileRenderer._isDragabble = function(oControl) {
+		var bDraggable = oControl.getDragDropConfig().some(function(vDragDropInfo){
+			return vDragDropInfo.isDraggable(oControl);
+		});
+
+		if (!bDraggable) {
+			// also check parent config
+			var oParent = oControl.getParent();
+			if (oParent && oParent.getDragDropConfig) {
+				bDraggable = oParent.getDragDropConfig().some(function(vDragDropInfo){
+					return vDragDropInfo.isDraggable(oControl);
+				});
+			}
+		}
+		return bDraggable;
+	};
+
 	/**
 	 * Checks if the GenericTile should render the info container.
 	 * @param {sap.m.GenericTile} oControl The GenericTile control
@@ -559,7 +585,7 @@ sap.ui.define(["sap/m/library", "sap/base/security/encodeCSS"],
 	 * @private
 	 */
 	GenericTileRenderer._isThemeHighContrast = function() {
-		return /(hcw|hcb)/g.test(sap.ui.getCore().getConfiguration().getTheme());
+		return /(hcw|hcb)/g.test(Configuration.getTheme());
 	};
 
 	GenericTileRenderer._isNewsContentPresent = function(aTileContent,iLength) {

package/src/sap/m/GroupHeaderListItem.js

@@ -30,44 +30,47 @@ sap.ui.define(["sap/ui/core/library", "./library", "./ListItemBase", "./GroupHea
 	 * @extends sap.m.ListItemBase
 	 *
 	 * @author SAP SE
-	 * @version 1.105.1
+	 * @version 1.107.0
 	 *
 	 * @constructor
 	 * @public
 	 * @since 1.12
 	 * @alias sap.m.GroupHeaderListItem
-	 * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
 	 */
-	var GroupHeaderListItem = ListItemBase.extend("sap.m.GroupHeaderListItem", /** @lends sap.m.GroupHeaderListItem.prototype */ { metadata : {
-
-		library : "sap.m",
-		properties : {
-
-			/**
-			 * Defines the title of the group header.
-			 */
-			title : {type : "string", group : "Data", defaultValue : null},
-
-			/**
-			 * Defines the count of items in the group, but it could also be an amount which represents the sum of all amounts in the group.
-			 * <b>Note:</b> Will not be displayed if not set.
-			 */
-			count : {type : "string", group : "Data", defaultValue : null},
-
-			/**
-			 * Allows to uppercase the group title.
-			 * @since 1.13.2
-			 * @deprecated Since version 1.40.10
-			 */
-			upperCase : {type : "boolean", group : "Appearance", defaultValue : false, deprecated: true},
-
-			/**
-			 * Defines the title text directionality with enumerated options. By default, the control inherits text direction from the DOM.
-			 * @since 1.28.0
-			 */
-			titleTextDirection : {type : "sap.ui.core.TextDirection", group : "Appearance", defaultValue : TextDirection.Inherit}
-		}
-	}});
+	var GroupHeaderListItem = ListItemBase.extend("sap.m.GroupHeaderListItem", /** @lends sap.m.GroupHeaderListItem.prototype */ {
+		metadata : {
+
+			library : "sap.m",
+			properties : {
+
+				/**
+				 * Defines the title of the group header.
+				 */
+				title : {type : "string", group : "Data", defaultValue : null},
+
+				/**
+				 * Defines the count of items in the group, but it could also be an amount which represents the sum of all amounts in the group.
+				 * <b>Note:</b> Will not be displayed if not set.
+				 */
+				count : {type : "string", group : "Data", defaultValue : null},
+
+				/**
+				 * Allows to uppercase the group title.
+				 * @since 1.13.2
+				 * @deprecated Since version 1.40.10
+				 */
+				upperCase : {type : "boolean", group : "Appearance", defaultValue : false, deprecated: true},
+
+				/**
+				 * Defines the title text directionality with enumerated options. By default, the control inherits text direction from the DOM.
+				 * @since 1.28.0
+				 */
+				titleTextDirection : {type : "sap.ui.core.TextDirection", group : "Appearance", defaultValue : TextDirection.Inherit}
+			}
+		},
+
+		renderer: GroupHeaderListItemRenderer
+	});
 
 	// GroupHeaderListItem does not respect the list mode
 	GroupHeaderListItem.prototype.getMode = function() {

package/src/sap/m/GrowingEnablement.js

@@ -71,10 +71,7 @@ sap.ui.define([
 			this._iTriggerTimer = 0;
 			this._aChunk = [];
 			this._oRM = null;
-
-			if (document.location.href.search("sap-ui-xx-enableItemsPool") > 0) {
-				this._aItemsPool = [];
-			}
+			this._aItemsPool = [];
 		},
 
 		/**
@@ -94,10 +91,8 @@ sap.ui.define([
 				this._oRM.destroy();
 				this._oRM = null;
 			}
-			this._aItemsPool && this._aItemsPool.forEach(function(oItem) {
-				oItem.destroy();
-			});
 
+			this.clearItemsPool();
 			this._oControl.$("triggerList").remove();
 			this._oControl.bUseExtendedChangeDetection = false;
 			this._oControl.removeDelegate(this);
@@ -169,11 +164,21 @@ sap.ui.define([
 				return;
 			}
 
+			// if the template invalidates, then also clear the itemsPool
+			this.clearItemsPool();
+
 			// if factory function is used we do not activate the replace option of the extended change detection
 			var oBindingInfo = this._oControl.getBindingInfo("items");
 			this._oControl.oExtendedChangeDetectionConfig = (!oBindingInfo || !oBindingInfo.template) ? null : {replace: true};
 		},
 
+		clearItemsPool: function() {
+			this._aItemsPool.forEach(function(oItem) {
+				oItem.destroy();
+			});
+			this._aItemsPool = [];
+		},
+
 		// determines growing reset with binding change reason
 		// according to UX sort/filter/context should reset the growing
 		shouldReset : function(sChangeReason) {
@@ -219,12 +224,8 @@ sap.ui.define([
 			// if max item count not reached or if we do not know the count
 			var oBinding = this._oControl.getBinding("items");
 			if (oBinding && !oBinding.isLengthFinal() || this._iLimit < this._oControl.getMaxItemsCount()) {
-				// The GrowingEnablement has its own busy indicator. Do not show the busy indicator, if existing, of the parent control.
-				if (this._oControl.getMetadata().hasProperty("enableBusyIndicator")) {
-					this._bParentEnableBusyIndicator = this._oControl.getEnableBusyIndicator();
-					this._oControl.setEnableBusyIndicator(false);
-				}
-
+				// block busy indicator animation from the ListBase
+				this._oControl._bBusy = true;
 				this._iLimit += this._oControl.getGrowingThreshold();
 				this._updateTriggerDelayed(true);
 				this.updateItems("Growing");
@@ -246,11 +247,6 @@ sap.ui.define([
 			this._bLoading = false;
 			this._updateTriggerDelayed(false);
 			this._oControl.onAfterPageLoaded(this.getInfo(), sChangeReason);
-
-			// After the data has been loaded, restore the busy indicator handling of the parent control.
-			if (this._oControl.setEnableBusyIndicator) {
-				this._oControl.setEnableBusyIndicator(this._bParentEnableBusyIndicator);
-			}
 		},
 
 		// created and returns load more trigger
@@ -436,13 +432,15 @@ sap.ui.define([
 		},
 
 		fillItemsPool: function() {
-			if (!this._iLimit || this._iRenderedDataItems || this._aItemsPool.length) {
+			if (!this._oControl || !this._iLimit || this._iRenderedDataItems || this._aItemsPool.length) {
 				return;
 			}
 
-			var oBindingInfo = this._oControl.getBindingInfo("items");
+			var oBindingInfo = this._oControl.getBindingInfo("items"),
+				// limit the number of items in the pool to 100, since have too many items in the pool is also not performant
+				iLimit = this._iLimit <= 100 ? this._iLimit : 100;
 			if (oBindingInfo && oBindingInfo.template) {
-				for (var i = 0; i < this._iLimit; i++) {
+				for (var i = 0; i < iLimit; i++) {
 					this._aItemsPool.push(oBindingInfo.factory());
 				}
 			}
@@ -452,8 +450,8 @@ sap.ui.define([
 		createListItem : function(oContext, oBindingInfo) {
 			this._iRenderedDataItems++;
 
-			if (this._aItemsPool && this._aItemsPool.length) {
-				return this._aItemsPool.pop().setBindingContext(oContext, oBindingInfo.model);
+			if (this._aItemsPool.length) {
+				return this._aItemsPool.shift().setBindingContext(oContext, oBindingInfo.model);
 			}
 
 			return GrowingEnablement.createItem(oContext, oBindingInfo);
@@ -588,8 +586,8 @@ sap.ui.define([
 				this._iLimit = oControl.getGrowingThreshold();
 			}
 
-			// pre-initialize items during the request is ongoing
-			if (this._aItemsPool) {
+			// pre-initialize items during the request is ongoing (but not for v1 ODataModel, since it is synchronous)
+			if (!oBinding.isA("sap.ui.model.odata.ODataListBinding")) {
 				if (oControl._bBusy) {
 					setTimeout(this.fillItemsPool.bind(this));
 				} else {

package/src/sap/m/GrowingList.js

@@ -5,8 +5,8 @@
  */
 
 // Provides control sap.m.GrowingList.
-sap.ui.define(['./List', './library', './GrowingListRenderer'],
-	function(List, library, GrowingListRenderer) {
+sap.ui.define(['./List', './library', './GrowingListRenderer', 'sap/ui/core/Configuration'],
+	function(List, library, GrowingListRenderer, Configuration) {
 	"use strict";
 
 
@@ -22,47 +22,50 @@ sap.ui.define(['./List', './library', './GrowingListRenderer'],
 	 * @extends sap.m.List
 	 *
 	 * @author SAP SE
-	 * @version 1.105.1
+	 * @version 1.107.0
 	 *
 	 * @constructor
 	 * @public
 	 * @deprecated Since version 1.16.
 	 * Instead use "List" or "Table" control with setting "growing" property to "true"
 	 * @alias sap.m.GrowingList
-	 * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
 	 */
-	var GrowingList = List.extend("sap.m.GrowingList", /** @lends sap.m.GrowingList.prototype */ { metadata : {
-
-		deprecated : true,
-		library : "sap.m",
-		properties : {
-
-			/**
-			 * Number of items requested from the server. To activate this you should set growing property to "true"
-			 * @since 1.16
-			 */
-			threshold : {type : "int", group : "Misc", defaultValue : 20},
-
-			/**
-			 * Text which is displayed on the trigger at the end of the list. The default is a translated text ("Load More Data") coming from the messagebundle properties.
-			 * This property can be used only if growing property is set "true" and scrollToLoad property is set "false".
-			 * @since 1.16
-			 */
-			triggerText : {type : "string", group : "Appearance", defaultValue : null},
-
-			/**
-			 * If you set this property to true then user needs to scroll end to trigger loading a new page. Default value is false which means user needs to scroll end and then click button to load new page.
-			 * NOTE: This property can be set true, if growing property is set "true" and if you only have one instance of this control inside the scroll container(e.g Page).
-			 * @since 1.16
-			 */
-			scrollToLoad : {type : "boolean", group : "Behavior", defaultValue : false}
-		}
-	}});
+	var GrowingList = List.extend("sap.m.GrowingList", /** @lends sap.m.GrowingList.prototype */ {
+		metadata : {
+
+			deprecated : true,
+			library : "sap.m",
+			properties : {
+
+				/**
+				 * Number of items requested from the server. To activate this you should set growing property to "true"
+				 * @since 1.16
+				 */
+				threshold : {type : "int", group : "Misc", defaultValue : 20},
+
+				/**
+				 * Text which is displayed on the trigger at the end of the list. The default is a translated text ("Load More Data") coming from the messagebundle properties.
+				 * This property can be used only if growing property is set "true" and scrollToLoad property is set "false".
+				 * @since 1.16
+				 */
+				triggerText : {type : "string", group : "Appearance", defaultValue : null},
+
+				/**
+				 * If you set this property to true then user needs to scroll end to trigger loading a new page. Default value is false which means user needs to scroll end and then click button to load new page.
+				 * NOTE: This property can be set true, if growing property is set "true" and if you only have one instance of this control inside the scroll container(e.g Page).
+				 * @since 1.16
+				 */
+				scrollToLoad : {type : "boolean", group : "Behavior", defaultValue : false}
+			}
+		},
+
+		renderer: GrowingListRenderer
+	});
 
 
 	// checks if control is not compatible anymore
 	GrowingList.prototype._isIncompatible = function() {
-		return sap.ui.getCore().getConfiguration().getCompatibilityVersion("sapMGrowingList").compareTo("1.16") >= 0;
+		return Configuration.getCompatibilityVersion("sapMGrowingList").compareTo("1.16") >= 0;
 	};
 
 	//sets growing property to true on init

package/src/sap/m/HBox.js

@@ -25,18 +25,21 @@ sap.ui.define(['./FlexBox', './library', './HBoxRenderer'],
 	 * @extends sap.m.FlexBox
 	 *
 	 * @author SAP SE
-	 * @version 1.105.1
+	 * @version 1.107.0
 	 *
 	 * @constructor
 	 * @public
 	 * @alias sap.m.HBox
-	 * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
 	 */
-	var HBox = FlexBox.extend("sap.m.HBox", /** @lends sap.m.HBox.prototype */ { metadata : {
+	var HBox = FlexBox.extend("sap.m.HBox", /** @lends sap.m.HBox.prototype */ {
+		metadata : {
 
-		library : "sap.m",
-		designtime: "sap/m/designtime/HBox.designtime"
-	}});
+			library : "sap.m",
+			designtime: "sap/m/designtime/HBox.designtime"
+		},
+
+		renderer: HBoxRenderer
+	});
 
 
 

package/src/sap/m/HeaderContainer.js

@@ -20,14 +20,11 @@ sap.ui.define([
 		"sap/ui/events/KeyCodes",
 		"sap/ui/events/PseudoEvents",
 		"sap/ui/thirdparty/jquery",
-		// jQuery Plugin "control"
-		"sap/ui/dom/jquery/control",
-		// jQuery Plugin "scrollLeftRTL"
-		"sap/ui/dom/jquery/scrollLeftRTL",
-		// jQuery Plugin "scrollRightRTL"
-		"sap/ui/dom/jquery/scrollRightRTL",
-		// jQuery custom selectors ":sapTabbable"
-		"sap/ui/dom/jquery/Selectors"
+		"sap/ui/core/Configuration",
+		"sap/ui/dom/jquery/control", // jQuery Plugin "control"
+		"sap/ui/dom/jquery/scrollLeftRTL", // jQuery Plugin "scrollLeftRTL"
+		"sap/ui/dom/jquery/scrollRightRTL", // jQuery Plugin "scrollRightRTL"
+		"sap/ui/dom/jquery/Selectors" // jQuery custom selectors ":sapTabbable"
 	],
 	function (
 		library,
@@ -45,7 +42,8 @@ sap.ui.define([
 		Log,
 		KeyCodes,
 		PseudoEvents,
-		jQuery
+		jQuery,
+		Configuration
 	) {
 		"use strict";
 
@@ -125,11 +123,10 @@ sap.ui.define([
 		 * @since 1.44.0
 		 *
 		 * @author SAP SE
-		 * @version 1.105.1
+		 * @version 1.107.0
 		 *
 		 * @public
 		 * @alias sap.m.HeaderContainer
-		 * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
 		 */
 		var HeaderContainer = Control.extend("sap.m.HeaderContainer", /** @lends sap.m.HeaderContainer.prototype */ {
 			metadata: {
@@ -268,7 +265,9 @@ sap.ui.define([
 
 					}
 				}
-			}
+			},
+
+			renderer: HeaderContainerRenderer
 		});
 
 		/* ============================================================ */
@@ -277,7 +276,7 @@ sap.ui.define([
 
 		HeaderContainer.prototype.init = function () {
 			this._aItemEnd = [];
-			this._bRtl = sap.ui.getCore().getConfiguration().getRTL();
+			this._bRtl = Configuration.getRTL();
 			this._oRb = sap.ui.getCore().getLibraryResourceBundle("sap.m");
 			this._oScrollCntr = new ScrollContainer(this.getId() + "-scrl-cntnr", {
 				width: "100%",
@@ -369,40 +368,42 @@ sap.ui.define([
 								var aItems = this._filterVisibleItems();
 								this.triggerScrollStop = true;
 								var iScrollValue = 0, iScrollOffset = 15;
-
-								var iScrollContainerScrollLeft = this._oScrollCntr.getDomRef().scrollLeft;
-								var iScrollContainerWidth = iScrollContainerScrollLeft + this._oScrollCntr.getDomRef().clientWidth;
-
 								var oFinalItem = aItems[aItems.length - 1];
-
-								var iFinalElementScrollLeft = oFinalItem.getParent().getDomRef().offsetLeft;
-								var iFinalElementContainerWidth = iFinalElementScrollLeft + oFinalItem.getDomRef().clientWidth;
-
-								var bIsFinalItemVisible = ((iFinalElementContainerWidth <= iScrollContainerWidth) && (iFinalElementScrollLeft >= iScrollContainerScrollLeft));
-								var iCurrectScrollValue = this._bRtl ? Math.abs(oEvent.currentTarget.scrollLeft) : oEvent.currentTarget.scrollLeft;
-
-								if (bIsFinalItemVisible) {
-									iScrollValue = this.aItemScrollValue[aItems.length - 1] - iScrollOffset - iCurrectScrollValue;
-									this.triggerScrollStop = false;
-								} else {
-									var value = this.aItemScrollValue.reduce(function(a, b) {
-										var aDiff = Math.abs(a - iCurrectScrollValue);
-										var bDiff = Math.abs(b - iCurrectScrollValue);
-										if (aDiff == bDiff) {
-											return a > b ? a : b;
-										} else {
-											return bDiff < aDiff ? b : a;
-										}
-									});
-									if (iCurrectScrollValue == 0) {
-										iScrollValue = 0;
+								var oScrollCntrDomRef = this._oScrollCntr.getDomRef();
+								if ( oScrollCntrDomRef && oFinalItem){
+									var oFinalItemParentDomRef = oFinalItem.getParent().getDomRef();
+									var oFinalItemDomRef = oFinalItem.getDomRef();
+									var iScrollContainerScrollLeft = oScrollCntrDomRef.scrollLeft;
+									var iScrollContainerWidth = iScrollContainerScrollLeft + oScrollCntrDomRef.clientWidth;
+									var iFinalElementScrollLeft = oFinalItemParentDomRef.offsetLeft;
+									var iFinalElementContainerWidth = iFinalElementScrollLeft + oFinalItemDomRef.clientWidth;
+
+									var bIsFinalItemVisible = ((iFinalElementContainerWidth <= iScrollContainerWidth) && (iFinalElementScrollLeft >= iScrollContainerScrollLeft));
+									var iCurrectScrollValue = this._bRtl ? Math.abs(oEvent.currentTarget.scrollLeft) : oEvent.currentTarget.scrollLeft;
+
+									if (bIsFinalItemVisible) {
+										iScrollValue = this.aItemScrollValue[aItems.length - 1] - iScrollOffset - iCurrectScrollValue;
 										this.triggerScrollStop = false;
 									} else {
-										iScrollValue = value - iScrollOffset - iCurrectScrollValue;
+										var value = this.aItemScrollValue.reduce(function(a, b) {
+											var aDiff = Math.abs(a - iCurrectScrollValue);
+											var bDiff = Math.abs(b - iCurrectScrollValue);
+											if (aDiff == bDiff) {
+												return a > b ? a : b;
+											} else {
+												return bDiff < aDiff ? b : a;
+											}
+										});
+										if (iCurrectScrollValue == 0) {
+											iScrollValue = 0;
+											this.triggerScrollStop = false;
+										} else {
+											iScrollValue = value - iScrollOffset - iCurrectScrollValue;
+										}
 									}
-								}
-								this._scroll(iScrollValue, this.getScrollTime());
+									this._scroll(iScrollValue, this.getScrollTime());
 							}
+						}
 						}.bind(this));
 					}
 				}.bind(this)
@@ -433,7 +434,7 @@ sap.ui.define([
 		};
 
 		HeaderContainer.prototype.onAfterRendering = function () {
-			this._bRtl = sap.ui.getCore().getConfiguration().getRTL();
+			this._bRtl = Configuration.getRTL();
 			this._checkOverflow();
 		};
 

package/src/sap/m/HeaderContainerItemNavigator.js

@@ -16,7 +16,7 @@ sap.ui.define([
 	 * @since 1.67.0
 	 *
 	 * @author SAP SE
-	 * @version 1.105.1
+	 * @version 1.107.0
 	 *
 	 * @constructor
 	 * @alias sap.m.HeaderContainerItemNavigator