@opentripplanner/core-utils 16.0.4 → 16.1.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opentripplanner/core-utils",
-  "version": "16.0.4",
+  "version": "16.1.0",
   "description": "Core functionality that is shared among numerous UI components",
   "engines": {
     "node": ">=13"
@@ -25,13 +25,14 @@
     "graphql": "^16.6.0",
     "lodash.clonedeep": "^4.5.0",
     "qs": "^6.9.1",
-    "@opentripplanner/geocoder": "^3.1.1"
+    "@opentripplanner/geocoder": "^3.1.2"
   },
   "gitHead": "0af1b7cda60bd4252b219dcf893e01c2acb2ed5d",
   "devDependencies": {
     "@types/chroma-js": "^3.1.2",
     "@types/mapbox__polyline": "^1.0.5",
-    "@opentripplanner/types": "^8.4.0"
+    "@types/node": "^25.6.0",
+    "@opentripplanner/types": "^8.5.0"
   },
   "scripts": {
     "tsc": "tsc"

package/src/__tests__/__snapshots__/query.js.snap

@@ -263,6 +263,10 @@ exports[`query parseLocationString should return location with coordinates as na
 
 exports[`query parseLocationString should return null for null input 1`] = `null`;
 
+exports[`query parseLocationString should return null with name as name with no coords (but with commas) for input 1`] = `null`;
+
+exports[`query parseLocationString should return null with name as name with no coords for input 1`] = `null`;
+
 exports[`query planParamsToQuery should parse a depart at query 1`] = `
 {
   "bannedRoutes": "897ABC",

package/src/__tests__/query.js

@@ -218,6 +218,13 @@ describe("query", () => {
         parseLocationString("33.983929829,-87.3892387982")
       ).toMatchSnapshot();
     });
+
+    it("should return null with name as name with no coords for input", () => {
+      expect(parseLocationString("1 cool street")).toMatchSnapshot();
+    });
+    it("should return null with name as name with no coords (but with commas) for input", () => {
+      expect(parseLocationString("148, se street")).toMatchSnapshot();
+    });
   });
 
   describe("planParamsToQuery", () => {

package/src/planQuery.graphql

@@ -7,6 +7,7 @@ query Plan(
   $fromPlace: String!
   $modes: [TransportMode]
   $numItineraries: Int
+  $omitCanceled: Boolean
   $time: String
   $toPlace: String!
   $unpreferred: InputUnpreferred
@@ -24,6 +25,7 @@ query Plan(
     # Currently only supporting EN locale, used for times and text
     locale: "en"
     numItineraries: $numItineraries
+    omitCanceled: $omitCanceled
     time: $time
     toPlace: $toPlace
     transportModes: $modes

package/src/query-gen.ts

@@ -24,15 +24,16 @@ type InputPreferred = {
 
 type OTPQueryParams = {
   arriveBy: boolean;
+  banned?: InputBanned;
   date?: string;
   from: LonLatOutput & { name?: string };
   modes: TransportMode[];
   modeSettings: ModeSetting[];
-  time?: string;
   numItineraries?: number;
-  to: LonLatOutput & { name?: string };
-  banned?: InputBanned;
+  omitCanceled?: boolean;
   preferred?: InputPreferred;
+  time?: string;
+  to: LonLatOutput & { name?: string };
   unpreferred?: InputPreferred;
 };
 

package/src/query.js

@@ -247,7 +247,7 @@ async function getFirstGeocodeResult(
     if (firstResult) {
       return geocoder.getLocationFromGeocodedFeature(firstResult);
     }
-    return null;
+    return { name: `(Geocoder failure) ${text}` };
   });
 }
 
@@ -265,7 +265,7 @@ export function parseLocationString(value) {
     ? stringToCoords(parts[1])
     : stringToCoords(parts[0]);
   const name = parts[1] ? parts[0] : coordsToString(coordinates);
-  return coordinates.length === 2
+  return coordinates.length === 2 && coordinates.every(c => !!c)
     ? {
         name: name || null,
         lat: coordinates[0] || null,