@opensumi/ide-editor 3.3.0 → 3.3.1-next-1725288439.0

package/src/browser/workbench-editor.service.ts

@@ -1,5 +1,3 @@
-import { observable } from 'mobx';
-
 import { Autowired, INJECTOR_TOKEN, Injectable, Injector } from '@opensumi/di';
 import {
   AppConfig,
@@ -42,7 +40,6 @@ import {
   StorageProvider,
   URI,
   WithEventBus,
-  debounce,
   formatLocalize,
   getDebugLogger,
   isDefined,
@@ -280,7 +277,7 @@ export class WorkbenchEditorServiceImpl extends WithEventBus implements Workbenc
   createEditorGroup(): EditorGroup {
     const editorGroup = this.injector.get(EditorGroup, [this.generateRandomEditorGroupName(), this.editorGroupIdGen++]);
     this.editorGroups.push(editorGroup);
-    const currentWatchDisposer = new Disposable(
+    editorGroup.addDispose([
       editorGroup.onDidEditorGroupBodyChanged(() => {
         if (editorGroup === this.currentEditorGroup) {
           if (!editorGroup.currentOpenType && editorGroup.currentResource) {
@@ -299,25 +296,15 @@ export class WorkbenchEditorServiceImpl extends WithEventBus implements Workbenc
           }
         }
       }),
-    );
-    editorGroup.addDispose({
-      dispose: () => {
-        currentWatchDisposer.dispose();
-      },
-    });
-    const groupChangeDisposer = editorGroup.onDidEditorGroupTabChanged(() => {
-      this.saveOpenedResourceState();
-    });
-    editorGroup.addDispose({
-      dispose: () => {
-        groupChangeDisposer.dispose();
-      },
-    });
-    editorGroup.onCurrentEditorCursorChange((e) => {
-      if (this._currentEditorGroup === editorGroup) {
-        this._onCursorChange.fire(e);
-      }
-    });
+      editorGroup.onDidEditorGroupTabChanged(() => {
+        this.saveOpenedResourceState();
+      }),
+      editorGroup.onCurrentEditorCursorChange((e) => {
+        if (this._currentEditorGroup === editorGroup) {
+          this._onCursorChange.fire(e);
+        }
+      }),
+    ]);
 
     return editorGroup;
   }
@@ -689,25 +676,25 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
   /**
    * 当编辑器的tab部分发生变更
    */
-  _onDidEditorGroupTabChanged = new EventEmitter<void>();
+  _onDidEditorGroupTabChanged = this.registerDispose(new EventEmitter<void>());
   onDidEditorGroupTabChanged: Event<void> = this._onDidEditorGroupTabChanged.event;
 
   /**
    * 当编辑器的tab部分发生变更
    */
-  _onDidEditorGroupTabOperation = new EventEmitter<IResourceTabOperation>();
+  _onDidEditorGroupTabOperation = this.registerDispose(new EventEmitter<IResourceTabOperation>());
   onDidEditorGroupTabOperation: Event<IResourceTabOperation> = this._onDidEditorGroupTabOperation.event;
 
   /**
    * 当编辑器的主体部分发生变更
    */
-  _onDidEditorGroupBodyChanged = new EventEmitter<void>();
+  _onDidEditorGroupBodyChanged = this.registerDispose(new EventEmitter<void>());
   onDidEditorGroupBodyChanged: Event<void> = this._onDidEditorGroupBodyChanged.event;
 
   /**
    * 当编辑器有内容处于加载状态
    */
-  _onDidEditorGroupContentLoading = new EventEmitter<IResource>();
+  _onDidEditorGroupContentLoading = this.registerDispose(new EventEmitter<IResource>());
   onDidEditorGroupContentLoading: Event<IResource> = this._onDidEditorGroupContentLoading.event;
 
   /**
@@ -733,7 +720,6 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
 
   private cachedResourcesOpenTypes = new Map<string, IEditorOpenType[]>();
 
-  @observable.shallow
   availableOpenTypes: IEditorOpenType[] = [];
 
   activeComponents = new Map<IEditorComponent, IResource[]>();
@@ -744,8 +730,6 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
 
   private holdDocumentModelRefs: Map<string, IEditorDocumentModelRef> = new Map();
 
-  private readonly toDispose: monaco.IDisposable[] = [];
-
   private _contextKeyService: IContextKeyService;
 
   private _resourceContext: ResourceContextKey;
@@ -763,12 +747,8 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
   private _prevDomHeight = 0;
   private _prevDomWidth = 0;
 
-  private _codeEditorPendingLayout = false;
-  private _diffEditorPendingLayout = false;
-  private _mergeEditorPendingLayout = false;
-
   // 当前为EditorComponent，且monaco光标变化时触发
-  private _onCurrentEditorCursorChange = new EventEmitter<CursorStatus>();
+  private _onCurrentEditorCursorChange = this.registerDispose(new EventEmitter<CursorStatus>());
   public onCurrentEditorCursorChange = this._onCurrentEditorCursorChange.event;
 
   private resourceOpenHistory: URI[] = [];
@@ -795,28 +775,28 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
 
   constructor(public readonly name: string, public readonly groupId: number) {
     super();
-    let toDispose: IDisposable | undefined;
-    this.eventBus.onDirective(
-      ResizeEvent.createDirective(getSlotLocation('@opensumi/ide-editor', this.config.layoutConfig)),
-      () => {
-        if (toDispose) {
-          toDispose.dispose();
-        }
 
-        toDispose = fastdom.mutate(() => {
-          this._layoutEditorWorker();
-        });
-      },
+    this.addDispose(
+      this.eventBus.onDirective(
+        ResizeEvent.createDirective(getSlotLocation('@opensumi/ide-editor', this.config.layoutConfig)),
+        () => {
+          this.layoutEditors();
+        },
+      ),
+    );
+    this.addDispose(
+      this.eventBus.on(GridResizeEvent, (e: GridResizeEvent) => {
+        if (e.payload.gridId === this.grid.uid) {
+          this.layoutEditors();
+        }
+      }),
+    );
+    this.addDispose(
+      this.eventBus.on(EditorComponentDisposeEvent, (e: EditorComponentDisposeEvent) => {
+        this.activeComponents.delete(e.payload);
+        this.activateComponentsProps.delete(e.payload);
+      }),
     );
-    this.eventBus.on(GridResizeEvent, (e: GridResizeEvent) => {
-      if (e.payload.gridId === this.grid.uid) {
-        this.doLayoutEditors();
-      }
-    });
-    this.eventBus.on(EditorComponentDisposeEvent, (e: EditorComponentDisposeEvent) => {
-      this.activeComponents.delete(e.payload);
-      this.activateComponentsProps.delete(e.payload);
-    });
 
     this.listenToExplorerAutoRevealConfig();
   }
@@ -825,10 +805,8 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
   private listenToExplorerAutoRevealConfig() {
     this.explorerAutoRevealConfig = !!this.preferenceService.get<boolean>('explorer.autoReveal');
     this.disposables.push(
-      this.preferenceService.onPreferenceChanged((change) => {
-        if (change.preferenceName === 'explorer.autoReveal') {
-          this.explorerAutoRevealConfig = change.newValue;
-        }
+      this.preferenceService.onSpecificPreferenceChange('explorer.autoReveal', (change) => {
+        this.explorerAutoRevealConfig = change.newValue;
       }),
     );
   }
@@ -860,49 +838,38 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
   layoutEditors() {
     fastdom.measure(() => {
       if (this._domNode) {
-        const currentWidth = this._domNode.offsetWidth;
-        const currentHeight = this._domNode.offsetHeight;
-        if (currentWidth !== this._prevDomWidth || currentHeight !== this._prevDomHeight) {
-          this.doLayoutEditors();
-        }
-        this._prevDomWidth = currentWidth;
-        this._prevDomHeight = currentHeight;
+        this._prevDomWidth = this._domNode.offsetWidth;
+        this._prevDomHeight = this._domNode.offsetHeight;
+        this.doLayoutEditors();
       }
     });
   }
 
-  private _layoutEditorWorker() {
+  private doLayoutEditors() {
     if (this.codeEditor) {
       if (this.currentOpenType && this.currentOpenType.type === EditorOpenType.code) {
-        this.codeEditor.layout();
-        this._codeEditorPendingLayout = false;
-      } else {
-        this._codeEditorPendingLayout = true;
+        this.codeEditor.layout(
+          {
+            width: this._prevDomWidth,
+            height: this._prevDomHeight,
+          },
+          true,
+        );
       }
     }
     if (this.diffEditor) {
       if (this.currentOpenType && this.currentOpenType.type === EditorOpenType.diff) {
-        this.diffEditor.layout();
-        this._diffEditorPendingLayout = false;
-      } else {
-        this._diffEditorPendingLayout = true;
-      }
-    }
-    if (this.mergeEditor) {
-      if (this.currentOpenType && this.currentOpenType.type === EditorOpenType.mergeEditor) {
-        // this.mergeEditor.layout();
-        this._mergeEditorPendingLayout = false;
-      } else {
-        this._mergeEditorPendingLayout = true;
+        this.diffEditor.layout(
+          {
+            width: this._prevDomWidth,
+            height: this._prevDomHeight,
+          },
+          true,
+        );
       }
     }
   }
 
-  @debounce(16 * 5)
-  doLayoutEditors() {
-    this._layoutEditorWorker();
-  }
-
   setContextKeys() {
     if (!this._resourceContext) {
       const getLanguageFromModel = (uri: URI) => {
@@ -1141,19 +1108,21 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
     );
 
     setTimeout(() => {
-      this.codeEditor.layout();
+      fastdom.mutate(() => {
+        this.codeEditor.layout();
+      });
     });
     this.addDispose(
       this.codeEditor.onRefOpen(() => {
         this.codeEditor.layout();
       }),
     );
-    this.toDispose.push(
+    this.addDispose(
       this.codeEditor.onCursorPositionChanged((e) => {
         this._onCurrentEditorCursorChange.fire(e);
       }),
     );
-    this.toDispose.push(
+    this.addDispose(
       this.codeEditor.onSelectionsChanged((e) => {
         if (this.currentOpenType && this.currentOpenType.type === EditorOpenType.code) {
           this.eventBus.fire(
@@ -1168,7 +1137,7 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
         }
       }),
     );
-    this.toDispose.push(
+    this.addDispose(
       this.codeEditor.onVisibleRangesChanged((e) => {
         if (this.currentOpenType && this.currentOpenType.type === EditorOpenType.code) {
           this.eventBus.fire(
@@ -1182,7 +1151,7 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
         }
       }),
     );
-    this.toDispose.push(
+    this.addDispose(
       this.codeEditor.onConfigurationChanged(() => {
         if (this.currentOpenType && this.currentOpenType.type === EditorOpenType.code) {
           this.eventBus.fire(
@@ -1225,7 +1194,15 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
       },
     );
     setTimeout(() => {
-      this.diffEditor.layout();
+      fastdom.mutate(() => {
+        this.diffEditor.layout();
+      });
+    });
+
+    this.diffEditor.onRefOpen(() => {
+      fastdom.mutate(() => {
+        this.diffEditor.layout();
+      });
     });
 
     this.addDiffEditorEventListeners(this.diffEditor.originalEditor, 'original');
@@ -1250,7 +1227,7 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
   }
 
   private addDiffEditorEventListeners(editor: IEditor, side?: 'modified' | 'original') {
-    this.toDispose.push(
+    this.addDispose(
       editor.onSelectionsChanged((e) => {
         if (this.currentOpenType && this.currentOpenType.type === EditorOpenType.diff) {
           this.eventBus.fire(
@@ -1267,7 +1244,7 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
       }),
     );
 
-    this.toDispose.push(
+    this.addDispose(
       editor.onVisibleRangesChanged((e) => {
         if (this.currentOpenType && this.currentOpenType.type === EditorOpenType.diff) {
           this.eventBus.fire(
@@ -1282,7 +1259,7 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
       }),
     );
 
-    this.toDispose.push(
+    this.addDispose(
       editor.onConfigurationChanged(() => {
         if (this.currentOpenType && this.currentOpenType.type === EditorOpenType.diff) {
           this.eventBus.fire(
@@ -1838,13 +1815,7 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
       this._currentOpenType = activeOpenType;
       this.notifyBodyChanged();
 
-      if (
-        (!this._codeEditorPendingLayout && activeOpenType.type === EditorOpenType.code) ||
-        (!this._diffEditorPendingLayout && activeOpenType.type === EditorOpenType.diff) ||
-        (!this._mergeEditorPendingLayout && activeOpenType.type === EditorOpenType.mergeEditor)
-      ) {
-        this.doLayoutEditors();
-      }
+      this.layoutEditors();
 
       this.cachedResourcesActiveOpenTypes.set(resource.uri.toString(), activeOpenType);
     }
@@ -2242,7 +2213,6 @@ export class EditorGroup extends WithEventBus implements IGridEditorGroup {
     super.dispose();
     this.codeEditor && this.codeEditor.dispose();
     this.diffEditor && this.diffEditor.dispose();
-    this.toDispose.forEach((disposable) => disposable.dispose());
     this.eventBus.fire(
       new EditorGroupDisposeEvent({
         group: this,

package/src/common/editor.ts

@@ -310,7 +310,7 @@ export interface IDiffEditor extends IDisposable {
 
   modifiedEditor: IEditor;
 
-  layout(): void;
+  layout(dimension?: IDimension, postponeRendering?: boolean): void;
 
   focus(): void;