@opensumi/ide-ai-native 3.8.1-next-1741091353.0 → 3.8.1-next-1741092802.0

package/src/browser/mcp/base-apply.service.ts

@@ -6,14 +6,12 @@ import { WorkbenchEditorService } from '@opensumi/ide-editor';
 import {
   EditorGroupCloseEvent,
   EditorGroupOpenEvent,
-  IEditorDocumentModelService,
   RegisterEditorSideComponentEvent,
 } from '@opensumi/ide-editor/lib/browser';
 import { IMarkerService } from '@opensumi/ide-markers';
-import { ICodeEditor, ITextModel, Position, Range, Selection, SelectionDirection } from '@opensumi/ide-monaco';
-import { Deferred, DisposableMap, Emitter, IDisposable, URI, path } from '@opensumi/ide-utils';
+import { ICodeEditor, Position, Range, Selection, SelectionDirection } from '@opensumi/ide-monaco';
+import { Deferred, Emitter, URI, path } from '@opensumi/ide-utils';
 import { SumiReadableStream } from '@opensumi/ide-utils/lib/stream';
-import { EditOperation } from '@opensumi/monaco-editor-core/esm/vs/editor/common/core/editOperation';
 
 import { IChatInternalService } from '../../common';
 import { CodeBlockData, CodeBlockStatus } from '../../common/types';
@@ -25,9 +23,15 @@ import {
   InlineDiffService,
   LiveInlineDiffPreviewer,
 } from '../widget/inline-diff';
-import { BaseInlineStreamDiffHandler } from '../widget/inline-stream-diff/inline-stream-diff.handler';
+import { InlineStreamDiffHandler } from '../widget/inline-stream-diff/inline-stream-diff.handler';
 
+import { FileHandler } from './tools/handlers/ReadFile';
+
+// 提供代码块的唯一索引，迭代轮次，生成状态管理（包括取消），关联文件位置这些信息的记录，后续并行 apply 的支持
 export abstract class BaseApplyService extends WithEventBus {
+  @Autowired(FileHandler)
+  protected fileHandler: FileHandler;
+
   @Autowired(IChatInternalService)
   protected chatInternalService: ChatInternalService;
 
@@ -43,14 +47,9 @@ export abstract class BaseApplyService extends WithEventBus {
   @Autowired(IMarkerService)
   private readonly markerService: IMarkerService;
 
-  @Autowired(IEditorDocumentModelService)
-  private readonly editorDocumentModelService: IEditorDocumentModelService;
-
   private onCodeBlockUpdateEmitter = new Emitter<CodeBlockData>();
   public onCodeBlockUpdate = this.onCodeBlockUpdateEmitter.event;
 
-  private currentSessionId?: string;
-
   constructor() {
     super();
     this.addDispose(
@@ -58,15 +57,6 @@ export abstract class BaseApplyService extends WithEventBus {
         this.cancelAllApply();
       }),
     );
-    this.currentSessionId = this.chatInternalService.sessionModel.sessionId;
-    this.addDispose(
-      this.chatInternalService.onChangeSession((sessionId) => {
-        if (sessionId !== this.currentSessionId) {
-          this.cancelAllApply();
-          this.currentSessionId = sessionId;
-        }
-      }),
-    );
     this.addDispose(
       this.chatInternalService.onRegenerateRequest(() => {
         const messages = this.chatInternalService.sessionModel.history.getMessages();
@@ -95,69 +85,30 @@ export abstract class BaseApplyService extends WithEventBus {
     return message?.codeBlockMap;
   }
 
-  private getSessionCodeBlocksForPath(relativePath: string, sessionId?: string) {
-    sessionId = sessionId || this.chatInternalService.sessionModel.sessionId;
-    const sessionModel = this.chatInternalService.getSession(sessionId);
-    if (!sessionModel) {
-      throw new Error(`Session ${sessionId} not found`);
-    }
-    const sessionAdditionals = sessionModel.history.sessionAdditionals;
-    const codeBlocks: CodeBlockData[] = Array.from(sessionAdditionals.values())
-      .map((additional) => additional.codeBlockMap as { [toolCallId: string]: CodeBlockData })
-      .reduce((acc, cur) => {
-        Object.values(cur).forEach((block) => {
-          if (block.relativePath === relativePath) {
-            acc.push(block);
-          }
-        });
-        return acc;
-      }, [] as CodeBlockData[])
-      .sort((a, b) => b.version - a.version);
-    return codeBlocks;
-  }
-
-  private activePreviewerMap = this.registerDispose(
-    new DisposableMap<string, BaseInlineDiffPreviewer<BaseInlineStreamDiffHandler>>(),
-  );
-
-  private editorListenerMap = this.registerDispose(new DisposableMap<string, IDisposable>());
+  private activePreviewer: BaseInlineDiffPreviewer<InlineStreamDiffHandler> | undefined;
 
   @OnEvent(EditorGroupCloseEvent)
   onEditorGroupClose(event: EditorGroupCloseEvent) {
-    const relativePath = path.relative(this.appConfig.workspaceDir, event.payload.resource.uri.path.toString());
-    const activePreviewer = this.activePreviewerMap.get(relativePath);
-    if (activePreviewer) {
-      this.activePreviewerMap.disposeKey(relativePath);
+    if (this.activePreviewer?.getNode()?.uri.path.toString() === event.payload.resource.uri.path.toString()) {
+      this.activePreviewer.dispose();
+      this.activePreviewer = undefined;
     }
-    this.editorListenerMap.disposeKey(event.payload.resource.uri.toString());
   }
 
   @OnEvent(EditorGroupOpenEvent)
   async onEditorGroupOpen(event: EditorGroupOpenEvent) {
-    const relativePath = path.relative(this.appConfig.workspaceDir, event.payload.resource.uri.path.toString());
-    if (
-      this.duringApply ||
-      this.activePreviewerMap.has(relativePath) ||
-      !this.chatInternalService.sessionModel.history.getMessages().length
-    ) {
+    if (!this.chatInternalService.sessionModel.history.getMessages().length) {
       return;
     }
+    const relativePath = path.relative(this.appConfig.workspaceDir, event.payload.resource.uri.path.toString());
     const filePendingApplies = Object.values(
       this.getMessageCodeBlocks(this.chatInternalService.sessionModel.history.lastMessageId!) || {},
     ).filter((block) => block.relativePath === relativePath && block.status === 'pending');
     // TODO: 刷新后重新应用，事件无法恢复 & 恢复继续请求，需要改造成批量apply形式
-    if (filePendingApplies.length > 0 && filePendingApplies[0].updatedCode) {
-      const editor = event.payload.group.codeEditor.monacoEditor;
-      this.renderApplyResult(editor, filePendingApplies[0], filePendingApplies[0].updatedCode);
-    }
-  }
-
-  get currentPreviewer() {
-    const currentUri = this.editorService.currentEditor?.currentUri;
-    if (!currentUri) {
-      return undefined;
+    // TODO: 暂时只支持 pending 串行的 apply，后续支持批量apply后统一accept
+    if (filePendingApplies.length > 0) {
+      this.renderApplyResult(filePendingApplies[0], filePendingApplies[0].updatedCode!);
     }
-    return this.activePreviewerMap.get(path.relative(this.appConfig.workspaceDir, currentUri.path.toString()));
   }
 
   getUriPendingCodeBlock(uri: URI): CodeBlockData | undefined {
@@ -176,25 +127,6 @@ export abstract class BaseApplyService extends WithEventBus {
     );
   }
 
-  getPendingPaths(sessionId?: string): string[] {
-    sessionId = sessionId || this.chatInternalService.sessionModel.sessionId;
-    const sessionModel = this.chatInternalService.getSession(sessionId);
-    if (!sessionModel) {
-      throw new Error(`Session ${sessionId} not found`);
-    }
-    const sessionAdditionals = sessionModel.history.sessionAdditionals;
-    return Array.from(sessionAdditionals.values())
-      .map((additional) => additional.codeBlockMap as { [toolCallId: string]: CodeBlockData })
-      .reduce((acc, cur) => {
-        Object.values(cur).forEach((block) => {
-          if (block.status === 'pending' && !acc.includes(block.relativePath)) {
-            acc.push(block.relativePath);
-          }
-        });
-        return acc;
-      }, [] as string[]);
-  }
-
   getCodeBlock(toolCallId: string, messageId?: string): CodeBlockData | undefined {
     messageId = messageId || this.chatInternalService.sessionModel.history.lastMessageId;
     if (!messageId) {
@@ -223,12 +155,9 @@ export abstract class BaseApplyService extends WithEventBus {
     this.onCodeBlockUpdateEmitter.fire(codeBlock);
   }
 
-  async registerCodeBlock(relativePath: string, content: string, toolCallId: string): Promise<CodeBlockData> {
+  registerCodeBlock(relativePath: string, content: string, toolCallId: string): CodeBlockData {
     const lastMessageId = this.chatInternalService.sessionModel.history.lastMessageId!;
     const savedCodeBlockMap = this.getMessageCodeBlocks(lastMessageId) || {};
-    const originalModelRef = await this.editorDocumentModelService.createModelReference(
-      URI.file(path.join(this.appConfig.workspaceDir, relativePath)),
-    );
     const newBlock: CodeBlockData = {
       codeEdit: content,
       relativePath,
@@ -237,13 +166,11 @@ export abstract class BaseApplyService extends WithEventBus {
       version: 1,
       createdAt: Date.now(),
       toolCallId,
-      // TODO: 支持range
-      originalCode: originalModelRef.instance.getText(),
     };
     const samePathCodeBlocks = Object.values(savedCodeBlockMap).filter((block) => block.relativePath === relativePath);
     if (samePathCodeBlocks.length > 0) {
       newBlock.version = samePathCodeBlocks.length;
-      for (const block of samePathCodeBlocks.sort((a, b) => a.version - b.version)) {
+      for (const block of samePathCodeBlocks.sort((a, b) => b.version - a.version)) {
         // 如果连续的上一个同文件apply结果存在LintError，则iterationCount++
         if (block.relativePath === relativePath && block.applyResult?.diagnosticInfos?.length) {
           newBlock.iterationCount++;
@@ -260,40 +187,21 @@ export abstract class BaseApplyService extends WithEventBus {
     return newBlock;
   }
 
-  private duringApply?: boolean;
-
   /**
    * Apply changes of a code block
    */
   async apply(codeBlock: CodeBlockData): Promise<CodeBlockData> {
     try {
-      this.duringApply = true;
       if (codeBlock.iterationCount > 3) {
         throw new Error('Lint error max iteration count exceeded');
       }
-      // 新建文件场景，直接返回codeEdit
-      const fastApplyFileResult = !codeBlock.originalCode
-        ? {
-            result: codeBlock.codeEdit,
-          }
-        : await this.doApply(codeBlock);
+      const fastApplyFileResult = await this.doApply(codeBlock);
       if (!fastApplyFileResult.stream && !fastApplyFileResult.result) {
         throw new Error('No apply content provided');
       }
 
-      if (this.activePreviewerMap.has(codeBlock.relativePath)) {
-        this.activePreviewerMap.disposeKey(codeBlock.relativePath);
-      }
-      // FIXME: 同一个bubble单个文件多次写入（如迭代）兼容
       // trigger diffPreivewer & return expected diff result directly
-      const result = await this.editorService.open(
-        URI.file(path.join(this.appConfig.workspaceDir, codeBlock.relativePath)),
-      );
-      if (!result) {
-        throw new Error('Failed to open file');
-      }
       const applyResult = await this.renderApplyResult(
-        result.group.codeEditor.monacoEditor,
         codeBlock,
         (fastApplyFileResult.result || fastApplyFileResult.stream)!,
         fastApplyFileResult.range,
@@ -309,39 +217,31 @@ export abstract class BaseApplyService extends WithEventBus {
       codeBlock.status = 'failed';
       this.updateCodeBlock(codeBlock);
       throw err;
-    } finally {
-      this.duringApply = false;
     }
   }
 
   async renderApplyResult(
-    editor: ICodeEditor,
     codeBlock: CodeBlockData,
     updatedContentOrStream: string | SumiReadableStream<IChatProgress>,
     range?: Range,
   ): Promise<{ diff: string; diagnosticInfos: IMarker[] } | undefined> {
-    const deferred = new Deferred<{ diff: string; diagnosticInfos: IMarker[] }>();
+    const { relativePath } = codeBlock;
+    const openResult = await this.editorService.open(URI.file(path.join(this.appConfig.workspaceDir, relativePath)));
+    if (!openResult) {
+      throw new Error('Failed to open editor');
+    }
+    const editor = openResult.group.codeEditor.monacoEditor;
     const inlineDiffController = InlineDiffController.get(editor)!;
-    range = range || editor.getModel()!.getFullModelRange();
+    codeBlock.status = 'pending';
+    // 强刷展示 manager 视图
+    this.eventBus.fire(new RegisterEditorSideComponentEvent());
+    this.updateCodeBlock(codeBlock);
+
+    const fullOriginalContent = editor.getModel()!.getValue();
+    range = range || editor.getModel()?.getFullModelRange()!;
+    // const savedRangeContent = editor.getModel()!.getValueInRange(range);
 
     if (typeof updatedContentOrStream === 'string') {
-      const editorCurrentContent = editor.getModel()!.getValue();
-      const document = this.editorDocumentModelService.getModelReference(
-        URI.file(path.join(this.appConfig.workspaceDir, codeBlock.relativePath)),
-      );
-      if (editorCurrentContent !== updatedContentOrStream || document?.instance.dirty) {
-        editor.getModel()?.pushEditOperations([], [EditOperation.replace(range, updatedContentOrStream)], () => null);
-        await this.editorService.save(URI.file(path.join(this.appConfig.workspaceDir, codeBlock.relativePath)));
-      }
-      const earlistPendingCodeBlock = this.getSessionCodeBlocksForPath(codeBlock.relativePath).find(
-        (block) => block.status === 'pending',
-      );
-      if ((earlistPendingCodeBlock?.originalCode || codeBlock.originalCode) === updatedContentOrStream) {
-        codeBlock.status = 'cancelled';
-        this.updateCodeBlock(codeBlock);
-        deferred.resolve();
-        return;
-      }
       // Create diff previewer
       const previewer = inlineDiffController.createDiffPreviewer(
         editor,
@@ -349,41 +249,18 @@ export abstract class BaseApplyService extends WithEventBus {
         {
           disposeWhenEditorClosed: true,
           renderRemovedWidgetImmediately: true,
-          reverse: true,
         },
       ) as LiveInlineDiffPreviewer;
-      this.activePreviewerMap.set(codeBlock.relativePath, previewer);
+      // TODO: 支持多个diffPreviewer
+      this.activePreviewer = previewer;
       codeBlock.updatedCode = updatedContentOrStream;
-      codeBlock.status = 'pending';
-      this.updateCodeBlock(codeBlock);
-      // 新建文件场景，为避免model为空，加一个空行
-      previewer.setValue(earlistPendingCodeBlock?.originalCode || codeBlock.originalCode || '\n');
-      // 强刷展示 manager 视图
-      this.eventBus.fire(new RegisterEditorSideComponentEvent());
-
-      this.listenPartialEdit(editor.getModel()!, codeBlock).then((result) => {
-        if (result) {
-          codeBlock.applyResult = result;
-        }
-        this.updateCodeBlock(codeBlock);
-        this.editorService.save(URI.file(path.join(this.appConfig.workspaceDir, codeBlock.relativePath)));
-      });
-
-      const { diff, rangesFromDiffHunk } = this.getDiffResult(
-        codeBlock.originalCode,
-        codeBlock.updatedCode,
-        codeBlock.relativePath,
-      );
-      const diagnosticInfos = this.getDiagnosticInfos(editor.getModel()!.uri.toString(), rangesFromDiffHunk);
-      deferred.resolve({
-        diff,
-        diagnosticInfos,
-      });
+      previewer.setValue(updatedContentOrStream);
     } else {
       const controller = new InlineChatController();
       controller.mountReadable(updatedContentOrStream);
+      const inlineDiffHandler = InlineDiffController.get(editor)!;
 
-      const previewer = inlineDiffController.showPreviewerByStream(editor, {
+      this.activePreviewer = inlineDiffHandler.showPreviewerByStream(editor, {
         crossSelection: Selection.fromRange(range, SelectionDirection.LTR),
         chatResponse: controller,
         previewerOptions: {
@@ -392,27 +269,14 @@ export abstract class BaseApplyService extends WithEventBus {
         },
       }) as LiveInlineDiffPreviewer;
       this.addDispose(
-        // 流式输出结束后，转为直接输出逻辑
-        previewer.getNode()!.onDiffFinished(async (diffModel) => {
+        this.activePreviewer.getNode()!.onDiffFinished((diffModel) => {
           codeBlock.updatedCode = diffModel.newFullRangeTextLines.join('\n');
-          // TODO: 添加 reapply
-          // 实际应用结果为空，则取消
-          if (codeBlock.updatedCode === codeBlock.originalCode) {
-            codeBlock.status = 'cancelled';
-            this.updateCodeBlock(codeBlock);
-            previewer.dispose();
-            deferred.resolve();
-            return;
-          }
           this.updateCodeBlock(codeBlock);
-          previewer.dispose();
-          const result = await this.renderApplyResult(editor, codeBlock, codeBlock.updatedCode);
-          deferred.resolve(result);
         }),
       );
-      this.activePreviewerMap.set(codeBlock.relativePath, previewer);
     }
-    return deferred.promise;
+
+    return this.listenPartialEdit(editor, codeBlock, fullOriginalContent);
   }
 
   /**
@@ -420,12 +284,9 @@ export abstract class BaseApplyService extends WithEventBus {
    */
   cancelApply(blockData: CodeBlockData): void {
     if (blockData.status === 'generating' || blockData.status === 'pending') {
-      if (this.activePreviewerMap.has(blockData.relativePath)) {
-        this.activePreviewerMap
-          .get(blockData.relativePath)
-          ?.getNode()
-          ?.livePreviewDiffDecorationModel.discardUnProcessed();
-        this.activePreviewerMap.disposeKey(blockData.relativePath);
+      if (this.activePreviewer) {
+        this.activePreviewer.getNode()?.livePreviewDiffDecorationModel.discardUnProcessed();
+        this.activePreviewer.dispose();
       }
       blockData.status = 'cancelled';
       this.updateCodeBlock(blockData);
@@ -466,9 +327,7 @@ export abstract class BaseApplyService extends WithEventBus {
     if (!codeBlock) {
       throw new Error('No pending code block found');
     }
-    const decorationModel = this.activePreviewerMap
-      .get(codeBlock.relativePath)
-      ?.getNode()?.livePreviewDiffDecorationModel;
+    const decorationModel = this.activePreviewer?.getNode()?.livePreviewDiffDecorationModel;
     if (!decorationModel) {
       throw new Error('No active previewer found');
     }
@@ -482,27 +341,32 @@ export abstract class BaseApplyService extends WithEventBus {
     this.updateCodeBlock(codeBlock);
   }
 
-  protected listenPartialEdit(model: ITextModel, codeBlock: CodeBlockData) {
+  protected listenPartialEdit(editor: ICodeEditor, codeBlock: CodeBlockData, fullOriginalContent: string) {
     const deferred = new Deferred<{ diff: string; diagnosticInfos: IMarker[] }>();
-    const uriString = model.uri.toString();
     const toDispose = this.inlineDiffService.onPartialEdit((event) => {
       // TODO 支持自动保存
-      if (
-        event.totalPartialEditCount === event.resolvedPartialEditCount &&
-        event.uri.path === model.uri.path.toString()
-      ) {
+      if (event.totalPartialEditCount === event.resolvedPartialEditCount) {
         if (event.acceptPartialEditCount > 0) {
           codeBlock.status = 'success';
-          const appliedResult = model.getValue();
-          const { diff, rangesFromDiffHunk } = this.getDiffResult(
-            codeBlock.originalCode,
-            appliedResult,
-            codeBlock.relativePath,
-          );
-          const diagnosticInfos = this.getDiagnosticInfos(model.uri.toString(), rangesFromDiffHunk);
+          const appliedResult = editor.getModel()!.getValue();
+          const diffResult = createPatch(codeBlock.relativePath, fullOriginalContent, appliedResult)
+            .split('\n')
+            .slice(4)
+            .join('\n');
+          const rangesFromDiffHunk = diffResult
+            .split('\n')
+            .map((line) => {
+              if (line.startsWith('@@')) {
+                const [, , , start, end] = line.match(/@@ -(\d+),(\d+) \+(\d+),(\d+) @@/)!;
+                return new Range(parseInt(start, 10), 0, parseInt(end, 10), 0);
+              }
+              return null;
+            })
+            .filter((range) => range !== null);
+          const diagnosticInfos = this.getDiagnosticInfos(editor.getModel()!.uri.toString(), rangesFromDiffHunk);
           // 移除开头的几个固定信息，避免浪费 tokens
           deferred.resolve({
-            diff,
+            diff: diffResult,
             diagnosticInfos,
           });
         } else {
@@ -510,31 +374,12 @@ export abstract class BaseApplyService extends WithEventBus {
           codeBlock.status = 'cancelled';
           deferred.resolve();
         }
-        this.editorListenerMap.disposeKey(uriString);
+        toDispose.dispose();
       }
     });
-    this.editorListenerMap.set(uriString, toDispose);
     return deferred.promise;
   }
 
-  protected getDiffResult(originalContent: string, appliedResult: string, relativePath: string) {
-    const diffResult = createPatch(relativePath, originalContent, appliedResult).split('\n').slice(4).join('\n');
-    const rangesFromDiffHunk = diffResult
-      .split('\n')
-      .map((line) => {
-        if (line.startsWith('@@')) {
-          const [, , , start, end] = line.match(/@@ -(\d+),(\d+) \+(\d+),(\d+) @@/)!;
-          return new Range(parseInt(start, 10), 0, parseInt(end, 10), 0);
-        }
-        return null;
-      })
-      .filter((range) => range !== null);
-    return {
-      diff: diffResult,
-      rangesFromDiffHunk,
-    };
-  }
-
   /**
    * Apply changes of a code block, return stream to render inline diff in stream mode, result to render inline diff directly
    * range is optional, if not provided, the result will be applied to the the full file

package/src/browser/mcp/tools/components/EditFile.tsx

@@ -13,7 +13,6 @@ import {
   useInjectable,
 } from '@opensumi/ide-core-browser';
 import { Loading } from '@opensumi/ide-core-browser/lib/components/ai-native';
-import { WorkbenchEditorService } from '@opensumi/ide-editor';
 import { ILanguageService } from '@opensumi/monaco-editor-core/esm/vs/editor/common/languages/language';
 import { IModelService } from '@opensumi/monaco-editor-core/esm/vs/editor/common/services/model';
 import { StandaloneServices } from '@opensumi/monaco-editor-core/esm/vs/editor/standalone/browser/standaloneServices';
@@ -31,7 +30,6 @@ export const EditFileToolComponent = (props: IMCPServerToolComponentProps) => {
   const labelService = useInjectable(LabelService);
   const appConfig = useInjectable<AppConfig>(AppConfig);
   const applyService = useInjectable<BaseApplyService>(BaseApplyService);
-  const editorService = useInjectable<WorkbenchEditorService>(WorkbenchEditorService);
   const { target_file = '', code_edit, instructions } = args || {};
   const absolutePath = path.join(appConfig.workspaceDir, target_file);
   const [codeBlockData, setCodeBlockData] = useState<CodeBlockData | undefined>(
@@ -57,20 +55,15 @@ export const EditFileToolComponent = (props: IMCPServerToolComponentProps) => {
 
   useEffect(() => {
     const disposable = applyService.onCodeBlockUpdate((codeBlockData) => {
-      if (codeBlockData.toolCallId === toolCallId) {
-        setCodeBlockData({ ...codeBlockData });
-      }
+      setCodeBlockData({ ...codeBlockData });
     });
     return () => {
       disposable.dispose();
     };
   }, []);
 
-  const handleToggleMode = (e: React.MouseEvent<HTMLDivElement>) => {
-    e.stopPropagation();
-    setMode(mode === 'code' ? 'diff' : 'code');
-  };
-
+  // 多次迭代时，仅在首处tool组件中展示
+  // FIXME: 这个优化有必要吗？每次都展示也挺好？
   if (!args || !codeBlockData) {
     return null;
   }
@@ -84,7 +77,7 @@ export const EditFileToolComponent = (props: IMCPServerToolComponentProps) => {
         })}
         onClick={() => {
           if (codeBlockData.status === 'pending') {
-            editorService.open(URI.file(absolutePath));
+            applyService.renderApplyResult(codeBlockData, codeBlockData.updatedCode!);
           } else if (codeBlockData.status === 'success') {
             applyService.revealApplyPosition(codeBlockData);
           }
@@ -96,15 +89,15 @@ export const EditFileToolComponent = (props: IMCPServerToolComponentProps) => {
           {codeBlockData.iterationCount > 1 && (
             <span className={styles['edit-file-tool-iteration-count']}>{codeBlockData.iterationCount}/3</span>
           )}
-          {renderStatus(codeBlockData, props.result)}
+          {renderStatus(codeBlockData)}
         </div>
         <div className={styles.right}>
           <Popover title={'Show Code'} id={'edit-file-tool-show-code'}>
-            <Icon iconClass='codicon codicon-file-code' onClick={handleToggleMode} />
+            <Icon iconClass='codicon codicon-file-code' onClick={() => setMode('code')} />
           </Popover>
           {codeBlockData.applyResult?.diff && (
             <Popover title={'Show Diff'} id={'edit-file-tool-show-diff'}>
-              <Icon iconClass='codicon codicon-diff-multiple' onClick={handleToggleMode} />
+              <Icon iconClass='codicon codicon-diff-multiple' onClick={() => setMode('diff')} />
             </Popover>
           )}
         </div>
@@ -138,7 +131,7 @@ export const EditFileToolComponent = (props: IMCPServerToolComponentProps) => {
   ];
 };
 
-const renderStatus = (codeBlockData: CodeBlockData, error?: string) => {
+const renderStatus = (codeBlockData: CodeBlockData) => {
   const status = codeBlockData.status;
   switch (status) {
     case 'generating':
@@ -157,7 +150,7 @@ const renderStatus = (codeBlockData: CodeBlockData, error?: string) => {
       );
     case 'failed':
       return (
-        <Popover title={`Failed (${error})`} id={'edit-file-tool-status-failed'}>
+        <Popover title='Failed' id={'edit-file-tool-status-failed'}>
           <Icon iconClass='codicon codicon-error' style={{ color: 'var(--debugConsole-errorForeground)' }} />
         </Popover>
       );

package/src/browser/mcp/tools/components/index.module.less

@@ -17,9 +17,6 @@
     align-items: center;
     justify-content: center;
   }
-  .left {
-    overflow: hidden;
-  }
   .left,
   .right {
     display: flex;

package/src/browser/mcp/tools/createNewFileWithText.ts

@@ -6,13 +6,10 @@ import { IFileServiceClient } from '@opensumi/ide-file-service';
 import { IWorkspaceService } from '@opensumi/ide-workspace';
 
 import { IMCPServerRegistry, MCPLogger, MCPServerContribution, MCPToolDefinition } from '../../types';
-import { BaseApplyService } from '../base-apply.service';
-
-import { EditFileToolComponent } from './components/EditFile';
 
 const inputSchema = z.object({
-  target_file: z.string().describe('The relative path where the file should be created'),
-  code_edit: z.string().describe('The content to write into the new file'),
+  pathInProject: z.string().describe('The relative path where the file should be created'),
+  text: z.string().describe('The content to write into the new file'),
 });
 
 @Domain(MCPServerContribution)
@@ -23,12 +20,8 @@ export class CreateNewFileWithTextTool implements MCPServerContribution {
   @Autowired(IFileServiceClient)
   private readonly fileService: IFileServiceClient;
 
-  @Autowired(BaseApplyService)
-  private applyService: BaseApplyService;
-
   registerMCPServer(registry: IMCPServerRegistry): void {
     registry.registerMCPTool(this.getToolDefinition());
-    registry.registerToolComponent('create_new_file_with_text', EditFileToolComponent);
   }
 
   getToolDefinition(): MCPToolDefinition {
@@ -38,16 +31,19 @@ export class CreateNewFileWithTextTool implements MCPServerContribution {
       description:
         'Creates a new file at the specified path within the project directory and populates it with the provided text. ' +
         'Use this tool to generate new files in your project structure. ' +
+        'Requires two parameters: ' +
+        '- pathInProject: The relative path where the file should be created ' +
+        '- text: The content to write into the new file ' +
         'Returns one of two possible responses: ' +
         '"ok" if the file was successfully created and populated, ' +
         '"can\'t find project dir" if the project directory cannot be determined. ' +
-        'Note: This tool creates any necessary parent directories automatically.',
+        'Note: Creates any necessary parent directories automatically.',
       inputSchema,
       handler: this.handler.bind(this),
     };
   }
 
-  private async handler(args: z.infer<typeof inputSchema> & { toolCallId: string }, logger: MCPLogger) {
+  private async handler(args: z.infer<typeof inputSchema>, logger: MCPLogger) {
     try {
       // 获取工作区根目录
       const workspaceRoots = this.workspaceService.tryGetRoots();
@@ -61,7 +57,7 @@ export class CreateNewFileWithTextTool implements MCPServerContribution {
 
       // 构建完整的文件路径
       const rootUri = URI.parse(workspaceRoots[0].uri);
-      const fullPath = path.join(rootUri.codeUri.fsPath, args.target_file);
+      const fullPath = path.join(rootUri.codeUri.fsPath, args.pathInProject);
       const fileUri = URI.file(fullPath);
 
       // 创建父目录
@@ -69,21 +65,17 @@ export class CreateNewFileWithTextTool implements MCPServerContribution {
       const parentUri = URI.file(parentDir);
       await this.fileService.createFolder(parentUri.toString());
 
-      // 创建文件
-      await this.fileService.createFile(fileUri.toString());
-
-      // 使用 applyService 写入文件内容
-      const codeBlock = await this.applyService.registerCodeBlock(args.target_file, args.code_edit, args.toolCallId);
-      await this.applyService.apply(codeBlock);
+      // 写入文件内容
+      await this.fileService.createFile(fileUri.toString(), { content: args.text });
 
-      logger.appendLine(`Successfully created file at: ${args.target_file}`);
+      logger.appendLine(`Successfully created file at: ${args.pathInProject}`);
       return {
         content: [{ type: 'text', text: 'ok' }],
       };
     } catch (error) {
       logger.appendLine(`Error during file creation: ${error}`);
       return {
-        content: [{ type: 'text', text: error.message }],
+        content: [{ type: 'text', text: 'unknown error' }],
         isError: true,
       };
     }

package/src/browser/mcp/tools/handlers/EditFile.ts

@@ -14,7 +14,7 @@ export class EditFileHandler {
 
   async handler(params: { targetFile: string; codeEdit: string; instructions?: string }, toolCallId: string) {
     const { targetFile, codeEdit } = params;
-    const block = await this.applyService.registerCodeBlock(targetFile, codeEdit, toolCallId);
+    const block = this.applyService.registerCodeBlock(targetFile, codeEdit, toolCallId);
     const blockData = await this.applyService.apply(block);
     return blockData;
   }