@openstax/ts-utils 1.20.2 → 1.20.3

package/dist/cjs/misc/helpers.d.ts

@@ -80,6 +80,8 @@ export declare const mapFind: <I, R>(array: I[], mapper: (item: I) => R, predica
 /**
  * returns a function that will only ever call the given function once, returning the first result for every subsequent call
  *
+ * does not cache rejected promises, to avoid cache poisoning on failed async requests
+ *
  * eg:
  *   const heavyFunction = () => 'hello';
  *   const butOnlyOnce = once(() => 'hello');
@@ -90,6 +92,8 @@ export declare const mapFind: <I, R>(array: I[], mapper: (item: I) => R, predica
 export declare const once: <F extends (...args: any[]) => any>(fn: F) => F;
 /**
  * memoizes a function with any number of arguments
+ *
+ * does not cache rejected promises, to avoid cache poisoning on failed async requests
  */
 export declare const memoize: <F extends (...args: any[]) => any>(fn: F) => F;
 /**

package/dist/cjs/misc/helpers.js

@@ -107,6 +107,8 @@ exports.mapFind = mapFind;
 /**
  * returns a function that will only ever call the given function once, returning the first result for every subsequent call
  *
+ * does not cache rejected promises, to avoid cache poisoning on failed async requests
+ *
  * eg:
  *   const heavyFunction = () => 'hello';
  *   const butOnlyOnce = once(() => 'hello');
@@ -133,6 +135,8 @@ const once = (fn) => {
 exports.once = once;
 /**
  * memoizes a function with any number of arguments
+ *
+ * does not cache rejected promises, to avoid cache poisoning on failed async requests
  */
 const memoize = (fn) => {
     const cache = {};
@@ -155,7 +159,15 @@ const memoize = (fn) => {
     };
     return ((...args) => {
         const thisCache = resolveCache(cache, args);
-        return thisCache.result = (thisCache.result || fn(...args));
+        if ('result' in thisCache) {
+            return thisCache.result;
+        }
+        thisCache.result = fn(...args);
+        if (typeof thisCache.result === 'object' && thisCache.result instanceof Promise) {
+            // Clear the result when possible but do not return a Promise that resolves to the initialValue
+            thisCache.result.catch(() => delete thisCache.result);
+        }
+        return thisCache.result;
     });
 };
 exports.memoize = memoize;