@opensoha/contracts 0.1.17 → 0.1.19

package/fixtures/openapi/WorkflowCatalogPage/invalid/unsupported-kind.json

@@ -0,0 +1,6 @@
+{
+  "items": [{ "id": "unknown", "sourceKind": "runtime", "sourceId": "run-1", "name": "Invalid kind", "context": "", "enabled": true, "scopes": [] }],
+  "total": -1,
+  "applications": [],
+  "environments": []
+}

package/fixtures/openapi/WorkflowCatalogPage/valid/build-without-environment.json

@@ -0,0 +1,6 @@
+{
+  "items": [{ "id": "build_source/app-1/build-1", "sourceKind": "build_source", "sourceId": "build-1", "name": "API build", "context": "buildkit", "enabled": true, "scopes": [{ "applicationId": "app-1", "applicationName": "API" }] }],
+  "total": 1,
+  "applications": [{ "value": "app-1", "label": "API" }],
+  "environments": []
+}

package/fixtures/openapi/WorkflowTemplateInput/invalid/zero-revision.json

@@ -0,0 +1,6 @@
+{
+  "key": "service-release",
+  "name": "Service release",
+  "enabled": true,
+  "expectedRevision": 0
+}

package/fixtures/openapi/WorkflowTemplateInput/valid/draft.json

@@ -0,0 +1,10 @@
+{
+  "key": "service-release",
+  "name": "Service release",
+  "enabled": true,
+  "definition": {
+    "kind": "release"
+  },
+  "expectedRevision": 2,
+  "publish": false
+}

package/gen/go/sohaapi/client.go

@@ -16,7 +16,7 @@ import (
 	"time"
 )
 
-const defaultUserAgent = "opensoha-contracts/0.1.17"
+const defaultUserAgent = "opensoha-contracts/0.1.19"
 
 type Client struct {
 	BaseURL    string
@@ -594,8 +594,16 @@ func (c *Client) GetComputeProviderInstance(ctx context.Context, domain ComputeP
 	return out.Data, nil
 }
 
-func (c *Client) CheckComputeProviderInstanceHealth(ctx context.Context, domain ComputeProviderDomain, providerKey, instanceRef, idempotencyKey string, req ComputeProviderReadRequest) (ComputeTaskView, error) {
-	return c.mutateComputeProviderInstance(ctx, domain, providerKey, instanceRef, "health-checks", idempotencyKey, req)
+func (c *Client) CheckComputeProviderInstanceHealth(ctx context.Context, domain ComputeProviderDomain, providerKey, instanceRef, idempotencyKey string, req ComputeProviderReadRequest) (ConnectionCheckResult, error) {
+	var out ConnectionCheckResultEnvelope
+	path := computeProviderInstancePath(domain, providerKey, instanceRef) + "/health-checks"
+	if err := c.doJSONWithHeaders(ctx, http.MethodPost, path, true, req, &out, idempotencyHeader(idempotencyKey)); err != nil {
+		return ConnectionCheckResult{}, err
+	}
+	if out.Data.CheckedAt.IsZero() || strings.TrimSpace(out.Data.Status) == "" {
+		return ConnectionCheckResult{}, fmt.Errorf("connection health check returned no synchronous result; upgrade the server before using this client")
+	}
+	return out.Data, nil
 }
 
 func (c *Client) DiscoverComputeProviderInstance(ctx context.Context, domain ComputeProviderDomain, providerKey, instanceRef, idempotencyKey string, req ComputeProviderDiscoverRequest) (ComputeTaskView, error) {

package/gen/go/sohaapi/client_test.go

@@ -414,7 +414,7 @@ func TestComputeInventoryClientSurface(t *testing.T) {
 			if key := r.Header.Get("Idempotency-Key"); key != "health-key-1" {
 				t.Fatalf("health Idempotency-Key = %q", key)
 			}
-			writeJSON(t, w, computeTaskEnvelopeFixture("health-task"))
+			writeJSON(t, w, map[string]any{"data": map[string]any{"healthy": true, "status": "healthy", "checkedAt": "2026-09-22T00:00:00Z"}})
 		case 8:
 			assertCommonRequest(t, r, http.MethodPost, "/api/v1/compute/provider-instances/virtualization/pve/connection%2Fone/discoveries")
 			if key := r.Header.Get("Idempotency-Key"); key != "discover-key-1" {
@@ -458,8 +458,8 @@ func TestComputeInventoryClientSurface(t *testing.T) {
 	if _, err := client.GetComputeProviderInstance(ctx, ComputeProviderDomainVirtualization, "pve", "connection/one"); err != nil {
 		t.Fatal(err)
 	}
-	if _, err := client.CheckComputeProviderInstanceHealth(ctx, ComputeProviderDomainVirtualization, "pve", "connection/one", "health-key-1", ComputeProviderReadRequest{ExpectedGeneration: 1}); err != nil {
-		t.Fatal(err)
+	if result, err := client.CheckComputeProviderInstanceHealth(ctx, ComputeProviderDomainVirtualization, "pve", "connection/one", "health-key-1", ComputeProviderReadRequest{ExpectedGeneration: 1}); err != nil || !result.Healthy || result.Status != "healthy" || result.CheckedAt.IsZero() {
+		t.Fatalf("CheckComputeProviderInstanceHealth = %#v, %v", result, err)
 	}
 	if _, err := client.DiscoverComputeProviderInstance(ctx, ComputeProviderDomainVirtualization, "pve", "connection/one", "discover-key-1", ComputeProviderDiscoverRequest{ExpectedGeneration: 1}); err != nil {
 		t.Fatal(err)
@@ -475,6 +475,29 @@ func TestComputeInventoryClientSurface(t *testing.T) {
 	}
 }
 
+func TestComputeProviderHealthPreservesDiagnostics(t *testing.T) {
+	client := newTestClient(t, func(w http.ResponseWriter, r *http.Request) {
+		writeJSON(t, w, map[string]any{"data": map[string]any{
+			"healthy": false, "status": "degraded", "checkedAt": "2026-09-22T00:00:00Z",
+			"httpStatus": 401, "reason": "authentication_failed", "message": "Credentials rejected", "nextAction": "Update credentials",
+		}})
+	})
+	result, err := client.CheckComputeProviderInstanceHealth(context.Background(), ComputeProviderDomainVirtualization, "pve", "connection-1", "", ComputeProviderReadRequest{})
+	if err != nil || result.Healthy || result.Status != "degraded" || result.HTTPStatus != 401 || result.Reason != "authentication_failed" || result.Message != "Credentials rejected" || result.NextAction != "Update credentials" || result.CheckedAt.IsZero() {
+		t.Fatalf("CheckComputeProviderInstanceHealth = %#v, %v", result, err)
+	}
+}
+
+func TestComputeProviderHealthRejectsLegacyTask(t *testing.T) {
+	client := newTestClient(t, func(w http.ResponseWriter, r *http.Request) {
+		w.WriteHeader(http.StatusAccepted)
+		writeJSON(t, w, computeTaskEnvelopeFixture("health-task"))
+	})
+	if _, err := client.CheckComputeProviderInstanceHealth(context.Background(), ComputeProviderDomainVirtualization, "pve", "connection-1", "", ComputeProviderReadRequest{}); err == nil || !strings.Contains(err.Error(), "upgrade the server") {
+		t.Fatalf("legacy task response should require a server upgrade, got %v", err)
+	}
+}
+
 func TestStreamComputeTask(t *testing.T) {
 	client := newTestClient(t, func(w http.ResponseWriter, r *http.Request) {
 		if r.Method != http.MethodGet || r.URL.EscapedPath() != "/api/v1/compute/tasks/virtualization/task%2Fone/stream" {