@opensip-cli/fitness 0.1.0

package/dist/recipes/__tests__/run-one-check.test.js

@@ -0,0 +1,182 @@
+/**
+ * Pins the load-bearing invariant called out in audit 2026-05-23 F7:
+ * `runOneCheck` reads `signal.aborted` after the retry chain to detect a
+ * timeout, and that detection is correct only because the per-check
+ * `AbortController` has exactly one abort source (the local
+ * `setTimeout`). The tests below pin the observable consequence — a
+ * non-timeout failure must NOT be reported as a timeout, regardless of
+ * whether the failing check's `run` reads or ignores the abort signal.
+ *
+ * If a future change wires another abort source into the per-check
+ * controller, these tests will catch the regression.
+ */
+import { describe, expect, it, vi } from 'vitest';
+import { defineCheck } from '../../framework/define-check.js';
+import { CheckAbortedError } from '../../framework/execution-context.js';
+import { runOneCheck } from '../run-one-check.js';
+let nextId = 0;
+function uid() {
+    nextId++;
+    return `00000000-0000-4000-8000-${nextId.toString(16).padStart(12, '0')}`;
+}
+function makeRecipe() {
+    return {
+        id: 'URCP_test',
+        name: 'test',
+        displayName: 'Test',
+        description: 'test recipe',
+        checks: { type: 'all', exclude: [] },
+        execution: { mode: 'sequential', stopOnFirstFailure: false, timeout: 30_000 },
+        reporting: { format: 'table', verbose: false },
+    };
+}
+function makeSession() {
+    return {
+        sessionId: 'SES_test',
+        recipe: makeRecipe(),
+        startedAt: new Date(),
+        status: 'running',
+        totalChecks: 1,
+        completedChecks: 0,
+        passedChecks: 0,
+        failedChecks: 0,
+        totalErrors: 0,
+        totalWarnings: 0,
+        totalIgnored: 0,
+        ignoresByTag: new Map(),
+        checkResults: [],
+        directives: [],
+    };
+}
+function makeProcessorContext(callbacks = {}) {
+    return {
+        session: makeSession(),
+        callbacks,
+        recipe: makeRecipe(),
+        includeViolations: true,
+    };
+}
+describe('runOneCheck — timeout-detection invariant (audit F7)', () => {
+    it('flags timedOut=true when the per-check timeout fires', async () => {
+        // Check sleeps longer than the recipe timeout; the local setTimeout
+        // aborts the controller, runOneCheck observes signal.aborted, and the
+        // outcome carries `timedOut: true`.
+        const slowAnalyze = vi.fn(async () => {
+            await new Promise((r) => setTimeout(r, 500));
+            return [];
+        });
+        const check = defineCheck({
+            id: uid(),
+            slug: 'slow',
+            description: 'slow',
+            tags: ['quality'],
+            analyzeAll: slowAnalyze,
+        });
+        const outcome = await runOneCheck(check, {
+            cwd: process.cwd(),
+            checkIndex: 1,
+            totalChecks: 1,
+            recipeTimeoutMs: 50,
+            retryEnabled: false,
+            maxRetries: 0,
+        }, makeProcessorContext());
+        expect(outcome.processOutput?.checkResult.timedOut).toBe(true);
+    });
+    it('reports a CheckAbortedError (retryResult.result === undefined, not a timeout) as a non-timeout error', async () => {
+        // defineCheck re-throws CheckAbortedError; executeWithRetry surfaces it as
+        // `{ result: undefined, lastError }` WITHOUT aborting runOneCheck's own
+        // controller. So runOneCheck takes the undefined-result error branch with
+        // `signal.aborted === false` → timedOut must be false (the timeout never
+        // fired). This is the branch that distinguishes "errored" from "timed out".
+        const aborting = vi.fn(() => {
+            throw new CheckAbortedError('aborted-check');
+        });
+        const check = defineCheck({
+            id: uid(),
+            slug: 'aborted-check',
+            description: 'throws CheckAbortedError',
+            tags: ['quality'],
+            analyzeAll: aborting,
+        });
+        const outcome = await runOneCheck(check, {
+            cwd: process.cwd(),
+            checkIndex: 1,
+            totalChecks: 1,
+            recipeTimeoutMs: 5000,
+            retryEnabled: false,
+            maxRetries: 0,
+        }, makeProcessorContext());
+        const cr = outcome.processOutput?.checkResult;
+        expect(cr).toBeDefined();
+        expect(cr?.passed).toBe(false);
+        expect(cr?.timedOut).toBe(false);
+        expect(cr?.error).toBeDefined();
+    });
+    it('catches a throw raised while processing a successful result (catch path)', async () => {
+        // The success path calls processSuccessResult, which invokes
+        // onCheckComplete. We make that callback throw ONLY on the success
+        // summary (passed === true); the throw escapes the try block and is
+        // handled by runOneCheck's catch, which re-dispatches to
+        // processErrorResult. Since the controller never aborted, the recovered
+        // result is reported as a non-timeout error.
+        const passing = vi.fn(() => Promise.resolve([]));
+        const check = defineCheck({
+            id: uid(),
+            slug: 'ok-but-callback-throws',
+            description: 'passes',
+            tags: ['quality'],
+            analyzeAll: passing,
+        });
+        const outcome = await runOneCheck(check, {
+            cwd: process.cwd(),
+            checkIndex: 1,
+            totalChecks: 1,
+            recipeTimeoutMs: 5000,
+            retryEnabled: false,
+            maxRetries: 0,
+        }, makeProcessorContext({
+            onCheckComplete: (_slug, summary) => {
+                if (summary.passed)
+                    throw new Error('callback exploded');
+            },
+        }));
+        const cr = outcome.processOutput?.checkResult;
+        expect(cr).toBeDefined();
+        // Callback errors raised from onCheckComplete during success processing are now
+        // swallowed inside processSuccessResult (to keep the check as a success for session
+        // counts and avoid double-counting). The error is only logged as a warning
+        // ('fitness.check.callback_error'). The returned processOutput remains the success one.
+        expect(cr?.timedOut).toBeUndefined();
+        expect(cr?.passed).toBe(true);
+        expect(cr?.error).toBeUndefined();
+    });
+    it('does NOT flag timedOut=true when the check completes well within the timeout', async () => {
+        // Pin the invariant: the only abort source on the per-check
+        // controller is the local setTimeout. A check that finishes promptly
+        // and does NOT abort must surface as a normal pass — never a
+        // timeout. If a future change wires an additional abort source into
+        // `checkAbortController`, an externally-aborted signal during this
+        // run would silently flip timedOut to true and break this test.
+        const fastAnalyze = vi.fn(() => Promise.resolve([]));
+        const check = defineCheck({
+            id: uid(),
+            slug: 'fast',
+            description: 'fast',
+            tags: ['quality'],
+            analyzeAll: fastAnalyze,
+        });
+        const outcome = await runOneCheck(check, {
+            cwd: process.cwd(),
+            checkIndex: 1,
+            totalChecks: 1,
+            recipeTimeoutMs: 5000,
+            retryEnabled: false,
+            maxRetries: 0,
+        }, makeProcessorContext());
+        const cr = outcome.processOutput?.checkResult;
+        expect(cr).toBeDefined();
+        expect(cr?.timedOut).not.toBe(true);
+        expect(cr?.passed).toBe(true);
+    });
+});
+//# sourceMappingURL=run-one-check.test.js.map

package/dist/recipes/__tests__/run-one-check.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"run-one-check.test.js","sourceRoot":"","sources":["../../../src/recipes/__tests__/run-one-check.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG;AAEH,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAElD,OAAO,EAAE,WAAW,EAAE,MAAM,iCAAiC,CAAC;AAC9D,OAAO,EAAE,iBAAiB,EAAE,MAAM,sCAAsC,CAAC;AACzE,OAAO,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAMlD,IAAI,MAAM,GAAG,CAAC,CAAC;AACf,SAAS,GAAG;IACV,MAAM,EAAE,CAAC;IACT,OAAO,2BAA2B,MAAM,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC,QAAQ,CAAC,EAAE,EAAE,GAAG,CAAC,EAAE,CAAC;AAC5E,CAAC;AAED,SAAS,UAAU;IACjB,OAAO;QACL,EAAE,EAAE,WAAW;QACf,IAAI,EAAE,MAAM;QACZ,WAAW,EAAE,MAAM;QACnB,WAAW,EAAE,aAAa;QAC1B,MAAM,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,EAAE,EAAE;QACpC,SAAS,EAAE,EAAE,IAAI,EAAE,YAAY,EAAE,kBAAkB,EAAE,KAAK,EAAE,OAAO,EAAE,MAAM,EAAE;QAC7E,SAAS,EAAE,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE;KAC/C,CAAC;AACJ,CAAC;AAED,SAAS,WAAW;IAClB,OAAO;QACL,SAAS,EAAE,UAAU;QACrB,MAAM,EAAE,UAAU,EAAE;QACpB,SAAS,EAAE,IAAI,IAAI,EAAE;QACrB,MAAM,EAAE,SAAS;QACjB,WAAW,EAAE,CAAC;QACd,eAAe,EAAE,CAAC;QAClB,YAAY,EAAE,CAAC;QACf,YAAY,EAAE,CAAC;QACf,WAAW,EAAE,CAAC;QACd,aAAa,EAAE,CAAC;QAChB,YAAY,EAAE,CAAC;QACf,YAAY,EAAE,IAAI,GAAG,EAAE;QACvB,YAAY,EAAE,EAAE;QAChB,UAAU,EAAE,EAAE;KACf,CAAC;AACJ,CAAC;AAED,SAAS,oBAAoB,CAAC,YAA2C,EAAE;IACzE,OAAO;QACL,OAAO,EAAE,WAAW,EAAE;QACtB,SAAS;QACT,MAAM,EAAE,UAAU,EAAE;QACpB,iBAAiB,EAAE,IAAI;KACxB,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,sDAAsD,EAAE,GAAG,EAAE;IACpE,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;QACpE,oEAAoE;QACpE,sEAAsE;QACtE,oCAAoC;QACpC,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE;YACnC,MAAM,IAAI,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,UAAU,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC,CAAC;YAC7C,OAAO,EAAE,CAAC;QACZ,CAAC,CAAC,CAAC;QACH,MAAM,KAAK,GAAG,WAAW,CAAC;YACxB,EAAE,EAAE,GAAG,EAAE;YACT,IAAI,EAAE,MAAM;YACZ,WAAW,EAAE,MAAM;YACnB,IAAI,EAAE,CAAC,SAAS,CAAC;YACjB,UAAU,EAAE,WAAW;SACxB,CAAC,CAAC;QAEH,MAAM,OAAO,GAAG,MAAM,WAAW,CAC/B,KAAK,EACL;YACE,GAAG,EAAE,OAAO,CAAC,GAAG,EAAE;YAClB,UAAU,EAAE,CAAC;YACb,WAAW,EAAE,CAAC;YACd,eAAe,EAAE,EAAE;YACnB,YAAY,EAAE,KAAK;YACnB,UAAU,EAAE,CAAC;SACd,EACD,oBAAoB,EAAE,CACvB,CAAC;QAEF,MAAM,CAAC,OAAO,CAAC,aAAa,EAAE,WAAW,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACjE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sGAAsG,EAAE,KAAK,IAAI,EAAE;QACpH,2EAA2E;QAC3E,wEAAwE;QACxE,0EAA0E;QAC1E,yEAAyE;QACzE,4EAA4E;QAC5E,MAAM,QAAQ,GAAG,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE;YAC1B,MAAM,IAAI,iBAAiB,CAAC,eAAe,CAAC,CAAC;QAC/C,CAAC,CAAC,CAAC;QACH,MAAM,KAAK,GAAG,WAAW,CAAC;YACxB,EAAE,EAAE,GAAG,EAAE;YACT,IAAI,EAAE,eAAe;YACrB,WAAW,EAAE,0BAA0B;YACvC,IAAI,EAAE,CAAC,SAAS,CAAC;YACjB,UAAU,EAAE,QAAQ;SACrB,CAAC,CAAC;QAEH,MAAM,OAAO,GAAG,MAAM,WAAW,CAC/B,KAAK,EACL;YACE,GAAG,EAAE,OAAO,CAAC,GAAG,EAAE;YAClB,UAAU,EAAE,CAAC;YACb,WAAW,EAAE,CAAC;YACd,eAAe,EAAE,IAAI;YACrB,YAAY,EAAE,KAAK;YACnB,UAAU,EAAE,CAAC;SACd,EACD,oBAAoB,EAAE,CACvB,CAAC;QAEF,MAAM,EAAE,GAAG,OAAO,CAAC,aAAa,EAAE,WAAW,CAAC;QAC9C,MAAM,CAAC,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC;QACzB,MAAM,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAC/B,MAAM,CAAC,EAAE,EAAE,QAAQ,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACjC,MAAM,CAAC,EAAE,EAAE,KAAK,CAAC,CAAC,WAAW,EAAE,CAAC;IAClC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0EAA0E,EAAE,KAAK,IAAI,EAAE;QACxF,6DAA6D;QAC7D,mEAAmE;QACnE,oEAAoE;QACpE,yDAAyD;QACzD,wEAAwE;QACxE,6CAA6C;QAC7C,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,CAAC;QACjD,MAAM,KAAK,GAAG,WAAW,CAAC;YACxB,EAAE,EAAE,GAAG,EAAE;YACT,IAAI,EAAE,wBAAwB;YAC9B,WAAW,EAAE,QAAQ;YACrB,IAAI,EAAE,CAAC,SAAS,CAAC;YACjB,UAAU,EAAE,OAAO;SACpB,CAAC,CAAC;QAEH,MAAM,OAAO,GAAG,MAAM,WAAW,CAC/B,KAAK,EACL;YACE,GAAG,EAAE,OAAO,CAAC,GAAG,EAAE;YAClB,UAAU,EAAE,CAAC;YACb,WAAW,EAAE,CAAC;YACd,eAAe,EAAE,IAAI;YACrB,YAAY,EAAE,KAAK;YACnB,UAAU,EAAE,CAAC;SACd,EACD,oBAAoB,CAAC;YACnB,eAAe,EAAE,CAAC,KAAK,EAAE,OAAO,EAAE,EAAE;gBAClC,IAAI,OAAO,CAAC,MAAM;oBAAE,MAAM,IAAI,KAAK,CAAC,mBAAmB,CAAC,CAAC;YAC3D,CAAC;SACF,CAAC,CACH,CAAC;QAEF,MAAM,EAAE,GAAG,OAAO,CAAC,aAAa,EAAE,WAAW,CAAC;QAC9C,MAAM,CAAC,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC;QACzB,gFAAgF;QAChF,oFAAoF;QACpF,2EAA2E;QAC3E,wFAAwF;QACxF,MAAM,CAAC,EAAE,EAAE,QAAQ,CAAC,CAAC,aAAa,EAAE,CAAC;QACrC,MAAM,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC9B,MAAM,CAAC,EAAE,EAAE,KAAK,CAAC,CAAC,aAAa,EAAE,CAAC;IACpC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8EAA8E,EAAE,KAAK,IAAI,EAAE;QAC5F,4DAA4D;QAC5D,qEAAqE;QACrE,6DAA6D;QAC7D,oEAAoE;QACpE,mEAAmE;QACnE,gEAAgE;QAChE,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,CAAC;QACrD,MAAM,KAAK,GAAG,WAAW,CAAC;YACxB,EAAE,EAAE,GAAG,EAAE;YACT,IAAI,EAAE,MAAM;YACZ,WAAW,EAAE,MAAM;YACnB,IAAI,EAAE,CAAC,SAAS,CAAC;YACjB,UAAU,EAAE,WAAW;SACxB,CAAC,CAAC;QAEH,MAAM,OAAO,GAAG,MAAM,WAAW,CAC/B,KAAK,EACL;YACE,GAAG,EAAE,OAAO,CAAC,GAAG,EAAE;YAClB,UAAU,EAAE,CAAC;YACb,WAAW,EAAE,CAAC;YACd,eAAe,EAAE,IAAI;YACrB,YAAY,EAAE,KAAK;YACnB,UAAU,EAAE,CAAC;SACd,EACD,oBAAoB,EAAE,CACvB,CAAC;QAEF,MAAM,EAAE,GAAG,OAAO,CAAC,aAAa,EAAE,WAAW,CAAC;QAC9C,MAAM,CAAC,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC;QACzB,MAAM,CAAC,EAAE,EAAE,QAAQ,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACpC,MAAM,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAChC,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/recipes/__tests__/service.test.d.ts

@@ -0,0 +1,11 @@
+/**
+ * @fileoverview Integration tests for FitnessRecipeService.
+ *
+ * Drives the full orchestration path (parallel/sequential execution,
+ * file cache prewarm, AST parse cache, directive application,
+ * disabled-checks filtering) against fixture projects so coverage
+ * reflects the orchestrator code, not just the per-check pure
+ * analyzer functions.
+ */
+export {};
+//# sourceMappingURL=service.test.d.ts.map

package/dist/recipes/__tests__/service.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"service.test.d.ts","sourceRoot":"","sources":["../../../src/recipes/__tests__/service.test.ts"],"names":[],"mappings":"AACA;;;;;;;;GAQG"}